[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paola Rossi from comment #9)
> I've applied the patches [13369,13370,13371] against 3.19.00.000
> 
> 'Item count' and 'Biblio count' didn't yet work:
> "No matching records found" (even if some records matched my search).

Weird, I don't have this problem.
What is the version of your browser?
Could you make a screenshot/screencast?

> NB1. A patron "Xa" of the library "Yb" had created the basket. In the
> "Created by" column of that basket I saw:
> XaYb (without spaces).
> I think that the value "Xa Yb" would be preferred; otherwise filtering "aY"
> would find that row (ERROR).

Hum, the "created by" column should only contain firstname + surname.

> NB2. On koha/acqui/acqui-home.pl I wrote nothing in vendor's field.
> Koha answered the default list of the vendor/baskets. It was:
> 
> You searched on vendor , 10 results found
> Show active and inactive baskets | Show opened baskets only
> Showing 1 to 6 of 6
>
> Was the result 10 or 6? 

Actually it's 10 vendors and 6 baskets.

> It's not so clear at once that the 4 missing baskets are the inactive ones.
> [I myself went early in confusion while I was testing, see below NB4.]
> Remember that on master the default is the complete list of vendors: if a
> vendor has only one inactive basket, the vendor is not listed at all!
> So the deault filter chosen in this bug:
> Show active and inactive baskets | Show opened baskets only
> didn't correspond to the current default of master.

Does my previous answer correct the confusion?

> NB3. Same search as NB2, on the empty-vendor list's answer.
> One vendor of mine was "inactive". But I saw it in the list of vendors.
> So an "inactive" basket is not the basket of an "inactive" vendor.
> So, I'm in doubt: what is an "inactive"/"active" basket?
> Some of the listed baskets had still expected items > 0: they're active,
> aren't they?
> But an open basket had 0 biblio, 0 items, 0 expected items: it was listed as
> active. Is it right?

A basket is considered as inactive if it is closed and no item is expected
(should not be different as before this patch set).
Before this patch, a "Show all baskets" existed. I have just renamed it, but
the behavior should be the same.

> NB4. On ACQ home, I saw for the table of funds:
> Hide inactive budgets | Show inactive budgets
> 
> Imho the use of the same kind of filters might perhaps be clearer:
> Show inactive baskets | Hide inactive baskets | Show closed baskets | Hide
> closed baskets

I am not sure. IMO it is more confusing.
But we could ask Owen what he thinks about it.

> NB5. In a closed basket, 1 item was ordered, 1 item was partial and 1 item
> was completely received.
> When I selected only the active baskets, the item count is 2.
> When both the active and inactive baskets were selected, the item count is 3.
> I'm in doubt: is it right?

It looks like a bug and it's certainly in master too.
Could you open a new bug report, describe the problem and assign it to me
please?

> NB6. "Expected items" might be preferred to "Items expected".

It does not come from this patch, it's the same string as before.
It could be fix on the QA step if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.