[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 33121
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33121
Bug 12252 - OAI-PMH items respect OpacHiddenItems

Review of attachment 33121:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12252&attachment=33121)
-----------------------------------------------------------------

::: C4/Biblio.pm
@@ +1263,5 @@
> +=item C<$embeditems>
> +
> +set to true to include item information.
> +
> +=item C<$opac>

This new parameter will be used in all opac scripts where we want to embed
items.

@@ +2928,5 @@
>      my @item_fields;
>      my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField( "items.itemnumber", $frameworkcode );
> +    my @items;
> +    my $opachiddenitems = $opac
> +      && ( C4::Context->preference('OpacHiddenItems') !~ /^\s*$/ );

It would have been better to use /\S/ to match the existing test.

::: opac/oai.pl
@@ +280,4 @@
>  
>      # We fetch it using this method, rather than the database directly,
>      # so it'll include the item data
> +    my $record = GetMarcBiblio($biblionumber, 1, 1);

We really want to avoid this kind of calls, it's not readable.

-- 
You are receiving this mail because:
You are watching all bug changes.