[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

--- Comment #58 from Frédéric Demians <frederic at tamil.fr> ---
Merci Jonathan pour les tests.  

> Lazily I tried with your host (coce.tamil.fr:8080), but it does not work.
> It seems that the browser blocks the request to other servers, which seems
> logical.
> Could you confirm or infirm that this worked for you?

Could you try rather with: http://coce.tamil.fr:8080

> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/svc/shelfbrowser.tt
> @@ +1,1 @@
> > +[% USE Koha %]

> Why do you added this line in this file (and not in shelfbrowser.inc)?

You're correct correct. It could be suppressed.

> ::: koha-tmpl/opac-tmpl/bootstrap/js/coce.js
> @@ +31,5 @@
> > +          var url = urlPerID[id];
> > +          $("[id^=coce-thumbnail]."+id).each(function() {
> > +            var img = document.createElement("img");
> > +            img.src = url;
> > +            img.title = url; //FIXME: to delete
> 
> Should be removed?

Well, good question. With that last line, it's possible to see immediately
where the image comes from by flying over it. In my opinion, this should be
kept now, and deleted later, or replaced by: img.title = id;

-- 
You are receiving this mail because:
You are watching all bug changes.