[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #55 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Marcel, all looks good to me but I have few questions:
1/ Could you please detail when the RESET mode should be used?

2/ ExecDBRev takes 5 parameters, but you use only 3, the idea is to call this
routine for each db rev in updatedatabase.pl?

3/ What means the $rv flag?

4/ Don't you think we should move the 2 files to skip into another directory
(and use this one exclusively for this use)?

5/

9691             $rv = 1 if !$! && !$@; #apparently, the file does not end with
1;

I tested with a file without 1; and I don't get any error.

6/ From http://perldoc.perl.org/functions/do.html, it seems that 
9690             print "ERROR: $!\n" if $!;
should be
9690             print "ERROR: $!\n" if $! and not $@;

7/ In TRACK mode, given the following file:
  1 use Modern::Perl;
  2 use C4::Context;
  3 my $dbh = C4::Context->dbh;
  4 $dbh->do("delete from foo");
I executed
  perl installer/data/mysql/updatedatabase.pl
and I got
DBD::mysql::db do failed: Table 'koha.foo' doesn't exist at
/home/koha/src/installer/data/mysql/atomicupdate/test3.pl line 4.
Dev upgrade test3.pl done

The filename is appended to _localatomicupdates, it seems it should not, could
you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.