[Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth()

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 34551
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34551
Bug 12954 - Questionable logic regarding session handling in
C4::Auth::checkauth()

Review of attachment 34551:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12954&attachment=34551)
-----------------------------------------------------------------

First comments, but nothing really important so far..

Still working my way through the logic for the second part

::: C4/Auth.pm
@@ +780,4 @@
>          }
>          elsif ( !$lasttime || ($lasttime < time() - $timeout) ) {
>              # timed logout
> +            $info{'timed_out'} = 1 if $lasttime;

This feels unrelated to me, as such I'de rather see it in it's own bug rather
than confusing the issue here.

-- 
You are receiving this mail because:
You are watching all bug changes.