[Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502

--- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> ---
This is because we do this

sub Check_Userid {
    my ( $uid, $borrowernumber ) = @_;

    return 1 unless ($uid);


And 1 means unique .. so we do Check_Userid ... it tells us, yes its unique .. 


This is wrong we should return 0 here. If it is empty, assume it is non unique.

This is a change in behaviour introduced by 1861.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.