[Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth()

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Any chance you could look at my alternative patch too Mark...  I would fail qa
on the first patch as it broke cross login attempt anonymous search history for
me.. which is a regression, I left it there initially so people could see the
difference between aproaches adn check whether I'de missed any fringe cases.

Test plan:
We need to test for the DBI error, and whether search history if maintained
accross the login/failed login boundary.

Before Patch:
Good username   / Good password = Login with history maintained
Good cardnumber / Good password = Login with history maintained
Good username   / Bad password  = DBI Error
Good cardnumber / Bad password  = DBI Error
Bad username    / Good password = DBI Error
Bad cardnumber  / Good password = DBI Error

After Patch:
Good username   / Good password = Login with history maintained
Good cardnumber / Good password = Login with history maintained
Good username   / Bad password  = Bad password error, anon search history
maintained
Good cardnumber / Bad password  = Bad password error, anon search history
maintained
Bad username    / Good password = Bad password error, anon search history
maintained
Bad cardnumber  / Good password = Bad password error, anon search history
maintained

-- 
You are receiving this mail because:
You are watching all bug changes.