From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:23:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 00:23:44 +0000 Subject: [Koha-bugs] [Bug 11659] New: Log Viewer does not parse export files correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11659 Bug ID: 11659 Summary: Log Viewer does not parse export files correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 24966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24966&action=edit Log Viewer's export file sample When trying to export log viewer's data the does not parse data correctly, neither TAB nor CSV format. It seems to export as MARC record format. See file attached. "Delimiter" syspreference option is set to "tab" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:24:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 00:24:16 +0000 Subject: [Koha-bugs] [Bug 11659] Log Viewer does not parse export files correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11659 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:28:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 00:28:04 +0000 Subject: [Koha-bugs] [Bug 11659] Log Viewer does not parse export files correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11659 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 04:32:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 03:32:31 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 04:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 03:32:35 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24096|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 24972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24972&action=edit Bug 10942: Provide a way for package upgrades to update template translations This patch adds a new config variable AUTOMATIC_TRANSLATIONS_UPDATE at /etc/default/koha-common that is used to control whether the upgrade process should trigger a $ koha-translate --update command for each installed template translation language. To test: - Have a koha-common setup with some languages installed (e.g. koha-translate --install es-ES) - Apply the patch and build a package for it. - Install it. - A new AUTOMATIC_TRANSLATIONS_UPDATE config variable should be in place at /etc/default/koha-common - Set AUTOMATIC_TRANSLATIONS_UPDATE to 'yes' - Re-install the package to trigger the post-install script - Verify that translations get updated. Edit: added a warning message for the case AUTOMATIC_TRANSLATIONS_UPDATE=no and there are translations installed (so they need to get updated). Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Works as advertised, default behaviour doesn't change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 04:36:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 03:36:15 +0000 Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 04:36:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 03:36:18 +0000 Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24965|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24973&action=edit Bug 11655: koha-translate --list shouldn't show 'en' 'en' is not a translation and it doesn't make any sense to return it as part of the installed translations or the available ones. It becomes relevant to remove it as users upgrading their installed translations end up grepping the output to remove 'en' like in: for lang in $(koha-translate --list | grep -v -x -e 'en') ; do koha-translate --update $lang done instead of simply issuing the koha-translate --list command. To test: - Run ./koha-translate --list ./koha-translate --list --available => It shouldn't return 'en' in the result list. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 09:47:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 08:47:39 +0000 Subject: [Koha-bugs] [Bug 11663] New: Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Bug ID: 11663 Summary: Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variable are not defined in template since opacbookbag is disabled. To reproduce this bug: - Choose bootstrap OPAC theme - Enable virtualsheves syspref - Disable opacbookbag syspref - Open a biblio record in OPAC detail page - You will observe that items holding tabs are not displayed as tabs but as a buletted list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 09:53:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 08:53:56 +0000 Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- Created attachment 24974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24974&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:38:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 20:38:14 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:38:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 20:38:18 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24950|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24977&action=edit Bug 11652: merging authority records does not correct biblios When merging authority records in librarian interface biblio records linked to deleted authority are not being corrected (i.e. have still old heading and orpaned link in $9). Test plan: 1. Have two authorities in the catalogue, linked to biblio records. 2. Merge them with the new merge facility (cf. Bug 5202). 3. Have a look a the biblio record(s) previously linked to the removed authority. It should still have the old heading AND orpaned authority link in $9. 4. Apply the patch. 5. Refresh the test records (or use another set). 6. Repeat 1-3. Headings should be refreshed and the correct authid link should be in $9 now. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:03:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 21:03:59 +0000 Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 21:04:03 +0000 Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24974|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24978&action=edit Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variables are not defined in template since opacbookbag is disabled. To reproduce this bug: - Choose bootstrap OPAC theme - Enable virtualsheves syspref - Disable opacbookbag syspref - Open a biblio record in OPAC detail page - You will observe that items holding tabs are not displayed as tabs but as a buletted list Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:07:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 21:07:33 +0000 Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Easy patches to sign off on, does everyone agree about the change in terminology? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:12:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 21:12:06 +0000 Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials needs user login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:12:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2014 21:12:10 +0000 Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials needs user login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24933|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24979&action=edit Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 04:52:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 03:52:12 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Records and items aren't interesting to the FBI in the same way patron data is. I can see that as a valid reason for deleting them completely. Perhaps a better response is to do a "Are you sure you want to delete permanently .. there is no way to get them back?" Confirmation prompt is a better way than disabling this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 10:58:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 09:58:08 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I agree with Chris - there are good reasons to offer a way to permanently delete patron information from the interface. Maybe we should also have a way to clean the deleted_borrowers table regularly on some conditions or at least delete the personal information in those records anonymizing them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 11:32:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 10:32:04 +0000 Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with accented Latin characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054 giuseppe.angilella at ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giuseppe.angilella at ct.infn. | |it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 11:59:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 10:59:11 +0000 Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your summary tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think "Waiting" should appear as a separate tab according to the test plan, but this is not working for me before AND after appyling the patch. The waiting holds always appear on the "Holds" tab. As I can't detect a regression, I am going to pass this. David, could you maybe take a look why that doesn't work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:01:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 11:01:16 +0000 Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your summary tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:01:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 11:01:19 +0000 Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your summary tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24951|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 24981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24981&action=edit [PASSED QA] Bug 11465 - Show counts and amounts on OPAC your summary tabs This patch adds counts and amounts to the tabs in the 'your summary' page of the OPAC patron account. _TEST PLAN_ Before applying: 1) Choose a test patron 2) Place a few holds 3) Check in one of the holds so that it is waiting for the patron 4) Check out a few items 5) Check out another item that can generate fines (backdate it a few weeks/months) 6) Run fines.pl to generate fines (make sure your finesmode syspref is set to prod) 7) Check your OPAC patron account. 8) Note the tabs "Checked out, Fines, Holds, and Waiting" Apply the patch 1) Switch your OPAC to the bootstrap theme 2) Refresh your browser for the OPAC patron account screen 3) Note that the applicable counts and amounts appear on the tabs -- At the moment, I just have a Bootstrap patch. This is an easy patch though, so I can duplicate to the other themes if necessary... Signed-off-by: Nicole C. Engard All tests on bootstrap pass Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer All tests and QA script pass. "Waiting" doesn't appear to work for me with and without the patch. "Checkouts", "Holds" and "Fines" work fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:13:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 11:13:24 +0000 Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials needs user login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hm, there is something that seems not quite right: 1) Searched for a subscription with patron notification active 2) Logged out of the OPAC 3) Subscribed to the patron notification - it showed the "subscribe" link 4) Logged out of the OPAC again 5) Subscription now always shows "cancel subscription", even when I open the page in another browser 6) Logging in with another user account, who hasn't subscribed the alert yet, I am still asked to unsubscribe instead of subscribing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:22:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 11:22:30 +0000 Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:22:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 11:22:33 +0000 Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24978|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24982&action=edit [PASSED QA] Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variables are not defined in template since opacbookbag is disabled. To reproduce this bug: - Choose bootstrap OPAC theme - Enable virtualsheves syspref - Disable opacbookbag syspref - Open a biblio record in OPAC detail page - You will observe that items holding tabs are not displayed as tabs but as a buletted list Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes QA script and all tests. Confirmed display problem exists without the patch and is solved by it. Ideally we would avoid having the cart messages in the template when the feature is deactivated, but this is ok for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:46:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 11:46:27 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #5 from Jacek Ablewicz --- (In reply to Chris Cormack from comment #1) > Is it deleting ones it shouldn't? Yes; I can replicate this as well. It will delete (or move to trash) ones it shouldn't. Evidently there is a problem with how given parameter borrower_dateexpiry is (not) being properly converted when passed from step2 to step3 in tools/cleanborrowers.pl - somehow this parameter value gets mangled in the process. In step2 this script does: $filterdate1 = format_date_in_iso( $params->{'filterdate1'} ); $filterdate2 = format_date_in_iso( $params->{'filterdate2'} ); $borrower_dateexpiry = format_date_in_iso( $params->{'borrower_dateexpiry'} ); ... $template->param( filterdate1 => format_date($filterdate1), filterdate2 => format_date($filterdate2), borrower_dateexpiry => $borrower_dateexpiry, Note there is no format_date() call on $borrower_dateexpiry in line #100.. Changing line 100 to borrower_dateexpiry => format_date($borrower_dateexpiry), seems to fix this issue (at least for me). But: my comprehension of date handling in Koha is very far from perfect; I can't really guarantee this would be a proper fix. I guess the exact outcome may also depend on 'dateformat' setting in I18N/L10N preferences (we use dd/mm/yyyy; for yyyy-mm-dd unpatched script may actually work seemingly fine!). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:49:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 11:49:05 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Janusz, I am working on this - could you check if merging 2 records from different frameworks works ok for you? I tried merging one "default" and "personal name" but the merge screen comes up empty? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:17:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 12:17:55 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #4 from Jacek Ablewicz --- Additionally, in EU countries - ability to permanently remove patron personal data from computer systems may be actually required by law, as mandated by EU Data Protection Directive 95/46/EC (to be replaced in 2016 by even more strict version). Aka: "Right to be Forgotten" (= personal data has to be deleted when the individual withdraws consent or the data is no longer necessary and there is no legitimate reason for an organization to keep it). AFAIK, interpretations, implementations and practical enforcement of this directive widely varies by country, but still - it will be better to have such functionality in the system, just to be on the safe side ;). But I agree it's perhaps too easy to destroy patron data by mistake using this tool. Maybe "Move these patrons to the trash" should be default option instead of "Permanently delete these patrons"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:39:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 12:39:24 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jcamins at cpbibliography.com --- Comment #4 from Katrin Fischer --- I am sorry, but this doesn't seem to work for me. I merged to person authority records, each linked to 2 records. After the merge, it only shows 2 linked records, while I think it should be 4. Adding Jared here cc as he is module maintainer for autorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:40:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 12:40:28 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 --- Comment #5 from Katrin Fischer --- Aha - wrote the last comment too soon - reindexing fixed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:41:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 12:41:42 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:41:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 12:41:46 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24977|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 24983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24983&action=edit [PASSED QA] Bug 11652: merging authority records does not correct biblios When merging authority records in librarian interface biblio records linked to deleted authority are not being corrected (i.e. have still old heading and orpaned link in $9). Test plan: 1. Have two authorities in the catalogue, linked to biblio records. 2. Merge them with the new merge facility (cf. Bug 5202). 3. Have a look a the biblio record(s) previously linked to the removed authority. It should still have the old heading AND orpaned authority link in $9. 4. Apply the patch. 5. Refresh the test records (or use another set). 6. Repeat 1-3. Headings should be refreshed and the correct authid link should be in $9 now. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. Note: new record count on the authority record will show after reindexing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:44:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 12:44:50 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 --- Comment #7 from Katrin Fischer --- Another note about comment 3: I think this might have been a data problem, retested with other records and it worked ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:54:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 12:54:46 +0000 Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to amount unallocated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I am failing to reproduce the problem, here is what I did: - My budget had 200,00 unallocated - I created a new fund with 200,00, it saved correctly - I tried editing the newly created fund, it also saved correctly Quite sure I am missing something - any hints? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:36:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:36:30 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:36:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:36:33 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24861|0 |1 is obsolete| | Attachment #24941|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 24984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24984&action=edit [PASSED QA] Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes QA script and tests. Small ergonomic improvement, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:36:55 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #11 from Katrin Fischer --- Created attachment 24985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24985&action=edit [PASSED QA] Bug 11625 [QA Followup] - Default to logged in library for circ rules and notices & slips Signed-off-by: Katrin Fischer Fixes the case that someone logs in as database user and changes circulation rules without explicitly selecting a library first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:39:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:39:47 +0000 Subject: [Koha-bugs] [Bug 11632] Untranslatable string "Remove" in patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Marking this duplicate to indicate that bug 11636 includes a fix for this. *** This bug has been marked as a duplicate of bug 11636 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:39:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:39:47 +0000 Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #4 from Katrin Fischer --- *** Bug 11632 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:51:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:51:26 +0000 Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:51:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:51:29 +0000 Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24905|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 24986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24986&action=edit [PASSED QA] Bug 11636 - Impossible to remove patrons from patron list during add process If you patrons have card numbers with leading zeroes this causes problems removing patron entries during the process of adding patrons to an existing list. This patch refactors the relevant JavaScript to correct the problem and to remove inline "onclick" from generated HTML. This patch also includes a fix for Bug 11632 - Untranslatable string "Remove" in patron lists. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Tools -> Patron lists. 3. Click "Add patrons" on an existing list. 4. Perform a patron search and choose one of the results. 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and test again. The "remove" link should now work. To test the fix for Bug 11632, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for patron_lists/list.tt. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script, works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:57:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:57:25 +0000 Subject: [Koha-bugs] [Bug 11664] New: No way to select all/unselect all on patron list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11664 Bug ID: 11664 Summary: No way to select all/unselect all on patron list Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: kyle at bywatersolutions.com On testing another patch I wondered why you can't select/unselect all patrons in a patron list to remove in batch. I think this would be a useful enhancement, as this seems to be the point of preferring checkboxes over a delete link. Also, why name the button "Update" when the purpose seems to always be deleting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:59:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 13:59:03 +0000 Subject: [Koha-bugs] [Bug 11664] No way to select all/unselect all on patron list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11664 --- Comment #1 from Katrin Fischer --- Hm, also sorting on the checkboxes in the first column doesn't seem to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 15:14:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 14:14:08 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Hi Mathieu, one small thing to fix: - When an order is not in a basket group, it displays empty parenthesis "()" and the link does not work. Please add a check. I also noticed that we display the branchcode instead of the branch name here - that could be easily fixed now using the TT plugin. If you want to you could add a follow up, but it can also be a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 15:52:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 14:52:21 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- I have problems in getting the search to work: Tested with MARC21: - Applied patch and copied file - Cataloged record Language-original = 041$h - Activated QueryParser - Waited for Zebra to reindex my newly added record - Searched for the unique content of 041$h as keyword search > Record was found - Searched for language-original:<041$h> > Record was not found I have no success in using the index explicitly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 15:58:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 14:58:08 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I am wondering if we really should get rid of the acquisition information when deleting an item. When an item is deleted, it's moved to deleted_items and can still be looked up for reporting purposes. It might also be interesting at that point to find out about the other history of the item, acquisition history included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 17:44:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 16:44:04 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 17:44:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 16:44:08 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24119|0 |1 is obsolete| | Attachment #24593|0 |1 is obsolete| | Attachment #24736|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 24987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24987&action=edit [PASSED QA] Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. Signed-off-by: Nicolas Bravais Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 17:44:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 16:44:25 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #25 from Katrin Fischer --- Created attachment 24988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24988&action=edit [PASSED QA] Bug 10851: FIX QA issues This patch fixes following warnings: FAIL C4/Serials.pm FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 17:44:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 16:44:36 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #26 from Katrin Fischer --- Created attachment 24989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24989&action=edit [PASSED QA] Bug 10851: (follow-up) FIX bad c/p (variable name) In catalogue.detail.tt, a wrong variable loop was used. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer APatches pass QA script and tests. Additional tests done: - Receiving issues, setting and unsetting new status - Display on serial summary page - Display on subscription detail page, issues tab - Display on OPAC and staff detail pages, subscription tab OPAC: ok Staff: ok - Claiming issues, filtering and status display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 19:24:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 18:24:43 +0000 Subject: [Koha-bugs] [Bug 11665] New: An ability to place orders directly from hold ratios list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Bug ID: 11665 Summary: An ability to place orders directly from hold ratios list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org This enhancement introduces a possibility to place orders from hold ratios list: - new option "Add order to basket" -> "From titles w/ highest hold ratios"; (user gets redirected from acqusition to "hold ratios" list in circulation) - "N to order" in "Items needed" column now becomes a link - when clicked, user gets redirected back to acquisition, directly to order form for a choosen title (suggested quantity "N to order" is being preserved) - in the "Items needed" column, there is an additional indication if there are any pending (not yet received) orders for a given title This solution is not exactly ideal.. most important drawback: to use it librarian needs both acquisition & circulation priviledges; if not having both - new options will not show / wouldn't be active. But it requires relatively small amount of changes in the code. To test: - apply patch, - test new functions (try to place some orders using an newly added option, examine resulting order records etc.) - check modified hold ratios list for possible problems (for user with only circulation priviledges, additional information regarding pending orders should be still visible, but not the link to order form) - ensure the two following existing options for adding orders to basket ("From an existing record", "From a new (empty) record") a still working properly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 19:36:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 18:36:52 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl |ity.org | --- Comment #1 from Jacek Ablewicz --- Created attachment 24990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24990&action=edit Bug 11665: An ability to place orders directly from hold ratios list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 20:07:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 19:07:18 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #61 from Katrin Fischer --- Starting with a code review on the squashed patch set: - Adds 2 new routines: * GetMessageTransportTypes * GetOverdueMessageTransportTypes - Database changes: * Adds a new table overduerules_transport_types * Adds a new column to letter - messgage_transport_type, email is default * Changes the primary key by adding message_transport_type to it: module code branchcode message_transport_type * Adds entries to overduerules_transport_types defaulting to email - New Javascript Library TODO: Add to the about page? - TODO: Translatability - I think the message transport types on the overdue notice triggers page are not translatable: + [% FOREACH mtt IN message_transport_types %] + [% mtt %] I will continue testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 21:24:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 20:24:24 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #44 from Doug Kingston --- (In reply to Katrin Fischer from comment #43) > I'd love to see this moving forward, but I am not sure how to fully test. So, this feature adds locking so that basically there can ever only be one instance of rebuild_zebra.pl running at any given time. Incremental updates in deamon try to obtain the lock and skip the current cycle if they cannot get the the lock. Other updates try to get the lock and block waiting for it to get free if its locked. Testing should check these behaviors. The flock testing program lets you apply the lock without having real conflicting updates. You can test using that to create conflicts or just use to instances of rebuild_zebra.pl as would happen for real. Using verbose mode you will get messages indicating if lock contention is detected. Cases to test: 1) 2 non-daemon invocations of a full rebuild; the second invocation should see the first has taken the lock and it should block until the first finishes. 2) daemon running and user starts a large full rebuild. Run the daemon mode incremental updater. Add or modify a record and make sure it gets updated. Then request a full rebuild while the daemon version is also running. Once the full rebuild has started, modify a record which will add an incremental update to the zebraqueue. You should see log messages from the daemon indicating that it is skipping the current pass as long as the full rebuild is still running. Does this help? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 22:20:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 21:20:31 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:14:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 22:14:52 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 --- Comment #16 from mathieu saby --- Created attachment 24991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24991&action=edit [PATCH] Bug 11027 (QA) : hide link if no basketgroup and use real branch name This patch is a answer to remarks made by QA: - if there is no basketgroup for an order, the basketgroup column in lastorders.pl is now blank (instead of parentheses) - the name of the branch is used instead of its code in the branch column To test: check late orders, included and not included into basketgroup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:15:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 22:15:04 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 22:15:51 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 --- Comment #17 from mathieu saby --- Katrin, I think you should be fine with the last patch. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:32:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 22:32:33 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #43 from mathieu saby --- I'm not sure of the origin of the conflict. I prefer to investigate a little more to avoid a mistake. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:49:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 22:49:56 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #44 from mathieu saby --- In fact the conflict was trivial ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:51:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 22:51:02 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24743|0 |1 is obsolete| | --- Comment #45 from mathieu saby --- Created attachment 24992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24992&action=edit [PATCH] Bug 10869: Allow the deletion of order line if the record is deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 00:09:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 23:09:01 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #4 from mathieu saby --- (In reply to Katrin Fischer from comment #3) > I am wondering if we really should get rid of the acquisition information > when deleting an item. When an item is deleted, it's moved to deleted_items > and can still be looked up for reporting purposes. It might also be > interesting at that point to find out about the other history of the item, > acquisition history included. Hello So you think a 'cancelled' status could be used for aqorders_items as well as for aqorders ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 00:11:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 23:11:09 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #46 from mathieu saby --- Marcel, I got a bad result with prove t/db_dependent/Acquisition.t # Failed test 'DelOrders delete items linked with cancelled order in aqorders_items table' # at t/db_dependent/Acquisition.t line 273. # got: '2' # expected: '0' # Looks like you failed 1 test of 67. t/db_dependent/Acquisition.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/67 subtests If I understand well, it is because, as you stated in your comment, aqorders_items is not cleared automaticaly by DelOrder, but will be when Bug 11617 is pushed. As Bug 11617 is not yet pushed, and Katrin raised an objection to it, I would prefer to put this one in Discussion, with status 'Blocked by Bug 11617'. Do you agree with that? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 00:28:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2014 23:28:15 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from mathieu saby --- The patch is clean, but to be applied on top of bug 11021 So, please test fist bug 11021. Both bugs can NOT be tested on a usual sandbox (because you have to check that the "installer" that fills Koha's database is working properly). Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 03:26:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 02:26:33 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Alexa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexa.gerancho at hushmail.com --- Comment #43 from Alexa --- *** Bug 260998 has been marked as a duplicate of this bug. *** Seen live from the domain http://volichat.com/adult-chat-rooms Marked for reference. Resolved as fixed @bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 04:36:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 03:36:35 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 --- Comment #18 from M. Tompsett --- Ran a variation on my test plan, and the branch name shows up, and there are no ()'s in the columns now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 04:37:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 03:37:30 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 04:37:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 03:37:34 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24991|0 |1 is obsolete| | --- Comment #19 from M. Tompsett --- Created attachment 24993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24993&action=edit [SIGNED OFF] Bug 11027 (QA) : hide link if no basketgroup and use real branch name This patch is a answer to remarks made by QA: - if there is no basketgroup for an order, the basketgroup column in lastorders.pl is now blank (instead of parentheses) - the name of the branch is used instead of its code in the branch column To test: check late orders, included and not included into basketgroup Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:44:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 05:44:45 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- The comments on bug 10465 say these fields don't exist in unimarc. That likely explains why I couldn't find any marcxml with tag="780" in it in my sample UNIMARC data. The patch eyeballs exactly like the OPAC portion of the bug 10465 patch for the prog. The directions were followed. System preferences were checked: opactheme (bootstrap), OPACXSLTDetailsDisplay (default), and OPACXSLTResultsDisplay (default). And master and patch applied versions both had identical "Normal View" and "MARC View" pages. http://www.ifla.org/publications/unimarc-formats-and-related-documentation Okay, no reference to 78X for biblio stuff. http://www.ifla.org/files/assets/uca/unimarc-authorities-format.pdf suggests they are used for authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:47:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 05:47:28 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:47:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 05:47:30 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22914|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 24994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24994&action=edit [SIGNED OFF] Bug 11246 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files for Bootstrap opac Another fix, 10465, removed fields 780 and 785 from a unimarc xslt file. This cleanup is needed for bootstrap too To test : in a UNIMARC Koha, with Bootstrap theme OPAC 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:54:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 05:54:40 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 --- Comment #5 from Katrin Fischer --- Maybe more a 'deleted' status to distinguish between orders being cancelled and items being deleted because of that and items being deleted from cataloguing? But this is just a thought, maybe it will make things too complicated and deleting is what people want? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:59:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 05:59:42 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 --- Comment #6 from Katrin Fischer --- Hm, thinking more about it, I think when cancelling an order the items are deleted and the order is marked as cancelled - do we really need to delete aqorders_items then? They would still refernece the original items and could be looked up in deleted_items. When the item is deleted later from cataloguing - would that currently touch the acquisitions data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:02:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 06:02:18 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- I tried just closing, applying the patch, and clicking the z39.50 search button. I think caching by the web browser messes it up. You really do need to run the test plan as given to get it to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:04:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 06:04:33 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24470|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 24995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24995&action=edit [SIGNED OFF] Bug 11572 - Keyword searches no longer detect isbn from "Search the catalog" In Koha 3.8, if a standard catalog search was performed and the user clicked the z39.50 search button, the search string would automatically be placed in the isbn field for the z39.50 search form. Changes to the code have since broken this functionality. Test Plan: 1) From mainpage.pl, use "Search the catalog" to search for the string "9781570672835" 2) Click the Z39.50 Search button 3) Note the string is placed in the title field 4) Apply this patch 5) Repeat steps 1-2 6) Note the string is placed in the isbn field Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:04:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 06:04:30 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:09:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 06:09:15 +0000 Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and MARC21 in some sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- I am wondering about NORMARC, RUSMARC, or other MARC variants which are more closely related to MARC21, but are not exactly MARC21. Is changing the MARC to MARC21 a good idea? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:10:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 06:10:29 +0000 Subject: [Koha-bugs] [Bug 11667] New: Hardcoded "Unknown" in suggestions management Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11667 Bug ID: 11667 Summary: Hardcoded "Unknown" in suggestions management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr If the suggestion status is not in SUGGEST_STATUS authorized values, the UI will show a tab with the untranslatable, hard-coded, text "Unknown": suggestion/suggestion.pl: return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown"; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:45:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 06:45:50 +0000 Subject: [Koha-bugs] [Bug 11434] in late order page only user with order_manage permission should be allowed to click on basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11434 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |mtompset at hotmail.com Resolution|--- |DUPLICATE --- Comment #2 from M. Tompsett --- I believe this is a poor duplicate of bug 11027, which has even more functionality. *** This bug has been marked as a duplicate of bug 11027 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:45:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 06:45:50 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 --- Comment #20 from M. Tompsett --- *** Bug 11434 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:06:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 07:06:55 +0000 Subject: [Koha-bugs] [Bug 11668] New: Untranslatable "Total" in borrowers stats report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668 Bug ID: 11668 Summary: Untranslatable "Total" in borrowers stats report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When saving borrowers_stats output into CSV, there will be hard-coded, untranslatable, "Total" and "TOTAL" texts. reports/borrowers_stats.pl: print "Total\n"; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:16:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 07:16:25 +0000 Subject: [Koha-bugs] [Bug 11668] Untranslatable "Total" in borrowers stats report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668 --- Comment #1 from paxed --- It would also be good to have the field names translatable (eg. "zipcode/branchcode" in the output) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:17:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 07:17:48 +0000 Subject: [Koha-bugs] [Bug 11667] Hardcoded "Unknown" in suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- I think this is a duplicate to a bug I filed and tried to solve a while ago - still have to find time to get back to it or at least split it up for a partial fix. *** This bug has been marked as a duplicate of bug 10519 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:17:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 07:17:48 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #16 from Katrin Fischer --- *** Bug 11667 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:56:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 07:56:15 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #10 from M. de Rooy --- (In reply to Katrin Fischer from comment #9) > I have problems in getting the search to work: > > Tested with MARC21: > - Applied patch and copied file > - Cataloged record Language-original = 041$h > - Activated QueryParser > - Waited for Zebra to reindex my newly added record > - Searched for the unique content of 041$h as keyword search > > Record was found > - Searched for language-original:<041$h> > > Record was not found > > I have no success in using the index explicitly. Thanks for testing, Katrin. I have to admit that my test plan should be reworded (see comment 7). Will do that in a minute. Sorry for any confusion about that.. Note that this report is about fixing the QueryParser config and it is not about searching on language-original. As long as this specific index is not in the field set of C4::Search::getIndexes, you will have no results (without QueryParser). But that is true for many more indexes in record.abs. Just mentioning a few indexes with the same behavior from the first few control fields: Microform-generation, Identifier-standard, BNB-card-number, BGF-number, Number-db, Number-natl-biblio, etc. So I feel that since this fixes QP, it should not be a reason to fail this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:00:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:00:41 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:00:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:00:44 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24752|0 |1 is obsolete| | --- Comment #11 from M. de Rooy --- Created attachment 24996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24996&action=edit Bug 11619: Duplicate key in QueryParser config Corrects a double entry for language in yaml file. Language should have been language-original. Test plan: Check that you have language-original in your zebra install. Specifically, this index should cover MARC21 041$h. Enable QueryParser and search for a record with this index. Note that this patch does not enable searching on this index without QueryParser. This is true for many more indexes in record.abs that are not included in the getIndexes routine. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:16:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:16:37 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #12 from Katrin Fischer --- Hi Jonathan, I understand that we have to list the index in Search.pm when not using the QueryParser. But now I am more confused as to why it didn't work in my test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:36:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:36:33 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #6 from Jonathan Druart --- Hello Marcel, This patch depends on bug 11555 and applies correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:37:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:37:45 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 --- Comment #7 from M. de Rooy --- (In reply to Jonathan Druart from comment #6) > Hello Marcel, > This patch depends on bug 11555 and applies correctly. OK Sorry, probably not seen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:43:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:43:52 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24897|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 24997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24997&action=edit Bug 11605: Fix regression Bug 11314 overrides the iDisplayLength and aLengthMenu values and should be kept. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:44:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:44:33 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24997|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 24998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24998&action=edit Bug 11605: default entry is 20 for all tables using datatables The default entry is 20 and can be apply to all tables. Bug 11555 apply the menu entries to all tables, redefining it is uesless and can be removed. Test plan: Test pages impacted by this patch and verify there is no regression on the tables. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:44:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:44:45 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 --- Comment #10 from Jonathan Druart --- Created attachment 24999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24999&action=edit Bug 11605: Fix regression Bug 11314 overrides the iDisplayLength and aLengthMenu values and should be kept. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:49:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:49:09 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #13 from M. de Rooy --- (In reply to Katrin Fischer from comment #12) > Hi Jonathan, I understand that we have to list the index in Search.pm when > not using the QueryParser. But now I am more confused as to why it didn't > work in my test? Katrin, I retested. If I enable QP and search on the index, I find the record with the search term in 041$h. If I disable QP, I do not find it. So please retest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:53:14 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #14 from Katrin Fischer --- Can you add the search term/query you used? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:54:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:54:50 +0000 Subject: [Koha-bugs] [Bug 7910] Batch renewal of serials and order creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:55:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:55:17 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #15 from M. de Rooy --- (In reply to Katrin Fischer from comment #14) > Can you add the search term/query you used? I just simply added dut in 041$h and search for language-original: dut -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:57:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 08:57:43 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #16 from Katrin Fischer --- Hm weird, I will retest. Jonathan, did you make any changes to the new patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:05:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 09:05:37 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > Hm weird, I will retest. Jonathan, did you make any changes to the new patch? No, I always mention when I amend a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:09:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 09:09:21 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:09:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 09:09:41 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kohapatch at gmail.com |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:39:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 09:39:27 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #12 from Jacek Ablewicz --- (In reply to mathieu saby from comment #11) > It is not working well, and most of all, improving the display of rrp and > ecost price on invoices is maybe a loss of time. > Mathieu, are you sure your last test was with the patches correctly applied? >From what I see, patched version is calculating & displaying unitcost (aka actual cost) on invoice page, just like it should - and there is an clear indication stating if given column is with, or without tax. We are currently testing those patches; so far with the good results for listincgst/invoiceincgst both yes/yes && no/no. Less usual combinations (no/yes, yes/no) might be a different story - I believe invoice.pl may need an additional small change like that: 185c185 > if ( $bookseller->{'invoiceincgst'} ) { --- < if ( $bookseller->{'listincgst'} ) { to behave properly for "no/yes" and "yes/no" (???). Anyway, handling prices for yes/no and no/yes combinations are apparently even more problematic in other places (like parcel.pl, basket.pl, .. - price calculations/display/column labeling etc. are not always working correctly in those other scripts - depending on the circumstances). I'm wondering if anyone is actually using such unusual combinations IRL? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:49:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 09:49:11 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #7 from M. de Rooy --- (In reply to Katrin Fischer from comment #3) > I am wondering if we really should get rid of the acquisition information > when deleting an item. When an item is deleted, it's moved to deleted_items > and can still be looked up for reporting purposes. It might also be > interesting at that point to find out about the other history of the item, > acquisition history included. Thanks for bringing that up, Katrin. In the current codebase deleteditems is actually only used in tools/export.pl. So like you mentioned, someone should use this connection in reporting. Note that this is (somewhat) theoretical, but possible. Koha currently removes the biblionumber from aqorders when a biblio is deleted (talking about removing acquisition history..) Does that make keeping the itemnumber in aqorders_items inconsistent? Or do we now stumble over the last way to retrieve the biblionumber still, via this itemnumber :) Also note that this discussion is in the scope of the AcqCreateItem pref. If you set that to Cataloging, you will have no itemnumbers at all in aqorders_items. That makes it a special table in the first place. The use of this table is more or less only relevant during the acquisition stage and no longer after ordering and receiving. With that in mind, I have a slight preference for cleaning up this table if an item is deleted. I will send a mail to the dev list and ask for some feedback. Setting to In Discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:09:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:09:48 +0000 Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:23:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:23:30 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 --- Comment #8 from Katrin Fischer --- I disagree with the assumption that the table is no longer interesting after the acquisition process is completed. The items tab where we added more and more information about acq is an example that libraries want to have these kind of information clearly visible. I also would say that an acquisiton process without items might be some kind of exception, but not the general rule right now. On the contrary I woudl argue that we should not remove the biblionumber on cancelling an order, as I can see no reason why this would be necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:29:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:29:58 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 --- Comment #9 from M. de Rooy --- (In reply to Katrin Fischer from comment #8) > On the contrary I woudl argue that we should not remove the > biblionumber on cancelling an order, as I can see no reason why this would > be necessary. If we keep the itemnumber, we should certainly keep the biblionumber too. Rather see a title (marked as deleted) instead of Deleted bibliographic notice, can't find title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:31:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:31:36 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24744|0 |1 is obsolete| | --- Comment #47 from M. de Rooy --- Created attachment 25000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25000&action=edit Bug 10869 Followup: Unit tests for DelOrder DelOrder now returns undef if no ordernumber passed. This patch also adds unit tests for DelOrder. Test plan: A. With syspref AcqCreateItem = on placing an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). New items linked with the order will be created 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders, and check the deletion of the order implies the deletion of items created when ordering a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). New items linked with the order will be created 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. B. With syspref AcqCreateItem = on receiving an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. And to test the UT: prove t/db_dependent/Acquisition.t Signed-off-by: Marcel de Rooy Amended the patch as to removing biblio parameter in DelOrder. There is no need to remove the parameter if you will search for biblionumber later on. I also suggest to handle the deletes in aqorders_items via constraint. Added a followup on report 11617 for that purpose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:32:19 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #48 from M. de Rooy --- Follow-up resubmitted to restore patch order. Will still answer previous comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:40:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:40:27 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25000|0 |1 is obsolete| | --- Comment #49 from M. de Rooy --- Created attachment 25001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25001&action=edit Bug 10869 Followup: Unit tests for DelOrder DelOrder now returns undef if no ordernumber passed. This patch also adds unit tests for DelOrder. Test plan: A. With syspref AcqCreateItem = on placing an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). New items linked with the order will be created 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders, and check the deletion of the order implies the deletion of items created when ordering a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). New items linked with the order will be created 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. B. With syspref AcqCreateItem = on receiving an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. And to test the UT: prove t/db_dependent/Acquisition.t Signed-off-by: Marcel de Rooy Amended the patch as to removing biblio parameter in DelOrder. There is no need to remove the parameter if you will search for biblionumber later on. Deleting records in aqorders_items is discussed on bug 11617. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:40:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:40:56 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #50 from M. de Rooy --- Updated the commit message of the second patch too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:49:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:49:39 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25001|0 |1 is obsolete| | --- Comment #51 from M. de Rooy --- Created attachment 25002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25002&action=edit Bug 10869 Followup: Unit tests for DelOrder DelOrder now returns undef if no ordernumber passed. This patch also adds unit tests for DelOrder. Test plan: A. With syspref AcqCreateItem = on placing an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). New items linked with the order will be created 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders, and check the deletion of the order implies the deletion of items created when ordering a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). New items linked with the order will be created 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. B. With syspref AcqCreateItem = on receiving an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. And to test the UT: prove t/db_dependent/Acquisition.t Signed-off-by: Marcel de Rooy Amended the patch as to removing biblio parameter in DelOrder. There is no need to remove the parameter if you will search for biblionumber later on. Deleting records in aqorders_items is discussed on bug 11617. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:55:05 +0000 Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:56:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 10:56:33 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25002|0 |1 is obsolete| | --- Comment #52 from M. de Rooy --- Created attachment 25003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25003&action=edit Bug 10869 Followup: Unit tests for DelOrder DelOrder now returns undef if no ordernumber passed. This patch also adds unit tests for DelOrder. Test plan: A. With syspref AcqCreateItem = on placing an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). New items linked with the order will be created 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders, and check the deletion of the order implies the deletion of items created when ordering a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). New items linked with the order will be created 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. B. With syspref AcqCreateItem = on receiving an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. And to test the UT: prove t/db_dependent/Acquisition.t Signed-off-by: Marcel de Rooy Amended the patch as to removing biblio parameter in DelOrder. There is no need to remove the parameter if you will search for biblionumber later on. Deleting records in aqorders_items is discussed on bug 11617. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:10:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 11:10:27 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #53 from M. de Rooy --- (In reply to mathieu saby from comment #46) > If I understand well, it is because, as you stated in your comment, > aqorders_items is not cleared automaticaly by DelOrder, but will be when Bug > 11617 is pushed. Yes. For now I removed this one test from your patch. It still checks in items, no longer in aqorders_items. Note that if there would be a cascaded delete, I think we should not have to check MySQL functionality either. So the test is no longer needed. > As Bug 11617 is not yet pushed, and Katrin raised an objection to it, I > would prefer to put this one in Discussion, with status 'Blocked by Bug > 11617'. Strictly speaking, they can be handled independently now. But the discussion on bug 11617 made me think somewhat more about it. If the user wants to delete an order, it is actually obvious that he wants to delete records in aqorders_items too. You did in the former version (and I moved it to another report :) But in the meantime we are now only deleting the real item records here. And the question is: Did the user understand that, and should he have the possibility to not remove the items (so only the order and aqorders_items)? Should we add two options: Delete order / Delete order and items. Note that Delete order and catalog record (or biblio) should obviously include items. BTW Would biblio record be a better description than catalog record in the second [or third] option? You can also misread it as follows now: First delete the order and then catalog [read: edit] the record. When you say biblio record, it is a noun and no verb. Sorry for all these comments.. ;) Setting to In Discussion, as you suggested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:16:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 11:16:39 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #54 from M. de Rooy --- The questions on order level actually pertain to basket level also. If we delete a basket, we do warn the user that he will lose his items. But he does not have a choice between "Delete basket and orders" and "Delete baskets, orders and items". Is this getting too complicated now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:35:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 11:35:34 +0000 Subject: [Koha-bugs] [Bug 11669] New: Allow setting 008 builder MARC country/language code URLs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11669 Bug ID: 11669 Summary: Allow setting 008 builder MARC country/language code URLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The MARC21 008 builder has URLs that point to loc.gov - lists of country and languages codes. The URLs should be configurable, as the loc.gov lists are only in English. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:36:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 11:36:29 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19263|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 25004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25004&action=edit Bug 5771 : Adds a download link for big error reports to import_borrowers If the import patrons tools produced a lot of errors(e.g. 1000), the browser will crash or not be glad. This patch allow to download an error file for report producing at least 25 errors. Test plan: Import patrons with at least 25 errors and check that a "Download report" button appears and produce a text file to download. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 11:38:07 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 --- Comment #16 from Jonathan Druart --- (In reply to Holger Mei?ner from comment #14) > The download button appears and a text file can be downloaded. But it only > contains some kind of reference? See screenshot. Thanks for testing! The last patch should fix that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 12:18:46 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #64 from Jonathan Druart --- Created attachment 25005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25005&action=edit Bug 11202: FIX UT for QueryParser.t Test plan: prove t/QueryParser.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:17:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 13:17:36 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #62 from Jonathan Druart --- Created attachment 25006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25006&action=edit Bug 9016: Fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:18:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 13:18:58 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #63 from Jonathan Druart --- (In reply to Katrin Fischer from comment #61) > - TODO: Translatability - I think the message transport types on the overdue > notice triggers page are not translatable: > > + [% FOREACH mtt IN message_transport_types %] > + [% mtt %] Last patch fixes that. Thanks for the catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:43:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 15:43:33 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- (In reply to M. de Rooy from comment #9) > (In reply to Katrin Fischer from comment #8) > > On the contrary I woudl argue that we should not remove the > > biblionumber on cancelling an order, as I can see no reason why this would > > be necessary. > If we keep the itemnumber, we should certainly keep the biblionumber too. > Rather see a title (marked as deleted) instead of Deleted bibliographic > notice, can't find title. It's a pity not having the foreign key constraints, but on balance there's too much potential need for library staff to need to refer to both ordered bibs and items for a period of time, even after the items or bibs are deleted in cataloging. This is going a bit far off, but I think we should consider adding a Boolean "is deleted" flag to biblio and items, to represent the case where an item or bib no longer is held by the library but is still referred to by other records that need to be kept for some archival purpose. This would make us more free to add FK constraints, at the cost of needing more code to distinguished between a merely deleted and a fully purged bib or item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:27:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 16:27:31 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #51 from Kyle M Hall --- Created attachment 25008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25008&action=edit Bug 9303 [QA Followup 2] - Undo changes to GetReserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:42:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 16:42:25 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #52 from Kyle M Hall --- (In reply to Katrin Fischer from comment #37) > ::: C4/Reserves.pm > @@ +270,5 @@ > > + $sth->execute($reserve_id); > > + $res = $sth->fetchrow_hashref(); > > + } > > + > > + carp("No hold for for reserve_id $reserve_id") unless $res; > > Hm, this change seems unrelated to the bug description? Yep, looks like an accidental commit. I added another followup to revert that code change. > ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt > @@ +1168,5 @@ > > + > > + [% END %] > > + > > +
Allow linked patron accounts to view this patron's checkouts from the OPAC
> > + > > This is different to how we handle the other privacy seetings in that we > don't allow staff to change those for a patron. I see why staff will want to > change that setting for a parent requesting it, but at the same time it > bothers me a bit. This is a specific requirement of the sponsor, specifically so that a guarantor can request to be able to view a guaranteed accounts checkouts without the need to log into the opac as that guaranteed patron to make the change. This option can easily be hidden via jquery if needed. > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt > @@ +1,3 @@ > > [% USE Koha %] > > [% USE KohaDates %] > > +[% USE EncodeUTF8 %] > > The only script using this so far is renew.pl - can you explain a bit? This is a simple filter plugin that encodes the given variable to utf8. It addresses some of the encoding issues we have in Koha. Right now our encoding of data to utf is mixed in throughout the code base when it really should be at one of two places, the very beginning ( e.g. database queries ) or at the very end ( e.g. template output ). This plugin allows us to handle utf8 encoding from the very end of the output chain. In fact, it would be even better if we could configure Koha's TT to filter every value though this filter before outputting. At this time however, I have been unable to find a way to do so. I'm certain we could do this by extending Template::Parser but I'm not sure if we want to go that far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:51:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 16:51:15 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #18 from M. de Rooy --- (In reply to Katrin Fischer from comment #16) > Hm weird, I will retest. Jonathan, did you make any changes to the new patch? Please do not forget to copy the queryparser.yaml to your zebra install. You could restart Zebra but I do not think that it was necessary. Edit a record after that and search.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:57:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 16:57:27 +0000 Subject: [Koha-bugs] [Bug 11670] New: Remove sorting from patron lists action columns Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Bug ID: 11670 Summary: Remove sorting from patron lists action columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The table that lists patron lists has sortable columns for add, edit, and delete buttons. These columns should not be sortable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:06:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 17:06:16 +0000 Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:06:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 17:06:18 +0000 Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 --- Comment #1 from Owen Leonard --- Created attachment 25009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25009&action=edit Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:15:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 17:15:35 +0000 Subject: [Koha-bugs] [Bug 11671] New: Restructure patron lists add form for improved usability Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Bug ID: 11671 Summary: Restructure patron lists add form for improved usability Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/patron_lists/list.pl?patron_list_id= OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I think it's a potential usability problem that the patron lists "add patron" form has a duplicated submit button. Having one button placed at the top next to the add function implies that this button might be *only* submitting the new patrons, not the deletions which could be triggered by having checked a checkbox. I think the process of adding a patron should trigger the display of an "add" submit button which only submits the additions, not any deletions. The button at the bottom of the list should be clearly labeled and only submit deletions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:56:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 17:56:54 +0000 Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648 --- Comment #5 from Fridolin SOMERS --- (In reply to Chris Cormack from comment #4) > Easy patches to sign off on, does everyone agree about the change in > terminology? It has been started with Bug 10346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:34:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:34:05 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:34:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:34:08 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 --- Comment #1 from Owen Leonard --- Created attachment 25010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25010&action=edit Bug 11671 - Restructure patron lists add form for improved usability Non-standard interface features have the potential to cause confusion. This patch brings various aspects of the patron lists add page into conformity with other staff client pages. - Add "select all/clear all" links for the checkboxes - Add a "remove selected" to the top of the table (see also Lists) - Split functionality of add from from delete form - Hide "Add patrons" button until at least one patron has been selected - Remove non-standard trash can icon from table's checkbox column - Exclude checkbox column from table sorting - Add confirmation to deletion actions - Improve breadcrumb specificity - Add title-string sorting to date column to accommodate sorting for all date format types To test, apply the patch and create a patron list. 1. Search for and select patrons for the list. Selecting a patron should trigger the display of an "Add patrons" button. 2. Click "Add patrons" and confirm that the add process completes correctly. 3. Search for and select a patron and also check the box next to an existing patron. Click "Add patrons" and confirm that no patron is removed. 4. Check that the "select all" and "clear all" links work correctly. 5. Select patrons on the list and click the "Remove selected" link. You should be prompted to confirm your choice. 4.a. Click cancel and confirm that the deletion process aborts. 4.b. Click OK and confirm that the deletion process completes. 6. Repeat step 4 with the "Remove selected patrons" at the bottom of the page. 7. Confirm that the page title and breadcrumbs correctly show the list name. 8. Switch between us and metric dateformat settings and confirm that table sorting by date is correct in both cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:35:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:35:35 +0000 Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Not a native speaker - but using consistent terminology helps translators :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:42:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:42:49 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25010|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 25011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25011&action=edit Bug 11671 - Restructure patron lists add form for improved usability Non-standard interface features have the potential to cause confusion. This patch brings various aspects of the patron lists add page into conformity with other staff client pages. - Add "select all/clear all" links for the checkboxes - Add a "remove selected" to the top of the table (see also Lists) - Split functionality of add from from delete form - Hide "Add patrons" button until at least one patron has been selected - Remove non-standard trash can icon from table's checkbox column - Exclude checkbox column from table sorting - Add confirmation to deletion actions - Improve breadcrumb specificity - Add title-string sorting to date column to accommodate sorting for all date format types To test, apply the patch and create a patron list. 1. Search for and select patrons for the list. Selecting a patron should trigger the display of an "Add patrons" button. 2. Click "Add patrons" and confirm that the add process completes correctly. 3. Search for and select a patron and also check the box next to an existing patron. Click "Add patrons" and confirm that no patron is removed. 4. Check that the "select all" and "clear all" links work correctly. 5. Select patrons on the list and click the "Remove selected" link. You should be prompted to confirm your choice. 4.a. Click cancel and confirm that the deletion process aborts. 4.b. Click OK and confirm that the deletion process completes. 6. Repeat step 4 with the "Remove selected patrons" at the bottom of the page. 7. Confirm that the page title and breadcrumbs correctly show the list name. 8. Switch between us and metric dateformat settings and confirm that table sorting by date is correct in both cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:43:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:43:52 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11636 --- Comment #3 from Owen Leonard --- Should have made this dependent on Bug 11636 since they conflict. Resubmitted and added the dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:43:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:43:52 +0000 Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11671 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:46:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:46:31 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:46:35 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24851|0 |1 is obsolete| | Attachment #24852|0 |1 is obsolete| | Attachment #24993|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 25012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25012&action=edit [PASSED QA] Bug 11027 : Add a column for basketgroups in late orders table and improve other columns This patch makes 4 changes in late orders page : - adding a new column for basketgroup, displaying the name and number of the basketgroup - displaying the name of the basket as well as its number, with a hyperlink to this basketgroup - displaying fund in a separate column to make sorting easier, and renaming it from "budget" to "fund" (the confusion can be found elsewhere in Koha...) - displaying branch in a separate column to make sorting easier (this column could be improved later, by getting branch from basketgroup if there is one) For that, in Aquisition.pm, I made some changes to GetLateOrders: - 3 new columns in SELECT - 1 new join To test : 1. Display the list of late orders of your instance. 2. Check you have 3 new columns for basketgroups, fund and branch 3. In basketgroup column you should have "name of basket group (number)" 4. In basket column you should have "name of basket (number)" 5. Check the links for basketgroups. They should send you to the page displaying information for each basketgroup (without possibiliy of editing them if they are closed) Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Patches pass QA script and all tests. Works as described. Also checked sorting and orders which are not in a basketgroup display correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:46:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:46:48 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 --- Comment #22 from Katrin Fischer --- Created attachment 25013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25013&action=edit [PASSED QA] Bug 11027 - Create a link only if user have required permissions With this followup, a user without order_manage permission won't be able to cick on a basket and a user without group_manage permission won't be able to click on a basketgroup Note that the issue for basket is present in current master. So it deserves a separate bugfix (as bug 11027 is an ENH) Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:46:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 19:46:59 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 --- Comment #23 from Katrin Fischer --- Created attachment 25014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25014&action=edit [PASSED QA] Bug 11027 (QA) : hide link if no basketgroup and use real branch name This patch is a answer to remarks made by QA: - if there is no basketgroup for an order, the basketgroup column in lastorders.pl is now blank (instead of parentheses) - the name of the branch is used instead of its code in the branch column To test: check late orders, included and not included into basketgroup Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:05:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 20:05:30 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:05:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 20:05:33 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24994|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 25015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25015&action=edit [PASSED QA] Bug 11246 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files for Bootstrap opac Another fix, 10465, removed fields 780 and 785 from a unimarc xslt file. This cleanup is needed for bootstrap too To test : in a UNIMARC Koha, with Bootstrap theme OPAC 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Changes are consistent with changes done earlier on the prog theme. Checked that the detail pages and results still display correctly for UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:31:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 20:31:08 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #19 from Katrin Fischer --- It still doesn't work in my test installation: - Checked that the file was copied correctly - Checked my koha-conf.xml for the QueryParser line. /home/katrin/koha-dev/etc/searchengine/queryparser.yaml - Checked QueryParser is activated. - Keyword search finds my 041$h result. - language-original:dedede doesn't. - Changed the record to have 'dut' instead. - Reindexed with -z - Keyword search finds dut. - language-original:dut gives no result. - No errors in my koha-opac-error_log. Marcel, does the space make a difference for you? language-original: dut vs. language-original:dut? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:38:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 20:38:52 +0000 Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to amount unallocated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644 --- Comment #5 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > I am failing to reproduce the problem, here is what I did: > - My budget had 200,00 unallocated > - I created a new fund with 200,00, it saved correctly > - I tried editing the newly created fund, it also saved correctly > > Quite sure I am missing something - any hints? I wish I had some hints to give you! I had to debug this on a production system. I tried to come up with the best way to reproduce the issue I could. It may even be that you'd be unable to reproduce the error on a different system, as this may have something to do with Perl versions. Can you at least verify the patch does not cause any regressions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:42:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 20:42:57 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #20 from Katrin Fischer --- *sigh* outdated index configuration... works alright now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:44:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 20:44:01 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:44:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 20:44:06 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24996|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 25016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25016&action=edit [PASSED QA] Bug 11619: Duplicate key in QueryParser config Corrects a double entry for language in yaml file. Language should have been language-original. Test plan: Check that you have language-original in your zebra install. Specifically, this index should cover MARC21 041$h. Enable QueryParser and search for a record with this index. Note that this patch does not enable searching on this index without QueryParser. This is true for many more indexes in record.abs that are not included in the getIndexes routine. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Works as described - make sure you are testing with a current indexing configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:05:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 21:05:28 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 21:05:32 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24995|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 25017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25017&action=edit [PASSED QA] Bug 11572 - Keyword searches no longer detect isbn from "Search the catalog" In Koha 3.8, if a standard catalog search was performed and the user clicked the z39.50 search button, the search string would automatically be placed in the isbn field for the z39.50 search form. Changes to the code have since broken this functionality. Test Plan: 1) From mainpage.pl, use "Search the catalog" to search for the string "9781570672835" 2) Click the Z39.50 Search button 3) Note the string is placed in the title field 4) Apply this patch 5) Repeat steps 1-2 6) Note the string is placed in the isbn field Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Tested old and new ISBN with and without hyphens. Also tested some other keyword searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 21:27:46 +0000 Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hi Kyle, 2 things: - Can you please move the syspref so the alphabetic order is correct? - Are you very attached to the around the not for loan values in the librarian message? It breaks the string into pieces in translation: msgid "Not for loan status updated from " And somewhere a 'to' I was too lazy to locate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2014 21:31:00 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #53 from Katrin Fischer --- Hi Kyle, as this is a data privacy relevant feature jQuery would not suffice to hide as it would still be possible to just turn Javasript off to change the setting. But that's just a note - I am going to test again ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 06:23:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 05:23:30 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #54 from Heather Braum --- Katrin, just to help in the explanation, since Kyle mentioned the sponsor requirement in his most recent comment back to you: I represent the organization that is sponsoring this development and since we requested the additional setting on the staff side to be able to turn this feature on and off through a borrower account, we are having to do this, because if you have the sys pref OPACPrivacy set to Don't Allow (which we have), patrons have no ability to even turn this new feature on/off in an OPAC account (if I remember correctly from our testing a few months ago). We have that sys pref turned off because it currently wrecks havoc on checkout history links for items if patrons "opt-out" of checkout history being left. In a consortia of 42 libraries with materials going everywhere, we have to have that checkout history to track down materials. Additionally, if you have a guarantor with 2 or more kids, it's much easier for this feature to be turned on from the staff side as well -- instead of having to log into each guarantee's account to turn this feature on. We thought adding the ability to turn this on and off from the staff side would actually help out patrons. I understand the privacy concerns -- we have them too -- and I'll let you all continue to sort this out, but I wanted to explain where we're coming from as the sponsor of this development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 06:38:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 05:38:44 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #55 from Katrin Fischer --- Hi Heather, thank you for taking the time to explain. I understand why it makes sense to have the option in the patron account. I might be a bit overly careful at times as we are quite strict with data privacy here. I just couldn't resist to point out that jQuery won't be a solution if you might not be allowed to use this feature for privacy concerns. There is no staff permission and no pref to turn it totally off currently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 07:57:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 06:57:08 +0000 Subject: [Koha-bugs] [Bug 11672] New: Untranslatable report areas in step 1 of Guided Reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Bug ID: 11672 Summary: Untranslatable report areas in step 1 of Guided Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The guided reports UI shows a drop-down box with "Circulation", "Catalogue", etc. These are hard-coded in C4/Reports/Guided.pm (the @REPORT_AREA hash) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 07:58:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 06:58:31 +0000 Subject: [Koha-bugs] [Bug 11673] New: columns.def has swapped last and first name of alt contact Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11673 Bug ID: 11673 Summary: columns.def has swapped last and first name of alt contact Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org borrowers.altcontactfirstname Alternate contact: Last name borrowers.altcontactsurname Alternate contact: First name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:50:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 07:50:07 +0000 Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to amount unallocated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644 --- Comment #6 from Katrin Fischer --- Ok, I can do regression testing, it might take a bit - busy week. If someone else beats me to it that's ok of course :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:27:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 09:27:27 +0000 Subject: [Koha-bugs] [Bug 11674] New: Configuration for MARC field doc URLs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Bug ID: 11674 Summary: Configuration for MARC field doc URLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When adding a MARC record, the MARC21 field documentation is hard-coded to go to www.loc.gov - The URL(s) should be configurable, to allow non-English documentation. Same applies to UNIMARC field docs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:57:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 09:57:10 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #20 from Katrin Fischer --- Robin, could you take a look at comment 9 from Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:48:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 10:48:19 +0000 Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:48:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 10:48:23 +0000 Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24973|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25018&action=edit Bug 11655: koha-translate --list shouldn't show 'en' 'en' is not a translation and it doesn't make any sense to return it as part of the installed translations or the available ones. It becomes relevant to remove it as users upgrading their installed translations end up grepping the output to remove 'en' like in: for lang in $(koha-translate --list | grep -v -x -e 'en') ; do koha-translate --update $lang done instead of simply issuing the koha-translate --list command. To test: - Run ./koha-translate --list ./koha-translate --list --available => It shouldn't return 'en' in the result list. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:55:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 10:55:32 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25004|0 |1 is obsolete| | --- Comment #17 from Holger Mei?ner --- Created attachment 25019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25019&action=edit Bug 5771 : Adds a download link for big error reports to import_borrowers If the import patrons tools produced a lot of errors(e.g. 1000), the browser will crash or not be glad. This patch allow to download an error file for report producing at least 25 errors. Test plan: Import patrons with at least 25 errors and check that a "Download report" button appears and produce a text file to download. Signed-off-by: Holger Mei?ner -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 10:56:52 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:13:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:13:41 +0000 Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to amount unallocated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- What is the error and what was the amount used? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:35:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:35:42 +0000 Subject: [Koha-bugs] [Bug 11675] New: Budget amount is not checked if a parent exist Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11675 Bug ID: 11675 Summary: Budget amount is not checked if a parent exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:37:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:37:08 +0000 Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to amount unallocated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11675 --- Comment #8 from Jonathan Druart --- I found bug 11675 on testing this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:37:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:37:08 +0000 Subject: [Koha-bugs] [Bug 11675] Budget amount is not checked if a parent exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11675 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11644 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:37:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:37:24 +0000 Subject: [Koha-bugs] [Bug 11675] Budget amount is not checked if a parent exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11675 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:37:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:37:28 +0000 Subject: [Koha-bugs] [Bug 11675] Budget amount is not checked if a parent exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11675 --- Comment #1 from Jonathan Druart --- Created attachment 25020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25020&action=edit Bug 11675: Budget total is not checked if a parent exists The sth is created before the query. The query was modified after the sth creation and an error was raised. Test plan: 0/ Don't apply the patch 1/ Create a budget A (amount=1000) 2/ Create a fund A1 (amount=1000) 3/ Create a child fund A11 (amount=1000) 4/ Edit A11 and change the amount to 2000 You are able to do it, an error appears in the Koha log: "check_parent_total.pl: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed" 5/ Apply the patch, edit A11 and save. You get an error 6/ Edit A11 and change the amount to <=1000 7/ Verify that there is no regression on adding/removing/editing budgets and funds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:37:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:37:45 +0000 Subject: [Koha-bugs] [Bug 11676] New: Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Bug ID: 11676 Summary: Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl ------------ - SYNOPSIS - ------------ When editing items, the shelving locations list does not reflect the shelving locations available for the home branch of the editable item? So if you are editing an item in another branch than the item's homebranch, you have a set of different/wrong shelving locations for the item you are editing, based on the branch where you are logged into, not the item you are editing. This is problematic when we receive and catalog items centrally and then transport them to other libraries. Changing the item editing behaviour to get the available shelving locations based on the item's homebranch instead of the users logged in library. ---------- - DESIGN - ---------- -When loading the koha/cataloguing/additem.pl?op=edititem, check if the item's homebranch exists and load the available shelving locations for the homebranch. -After changing "Permanent location", load new shelving locations based on the homebranch using an AJAX query. ---Only touch the elements to be as unintrusive as possible. -When javascript is disabled, this feature only loads the available shelving locations on page load. ----------------- - IN DISCUSSION - ----------------- -Can this feature be on by default or do we need Yet.Another.System.Preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:37:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:37:59 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:38:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 11:38:08 +0000 Subject: [Koha-bugs] [Bug 11675] Budget amount is not checked if a parent exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11675 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:29:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 12:29:52 +0000 Subject: [Koha-bugs] [Bug 11677] New: Limit to Only items currently available for loan or reference not working! Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Bug ID: 11677 Summary: Limit to Only items currently available for loan or reference not working! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The ability to limit a search to only available items does not seem to be working as expected. Sometimes records with available items are not included in the results. Example: http://screencast.com/t/OVgYybzLE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:39:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 12:39:22 +0000 Subject: [Koha-bugs] [Bug 5958] Availability Limit with icu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5958 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11677 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:39:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 12:39:22 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:19:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 13:19:25 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #22 from M. de Rooy --- (In reply to Katrin Fischer from comment #20) > *sigh* outdated index configuration... works alright now :) Thanks for your perseverance :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:08:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:08:04 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11609 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:08:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:08:04 +0000 Subject: [Koha-bugs] [Bug 11609] organize suggestions by library doesn't appear to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11603 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:08:20 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11609 |11209 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:08:20 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11603 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:08:20 +0000 Subject: [Koha-bugs] [Bug 11609] organize suggestions by library doesn't appear to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11603 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:11:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:11:07 +0000 Subject: [Koha-bugs] [Bug 11678] New: Gather print notices: send files by email Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Bug ID: 11678 Summary: Gather print notices: send files by email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 11603 allows to generate 3 types of files: html, csv and ods. This patch will add a --email parameter in order to send the generated files by email. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:11:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:11:20 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11678 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:11:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:11:20 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11603 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:14:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:14:03 +0000 Subject: [Koha-bugs] [Bug 11679] New: Add an ods export choice for reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Bug ID: 11679 Summary: Add an ods export choice for reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:15:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:15:57 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:16:00 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #1 from Jonathan Druart --- Created attachment 25021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25021&action=edit Bug 11603: Preparation step, cleaning up This patch refactores and adds some good practices: - use Modern::Perl - use Pod::Usage - add POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:16:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:16:06 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #2 from Jonathan Druart --- Created attachment 25022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25022&action=edit Bug 11603: Gather print notices - add a csv parameter This patch adds: - the ability to generate a csv file instead of a html file. - a letter_code parameter. >From now you are able to generate a csv file for print notices. Imagine a template notice defined as: cardnumber:patron:email:item <>:<> >:<>:<> You would like to generate a csv file and not a html file. Test plan: - define your OVERDUE notice for the print template as: cardnumber:patron:email:item <>:<> >:<>:<> - define overdues rules for a patron category - check 2 items out using a due date in order to generate the overdue notices - check these 2 items in - launch the overdue_notices script - the message_queue table should now contain 2 new entries - launch the gather_print_notices cronjob with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE --letter_code=CHECKIN you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE -d=: will produce 1 csv file in your /tmp/test directory - verify the csv file is correct and contain only 1 csv header column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:16:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:16:11 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #3 from Jonathan Druart --- Created attachment 25023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25023&action=edit Bug 11603: Gather print notices - add a ods parameter This patch adds: - the ability to generate an ods file >From now you are able to generate a ods file for print notices. You would like to generate a csv file and not a html file. Test plan: - same as previous patch but test the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=: you should get an error because csv2ods is not installed. Follow the installation instructions and try again the command. A ods file should be generated in your /tmp/test directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:16:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:16:16 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #4 from Jonathan Druart --- Created attachment 25024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25024&action=edit Bug 11603: Refactoring A lot of code is duplicated for the 3 supported formats html, csv and ods. This patch refactores some of the code and makes it more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:16:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:16:58 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 --- Comment #1 from Jonathan Druart --- Created attachment 25025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25025&action=edit Bug 11678: Gather print notices: add --email parameter This patch add the ability to send generated files by email. You can specify several emails. Test plan: - same as Bug 11603 - call the script misc/cronjobs/gather_print_notices.pl with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --ods --html --letter_code=CHECKIN -d=: --email="email_one at example.org" --email="email_two at example.org" check your mailbox and verify the email contain 3 attached files: 1 csv, 1 ods and 1 html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:16:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:16:55 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:17:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:17:43 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:17:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:17:47 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 --- Comment #1 from Jonathan Druart --- Created attachment 25026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25026&action=edit Bug 11679: Add ods as a format for reports This patch adds the ability to export the data generated by a report into a ods file. Test plan: Install csv2ods (cf commit message from bug 11603 for the install instructions) and verify you are able to generate an ods file from a report result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:19:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:19:19 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov --- Comment #1 from Peggy Thrasher --- I can cause this problem as follows: Search in the OPAC Click on a title to take you to the detail page Click on the author's name or a subject heading When you have the new summary screen with the author's or subject's listings, click on limit to Currently Available. Then bad things happen. Looks like it is searching for "available" in one instance, doesn't find anything in other instances, or displays the wrong list (1 item instead of 291 results) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:20:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:20:34 +0000 Subject: [Koha-bugs] [Bug 11680] New: tax rate changes on edit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 Bug ID: 11680 Summary: tax rate changes on edit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org See this: http://screencast.com/t/d06EsMl925WO When you have a record with a tax rate saved on it and then click 'modify' to edit it the tax rate defaults to the first tax rate value even if that's not what was chosen before. Tested on Master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:26:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:26:15 +0000 Subject: [Koha-bugs] [Bug 11681] New: invoice not showing right price with tax Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11681 Bug ID: 11681 Summary: invoice not showing right price with tax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 25027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25027&action=edit Step1-order See the series of attached screenshots. 1 - make sure that your tax rate is set on the vendor as 'not included' in the price. 2 - place an order for one item with the tax rate chosen 3 - close the basket 4 - receive the order 5 - note that on receipt the tax rate doesn't show, but it does show in the receipt summary 6 - click finish receiving 7 - note that the invoice does not have the right price with the tax included Tested on master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:26:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:26:28 +0000 Subject: [Koha-bugs] [Bug 11681] invoice not showing right price with tax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11681 --- Comment #1 from Nicole C. Engard --- Created attachment 25028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25028&action=edit Step2-receive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:26:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:26:46 +0000 Subject: [Koha-bugs] [Bug 11681] invoice not showing right price with tax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11681 --- Comment #2 from Nicole C. Engard --- Created attachment 25029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25029&action=edit Step3-receiptsummary -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:27:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:27:02 +0000 Subject: [Koha-bugs] [Bug 11681] invoice not showing right price with tax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11681 --- Comment #3 from Nicole C. Engard --- Created attachment 25030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25030&action=edit Step4-invoice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:27:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:27:48 +0000 Subject: [Koha-bugs] [Bug 11681] invoice not showing right price with tax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11681 --- Comment #4 from Nicole C. Engard --- Sorry - I wasn't clear - the tax rate is different in the two places ... 5.1 and 5.4 in my example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:40:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:40:46 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #45 from M. de Rooy --- If someone does not beat me to it, I would like to put some QA time in this report. But just for the record, I would not recommend updating records during a full rebuild. Catalogers should sleep some time :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:49:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 14:49:35 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #46 from Katrin Fischer --- Hi Marcel, I would be grateful if you could take this on - feeling a bit out of my depth here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:03:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:03:57 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:04:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:04:11 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:04:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:04:19 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 25031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25031&action=edit Bug 11552; After a transfer, allow to search on the original order line If an order is transferred from a basket to another, it should be possible to retrieve it with the original ordernumber. Test plan: - transfer an order - note the original ordernumber and the new one - receive the order and, on the parcel page, try to find your order with the original ordernumber and the new one. Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:05:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:05:12 +0000 Subject: [Koha-bugs] [Bug 11609] organize suggestions by library doesn't appear to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11609 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10519 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:05:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:05:12 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #17 from Katrin Fischer --- *** Bug 11609 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:07:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:07:00 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24866|0 |1 is obsolete| | --- Comment #2 from Holger Mei?ner --- Created attachment 25032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25032&action=edit Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds The current holds behavior in Koha allows a situation like this: - Patron A has an item currently checked out. - Patron B places a hold on the next available copy of that title. - Then Patron A will not be able to renew his item, even if there are other available copies of that title that could potentially fill Patron B's hold. Since this seems unfair to Patron A, we should allow renewal of items even if there are unfilled holds, but those holds could all be filled with currently available items. Test Plan: 1) Apply this patch 2) Create a record with two items 3) Check out the item to a patron 4) Place a hold on the record 5) Note you cannot renew the item for the patron 6) Enable the new system preference AllowRenewalIfOtherItemsAvailable 7) Note you can now renew the item, as all the holds can be satisfied by available items. 8) Place a second hold on the record 9) Note you can no longer renew the item, as all the holds *cannot* be filled by currently available items Signed-off-by: Holger Mei?ner -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:07:29 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |h.meissner.82 at web.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:09:08 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #3 from Holger Mei?ner --- Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:49:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 15:49:53 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 --- Comment #5 from Koha Team Lyon 3 --- I have transfered an order from an order and from a receipt. After transfer, on the parcel page, I can retrieve the order by the former order number and the new one. Ok for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 17:35:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 16:35:30 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #56 from Galen Charlton --- (In reply to Kyle M Hall from comment #30) > (In reply to Katrin Fischer from comment #22) > > Hi Kyle, > > I like that it is an option for the borrower to set, but could we also tie > > the whole feature to a system preference maybe? I am a bit worried about > > data privacy implications and that would make it a bit easier. > > Can you expand a bit? The option is off by default, and if you opt to leave > opacprivacy disabled, there's no even a way to turn it on. I guess I want to > avoid YASP syndrome without absolute necessity. There is a difference between retaining circ history (and OpacPrivacy might be batter called PatronCircHistoryRetentionPolicy) and making patron's information available to other patrons. As you know, I'm not a fan of increasing the number of system preferences without due cause -- but in this case, YASP is called. Katrin can speak more to the specifics, but my understanding is that European data privacy laws are a Big Legal Deal, to the point that I feel strongly that we should give weight to concerns raised by Koha users who work in those jurisdictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 17:39:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 16:39:06 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #57 from Galen Charlton --- (In reply to Katrin Fischer from comment #55) > Hi Heather, thank you for taking the time to explain. I understand why it > makes sense to have the option in the patron account. I might be a bit > overly careful at times as we are quite strict with data privacy here. I > just couldn't resist to point out that jQuery won't be a solution if you > might not be allowed to use this feature for privacy concerns. There is no > staff permission and no pref to turn it totally off currently. +1 to the general point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:37:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:37:50 +0000 Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:40:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:40:29 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:40:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:40:34 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:41:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:41:19 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 25034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25034&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. For pageload. -Modifies the Koha::GetAuthorisedValues() to support passing a branchcode as a parameter -Modifies cataloguing/additem.pl to find the items.homebranch and pass this to the GetAuthorisedValues(). ------------- - TEST PLAN - ------------- 1. Define shelving locations for a specific branch: Go to Administration -> Authorised values -> category: LOC, Add a new value X specific to branch A, Add a new value Y specific to branch B. 2. Set your logged in library to branch C. 3. Edit an item. Set the Permanent location to branch A. Save the item. 4. Edit the item. Shelving locations has location X selectable in addition to the default ones. Set the Permanent location to branch B. Save the item. 5. Edit the item. Shelving locations has location Y selectable in addition to the default ones. Set the Permanent location to branch C. Save the item. 6. Edit the item. Shelving locations has neither Y or X selectable. Don't save. 7. Set your logged in branch to A. 8. Edit the item. Shelving locations has neither Y or X selectable. Don't save. This is how we do it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:41:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:41:40 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 25035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25035&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Svc AJAX-wrapper. This patch provides a HTTP-interface for the C4::Koha::GetAuthorisedValues() using the existing svc web interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:41:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:41:50 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 25036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25036&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Javascript bits. Makes the Shelving locations automatically refresh when the "Permanent location" (homebranch) changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:49:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:49:40 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #27 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:57:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:57:39 +0000 Subject: [Koha-bugs] [Bug 11682] New: serials.status is too dependent on magic numbers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 Bug ID: 11682 Summary: serials.status is too dependent on magic numbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The status column in the serials table, which represents the receipt status of a serial issue, uses a slew of magic numbers. This can make it difficult to maintain the code and add new statuses. Ways to address this, ranging from simple to more complex, include: [1] Use named constants. [2] Changing serials.status from an integer to a varchar and using self-describing values, possibly in conjunction with a new authorized value list. [3] Create a new serial_issue_status column to manage the statuses. It might look like this: id INTEGER -- status ID name VARCHAR(255) -- label of status missing BOOLEAN -- whether or not the status should be considered to represent an issue that was never received [4] As with option 3, but allowing staff users to define new statuses. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:58:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 17:58:10 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #28 from Galen Charlton --- I don't like the way serials.status uses magic numbers, so I've opened bug 11682. Comments welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:02:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 18:02:45 +0000 Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fr?d?ric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:08:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 18:08:38 +0000 Subject: [Koha-bugs] [Bug 11683] New: add search by title or callnumber on courses reserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11683 Bug ID: 11683 Summary: add search by title or callnumber on courses reserves Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org It would be nice to have the possibility to search titles or callnumber of biblios on courses reserves search on opac. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:18:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 18:18:39 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Kyle! I did add a note to the commit message: Note that the behavior will be a bit odd if you do a 'replace via Z39.50' from a bib record whose title happens to be an ISBN, but this scenario seems unlikely enough to ignore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:32:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 18:32:00 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- This is pending review by Jared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:35:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 18:35:22 +0000 Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- (In reply to Owen Leonard from comment #0) > This problem affects libraries where patron card numbers include leading > zeroes, for example "0001234." To reproduce: > > 1. If necessary, create or modify a patron to have a card number > with leading zeroes. > 2. Go to Tools -> Patron lists. > 3. Click "Add patrons" on an existing list. > 4. Perform a patron search and choose one of the results. > 5. Click the "remove" link next to the patron name which was just added. > Nothing will happen. > > See also Bug 11534. As a general observation, interfaces that refer to known patron records would be better off referring to them by borrowernumber, not cardnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:39:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 18:39:32 +0000 Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:46:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 18:46:27 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #23 from Galen Charlton --- Pushed to master, along with a follow-up fixing a test case that the main patch broke. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:53:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 18:53:02 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 --- Comment #13 from Kyle M Hall --- Created attachment 25037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25037&action=edit Bug 11405 [7] - Add out of order status to CSV file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 20:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 19:28:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #44 from Blou --- Created attachment 25038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25038&action=edit Bug 8753 - Add forgot password link to OPAC (patch) When asking for a new link when one was already sent now causes an update of the one in the DB. This - makes the previous link invalid - reset the timestamp to allow for two more days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:11:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 21:11:19 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24908|0 |1 is obsolete| | Attachment #25038|0 |1 is obsolete| | --- Comment #45 from Blou --- Created attachment 25039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25039&action=edit Bug 8753 - Add forgot password link to OPAC This includes fix following the most recent comments and a rebasing through db 3.15.00.16 Fixes all comments specified by mtompsett. TEST PLAN: 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. That will cause the link 'Forgot yo 2b) make sure that OpacPasswordChange is also ON. 3) refresh front page, click on 'Forgot your password' and enter a VALID address (one that is associated to an en 3b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 4) An email should be received at that address with a link. 5) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 6) Go to main page try the new password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:38:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 21:38:33 +0000 Subject: [Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- The problem with authorized values is that there is currently no way to have multiple translations. The standard statuses right now are located in the tepmlates and are therefore translated into any installed lanugage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:42:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 21:42:58 +0000 Subject: [Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 --- Comment #2 from Katrin Fischer --- Hm, might be misunderstanding. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:55:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 21:55:18 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:55:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 21:55:22 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24631|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 25040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25040&action=edit Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 23:11:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2014 22:11:31 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #21 from Robin Sheat --- (In reply to Katrin Fischer from comment #20) > Robin, could you take a look at comment 9 from Jonathan? I can, but I don't know why it'd be doing that. Maybe memcached wasn't running or something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:00:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 01:00:44 +0000 Subject: [Koha-bugs] [Bug 11684] New: More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Bug ID: 11684 Summary: More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Unsecured content on secured pages for opac-readingrecord and opac-user templates. Patches to follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:04:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 01:04:02 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:04:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 01:04:07 +0000 Subject: [Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684 --- Comment #1 from Liz Rea --- Created attachment 25043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25043&action=edit bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user To test: * Enable Amazon images in the system preferences * Issue a book you know will have images for, verify that without SSL 1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord 2. the image source is from an Amazon url that uses http:// 3. the images are the right size, and look ok * Do the same using https, verify that with SSL 1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord 2. the image source is from an Amazon url that uses https:// 3. the images are the right size, and look ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 03:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 02:05:57 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11574 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 03:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 02:05:57 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11601 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 03:06:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 02:06:24 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #7 from Liz Rea --- Created attachment 25044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25044&action=edit Bug 11574 - Clean up lists interface for printing Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file, observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 04:37:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 03:37:36 +0000 Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |liz at catalyst.net.nz --- Comment #4 from Liz Rea --- To test: This text is explicitly, as far as I can tell, for screen readers. Therefore, the way to test this is to inspect the source of the generated page and make sure that the text in the for Pick up location shows the correct spelling of location. It's not a commit message, but I hope this test plan helps you test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 07:24:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 06:24:22 +0000 Subject: [Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 --- Comment #3 from Katrin Fischer --- Ok, no more commenting in the late evenings? :) Maybe we could allow to define custom statuses and still keep a few standard ones, similar to the suggestion status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:31:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 07:31:47 +0000 Subject: [Koha-bugs] [Bug 11685] New: GetSupportName and GetSupportList do not split AdvancedSearchTypes by pipe Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11685 Bug ID: 11685 Summary: GetSupportName and GetSupportList do not split AdvancedSearchTypes by pipe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org System preference AdvancedSearchTypes can be a pipe-separated list of values. GetSupportName() and GetSupportList() compare the syspref value directly using eq instead of using a regex, or splitting the value by pipe and then comparing the array values. For example, this can mean the "Item type" drop down is empty in OPAC when entering a new purchase suggestion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:52:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 08:52:16 +0000 Subject: [Koha-bugs] [Bug 11686] New: "please note your reason here..." does not get translated Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11686 Bug ID: 11686 Summary: "please note your reason here..." does not get translated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Even though the text "please note your reason here..." (in suggestion.tt) will get picked up into the po-files, it is never actually translated in the templates when you install the language. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:21:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:21:36 +0000 Subject: [Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- (In reply to Galen Charlton from comment #0) > [3] Create a new serial_issue_status column to manage the statuses. It > might look like this: > > id INTEGER -- status ID > name VARCHAR(255) -- label of status > missing BOOLEAN -- whether or not the status should be considered to > represent an issue that was never received I'm not sure it is enough. The status value is checked at several places in the code: 1/ (planneddate < now() AND serial.status=1) OR serial.STATUS IN (3, 4, 41, 42, 43, 44) 2/ WHERE ((planneddate < now() AND serial.STATUS =1) OR serial.STATUS = 3) and some others. The "missing" boolean won't permit to write a SQL query doing the same thing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:22:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:22:10 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:22:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:22:10 +0000 Subject: [Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10851 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:39:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:39:22 +0000 Subject: [Koha-bugs] [Bug 11687] New: statecollection.pl is unused Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 Bug ID: 11687 Summary: statecollection.pl is unused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The script serials/statecollection.pl is no longer in use and can be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:40:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:40:46 +0000 Subject: [Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:40:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:40:50 +0000 Subject: [Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 --- Comment #5 from Jonathan Druart --- Created attachment 25045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25045&action=edit Bug 11687: statecollection.pl is no longer in use It can be removed. Test plan: git grep statecollection returns no occurrence. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:42:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:42:12 +0000 Subject: [Koha-bugs] [Bug 11687] statecollection.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:42:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:42:13 +0000 Subject: [Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25045|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Comment on attachment 25045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25045 Bug 11687: statecollection.pl is no longer in use Arg, bad bz number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:42:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:42:16 +0000 Subject: [Koha-bugs] [Bug 11687] statecollection.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 --- Comment #1 from Jonathan Druart --- Created attachment 25046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25046&action=edit Bug 11687: statecollection.pl is no longer in use It can be removed. Test plan: git grep statecollection returns no occurrence. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:42:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:42:51 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 --- Comment #4 from paxed --- Some terms really should be defined better: "list", "cart", "basket", "basket group" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:43:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 09:43:00 +0000 Subject: [Koha-bugs] [Bug 11687] statecollection.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 10:00:09 +0000 Subject: [Koha-bugs] [Bug 11688] New: OrderPdfFormat cannot be configured nor localized Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11688 Bug ID: 11688 Summary: OrderPdfFormat cannot be configured nor localized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Syspref OrderPdfFormat takes a cryptic text string. Output is a PDF that cannot be configured. Both the perl code and the ODT-file (which is originally used as the layout of the PDF) have strings that need translation. The perl code has hard-coded locations for strings ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:26:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 10:26:28 +0000 Subject: [Koha-bugs] [Bug 11689] New: New missing statuses is not well managed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Bug ID: 11689 Summary: New missing statuses is not well managed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Bug 10851 introduced new missing status (codes 41,42,43,44), but in GetSerials and _update_missinglist, they are not take into account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:27:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 10:27:33 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11689 --- Comment #29 from Jonathan Druart --- This enhancement introduced an issue, please see bug 11689. Patch coming soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:27:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 10:27:33 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10851 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:27:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 10:27:59 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:34:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 10:34:34 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:34:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 10:34:38 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 --- Comment #1 from Jonathan Druart --- Created attachment 25047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25047&action=edit Bug 11689: New missing statuses are not well managed Bug 10851 introduced new missing status (codes 41,42,43,44), but in GetSerials and _update_missinglist, they are not take into account. To reproduce: 1/ Create a serial with 10 issues. 2/ Set different statuses on each one, with at least 6 missing statuses (not only "Missing"). 3/ Go on the subscription detail page, tab "Summary", the issues with a new missing status are not listed in the missing issues list. 4/ On the "Issues" tab, all missing are listed (normally only 5 should be listed. 5/ Apply the patch. 6/ Edit serial (to rewrite the missing list). 6/ Verify that steps 3 and 4 have now correct behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:17:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:17:56 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:19:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:19:08 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |abl at biblos.pk.edu.pl Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl |ity.org | --- Comment #1 from Jacek Ablewicz --- Created attachment 25048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25048&action=edit Proposed patch If the tax rates in Acquisitions -> gist system preference are entered with trailing zeroes, given order tax rate value may not be correctly handled on order edit. To test: 1) insert some tax rates with trailing zeroes in gist system preference (e.g: '0|0.080|0.12|0.20|0.23') 2) place some new orders, choosing 8.0% 12.0% 20.0% 23.0% as gst rate 3) try to modify them 4) note that orders with 12.0% and 23.0% tax rates are preserving previously choosen rates on edit, while the ones with 8.0% and 20.0% do not (they are defaulting to the first defined tax rate) 5) apply the patch 6) repeat 2) and 3) 7) all tax rates configured in system prefrence shall now behave properly while editing orders -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:29:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:29:12 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11619 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:29:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:29:12 +0000 Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10544 | --- Comment #24 from M. de Rooy --- (In reply to Galen Charlton from comment #23) > Pushed to master, along with a follow-up fixing a test case that the main > patch broke. Thanks, Galen. I remove the non-mandatory dependency for 10544. It can also be applied on top of this.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:29:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:29:50 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #26 from M. de Rooy --- Still applies on top of 11619. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:30:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:30:20 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 --- Comment #2 from Jacek Ablewicz --- (In reply to Nicole C. Engard from comment #0) > See this: http://screencast.com/t/d06EsMl925WO > Nicole, I'm not sure if proposed patch will actually resolve this particular problem as seen in the video (unless you have trailing zeroes in your 6.0% tax rate definition in gist system preference?); it may as well be different issue (with the same symptoms) which I encountered while trying to reproduce this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:32:32 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:40:33 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 11:40:33 +0000 Subject: [Koha-bugs] [Bug 11681] invoice not showing right price with tax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11681 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:11:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 12:11:05 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:11:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 12:11:08 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25026|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 25049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25049&action=edit Bug 11679: Add ods as a format for reports This patch adds the ability to export the data generated by a report into a ods file. Test plan: Install csv2ods (cf commit message from bug 11603 for the install instructions) and verify you are able to generate an ods file from a report result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:32:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 12:32:16 +0000 Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25009|0 |1 is obsolete| | --- Comment #2 from Petter Goks?yr ?sen --- Created attachment 25050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25050&action=edit Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. --------------------------------------------------------------------- Created to patron lists and confirmed the collums 'add patrons', 'edit' and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list' are still sortable. The size of buttons are smaller. I also agree this is an improvement. Signed-off-by: Petter Goksoyr Asen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:33:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 12:33:47 +0000 Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |boutrosboutrosboutros at gmail | |.com --- Comment #3 from Petter Goks?yr ?sen --- Sorry, a few typos there, should be Created TWO patron lists and confirmed the COLUMNS ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:09:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 13:09:22 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #46 from Blou --- Created attachment 25051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25051&action=edit Delete the exprired links after (any) successful reset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:22:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 14:22:04 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:23:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 14:23:36 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 --- Comment #3 from Nicole C. Engard --- I did not have a trailing 0 on my tax rate it was 0|0.6 in the preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:49:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 14:49:19 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #23 from Julian Maurice --- Created attachment 25053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25053&action=edit Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 14:51:08 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #24 from Julian Maurice --- This patch should fix problems of comment 21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:13:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 15:13:51 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #47 from M. Tompsett --- Vast improvement on the DELETE. Sadly, still have two problems. "Framing Problem" Click forget password link Type in username and password to log in to OPAC Click link in email. (screen 1) Log out of OPAC Click link in email. (screen 2) Both screens are framed differently. "Email Problem" http://irc.koha-community.org/koha/2014-02-04#i_1460899 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:22:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 15:22:55 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:22:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 15:22:58 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 --- Comment #1 from Owen Leonard --- Created attachment 25056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25056&action=edit Bug 10865 - Don't show list permissions when adding public lists/sharing lists is not allowed If patron creation of public lists is disallowed by the OpacAllowPublicListCreation system preference the "category" option should be hidden altogether instead of showing a with "private" as the only option. This patch hides category and permissions controls when OpacAllowPublicListCreation is set to "don't allow." To test you must have the virtualshelves system preference enabled. Apply the patch and log into the OPAC. Test: - With OpacAllowPublicListCreation enabled, create a new list. You should see options for setting category and permissions. Saving the new list should complete correctly and save the right settings. - With OpacAllowPublicListCreation enabled, edit an existing list. You should see the same options and saving your changes should work correctly. - With OpacAllowPublicListCreation disabled, create a new list. You should only see fields for title and sort. Saving this list should complete correctly and save the right settings. - With OpacAllowPublicListCreation disabled, edit an existing list. You should be able to edit only title and sort settings. Saving your changes should work correctly. Repeat your tests for both prog and bootstrap themes. Signed-off-by: Nicole C. Engard tested on all three themes and works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:18:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:18:19 +0000 Subject: [Koha-bugs] [Bug 11664] No way to select all/unselect all on patron list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11664 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Owen Leonard --- I rolled a fix for this into the broader Bug 11671 so I'm marking this as a duplicate. *** This bug has been marked as a duplicate of bug 11671 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:18:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:18:19 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Owen Leonard --- *** Bug 11664 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:21:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:21:30 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:21:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:21:33 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25048|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard --- Created attachment 25059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25059&action=edit [SIGNED-OFF] Bug 11680 - tax rate changes on edit If the tax rates in Acquisitions -> gist system preference are entered with trailing zeroes, given order tax rate value may not be correctly handled on order edit. To test: 1) insert some tax rates with trailing zeroes in gist system preference (e.g: '0|0.080|0.12|0.20|0.23') 2) place some new orders, choosing 8.0% 12.0% 20.0% 23.0% as gst rate 3) try to modify them 4) note that orders with 12.0% and 23.0% tax rates are preserving previously choosen rates on edit, while the ones with 8.0% and 20.0% do not (they are defaulting to the first defined tax rate) 5) apply the patch 6) repeat 2) and 3) 7) all tax rates configured in system prefrence shall now behave properly while editing orders Signed-off-by: Nicole C. Engard All tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:21:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:21:52 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 --- Comment #6 from Nicole C. Engard --- It does appear to solve my problem - I don't know why -but it does :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:23:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:23:19 +0000 Subject: [Koha-bugs] [Bug 11692] New: number 9 showing on topissues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11692 Bug ID: 11692 Summary: number 9 showing on topissues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org This is a strange one and has been confirmed in 3.12 and master. Each item's title listing on the Most Popular page in the opac ends with the string "; 9". I can't figure out where it's coming from but it's been on the 4 systems I looked at. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:31:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:31:05 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com --- Comment #7 from Pablo AB --- This is an important issue for non-English Koha users, at least Spanish speakers. We see a lot of people having problem with this on Koha-es (Spanish Koha list, http://groups.yahoo.com/group/koha-es). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:32:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:32:52 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25034|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 25060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25060&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. For pageload. -Modifies the Koha::GetAuthorisedValues() to support passing a branchcode as a parameter -Modifies cataloguing/additem.pl to find the items.homebranch and pass this to the GetAuthorisedValues(). ------------- - TEST PLAN - ------------- 1. Define shelving locations for a specific branch: Go to Administration -> Authorised values -> category: LOC, Add a new value X specific to branch A, Add a new value Y specific to branch B. 2. Set your logged in library to branch C. 3. Edit an item. Set the Permanent location to branch A. Save the item. 4. Edit the item. Shelving locations has location X selectable in addition to the default ones. Set the Permanent location to branch B. Save the item. 5. Edit the item. Shelving locations has location Y selectable in addition to the default ones. Set the Permanent location to branch C. Save the item. 6. Edit the item. Shelving locations has neither Y or X selectable. Don't save. 7. Set your logged in branch to A. 8. Edit the item. Shelving locations has neither Y or X selectable. Don't save. This is how we do it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:33:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:33:25 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25035|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 25061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25061&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Svc AJAX-wrapper. This patch provides a HTTP-interface for the C4::Koha::GetAuthorisedValues() using the existing svc web interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:33:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:33:44 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25036|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 25062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25062&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Javascript bits. Makes the Shelving locations automatically refresh when the "Permanent location" (homebranch) changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:35:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:35:35 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:37:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:37:53 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #14 from Olli-Antti Kivilahti --- Would you kindly help me help you get this feature to master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:56:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 16:56:07 +0000 Subject: [Koha-bugs] [Bug 11692] number 9 showing on topissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11692 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 18:23:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 17:23:07 +0000 Subject: [Koha-bugs] [Bug 11692] number 9 showing on topissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11692 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 18:23:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 17:23:11 +0000 Subject: [Koha-bugs] [Bug 11692] number 9 showing on topissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11692 --- Comment #1 from Owen Leonard --- Created attachment 25063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25063&action=edit Bug 11692 - number 9 showing on topissues The template for the OPAC's "most popular" page includes several variables which are not passed by the script, including biblioitems.size. This patch adds the right columns to the query and standardizes the output somewhat based on non-XSLT opac-detail. To test, apply the patch and view the "most popular" page in both prog and bootstrap. You should see correct publisher, copyright, pages, and size information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 18:51:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 17:51:28 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #48 from Owen Leonard --- I notice this feature is enabled by default. I think it should be disabled by default. There are many problems with the template which I'll work on a follow-up for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:02:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 18:02:57 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25061|0 |1 is obsolete| | --- Comment #7 from Olli-Antti Kivilahti --- Created attachment 25064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25064&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Svc AJAX-wrapper. This patch provides a HTTP-interface for the C4::Koha::GetAuthorisedValues() using the existing svc web interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:05:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 18:05:45 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 25065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25065&action=edit C4::Auth.pm Documentation improvement check_cookie_auth() didn't describe the content and how to use the permissions hash and I had to rummage through code to figure out how the flags are properly passed. I hope this will help the next one not to take that hit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:57:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 18:57:02 +0000 Subject: [Koha-bugs] [Bug 11693] New: Default preferences not loaded for self registering patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Bug ID: 11693 Summary: Default preferences not loaded for self registering patron Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: hissheep4 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a new patron uses the self registering option, their record is not created with the default emailing preferences, but is left blank. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:58:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 18:58:03 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 JB changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Default preferences not |Default emailing |loaded for self registering |preferences not loaded for |patron |self registering patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 18:59:32 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #49 from Owen Leonard --- For what it's worth, I tested this and didn't get a password recovery email. I noticed in trying to understand how the emails should be sent that the feature doesn't use notice templates or the message queue. Should we be adding a feature that uses yet another method for handling emails? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:02:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 19:02:45 +0000 Subject: [Koha-bugs] [Bug 11228] Explanation on 'patron notification' is not quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228 --- Comment #7 from Nicole C. Engard --- Can someone confirm that this edit to the manual is correct: http://git.koha-community.org/gitweb/?p=kohadocs.git;a=commitdiff;h=29377fa98448112cc7b138e9dd6c5960c7500c1c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:31:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 19:31:29 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francharb at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:32:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 19:32:00 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francharb at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:33:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 19:33:37 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francharb at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:33:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 19:33:43 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francharb at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:33:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 19:33:49 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francharb at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:33:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 19:33:54 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francharb at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:41:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 20:41:49 +0000 Subject: [Koha-bugs] [Bug 11694] New: Improve handling of individual hold suspension Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11694 Bug ID: 11694 Summary: Improve handling of individual hold suspension Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-user.pl#opac-user-holds OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Putting the hold suspension/resumption controls in the table of holds creates quite a bit of clutter, especially with AutoResumeSuspendedHolds enabled. I propose to make some styling changes to the way the controls are displayed. If AutoResumeSuspendedHolds is enabled (and so is JavaScript) the suspend control will trigger a modal dialog which will contain the "suspend until" options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:54:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 21:54:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #50 from M. Tompsett --- My Ubuntu VM has email set up in a manner similar to https://help.ubuntu.com/community/Postfix This uses the Mail::SendMail library directly, which is already part of the dependencies for Koha. Checkout the code in C4/Members.pm around line 2314 after applying the patch. The "if ( sendmail %mail )" is what actually does the emailing. If you don't have postfix configured, then nullmailer is installed. Hopefully, that is configured correctly. I have yet to read sensible and useful documentation on it. Some mail hosts delay sending/receiving when mail is relayed. Patience may be required while testing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:11:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2014 22:11:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #51 from David Cook --- (In reply to M. Tompsett from comment #50) > My Ubuntu VM has email set up in a manner similar to > https://help.ubuntu.com/community/Postfix > > This uses the Mail::SendMail library directly, which is already part of the > dependencies for Koha. Checkout the code in C4/Members.pm around line 2314 > after applying the patch. > The "if ( sendmail %mail )" is what actually does the emailing. > > If you don't have postfix configured, then nullmailer is installed. > Hopefully, that is configured correctly. I have yet to read sensible and > useful documentation on it. > > Some mail hosts delay sending/receiving when mail is relayed. Patience may > be required while testing this. While other parts of Koha do rely on Sendmail directly, I think Owen has a very good point. We should definitely be using the notice templates, and we should probably be using the message queue. The notice templates allow libraries to provide their own wording/translations to the message. I think that's a *must*. Using the message queue also helps Koha administrators to track the messages going out, since they might not have direct access to the MTA or mail server. Owen: I'm not sure what your testing scenario is but I noticed recently that my Koha VM's MTA is configured out of the box not to send email outside of its local domain. I don't know if that's relevant for you though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 01:04:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 00:04:16 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #15 from David Cook --- Jonathan, I think if you sign off on my follow-up, we can get this over to the QA people. I would love to see this one get through soon. It's been a long-standing bug for us. Happy to test someone else's patch if it means this one gets through as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 07:01:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 06:01:20 +0000 Subject: [Koha-bugs] [Bug 11459] OrderPdfFormat pref description could be more verbose In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |10746 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 07:01:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 06:01:20 +0000 Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11459 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 07:02:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 06:02:12 +0000 Subject: [Koha-bugs] [Bug 11688] OrderPdfFormat cannot be configured nor localized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- I think this is a duplicate to bug 5016 and bug 11456, both linked to omnibus bug 10746. *** This bug has been marked as a duplicate of bug 10746 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 07:02:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 06:02:12 +0000 Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #2 from Katrin Fischer --- *** Bug 11688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:15:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 07:15:13 +0000 Subject: [Koha-bugs] [Bug 11695] New: Typo: "Tree-character alphabetic code" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 Bug ID: 11695 Summary: Typo: "Tree-character alphabetic code" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org Typo in marc21_field_008.xml: "Tree-character alphabetic code", should be _Three_, not _Tree_ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:35:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 07:35:23 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from M. de Rooy --- Saving a public list on opac now results in setting it to Private. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:35:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 07:35:57 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:29:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 08:29:42 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for recieving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14517|0 |1 is obsolete| | --- Comment #15 from Julian Maurice --- Created attachment 25068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25068&action=edit Bug 7290: More granular permissions for order receiving Add branch to aqorders. Add subpermission acquisition => order_receive_all Users with order_receive_all can receive all orders. Users with only order_receive can receive an order if: - order branch is defined and is the same as the current working branch - order branch is not defined, basket branch is defined and basket branch is the same as the current working branch - order branch and basket branch are not defined Use dataTables filters possibilities instead of custom JS solution in parcel.pl Unit tests are available in t/Acquisition/CanUserReceiveBasket.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:30:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 08:30:00 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for recieving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 09:45:37 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros at gmail | |.com --- Comment #82 from Petter Goks?yr ?sen --- > > - Problems with Back button : old searches are saved and performed > > I don't know how to fix that :-/ I will see while the QA step. > I don't have a solution for that. A workaround would be to open the patron detail page into a new tab/window. Note: I havent tried this patch, but I recently resolved a similar issue in another project. Most browsers now use something called BFCache (back-forward cache) witch means that when you click back button, the page is not reloaded, and scripts not rerun, The page is still in browser memory, so it just revert to previous state. To force any action when you are going back, you have to listen for the "pageshow" event. For example with jqUery: $(window).bind("pageshow", function() { // clear input fields here! }); You can read about BFcache logic here: https://developer.mozilla.org/en-US/docs/Working_with_BFCache Hope this helps! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:17:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 10:17:16 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Olli-Antti Kivilahti --- Just implementing our print message processing and found a nasty bug. I am sending overdue notifications for each letter 1,2,3 via email,print,sms. I have different template configured per transport_type. If a patron doesn't have email configured, instead of getting three messages in the message_queue with their respective letter-templates used, I get only sms and print(using the email-template) So the print is sent using the email template if email address is missing, instead of the print template. This is a big issue since the print templates often follow a very specific eLetter format and must use the proper transport type template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:53:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 10:53:05 +0000 Subject: [Koha-bugs] [Bug 11696] New: Multi transport types: the print notices should be processed in first Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 Bug ID: 11696 Summary: Multi transport types: the print notices should be processed in first Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org On bug 10832 comment 12, a specific cause an issue. If email, print and sms are checked (for overdues for instance), and no email exists for the user, the email template will be used to sent the print notice. The print notices should be processed in first to avoid this problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:53:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 10:53:29 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11696 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:53:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 10:53:29 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10832 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:55:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 10:55:39 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:55:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 10:55:42 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 --- Comment #1 from Jonathan Druart --- Created attachment 25069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25069&action=edit Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:56:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 10:56:35 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart --- I just submitted a patch on bug 11696 for this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:56:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 11:56:27 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25069|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 25070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25070&action=edit Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:59:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 11:59:27 +0000 Subject: [Koha-bugs] [Bug 11696] Multi transport types: the print notices should be processed in first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11696 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |olli-antti.kivilahti at jns.fi --- Comment #3 from Olli-Antti Kivilahti --- Pretty slick solution! gg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:00:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 13:00:08 +0000 Subject: [Koha-bugs] [Bug 11697] New: Thesaurus plugin sets indicators with a space Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11697 Bug ID: 11697 Summary: Thesaurus plugin sets indicators with a space Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When using thesaurus plugin to link a biblio field with an authority, the indicators of the field of authority are set into indicators of biblio field. The bug is that when an indicator is not defined, it contains a space ' '. This space is then set into biblio field. The user must then erase this space before setting the indicator. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:04:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 13:04:13 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82 at web.de --- Comment #38 from Holger Mei?ner --- Just tested this with an item's replacement price set to 7,95 and overdue fines cap set to 1000. Directly after the checkout (backdated a few years) the fine was displayed to be 0. I guess that's ok, since you usually don't backdate except for testing. Then I ran misc/cronjobs/fines.pl and the fine was updated to 1000. Finally I returned the item and the fine was set to 7,95. So apparently and confusingly fines are calculated in different places. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:09:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 13:09:24 +0000 Subject: [Koha-bugs] [Bug 11697] Thesaurus plugin sets indicators with a space In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11697 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:09:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 13:09:27 +0000 Subject: [Koha-bugs] [Bug 11697] Thesaurus plugin sets indicators with a space In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11697 --- Comment #1 from Fridolin SOMERS --- Created attachment 25071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25071&action=edit Bug 11697 - Thesaurus plugin sets indicators with a space When using thesaurus plugin to link a biblio field with an authority, the indicators of the field of authority are set into indicators of biblio field. The bug is that when an indicator is not defined, it contains a space ' '. This space is then set into biblio field. The user must then erase this space before setting the indicator. This patch sets indicator as empty string when containing a space. Test plan : - Create a new biblio record - Select a field managed with a thesaurus. For example 700 - Click on thesaurus plugin icon - Search and choose an authority record with no indicator set on heading field => Without patch, the indicators of the biblio field (ie 700) are filled with a space character => With patch, the indicators of the biblio field (ie 700) are empty - Click on plugin icon - Search and choose an authority record with indicators set on heading field => The indicators are set in biblio field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:22:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 13:22:34 +0000 Subject: [Koha-bugs] [Bug 7770] usage of OPACBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7770 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Version|3.8 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:48:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 13:48:47 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #51 from Julian Maurice --- Created attachment 25072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25072&action=edit Bug 7683: Remove dead code about dewey and lccn filters $hasdewey and $haslccn were hardcoded to 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:48:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 13:48:57 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #52 from Julian Maurice --- Created attachment 25073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25073&action=edit Bug 7683: Fix a shift in date filter indexes Date filter indexes are 13, 14, 15, 16, not 14, 15, 16, 17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:49:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 13:49:26 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #53 from Julian Maurice --- The last patch should fix issue of comment 50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:04:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:04:24 +0000 Subject: [Koha-bugs] [Bug 11698] New: can't create a budget Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698 Bug ID: 11698 Summary: can't create a budget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 25074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25074&action=edit budget I can't create a budget in master. When I do I get this error: Software error: round() overflow. Try smaller precision or use Math::BigFloat at /home/nengard/kohaclone/admin/aqbudgetperiods.pl line 258. For help, please send mail to the webmaster (webmaster at debian), giving this error message and the time and date of the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:05:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:05:11 +0000 Subject: [Koha-bugs] [Bug 11698] can't create a budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698 --- Comment #1 from Nicole C. Engard --- Oh, and I should add that now I can't get to the existing budgets list either because it's giving me the same error.... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:07:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:07:49 +0000 Subject: [Koha-bugs] [Bug 11699] New: notes entered when receiving are not saved Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Bug ID: 11699 Summary: notes entered when receiving are not saved Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 25075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25075&action=edit adding note When in acquisitions you can enter notes on the receive page. Those notes go no where though - they don't show on the invoice as you'd expect or even on the order under 'already received' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:08:18 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #1 from Nicole C. Engard --- Created attachment 25076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25076&action=edit no note -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:09:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:09:20 +0000 Subject: [Koha-bugs] [Bug 7770] usage of OPACBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7770 --- Comment #2 from Fridolin SOMERS --- (In reply to Matthias Meusburger from comment #1) > To my opinion, http:// should not be added automatically, for one simple > reason: it just might not be http:// ! > OPAC might be using https, and in that case, automatic prefill would be > wrong. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:23:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:23:30 +0000 Subject: [Koha-bugs] [Bug 11692] number 9 showing on topissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11692 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:23:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:23:32 +0000 Subject: [Koha-bugs] [Bug 11692] number 9 showing on topissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11692 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25063|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 25077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25077&action=edit [SIGNED-OFF] Bug 11692 - number 9 showing on topissues The template for the OPAC's "most popular" page includes several variables which are not passed by the script, including biblioitems.size. This patch adds the right columns to the query and standardizes the output somewhat based on non-XSLT opac-detail. To test, apply the patch and view the "most popular" page in both prog and bootstrap. You should see correct publisher, copyright, pages, and size information. Signed-off-by: Nicole C. Engard Tested in all three themes and works lovely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:26:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:26:21 +0000 Subject: [Koha-bugs] [Bug 11228] Explanation on 'patron notification' is not quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228 --- Comment #8 from Nicole C. Engard --- With help on IRC I have updated the manual: http://manual.koha-community.org/3.14/en/routinglist.html http://manual.koha-community.org/3.14/en/newsubscription.html http://manual.koha-community.org/3.14/en/serialsubinopac.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:30:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:30:21 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #17 from Julian Maurice --- Created attachment 25078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25078&action=edit Bug 7292: New permission for claims (database changes only) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:30:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:30:24 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21354|0 |1 is obsolete| | --- Comment #18 from Julian Maurice --- Created attachment 25079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25079&action=edit Bug 7292: More granular permissions for claiming orders Add a new permission order_claim_for_all. Without this permission, user can only claim for orders in baskets he's authorised to manage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:31:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:31:57 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Julian Maurice --- Patches split and rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:46:35 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24884|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 25080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25080&action=edit Bug 8918: Fix reserve priority in ILS-DI Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:46:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:46:52 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24885|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 25081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25081&action=edit 8918 QA Followup for pref descriptions Rebased on master and signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:47:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:47:06 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24886|0 |1 is obsolete| | --- Comment #57 from Julian Maurice --- Created attachment 25082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25082&action=edit Bug 8918: Add a unit test for CalculatePriority Rebased on master and signed off Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:47:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:47:21 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24920|0 |1 is obsolete| | --- Comment #58 from Julian Maurice --- Created attachment 25083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25083&action=edit Bug 8918: Follow-up for some more unit tests for CalculatePriority Rebased on master and signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:47:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:47:30 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #59 from Julian Maurice --- Created attachment 25084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25084&action=edit Bug 8918: t/db_dependant/Reserves.t fails if marcflavour is UNIMARC Set marcflavour to MARC21 to make tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:48:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 14:48:45 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #60 from Julian Maurice --- > Julian: Could you still test this again one time and set status back to Signed off? Thanks. I added a new patch so I leave the bug status to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:05:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:05:29 +0000 Subject: [Koha-bugs] [Bug 11687] statecollection.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25046|0 |1 is obsolete| | --- Comment #2 from Holger Mei?ner --- Created attachment 25085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25085&action=edit Bug 11687: statecollection.pl is no longer in use It can be removed. Test plan: git grep statecollection returns no occurrence. http://bugs.koha-community.org/show_bug.cgi?id=11682 Signed-off-by: Holger Mei?ner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:06:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:06:29 +0000 Subject: [Koha-bugs] [Bug 11687] statecollection.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |h.meissner.82 at web.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:18:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:18:10 +0000 Subject: [Koha-bugs] [Bug 11700] New: C4::AuthoritiesMarc::merge enhancements/fixes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bug ID: 11700 Summary: C4::AuthoritiesMarc::merge enhancements/fixes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 7419 patches contains several enhancements and fixes for subroutine C4::AuthoritiesMarc::merge. This bug is complicated to test so I will remove changes to this subroutine from bug 7419 and put it here. So maybe it will increase the chances to push these patches into master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:18:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:18:44 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #1 from Julian Maurice --- Created attachment 25086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25086&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different - Indentation and whitespace fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:32:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:32:53 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17790|0 |1 is obsolete| | --- Comment #46 from Julian Maurice --- Created attachment 25087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25087&action=edit Bug 7419: Move indexation subs in C4::ZebraIndex Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:33:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:33:59 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17791|0 |1 is obsolete| | Attachment #17792|0 |1 is obsolete| | Attachment #22150|0 |1 is obsolete| | --- Comment #47 from Julian Maurice --- Created attachment 25088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25088&action=edit Bug 7419: New script dedup_authorities.pl Rebased on master Removed all changes to C4::AuthoritiesMarc::merge (see bug 11700) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:34:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:34:28 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22907|0 |1 is obsolete| | --- Comment #48 from Julian Maurice --- Created attachment 25089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25089&action=edit Fix C4::Context::Zconn() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:34:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:34:55 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7419 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:34:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:34:55 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Depends on| |11700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:49:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:49:16 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24903|0 |1 is obsolete| | --- Comment #8 from Holger Mei?ner --- Created attachment 25090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25090&action=edit Bug 11411 - Bootstrap theme (enhancement) for (right to left) This patch improves Koha's layout when a right-to-left language is being displayed by correcting a float set by the right-to-left version of Bootstrap CSS. The patch modifies the right-to-left Less file and includes a now-minified version of the compiled CSS. To test, install a right-to-left language like ar-Arab. Apply the patch and view the OPAC under the Bootstrap theme. When logged in, the aligned to the left. Signed-off-by: Holger Mei?ner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:50:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 15:50:03 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |h.meissner.82 at web.de --- Comment #9 from Holger Mei?ner --- Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:08:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:08:50 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #54 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:09:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:09:37 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:09:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:09:45 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:09:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:09:51 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:09:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:09:56 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23687|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:10:04 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:10:07 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 --- Comment #5 from Owen Leonard --- (In reply to M. de Rooy from comment #4) > Saving a public list on opac now results in setting it to Private. I can't reproduce this error. Can you tell me the steps you're following? Does it only happen in one theme? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:10:10 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olli-antti.kivilahti at jns.fi --- Comment #16 from Olli-Antti Kivilahti --- Hi there! Applied the bug. I am noticing a huge performance drop with cronjobs/overdue_notices.pl getting 12 items to the message_queue takes 31s with this feature applied. getting 12 items to the message_queue takes 1s without this feature applied. oops... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:10:12 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:10:19 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23690|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:10:25 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23691|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:10:31 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25072|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:10:37 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25073|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:20 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #55 from sandboxes at biblibre.com --- Created attachment 25091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25091&action=edit Bug 11579: Show ordernumber in basket.pl tables Test plan: Verify the ordernumber is correctly displayed on the basket page (acqui/basket.pl?basketno=X) Signed-off-by: silvere Signed-off-by: Katrin Fischer Fixed a tiny typo in the HTML: > . Passes all tests and QA script. Tested that the ordernumber is now displayed and table sorting works for the smaller and more detailed table. Signed-off-by: Galen Charlton Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:25 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #56 from sandboxes at biblibre.com --- Created attachment 25092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25092&action=edit Bug 11439: (follow-up) adjust for change in list returned by OCLC XISBN The set of related ISBNs for the first Harry Potter book returned by OCLC's XISBN service has changed recently, so this patch adjusts the test to match. Signed-off-by: Galen Charlton Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:29 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #57 from sandboxes at biblibre.com --- Created attachment 25093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25093&action=edit Bug 9823: Refactor return from GetReservesFromBiblionumber The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaining a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. Signed-off-by: Marcel de Rooy Placed biblio holds, future holds and item holds. Works as expected. Tested Holds.t and Reserves.t. Pass. Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. Fine. C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. Looks good. Handled a few unneeded calls in QA follow-up. Left only one point to-do for serials/routing-preview.pl. See Bugzilla. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:34 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #58 from sandboxes at biblibre.com --- Created attachment 25094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25094&action=edit Bug 9823: QA follow-up for GetReservesFromBiblionumber calls The template params holds and holdcount are not used in the ISBD template. Removed the associated code from catalogue/ISBDdetail.pl. Same applies for catalogue/MARCdetail.pl and labeledMARCdetail.pl. Same applies also for catalogue/imageviewer.pl. Same applies also for catalogue/moredetail.pl. In catalogue detail.tt only the number of holds is used. Removed the code that passed the holds array to the template. For consistency opac-detail should also incorporate future holds into its holds count; added the all_dates parameter for that reason. The Reserves module is no longer needed in moredetail. Removed it. Checked the other scripts also. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:38 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #59 from sandboxes at biblibre.com --- Created attachment 25095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25095&action=edit Bug 9823: (follow-up) improve POD for C4::Reserves::GetReservesFromBiblionumber Signed-off-by: Galen Charlton Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:43 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #60 from sandboxes at biblibre.com --- Created attachment 25096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25096&action=edit Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names Signed-off-by: Brendan Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:47 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #61 from sandboxes at biblibre.com --- Created attachment 25097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25097&action=edit Bug 7679: Followup: circulation statistics wizard improvements Signed-off-by: Brendan Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:51 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #62 from sandboxes at biblibre.com --- Created attachment 25098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25098&action=edit Bug 7679: Fix criteria display Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:11:56 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #63 from sandboxes at biblibre.com --- Created attachment 25099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25099&action=edit Bug 7679: Group different case values in the same row/column Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:12:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:12:00 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #64 from sandboxes at biblibre.com --- Created attachment 25100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25100&action=edit Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:15:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:15:06 +0000 Subject: [Koha-bugs] [Bug 11701] New: Fix C4::Context::Zconn Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Bug ID: 11701 Summary: Fix C4::Context::Zconn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When calling C4::Context::Zconn once with async=0, then once again with async=1, the same ZOOM::Connection object is returned twice (with option async=0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:15:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:15:37 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #65 from Koha Team AMU --- (In reply to Julian Maurice from comment #53) > The last patch should fix issue of comment 50 The acquired date filter is ok with this patch. I find the same results using SQL request and statistics wizards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:15:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:15:58 +0000 Subject: [Koha-bugs] [Bug 11701] Fix C4::Context::Zconn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 --- Comment #1 from Julian Maurice --- Created attachment 25101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25101&action=edit Bug 11701: Unit tests for C4::Context::Zconn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:16:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:16:01 +0000 Subject: [Koha-bugs] [Bug 11701] Fix C4::Context::Zconn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 --- Comment #2 from Julian Maurice --- Created attachment 25102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25102&action=edit Bug 11701: Fix C4::Context::Zconn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:16:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:16:21 +0000 Subject: [Koha-bugs] [Bug 11701] Fix C4::Context::Zconn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:16:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:16:32 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:17:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:17:01 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25089|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Comment on attachment 25089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25089 Fix C4::Context::Zconn() Obsolete patch on Zconn (new bug 11701) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 16:22:20 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize --- Hi Holger, It's great to see another new developer! Your code looks good to me, and I'm just running through testing it for bugs now. As a quick comment, I'de love to see a minor enhancement to this. It would be great if you could pass the number of days before renewal allowed in the error, and display this useful piece of information in the error message given to users? Otherwise, I'm pretty happy to sign-off once I've completed my testing. Great to have you on-board. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:08:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 17:08:50 +0000 Subject: [Koha-bugs] [Bug 11702] New: Can't specify date for automatic resumption of suspended hold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11702 Bug ID: 11702 Summary: Can't specify date for automatic resumption of suspended hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Hold requests Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you suspend an individual hold in either the OPAC or staff client and specify a date for automatic resumption the date is not saved correctly. To reproduce in the OPAC: 1. Turn on RequestOnOpac, AutoResumeSuspendedHolds, and SuspendHoldsOpac 2. Log in to the OPAC and place a hold 3. View the list of your existing holds (opac-user.pl) 4. Choose an individual hold to suspend, specify a suspend-until date, and submit 5. When the page reloads the hold will say "Suspended until 02/00/0" To reproduce in the staff client: 1. Turn on AutoResumeSuspendedHolds and SuspendHoldsIntranet 2. Place a hold for a patron, or find an existing hold 3. View the hold details page for that hold (/cgi-bin/koha/reserve/request.pl?biblionumber=XX) 4. Specify a suspend-until date for the hold and submit 5. When the page reloads the hold will say "Unsuspend on" and show no date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:30:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 17:30:50 +0000 Subject: [Koha-bugs] [Bug 11702] Can't specify date for automatic resumption of suspended hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11702 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:30:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 17:30:56 +0000 Subject: [Koha-bugs] [Bug 11702] Can't specify date for automatic resumption of suspended hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11702 --- Comment #1 from Owen Leonard --- Created attachment 25103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25103&action=edit Bug 11702 - Can't specify date for automatic resumption of suspended hold When suspending an individual hold in the OPAC or staff client the date of resumption is saved as '000-00-00' no matter what dateformat setting you use. This is not true of performing a suspend-all action. This patch changes the date handling in C4::Reserves::ToggleSuspend to match that in C4::Reserves::SuspendAll. To test in the OPAC: 1. Turn on RequestOnOpac, AutoResumeSuspendedHolds, and SuspendHoldsOpac. 2. Log in to the OPAC and place a hold. 3. View the list of your existing holds (opac-user.pl). 4. Choose an individual hold to suspend, specify a suspend-until date, and submit. 5. When the page reloads the suspension should be saved with the correct resumption date. Test using all dateformat system preference options. Also test suspensions without resumption dates. To test in the staff client: 1. Turn on AutoResumeSuspendedHolds and SuspendHoldsIntranet. 2. Place a hold for a patron, or find an existing hold. 3. View the hold details page for that hold (/cgi-bin/koha/reserve/request.pl?biblionumber=XX). 4. Specify a suspend-until date for the hold and submit. 5. When the page reloads the hold should say "Unsuspend on" and show the correct resumption date. Test using all dateformat system preference options. Also test suspensions without resumption dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:31:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 17:31:28 +0000 Subject: [Koha-bugs] [Bug 11694] Improve handling of individual hold suspension In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:31:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 17:31:28 +0000 Subject: [Koha-bugs] [Bug 11702] Can't specify date for automatic resumption of suspended hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11702 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11694 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 17:58:04 +0000 Subject: [Koha-bugs] [Bug 11694] Improve handling of individual hold suspension in Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve handling of |Improve handling of |individual hold suspension |individual hold suspension | |in Bootstrap OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:05:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 18:05:10 +0000 Subject: [Koha-bugs] [Bug 11694] Improve handling of individual hold suspension in Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:05:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 18:05:15 +0000 Subject: [Koha-bugs] [Bug 11694] Improve handling of individual hold suspension in Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11694 --- Comment #1 from Owen Leonard --- Created attachment 25104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25104&action=edit Bug 11694 - Improve handling of individual hold suspension in Bootstrap OPAC This patch changes the way the controls to suspend and resume holds are displayed on the OPAC for a logged-in user when using the Bootstrap theme. Instead of showing all the suspend options in the table cell a link will trigger a modal with the controls. This makes the table more compact and readable. The patch adds a span and class to the dateformat include so that the dateformat hint can be hidden if JavaScript is enabled (and thus the datepicker will use the correct format automatically). A new class has been added to the CSS, ".js-show" to be used for elements which should be hidden if JavaScript is disabled and made visible by JavaScript if it is enabled. To test you must have RequestOnOpac, SuspendHoldsOpac, and the bootstrap theme enabled. Apply the patch for Bug 11702 if necessary in order for suspend-until dates to be saved correctly. Apply the patch and test with AutoResumeSuspendedHolds enabled: 1. Log in to the OPAC and place a hold. 2. View the list of your holds in the OPAC. 3. Click the "Suspend" link for your new hold. A modal window should appear allowing you to specify a suspend-until date. 4. Specify a suspend-until date. Test the "clear" link and confirm that it clears the date. 5. Specify a suspend-until date and submit. 6. Confirm that the hold has been suspended with the specified resumption date. 7. Click the "Resume" link on the suspended hold to resume. 8. Click the "Suspend" link again and submit without specifying a date. 9. Confirm that the hold has been suspended indefinitely. Follow the same steps above with JavaScript disabled. The "suspend until" options will appear inside the table as before and everything should work correctly. Test with AutoResumeSuspendedHolds disabled. No modal dialog should appear when the "Suspend" link is clicked. The hold should simply be suspended indefinitely. Test again with JavaScript disabled. There should be no change in functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 18:50:32 +0000 Subject: [Koha-bugs] [Bug 11703] New: Convert checkouts table to ajax datatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Bug ID: 11703 Summary: Convert checkouts table to ajax datatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:50:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 18:50:40 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:51:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 18:51:16 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #1 from Kyle M Hall --- Created attachment 25105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25105&action=edit WIP - Bug 11703 - Convert checkouts table to ajax datatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:52:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 18:52:31 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11518 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:52:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 18:52:31 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 20:15:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 19:15:43 +0000 Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 20:15:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 19:15:47 +0000 Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22166|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 25106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25106&action=edit [SIGNED-OFF] Bug 11094 - Bootstrap theme: typo loaction This patch fixes a typo on opac-user.tt To test you must have existing holds on your account. Log into the OPAC and view the holds tab on the "your summary" page (opac-user.pl). Resize the browser window until the table switches from a regular table layout to a vertical column. Only when the view is narrow enough does the affected label appear: Pick up location: [library name] Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:03:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:03:14 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:23:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:23:10 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Owen Leonard --- Both of these patches appear to be signed off, so I'm changing this bug's status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:25:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:25:56 +0000 Subject: [Koha-bugs] [Bug 11704] New: Wrong headers in {opac|intranet}/svc/report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 Bug ID: 11704 Summary: Wrong headers in {opac|intranet}/svc/report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org As they are not made explicit, the opac/svc/report script falls back to ISO-8859 encoding. To reproduce: - Create a PUBLIC report from SQL like: SELECT title, author FROM biblio LIMIT 10 - Make sure the report (tweak it so that...) returns some titles/authors that contain diacritics and non-latin characters (e.g. ??). - Call the report from the OPAC like: http://opac/cgi-bin/koha/svc/report?id=1%name=Tomas => Notice the characters are broken - Call the report from the STAFF interface like: http://opac/cgi-bin/koha/svc/report?id=1%name=Tomas => Notice the characters are broken Note: - 1 is the report's ID - "Tomas" is an arbitrary string I guess -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:29:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:29:24 +0000 Subject: [Koha-bugs] [Bug 11704] Wrong headers in {opac|intranet}/svc/report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 25107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25107&action=edit Evidence of wrong headers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:34:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:34:17 +0000 Subject: [Koha-bugs] [Bug 11704] Wrong headers in {opac|intranet}/svc/report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:34:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:34:22 +0000 Subject: [Koha-bugs] [Bug 11704] Wrong headers in {opac|intranet}/svc/report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 25108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25108&action=edit Bug 11704: Make */svc/report print the correct headers To test: 1 - Go through the first comments instructions to reproduce and verify the bug is present (OPAC and STAFF) 2 - Apply the patch 3 - Repeat step 1 and notice * characters are not broken anymore * the header is correct 4 - Sign off Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:37:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:37:35 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Katrin Fischer --- Hi Holger, thx for testing! Reading your comment I think this is a failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:41:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:41:22 +0000 Subject: [Koha-bugs] [Bug 11704] Wrong headers in {opac|intranet}/svc/report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 25109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25109&action=edit Evidence of good headers (with the patch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:53:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 20:53:47 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25105|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 25110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25110&action=edit WIP - Bug 11703 - Convert checkouts table to ajax datatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 22:21:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 21:21:13 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25110|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 25111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25111&action=edit WIP - Bug 11703 - Convert checkouts table to ajax datatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:10:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 23:10:18 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #28 from M. Tompsett --- I'm not sure that is right, because I tweaked the second patch and signed it off. I think the second patch needs proper sign off by someone else before being marked as signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:20:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 23:20:54 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:58:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2014 23:58:59 +0000 Subject: [Koha-bugs] [Bug 11705] New: New Debian policy enforcement is breaking the build script Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11705 Bug ID: 11705 Summary: New Debian policy enforcement is breaking the build script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Koha is packaged as a Debian native package. The build tools in debian testing now enforce the policy that native packages shouldn't have -1 in the version (i.e. shouldn't have a debian version part.) For now this is fixed by removing the -1, ultimately Koha shouldn't be a Debian native package. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 01:14:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 00:14:51 +0000 Subject: [Koha-bugs] [Bug 11705] New Debian policy enforcement is breaking the build script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11705 --- Comment #1 from Robin Sheat --- Created attachment 25112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25112&action=edit Bug 11705 - change versioning of build-git-snapshot This change makes the package versions conform to debian requirements for native packages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 01:59:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 00:59:05 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #17 from David Cook --- (In reply to Olli-Antti Kivilahti from comment #16) > Hi there! > > Applied the bug. > I am noticing a huge performance drop with cronjobs/overdue_notices.pl > > getting 12 items to the message_queue takes 31s with this feature applied. > getting 12 items to the message_queue takes 1s without this feature applied. > > oops... I've reproduced this problem as well, although I'm getting 35 items at around 31s. When I use strace, I'm noticing that 99% of the time is being spent on "brk" syscalls. I'm guessing the regex or the DateTime conversions are slowing things? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:40:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:40:53 +0000 Subject: [Koha-bugs] [Bug 11660] tools/pdfViewer.pl is vulnerable to displaying the contents of an arbitrary file on the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11660 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing Version|unspecified |master Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:41:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:41:10 +0000 Subject: [Koha-bugs] [Bug 11660] tools/pdfViewer.pl is vulnerable to displaying the contents of an arbitrary file on the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11660 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:41:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:41:46 +0000 Subject: [Koha-bugs] [Bug 11661] edithelp.pl can be used to write arbitrary files to the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11661 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing Version|unspecified |master Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:42:04 +0000 Subject: [Koha-bugs] [Bug 11661] edithelp.pl can be used to write arbitrary files to the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11661 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:42:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:42:38 +0000 Subject: [Koha-bugs] [Bug 11662] member-picupload.pl can write to arbitrary files on the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11662 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing Version|unspecified |master Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:43:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:43:00 +0000 Subject: [Koha-bugs] [Bug 11662] member-picupload.pl can write to arbitrary files on the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11662 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:43:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:43:11 +0000 Subject: [Koha-bugs] [Bug 11666] admin/import_export_framework.pl allows execution of arbitrary SQL without authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11666 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing Version|unspecified |master Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:43:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:43:21 +0000 Subject: [Koha-bugs] [Bug 11666] admin/import_export_framework.pl allows execution of arbitrary SQL without authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11666 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:58:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 01:58:16 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #18 from David Cook --- I thought about using DBIX::Class via Koha::Database to figure out the data type for the column, but I don't think that's going to be practical in this case, since the sourcename for the Koha::Schema::Result classes are sometimes quite different from the actual table name (e.g. borrowers vs Borrower, or MatcherMatchpoint vs matcher_matchpoints). I suppose we also have to consider...is decreased performance worth having correct timestamps? It might be worth testing this with a much larger load than 10-30 notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 03:05:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 02:05:34 +0000 Subject: [Koha-bugs] [Bug 11660] tools/pdfViewer.pl is vulnerable to displaying the contents of an arbitrary file on the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11660 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Galen Charlton --- Included in the following releases: 3.8.23, 3.10.13, 3.12.10, and 3.14.3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 03:05:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 02:05:43 +0000 Subject: [Koha-bugs] [Bug 11661] edithelp.pl can be used to write arbitrary files to the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11661 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Galen Charlton --- Included in the following releases: 3.8.23, 3.10.13, 3.12.10, and 3.14.3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 03:05:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 02:05:50 +0000 Subject: [Koha-bugs] [Bug 11662] member-picupload.pl can write to arbitrary files on the server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11662 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Galen Charlton --- Included in the following releases: 3.8.23, 3.10.13, 3.12.10, and 3.14.3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 03:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 02:05:57 +0000 Subject: [Koha-bugs] [Bug 11666] admin/import_export_framework.pl allows execution of arbitrary SQL without authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11666 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Galen Charlton --- Included in the following releases: 3.8.23, 3.10.13, 3.12.10, and 3.14.3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 03:07:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 02:07:02 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #19 from David Cook --- (In reply to David Cook from comment #18) > I thought about using DBIx::Class via Koha::Database to figure out the data > type for the column, but I don't think that's going to be practical in this > case, since the sourcename for the Koha::Schema::Result classes are > sometimes quite different from the actual table name (e.g. borrowers vs > Borrower, or MatcherMatchpoint vs matcher_matchpoints). > > I suppose we also have to consider...is decreased performance worth having > correct timestamps? > > It might be worth testing this with a much larger load than 10-30 notices. Sorry to keep spamming everyone, but perhaps it would be a good idea to add a "source_name" alias to each Result class so that we can use the actual table name as a source name when trying to use DBIx::Class. http://search.cpan.org/~ribasushi/DBIx-Class-0.08270/lib/DBIx/Class/ResultSource.pm#source_name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 03:57:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 02:57:09 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Fr?d?rick, do you have any use cases besides the @attr 4 you mentioned? In this case, I think it might be a better idea to add a "structure" drop-down menu to the Z39.50 search pages. That way, people could specify "phrase" (@attr 4=1) or word (@attr 4=2). If we default to "phrase", that would resolve your problem, I believe. I haven't tried the patch, but your patch seems a bit unwieldy to me conceptually. Perhaps you could explain its utility a bit more? -- Personally, I would really like to see a table for mapping Bib-1/PQF attributes to specific Z39.50 servers, since different servers (especially Innovative Interfaces, iirc) often implement different Bib-1 attributes for particular indexes, despite the standard profile. However, I think that's tangential to the issue you're describing here, yes? Source: http://www.loc.gov/z3950/agency/defns/bib1.html#structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 06:28:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 05:28:50 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 JB changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 06:30:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 05:30:24 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 JB changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |3.12 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 06:31:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 05:31:53 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 JB changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |OPAC Version|3.12 |3.14 Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 09:09:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 08:09:35 +0000 Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m Version|3.14 |master --- Comment #26 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.4. RM announced this bug can be pushed in stable branches but will not be in master, waiting for Bug 11096. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 09:10:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 08:10:29 +0000 Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 09:29:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 08:29:31 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 --- Comment #6 from M. de Rooy --- Tested in bootstrap. Enable pref, create new public list in opac. Disable pref. Edit same list in opac and Save. Public list is now a private list.. (This is new behavior; tested it too without the patch.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 09:35:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 08:35:24 +0000 Subject: [Koha-bugs] [Bug 11706] New: Typo "efault" in updatedatabase.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11706 Bug ID: 11706 Summary: Typo "efault" in updatedatabase.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org installer/data/mysql/updatedatabase.pl: VALUES ( "issues to claim", "efault CSV export for serial issue claims", "efault", should be "Default" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 09:54:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 08:54:56 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #16 from Holger Mei?ner --- Thank you, Martin! (In reply to Martin Renvoize from comment #15) > As a quick comment, I'de love to see a minor enhancement to this. It would > be great if you could pass the number of days before renewal allowed in the > error, and display this useful piece of information in the error message > given to users? Yes, that's a good idea. I'll do this as a follow-up. I also noticed that unit test t/db_dependent/Circulation_Issuingrule.t fails. I'll do a follow-up for this too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:12:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:12:39 +0000 Subject: [Koha-bugs] [Bug 11707] New: Additional attributes broken for category code with space Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11707 Bug ID: 11707 Summary: Additional attributes broken for category code with space Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When editing additional attributes of a patron of a category with a code with space (ie "CAT 3"), the Javascript is broken and Additional attributes are not displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:19:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:19:39 +0000 Subject: [Koha-bugs] [Bug 11707] Additional attributes broken for category code with space In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11707 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:19:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:19:41 +0000 Subject: [Koha-bugs] [Bug 11707] Additional attributes broken for category code with space In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11707 --- Comment #1 from Fridolin SOMERS --- Created attachment 25113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25113&action=edit Bug 11707 - Additional attributes broken for category code with space When editing additional attributes of a patron of a category with a code with space (ie "CAT 3"), the Javascript is broken and Additional attributes are not displayed. This patch corrects by adding simple quotes aroud category code in JS code. Test plan : - Create an patron additional attribute - Create a new patron category with a space in code. ie "CAT 3" - Create a new patron of this category : /cgi-bin/koha/members/memberentry.pl?op=add&categorycode=CAT 3 => Without patch the JS is broken (Syntax error, unrecognized expression: [data-category_code=CAT 3]) and additional attributes are not displayed. => With patch the JS is not broken and additional attributes are displayed and can be edited. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:40:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:40:26 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #17 from Martin Renvoize --- Hi Holger, Well spotted on the unit tests, I hadn't found that issue yet.. I had a bit of a mare getting my test environment circulation working to test the feature, I'm hoping to test properly later today. I'll hold off on a signoff until I see the unit tests patch go in, as failing unit test would only get caught at the QA level, so it'll save us both hassle if it passes those before QA give it the evil eye ;) Great work, Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:44:32 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23573|0 |1 is obsolete| | --- Comment #47 from M. de Rooy --- Created attachment 25114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25114&action=edit Bug 11078 Add locking to rebuild_zebra.pl This patch adds locking to rebuild_zebra.pl to ensure that simultaneous changes are prevented (as one is likely to overwrite the other). Incremental updates in daemon mode will skipped if the lock is busy and they will be picked up on the next pass. Non-daemon mode invocations will wait for the lock to clear and then proceed. Supporting changes made to Makefile.PL and templates for the new locking directory (paralleling the other zebra lock directories). We stash the zebra_lockdir in koha-conf.xml so rebuild_zebra.pl can find it. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Amended the patch: just added the /rebuild from the follow-up. Works as advertised, but I post some comments on Bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:47:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:47:01 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Command-line Utilities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:47:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:47:29 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:47:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:47:41 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:47:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:47:57 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:48:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:48:12 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:48:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:48:31 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:48:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:48:50 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|6435 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:48:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 09:48:50 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11078 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:20:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 10:20:31 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #29 from Magnus Enger --- Could the "MARC Modification Templates" introduced by Byg 8015 be extended to modify records that are imported via Z39.50 to? Docs: http://manual.koha-community.org/3.14/en/catalogtools.html#marcmodtemplates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 10:27:38 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from M. de Rooy --- QA Comment: First, I like this patch and would like to see it reach master soon. Compliments for the solid testing of Martin by the way. I have taken the liberty of trusting Martin and Robin here for the package related stuff. I tested daemon and non-daemon simultaneously. Added some debug sleeps and prints to have some grip on the tests. Although I am inclined to pass QA on this patch (no complaints from qa tools), I see some room for minor improvements in a follow-up: 1) There is the probably very rare circumstance of: The flock call produces a fatal error if used on a machine that doesn't implement flock(2), fcntl(2) locking, or lockf(3). Could you wrap the flock call inside an eval in a function? The daemon should only eval the flock at least once.. 2) You are waiting on the lock with the one-time invocation. If I am not running daemon mode, but I run the one-time invocation via cron very regularly, I would (personally) prefer to skip the one-pass instead of waiting for the lock. I agree that it is somewhat arbitrary what is the best thing here. Could we resolve that by adding a simple command-line parameter that tells rebuild-zebra to wait or skip? (Skip by default, I guess :-) 3) What about t/db_dependent/zebra_config.pl, called from Search.t? 4) And finally :) what about the defaulting to /var/lock if the zebra lock has not been defined or so? mkdir /var/lock/rebuild: Permission denied at misc/migration_tools/rebuild_zebra.pl line 161. I guess that this permission problem could popup in many cases more.. With four points after all, I am sorry that I did no longer dare to move it to Passed QA rightaway. So first setting it to Failed QA in order to get some feedback. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:34:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 10:34:35 +0000 Subject: [Koha-bugs] [Bug 11708] New: Display all basketgroups on one page, and new column aqbasketgroups.closeddate Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Bug ID: 11708 Summary: Display all basketgroups on one page, and new column aqbasketgroups.closeddate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:35:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 10:35:27 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #1 from Julian Maurice --- Created attachment 25115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25115&action=edit Bug 11708: Add aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:35:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 10:35:31 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #2 from Julian Maurice --- Created attachment 25116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25116&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:35:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 10:35:35 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #3 from Julian Maurice --- Created attachment 25117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25117&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:35:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 10:35:57 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:13:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 11:13:50 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:13:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 11:13:54 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25084|0 |1 is obsolete| | --- Comment #61 from M. de Rooy --- Created attachment 25118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25118&action=edit Bug 8918: t/db_dependent/Reserves.t fails if marcflavour is UNIMARC Set marcflavour to MARC21 to make tests pass. Signed-off-by: Marcel de Rooy Works for MARC21. But I would prefer a better fix for UNIMARC. Will send a follow-up for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:14:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 11:14:06 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #62 from M. de Rooy --- Created attachment 25119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25119&action=edit Bug 8918: Follow-up for use of AddBiblio in Reserves.t with UNIMARC Changed title and author field for UNIMARC. Signed-off-by: Marcel de Rooy Tested for MARC21, NORMARC and UNIMARC by adding temporary set_preference.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:18:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 11:18:34 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:43:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 12:43:49 +0000 Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:43:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 12:43:52 +0000 Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25106|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 25120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25120&action=edit Bug 11094 - Bootstrap theme: typo loaction This patch fixes a typo on opac-user.tt To test you must have existing holds on your account. Log into the OPAC and view the holds tab on the "your summary" page (opac-user.pl). Resize the browser window until the table switches from a regular table layout to a vertical column. Only when the view is narrow enough does the affected label appear: Pick up location: [library name] Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:44:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 12:44:35 +0000 Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:56:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 12:56:48 +0000 Subject: [Koha-bugs] [Bug 11687] statecollection.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:56:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 12:56:51 +0000 Subject: [Koha-bugs] [Bug 11687] statecollection.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25085|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 25121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25121&action=edit Bug 11687: statecollection.pl is no longer in use It can be removed. Test plan: git grep statecollection returns no occurrence. http://bugs.koha-community.org/show_bug.cgi?id=11682 Signed-off-by: Holger Meissner Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:57:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 12:57:17 +0000 Subject: [Koha-bugs] [Bug 11687] statecollection.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11687 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Trivial patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #4 from M. de Rooy --- Commit 3519c9540a1ed96e2d6621bb30738f0c3cc3233c removed this file in 2007, but commit e9ae8c0686629747415ade8e2b8d69defeccbc62 reintroduced it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:07:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:07:05 +0000 Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and MARC21 in some sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:07:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:07:08 +0000 Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and MARC21 in some sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24734|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 25122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25122&action=edit Bug 11611: Rephrase description and examples of 5 MARC related sysprefs This patch rephrases the description or examples of 5 sysprefs: 1/ MARCAuthorityControlField008: "MARC" -> "MARC21" 2/ itemcallnumber: "Examples" -> "Examples (for MARC21 records)" 3/ DefaultLanguageField008: "Range 35-37" -> "Range 35-37 of MARC21 records" 4/ MARCOrgCode: "new MARC records" -> "new MARC21 records" 5/ UNIMARCAuthorityField100 description: "Do NOT include the date (position 00-05)." -> "position 08-35. Do NOT include the date (position 00-07)." It also adds description in sql systempreferences table for UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode Test plan: Apply and run updatedatabase.pl Check the changes are taken into account in syspref administration page Check the changes are taken into account in systempreferences table (for UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:09:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:09:06 +0000 Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and MARC21 in some sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611 --- Comment #5 from M. de Rooy --- (In reply to M. Tompsett from comment #3) > I am wondering about NORMARC, RUSMARC, or other MARC variants which are more > closely related to MARC21, but are not exactly MARC21. Is changing the MARC > to MARC21 a good idea? Just text :) In balance, we are improving the situation (esp. the number of leading chars..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:17:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:17:00 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Depends on|11146 | Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:17:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:17:00 +0000 Subject: [Koha-bugs] [Bug 11146] Show a go back link on no permission page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11146 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11400 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:29:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:29:22 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from M. de Rooy --- Scrolling through the last comments, I also agree that the Previous page button is not really placed very nice (not to say ugly :) Login is no verb, so it should be Log in. (Note that this occurs in more places.) And if you add the sentence "Log in as a different user", what about adding the other possibility of going back too? So: Log in as a different user or go back to the previous page? On the other hand, adding even more text and buttons will probably not improve the current form. So this is a hard one. Moving it to In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:56:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:56:07 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24571|0 |1 is obsolete| | Attachment #24572|0 |1 is obsolete| | Attachment #24573|0 |1 is obsolete| | Attachment #24574|0 |1 is obsolete| | Attachment #24575|0 |1 is obsolete| | Attachment #24576|0 |1 is obsolete| | Attachment #25006|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall --- Created attachment 25123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25123&action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:56:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:56:28 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #65 from Kyle M Hall --- Created attachment 25124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25124&action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:56:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:56:32 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #66 from Kyle M Hall --- Created attachment 25125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25125&action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:56:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:56:36 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #67 from Kyle M Hall --- Created attachment 25126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25126&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:56:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:56:41 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #68 from Kyle M Hall --- Created attachment 25127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25127&action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:56:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:56:45 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #69 from Kyle M Hall --- Created attachment 25128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25128&action=edit Bug 9016: QA Followup Fix tab characters and POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:56:49 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #70 from Kyle M Hall --- Created attachment 25129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25129&action=edit Bug 9016: Fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:56:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 13:56:55 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #71 from Kyle M Hall --- Created attachment 25130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25130&action=edit Bug 9016 [QA Followup] - Add insertAtCaret library to about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:10:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:10:50 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 --- Comment #7 from Owen Leonard --- (In reply to M. de Rooy from comment #6) > Enable pref, create new public list in opac. > Disable pref. Edit same list in opac and Save. I see the problem, but this presents an interesting question... If you have changed your library policy to disallow creation of public lists should it be possible for the general public to keep a list public? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:13:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:13:40 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25090|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Created attachment 25131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25131&action=edit Bug 11411 - Bootstrap theme (enhancement) for (right to left) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:13:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:13:52 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 --- Comment #11 from Kyle M Hall --- Created attachment 25132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25132&action=edit Bug 11411 [QA Followup] - Tidy css to restore readability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:14:05 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:23:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:23:43 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24998|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 25133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25133&action=edit Bug 11605: default entry is 20 for all tables using datatables The default entry is 20 and can be apply to all tables. Bug 11555 apply the menu entries to all tables, redefining it is uesless and can be removed. Test plan: Test pages impacted by this patch and verify there is no regression on the tables. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:23:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:23:55 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24999|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 25134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25134&action=edit Bug 11605: Fix regression Bug 11314 overrides the iDisplayLength and aLengthMenu values and should be kept. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:23:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:23:52 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:28:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:28:46 +0000 Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and MARC21 in some sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:28:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:28:48 +0000 Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and MARC21 in some sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25122|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 25135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25135&action=edit Bug 11611: Rephrase description and examples of 5 MARC related sysprefs This patch rephrases the description or examples of 5 sysprefs: 1/ MARCAuthorityControlField008: "MARC" -> "MARC21" 2/ itemcallnumber: "Examples" -> "Examples (for MARC21 records)" 3/ DefaultLanguageField008: "Range 35-37" -> "Range 35-37 of MARC21 records" 4/ MARCOrgCode: "new MARC records" -> "new MARC21 records" 5/ UNIMARCAuthorityField100 description: "Do NOT include the date (position 00-05)." -> "position 08-35. Do NOT include the date (position 00-07)." It also adds description in sql systempreferences table for UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode Test plan: Apply and run updatedatabase.pl Check the changes are taken into account in syspref administration page Check the changes are taken into account in systempreferences table (for UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:30:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:30:20 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #58 from Katrin Fischer --- Hi Kyle, could you please syspref the feature in staff/intranet? Additionally I think the options in the patron account shoudl only be visible when BorrowerRelationships is not empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:40:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:40:46 +0000 Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:40:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:40:48 +0000 Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25050|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 25136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25136&action=edit Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. --------------------------------------------------------------------- Created to patron lists and confirmed the collums 'add patrons', 'edit' and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list' are still sortable. The size of buttons are smaller. I also agree this is an improvement. Signed-off-by: Petter Goksoyr Asen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:49:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:49:50 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:49:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2014 14:49:54 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25058|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 25137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25137&action=edit Bug 10865 [Revised] Don't show list permissions when adding public lists/sharing lists is not allowed If patron creation of public lists is disallowed by the OpacAllowPublicListCreation system preference the "category" option should be hidden altogether instead of showing a with "private" as the only option. This patch hides category and permissions controls when OpacAllowPublicListCreation is set to "don't allow." To test you must have the virtualshelves system preference enabled. Apply the patch and log into the OPAC. Test: - With OpacAllowPublicListCreation enabled, create a new list. You should see options for setting category and permissions. Saving the new list should complete correctly and save the right settings. - With OpacAllowPublicListCreation enabled, edit an existing list. You should see the same options and saving your changes should work correctly. - With OpacAllowPublicListCreation disabled, create a new list. You should only see fields for title and sort. Saving this list should complete correctly and save the right settings. - With OpacAllowPublicListCreation disabled, edit an existing list. You should be able to edit only title and sort settings. Saving your changes should work correctly. Repeat your tests for both prog and bootstrap themes. Revision: Existing public lists can be edited and retain their public status even if OpacAllowPublicListCreation has since been disabled. This preserves the behavior previous to this patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:21:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:21:07 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:21:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:21:24 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:25:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:25:30 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #16 from Katrin Fischer --- All the SIP messages are currently in English and untranslatable. I think this is something for a more general bug and should not be a blocker here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:28:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:28:57 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 --- Comment #10 from Jacek Ablewicz --- Created attachment 25169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25169&action=edit Bug 11680: (follow-up) tax rate changes on edit Follow-up to fix similar issue on vendor edit. If the tax rates in Acquisitions -> gist system preference are entered with trailing zeroes, given vendor tax rate value may not be correctly handled on vendor edit. Test plan for this follow-up: 1) insert some tax rates with trailing zeroes in gist system preference (e.g: '0|0.080|0.12|0.20|0.23') 2) add some vendors, choosing 8.0% 12.0% 20.0% 23.0% as gst rate 3) try to modify them 4) note that vendors with 12.0% and 23.0% tax rates are preserving previously choosen rates on edit, while the ones with 8.0% and 20.0% do not (they are defaulting to the first defined tax rate) 5) apply the patch 6) repeat 2) and 3) 7) all tax rates configured in system prefrence shall now behave properly while editing vendors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:31:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:31:05 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #17 from paxed --- (In reply to Katrin Fischer from comment #16) > All the SIP messages are currently in English and untranslatable. I think > this is something for a more general bug and should not be a blocker here. Except this is added to the payment description, it's not a SIP message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:35:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:35:20 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #18 from Katrin Fischer --- Ah, thx for clarifying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:48:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:48:56 +0000 Subject: [Koha-bugs] [Bug 11730] New: C4::Charset call C4::Context without use it Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11730 Bug ID: 11730 Summary: C4::Charset call C4::Context without use it Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: stephane.delaune at biblibre.com QA Contact: testopia at bugs.koha-community.org C4::Charset call C4::Context without use it ; so when a script call SetMarcUnicodeFlag it returen : "Can't locate object method "preference" via package "C4::Context" (perhaps you forgot to load "C4::Context"?) at /home/gboisson/workspace/versions/community/C4/Charset.pm line 330". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:57:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:57:08 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 --- Comment #19 from M. de Rooy --- (In reply to M. de Rooy from comment #18) > Note: get_baskets_to_delete will not return all deletable baskets in dry-run > mode. Not sure if you should really need that, but the information now is > not accurate.. I reread one of my earlier comments on this report. I still prefer to delete in terms of completed baskets than completed orders. Actually the Koha basket is "the order" and the Koha order is "an order line". If all order lines have been processed and pass the date filter, the basket could be deleted via DelBasket with a cascading effect to aqorders and aqorders_items. I agree with Galen for the folder. I would also suggest to move it to misc/maintenance. No problem to run a cron job from there, but most people will probably run this at most annually and manually :) In order to meet the concerns raised about deleting valuable acquisition history, what do you think about adding a few lines that copy aqbasket, aqorders and aqorders_items for the selected baskets into some [temporary] archive tables and dumping these tables to file? The archive and sqldump steps could be parametrized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:58:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:58:20 +0000 Subject: [Koha-bugs] [Bug 11730] C4::Charset call C4::Context without use it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11730 --- Comment #1 from stephane.delaune at biblibre.com --- Created attachment 25170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25170&action=edit proposed patch proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:58:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 09:58:32 +0000 Subject: [Koha-bugs] [Bug 11730] C4::Charset call C4::Context without use it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11730 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:06:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 10:06:12 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:08:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 10:08:05 +0000 Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #11 from M. de Rooy --- (In reply to Galen Charlton from comment #10) > It's a pity not having the foreign key constraints, but on balance there's > too much potential need for library staff to need to refer to both ordered > bibs and items for a period of time, even after the items or bibs are > deleted in cataloging. At least we have a FK on ordernumber in aqorders_items. Closing this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:25:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 10:25:16 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:31:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 10:31:41 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8991 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:31:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 10:31:41 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10869 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:46:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 10:46:54 +0000 Subject: [Koha-bugs] [Bug 11731] New: Typo "tranports" in installation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11731 Bug ID: 11731 Summary: Typo "tranports" in installation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr message_transport_types.txt:Defines default message tranports for email and sms. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 12:12:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 11:12:57 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #55 from M. de Rooy --- (In reply to M. de Rooy from comment #54) > The questions on order level actually pertain to basket level also. If we > delete a basket, we do warn the user that he will lose his items. But he > does not have a choice between "Delete basket and orders" and "Delete > baskets, orders and items". > Is this getting too complicated now? We are/have been discussing deleting acquisition information on several reports now. The constraint on itemnumber in aqorders_items did not reach consensus (bug 11617). Please note also bug 8991. I think we should move the old completed baskets (with orders) to an archive table and offer the possibility to delete that too. What do you think? With respect to the angle of this report, I think it is somewhat strange to delete biblio and item records but leave an order (read: order line) in cancelled status with a Deleted bibliographic record, can't find title-line. There is much more information on a biblio record and we do not hesitate to delete it (with a copy in deletedbiblio) but we keep a deleted order (line) without title. Do we need some more community consensus on how to move such things further in Acquistion before deciding on several individual patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:06:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:06:19 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #10 from Petter Goks?yr ?sen --- > Seems this bug exists only since 3.14. Can you test on a fresh install ? By fresh install, do you mean the debian package? And not from git master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 12:57:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 11:57:15 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #15 from Tom?s Cohen Arazi --- The thing is, anyone using Debian packages doesn't have (by default) the rewrite rules wrapped in a conditional. Those are the users that need to be taken into account in this specific bug. This patch just captures the situation where mod_rewrite needs to be enabled by hand by the user, and prints a warning. Another option would be to make it conditional. I'd be in favour of not changing the current behaviour (which would mean wrapping the rewrite rules), but adding this warning, for the stable branches at least. Maybe for 3.16 we could just have the rewrite rules match those for tar.gz installs. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:28:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:28:11 +0000 Subject: [Koha-bugs] [Bug 11732] New: Eliminate warning on undefined branchcode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11732 Bug ID: 11732 Summary: Eliminate warning on undefined branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org When you run the Reserves test, you have the warnings: Use of uninitialized value $branchcode in hash element at /usr/share/koha/testclone/C4/Letters.pm line 138. Use of uninitialized value $branchcode in hash element at /usr/share/koha/testclone/C4/Letters.pm line 148. This patch removes that warning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:29:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:29:52 +0000 Subject: [Koha-bugs] [Bug 11732] Eliminate warning on undefined branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11732 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:29:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:29:55 +0000 Subject: [Koha-bugs] [Bug 11732] Eliminate warning on undefined branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11732 --- Comment #1 from M. de Rooy --- Created attachment 25171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25171&action=edit Bug 11732: Eliminate warning on undefined branchcode When you run the Reserves test, you have the warnings: Use of uninitialized value $branchcode in hash element at /usr/share/koha/testclone/C4/Letters.pm line 138. Use of uninitialized value $branchcode in hash element at /usr/share/koha/testclone/C4/Letters.pm line 148. This patch removes that warning. Test plan: Run the Reserves.t again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:06:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:06:19 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #10 from Petter Goks?yr ?sen --- > Seems this bug exists only since 3.14. Can you test on a fresh install ? By fresh install, do you mean the debian package? And not from git master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:30:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:30:11 +0000 Subject: [Koha-bugs] [Bug 11732] Eliminate warning on undefined branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11732 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:30:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:30:15 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #11 from Fridolin SOMERS --- (In reply to Petter Goks?yr ?sen from comment #10) > > Seems this bug exists only since 3.14. Can you test on a fresh install ? > > By fresh install, do you mean the debian package? And not from git master? No, I mean an install created from scratch, not an existing install with sources updated to current master. If someone else could test, it would be great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:33:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:33:22 +0000 Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item referring to more parts/volumes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #28 from M. de Rooy --- Obsoleting the patches for this report. Will probably come up with a new approach to get this moving. Back to Assigned for the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:33:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:33:54 +0000 Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item referring to more parts/volumes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:33:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:33:56 +0000 Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item referring to more parts/volumes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21741|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:33:58 +0000 Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item referring to more parts/volumes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21742|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:38:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:38:22 +0000 Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist and receivedlist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:39:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:39:36 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 Bug 10521 depends on bug 10520, which changed state. Bug 10520 Summary: Add i18n function to English mysql files for webinstaller http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:39:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:39:35 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:39:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:39:36 +0000 Subject: [Koha-bugs] [Bug 10526] Add i18n function to Norwegian mysql files for webinstaller (nb-NO) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10526 Bug 10526 depends on bug 10520, which changed state. Bug 10520 Summary: Add i18n function to English mysql files for webinstaller http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 12:39:37 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Bug 10572 depends on bug 10520, which changed state. Bug 10520 Summary: Add i18n function to English mysql files for webinstaller http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 14:08:20 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #55 from M. de Rooy --- Created attachment 25172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25172&action=edit Bug 11078: Follow-up for flock eval This patch adds a subroutine where the flock is once tested in an eval. Just to be sure that flock has been implemented and prevent a fatal error. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:09:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 14:09:58 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #56 from M. de Rooy --- (In reply to Doug Kingston from comment #49) > (In reply to M. de Rooy from comment #48) > Please point me at a similar usage elsewhere so I can make sure to do what > you intend here. Instead of looking for or describing it, I wrote a few lines. Please test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:15:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 14:15:41 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #57 from M. de Rooy --- > I do not have a preference on the default behavior here. I can also see > people being surprised that their command exits without waiting by default > as the most > likely interference is from an incremental update at about the same time > which will exit quickly. Adding a flag to control waiting or exiting is > fine. It should complement the default behavior. > > I would like some sort of consensus from the community before I start > changing code. If a couple of more people concur, I can make the change. > Lets try to close on this issue quickly - can you reach out to a couple of > senior folks for an opinion? Otherwise, lets leave as is. We have some replies now (moving the balance to skipping). The argument of a cronjob that starts a new incremental update every 2 minutes while the rebuild is running 60 minutes gives you 30 jobs just waiting, is imo sound enough to default to skip instead of wait. An additional parameter could be added to include the wait behavior as your patch implemented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:21:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 14:21:50 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #58 from M. de Rooy --- > > 4) And finally :) what about the defaulting to /var/lock if the zebra lock > > has not been defined or so? mkdir /var/lock/rebuild: Permission denied at > > misc/migration_tools/rebuild_zebra.pl line 161. I guess that this permission > > problem could popup in many cases more.. > > Something like this? > my $lockdir = C4::Context->config("zebra_lockdir") // "/var/lock"; > $lockdir .= "/rebuild"; > unless (-d $lockdir) { > make_path($lockdir, {verbose=>0, mode=>oct(755), error=>\$err}) > $lockdir = "/var/lock" if (@$err); > } > my $lockfile = $lockdir . "/rebuild..LCK"; Sorry, that my comment here was not that clear (defaulting was not the right word, it should better be fall back). I actually meant that we should better choose another folder than /var/lock. If you run the zebra job without root permissions, you will probably have no permissions in /var/lock. Since this should be an exception, why not just fall back to /tmp (OR just skip the locking stuff: if the install is dubious, who complains..) BTW there are other places in Koha where write permission in /tmp is just assumed. In every case, it is much more likely to be so. Your choice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:59:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 14:59:42 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 25173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25173&action=edit Bug 11509: (trivial rmaint followup) wrong parameter count While adding the --help and -h switches I forgot to change to arguments count validation so that one can actually use those parameters (i.e. koha-create should accept being invoked with only one parameter). This patch just changes the minimum parateres required from 2 to 1. To reproduce: - Run 'koha-create --help' from master => Usage information is printed BUT ALSO an "Error: wrong parameters" message - Apply the patch and - Run 'koha-create --help' => Usage informatio it printed and no error message. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:10:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:10:44 +0000 Subject: [Koha-bugs] [Bug 11718] Use new DataTables include in reports templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11718 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:10:47 +0000 Subject: [Koha-bugs] [Bug 11718] Use new DataTables include in reports templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11718 --- Comment #1 from Owen Leonard --- Created attachment 25174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25174&action=edit Bug 11718 - Use new DataTables include in reports templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all circ-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Reports -> Guided reports -> Use saved (reports/guided_reports.pl?phase=Use saved): "Creation date" sorting has been reconfigured to use the title-string method for sorting on an unformatted date. C4:Reports::Guided.pm has been modified to pass an unformatted date to the template. Sorting should work correctly for all settings of the dateformat system pref. - Reports -> Catalog by item type (reports/manager.pl?report_name=itemtypes) - Reports -> Serials statistics wizard (reports/serials_stats.pl): The subscription begin and subscription end columns have been modified to use the title-string filter for sorting. An unformatted date is now passed from reports/serials_stats.pl to the template, where the KohaDates filter is used for formatting. Sorting is based on the unformatted date. Sorting should work correctly for all settings of the dateformat system pref. - Sorting of titles should now exclude article from sorting. - Minor template improvements: - Vendor name now links to vendor details. - Subscription title now links to subscription details. - Library name is now shown instead of branchcode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:18:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:18:54 +0000 Subject: [Koha-bugs] [Bug 11692] number 9 showing on topissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11692 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:21:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:21:14 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |Pushed to Master --- Comment #9 from Galen Charlton --- I've pushed the follow-up to master. Thanks, Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:26:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:26:11 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:26:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:26:36 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:40:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:40:53 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:41:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:41:48 +0000 Subject: [Koha-bugs] [Bug 11521] Patron Cardnumber scanning causing patron record to be saved. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11521 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:45:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:45:21 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle field to biblio table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:45:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:45:44 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Setting back to needs signoff so that the follow-up can be tested. A couple notes: [1] The reason for the bug is that Template Toolkit's equality operator (==) is implemented using the Perl 'eq' operator. If the comparison were numeric, then 0.2 == 0.20 evaluates to true But since it's using 'eq', '0.2' eq '0.20' is NOT true The trick of adding 0.0 forces a normalization of the tax rate. [2] It would be worth writing a subroutine for getting the list of tax rates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:52:24 +0000 Subject: [Koha-bugs] [Bug 11556] Send any notice to any patron (or all patrons) on demand In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:54:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:54:14 +0000 Subject: [Koha-bugs] [Bug 11732] Eliminate warning on undefined branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11732 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- I tried to test this, but test 7 fails when I run: prove -v t/db_dependent/Reserves.t And an error message is not triggered even in master. I suspect I don't have things set to pretend to be logged in. This eyeballs just fine, but I was wondering... why not move line 129 to after the if? And why not // instead of ||? Sorry, I couldn't trigger this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:54:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:54:33 +0000 Subject: [Koha-bugs] [Bug 11733] New: "gist" system preference inconsistently treated as single-value or multi-value Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 Bug ID: 11733 Summary: "gist" system preference inconsistently treated as single-value or multi-value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The "gist" system preference, which specifies tax rates available for use in various places in acquisitions, lets the user specify multiple values separated by pipe symbols. The first value is taken to be the default tax rate to apply. However, there are some places in the code where it effectively assumes that gist contains only one value: acqui/basketgroup.pl: if ($bookseller->{invoiceincgst} && ! $bookseller->{listincgst} && ( $bookseller->{gstrate} // C4::Co acqui/basketgroup.pl: my $gst = $bookseller->{gstrate} // C4::Context->preference("gist"); acqui/basketgroup.pl: my $pdf = printpdf($basketgroup, $bookseller, $baskets, \%orders, $bookseller->{gstrate} // C4::Context-> acqui/invoice.pl:my $gist = $bookseller->{gstrate} // C4::Context->preference("gist") // 0; acqui/parcel.pl:my $gst = $bookseller->{gstrate} // C4::Context->preference("gist") // 0; and other places where it assumes (correctly) that it can have multiple values: acqui/neworderempty.pl:}, split( '\|', C4::Context->preference("gist") ); acqui/supplier.pl: }, split( '\|', C4::Context->preference("gist") ); Routines should be written for fetching either the list of tax rates or the default tax rate as needed. See also bug 11680. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:57:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:57:11 +0000 Subject: [Koha-bugs] [Bug 11721] Use new DataTables include in suggestions template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:59:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 15:59:45 +0000 Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:07:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 16:07:47 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #5 from Nicole C. Engard --- Created attachment 25175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25175&action=edit screenshot after applying all patches I like the idea but there are a few issues. First the inactive Budgets are showing. Next I have only 1 2011 budget but for some reason it shows 2 times... also I don't see the budget headings as clear dividers. They kind of blend in by having the white background. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:07:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 16:07:59 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:17:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 16:17:22 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:17:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 16:17:27 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17906|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 25176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25176&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:19:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 16:19:10 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25176|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 25177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25177&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:01:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:01:18 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:01:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:01:22 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #1 from Owen Leonard --- Created attachment 25178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25178&action=edit Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:02:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:02:38 +0000 Subject: [Koha-bugs] [Bug 11720] Use new DataTables include in tools templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:26:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:26:35 +0000 Subject: [Koha-bugs] [Bug 11734] New: Use new DataTables include in batch modification templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11734 Bug ID: 11734 Summary: Use new DataTables include in batch modification templates Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/batchMod.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 11720 The batch modification and batch deletion templates should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:26:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:26:35 +0000 Subject: [Koha-bugs] [Bug 11720] Use new DataTables include in tools templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11734 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:32:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:32:20 +0000 Subject: [Koha-bugs] [Bug 11734] Use new DataTables include in batch modification templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11734 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:32:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:32:23 +0000 Subject: [Koha-bugs] [Bug 11734] Use new DataTables include in batch modification templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11734 --- Comment #1 from Owen Leonard --- Created attachment 25179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25179&action=edit Bug 11734 - Use new DataTables include in batch modification templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch modification and batch deletion pages. Minor text changes: Corrected capitalization. Apply the patch and test the following: - On batch modification and batch deletion, submit multiple barcodes or item numbers. On the results page the title column has been configured to use the "anti-the" filter to exclude articles from sorting. Sorting on all columns should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:56:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:56:56 +0000 Subject: [Koha-bugs] [Bug 11720] Use new DataTables include in tools templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11735 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:56:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 17:56:56 +0000 Subject: [Koha-bugs] [Bug 11735] New: Use new DataTables include in calendar template Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Bug ID: 11735 Summary: Use new DataTables include in calendar template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/holidays.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 11720 The calendar template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:05:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 18:05:23 +0000 Subject: [Koha-bugs] [Bug 11735] Use new DataTables include in calendar template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:05:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 18:05:25 +0000 Subject: [Koha-bugs] [Bug 11735] Use new DataTables include in calendar template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 --- Comment #1 from Owen Leonard --- Created attachment 25180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25180&action=edit Bug 11735 - Use new DataTables include in calendar template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the calendar template and corrects some table sorting configuration errors. To test you should have multiple calendar entries in various categories of holiday: Unique holidays, repeating yearly holidays, repeating weekly holidays, and exceptions. Sorting of date columns should work regardless of your dateformat system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 18:52:24 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #59 from M. de Rooy --- (In reply to M. de Rooy from comment #58) > If you run the zebra job without root > permissions, you will probably have no permissions in /var/lock. $ ls -ld /run/lock drwxr-xr-x. 4 root root 80 Feb 10 03:09 /run/lock Redhat/Fedora distro's may point /var/lock via /var/run/lock to /run/lock on tmpfs. As you see, the perms do not help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:13:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:13:32 +0000 Subject: [Koha-bugs] [Bug 11720] Use new DataTables include in tools templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11736 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:13:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:13:32 +0000 Subject: [Koha-bugs] [Bug 11736] New: Use new DataTables include in Koha news templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11736 Bug ID: 11736 Summary: Use new DataTables include in Koha news templates Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/koha-news.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 11720 Koha news template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:15:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:15:31 +0000 Subject: [Koha-bugs] [Bug 11384] Koha should not use "ctid" as a column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11384 --- Comment #14 from Chris Nighswonger --- (In reply to Fridolin SOMERS from comment #13) > (In reply to Katrin Fischer from comment #12) > > While testing for the existance of the table is good - it worries me a bit, > > that the table is not there. I got the table on my installations. > Indeed, this table exists since 3.2 Interesting and a bit disconcerning since this DB began with a 3.0 installation and has moved along ever since. It provokes a few not-necessarily-new thoughts: 1. We should probably "stamp" a new database when it is created with the original rev number it was created under. This field would never change and could be used to somehow "verify" that the current DB structure at any point in time was, indeed, current. 2. There should definitely be some mechanism in place to veryify the existence of tables prior to "working" on them during upgrades. 3. When dealing with essential tables, there should be a mechanism to throw a rather large warning to the user when one of them is found missing, even if there is no "easy" way to fix it because what you don't know can, indeed, hurt you. But we have beat around this bush before, so I just list them here for posterity's sake. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:21:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:21:39 +0000 Subject: [Koha-bugs] [Bug 11736] Use new DataTables include in Koha news templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11736 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:21:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:21:43 +0000 Subject: [Koha-bugs] [Bug 11736] Use new DataTables include in Koha news templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11736 --- Comment #1 from Owen Leonard --- Created attachment 25181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25181&action=edit Bug 11736 - Use new DataTables include in Koha news templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the Koha news page. To test you should have existing news items with varying creation and expiration dates. Apply the patch and confirm that table sorting works correctly for all settings of the dateformat system preference. C4::NewsChannels.pm has been modified so that it now passes an unformatted date to the template, where the KohaDates plugin is used to apply the correct formatting. Sorting is based on the unformatted date. Also corrected: Capitalization errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:28:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:28:12 +0000 Subject: [Koha-bugs] [Bug 11737] New: Use new DataTables include in quotes management template Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Bug ID: 11737 Summary: Use new DataTables include in quotes management template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/quotes.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 11720 The quotes management template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:28:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:28:12 +0000 Subject: [Koha-bugs] [Bug 11720] Use new DataTables include in tools templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11737 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:35:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:35:29 +0000 Subject: [Koha-bugs] [Bug 11737] Use new DataTables include in quotes management template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:35:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:35:32 +0000 Subject: [Koha-bugs] [Bug 11737] Use new DataTables include in quotes management template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 --- Comment #1 from Owen Leonard --- Created attachment 25182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25182&action=edit Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:46:35 +0000 Subject: [Koha-bugs] [Bug 11738] New: Use new DataTables include in batch patron modification template Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Bug ID: 11738 Summary: Use new DataTables include in batch patron modification template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/modborrowers.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 11720 The batch patron modification template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 19:46:35 +0000 Subject: [Koha-bugs] [Bug 11720] Use new DataTables include in tools templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11738 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:00:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:00:52 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:00:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:00:56 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #1 from Owen Leonard --- Created attachment 25183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25183&action=edit Bug 11738 - Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Submit a change to multiple borrowers. The results page should also be sorted correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:05:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:05:41 +0000 Subject: [Koha-bugs] [Bug 11720] Use new DataTables include in tools templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11739 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:05:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:05:41 +0000 Subject: [Koha-bugs] [Bug 11739] New: Use new DataTables include in notices template Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 Bug ID: 11739 Summary: Use new DataTables include in notices template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 11720 The Notices and Slips template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:10:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:10:24 +0000 Subject: [Koha-bugs] [Bug 11739] Use new DataTables include in notices template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:10:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:10:28 +0000 Subject: [Koha-bugs] [Bug 11739] Use new DataTables include in notices template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 --- Comment #1 from Owen Leonard --- Created attachment 25184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25184&action=edit Bug 11739 - Use new DataTables include in notices template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the Notices & Slips page. To test, view the Notices & Slips page (tools/letter.pl). Confirm that the table of notices is sorted correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:29:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:29:27 +0000 Subject: [Koha-bugs] [Bug 11740] New: Use new DataTables include in quotes upload template Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Bug ID: 11740 Summary: Use new DataTables include in quotes upload template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/quotes-upload.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 11720 The quotes upload template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:29:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:29:27 +0000 Subject: [Koha-bugs] [Bug 11720] Use new DataTables include in tools templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11740 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:44:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:44:57 +0000 Subject: [Koha-bugs] [Bug 11704] Wrong headers in {opac|intranet}/svc/report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:45:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2014 20:45:06 +0000 Subject: [Koha-bugs] [Bug 11704] Wrong headers in {opac|intranet}/svc/report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25108|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 25185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25185&action=edit Bug 11704: Make */svc/report print the correct headers To test: 1 - Go through the first comments instructions to reproduce and verify the bug is present (OPAC and STAFF) 2 - Apply the patch 3 - Repeat step 1 and notice * characters are not broken anymore * the header is correct 4 - Sign off Regards To+ Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 03:42:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 02:42:12 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by merlissia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 03:42:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 02:42:25 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 03:42:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 02:42:31 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 25186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25186&action=edit Bug 11738 - Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Submit a change to multiple borrowers. The results page should also be sorted correctly. Signed-off-by: merlissia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 03:49:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 02:49:13 +0000 Subject: [Koha-bugs] [Bug 11739] Use new DataTables include in notices template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by merlissia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 03:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 02:49:24 +0000 Subject: [Koha-bugs] [Bug 11739] Use new DataTables include in notices template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 03:49:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 02:49:31 +0000 Subject: [Koha-bugs] [Bug 11739] Use new DataTables include in notices template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 25187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25187&action=edit Bug 11739 - Use new DataTables include in notices template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the Notices & Slips page. To test, view the Notices & Slips page (tools/letter.pl). Confirm that the table of notices is sorted correctly. Signed-off-by: merlissia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:15:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 03:15:15 +0000 Subject: [Koha-bugs] [Bug 11737] Use new DataTables include in quotes management template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by merlissia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:15:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 03:15:27 +0000 Subject: [Koha-bugs] [Bug 11737] Use new DataTables include in quotes management template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:15:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 03:15:34 +0000 Subject: [Koha-bugs] [Bug 11737] Use new DataTables include in quotes management template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 25188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25188&action=edit Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. Signed-off-by: merlissia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:27:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 03:27:13 +0000 Subject: [Koha-bugs] [Bug 11735] Use new DataTables include in calendar template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by merlissia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:27:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 03:27:25 +0000 Subject: [Koha-bugs] [Bug 11735] Use new DataTables include in calendar template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:27:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 03:27:31 +0000 Subject: [Koha-bugs] [Bug 11735] Use new DataTables include in calendar template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 25189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25189&action=edit Bug 11735 - Use new DataTables include in calendar template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the calendar template and corrects some table sorting configuration errors. To test you should have multiple calendar entries in various categories of holiday: Unique holidays, repeating yearly holidays, repeating weekly holidays, and exceptions. Sorting of date columns should work regardless of your dateformat system preference. Signed-off-by: merlissia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:31:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 08:31:14 +0000 Subject: [Koha-bugs] [Bug 11741] New: < > not displaying correctly in XSLT result list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Bug ID: 11741 Summary: < > not displaying correctly in XSLT result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If you have a record, that contains < >, those are incorrectly escaped on the OPAC and staff XSLT result lists. The detail pages display correctly. Example: Record: Wer ist wer? Display: Wer ist wer? <TEST> HTML source: &lt;TEST&gt It looks like a problem with the sequence of escaping characters. First < > are changed to HTML entities, then the apersand itself is changed, leaving us with a mix. This was reported by one of our librares and seems to have changed between 3.6 and 3.12 as they were recently updated. The problem doesn't seem to appear on master. I couldn't test with 3.14 so far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:34:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 08:34:04 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #19 from Holger Mei?ner --- Thought about it and decided to do a rebase rather than a follow-up. To avoid race conditions that might lead to QA having to apply the malocchio twice, I set the status back to assigned. ;) I'm a bit busy, but I'll try to complete it this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:49:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 08:49:13 +0000 Subject: [Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #1 from Katrin Fischer --- Hm, thinking more about it - I think it could also be a configuration/indexing problem. Needs more testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:51:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 08:51:22 +0000 Subject: [Koha-bugs] [Bug 11735] Use new DataTables include in calendar template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:51:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 08:51:26 +0000 Subject: [Koha-bugs] [Bug 11735] Use new DataTables include in calendar template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25189|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 25190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25190&action=edit Bug 11735 - Use new DataTables include in calendar template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the calendar template and corrects some table sorting configuration errors. To test you should have multiple calendar entries in various categories of holiday: Unique holidays, repeating yearly holidays, repeating weekly holidays, and exceptions. Sorting of date columns should work regardless of your dateformat system preference. Signed-off-by: merlissia Signed-off-by: Jonathan Druart Note: Day of week is not correctly sorted: Sundays, Mondays, Thursdays. But it is not a regression. It is caused by the ugly way to display weekdays (document.write). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:09:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 09:09:48 +0000 Subject: [Koha-bugs] [Bug 11704] Wrong headers in {opac|intranet}/svc/report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:22:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 09:22:25 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Regression found. To reproduce: 1/ Link a patron attribute to a patron category. 2/ On the patrons mod tools, you should see (at the bottom): Attribute: [SELECT] [CHECKBOX] [INPUT] [New] This attribute will be only applied to the patron's category "CATEGORY_CODE" With the patch, I get: Attribute: [SELECT] [CHECKBOX] [New] This input and the message have disappeared. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 09:10:47 +0000 Subject: [Koha-bugs] [Bug 11704] Wrong headers in {opac|intranet}/svc/report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11704 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25185|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 25191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25191&action=edit Bug 11704: Make */svc/report print the correct headers To test: 1 - Go through the first comments instructions to reproduce and verify the bug is present (OPAC and STAFF) 2 - Apply the patch 3 - Repeat step 1 and notice * characters are not broken anymore * the header is correct 4 - Sign off Regards To+ Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:31:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 09:31:51 +0000 Subject: [Koha-bugs] [Bug 11737] Use new DataTables include in quotes management template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:31:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 09:31:55 +0000 Subject: [Koha-bugs] [Bug 11737] Use new DataTables include in quotes management template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25188|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 25192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25192&action=edit Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. Signed-off-by: merlissia Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:32:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 09:32:13 +0000 Subject: [Koha-bugs] [Bug 11737] Use new DataTables include in quotes management template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 --- Comment #5 from Jonathan Druart --- Created attachment 25193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25193&action=edit Bug 11737: (follow-up) fnReloadAjax.js is duplicated the file dataTables.fnReloadAjax.js exists in the interface and themelang directories. It is only used in quotes.tt. So the unused one can be removed. test plan: git grep fnReloadAjax.js should return only 1 ref (quotes.tt) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:35:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 09:35:44 +0000 Subject: [Koha-bugs] [Bug 11739] Use new DataTables include in notices template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:35:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 09:35:48 +0000 Subject: [Koha-bugs] [Bug 11739] Use new DataTables include in notices template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25187|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 25194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25194&action=edit Bug 11739 - Use new DataTables include in notices template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the Notices & Slips page. To test, view the Notices & Slips page (tools/letter.pl). Confirm that the table of notices is sorted correctly. Signed-off-by: merlissia Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 12:38:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 11:38:01 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #20 from Martin Renvoize --- All great news Holger, Thanks for keeping us informed, I look forward to the updated patch for my next round of tests. Thus far I'm happy with the results and the code.. it's looking great. Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 13:44:32 +0000 Subject: [Koha-bugs] [Bug 11740] Use new DataTables include in quotes upload template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:44:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 13:44:35 +0000 Subject: [Koha-bugs] [Bug 11740] Use new DataTables include in quotes upload template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 --- Comment #1 from Owen Leonard --- Created attachment 25195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25195&action=edit Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:51:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 13:51:28 +0000 Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:13:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 14:13:51 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #5 from Jonathan Druart --- >From IRC: oleonard: Joubu: I'm having trouble reproducing the problem you had with Bug 11738 oleonard: Joubu: Can you describe the patron attribute you're working with? Joubu: oleonard-away: In fact I get a JS error: "TypeError: m is undefined" Joubu: oleonard-away: It is caused by the dynamic rows added by borrower.patron_attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:21:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 14:21:58 +0000 Subject: [Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #2 from Katrin Fischer --- Ok, it's not related to the version actually - it's related to indexing: rebuild_zebra.pl -x = broken display rebuild_zebra.pl without -x = display ok -x is the default on package installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:31:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 15:31:27 +0000 Subject: [Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:54:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 15:54:22 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #6 from Jonathan Druart --- Created attachment 25196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25196&action=edit patron attr type screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:54:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 15:54:55 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #7 from Jonathan Druart --- Created attachment 25197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25197&action=edit batch mod patron screen - without patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:55:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 15:55:16 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #8 from Jonathan Druart --- Created attachment 25198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25198&action=edit batch mod patron screen - with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:56:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 15:56:48 +0000 Subject: [Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:56:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 15:56:51 +0000 Subject: [Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #3 from Katrin Fischer --- Created attachment 25199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25199&action=edit Bug 11741: Correct display of < > in XSLT result lists < and > are incorrectly transformed into HTML entities on the XSLT result list. Example: Record: Result list: <TEST> HTML source: &lt;TEST&gt To test: - catalog a record that contains > and < - Reindex, without using the -x option - Confirm the display is correct - Reindex again, using the -x option - Confirm the display is now broken - Apply patch - Reindex again with and without -x - Verify that now the display is always correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 15:58:04 +0000 Subject: [Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #4 from Katrin Fischer --- I found a way to fix the display, but I am not totally persuaded this is a good solution - please comment :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:21:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 17:21:48 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:21:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 17:21:52 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25186|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 25200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25200&action=edit Bug 11738 [Revised] Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Test with extended patron attributes enabled. Test adding and removing varying numbers of attributes to patrons in your batch. Submit a change to multiple borrowers. The results page should also be sorted correctly. Revision: Corrected error caused by the variable number of columns in the table corresponding to varying numbers of patron attributes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:47:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 17:47:49 +0000 Subject: [Koha-bugs] [Bug 11742] New: Overdue notice/status triggers displaying the wrong notice for default Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Bug ID: 11742 Summary: Overdue notice/status triggers displaying the wrong notice for default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If you copy the notice set for an overdue trigger, overduerules.pl will display the description for the copied notice instead of the actual notice! This is because the copied notice shares the same letter code as the notice that was copied. Video example: http://screencast.com/t/WeEG3qlw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 19:02:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 18:02:04 +0000 Subject: [Koha-bugs] [Bug 11743] New: Remove unused DataTables plugin from OPAC theme directories Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11743 Bug ID: 11743 Summary: Remove unused DataTables plugin from OPAC theme directories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Two theme directories contain a copy of the main DataTables plugin which is unused and can be removed: opac-tmpl/ccsr/en/lib/jquery/plugins/jquery.dataTables.min.js opac-tmpl/bootstrap/lib/jquery/plugins/jquery.dataTables.min.js All OPAC templates now use the copy in opac-tmpl/lib/jquery/plugins/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 19:24:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 18:24:10 +0000 Subject: [Koha-bugs] [Bug 9212] Parentheses in subject headings break search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 19:41:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 18:41:53 +0000 Subject: [Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:01:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 19:01:35 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:47:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 19:47:33 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:59:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 19:59:24 +0000 Subject: [Koha-bugs] [Bug 5711] Distinction between authors/additional authors in opac normal view (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5711 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:45:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 20:45:15 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 --- Comment #7 from Ian Palko --- (In reply to Owen Leonard from comment #6) > (In reply to Ian Palko from comment #4) > > Now, the focus is not by default on the "add barcode" field, but when data > > is entered into this field, whether by scanner or keyboard, focus is > > immediately sent to the "search the catalog" field at the top of the page. > > This sounds like Bug 11567. Are you using a non-English translation which > needs to be updated? In fact, no. We've used the main English koha without any translation since 3.6. I've never run or needed to run koha-translate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 22:10:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2014 21:10:35 +0000 Subject: [Koha-bugs] [Bug 11744] New: canceil receipt not work for one item Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Bug ID: 11744 Summary: canceil receipt not work for one item Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Created attachment 25201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25201&action=edit cancel receipt Hi, My test plan: -AcqCreateItem = receiving an order -order 1 item -receive the order, item is created -cancel receipt -the order is pending but the item is not deleted If i receive a second time the order, an other item is created. Someone can test it? It's difficult to speak in english for me so i make a video without sound... Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 05:55:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2014 04:55:47 +0000 Subject: [Koha-bugs] [Bug 11745] New: Only one "TOPICS" value shown for 650a Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11745 Bug ID: 11745 Summary: Only one "TOPICS" value shown for 650a Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: dswhite42 at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In my "authorised_values" table, I have the following rows with a "category" of "TOPICS": Biography Children History Music Science For each of these rows, the "lib" value is NULL. However when I go to Intranet -> Cataloging -> New Record -> Default framework, go to the "6" tab and look at 650a ("Topical term..."), the dropdown box contains only a single value, "Biography" Looking at the SQL that generates this dropdown, I see this: SELECT authorised_value, lib FROM authorised_values LEFT JOIN authorised_values_branches ON ( id = av_id ) WHERE category = 'TOPICS' AND ( branchcode = 'NO_LIBRARY_SET' OR branchcode IS NULL ) GROUP BY lib ORDER BY lib, lib_opac My "authorised_values_branches" table is empty. (This is a database upgrade from 3.00.00.070, and nothing during the installation process populated that table). The result of that SQL commmand is to just return the first value ("Biography") If I remove the "GROUP BY lib" clause, then all TOPICS values will populate the 650a dropdown. (My original Koha 3.00.00.070 did not include that "GROUP BY" clause in addbiblio.pl) Is this a bug in addbiblio.pl? Or a problem related to the upgrade from 3.00.00.070 -> 3.14.02.000 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 05:56:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2014 04:56:15 +0000 Subject: [Koha-bugs] [Bug 11745] Only one "TOPICS" value shown for 650a In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11745 David White changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 07:24:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2014 06:24:22 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #16 from Magnus Enger --- Marcel: The status is now RESOLVED WONTFIX - is that a mistake? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:51:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2014 09:51:44 +0000 Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- QA comment: 1/ I am not sure the code you added to AddReturn is put at the right place. I think the code should be put into the if ( $doreturn ) statement (if the return is not done, I suppose we don't want to update the not for loan status). Moreover, you will be able to use the existing call to ModItem (and avoid 1 call to it). 2/ Could you add unit tests for this new syspref please? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:15:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2014 10:15:36 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- Hi Kyle, To me the new syspref does not make sense. Don't you consider the existing behavior as a bug? I don't see a situation where the renew should be refused. Maybe could you send an email to the koha mailing list in order to ask what librarians think about the existing behavior? Switch to in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:37:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2014 10:37:30 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:37:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2014 10:37:34 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25168|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 25202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25202&action=edit Bug 10865 [Revised] Don't show list permissions when adding public lists/sharing lists is not allowed If patron creation of public lists is disallowed by the OpacAllowPublicListCreation system preference the "category" option should be hidden altogether instead of showing a > + Required Are you sure this "required" string is useful? The label is already in red. I just passed QA on bug 11766 and bug 11767 and you didn't add it. Should we be consistent for all forms? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:32:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:32:01 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #7 from Julian Maurice --- Created attachment 25426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25426&action=edit Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:38:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:38:54 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #28 from Jonathan Druart --- (In reply to M. de Rooy from comment #26) > Some prelimary QA comments/questions: Thank you Marcel for having a look at this one. > If you browse the selection, it would imo be good to show that you are doing > so (Browse selected results vs. Browse results). Will be fixed. > If we use the js plugin, it would be good to acknowledge that on About, > separate from the question if this specific MIT license needs that by law or > so. In fact the plugin is useless, I will remove it. > Also I do not think that remembering a few biblios in a cookie, would be a > big legal problem. We c/should clear the contents every time we start a new > search. And if we are not allowed to create it, well we do not.. How do we know if we are allowed or not? > More technically: > There is a small merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css. Will be fixed. > Note that I would like to see the bootstrap patch here also instead of on > another report. Bootstrap is now leading and should be pushed first. (Is > there any trouble there with less files?) The first patches were signed off, so I prefer to create another report for the bootstrap theme. I will add the patch from bug 11296 to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:40:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:40:45 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23542|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 25427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25427&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita Signed-off-by: Koha Team Amu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:40:52 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23543|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 25428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25428&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised for prog and ccsr. Not implemented for bootstrap, but doesn't affect it detrimentally either. Jonathan plans to open a new bug to implement for bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:40:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:40:59 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23633|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 25429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25429&action=edit Bug 10858: FIX error if no biblio is selected If the user launch a search a directly go to the opac detail page, an error occurs: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 171. Test plan: - remove the bibs_selected cookie - launch a search - click on a result - the page should be displayed correctly (cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:41:05 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23781|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 25430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25430&action=edit Bug 10858: Don't use the cookie if the ft is disabled Is the pref 'OpacBrowseResults' is off, the feature should be completly off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:41:11 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23782|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 25431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25431&action=edit Bug 10858: Update the jquery.json plugin to the lastest version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:41:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:41:18 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #34 from Jonathan Druart --- Created attachment 25432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25432&action=edit Bug 10858: Browse selected biblios - bootstrap Add the changes from bug 10858 to the bootstrap theme. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:41:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:41:24 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #35 from Jonathan Druart --- Created attachment 25433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25433&action=edit Bug 10858: Remove the jQuery JSON plugin JSON.stringify and JSON.parse are natively supported by mordern browsers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:41:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:41:31 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #36 from Jonathan Druart --- Created attachment 25434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25434&action=edit Bug 10858: FIX the "Browse selected" link It should be updated on checkbox changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:41:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:41:37 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #37 from Jonathan Druart --- Created attachment 25435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25435&action=edit Bug 10858: FIX Only one occurrence of the biblionumbers should be stored We have to remove duplicate biblionumber in the array of biblionumbers stored in the cookie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:41:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:41:44 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #38 from Jonathan Druart --- Created attachment 25436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25436&action=edit Bug 10858: Replace "Browse results" with "Browse selected results" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:48:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:48:36 +0000 Subject: [Koha-bugs] [Bug 11296] Browse selected biblios - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 10858 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:48:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:48:36 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #39 from Jonathan Druart --- *** Bug 11296 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:48:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:48:36 +0000 Subject: [Koha-bugs] [Bug 11311] Browse selected authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Bug 11311 depends on bug 11296, which changed state. Bug 11296 Summary: Browse selected biblios - bootstrap http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11296 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:50:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:50:40 +0000 Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 --- Comment #16 from Jonathan Druart --- (In reply to Kyle M Hall from comment #15) > Jonathan, can you point out which template files you believe this is an > issue for? I'm not seeing it. Did you try to reproduce my example? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:54:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:54:45 +0000 Subject: [Koha-bugs] [Bug 11744] canceil receipt not work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #1 from Jacek Ablewicz --- (In reply to Marjorie Barry-Vila from comment #0) > Someone can test it? Yes, I can confirm there is a problem with CancelReceipt(). It will delete (one or more, it doesn't matter) items associated with received order only if the given order is a partial receive (and the parent order is not fully received yet). Plus, in those rare cases when it is actually deleting the items, it's currently not doing a very good job - it is removing item records directly from mysql table, but it does NOT flag biblio record for Zebra reindexing after the deletion. Until recently, it also used to delete the items if given order was a transfer to another basket - but it was deleting the order record itself too, which was not all that good (see bug 11549). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:55:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:55:30 +0000 Subject: [Koha-bugs] [Bug 11744] canceil receipt not work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11549 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:55:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:55:30 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11744 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:59:55 +0000 Subject: [Koha-bugs] [Bug 11779] Unexpected change in logged in branch when changing overdue notice triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 10:59:59 +0000 Subject: [Koha-bugs] [Bug 11779] Unexpected change in logged in branch when changing overdue notice triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25398|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 25437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25437&action=edit Bug 11779 - Unexpected change in logged in branch when changing overdue notice triggers Steps to reproduce: 1) Log into staff intranet 2) Set logged in branch 3) Browse to tools/overdue notice triggers 4) Select a branch from the pulldown that is not your logged in branch 5) use the "Check out" bar at the top of the page to search for a patron to check out to 6) Once you have landed here, click the "check out" tab link again, or the Edit button ( any action really ) 7) Note your logged in branch has now changed to the once selected when editing the notice/status triggers This is due to the way the patron search passes the branchcode to be used via the form. This form assumes the branchcode variable is always the currently logged in branch, which may not and is not always the case. Test Plan: 1) Apply this patch 2) Repeat the steps to reproduce above 3) Note your logged in branch does not change Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Funny bug :) This patch fixes the described issue and should not introduce regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:06:40 +0000 Subject: [Koha-bugs] [Bug 11740] Use new DataTables include in quotes upload template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:06:43 +0000 Subject: [Koha-bugs] [Bug 11740] Use new DataTables include in quotes upload template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25400|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25438&action=edit Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart No regression found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:09:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:09:31 +0000 Subject: [Koha-bugs] [Bug 11701] Fix C4::Context::Zconn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25102|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 25439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25439&action=edit Bug 11701: Fix C4::Context::Zconn Support other parameters too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:10:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:10:49 +0000 Subject: [Koha-bugs] [Bug 11701] Fix C4::Context::Zconn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Julian Maurice --- A quick grep shows me that other parameters are not used, but it isn't harder to support all parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:15:51 +0000 Subject: [Koha-bugs] [Bug 11783] Record level unavailable holds sending empty CD field rather than item barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:15:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:15:54 +0000 Subject: [Koha-bugs] [Bug 11783] Record level unavailable holds sending empty CD field rather than item barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25403|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25440&action=edit Bug 11783 - Record level unavailable holds sending empty CD field rather than item barcode If a patron has a record-level hold that is unavailable, any patron information request will send back an empty CD field when this field should have an item barcode in it. This is due to a minor error in ILS::Patron::_get_outstanding_hodsl where GetItemnumbersForBiblio is assumed to return an array but in reality returns an arrayref. Test Plan: 1) Create a record level hold for a patron and record 2) Using SIP2, make a patron information request 3) Note the empty CD fields 4) Apply this patch, restart SIP server 5) Repeat step 2 6) Note the CD field now has a barcode Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart I did not test this patch but the following code shows me it is correct: use C4::Items; use Data::Dumper; my $biblionumber = 5035; my $itemnumber = (GetItemnumbersForBiblio($biblionumber))[0]; say Dumper $itemnumber; $itemnumber = (GetItemnumbersForBiblio($biblionumber))->[0]; say Dumper $itemnumber; displays: $VAR1 = [ '23168', '23169', '23170', '23171', '23172' ]; $VAR1 = '23168'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:16:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:16:51 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Blocks| |11783 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:16:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:16:51 +0000 Subject: [Koha-bugs] [Bug 11783] Record level unavailable holds sending empty CD field rather than item barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10817 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:26:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:26:09 +0000 Subject: [Koha-bugs] [Bug 11784] Patron images broken in Self checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:26:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:26:13 +0000 Subject: [Koha-bugs] [Bug 11784] Patron images broken in Self checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25385|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25441&action=edit Bug 11784 - Patron images broken in Self checkout I suppose this bug was introduced with Bug 10636 (patronimage should habe borrowernumber as PK, not cardnumber) To test: - Have a Patron with image. Configure everything to show image in SCO. - Go to SCO and log in patron - Image does not show up (broken link) - Apply patch - Test with prog, ccsr and bootstrap themes - Image should display Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:27:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:27:07 +0000 Subject: [Koha-bugs] [Bug 11784] Patron images broken in Self checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |10636 --- Comment #4 from Jonathan Druart --- Introduced by bug 10636 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:27:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:27:07 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11784 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:35:57 +0000 Subject: [Koha-bugs] [Bug 11777] Created by name is not coming in order receiving page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:36:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:36:03 +0000 Subject: [Koha-bugs] [Bug 11777] Created by name is not coming in order receiving page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11777 --- Comment #4 from Jonathan Druart --- Created attachment 25442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25442&action=edit Bug 11777 - Created by name is not coming in order receiving page To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Click on Receive shipment button. 6) Click on receive link on the right hand side you will be able to see created by name Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:36:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:36:50 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11777 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:36:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:36:50 +0000 Subject: [Koha-bugs] [Bug 11777] Created by name is not coming in order receiving page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |10723 Severity|enhancement |normal --- Comment #5 from Jonathan Druart --- Certainly introduced by bug 10723. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:45:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:45:47 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #26 from Julian Maurice --- Created attachment 25443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25443&action=edit Bug 7679: Fix two SQL queries when using patron attributes and remove some Perl warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:46:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 11:46:07 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #27 from Julian Maurice --- This time the problem should be fixed ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:15:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 12:15:58 +0000 Subject: [Koha-bugs] [Bug 8878] koha-shell: a command to make using koha commands easier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8878 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Whenever using the koha-shell command I am met with the following error messages: bash: cannot set terminal process group (-1): Inappropriate ioctl for device bash: no job control in this shell Is this something specific to my setup, or is it a general bug/oddity? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:18:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 12:18:53 +0000 Subject: [Koha-bugs] [Bug 11782] Need junktag file to remove specific marc fields/subfields on z39.50 import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11782 --- Comment #1 from M. de Rooy --- Hi, On report 6536 and subsequent ones I still plan to add XSLT on top of Z3950 results, allowing you to strip tags or do whatever you want with them before importing. Unfortunately these patches did not yet reach master, but I have not given up on them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:28:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 12:28:10 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #64 from M. de Rooy --- (In reply to Doug Kingston from comment #63) > This is a new combined patch (original+QA changes). Its been build against > HEAD so it should apply to a new branch at origin/master. It replaces the > two patches from earlier. Yes, it applies. Will have a look now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 12:38:46 +0000 Subject: [Koha-bugs] [Bug 11744] canceil receipt not work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at biblibre.co | |m Version|3.12 |master Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #2 from Jonathan Druart --- I reproduced against master. I will provide a patch soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:46:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 12:46:29 +0000 Subject: [Koha-bugs] [Bug 11744] canceil receipt not work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:46:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 12:46:38 +0000 Subject: [Koha-bugs] [Bug 11744] canceil receipt not work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #4 from Jonathan Druart --- Created attachment 25445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25445&action=edit Bug 11744: Cancel a receipt does not delete items created on receiving If items is created on receiving, cancel a receipt should delete them. The code only manage the case if the order is a child of another order (partial). To reproduce: 1/ Set AcqCreateItem to receiving 2/ Order one or more item(s) 3/ Receive the order and verify the item is created 4/ Cancel the receipt 5/ The item is not deleted Test plan: 1/ Apply this patch and do again previous steps. The item should not be deleted at step 5. 2/ Set AcqCreateItem to ordering and verify the item is not deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:46:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 12:46:33 +0000 Subject: [Koha-bugs] [Bug 11744] canceil receipt not work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #3 from Jonathan Druart --- Created attachment 25444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25444&action=edit Bug 11744: Add regression tests Before the patch: prove t/db_dependent/Acquisition/CancelReceipt.t returns 1 failure. After the patch, the 2 tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 13:07:13 +0000 Subject: [Koha-bugs] [Bug 8878] koha-shell: a command to make using koha commands easier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8878 --- Comment #15 from Martin Renvoize --- Looks like Galen has reported the bug now: bug 11775 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:46:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 13:46:10 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:57:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 13:57:38 +0000 Subject: [Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #8 from Dan Scott --- As this bug addresses regressions from the prior default theme to the new default theme in 3.14, will the patch also be backported to 3.14? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:00:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 14:00:34 +0000 Subject: [Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #9 from Katrin Fischer --- Hi Dan, as this is marked as bug (vs. enhancement or new feature) it is likely to be backported to earlier versions, but it's up to the RMaint to make the decision. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:26:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 14:26:12 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #28 from Marjorie Barry-Vila --- Hi, It's marked Resolved Wontfix but for us it's very critical. We just have 3.12 and we can not print our labels correctly. We are in lcc and for a call number like HQ759.96 C58 1986, we have this: HQ 759.96 .C58 1986 and for this STV B46ga 2013 Saison.2 DVD 1/5, we have STV .B46 G A2013 SAISON.2 DVD 1/5 We don't want to put our call number in dcc. How can we go back for print lcc call number correctly? Thanks, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:49:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 14:49:21 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 14:49:25 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25412|0 |1 is obsolete| | --- Comment #65 from M. de Rooy --- Created attachment 25446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25446&action=edit Bug 11078: Add locking to rebuild_zebra (revised patch 2014-02-18) This patch adds locking to rebuild_zebra.pl to ensure that simultaneous changes are prevented (as one is likely to overwrite the other). Incremental updates in daemon mode will skipped if the lock is busy and they will be picked up on the next pass. Non-daemon mode invocations will also exit immediately if they cannot get the lock unless the new flag -wait-for-lock is specified, in which case they will wait until the get the lock and then proceed. Supporting changes made to Makefile.PL and templates for the new locking directory (paralleling the other zebra lock directories). We stash the zebra_lockdir in koha-conf.xml so rebuild_zebra.pl can find it. To address earlier QA concerns we: 1. added code to check if flock is available and ignore locking if its missing (from M. de Rooy) 2. changed default for adhoc invocations to abort if they cannot obtain the lock. Added option -wait-for-lock if the user prefers to wait until the lock is free, and then continue processing. 3. added missing entry to t/db_dependent/zebra_config.pl 4. added a fallback locking directory of /tmp Signed-off-by: Marcel de Rooy Doug merged the original patch with the QA changes. Just for the record, noting here that the original patch was tested extensively too by Martin Renvoize. I have added a followup for some exceptional cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:50:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 14:50:55 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #66 from M. de Rooy --- Created attachment 25447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25447&action=edit Bug 11078: QA Follow-up for missing file permissions on lockfile The original patch creates a lockfile in the ZEBRA_LOCKDIR. It can fall back to /var/lock or even /tmp. If the create fails, it dies. This can be considered as very exceptional. This followup adjusts the fallback location in /var/lock or /tmp slightly. It appends the database name to the folder in order to prevent interfering between multiple Koha instances. Creation of the lockfile has been moved to a subroutine extending directory and file creation testing. In the very unlikely case that we cannot create the lockfile (after three separate tries), this follow-up allows you to continue instead of die. This is just as we did before we had file locking here. Every time skipping a reindex could cause more harm than continuing and having the race condition once in a while. Test plan: Test adding and removing lockdir from your koha-conf.xml. Check fallback. Note that fallback in /var/lock or /tmp must contain database name. Remove the lockdir config line and remove permissions from fallback. In this case the reindex should continue but with a warning. Signed-off-by: Marcel de Rooy Tested with daemon and one-off invocation simultaneously. Tested new wait parameter. Tried all variations of lock directory (changing permissions etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:01:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:01:28 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24143|0 |1 is obsolete| | --- Comment #6 from Benjamin Rokseth --- Created attachment 25448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25448&action=edit Bug 11518 [Followup] - Change method name from 'itemtype' to 'effective_itemtype' for clarity Test runs without errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:03:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:03:12 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #67 from M. de Rooy --- QA Comment: Thanks Doug for all adjustments. As you can see, I still saw a reason to add a followup to cover some (very) exceptional cases. Just for the record: I would prefer (next time) to keep the original patch with signoff and just add QA follow-ups. But no reason to do that now anymore! I would like to suggest the following route now: Please apply both patches and test again (hopefully last time). You could add your signoff on the second patch. Since we had Martin for the signoff and considering the second patch as a QA follow-up, I will pass QA on this report after receiving your confirmation. Note that we have no warnings too from the QA tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:03:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:03:59 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #29 from Chris Nighswonger --- (In reply to Marjorie Barry-Vila from comment #28) > Hi, > > It's marked Resolved Wontfix but for us it's very critical. > We just have 3.12 and we can not print our labels correctly. Please see comment 22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:06:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:06:37 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 --- Comment #1 from Nicole C. Engard --- This is still an issue and a big one at that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:10:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:10:22 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 --- Comment #2 from Nicole C. Engard --- http://screencast.com/t/GgtRm7IqPf7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:18:46 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from M. de Rooy --- Jonathan: Thanks for your adjustments and your patience in looking at what follows :) I would strongly prefer to slightly adjust a few patches here. We now add the plugin, update it and then remove it in this series.. I would not recommend to push that line of action if we can just remove it from the first patch. I have no objection to leaving the original signoff on that one when you enter your additional signoff commenting on the amend. After that I will add still another signoff. Makes that sense? Changing status to reflect this.. Please change back to SO after that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:27:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:27:21 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #81 from M. de Rooy --- Will have a look again. Will probably not finish this today however,, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:27:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:27:52 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:39:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:39:50 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #82 from M. de Rooy --- Olli, Since this is a larger set of patches, it could be helpful while reviewing it to know what you exactly tested when signing off? Is it possible to elaborate on that? Thanks in advance.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:40:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 15:40:35 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:05:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:05:14 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Hardware|PC |All Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:07:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:07:19 +0000 Subject: [Koha-bugs] [Bug 11328] Local cover images not appearing in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:15:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:15:58 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:16:00 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 --- Comment #1 from Owen Leonard --- Created attachment 25449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25449&action=edit Bug 3766 - Cities/Towns and Road Types only on one address When adding a new patron only the primary contact city/state fields are linked to a dropdown listing values from stored city/state/zip/country values. The same dropdown of predefined values should be linked to alternate address and alternate contact. This patch does so by adapting the same JS and markup for these additional cases. To test you should have cities defined in Administration -> Cities. - Edit or create a new patron. - Under main address -> city select one of the predefined entries. - The city, state, zip, and country values should be correctly populated. - Test under alternate address -> city and alternate contact -> city. - Save your changes and confirm that everything worked correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:35:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:35:09 +0000 Subject: [Koha-bugs] [Bug 11791] New: Use validation plugin when creating new city Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Bug ID: 11791 Summary: Use validation plugin when creating new city Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/cities.pl?op=add_form OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The new city entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:36:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:36:24 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25427|0 |1 is obsolete| | Attachment #25428|0 |1 is obsolete| | Attachment #25429|0 |1 is obsolete| | Attachment #25430|0 |1 is obsolete| | Attachment #25431|0 |1 is obsolete| | Attachment #25432|0 |1 is obsolete| | Attachment #25433|0 |1 is obsolete| | Attachment #25434|0 |1 is obsolete| | Attachment #25435|0 |1 is obsolete| | Attachment #25436|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 25450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25450&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita Signed-off-by: Koha Team Amu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:36:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:36:30 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #42 from Jonathan Druart --- Created attachment 25451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25451&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised for prog and ccsr. Not implemented for bootstrap, but doesn't affect it detrimentally either. Jonathan plans to open a new bug to implement for bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:36:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:36:36 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #43 from Jonathan Druart --- Created attachment 25452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25452&action=edit Bug 10858: FIX error if no biblio is selected If the user launch a search a directly go to the opac detail page, an error occurs: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 171. Test plan: - remove the bibs_selected cookie - launch a search - click on a result - the page should be displayed correctly (cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:36:42 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #44 from Jonathan Druart --- Created attachment 25453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25453&action=edit Bug 10858: Don't use the cookie if the ft is disabled Is the pref 'OpacBrowseResults' is off, the feature should be completly off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:36:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:36:54 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #46 from Jonathan Druart --- Created attachment 25455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25455&action=edit Bug 10858: FIX the "Browse selected" link It should be updated on checkbox changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:36:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:36:48 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #45 from Jonathan Druart --- Created attachment 25454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25454&action=edit Bug 10858: Browse selected biblios - bootstrap Add the changes from bug 10858 to the bootstrap theme. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:37:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:37:00 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #47 from Jonathan Druart --- Created attachment 25456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25456&action=edit Bug 10858: FIX Only one occurrence of the biblionumbers should be stored We have to remove duplicate biblionumber in the array of biblionumbers stored in the cookie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:37:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:37:06 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #48 from Jonathan Druart --- Created attachment 25457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25457&action=edit Bug 10858: Replace "Browse results" with "Browse selected results" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:38:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:38:38 +0000 Subject: [Koha-bugs] [Bug 11791] Use validation plugin when creating new city In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 --- Comment #1 from Owen Leonard --- Created attachment 25458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25458&action=edit Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:38:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:38:36 +0000 Subject: [Koha-bugs] [Bug 11791] Use validation plugin when creating new city In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:41:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:41:00 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Jonathan Druart --- (In reply to M. de Rooy from comment #40) > I would strongly prefer to slightly adjust a few patches here. > We now add the plugin, update it and then remove it in this series.. > I would not recommend to push that line of action if we can just remove it > from the first patch. I have no objection to leaving the original signoff on > that one when you enter your additional signoff commenting on the amend. > After that I will add still another signoff. > Makes that sense? Absolutely, it was a "morning laziness" :) I completely removed all references to this plugin in the last set of patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:49:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:49:53 +0000 Subject: [Koha-bugs] [Bug 11328] Local cover images not appearing in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 --- Comment #1 from Marjorie Barry-Vila --- Created attachment 25459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25459&action=edit local cover -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:50:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:50:03 +0000 Subject: [Koha-bugs] [Bug 11328] Local cover images not appearing in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 --- Comment #2 from Marjorie Barry-Vila --- Hi, It's the same for a staff detail biblio (see attachment). Jquery code you proposed is just for a results list? is there a jquery code for detail biblio? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:59:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 16:59:24 +0000 Subject: [Koha-bugs] [Bug 11792] New: Use validation plugin when creating new currency Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11792 Bug ID: 11792 Summary: Use validation plugin when creating new currency Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/currency.pl?op=add_form OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The new currency entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:01:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:01:49 +0000 Subject: [Koha-bugs] [Bug 11792] Use validation plugin when creating new currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11792 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:01:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:01:52 +0000 Subject: [Koha-bugs] [Bug 11792] Use validation plugin when creating new currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11792 --- Comment #1 from Owen Leonard --- Created attachment 25460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25460&action=edit Bug 11792 - Use validation plugin when creating new currency The page for adding a new currency includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Currencies & Exchange rates -> New currency. Try submitting the form without entering a currency, rate, and/or symbol. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing currency should also work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:15:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:15:20 +0000 Subject: [Koha-bugs] [Bug 11749] Remove unused jQuery plugin jquery.hoverIntent.minified.js from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11749 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:15:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:15:35 +0000 Subject: [Koha-bugs] [Bug 11766] Use validation plugin when creating new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:15:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:15:50 +0000 Subject: [Koha-bugs] [Bug 11767] Use validation plugin when creating new authority framework tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11767 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:16:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:16:15 +0000 Subject: [Koha-bugs] [Bug 11740] Use new DataTables include in quotes upload template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:16:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:16:31 +0000 Subject: [Koha-bugs] [Bug 11784] Patron images broken in Self checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11784 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:17:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:17:34 +0000 Subject: [Koha-bugs] [Bug 11779] Unexpected change in logged in branch when changing overdue notice triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11779 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master, along with a follow-up that - Ensures that the plugin returns the empty string, not undef, if no user environment is set. This avoids spurious warnings should the new template plugin function be used in the OPAC. - Adds unit tests for the new plugin function. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:18:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:18:41 +0000 Subject: [Koha-bugs] [Bug 11783] Record level unavailable holds sending empty CD field rather than item barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11783 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kyle! I note that a warning will likely be logged if there are no items attached to the being being requested (as might happen if the items were deleted after the request was placed). However, that would have happened prior to this patch as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:19:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:19:04 +0000 Subject: [Koha-bugs] [Bug 11777] Created by name is not coming in order receiving page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11777 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master, along with a follow-up that adds a regression test. Thanks, Amit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:22:20 +0000 Subject: [Koha-bugs] [Bug 11793] New: Use validation plugin when creating new item type Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Bug ID: 11793 Summary: Use validation plugin when creating new item type Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/itemtypes.pl?op=add_form OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The new item type entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:36:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:36:49 +0000 Subject: [Koha-bugs] [Bug 11793] Use validation plugin when creating new item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:36:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:36:51 +0000 Subject: [Koha-bugs] [Bug 11793] Use validation plugin when creating new item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 --- Comment #1 from Owen Leonard --- Created attachment 25461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25461&action=edit Bug 11793 - Use validation plugin when creating new item type The page for adding a new item type includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Item types -> New item type. Try submitting the form with the following error conditions: - Missing item type - Missing description - A non-number in the "rental charge" field These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing item type should also work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:37:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:37:26 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com Blocks| |11747 --- Comment #12 from Galen Charlton --- I very much agree that this is a usability improvement -- *if* more than one library is sharing the database. However, I'm not convinced that this is an improvement for single-branch libraries or library systems that have multiple branches but no variation in circulation policy. For such libraries, this patch means that going to circulation rules or notices & slips immediately requires them to make at least two more clicks. Setting to in discussion for feedback from such libraries and suggestions for ways to make this work well both for consortia and single-branch/single-system users. I'm also setting this bug as a blocker for bug 11747 since they cover the same underlying concept. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:37:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:37:26 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11625 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:38:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:38:37 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 --- Comment #5 from Galen Charlton --- Setting to in discussion for the same reason I set bug 11625 to in discussion. I suggest that we use bug 11625 for all discussion, as whatever resolution occurs for that bug will, for the sake of consistency, should become the resolution for this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:38:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:38:44 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 17:39:28 +0000 Subject: [Koha-bugs] [Bug 11794] New: opacSerialDefaultTab being ignored Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Bug ID: 11794 Summary: opacSerialDefaultTab being ignored Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org This is true in master and 3.14. If you have opacSerialDefaultTab set to show the subscription tab it still shows the holdings tab as default in ccsr and bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:03:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 18:03:46 +0000 Subject: [Koha-bugs] [Bug 11795] New: Use validation plugin when creating new Z39.50 server Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 Bug ID: 11795 Summary: Use validation plugin when creating new Z39.50 server Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/z3950servers.pl?op=add_form OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The new Z39.50 server entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:06:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 18:06:47 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 18:10:47 +0000 Subject: [Koha-bugs] [Bug 11795] Use validation plugin when creating new Z39.50 server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:10:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 18:10:50 +0000 Subject: [Koha-bugs] [Bug 11795] Use validation plugin when creating new Z39.50 server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 --- Comment #1 from Owen Leonard --- Created attachment 25462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25462&action=edit Bug 11795 - Use validation plugin when creating new Z39.50 server The page for adding a new Z39.50 server includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Z39.50 client targets -> New Z39.50 server. Try submitting the form with any of the following error conditions: - Missing Z39.50 server name - Missing hostname - Missing port - Non-numeric port - Missing database - Non-numeric rank - Non-numeric timeout These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing Z39.50 server should also work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:14:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 18:14:24 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:35:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 18:35:41 +0000 Subject: [Koha-bugs] [Bug 8963] Can not upload csv file for Quote of the day and encoding problems with non-UTF-8 files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8963 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:41:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 18:41:15 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 20:25:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 19:25:11 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 20:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 19:25:46 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 20:25:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 19:25:49 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20384|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 25463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25463&action=edit Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 20:27:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 19:27:07 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20394|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 25464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25464&action=edit [SIGNED-OFF] Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:09:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:09:38 +0000 Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to amount unallocated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Kyle! However, I have declined to push Jonathan's follow-up, and instead have pushed one of my own with the following FIXME (which to be clear, is NOT directed at Kyle's patch in particular): +# FIXME - we really need a better way to do this consistently +# and across the board, be it bigints, Math::FixedPoint, a +# modernized version of Math::Curency that isn't tied to the system +# locale, or something else. The problem with Jonathan's suggestion of using a system preference to specify the number of decimal places for a currency is that such a thing is not actually a global attribute -- it's more properly an attribute of the currency. Hard-coding the number of decimal places to 2, while not ideal, won't break things for folks who use JPY. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:12:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:12:04 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:12:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:12:08 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 --- Comment #4 from Owen Leonard --- Created attachment 25465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25465&action=edit Bug 10714 [Follow-up] Redirect to list contents view upon save after initiating edit from list contents view This follow-up corrects the "cancel" action on list edit actions based on whether the edit was initiated from the list of lists or the list contents view. To test, view the list of lists and click the edit link next to one of them. Click the cancel link. You should return to the list of lists you were just viewing. View the contents of a list. Choose "Edit list" from the edit menu. Click the cancel link on the edit screen. You should return to the list contents view from which you initiated the edit action. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:22:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:22:55 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:26:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:26:12 +0000 Subject: [Koha-bugs] [Bug 11796] New: Results with 6 facets have missing facet Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 Bug ID: 11796 Summary: Results with 6 facets have missing facet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:26:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:26:17 +0000 Subject: [Koha-bugs] [Bug 11796] Results with 6 facets have missing facet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:28:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:28:11 +0000 Subject: [Koha-bugs] [Bug 9856] Add TTF font path in a syspref instead of hardcoding, for labels printing (bug 8375) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9856 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:28:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:28:23 +0000 Subject: [Koha-bugs] [Bug 11796] Results with 6 facets have missing facet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 --- Comment #1 from Kyle M Hall --- Created attachment 25466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25466&action=edit Bug 11796 - Results with 6 facets have missing facet If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. Test Plan: 1) Perform a search that should give results for 6 different libraries 2) Note you only see 5 libraries in the facets with no option to expand 3) Apply this patch 4) Repeat step 1 5) Note you now have the option to expand the facets list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:28:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:28:36 +0000 Subject: [Koha-bugs] [Bug 11796] Results with 6 facets have missing facet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:36:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:36:04 +0000 Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22494|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 25467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25467&action=edit Bug 10904 - would like to limit patron update request management by branch By not limiting the patron modification lists by branch, it can quickly become overwhelming for a librarian. This patch makes the following modifications: * Only superlibrians will see the full list of borrowers with pending modifications. * Adds the patron cardnumber after the patrons name on the modification list. * Adds a link to the patron's record from the modification list. Test Plan: 1) Apply this patch 2) Set up some pending modifications for two branches 3) Log in to the staff intranet as one of those branches 4) You should note the number of pending modifications counts only your logged in branch's patrons 5) Click the link, you should only see your logged in branches patrons in the pending modifications list. 6) You should note the cardnumber is displayed next to the patron name 7) You should note the "View record" link below each patron's name Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:36:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:36:19 +0000 Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23104|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 25468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25468&action=edit Bug 10904 [QA Followup] - would like to limit patron update request management by branch Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:41:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:41:08 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #20 from Owen Leonard --- (In reply to Jonathan Druart from comment #19) > Moreover, the > message "Cannot place hold: this record has no items attached." appears on a > blank page (without back button or something else). This issue does make it Failed QA, because the point of the bug is to make it possible to continue to place a hold on those titles which do have items attached even if the user also selected some which have no items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:42:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:42:30 +0000 Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 20:56:12 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #30 from Galen Charlton --- Pushed to a master, along with a follow-up that updates the MARC21 DOM configuration. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:10:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:10:29 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #65 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:19:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:19:27 +0000 Subject: [Koha-bugs] [Bug 11775] koha-shell displays warning on Debian Wheezy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11775 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #1 from Robin Sheat --- I'm not aware of any reasonable work-around that we could do, we might just have to wait for debian to sort it out. I'm open to ideas though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:21:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:21:32 +0000 Subject: [Koha-bugs] [Bug 11732] Eliminate warning on undefined branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11732 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:27:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:27:51 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25131|0 |1 is obsolete| | CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:28:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:28:11 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:29:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:29:14 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25090|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:40:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:40:25 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- I have pushed Owen's original patch, but I'm declining to push the follow-ups supplied by Kyle because they defeat the (network performance) purpose of the minification. Also, in this case I don't think we want the compiled CSS to be readable, since one /should/ be editing the LESS files. That said, I'm not setting this decision in concrete, as only time will tell whether the benefits of minifying the CSS file outweigh the stumbling blocks for folks using a browser CSS debugger. However, I will point out that Chrome, at least, includes a pretty-print function in its debugger. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:57:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:57:33 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:57:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:57:36 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #9 from Kyle M Hall --- Created attachment 25469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25469&action=edit Bug 5377 - Database fields too small for multiple ISBN and ISSN Test Plan: 1) Apply this patch 2) Create a record with 5 ISBNs and 5 ISSNs 3) Create a new report from the following SQL, or execute it from the mysql console: SELECT isbn, issn FROM biblioitems ORDER BY biblionumber DESC LIMIT 1 4) Note that all your ISBNs and ISSNs are listed, separated by the pipe character ( | ) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:58:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 21:58:21 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2014 22:34:27 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #10 from David Cook --- (In reply to Kyle M Hall from comment #9) > Created attachment 25469 [details] [review] > Bug 5377 - Database fields too small for multiple ISBN and ISSN > > Test Plan: > 1) Apply this patch > 2) Create a record with 5 ISBNs and 5 ISSNs > 3) Create a new report from the following SQL, or execute it from the > mysql console: > SELECT isbn, issn FROM biblioitems ORDER BY biblionumber DESC LIMIT 1 > 4) Note that all your ISBNs and ISSNs are listed, separated by the pipe > character ( | ) I'll have to try this out when I have some time. I wonder if the ISSN will display properly in Koha itself though if it's used to only having a single ISSN in that field. Still, happy to see movement on this one. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:02:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:02:44 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:02:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:02:48 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25469|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 25470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25470&action=edit Bug 5377 - Database fields too small for multiple ISBN and ISSN Test Plan: 1) Apply this patch 2) Create a record with 5 ISBNs and 5 ISSNs 3) Create a new report from the following SQL, or execute it from the mysql console: SELECT isbn, issn FROM biblioitems ORDER BY biblionumber DESC LIMIT 1 4) Note that all your ISBNs and ISSNs are listed, separated by the pipe character ( | ) Signed-off-by: Chris Cormack This might be slow to run on big databases, because of the 2 index rebuilds, however it changes no functionality just increases the field size which is safe enough (we store multiple now already) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:03:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:03:55 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- We never actually use biblioitems.issn for much of anything, certainly not if using XSLT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:12:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:12:54 +0000 Subject: [Koha-bugs] [Bug 11796] Results with 6 facets have missing facet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:12:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:12:57 +0000 Subject: [Koha-bugs] [Bug 11796] Results with 6 facets have missing facet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25466|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 25471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25471&action=edit Bug 11796 - Results with 6 facets have missing facet If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. Test Plan: 1) Perform a search that should give results for 6 different libraries 2) Note you only see 5 libraries in the facets with no option to expand 3) Apply this patch 4) Repeat step 1 5) Note you now have the option to expand the facets list Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:16:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:16:05 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:16:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:16:09 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20347|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 25472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25472&action=edit Bug 10714: Redirect to list contents view upon save after initiating edit from list contents view In the staff client, if you initiate a list edit from the list contents view you should be redirected to that same view after saving your changes. The OPAC already works this way. To test, view the contents of an existing list. Click the "Edit list" item under the "Edit" menu. Click save on the list edit form and you should be redirected back to the contents view of that list. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:19:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:19:05 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25465|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 25473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25473&action=edit Bug 10714 [Follow-up] Redirect to list contents view upon save after initiating edit from list contents view This follow-up corrects the "cancel" action on list edit actions based on whether the edit was initiated from the list of lists or the list contents view. To test, view the list of lists and click the edit link next to one of them. Click the cancel link. You should return to the list of lists you were just viewing. View the contents of a list. Choose "Edit list" from the edit menu. Click the cancel link on the edit screen. You should return to the list contents view from which you initiated the edit action. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:26:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:26:38 +0000 Subject: [Koha-bugs] [Bug 11795] Use validation plugin when creating new Z39.50 server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:26:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:26:42 +0000 Subject: [Koha-bugs] [Bug 11795] Use validation plugin when creating new Z39.50 server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25462|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 25474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25474&action=edit Bug 11795 - Use validation plugin when creating new Z39.50 server The page for adding a new Z39.50 server includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Z39.50 client targets -> New Z39.50 server. Try submitting the form with any of the following error conditions: - Missing Z39.50 server name - Missing hostname - Missing port - Non-numeric port - Missing database - Non-numeric rank - Non-numeric timeout These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing Z39.50 server should also work correctly. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:36:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:36:30 +0000 Subject: [Koha-bugs] [Bug 11793] Use validation plugin when creating new item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:36:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:36:34 +0000 Subject: [Koha-bugs] [Bug 11793] Use validation plugin when creating new item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25461|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 25475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25475&action=edit Bug 11793 - Use validation plugin when creating new item type The page for adding a new item type includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Item types -> New item type. Try submitting the form with the following error conditions: - Missing item type - Missing description - A non-number in the "rental charge" field These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing item type should also work correctly. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:48:41 +0000 Subject: [Koha-bugs] [Bug 11792] Use validation plugin when creating new currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11792 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:48:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:48:44 +0000 Subject: [Koha-bugs] [Bug 11792] Use validation plugin when creating new currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11792 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25460|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 25476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25476&action=edit Bug 11792 - Use validation plugin when creating new currency The page for adding a new currency includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Currencies & Exchange rates -> New currency. Try submitting the form without entering a currency, rate, and/or symbol. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing currency should also work correctly. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:51:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:51:47 +0000 Subject: [Koha-bugs] [Bug 11791] Use validation plugin when creating new city In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:51:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 03:51:51 +0000 Subject: [Koha-bugs] [Bug 11791] Use validation plugin when creating new city In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25458|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 25477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25477&action=edit Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 05:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 04:31:43 +0000 Subject: [Koha-bugs] [Bug 11797] New: auth_finder.pl: Odd number of elements in anonymous hash Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Bug ID: 11797 Summary: auth_finder.pl: Odd number of elements in anonymous hash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org While hunting through my live system Koha error logs I found: auth_finder.pl: Odd number of elements in anonymous hash at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 1037. So, I read the code and wondered what if a tag was missing in the giant if statement? http://www.loc.gov/marc/authority/ad1xx3xx.html lists a 162, but there is no 162, nor is there an else on the giant if statement. Test? I don't know, but the patch that follows should fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 05:45:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 04:45:44 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 05:45:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 04:45:46 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 --- Comment #1 from M. Tompsett --- Created attachment 25478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25478&action=edit Bug 11797 - auth_finder.pl: Odd number of elements in anonymous hash Added missing 162 MARC authorities tag and missing else case. If the records are not in a given order the first substring of the previous tag could be not 'a', but only 'a' exists for 162, so the hash would have "hemain => " which triggers the error. That's my theory anyways. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 05:46:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 04:46:28 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:05:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 08:05:41 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:06:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 08:06:04 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:49:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 08:49:09 +0000 Subject: [Koha-bugs] [Bug 11798] New: Problems with column sorting and row visibility in invoices table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Bug ID: 11798 Summary: Problems with column sorting and row visibility in invoices table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org There are some problems with column sorting and row visibility in invoices table. Symptoms: 1) Sorting on "Billing date" (functionality introduced by bug 10794) doesn't work properly any longer after bug 10401 was pushed (another side-effect being that "Vendor" column is currently not sortable at all). 2) Only "top ten" invoices are always displayed in the table, and it's not possible to change that without missing top/bottom DataTables pagination bars. (I'm not quite sure it's an error, perhaps it was intended to work like that = a feature, not a bug)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:19:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:19:40 +0000 Subject: [Koha-bugs] [Bug 11798] Problems with column sorting and row visibility in invoices table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 --- Comment #1 from Jacek Ablewicz --- Created attachment 25479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25479&action=edit Bug 11798 - Problems with column sorting and row visibility in invoices table 1) Sorting on "Billing date" (functionality introduced by bug 10794) doesn't work properly any longer after bug 10401 was pushed (another side-effect being that "Vendor" column is currently not sortable at all). 2) Only "top ten" invoices are always displayed in the table, and it's not possible to change that without missing top/bottom DataTables pagination bars. This patch fixes sorting for "Billing date" & "Vendor" columns in invoices table and restores the ability to see all table rows/search results (not just "top ten"). Test plan (you'll need to have 11+ invoices with various billing dates entered in the system): 1) apply patch, 2) view the Acquisitions invoices page (acqui/invoices.pl), do some search (= as broad search as possible) and confirm that "Billing date" and "Vendor" columns now do sort correctly, 3) in situations when there are more then 10 search results, they should all be visible in the invoices table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:26:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:26:43 +0000 Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices table doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #10 from Jacek Ablewicz --- (In reply to Joseph Alway from comment #9) > Yeah, I did notice that it was only displaying 10 items and there was no > option to show the rest. Which would be another bug. Unless they are being > caused by the same thing. Still don't know if the "top 10 only display" is a bug or a feature but I made a patch to fix both issues; see bug 11798. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:29:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:29:00 +0000 Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices table doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11798 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:29:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:29:00 +0000 Subject: [Koha-bugs] [Bug 11798] Problems with column sorting and row visibility in invoices table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |abl at biblos.pk.edu.pl Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10794 Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:41:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:41:25 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- Olli-Antti, should this be signed off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:47:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:47:28 +0000 Subject: [Koha-bugs] [Bug 11785] Use validation plugin when uploading local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:47:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:47:32 +0000 Subject: [Koha-bugs] [Bug 11785] Use validation plugin when uploading local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25405|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25480&action=edit Bug 11785 - Use validation plugin when uploading local cover images When uploading local cover images the form should not be submitted if no file has been selected. The existing form validation script doesn't work. This patch adds HTML5 validation attributes and use of Koha's built-in form validation plugin. To test, apply the patch and go to Tools -> Upload local cover image. Try to submit the form without selecting a file to upload. You should be prevented from doing so. Choose a file and confirm that the upload completes correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:50:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:50:35 +0000 Subject: [Koha-bugs] [Bug 11787] Use validation plugin when adding new vendor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:50:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 09:50:39 +0000 Subject: [Koha-bugs] [Bug 11787] Use validation plugin when adding new vendor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25406|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25481&action=edit Bug 11787 - Use validation plugin when adding new vendor The vendor entry form uses some custom JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. Also corrected: Minor validation issue. To test, apply the patch and go to Acquisitions -> New vendor. Try submitting the form without entering a vendor name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing vendor should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:03:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:03:17 +0000 Subject: [Koha-bugs] [Bug 11788] Use validation plugin when creating new course In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:03:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:03:21 +0000 Subject: [Koha-bugs] [Bug 11788] Use validation plugin when creating new course In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25407|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25482&action=edit Bug 11788 - Use validation plugin when creating new course The page for adding a new course includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Course reserves -> New course. Try submitting the form without entering a department, course number, and/or course name. This should trigger validation warnings. Submission of the form with valid data should work correctly. Editing an existing course should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:05:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:05:47 +0000 Subject: [Koha-bugs] [Bug 11789] Use validation plugin when creating new list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:05:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:05:51 +0000 Subject: [Koha-bugs] [Bug 11789] Use validation plugin when creating new list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25408|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 25483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25483&action=edit Bug 11789 - Use validation plugin when creating new list The page for adding a new list includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. Other edits: Minor validation fixes. To test, apply the patch and go to Lists -> New list. Try submitting the form without entering a list name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing list should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:07:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:07:39 +0000 Subject: [Koha-bugs] [Bug 11789] Use validation plugin when creating new list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Are you sure this "required" string is useful? The label is already in red. > I just passed QA on bug 11766 and bug 11767 and you didn't add it. > Should we be consistent for all forms? Owen's answer (IRC): I am trying to consistently add the "Required" note, and I realize I missed it on some of my recent patches. I think it's useful. Not everyone is going to know what the red color indicates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:21:03 +0000 Subject: [Koha-bugs] [Bug 11796] Results with 6 facets have missing facet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:21:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:21:08 +0000 Subject: [Koha-bugs] [Bug 11796] Results with 6 facets have missing facet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25471|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25484&action=edit Bug 11796 - Results with 6 facets have missing facet If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. Test Plan: 1) Perform a search that should give results for 6 different libraries 2) Note you only see 5 libraries in the facets with no option to expand 3) Apply this patch 4) Repeat step 1 5) Note you now have the option to expand the facets list Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart This patch should provide a regression test but I really don't know how to write it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:25:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:25:59 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:26:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:26:05 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25472|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 25485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25485&action=edit Bug 10714: Redirect to list contents view upon save after initiating edit from list contents view In the staff client, if you initiate a list edit from the list contents view you should be redirected to that same view after saving your changes. The OPAC already works this way. To test, view the contents of an existing list. Click the "Edit list" item under the "Edit" menu. Click save on the list edit form and you should be redirected back to the contents view of that list. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:26:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:26:13 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25473|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 25486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25486&action=edit Bug 10714 [Follow-up] Redirect to list contents view upon save after initiating edit from list contents view This follow-up corrects the "cancel" action on list edit actions based on whether the edit was initiated from the list of lists or the list contents view. To test, view the list of lists and click the edit link next to one of them. Click the cancel link. You should return to the list of lists you were just viewing. View the contents of a list. Choose "Edit list" from the edit menu. Click the cancel link on the edit screen. You should return to the list contents view from which you initiated the edit action. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:32:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:32:31 +0000 Subject: [Koha-bugs] [Bug 11795] Use validation plugin when creating new Z39.50 server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:32:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:32:34 +0000 Subject: [Koha-bugs] [Bug 11795] Use validation plugin when creating new Z39.50 server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25474|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25487&action=edit Bug 11795 - Use validation plugin when creating new Z39.50 server The page for adding a new Z39.50 server includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Z39.50 client targets -> New Z39.50 server. Try submitting the form with any of the following error conditions: - Missing Z39.50 server name - Missing hostname - Missing port - Non-numeric port - Missing database - Non-numeric rank - Non-numeric timeout These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing Z39.50 server should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Amended patch: replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:45:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:45:38 +0000 Subject: [Koha-bugs] [Bug 11793] Use validation plugin when creating new item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:45:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:45:43 +0000 Subject: [Koha-bugs] [Bug 11793] Use validation plugin when creating new item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25475|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25488&action=edit Bug 11793 - Use validation plugin when creating new item type The page for adding a new item type includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Item types -> New item type. Try submitting the form with the following error conditions: - Missing item type - Missing description - A non-number in the "rental charge" field These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing item type should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:47:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:47:52 +0000 Subject: [Koha-bugs] [Bug 11792] Use validation plugin when creating new currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:47:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 10:47:56 +0000 Subject: [Koha-bugs] [Bug 11792] Use validation plugin when creating new currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25476|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25489&action=edit Bug 11792 - Use validation plugin when creating new currency The page for adding a new currency includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Currencies & Exchange rates -> New currency. Try submitting the form without entering a currency, rate, and/or symbol. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing currency should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:04:03 +0000 Subject: [Koha-bugs] [Bug 11791] Use validation plugin when creating new city In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:04:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:04:09 +0000 Subject: [Koha-bugs] [Bug 11791] Use validation plugin when creating new city In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25477|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25490&action=edit Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Note: This patch changes the behavior. Before the patch, only 1 out of city and zip was required. Now both are. Since the 2 inputs were marked as required, I think they should be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:22:20 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #13 from Jonathan Druart --- The DB structure changes should be done on the deletedbiblioitems table too. Marked as Failed QA. Note: I got the following error "BLOB/TEXT column 'issn' used in key specification without a key length" My issn index was called issn_idx, I have absolutely no idea why... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:27:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:27:13 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:27:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:27:16 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #14 from Kyle M Hall --- Created attachment 25491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25491&action=edit Bug 5377 [QA Followup] - Alter deletedbiblioitems to match biblioitems -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:30:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:30:36 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25491|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 25492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25492&action=edit Bug 5377 [QA Followup] - Alter deletedbiblioitems to match biblioitems -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:34:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:34:04 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #16 from Kyle M Hall --- The latest followup only alters the isbn index for deletedbiblioitems. The previous iteration from the patch added an issn index that didn't previously exist. I added it to make it make biblioitems, but now I'm removing it because I see no benefit from having it, and at the least having it will cause cost a bit more cpu time and disk space. QA'ers, if you feel for some reason the deletedbiblioitems table *should* have an issn index, just deprecate the followup, and restore the previous iteration of it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:42:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:42:59 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:43:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:43:06 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25470|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 25493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25493&action=edit Bug 5377 - Database fields too small for multiple ISBN and ISSN Test Plan: 1) Apply this patch 2) Create a record with 5 ISBNs and 5 ISSNs 3) Create a new report from the following SQL, or execute it from the mysql console: SELECT isbn, issn FROM biblioitems ORDER BY biblionumber DESC LIMIT 1 4) Note that all your ISBNs and ISSNs are listed, separated by the pipe character ( | ) Signed-off-by: Chris Cormack This might be slow to run on big databases, because of the 2 index rebuilds, however it changes no functionality just increases the field size which is safe enough (we store multiple now already) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:43:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:43:36 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25492|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 25494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25494&action=edit Bug 5377 [QA Followup] - Alter deletedbiblioitems to match biblioitems Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:45:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:45:19 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #19 from Jonathan Druart --- Created attachment 25495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25495&action=edit Bug 5377: No index on deletedbiblioitems.issn This patch removes a trailing space and remove the issn index deletion (it does not exist on deletedbiblioitems). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:48:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:48:58 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #2 from paxed --- (In reply to Magnus Enger from comment #1) > > I seem to remember someone saying that we should keep the iso2709 in > biblioitems.marc, because if you want to export e.g. 500k records in iso2709 > format, transforming all those records from marcxml on the fly would be > *really* heavy. But I might be wrong... I'd think not having to take care of twice the data would weigh more than possibly having a hypothetical situation of exporting 500k iso2709 records... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:53:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:53:16 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #20 from Jonathan Druart --- (In reply to Kyle M Hall from comment #16) > QA'ers, if you feel for some reason the deletedbiblioitems table *should* > have an issn index, just deprecate the followup, and restore the previous > iteration of it. I didn't see your comment when I submitted my QA patches. In my opinion, if the index is not in use, it is useless to add it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:54:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:54:24 +0000 Subject: [Koha-bugs] [Bug 11799] New: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 Bug ID: 11799 Summary: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Remove unused (obsolete) routine from VirtualShelves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:58:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:58:18 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:58:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:58:21 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 --- Comment #1 from M. de Rooy --- Created attachment 25496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25496&action=edit Bug 11799: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm This routine is no longer used. Test plan: Do a grep on the name. (Bonus points:) Verify if you can perform some actions on lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:58:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 11:58:58 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:00:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 12:00:39 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 12:42:04 +0000 Subject: [Koha-bugs] [Bug 11479] Remove experimental given/when from C4::MarcModificationTemplates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 --- Comment #4 from Colin Campbell --- (In reply to Jonathan Druart from comment #3) > This one is not a given/when, but a for/when. Which is not experimental. > To me this patch is not relevant. ~/kohaclone$ perl -wc C4/MarcModificationTemplates.pm when is experimental at /home/cc/kohaclone/Koha/SimpleMARC.pm line 93. when is experimental at /home/cc/kohaclone/Koha/SimpleMARC.pm line 96. when is experimental at /home/cc/kohaclone/Koha/SimpleMARC.pm line 99. when is experimental at C4/MarcModificationTemplates.pm line 552. when is experimental at C4/MarcModificationTemplates.pm line 558. when is experimental at C4/MarcModificationTemplates.pm line 564. when is experimental at C4/MarcModificationTemplates.pm line 570. when is experimental at C4/MarcModificationTemplates.pm line 581. when is experimental at C4/MarcModificationTemplates.pm line 584. when is experimental at C4/MarcModificationTemplates.pm line 587. when is experimental at C4/MarcModificationTemplates.pm line 590. C4/MarcModificationTemplates.pm syntax OK And here is the notification from the 5.18 delta The smartmatch family of features are now experimental Smart match, added in v5.10.0 and significantly revised in v5.10.1, has been a regular point of complaint. Although there are a number of ways in which it is useful, it has also proven problematic and confusing for both users and implementors of Perl. There have been a number of proposals on how to best address the problem. It is clear that smartmatch is almost certainly either going to change or go away in the future. Relying on its current behavior is not recommended. Warnings will now be issued when the parser sees "~~", "given", or "when". To disable these warnings, you can add this line to the appropriate scope: no if $] >= 5.018, warnings => "experimental::smartmatch"; Consider, though, replacing the use of these features, as they may change behavior again before becoming stable. for/when relies on smartmatch the patch is relevant -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:00:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 13:00:21 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Olli-Antti Kivilahti --- oki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 13:25:30 +0000 Subject: [Koha-bugs] [Bug 11479] Remove experimental given/when from C4::MarcModificationTemplates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 13:25:34 +0000 Subject: [Koha-bugs] [Bug 11479] Remove experimental given/when from C4::MarcModificationTemplates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25356|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 25497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25497&action=edit Bug 11479 Remove experimental given/when keywords Replace constructs using given and when by if/else feature now generates compilation warnings in 5.18 and is liable to change behaviour replaced the construcrs with if/else reformatted the if branching using perltidy to remove the now redundant indent Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 13:25:55 +0000 Subject: [Koha-bugs] [Bug 11478] Remove experimental given/when from Koha::SimpleMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 13:25:59 +0000 Subject: [Koha-bugs] [Bug 11478] Remove experimental given/when from Koha::SimpleMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25355|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 25498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25498&action=edit Bug 11478 Replace experimental given/when keywords The keywords given and when are flagged experimental in perl 5.18 and subject to change replace the construct by an if/elsif Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:05:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:05:55 +0000 Subject: [Koha-bugs] [Bug 11468] Remove use of smartmatch from DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468 --- Comment #6 from Colin Campbell --- (In reply to Fridolin SOMERS from comment #5) > Should the use of given/when be avoided ? > If yes it may be added to > http://wiki.koha-community.org/wiki/Coding_Guidelines I think so This is the perldelta for 5.18 : The smartmatch family of features are now experimental Smart match, added in v5.10.0 and significantly revised in v5.10.1, has been a regular point of complaint. Although there are a number of ways in which it is useful, it has also proven problematic and confusing for both users and implementors of Perl. There have been a number of proposals on how to best address the problem. It is clear that smartmatch is almost certainly either going to change or go away in the future. Relying on its current behavior is not recommended. Warnings will now be issued when the parser sees "~~", "given", or "when". To disable these warnings, you can add this line to the appropriate scope: no if $] >= 5.018, warnings => "experimental::smartmatch"; Consider, though, replacing the use of these features, as they may change behavior again before becoming stable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:22:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:22:16 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #50 from M. de Rooy --- Some comments after experimenting the feature further on bootstrap/prog. Should we still put time in ccsr? 1. If you disable OpacBrowseResults, please remove the link. 2. In bootstrap clicking Browse selected on detail page does not respond (prog does) 3. This is a weird one but just mentioning: Disable cookies in your browser. Check two biblios on the same page. Click on Browse selected. No item was selected. Heh. If you cannot save the cookie, remove link too? Note that by checking the cookie again in setContextBiblioNumbers, you know if the first call succeeded or not. Waiting for some feedback. After that I will still have to look at the code somewhat more closely.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:30:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:30:29 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23713|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 25499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25499&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:30:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:30:34 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23714|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 25500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25500&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:30:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:30:39 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23715|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 25501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25501&action=edit Bug 11430: UT: add unit tests to delete only selected lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:30:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:30:45 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23716|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 25502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25502&action=edit Bug 11430: OPAC changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:30:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:30:55 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23718|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 25504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25504&action=edit Bug 11430: Intranet changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:30:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:30:50 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23717|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 25503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25503&action=edit Bug 11430: OPAC changes -- prog theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:31:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:31:14 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #13 from Jonathan Druart --- Rebased patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:50:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:50:00 +0000 Subject: [Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:50:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:50:07 +0000 Subject: [Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677 --- Comment #2 from Owen Leonard --- Created attachment 25505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25505&action=edit Bug 9677 - Style button on notices and slips page with Bootstrap The toolbar button on the Notices & Slips page isn't styled with Bootstrap as other toolbar buttons are. This patch corrects this. The patch also removes some obsolete CSS. To test go to Tools -> Notices and Slips. The toolbar button should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:59:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 14:59:37 +0000 Subject: [Koha-bugs] [Bug 11800] New: Correct toolbar markup on course reserve pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11800 Bug ID: 11800 Summary: Correct toolbar markup on course reserve pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The toolbar markup on a couple of the course reserve pages doesn't exactly match other instances in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:03:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:03:15 +0000 Subject: [Koha-bugs] [Bug 11800] Correct toolbar markup on course reserve pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11800 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:03:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:03:18 +0000 Subject: [Koha-bugs] [Bug 11800] Correct toolbar markup on course reserve pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11800 --- Comment #1 from Owen Leonard --- Created attachment 25506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25506&action=edit Bug 11800 - Correct toolbar markup on course reserve pages This patch corrects some inconsistencies between the toolbars on some course reserves pages and other toolbars in Koha. Other changes: Removed obsolete commented markup and corrected some invalid markup. To test course reserves must be enabled. View the list of course reserves (course_reserves/course-reserves.pl) and the detail view of a course (course_reserves/course-details.pl?course_id=X). Toolbars on both pages should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:06:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:06:15 +0000 Subject: [Koha-bugs] [Bug 11801] New: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Bug ID: 11801 Summary: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:06:25 +0000 Subject: [Koha-bugs] [Bug 11801] In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:10:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:10:04 +0000 Subject: [Koha-bugs] [Bug 11801] In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #1 from Kyle M Hall --- Created attachment 25507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25507&action=edit Pre-patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:10:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:10:20 +0000 Subject: [Koha-bugs] [Bug 11801] In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #2 from Kyle M Hall --- Created attachment 25508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25508&action=edit Post-patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:11:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:11:05 +0000 Subject: [Koha-bugs] [Bug 11801] In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:11:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:11:08 +0000 Subject: [Koha-bugs] [Bug 11801] In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #3 from Kyle M Hall --- Created attachment 25509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25509&action=edit Bug 11801 - In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:13:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:13:45 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25448|0 |1 is obsolete| | --- Comment #7 from Benjamin Rokseth --- Created attachment 25510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25510&action=edit Bug 11518 [Followup] - Change method name from 'itemtype' to 'effective_itemtype' for clarity Test runs without errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:16:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:16:38 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |benjamin.rokseth at kul.oslo.k | |ommune.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:19:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:19:21 +0000 Subject: [Koha-bugs] [Bug 11802] New: Patron purchase suggestions page requires some corrections Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 Bug ID: 11802 Summary: Patron purchase suggestions page requires some corrections Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/purchase-suggestions.pl?borrower number=X OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Patrons Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The purchase suggestions page for an individual patron (members/purchase-suggestions.pl) has some errors: - The patron image doesn't appear - The button toolbar markup isn't correct - Unescaped ampersands triggering validation errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:25:58 +0000 Subject: [Koha-bugs] [Bug 11802] Patron purchase suggestions page requires some corrections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:26:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:26:00 +0000 Subject: [Koha-bugs] [Bug 11802] Patron purchase suggestions page requires some corrections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 --- Comment #1 from Owen Leonard --- Created attachment 25511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25511&action=edit Bug 11802 - Patron purchase suggestions page requires some corrections This patch corrects some errors with the staff client's patron purchase suggestions page (members/purchase-suggestions.pl). To test, apply the patch and make sure the patronimages system preference is enabled. - View the purchase suggestions page for a patron whose record has a patron image attached. The image should appear in the left-hand sidebar. - View the page for a patron who has submitted no purchase suggestions. The message should be styled correctly. - The toolbar on the page should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:42:04 +0000 Subject: [Koha-bugs] [Bug 11801] In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In transit hold items |In transit hold items |incorrectly labels as |incorrectly labeled as |"Waiting to be pulled" on |"Waiting to be pulled" on |request.pl |request.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:51:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:51:21 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #51 from Jonathan Druart --- Created attachment 25512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25512&action=edit Bug 10858: fix bad merge conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:51:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:51:29 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #52 from Jonathan Druart --- Created attachment 25513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25513&action=edit Bug 10858: follow-up Don't use the cookie if the ft is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:51:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:51:35 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #53 from Jonathan Druart --- Created attachment 25514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25514&action=edit Bug 10858: Handle JS deactivated and cookies disabled If JS is deactivated, the "browse" link should not be displayed. Same if cookies are disabled, the feature does not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:53:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:53:45 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #54 from Jonathan Druart --- (In reply to M. de Rooy from comment #50) > 1. If you disable OpacBrowseResults, please remove the link. Fixed > 2. In bootstrap clicking Browse selected on detail page does not respond > (prog does) Cause by a bad merge conflict reintroduced by last set of patches. Fixed! > 3. This is a weird one but just mentioning: Disable cookies in your browser. > Check two biblios on the same page. Click on Browse selected. No item was > selected. Heh. If you cannot save the cookie, remove link too? Note that by > checking the cookie again in setContextBiblioNumbers, you know if the first > call succeeded or not. Fixed too with the last patch. There were some weird behaviors if javascript was deactivated or cookies disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:57:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:57:54 +0000 Subject: [Koha-bugs] [Bug 11479] Remove experimental given/when from C4::MarcModificationTemplates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:58:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 15:58:15 +0000 Subject: [Koha-bugs] [Bug 11478] Remove experimental given/when from Koha::SimpleMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:12:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 16:12:17 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- I repeated this test today with PREDUEDGST and it's the same result: We print the branch information from the patron's branch, but it's not using the notice template from the patron's branch but the general template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:33:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 16:33:25 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:33:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 16:33:32 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:46:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 16:46:09 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:46:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 16:46:14 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 --- Comment #1 from Owen Leonard --- Created attachment 25515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25515&action=edit Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:55:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 16:55:30 +0000 Subject: [Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:58:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 16:58:49 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:07:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:07:32 +0000 Subject: [Koha-bugs] [Bug 11785] Use validation plugin when uploading local cover images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11785 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:07:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:07:42 +0000 Subject: [Koha-bugs] [Bug 11787] Use validation plugin when adding new vendor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:07:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:07:52 +0000 Subject: [Koha-bugs] [Bug 11788] Use validation plugin when creating new course In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11788 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:07:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:07:58 +0000 Subject: [Koha-bugs] [Bug 11795] Use validation plugin when creating new Z39.50 server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11795 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:08:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:08:09 +0000 Subject: [Koha-bugs] [Bug 11793] Use validation plugin when creating new item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:08:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:08:16 +0000 Subject: [Koha-bugs] [Bug 11792] Use validation plugin when creating new currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11792 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:08:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:08:23 +0000 Subject: [Koha-bugs] [Bug 11791] Use validation plugin when creating new city In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:09:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:09:18 +0000 Subject: [Koha-bugs] [Bug 11789] Use validation plugin when creating new list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11789 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #6 from Galen Charlton --- This patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:14:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:14:22 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 --- Comment #2 from Marc V?ron --- Created attachment 25516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25516&action=edit [Signed-off] Bug 3766 - Cities/Towns and Road Types only on one address When adding a new patron only the primary contact city/state fields are linked to a dropdown listing values from stored city/state/zip/country values. The same dropdown of predefined values should be linked to alternate address and alternate contact. This patch does so by adapting the same JS and markup for these additional cases. To test you should have cities defined in Administration -> Cities. - Edit or create a new patron. - Under main address -> city select one of the predefined entries. - The city, state, zip, and country values should be correctly populated. - Test under alternate address -> city and alternate contact -> city. - Save your changes and confirm that everything worked correctly. Works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:15:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:15:16 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25449|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:15:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:15:30 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:24:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:24:15 +0000 Subject: [Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677 --- Comment #3 from Marc V?ron --- Created attachment 25517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25517&action=edit [Signed-off] Bug 9677 - Style button on notices and slips page with Bootstrap The toolbar button on the Notices & Slips page isn't styled with Bootstrap as other toolbar buttons are. This patch corrects this. The patch also removes some obsolete CSS. To test go to Tools -> Notices and Slips. The toolbar button should look correct and work correctly. Patch works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:24:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:24:37 +0000 Subject: [Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25505|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:24:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:24:45 +0000 Subject: [Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:38:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:38:54 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 --- Comment #2 from Marc V?ron --- Created attachment 25518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25518&action=edit [Signed-off]Bug 11799: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm This routine is no longer used. Test plan: Do a grep on the name. (Bonus points:) Verify if you can perform some actions on lists. No more occurences of _biblionumber_sth found Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:39:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:39:19 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25496|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 17:39:28 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 19:16:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 18:16:53 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 --- Comment #11 from Kyle M Hall --- (In reply to Katrin Fischer from comment #10) > Created attachment 24195 [details] > test case home library/pickup library > > Kyle, I have double checked everything, but the test case described in the > attached PDF doesn't seem to give the correct result to me. Could you please > take a look? > > When I turn off LocalHoldsPriority the hold for R is triggered. I think I made the assumption that the holds would be iterated over in order of priority. I'll try to reproduce your results and see what I can do! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 19:47:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 18:47:32 +0000 Subject: [Koha-bugs] [Bug 11803] New: Consistent use of $dbh in _koha_modify_item Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11803 Bug ID: 11803 Summary: Consistent use of $dbh in _koha_modify_item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 19:47:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 18:47:46 +0000 Subject: [Koha-bugs] [Bug 11803] Consistent use of $dbh in _koha_modify_item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11803 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 19:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 18:49:25 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 19:51:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 18:51:06 +0000 Subject: [Koha-bugs] [Bug 11803] Consistent use of $dbh in _koha_modify_item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11803 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 19:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 18:51:08 +0000 Subject: [Koha-bugs] [Bug 11803] Consistent use of $dbh in _koha_modify_item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11803 --- Comment #1 from M. de Rooy --- Created attachment 25519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25519&action=edit Bug 11803: Consistent use of $dbh in _koha_modify_item This is just some code cleanup, no behavior change expected. Also replacing errstr with err in testing the results. (See DBI.) Test plan: Modify an item and save it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 19:02:56 +0000 Subject: [Koha-bugs] [Bug 11796] Results with 6 facets have missing facet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11796 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:10:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 19:10:25 +0000 Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and MARC21 in some sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:29:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 19:29:55 +0000 Subject: [Koha-bugs] [Bug 11804] New: there should not be both a circ-menu.tt and a circ-menu.inc Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Bug ID: 11804 Summary: there should not be both a circ-menu.tt and a circ-menu.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org koha/koha-tmpl/intranet-tmpl/prog/en/includes/ contains both a circ-menu.tt and a circ-menu.inc. circ-menu.tt contains the following comment: [%# duplicates circ-menu.inc but assumes all borrower attributes are in a borrower variable rather than in the global namespace %] circ-menu.tt is used only by the following templates: members/pay.tt members/paycollect.tt This is a blatant violation of the DRY principle, and some inconsistencies have appeared over the years: * the purchase suggestions tab doesn't show up when using the fine payment page * the logic for displaying the notices tab differs The duplication should be removed, perhaps as part of a larger project to make all of the patron and circulation pages use the same routine to grab information about the current patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:32:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 19:32:00 +0000 Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines rather than account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Ketan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:36:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 19:36:14 +0000 Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Nicole! I agree with Marcel that the form needs a revamp to make it clear that it has two distinct modes of operation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:39:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 19:39:02 +0000 Subject: [Koha-bugs] [Bug 11789] Use validation plugin when creating new list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11789 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:39:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 19:39:06 +0000 Subject: [Koha-bugs] [Bug 11789] Use validation plugin when creating new list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11789 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25483|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 25520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25520&action=edit Bug 11789 - Use validation plugin when creating new list The page for adding a new list includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. Other edits: Minor validation fixes. To test, apply the patch and go to Lists -> New list. Try submitting the form without entering a list name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing list should also work correctly. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:20:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:20:11 +0000 Subject: [Koha-bugs] [Bug 11328] Show local cover images in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Local cover images not |Show local cover images in |appearing in staff client |staff client search results |search results | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:29:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:29:40 +0000 Subject: [Koha-bugs] [Bug 11328] Show local cover images in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 --- Comment #3 from Owen Leonard --- Created attachment 25521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25521&action=edit Bug 11328 - Show local cover images in staff client search results Local cover images do not appear in staff client search results. This patch adds them. To test, enable the LocalCoverImages system preference and add at least one cover image to a title. Perform a search which will return results that include your title. Confirm that the local cover image is displayed. Search results should also display correctly with and without AmazonCoverImages enabled as well as with LocalCoverImages disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:29:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:29:36 +0000 Subject: [Koha-bugs] [Bug 11328] Show local cover images in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:37:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:37:24 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla at live.ca --- Comment #6 from Fr?d?rick Capovilla --- Created attachment 25522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25522&action=edit Prevent local authentification fallback if an invalid LDAP password was entered. We encountered the same problem with on our instances and created a patch to fix it. With this patch, the authentication now fails if the LDAP authentication fails because of an invalid password. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:41:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:41:55 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fcapovilla at live.ca --- Comment #7 from Fr?d?rick Capovilla --- Created attachment 25523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25523&action=edit Only update the password if the LDAP password field was mapped. Here is a second patch I think is related to this problem. With this patch, local password won't be updated if the "password" field is not mapped in the LDAP configuration. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:42:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:42:08 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:42:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:42:26 +0000 Subject: [Koha-bugs] [Bug 11805] New: Use validation plugin when creating new basket in Acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11805 Bug ID: 11805 Summary: Use validation plugin when creating new basket in Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/roadtype.pl?op=add_form OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The new basket entry form in Acquisitions uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:46:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:46:19 +0000 Subject: [Koha-bugs] [Bug 11805] Use validation plugin when creating new basket in Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11805 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:46:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 20:46:22 +0000 Subject: [Koha-bugs] [Bug 11805] Use validation plugin when creating new basket in Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11805 --- Comment #1 from Owen Leonard --- Created attachment 25524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25524&action=edit Bug 11805 - Use validation plugin when creating new basket in Acquisitions The page for adding a new basket in Acquisitions includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Acquisitions -> Choose a vendor -> New basket. Try submitting the form without entering a basket name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing basket should also work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:06:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:06:37 +0000 Subject: [Koha-bugs] [Bug 11806] New: Use validation plugin when creating new OAI set Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806 Bug ID: 11806 Summary: Use validation plugin when creating new OAI set Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/oai_sets.pl?op=new OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The new OAI set entry form shows that two fields are required but does not enforce this requirement. This can be handled client-side with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:07:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:07:05 +0000 Subject: [Koha-bugs] [Bug 11805] Use validation plugin when creating new basket in Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11805 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- URL|/cgi-bin/koha/admin/roadtyp |/cgi-bin/koha/acqui/basketh |e.pl?op=add_form |eader.pl?booksellerid=X&op= | |add_form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:11:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:11:43 +0000 Subject: [Koha-bugs] [Bug 11806] Use validation plugin when creating new OAI set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:11:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:11:47 +0000 Subject: [Koha-bugs] [Bug 11806] Use validation plugin when creating new OAI set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806 --- Comment #1 from Owen Leonard --- Created attachment 25525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25525&action=edit Bug 11806 - Use validation plugin when creating new OAI set The form for adding a new OAI indicates that two fields are required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Administration -> OAI sets configuration -> New set. Try submitting the form without entering a setSpec and/or setName. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing set should also work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:15:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:15:44 +0000 Subject: [Koha-bugs] [Bug 11807] New: Add categorycode conversions to LDAP authentication. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Bug ID: 11807 Summary: Add categorycode conversions to LDAP authentication. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 25526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25526&action=edit Add support for categorycode conversions when updating an user using a LDAP server. This patch lets you easily configure mappings for categorycode values. These mapping will be used when updating the user's account after a successful LDAP login. Here is an example configuration : STU ... STUDENT EMPLOYEE With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:16:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:16:07 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:18:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:18:35 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 --- Comment #1 from Fr?d?rick Capovilla --- Note: This patch also includes a small fix for the update of mapped LDAP date values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:24:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:24:42 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:39:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:39:04 +0000 Subject: [Koha-bugs] [Bug 11808] New: When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Bug ID: 11808 Summary: When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 25527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25527&action=edit Add the SearchCardnumberWithLDAP system preference. This patch adds the "SearchCardnumberWithLDAP" system preference which will let you search for cardnumbers on a LDAP server. This feature only works in the Circulation section's "Check out" search bar. This feature is useful if you want to be able to checkout items for new users who were added on an LDAP server, but never connected on the OPAC. Here is how this feature works: * The librarian searches for a cardnumber in the intranet to do a checkout. * Search for the cardnumber in the local database. * If no borrower was found, SearchCardnumberWithLDAP is activated and an LDAP server is configured, search for the borrower on the LDAP server. * If a borrower was found on the LDAP server, add it to the local database. Also: * If the borrower was found in the local database, SearchCardnumberWithLDAP is activated and an LDAP server is configured, the borrower is updated using the informations on the LDAP server. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:50:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:50:43 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:50:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:50:48 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #1 from Fr?d?rick Capovilla --- To test this feature, you must have a LDAP server and configure it in your "koha-conf.xml" with at least mappings for the cardnumber and firstname fields. Make sure all required fields are mapped. Test case 1 : * Add a borrower with the cardnumber "12345" and the name "Test user" on your LDAP server. Make sure this cardnumber doesn't exist in your Koha database. * Activate the "SearchCardnumberWithLDAP" system preference. * Go to the "Circulation" section and search for the "12345" cardnumber to do a checkout. * You should be redirected to the circulation page for the "Test user" borrower, which means the LDAP user was successfully added to the local database. * Modify the "12345" user on your LDAP server. For example, change its name to "Bob". * Go to the "Circulation" section and search for the "12345" cardnumber again. * The user's name should now be "Bob" on the circulation page. Test case 2 : * Disable the "SearchCardnumberWithLDAP" system preference. * Modify the "12345" user on your LDAP server. For example, change its name to "Lisa". * Go to the "Circulation" section and search for the "12345" cardnumber again. * The user's name should still be "Bob" because the account was not updated this time. * Add a borrower with the cardnumber "123456" and the name "Test user 2" on your LDAP server. Make sure this cardnumber doesn't exist in your Koha database. * Go to the "Circulation" section and search for the "123456" cardnumber to do a checkout. * "No patron matched '123456'" should be shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:51:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 21:51:04 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:26:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 22:26:28 +0000 Subject: [Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:30:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 22:30:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:37:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 22:37:10 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24856|0 |1 is obsolete| | --- Comment #3 from Jesse Weaver --- Created attachment 25528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25528&action=edit Bug 11211 - Move calculation code out of C4::Calendar This patch moves the calculation code out of C4::Calendar, replacing any references to it with Koha::Calendar. Additionally, it moves the administration interface to a single script, tools/calendar.pl. NOTE: This is intended as a bridge to bug 8133, so the UI is a bit awkward, and C4::Calendar has an API designed for adding hours to the calendar. All features should still work, and 8133 will make things better. Test plan: 1) Install the new dependency, Template::Plugin::JavaScript. 2) prove t/db_dependent/Calendar.t t/db_dependent/Holidays.t to verify that the new C4::Calendar API works correctly. 3) prove t/Calendar.t 4) Add, remove and modify events of each type using the administrative interface. In this version, changing a repeating event to "Open" deletes it. 5) Check out items to verify that the calculation code is using the events you just created. 6) If possible, verify that the two affected cronjobs still function correctly. (Rebased version.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 00:07:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 23:07:41 +0000 Subject: [Koha-bugs] [Bug 6897] show hold expiration date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6897 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 00:15:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2014 23:15:59 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #2 from Joy Nelson --- I have had a library ask for this same thing. The downside I see here is that libraries may start setting up a billion patron categories because of the granularity in permissions. Something to consider. joy (In reply to David Cook from comment #1) > I think that this is a great idea. > > I've recently had a library ask if this is a possibility, so it would be > great to see this get into Koha. > > I have other priorities at the moment, but I would be happy to test any > patches and maybe write my own sometime in the future. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 07:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 06:59:57 +0000 Subject: [Koha-bugs] [Bug 11809] New: Bootstrap should not show Clear date -link if the date is required Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11809 Bug ID: 11809 Summary: Bootstrap should not show Clear date -link if the date is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org In OPAC, when patron changes his personal information, the page shows a "Clear date" -link after the Date of Birth -input, even when DoB is set to required field. That link should not be shown if DoB is required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:11:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:11:39 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 --- Comment #3 from Jonathan Druart --- Created attachment 25529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25529&action=edit Bug 11799: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm This routine is no longer used. Test plan: Do a grep on the name. (Bonus points:) Verify if you can perform some actions on lists. No more occurences of _biblionumber_sth found Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:11:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:11:56 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:23:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:23:11 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Lists |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:23:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:23:19 +0000 Subject: [Koha-bugs] [Bug 11799] Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:23:28 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:23:28 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Bug 11475 depends on bug 9044, which changed state. Bug 9044 Summary: Allow to select items on catalogue/detail.pl and trigger actions http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:29 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:30 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 Bug 3934 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:31 +0000 Subject: [Koha-bugs] [Bug 7592] year/month pattern In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7592 Bug 7592 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:30 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Bug 5338 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:31 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Bug 7677 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:32 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Bug 11262 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:32 +0000 Subject: [Koha-bugs] [Bug 11168] GetLateOrMissingIssues: $supplierid is not mandatory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11168 Bug 11168 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:32 +0000 Subject: [Koha-bugs] [Bug 11263] New 'locale' setting in subscriptions is not user friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Bug 11263 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:32 +0000 Subject: [Koha-bugs] [Bug 11265] Problems with locale saving/editing on serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11265 Bug 11265 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:33 +0000 Subject: [Koha-bugs] [Bug 11386] Mandatory fields in subscription add form should use standard formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11386 Bug 11386 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:24:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:24:33 +0000 Subject: [Koha-bugs] [Bug 11295] Serials manual history can no longer be added or edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11295 Bug 11295 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:25:08 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:25:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:25:09 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 5349, which changed state. Bug 5349 Summary: Moving an order http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:25:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:25:43 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:25:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:25:43 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 7295, which changed state. Bug 7295 Summary: list of librarian managing a basket http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:25:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:25:43 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for recieving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Bug 7290 depends on bug 7295, which changed state. Bug 7295 Summary: list of librarian managing a basket http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:25:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 08:25:44 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Bug 7292 depends on bug 7295, which changed state. Bug 7295 Summary: list of librarian managing a basket http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:02:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 11:02:35 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:08:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 11:08:26 +0000 Subject: [Koha-bugs] [Bug 2559] Language limit on Spanish returns Russian records or is it English ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2559 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:34:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 11:34:21 +0000 Subject: [Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677 --- Comment #4 from Jonathan Druart --- Created attachment 25530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25530&action=edit Bug 9677 - Style button on notices and slips page with Bootstrap The toolbar button on the Notices & Slips page isn't styled with Bootstrap as other toolbar buttons are. This patch corrects this. The patch also removes some obsolete CSS. To test go to Tools -> Notices and Slips. The toolbar button should look correct and work correctly. Patch works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart "yui-menu-button" is not contained in tt files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:34:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 11:34:49 +0000 Subject: [Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25517|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:35:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 11:35:01 +0000 Subject: [Koha-bugs] [Bug 9677] Style button on notices and slips page with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:00:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:00:31 +0000 Subject: [Koha-bugs] [Bug 11810] New: Input fields in OPAC suggestion form are a bit short (Bootstrap) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11810 Bug ID: 11810 Summary: Input fields in OPAC suggestion form are a bit short (Bootstrap) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The input fields for suggestions in the OPAC are a bit short in the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:15:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:15:06 +0000 Subject: [Koha-bugs] [Bug 6814] Notify suggestor when item is received in the library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6814 Bug 6814 depends on bug 7096, which changed state. Bug 7096 Summary: Receiving suggested items does not trigger notification mail (AVAILABLE) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7096 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:15:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:15:05 +0000 Subject: [Koha-bugs] [Bug 7096] Receiving suggested items does not trigger notification mail (AVAILABLE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- Retesting all the suggestion messages today and emails are sent correctly - including the AVAILABLE when the item is received. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:15:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:15:06 +0000 Subject: [Koha-bugs] [Bug 4211] Acquisitions actions on suggestions don't generate email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4211 Bug 4211 depends on bug 7096, which changed state. Bug 7096 Summary: Receiving suggested items does not trigger notification mail (AVAILABLE) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7096 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:16:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:16:24 +0000 Subject: [Koha-bugs] [Bug 6814] Notify suggestor when item is received in the library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6814 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- The patron who made the suggestion can be notified automatically when the item is received using the AVAILABLE notice template. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:17:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:17:59 +0000 Subject: [Koha-bugs] [Bug 7322] Implement emailPurchaseSuggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 5770 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:17:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:17:59 +0000 Subject: [Koha-bugs] [Bug 5770] email librarian when purchase suggestion made In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #2 from Katrin Fischer --- *** Bug 7322 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:20:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:20:04 +0000 Subject: [Koha-bugs] [Bug 7094] Ordering from a suggestion does not trigger notification mail (ORDERED) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7094 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Retested today and an ORDERED email was created and sent correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:20:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:20:04 +0000 Subject: [Koha-bugs] [Bug 4211] Acquisitions actions on suggestions don't generate email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4211 Bug 4211 depends on bug 7094, which changed state. Bug 7094 Summary: Ordering from a suggestion does not trigger notification mail (ORDERED) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7094 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:50:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:50:38 +0000 Subject: [Koha-bugs] [Bug 11811] New: tools/import_borrowers.pl doesn't support utf-8 encoded CSV Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11811 Bug ID: 11811 Summary: tools/import_borrowers.pl doesn't support utf-8 encoded CSV Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:54:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 12:54:41 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #54 from Jonathan Druart --- (In reply to M. de Rooy from comment #51) > Created attachment 20369 [details] [review] > Bug 8044: Translate basket CSV column names using Koha::I18N Note: this patch is not needed anymore. Bug 10935 fixes the translatable issue on csv headers. But the module and others patches is still needed to translate some others strings (in C4::SIP::* for instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:02:37 +0000 Subject: [Koha-bugs] [Bug 11811] tools/import_borrowers.pl doesn't support utf-8 encoded CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11811 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:15:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:15:56 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- Jonathan, I wonder if it would be best to define the list of statuses in a package constant in C4::Serials, and to replace all the references to the array of statuses with this constant to make future additions simpler. use constant MISSING_STATUSES => [ 2, 4, 41, 42, 43, 44, 5 ]; If you think this isn't an idea worth pursuing just reset the status to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:21:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:21:50 +0000 Subject: [Koha-bugs] [Bug 10580] Remove NoZebra reference from Makefile.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10580 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:21:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:21:53 +0000 Subject: [Koha-bugs] [Bug 10580] Remove NoZebra reference from Makefile.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10580 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25315|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 25531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25531&action=edit Bug 10580: Zebra no more optional in Koha setup Running Makefile.PL asks the user whether to install the Zebra configuration files and different texts relate to the user having chosen to use Zebra. This patch removes references to choosing to use Zebra and removes the related variables from the code. To test: - Apply the patch - Go through the different install modes - Verify that nothing nothing is broken - Sign off Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:28:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:28:27 +0000 Subject: [Koha-bugs] [Bug 11707] Additional attributes broken for category code with space In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- I agree with Katrin's comment. Perhaps it would be better to fix this by adding a check to the attribute creator to stop a librarian from creating an attribute with a space in the value, and perhaps some of Joy's other recommendations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:28:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:28:33 +0000 Subject: [Koha-bugs] [Bug 11707] Additional attributes broken for category code with space In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:37:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:37:20 +0000 Subject: [Koha-bugs] [Bug 11707] Additional attributes broken for category code with space In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11707 --- Comment #5 from Jonathan Druart --- (In reply to Kyle M Hall from comment #4) > I agree with Katrin's comment. Perhaps it would be better to fix this by > adding a check to the attribute creator to stop a librarian from creating an > attribute with a space in the value, and perhaps some of Joy's other > recommendations. I agree too, but what about existing ones? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:45:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:45:17 +0000 Subject: [Koha-bugs] [Bug 11471] Basket groups display 0 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11471 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25388|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 25532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25532&action=edit Bug 11471: Display the currency for baskets in a basketgroup On editing a basketgroup, the currency for baskets in a basketgroup is always '0'. With this patch, the currency is correctly displayed. TEST PLAN ========= 1) Log into staff client 2) Acquisitions 3) Click 'Search' in the 'Manage orders' box 4) Click '+ New basket' because a vendor name 5) Type 'Test Basket' into basket name 6) Click 'Save' 7) Click 'Add to basket' 8) Click 'From an external source' 9) Type 'Green Eggs and Ham' into the Title text box 10) Click 'Search' 11) Click 'Order' on any one of the results 12) Click 'Add Item' in the 'Item' box 13) Select a Fund from the dropdown in the 'Accounting details' box 14) Click 'Save' 15) Click 'Close the basket' 16) Click 'Yes, close (Y)' without checking attach to a basket group 17) Click the 'Basket groups' tab 18) Click '+ New basket group' 19) Notice the listing in the 'Ungrouped baskets'. 20) Drag and drop the entry into the 'Baskets in this group' text area 21) Click 'Save' 22) Click 'Edit' 23) Notice it displays incorrectly. (e.g. Total: 0 0) 24) Apply the patch (git bz apply 11471) 25) Refresh the page 26) Notice it displays the currency correctly. (e.g. Total: 0 USD) NOTE: If there is a space issue, see Bug 9654. This can be applied separately from that bug. 27) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1) Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:45:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:45:39 +0000 Subject: [Koha-bugs] [Bug 11471] Basket groups display 0 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11471 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:46:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:46:44 +0000 Subject: [Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25392|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 25533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25533&action=edit Bug 11562: sysprefs.sql is not correctly sorted. The QA tools does not manage to catch error sorting on the sysprefs.sql file if it is already bad sorted. This patch tidies up the sysprefs file. TEST PLAN --------- 0) Back up your system preferences table. 1) check out master 2) Use your koha database, and then: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql 3) suspend your mysql client and type something similar to: mysql -u root -p -e 'USE kohadata;SELECT * from systempreferences ORDER BY Variable;' > ~/master_sysprefs 4) apply the patch 5) foreground your mysql client, and then: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql 6) suspend your mysql client and type something similar to: mysql -u root -p -e 'USE kohadata;SELECT * from systempreferences ORDER BY Variable;' > ~/11562_sysprefs 7) foreground your mysql client and quit 8) Take a diff, they should be identical diff ~/master_sysprefs ~/11562_sysprefs NOTE: You can't use your own system preferences values, because upgrades and changed values would require a lot of time to compare the results. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:46:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:46:52 +0000 Subject: [Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:49:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:49:43 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 --- Comment #4 from Jonathan Druart --- (In reply to Kyle M Hall from comment #3) > Jonathan, I wonder if it would be best to define the list of statuses in a > package constant in C4::Serials, and to replace all the references to the > array of statuses with this constant to make future additions simpler. Kyle, Yes of course, it is a good idea. But this one is major. I think that your suggestion is an enhancement, not a bugfix. I tried to fix the issue by making as few changes as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:52:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:52:45 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 --- Comment #5 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > (In reply to Kyle M Hall from comment #3) > > Jonathan, I wonder if it would be best to define the list of statuses in a > > package constant in C4::Serials, and to replace all the references to the > > array of statuses with this constant to make future additions simpler. > > Kyle, > Yes of course, it is a good idea. But this one is major. I think that your > suggestion is an enhancement, not a bugfix. > I tried to fix the issue by making as few changes as possible. Understood. I would still consider that a bug fix rather than an enhancement though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:53:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:53:25 +0000 Subject: [Koha-bugs] [Bug 11256] Set a number of items to display on a biblio detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25401|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 25534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25534&action=edit Bug 11256: Opac: Set a number of items to display on a biblio detail page. Currently, the number of items to display is hardcoded (50). But the perl script loads all items before to check if the number of items is oversized. This patch adds a new pref OpacMaxItemsToDisplay (default to 50). If the *total* number of items for a biblio is greater, no item is displayed and a link allows to display all items. Test plan: 1/ search a biblio with many items 2/ set the pref according the number of items you want to display 3/ verify the items are not displayed if the number of items is greater the pref value 4/ enable the OpacSeparateHoldings pref and verify the items are displayed in different tabs (if items have different locations). Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:53:30 +0000 Subject: [Koha-bugs] [Bug 11256] Set a number of items to display on a biblio detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25402|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 25535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25535&action=edit Bug 11256: Opac: Set a number of items to display on a biblio detail page - bootstrap This patch adds the changes for the bootstrap theme. See test plan in the previous patch. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:53:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:53:40 +0000 Subject: [Koha-bugs] [Bug 11256] Set a number of items to display on a biblio detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:54:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:54:47 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 --- Comment #6 from Kyle M Hall --- > Understood. I would still consider that a bug fix rather than an enhancement > though. Ignore this, I was thinking of the wrong bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:59:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:59:27 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25011|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 25536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25536&action=edit Bug 11671 - Restructure patron lists add form for improved usability Non-standard interface features have the potential to cause confusion. This patch brings various aspects of the patron lists add page into conformity with other staff client pages. - Add "select all/clear all" links for the checkboxes - Add a "remove selected" to the top of the table (see also Lists) - Split functionality of add from from delete form - Hide "Add patrons" button until at least one patron has been selected - Remove non-standard trash can icon from table's checkbox column - Exclude checkbox column from table sorting - Add confirmation to deletion actions - Improve breadcrumb specificity - Add title-string sorting to date column to accommodate sorting for all date format types To test, apply the patch and create a patron list. 1. Search for and select patrons for the list. Selecting a patron should trigger the display of an "Add patrons" button. 2. Click "Add patrons" and confirm that the add process completes correctly. 3. Search for and select a patron and also check the box next to an existing patron. Click "Add patrons" and confirm that no patron is removed. 4. Check that the "select all" and "clear all" links work correctly. 5. Select patrons on the list and click the "Remove selected" link. You should be prompted to confirm your choice. 4.a. Click cancel and confirm that the deletion process aborts. 4.b. Click OK and confirm that the deletion process completes. 6. Repeat step 4 with the "Remove selected patrons" at the bottom of the page. 7. Confirm that the page title and breadcrumbs correctly show the list name. 8. Switch between us and metric dateformat settings and confirm that table sorting by date is correct in both cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:59:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 13:59:44 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 --- Comment #6 from Owen Leonard --- Rebased on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:15:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:15:30 +0000 Subject: [Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:20:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:20:23 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 --- Comment #7 from Kyle M Hall --- Created attachment 25537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25537&action=edit Bug 11689 [QA Followup] - Use constants to describe statuses Make the code a bit more understandable by using constants to define the status values and reference those. Adds self-documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:22:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:22:13 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25537|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 25538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25538&action=edit Bug 11689 [QA Followup] - Use constants to describe statuses Make the code a bit more understandable by using constants to define the status values and reference those. Adds self-documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:23:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:23:44 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:26:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:26:33 +0000 Subject: [Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:26:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:26:35 +0000 Subject: [Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 --- Comment #1 from Owen Leonard --- Created attachment 25539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25539&action=edit Bug 10751 - Title should be mandatory for creating suggestions in staff The form for adding a new purchase suggestion in the staff client indicates that the title field is required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Acquisitions -> Suggestions -> New purchase suggestion. Try submitting the form without entering a title. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing suggestion should also work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:34:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:34:24 +0000 Subject: [Koha-bugs] [Bug 11812] New: Add missing "required" indicator to fields which are required Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Bug ID: 11812 Summary: Add missing "required" indicator to fields which are required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Some form fields are configured to be required but lack the "required" note next to them. Since the red label color may not be immediately understood to indicate that a field is required the "required" text should be present too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:36:27 +0000 Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised Values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:36:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:36:29 +0000 Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised Values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25212|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 25540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25540&action=edit Bug 7372: Move road types from the roadtype table to the ROADTYPE AV Currently road types are stored in a specific table in DB. Moreover, an admin page is present in order to manage them. This patch proposes to remove this table and this page in favour of a new authorised value category 'ROADTYPE'. This patch: - adds a new AV category 'ROADTYPE' (created from the roadtype table content). - remove the roadtype table. - remove the .pl and .tt file admin/roadtype - remove the 2 routines C4::Members::GetRoadTypes and C4::Members::GetRoadTypeDetails Test plan: 1/ Execute the updatedatabase entry and verify existing roadtypes are now stored in the AV 'ROADTYPE'. 2/ Verify you can add/update a streettype for patrons. 3/ Verify on following pages the streettype is displayed in patron information (top left): circ/circulation.pl members/memberentry.pl members/moremember.pl members/routing-lists.pl Signed-off-by: Sophie Meynieux Signed-off-by: Kyle M Hall Passes koha-qa.pl, t and xt. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:38:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:38:23 +0000 Subject: [Koha-bugs] [Bug 11813] New: Send 'Opac self registration verification' email from branch address if possible Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11813 Bug ID: 11813 Summary: Send 'Opac self registration verification' email from branch address if possible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When EmailSelfRegistration is activated and verification is required, the email sent to activate the account is sent from the kohaadminemailaddress instead of the branch address. When a branch is set by the patron in the registration form, the mail should be sent from the branch email address instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:39:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 14:39:16 +0000 Subject: [Koha-bugs] [Bug 11813] Send 'Opac self registration verification' email from branch address if possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11813 --- Comment #1 from Katrin Fischer --- ... and ideally in that case also the branch specific notice template would be used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:01:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:01:31 +0000 Subject: [Koha-bugs] [Bug 11814] New: Serial statuses should be stored in constants Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Bug ID: 11814 Summary: Serial statuses should be stored in constants Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org See bug 11689 comment 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:01:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:01:54 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11689 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:01:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:01:54 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11814 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:03:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:03:08 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25538|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Comment on attachment 25538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25538 Bug 11689 [QA Followup] - Use constants to describe statuses In agreement with Kyle, I move this patch to another report, see bug 11814. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:03:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:03:40 +0000 Subject: [Koha-bugs] [Bug 11689] New missing statuses is not well managed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Jonathan Druart --- And switch this one back in the need QA queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:08:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:08:50 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:08:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:08:54 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #1 from Jonathan Druart --- Created attachment 25541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25541&action=edit Bug 11814 - Use constants to describe statuses Make the code a bit more understandable by using constants to define the status values and reference those. Adds self-documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:09:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:09:05 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #2 from Jonathan Druart --- Created attachment 25542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25542&action=edit Bug 11814 - (follow-up) Use constants to describe statuses This patch deals with all hard-coded status codes in the C4::Serials module. Test plan: Test a complete workflow in the serial module (create, order, receive, generate next) trying to use all statuses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:09:08 +0000 Subject: [Koha-bugs] [Bug 11812] Add missing "required" indicator to fields which are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:09:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2014 15:09:11 +0000 Subject: [Koha-bugs] [Bug 11812] Add missing "required" indicator to fields which are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 --- Comment #1 from Owen Leonard --- Created attachment 25543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25543&action=edit Bug 11812 - Add missing "required" indicator to fields which are required Form fields in the staff client which are required should be configured to be so by doing several things: - Add a class "required" to the field's