From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:23:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 00:23:44 +0000
Subject: [Koha-bugs] [Bug 11659] New: Log Viewer does not parse export files
correctly
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11659
Bug ID: 11659
Summary: Log Viewer does not parse export files correctly
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Transaction logs
Assignee: koha-bugs at lists.koha-community.org
Reporter: costalc at gmail.com
QA Contact: testopia at bugs.koha-community.org
Created attachment 24966
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24966&action=edit
Log Viewer's export file sample
When trying to export log viewer's data the does not parse data correctly,
neither TAB nor CSV format. It seems to export as MARC record format.
See file attached. "Delimiter" syspreference option is set to "tab"
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:24:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 00:24:16 +0000
Subject: [Koha-bugs] [Bug 11659] Log Viewer does not parse export files
correctly
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11659
bondiurbano changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:28:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 00:28:04 +0000
Subject: [Koha-bugs] [Bug 11659] Log Viewer does not parse export files
correctly
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11659
bondiurbano changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |3.14
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 04:32:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 03:32:31 +0000
Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to
update template translations
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 04:32:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 03:32:35 +0000
Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to
update template translations
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24096|0 |1
is obsolete| |
--- Comment #6 from Chris Cormack ---
Created attachment 24972
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24972&action=edit
Bug 10942: Provide a way for package upgrades to update template translations
This patch adds a new config variable AUTOMATIC_TRANSLATIONS_UPDATE at
/etc/default/koha-common that is used to control whether the upgrade
process should trigger a
$ koha-translate --update
command for each installed template translation language.
To test:
- Have a koha-common setup with some languages installed
(e.g. koha-translate --install es-ES)
- Apply the patch and build a package for it.
- Install it.
- A new AUTOMATIC_TRANSLATIONS_UPDATE config variable should be in place
at /etc/default/koha-common
- Set AUTOMATIC_TRANSLATIONS_UPDATE to 'yes'
- Re-install the package to trigger the post-install script
- Verify that translations get updated.
Edit: added a warning message for the case AUTOMATIC_TRANSLATIONS_UPDATE=no
and there are translations installed (so they need to get updated).
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack
Works as advertised, default behaviour doesn't change.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 04:36:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 03:36:15 +0000
Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 04:36:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 03:36:18 +0000
Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24965|0 |1
is obsolete| |
--- Comment #2 from Chris Cormack ---
Created attachment 24973
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24973&action=edit
Bug 11655: koha-translate --list shouldn't show 'en'
'en' is not a translation and it doesn't make any sense to return it as part of
the installed translations or the available ones.
It becomes relevant to remove it as users upgrading their installed
translations end up grepping the output to remove 'en' like in:
for lang in $(koha-translate --list | grep -v -x -e 'en') ; do
koha-translate --update $lang
done
instead of simply issuing the koha-translate --list command.
To test:
- Run
./koha-translate --list
./koha-translate --list --available
=> It shouldn't return 'en' in the result list.
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 09:47:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 08:47:39 +0000
Subject: [Koha-bugs] [Bug 11663] New: Bootstap theme opac holding tab
improperly displayed when opacbookbag syspref is disabled
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663
Bug ID: 11663
Summary: Bootstap theme opac holding tab improperly displayed
when opacbookbag syspref is disabled
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: frederic at tamil.fr
QA Contact: testopia at bugs.koha-community.org
Bootstap theme opac holding tab is improperly displayed when opacbookbag
syspref is disabled, and virtualshelf is enabled. This is due to the fact that
in this situation basket.js is loaded (for virtual shelves), but some JS
variable are not defined in template since opacbookbag is disabled.
To reproduce this bug:
- Choose bootstrap OPAC theme
- Enable virtualsheves syspref
- Disable opacbookbag syspref
- Open a biblio record in OPAC detail page
- You will observe that items holding tabs are not displayed as tabs but
as a buletted list
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 09:53:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 08:53:56 +0000
Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly
displayed when opacbookbag syspref is disabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663
Fr?d?ric Demians changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Assignee|oleonard at myacpl.org |frederic at tamil.fr
--- Comment #1 from Fr?d?ric Demians ---
Created attachment 24974
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24974&action=edit
Proposed patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:38:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 20:38:14 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
biblios
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:38:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 20:38:18 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
biblios
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24950|0 |1
is obsolete| |
--- Comment #2 from Chris Cormack ---
Created attachment 24977
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24977&action=edit
Bug 11652: merging authority records does not correct biblios
When merging authority records in librarian interface biblio records
linked to deleted authority are not being corrected (i.e. have still
old heading and orpaned link in $9).
Test plan:
1. Have two authorities in the catalogue, linked to biblio records.
2. Merge them with the new merge facility (cf. Bug 5202).
3. Have a look a the biblio record(s) previously linked to the removed
authority. It should still have the old heading AND orpaned authority
link in $9.
4. Apply the patch.
5. Refresh the test records (or use another set).
6. Repeat 1-3. Headings should be refreshed and the correct authid link
should be in $9 now.
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:03:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 21:03:59 +0000
Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly
displayed when opacbookbag syspref is disabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:04:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 21:04:03 +0000
Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly
displayed when opacbookbag syspref is disabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24974|0 |1
is obsolete| |
--- Comment #2 from Chris Cormack ---
Created attachment 24978
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24978&action=edit
Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag
syspref is disabled
Bootstap theme opac holding tab is improperly displayed when opacbookbag
syspref is disabled, and virtualshelf is enabled. This is due to the fact that
in this situation basket.js is loaded (for virtual shelves), but some JS
variables are not defined in template since opacbookbag is disabled.
To reproduce this bug:
- Choose bootstrap OPAC theme
- Enable virtualsheves syspref
- Disable opacbookbag syspref
- Open a biblio record in OPAC detail page
- You will observe that items holding tabs are not displayed as tabs but
as a buletted list
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:07:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 21:07:33 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #4 from Chris Cormack ---
Easy patches to sign off on, does everyone agree about the change in
terminology?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:12:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 21:12:06 +0000
Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials
needs user login
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:12:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2014 21:12:10 +0000
Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials
needs user login
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24933|0 |1
is obsolete| |
--- Comment #2 from Chris Cormack ---
Created attachment 24979
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24979&action=edit
Bug 11647 : Subscription for email notification on serials asks for login
before proceeding
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 04:52:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 03:52:12 +0000
Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should
not allow permanent destruction of patron data
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
CC| |chris at bigballofwax.co.nz
--- Comment #2 from Chris Cormack ---
Records and items aren't interesting to the FBI in the same way patron data is.
I can see that as a valid reason for deleting them completely.
Perhaps a better response is to do a "Are you sure you want to delete
permanently .. there is no way to get them back?"
Confirmation prompt is a better way than disabling this.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 10:58:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 09:58:08 +0000
Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should
not allow permanent destruction of patron data
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
I agree with Chris - there are good reasons to offer a way to permanently
delete patron information from the interface. Maybe we should also have a way
to clean the deleted_borrowers table regularly on some conditions or at least
delete the personal information in those records anonymizing them.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 11:32:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 10:32:04 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
accented Latin characters
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054
giuseppe.angilella at ct.infn.it changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giuseppe.angilella at ct.infn.
| |it
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 11:59:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 10:59:11 +0000
Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your
summary tabs
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
I think "Waiting" should appear as a separate tab according to the test plan,
but this is not working for me before AND after appyling the patch. The waiting
holds always appear on the "Holds" tab. As I can't detect a regression, I am
going to pass this. David, could you maybe take a look why that doesn't work?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:01:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 11:01:16 +0000
Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your
summary tabs
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:01:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 11:01:19 +0000
Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your
summary tabs
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24951|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 24981
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24981&action=edit
[PASSED QA] Bug 11465 - Show counts and amounts on OPAC your summary tabs
This patch adds counts and amounts to the tabs in the 'your summary'
page of the OPAC patron account.
_TEST PLAN_
Before applying:
1) Choose a test patron
2) Place a few holds
3) Check in one of the holds so that it is waiting for the patron
4) Check out a few items
5) Check out another item that can generate fines (backdate it a few
weeks/months)
6) Run fines.pl to generate fines (make sure your finesmode syspref is set to
prod)
7) Check your OPAC patron account.
8) Note the tabs "Checked out, Fines, Holds, and Waiting"
Apply the patch
1) Switch your OPAC to the bootstrap theme
2) Refresh your browser for the OPAC patron account screen
3) Note that the applicable counts and amounts appear on the tabs
--
At the moment, I just have a Bootstrap patch. This is an easy patch though, so
I can duplicate to the other themes if necessary...
Signed-off-by: Nicole C. Engard
All tests on bootstrap pass
Signed-off-by: Nicole C. Engard
Signed-off-by: Katrin Fischer
All tests and QA script pass.
"Waiting" doesn't appear to work for me with and without the patch.
"Checkouts", "Holds" and "Fines" work fine.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:13:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 11:13:24 +0000
Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials
needs user login
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
Hm, there is something that seems not quite right:
1) Searched for a subscription with patron notification active
2) Logged out of the OPAC
3) Subscribed to the patron notification - it showed the "subscribe" link
4) Logged out of the OPAC again
5) Subscription now always shows "cancel subscription", even when I open
the page in another browser
6) Logging in with another user account, who hasn't subscribed the alert yet,
I am still asked to unsubscribe instead of subscribing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:22:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 11:22:30 +0000
Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly
displayed when opacbookbag syspref is disabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:22:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 11:22:33 +0000
Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly
displayed when opacbookbag syspref is disabled
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24978|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 24982
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24982&action=edit
[PASSED QA] Bug 11663: Bootstap opac holding tab improperly displayed when
opacbookbag syspref is disabled
Bootstap theme opac holding tab is improperly displayed when opacbookbag
syspref is disabled, and virtualshelf is enabled. This is due to the fact that
in this situation basket.js is loaded (for virtual shelves), but some JS
variables are not defined in template since opacbookbag is disabled.
To reproduce this bug:
- Choose bootstrap OPAC theme
- Enable virtualsheves syspref
- Disable opacbookbag syspref
- Open a biblio record in OPAC detail page
- You will observe that items holding tabs are not displayed as tabs but
as a buletted list
Signed-off-by: Chris Cormack
Signed-off-by: Katrin Fischer
Passes QA script and all tests.
Confirmed display problem exists without the patch and is solved by it.
Ideally we would avoid having the cart messages in the template when
the feature is deactivated, but this is ok for now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:46:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 11:46:27 +0000
Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes
more than warning states it will delete
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abl at biblos.pk.edu.pl
--- Comment #5 from Jacek Ablewicz ---
(In reply to Chris Cormack from comment #1)
> Is it deleting ones it shouldn't?
Yes; I can replicate this as well. It will delete (or move to trash) ones it
shouldn't.
Evidently there is a problem with how given parameter borrower_dateexpiry is
(not) being properly converted when passed from step2 to step3 in
tools/cleanborrowers.pl - somehow this parameter value gets mangled in the
process.
In step2 this script does:
$filterdate1 = format_date_in_iso( $params->{'filterdate1'} );
$filterdate2 = format_date_in_iso( $params->{'filterdate2'} );
$borrower_dateexpiry = format_date_in_iso( $params->{'borrower_dateexpiry'} );
...
$template->param(
filterdate1 => format_date($filterdate1),
filterdate2 => format_date($filterdate2),
borrower_dateexpiry => $borrower_dateexpiry,
Note there is no format_date() call on $borrower_dateexpiry in line #100..
Changing line 100 to
borrower_dateexpiry => format_date($borrower_dateexpiry),
seems to fix this issue (at least for me). But: my comprehension of date
handling in Koha is very far from perfect; I can't really guarantee this would
be a proper fix.
I guess the exact outcome may also depend on 'dateformat' setting in I18N/L10N
preferences (we use dd/mm/yyyy; for yyyy-mm-dd unpatched script may actually
work seemingly fine!).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 12:49:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 11:49:05 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
biblios
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
Janusz, I am working on this - could you check if merging 2 records from
different frameworks works ok for you? I tried merging one "default" and
"personal name" but the merge screen comes up empty?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:17:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 12:17:55 +0000
Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should
not allow permanent destruction of patron data
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abl at biblos.pk.edu.pl
--- Comment #4 from Jacek Ablewicz ---
Additionally, in EU countries - ability to permanently remove patron personal
data from computer systems may be actually required by law, as mandated by EU
Data Protection Directive 95/46/EC (to be replaced in 2016 by even more strict
version). Aka: "Right to be Forgotten" (= personal data has to be deleted when
the individual withdraws consent or the data is no longer necessary and there
is no legitimate reason for an organization to keep it).
AFAIK, interpretations, implementations and practical enforcement of this
directive widely varies by country, but still - it will be better to have such
functionality in the system, just to be on the safe side ;).
But I agree it's perhaps too easy to destroy patron data by mistake using this
tool. Maybe "Move these patrons to the trash" should be default option instead
of "Permanently delete these patrons"?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:39:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 12:39:24 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
biblios
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |jcamins at cpbibliography.com
--- Comment #4 from Katrin Fischer ---
I am sorry, but this doesn't seem to work for me. I merged to person authority
records, each linked to 2 records. After the merge, it only shows 2 linked
records, while I think it should be 4. Adding Jared here cc as he is module
maintainer for autorities.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:40:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 12:40:28 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
biblios
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652
--- Comment #5 from Katrin Fischer ---
Aha - wrote the last comment too soon - reindexing fixed it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:41:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 12:41:42 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
biblios
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:41:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 12:41:46 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
biblios
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24977|0 |1
is obsolete| |
--- Comment #6 from Katrin Fischer ---
Created attachment 24983
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24983&action=edit
[PASSED QA] Bug 11652: merging authority records does not correct biblios
When merging authority records in librarian interface biblio records
linked to deleted authority are not being corrected (i.e. have still
old heading and orpaned link in $9).
Test plan:
1. Have two authorities in the catalogue, linked to biblio records.
2. Merge them with the new merge facility (cf. Bug 5202).
3. Have a look a the biblio record(s) previously linked to the removed
authority. It should still have the old heading AND orpaned authority
link in $9.
4. Apply the patch.
5. Refresh the test records (or use another set).
6. Repeat 1-3. Headings should be refreshed and the correct authid link
should be in $9 now.
Signed-off-by: Chris Cormack
Signed-off-by: Katrin Fischer
Passes all tests and QA script.
Note: new record count on the authority record will show
after reindexing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:44:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 12:44:50 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
biblios
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652
--- Comment #7 from Katrin Fischer ---
Another note about comment 3: I think this might have been a data problem,
retested with other records and it worked ok.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 13:54:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 12:54:46 +0000
Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to
amount unallocated
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #4 from Katrin Fischer ---
I am failing to reproduce the problem, here is what I did:
- My budget had 200,00 unallocated
- I created a new fund with 200,00, it saved correctly
- I tried editing the newly created fund, it also saved correctly
Quite sure I am missing something - any hints?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:36:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:36:30 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
and notices & slips
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:36:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:36:33 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
and notices & slips
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24861|0 |1
is obsolete| |
Attachment #24941|0 |1
is obsolete| |
--- Comment #10 from Katrin Fischer ---
Created attachment 24984
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24984&action=edit
[PASSED QA] Bug 11625 - Default to logged in library for circ rules and notices
& slips
This patch makes the default circ rules and notices/slips to edit
the logged in branch, if one is set.
Test Plan:
1) Apply this patch
2) Log into staff side, and set your library
3) Browse to Administration/Circulation and fines rules
4) Note the rule set selected is for your library
5) Select "All libraries"
6) Note the rule set selected is for "All libraries"
7) Browse to Toos/Notices & slips
8) Note the notice set selected is for your library
9) Select "All libraries"
10) Not the rule set selected is for "All libraries"
11) Click "New Notice"
12) Note the Library field is set to "All libraries"
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
Passes QA script and tests.
Small ergonomic improvement, no regressions found.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:36:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:36:55 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
and notices & slips
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625
--- Comment #11 from Katrin Fischer ---
Created attachment 24985
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24985&action=edit
[PASSED QA] Bug 11625 [QA Followup] - Default to logged in library for circ
rules and notices & slips
Signed-off-by: Katrin Fischer
Fixes the case that someone logs in as database user and
changes circulation rules without explicitly selecting a
library first.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:39:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:39:47 +0000
Subject: [Koha-bugs] [Bug 11632] Untranslatable string "Remove" in patron
lists
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11632
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
CC| |katrin.fischer at bsz-bw.de
Resolution|--- |DUPLICATE
--- Comment #1 from Katrin Fischer ---
Marking this duplicate to indicate that bug 11636 includes a fix for this.
*** This bug has been marked as a duplicate of bug 11636 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:39:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:39:47 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
list during add process
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pasi.kallinen at pttk.fi
--- Comment #4 from Katrin Fischer ---
*** Bug 11632 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:51:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:51:26 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
list during add process
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:51:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:51:29 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
list during add process
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24905|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 24986
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24986&action=edit
[PASSED QA] Bug 11636 - Impossible to remove patrons from patron list during
add process
If you patrons have card numbers with leading zeroes this causes
problems removing patron entries during the process of adding patrons to
an existing list. This patch refactors the relevant JavaScript to
correct the problem and to remove inline "onclick" from generated HTML.
This patch also includes a fix for Bug 11632 - Untranslatable string
"Remove" in patron lists.
To test:
1. If necessary, create or modify a patron to have a card number
with leading zeroes.
2. Go to Tools -> Patron lists.
3. Click "Add patrons" on an existing list.
4. Perform a patron search and choose one of the results.
5. Click the "remove" link next to the patron name which was just added.
Nothing will happen.
6. Apply the patch and test again. The "remove" link should now work.
To test the fix for Bug 11632, after applying the patch run "translate
update [language code]" and confirm that the "Remove" string is listed
in the updated po file for patron_lists/list.tt.
Signed-off-by: Kyle M Hall
Signed-off-by: Katrin Fischer
Passes all tests and QA script, works as described.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:57:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:57:25 +0000
Subject: [Koha-bugs] [Bug 11664] New: No way to select all/unselect all on
patron list
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11664
Bug ID: 11664
Summary: No way to select all/unselect all on patron list
Change sponsored?: ---
Product: Koha
Version: 3.14
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: kyle at bywatersolutions.com
On testing another patch I wondered why you can't select/unselect all patrons
in a patron list to remove in batch. I think this would be a useful
enhancement, as this seems to be the point of preferring checkboxes over a
delete link. Also, why name the button "Update" when the purpose seems to
always be deleting?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 14:59:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 13:59:03 +0000
Subject: [Koha-bugs] [Bug 11664] No way to select all/unselect all on patron
list
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11664
--- Comment #1 from Katrin Fischer ---
Hm, also sorting on the checkboxes in the first column doesn't seem to work.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 15:14:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 14:14:08 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |katrin.fischer at bsz-bw.de
--- Comment #15 from Katrin Fischer ---
Hi Mathieu,
one small thing to fix:
- When an order is not in a basket group, it displays empty parenthesis "()"
and
the link does not work. Please add a check.
I also noticed that we display the branchcode instead of the branch name here -
that could be easily fixed now using the TT plugin. If you want to you could
add a follow up, but it can also be a separate bug.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 15:52:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 14:52:21 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |katrin.fischer at bsz-bw.de
--- Comment #9 from Katrin Fischer ---
I have problems in getting the search to work:
Tested with MARC21:
- Applied patch and copied file
- Cataloged record Language-original = 041$h
- Activated QueryParser
- Waited for Zebra to reindex my newly added record
- Searched for the unique content of 041$h as keyword search
> Record was found
- Searched for language-original:<041$h>
> Record was not found
I have no success in using the index explicitly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 15:58:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 14:58:08 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
I am wondering if we really should get rid of the acquisition information when
deleting an item. When an item is deleted, it's moved to deleted_items and can
still be looked up for reporting purposes. It might also be interesting at that
point to find out about the other history of the item, acquisition history
included.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 17:44:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 16:44:04 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 17:44:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 16:44:08 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24119|0 |1
is obsolete| |
Attachment #24593|0 |1
is obsolete| |
Attachment #24736|0 |1
is obsolete| |
--- Comment #24 from Katrin Fischer ---
Created attachment 24987
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24987&action=edit
[PASSED QA] Bug 10851: Serials - Add missing statuses
4 new missing statuses is added by this patch:
never received, sold out, damaged or lost.
These status have the same behavior than the simple Missing status.
Test plan:
- Find a serial to claim.
- Modify the status of this serial with one of these new statuses.
- Try to find it with the "serials to claim" search.
- Verify that the status is displayed on the serial module pages and on
the OPAC.
Signed-off-by: Nicolas Bravais
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 17:44:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 16:44:25 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851
--- Comment #25 from Katrin Fischer ---
Created attachment 24988
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24988&action=edit
[PASSED QA] Bug 10851: FIX QA issues
This patch fixes following warnings:
FAIL C4/Serials.pm
FAIL valid
Useless use of a constant (43) in void context
Useless use of a constant (41) in void context
Useless use of a constant (44) in void context
Useless use of a constant (42) in void context
Useless use of a constant (4) in void context
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 17:44:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 16:44:36 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851
--- Comment #26 from Katrin Fischer ---
Created attachment 24989
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24989&action=edit
[PASSED QA] Bug 10851: (follow-up) FIX bad c/p (variable name)
In catalogue.detail.tt, a wrong variable loop was used.
Signed-off-by: Jonathan Druart
Signed-off-by: Katrin Fischer
APatches pass QA script and tests.
Additional tests done:
- Receiving issues, setting and unsetting new status
- Display on serial summary page
- Display on subscription detail page, issues tab
- Display on OPAC and staff detail pages, subscription tab
OPAC: ok
Staff: ok
- Claiming issues, filtering and status display
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 19:24:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 18:24:43 +0000
Subject: [Koha-bugs] [Bug 11665] New: An ability to place orders directly
from hold ratios list
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665
Bug ID: 11665
Summary: An ability to place orders directly from hold ratios
list
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs at lists.koha-community.org
Reporter: abl at biblos.pk.edu.pl
QA Contact: testopia at bugs.koha-community.org
This enhancement introduces a possibility to place orders
from hold ratios list:
- new option "Add order to basket" -> "From titles w/ highest hold ratios";
(user gets redirected from acqusition to "hold ratios" list in circulation)
- "N to order" in "Items needed" column now becomes a link - when clicked,
user gets redirected back to acquisition, directly to order form for
a choosen title (suggested quantity "N to order" is being preserved)
- in the "Items needed" column, there is an additional indication if
there are any pending (not yet received) orders for a given title
This solution is not exactly ideal.. most important drawback: to use
it librarian needs both acquisition & circulation priviledges; if not
having both - new options will not show / wouldn't be active. But it
requires relatively small amount of changes in the code.
To test:
- apply patch,
- test new functions (try to place some orders using an newly added
option, examine resulting order records etc.)
- check modified hold ratios list for possible problems (for user
with only circulation priviledges, additional information regarding
pending orders should be still visible, but not the link
to order form)
- ensure the two following existing options for adding orders to basket
("From an existing record", "From a new (empty) record") a still working
properly.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 19:36:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 18:36:52 +0000
Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from
hold ratios list
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abl at biblos.pk.edu.pl
Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl
|ity.org |
--- Comment #1 from Jacek Ablewicz ---
Created attachment 24990
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24990&action=edit
Bug 11665: An ability to place orders directly from hold ratios list
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 20:07:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 19:07:18 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #61 from Katrin Fischer ---
Starting with a code review on the squashed patch set:
- Adds 2 new routines:
* GetMessageTransportTypes
* GetOverdueMessageTransportTypes
- Database changes:
* Adds a new table overduerules_transport_types
* Adds a new column to letter - messgage_transport_type, email is default
* Changes the primary key by adding message_transport_type to it:
module code branchcode message_transport_type
* Adds entries to overduerules_transport_types defaulting to email
- New Javascript Library
TODO: Add to the about page?
- TODO: Translatability - I think the message transport types on the overdue
notice triggers page are not translatable:
+ [% FOREACH mtt IN message_transport_types %]
+
[% mtt %]
I will continue testing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 21:24:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 20:24:24 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
race condition during full rebuilds
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078
--- Comment #44 from Doug Kingston ---
(In reply to Katrin Fischer from comment #43)
> I'd love to see this moving forward, but I am not sure how to fully test.
So, this feature adds locking so that basically there can ever only be one
instance of rebuild_zebra.pl running at any given time.
Incremental updates in deamon try to obtain the lock and skip the current cycle
if they cannot get the the lock. Other updates try to get the lock and block
waiting for it to get free if its locked.
Testing should check these behaviors. The flock testing program lets you apply
the lock without having real conflicting updates. You can test using that to
create conflicts or just use to instances of rebuild_zebra.pl as would happen
for real. Using verbose mode you will get messages indicating if lock
contention is detected.
Cases to test:
1) 2 non-daemon invocations of a full rebuild; the second invocation should see
the first has taken the lock and it should block until the first finishes.
2) daemon running and user starts a large full rebuild. Run the daemon mode
incremental updater. Add or modify a record and make sure it gets updated.
Then request a full rebuild while the daemon version is also running. Once the
full rebuild has started, modify a record which will add an incremental update
to the zebraqueue. You should see log messages from the daemon indicating that
it is skipping the current pass as long as the full rebuild is still running.
Does this help?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 22:20:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 21:20:31 +0000
Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the
MARC21 defaults
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathsabypro at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:14:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 22:14:52 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
--- Comment #16 from mathieu saby ---
Created attachment 24991
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24991&action=edit
[PATCH] Bug 11027 (QA) : hide link if no basketgroup and use real branch name
This patch is a answer to remarks made by QA:
- if there is no basketgroup for an order, the basketgroup column in
lastorders.pl is now blank (instead of parentheses)
- the name of the branch is used instead of its code in the branch column
To test: check late orders, included and not included into basketgroup
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:15:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 22:15:04 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:15:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 22:15:51 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
--- Comment #17 from mathieu saby ---
Katrin, I think you should be fine with the last patch.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:32:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 22:32:33 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #43 from mathieu saby ---
I'm not sure of the origin of the conflict. I prefer to investigate a little
more to avoid a mistake.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:49:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 22:49:56 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #44 from mathieu saby ---
In fact the conflict was trivial ;-)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:51:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 22:51:02 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24743|0 |1
is obsolete| |
--- Comment #45 from mathieu saby ---
Created attachment 24992
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24992&action=edit
[PATCH] Bug 10869: Allow the deletion of order line if the record is deleted
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 00:09:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 23:09:01 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathsabypro at gmail.com
--- Comment #4 from mathieu saby ---
(In reply to Katrin Fischer from comment #3)
> I am wondering if we really should get rid of the acquisition information
> when deleting an item. When an item is deleted, it's moved to deleted_items
> and can still be looked up for reporting purposes. It might also be
> interesting at that point to find out about the other history of the item,
> acquisition history included.
Hello
So you think a 'cancelled' status could be used for aqorders_items as well as
for aqorders ?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 00:11:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 23:11:09 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #46 from mathieu saby ---
Marcel, I got a bad result with prove t/db_dependent/Acquisition.t
# Failed test 'DelOrders delete items linked with cancelled order in
aqorders_items table'
# at t/db_dependent/Acquisition.t line 273.
# got: '2'
# expected: '0'
# Looks like you failed 1 test of 67.
t/db_dependent/Acquisition.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/67 subtests
If I understand well, it is because, as you stated in your comment,
aqorders_items is not cleared automaticaly by DelOrder, but will be when Bug
11617 is pushed.
As Bug 11617 is not yet pushed, and Katrin raised an objection to it, I would
prefer to put this one in Discussion, with status 'Blocked by Bug 11617'.
Do you agree with that?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 00:28:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2014 23:28:15 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
947 and 969 fields in french unimarc_complete framework
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #4 from mathieu saby ---
The patch is clean, but to be applied on top of bug 11021
So, please test fist bug 11021.
Both bugs can NOT be tested on a usual sandbox (because you have to check that
the "installer" that fills Koha's database is working properly).
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 03:26:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 02:26:33 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
field through preferences
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951
Alexa changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alexa.gerancho at hushmail.com
--- Comment #43 from Alexa ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen live from the domain http://volichat.com/adult-chat-rooms
Marked for reference. Resolved as fixed @bugzilla.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 04:36:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 03:36:35 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
--- Comment #18 from M. Tompsett ---
Ran a variation on my test plan, and the branch name shows up, and there are no
()'s in the columns now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 04:37:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 03:37:30 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 04:37:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 03:37:34 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24991|0 |1
is obsolete| |
--- Comment #19 from M. Tompsett ---
Created attachment 24993
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24993&action=edit
[SIGNED OFF] Bug 11027 (QA) : hide link if no basketgroup and use real branch
name
This patch is a answer to remarks made by QA:
- if there is no basketgroup for an order, the basketgroup column in
lastorders.pl is now blank (instead of parentheses)
- the name of the branch is used instead of its code in the branch column
To test: check late orders, included and not included into basketgroup
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:44:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 05:44:45 +0000
Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785
in UNIMARC XSLT should be removed in bootstrap theme
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #2 from M. Tompsett ---
The comments on bug 10465 say these fields don't exist in unimarc. That likely
explains why I couldn't find any marcxml with tag="780" in it in my sample
UNIMARC data.
The patch eyeballs exactly like the OPAC portion of the bug 10465 patch for the
prog.
The directions were followed. System preferences were checked: opactheme
(bootstrap), OPACXSLTDetailsDisplay (default), and OPACXSLTResultsDisplay
(default).
And master and patch applied versions both had identical "Normal View" and
"MARC View" pages.
http://www.ifla.org/publications/unimarc-formats-and-related-documentation
Okay, no reference to 78X for biblio stuff.
http://www.ifla.org/files/assets/uca/unimarc-authorities-format.pdf
suggests they are used for authorities.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:47:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 05:47:28 +0000
Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785
in UNIMARC XSLT should be removed in bootstrap theme
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:47:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 05:47:30 +0000
Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785
in UNIMARC XSLT should be removed in bootstrap theme
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22914|0 |1
is obsolete| |
--- Comment #3 from M. Tompsett ---
Created attachment 24994
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24994&action=edit
[SIGNED OFF] Bug 11246 : remove useless reference to fields 780 and 785 in
UNIMARC XSLT files for Bootstrap opac
Another fix, 10465, removed fields 780 and 785 from a unimarc xslt file.
This cleanup is needed for bootstrap too
To test : in a UNIMARC Koha, with Bootstrap theme OPAC
1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay sysprefs are
set to "default"
2. apply the patch
3. search some records in OPAC : the list view and the detail view must be
exacty the same as before you apply the patch.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:54:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 05:54:40 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617
--- Comment #5 from Katrin Fischer ---
Maybe more a 'deleted' status to distinguish between orders being cancelled and
items being deleted because of that and items being deleted from cataloguing?
But this is just a thought, maybe it will make things too complicated and
deleting is what people want?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:59:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 05:59:42 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617
--- Comment #6 from Katrin Fischer ---
Hm, thinking more about it, I think when cancelling an order the items are
deleted and the order is marked as cancelled - do we really need to delete
aqorders_items then? They would still refernece the original items and could be
looked up in deleted_items. When the item is deleted later from cataloguing -
would that currently touch the acquisitions data?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:02:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 06:02:18 +0000
Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from
"Search the catalog"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #2 from M. Tompsett ---
I tried just closing, applying the patch, and clicking the z39.50 search
button. I think caching by the web browser messes it up. You really do need to
run the test plan as given to get it to work.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:04:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 06:04:33 +0000
Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from
"Search the catalog"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24470|0 |1
is obsolete| |
--- Comment #3 from M. Tompsett ---
Created attachment 24995
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24995&action=edit
[SIGNED OFF] Bug 11572 - Keyword searches no longer detect isbn from "Search
the catalog"
In Koha 3.8, if a standard catalog search was performed and the user
clicked the z39.50 search button, the search string would automatically
be placed in the isbn field for the z39.50 search form.
Changes to the code have since broken this functionality.
Test Plan:
1) From mainpage.pl, use "Search the catalog" to search for the string
"9781570672835"
2) Click the Z39.50 Search button
3) Note the string is placed in the title field
4) Apply this patch
5) Repeat steps 1-2
6) Note the string is placed in the isbn field
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:04:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 06:04:30 +0000
Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from
"Search the catalog"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:09:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 06:09:15 +0000
Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and
MARC21 in some sysprefs
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #3 from M. Tompsett ---
I am wondering about NORMARC, RUSMARC, or other MARC variants which are more
closely related to MARC21, but are not exactly MARC21. Is changing the MARC to
MARC21 a good idea?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:10:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 06:10:29 +0000
Subject: [Koha-bugs] [Bug 11667] New: Hardcoded "Unknown" in suggestions
management
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11667
Bug ID: 11667
Summary: Hardcoded "Unknown" in suggestions management
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: frederic at tamil.fr
If the suggestion status is not in SUGGEST_STATUS authorized values, the UI
will show a tab with the untranslatable, hard-coded, text "Unknown":
suggestion/suggestion.pl: return
GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown";
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:45:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 06:45:50 +0000
Subject: [Koha-bugs] [Bug 11434] in late order page only user with
order_manage permission should be allowed to click on basket
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11434
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |RESOLVED
CC| |mtompset at hotmail.com
Resolution|--- |DUPLICATE
--- Comment #2 from M. Tompsett ---
I believe this is a poor duplicate of bug 11027, which has even more
functionality.
*** This bug has been marked as a duplicate of bug 11027 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 07:45:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 06:45:50 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
--- Comment #20 from M. Tompsett ---
*** Bug 11434 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:06:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 07:06:55 +0000
Subject: [Koha-bugs] [Bug 11668] New: Untranslatable "Total" in borrowers
stats report
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668
Bug ID: 11668
Summary: Untranslatable "Total" in borrowers stats report
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: frederic at tamil.fr
When saving borrowers_stats output into CSV, there will be hard-coded,
untranslatable, "Total" and "TOTAL" texts.
reports/borrowers_stats.pl: print "Total\n";
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:16:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 07:16:25 +0000
Subject: [Koha-bugs] [Bug 11668] Untranslatable "Total" in borrowers stats
report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668
--- Comment #1 from paxed ---
It would also be good to have the field names translatable (eg.
"zipcode/branchcode" in the output)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:17:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 07:17:48 +0000
Subject: [Koha-bugs] [Bug 11667] Hardcoded "Unknown" in suggestions
management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11667
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |katrin.fischer at bsz-bw.de
Resolution|--- |DUPLICATE
--- Comment #1 from Katrin Fischer ---
I think this is a duplicate to a bug I filed and tried to solve a while ago -
still have to find time to get back to it or at least split it up for a partial
fix.
*** This bug has been marked as a duplicate of bug 10519 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:17:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 07:17:48 +0000
Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct
display of tab descriptions broken
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pasi.kallinen at pttk.fi
--- Comment #16 from Katrin Fischer ---
*** Bug 11667 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:56:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 07:56:15 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #10 from M. de Rooy ---
(In reply to Katrin Fischer from comment #9)
> I have problems in getting the search to work:
>
> Tested with MARC21:
> - Applied patch and copied file
> - Cataloged record Language-original = 041$h
> - Activated QueryParser
> - Waited for Zebra to reindex my newly added record
> - Searched for the unique content of 041$h as keyword search
> > Record was found
> - Searched for language-original:<041$h>
> > Record was not found
>
> I have no success in using the index explicitly.
Thanks for testing, Katrin.
I have to admit that my test plan should be reworded (see comment 7). Will do
that in a minute. Sorry for any confusion about that..
Note that this report is about fixing the QueryParser config and it is not
about searching on language-original. As long as this specific index is not in
the field set of C4::Search::getIndexes, you will have no results (without
QueryParser). But that is true for many more indexes in record.abs. Just
mentioning a few indexes with the same behavior from the first few control
fields: Microform-generation, Identifier-standard, BNB-card-number, BGF-number,
Number-db, Number-natl-biblio, etc.
So I feel that since this fixes QP, it should not be a reason to fail this
patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:00:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:00:41 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:00:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:00:44 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24752|0 |1
is obsolete| |
--- Comment #11 from M. de Rooy ---
Created attachment 24996
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24996&action=edit
Bug 11619: Duplicate key in QueryParser config
Corrects a double entry for language in yaml file.
Language should have been language-original.
Test plan:
Check that you have language-original in your zebra install.
Specifically, this index should cover MARC21 041$h.
Enable QueryParser and search for a record with this index.
Note that this patch does not enable searching on this
index without QueryParser. This is true for many more indexes
in record.abs that are not included in the getIndexes routine.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:16:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:16:37 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #12 from Katrin Fischer ---
Hi Jonathan, I understand that we have to list the index in Search.pm when not
using the QueryParser. But now I am more confused as to why it didn't work in
my test?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:36:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:36:33 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--- Comment #6 from Jonathan Druart ---
Hello Marcel,
This patch depends on bug 11555 and applies correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:37:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:37:45 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605
--- Comment #7 from M. de Rooy ---
(In reply to Jonathan Druart from comment #6)
> Hello Marcel,
> This patch depends on bug 11555 and applies correctly.
OK Sorry, probably not seen :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:43:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:43:52 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24897|0 |1
is obsolete| |
--- Comment #8 from Jonathan Druart ---
Created attachment 24997
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24997&action=edit
Bug 11605: Fix regression
Bug 11314 overrides the iDisplayLength and aLengthMenu values and should
be kept.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:44:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:44:33 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24997|0 |1
is obsolete| |
--- Comment #9 from Jonathan Druart ---
Created attachment 24998
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24998&action=edit
Bug 11605: default entry is 20 for all tables using datatables
The default entry is 20 and can be apply to all tables.
Bug 11555 apply the menu entries to all tables, redefining it is
uesless and can be removed.
Test plan:
Test pages impacted by this patch and verify there is no regression on
the tables.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:44:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:44:45 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605
--- Comment #10 from Jonathan Druart ---
Created attachment 24999
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24999&action=edit
Bug 11605: Fix regression
Bug 11314 overrides the iDisplayLength and aLengthMenu values and should
be kept.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:49:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:49:09 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #13 from M. de Rooy ---
(In reply to Katrin Fischer from comment #12)
> Hi Jonathan, I understand that we have to list the index in Search.pm when
> not using the QueryParser. But now I am more confused as to why it didn't
> work in my test?
Katrin,
I retested. If I enable QP and search on the index, I find the record with the
search term in 041$h.
If I disable QP, I do not find it.
So please retest.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:53:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:53:14 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #14 from Katrin Fischer ---
Can you add the search term/query you used?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:54:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:54:50 +0000
Subject: [Koha-bugs] [Bug 7910] Batch renewal of serials and order creation
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910
Amit changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |ASSIGNED
CC| |amitddng135 at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:55:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:55:17 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #15 from M. de Rooy ---
(In reply to Katrin Fischer from comment #14)
> Can you add the search term/query you used?
I just simply added dut in 041$h and search for language-original: dut
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:57:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 08:57:43 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #16 from Katrin Fischer ---
Hm weird, I will retest. Jonathan, did you make any changes to the new patch?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:05:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 09:05:37 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #17 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #16)
> Hm weird, I will retest. Jonathan, did you make any changes to the new patch?
No, I always mention when I amend a patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:09:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 09:09:21 +0000
Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders,
suggestions and catalog
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813
Amit changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |ASSIGNED
CC| |amitddng135 at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:09:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 09:09:41 +0000
Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders,
suggestions and catalog
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813
Amit changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|kohapatch at gmail.com |amitddng135 at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:39:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 09:39:27 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
invoice page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abl at biblos.pk.edu.pl
--- Comment #12 from Jacek Ablewicz ---
(In reply to mathieu saby from comment #11)
> It is not working well, and most of all, improving the display of rrp and
> ecost price on invoices is maybe a loss of time.
>
Mathieu, are you sure your last test was with the patches correctly applied?
>From what I see, patched version is calculating & displaying unitcost (aka
actual cost) on invoice page, just like it should - and there is an clear
indication stating if given column is with, or without tax.
We are currently testing those patches; so far with the good results
for listincgst/invoiceincgst both yes/yes && no/no.
Less usual combinations (no/yes, yes/no) might be a different story - I believe
invoice.pl may need an additional small change like that:
185c185
> if ( $bookseller->{'invoiceincgst'} ) {
---
< if ( $bookseller->{'listincgst'} ) {
to behave properly for "no/yes" and "yes/no" (???).
Anyway, handling prices for yes/no and no/yes combinations are apparently even
more problematic in other places (like parcel.pl, basket.pl, .. - price
calculations/display/column labeling etc. are not always working correctly in
those other scripts - depending on the circumstances). I'm wondering if anyone
is actually using such unusual combinations IRL?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:49:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 09:49:11 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |In Discussion
--- Comment #7 from M. de Rooy ---
(In reply to Katrin Fischer from comment #3)
> I am wondering if we really should get rid of the acquisition information
> when deleting an item. When an item is deleted, it's moved to deleted_items
> and can still be looked up for reporting purposes. It might also be
> interesting at that point to find out about the other history of the item,
> acquisition history included.
Thanks for bringing that up, Katrin.
In the current codebase deleteditems is actually only used in tools/export.pl.
So like you mentioned, someone should use this connection in reporting. Note
that this is (somewhat) theoretical, but possible.
Koha currently removes the biblionumber from aqorders when a biblio is deleted
(talking about removing acquisition history..) Does that make keeping the
itemnumber in aqorders_items inconsistent? Or do we now stumble over the last
way to retrieve the biblionumber still, via this itemnumber :)
Also note that this discussion is in the scope of the AcqCreateItem pref. If
you set that to Cataloging, you will have no itemnumbers at all in
aqorders_items. That makes it a special table in the first place. The use of
this table is more or less only relevant during the acquisition stage and no
longer after ordering and receiving.
With that in mind, I have a slight preference for cleaning up this table if an
item is deleted. I will send a mail to the dev list and ask for some feedback.
Setting to In Discussion.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:09:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:09:48 +0000
Subject: [Koha-bugs] [Bug 11665] An ability to place orders directly from
hold ratios list
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Medium patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:23:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:23:30 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617
--- Comment #8 from Katrin Fischer ---
I disagree with the assumption that the table is no longer interesting after
the acquisition process is completed. The items tab where we added more and
more information about acq is an example that libraries want to have these kind
of information clearly visible. I also would say that an acquisiton process
without items might be some kind of exception, but not the general rule right
now. On the contrary I woudl argue that we should not remove the biblionumber
on cancelling an order, as I can see no reason why this would be necessary.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:29:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:29:58 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617
--- Comment #9 from M. de Rooy ---
(In reply to Katrin Fischer from comment #8)
> On the contrary I woudl argue that we should not remove the
> biblionumber on cancelling an order, as I can see no reason why this would
> be necessary.
If we keep the itemnumber, we should certainly keep the biblionumber too.
Rather see a title (marked as deleted) instead of Deleted bibliographic notice,
can't find title.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:31:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:31:36 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24744|0 |1
is obsolete| |
--- Comment #47 from M. de Rooy ---
Created attachment 25000
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25000&action=edit
Bug 10869 Followup: Unit tests for DelOrder
DelOrder now returns undef if no ordernumber passed.
This patch also adds unit tests for DelOrder.
Test plan:
A. With syspref AcqCreateItem = on placing an order
1. Fill a basket with some orders (some records with already existing items or
holds, some without items). New items linked with the order will be created
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders, and check the deletion of the
order implies the deletion of items created when ordering
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.
7. Add some other orders to your basket (some records with already existing
items or holds, some without items). New items linked with the order will be
created
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.
B. With syspref AcqCreateItem = on receiving an order
1. Fill a basket with some orders (some records with already existing items or
holds, some without items).
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
7. Add some other orders to your basket (some records with already existing
items or holds, some without items).
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
And to test the UT: prove t/db_dependent/Acquisition.t
Signed-off-by: Marcel de Rooy
Amended the patch as to removing biblio parameter in DelOrder.
There is no need to remove the parameter if you will search for
biblionumber later on.
I also suggest to handle the deletes in aqorders_items via constraint.
Added a followup on report 11617 for that purpose.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:32:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:32:19 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #48 from M. de Rooy ---
Follow-up resubmitted to restore patch order. Will still answer previous
comment.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:40:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:40:27 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25000|0 |1
is obsolete| |
--- Comment #49 from M. de Rooy ---
Created attachment 25001
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25001&action=edit
Bug 10869 Followup: Unit tests for DelOrder
DelOrder now returns undef if no ordernumber passed.
This patch also adds unit tests for DelOrder.
Test plan:
A. With syspref AcqCreateItem = on placing an order
1. Fill a basket with some orders (some records with already existing items or
holds, some without items). New items linked with the order will be created
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders, and check the deletion of the
order implies the deletion of items created when ordering
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.
7. Add some other orders to your basket (some records with already existing
items or holds, some without items). New items linked with the order will be
created
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.
B. With syspref AcqCreateItem = on receiving an order
1. Fill a basket with some orders (some records with already existing items or
holds, some without items).
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
7. Add some other orders to your basket (some records with already existing
items or holds, some without items).
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
And to test the UT: prove t/db_dependent/Acquisition.t
Signed-off-by: Marcel de Rooy
Amended the patch as to removing biblio parameter in DelOrder.
There is no need to remove the parameter if you will search for
biblionumber later on.
Deleting records in aqorders_items is discussed on bug 11617.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:40:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:40:56 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #50 from M. de Rooy ---
Updated the commit message of the second patch too.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:49:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:49:39 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25001|0 |1
is obsolete| |
--- Comment #51 from M. de Rooy ---
Created attachment 25002
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25002&action=edit
Bug 10869 Followup: Unit tests for DelOrder
DelOrder now returns undef if no ordernumber passed.
This patch also adds unit tests for DelOrder.
Test plan:
A. With syspref AcqCreateItem = on placing an order
1. Fill a basket with some orders (some records with already existing items or
holds, some without items). New items linked with the order will be created
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders, and check the deletion of the
order implies the deletion of items created when ordering
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.
7. Add some other orders to your basket (some records with already existing
items or holds, some without items). New items linked with the order will be
created
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.
B. With syspref AcqCreateItem = on receiving an order
1. Fill a basket with some orders (some records with already existing items or
holds, some without items).
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
7. Add some other orders to your basket (some records with already existing
items or holds, some without items).
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
And to test the UT: prove t/db_dependent/Acquisition.t
Signed-off-by: Marcel de Rooy
Amended the patch as to removing biblio parameter in DelOrder.
There is no need to remove the parameter if you will search for
biblionumber later on.
Deleting records in aqorders_items is discussed on bug 11617.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:55:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:55:05 +0000
Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:56:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 10:56:33 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25002|0 |1
is obsolete| |
--- Comment #52 from M. de Rooy ---
Created attachment 25003
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25003&action=edit
Bug 10869 Followup: Unit tests for DelOrder
DelOrder now returns undef if no ordernumber passed.
This patch also adds unit tests for DelOrder.
Test plan:
A. With syspref AcqCreateItem = on placing an order
1. Fill a basket with some orders (some records with already existing items or
holds, some without items). New items linked with the order will be created
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders, and check the deletion of the
order implies the deletion of items created when ordering
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.
7. Add some other orders to your basket (some records with already existing
items or holds, some without items). New items linked with the order will be
created
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.
B. With syspref AcqCreateItem = on receiving an order
1. Fill a basket with some orders (some records with already existing items or
holds, some without items).
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
7. Add some other orders to your basket (some records with already existing
items or holds, some without items).
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
And to test the UT: prove t/db_dependent/Acquisition.t
Signed-off-by: Marcel de Rooy
Amended the patch as to removing biblio parameter in DelOrder.
There is no need to remove the parameter if you will search for
biblionumber later on.
Deleting records in aqorders_items is discussed on bug 11617.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:10:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 11:10:27 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
--- Comment #53 from M. de Rooy ---
(In reply to mathieu saby from comment #46)
> If I understand well, it is because, as you stated in your comment,
> aqorders_items is not cleared automaticaly by DelOrder, but will be when Bug
> 11617 is pushed.
Yes. For now I removed this one test from your patch. It still checks in items,
no longer in aqorders_items. Note that if there would be a cascaded delete, I
think we should not have to check MySQL functionality either. So the test is no
longer needed.
> As Bug 11617 is not yet pushed, and Katrin raised an objection to it, I
> would prefer to put this one in Discussion, with status 'Blocked by Bug
> 11617'.
Strictly speaking, they can be handled independently now.
But the discussion on bug 11617 made me think somewhat more about it.
If the user wants to delete an order, it is actually obvious that he wants to
delete records in aqorders_items too. You did in the former version (and I
moved it to another report :) But in the meantime we are now only deleting the
real item records here. And the question is: Did the user understand that, and
should he have the possibility to not remove the items (so only the order and
aqorders_items)? Should we add two options: Delete order / Delete order and
items. Note that Delete order and catalog record (or biblio) should obviously
include items. BTW Would biblio record be a better description than catalog
record in the second [or third] option? You can also misread it as follows now:
First delete the order and then catalog [read: edit] the record. When you say
biblio record, it is a noun and no verb.
Sorry for all these comments.. ;)
Setting to In Discussion, as you suggested.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:16:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 11:16:39 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #54 from M. de Rooy ---
The questions on order level actually pertain to basket level also. If we
delete a basket, we do warn the user that he will lose his items. But he does
not have a choice between "Delete basket and orders" and "Delete baskets,
orders and items".
Is this getting too complicated now?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:35:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 11:35:34 +0000
Subject: [Koha-bugs] [Bug 11669] New: Allow setting 008 builder MARC
country/language code URLs
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11669
Bug ID: 11669
Summary: Allow setting 008 builder MARC country/language code
URLs
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: frederic at tamil.fr
The MARC21 008 builder has URLs that point to loc.gov - lists of country and
languages codes. The URLs should be configurable, as the loc.gov lists are only
in English.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:36:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 11:36:29 +0000
Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers -
Provide a download file of errors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19263|0 |1
is obsolete| |
--- Comment #15 from Jonathan Druart ---
Created attachment 25004
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25004&action=edit
Bug 5771 : Adds a download link for big error reports to import_borrowers
If the import patrons tools produced a lot of errors(e.g. 1000), the
browser will crash or not be glad.
This patch allow to download an error file for report producing at least
25 errors.
Test plan:
Import patrons with at least 25 errors and check that a "Download
report" button appears and produce a text file to download.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:38:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 11:38:07 +0000
Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers -
Provide a download file of errors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771
--- Comment #16 from Jonathan Druart ---
(In reply to Holger Mei?ner from comment #14)
> The download button appears and a text file can be downloaded. But it only
> contains some kind of reference? See screenshot.
Thanks for testing! The last patch should fix that.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:18:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 12:18:46 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202
--- Comment #64 from Jonathan Druart ---
Created attachment 25005
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25005&action=edit
Bug 11202: FIX UT for QueryParser.t
Test plan:
prove t/QueryParser.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:17:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 13:17:36 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #62 from Jonathan Druart ---
Created attachment 25006
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25006&action=edit
Bug 9016: Fix some translate issues
On tools/letter.pl and tools/overduerules.pl, some strings were not
translatable. This patch should fix that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:18:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 13:18:58 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #63 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #61)
> - TODO: Translatability - I think the message transport types on the overdue
> notice triggers page are not translatable:
>
> + [% FOREACH mtt IN message_transport_types %]
> +
[% mtt %]
Last patch fixes that. Thanks for the catch!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:43:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 15:43:33 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gmcharlt at gmail.com
--- Comment #10 from Galen Charlton ---
(In reply to M. de Rooy from comment #9)
> (In reply to Katrin Fischer from comment #8)
> > On the contrary I woudl argue that we should not remove the
> > biblionumber on cancelling an order, as I can see no reason why this would
> > be necessary.
> If we keep the itemnumber, we should certainly keep the biblionumber too.
> Rather see a title (marked as deleted) instead of Deleted bibliographic
> notice, can't find title.
It's a pity not having the foreign key constraints, but on balance there's too
much potential need for library staff to need to refer to both ordered bibs and
items for a period of time, even after the items or bibs are deleted in
cataloging.
This is going a bit far off, but I think we should consider adding a Boolean
"is deleted" flag to biblio and items, to represent the case where an item or
bib no longer is held by the library but is still referred to by other records
that need to be kept for some archival purpose. This would make us more free
to add FK constraints, at the cost of needing more code to distinguished
between a merely deleted and a fully purged bib or item.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:27:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 16:27:31 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
--- Comment #51 from Kyle M Hall ---
Created attachment 25008
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25008&action=edit
Bug 9303 [QA Followup 2] - Undo changes to GetReserve
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:42:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 16:42:25 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
--- Comment #52 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #37)
> ::: C4/Reserves.pm
> @@ +270,5 @@
> > + $sth->execute($reserve_id);
> > + $res = $sth->fetchrow_hashref();
> > + }
> > +
> > + carp("No hold for for reserve_id $reserve_id") unless $res;
>
> Hm, this change seems unrelated to the bug description?
Yep, looks like an accidental commit. I added another followup to revert that
code change.
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
> @@ +1168,5 @@
> > +
> > + [% END %]
> > +
> > +
Allow linked patron accounts to view this patron's checkouts from the OPAC
> > +
>
> This is different to how we handle the other privacy seetings in that we
> don't allow staff to change those for a patron. I see why staff will want to
> change that setting for a parent requesting it, but at the same time it
> bothers me a bit.
This is a specific requirement of the sponsor, specifically so that a guarantor
can request to be able to view a guaranteed accounts checkouts without the need
to log into the opac as that guaranteed patron to make the change. This option
can easily be hidden via jquery if needed.
> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
> @@ +1,3 @@
> > [% USE Koha %]
> > [% USE KohaDates %]
> > +[% USE EncodeUTF8 %]
>
> The only script using this so far is renew.pl - can you explain a bit?
This is a simple filter plugin that encodes the given variable to utf8. It
addresses some of the encoding issues we have in Koha. Right now our encoding
of data to utf is mixed in throughout the code base when it really should be at
one of two places, the very beginning ( e.g. database queries ) or at the very
end ( e.g. template output ). This plugin allows us to handle utf8 encoding
from the very end of the output chain. In fact, it would be even better if we
could configure Koha's TT to filter every value though this filter before
outputting. At this time however, I have been unable to find a way to do so.
I'm certain we could do this by extending Template::Parser but I'm not sure if
we want to go that far.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:51:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 16:51:15 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #18 from M. de Rooy ---
(In reply to Katrin Fischer from comment #16)
> Hm weird, I will retest. Jonathan, did you make any changes to the new patch?
Please do not forget to copy the queryparser.yaml to your zebra install.
You could restart Zebra but I do not think that it was necessary.
Edit a record after that and search..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:57:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 16:57:27 +0000
Subject: [Koha-bugs] [Bug 11670] New: Remove sorting from patron lists
action columns
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670
Bug ID: 11670
Summary: Remove sorting from patron lists action columns
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: minor
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
The table that lists patron lists has sortable columns for add, edit, and
delete buttons. These columns should not be sortable.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:06:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 17:06:16 +0000
Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action
columns
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:06:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 17:06:18 +0000
Subject: [Koha-bugs] [Bug 11670] Remove sorting from patron lists action
columns
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670
--- Comment #1 from Owen Leonard ---
Created attachment 25009
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25009&action=edit
Bug 11670 - Remove sorting from patron lists action columns
The list of patron lists has sortable columns for the add, edit, and
delete buttons. These columns should not be sortable. This patch removes
sorting.
This patch also adds the "btn-mini" class to the in-table buttons to
make the table more compact.
To test you must have existing patron lists. Apply the patch and
navigate to Tools -> Patron lists. The columns containing the add, edit,
and delete buttons should not be sortable. Other columns should sort
correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:15:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 17:15:35 +0000
Subject: [Koha-bugs] [Bug 11671] New: Restructure patron lists add form for
improved usability
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671
Bug ID: 11671
Summary: Restructure patron lists add form for improved
usability
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
URL: /cgi-bin/koha/patron_lists/list.pl?patron_list_id=
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
I think it's a potential usability problem that the patron lists "add patron"
form has a duplicated submit button. Having one button placed at the top next
to the add function implies that this button might be *only* submitting the new
patrons, not the deletions which could be triggered by having checked a
checkbox.
I think the process of adding a patron should trigger the display of an "add"
submit button which only submits the additions, not any deletions. The button
at the bottom of the list should be clearly labeled and only submit deletions.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:56:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 17:56:54 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648
--- Comment #5 from Fridolin SOMERS ---
(In reply to Chris Cormack from comment #4)
> Easy patches to sign off on, does everyone agree about the change in
> terminology?
It has been started with Bug 10346
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:34:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:34:05 +0000
Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for
improved usability
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Medium patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:34:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:34:08 +0000
Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for
improved usability
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671
--- Comment #1 from Owen Leonard ---
Created attachment 25010
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25010&action=edit
Bug 11671 - Restructure patron lists add form for improved usability
Non-standard interface features have the potential to cause confusion.
This patch brings various aspects of the patron lists add page into
conformity with other staff client pages.
- Add "select all/clear all" links for the checkboxes
- Add a "remove selected" to the top of the table (see also Lists)
- Split functionality of add from from delete form
- Hide "Add patrons" button until at least one patron has been selected
- Remove non-standard trash can icon from table's checkbox column
- Exclude checkbox column from table sorting
- Add confirmation to deletion actions
- Improve breadcrumb specificity
- Add title-string sorting to date column to accommodate sorting for all
date format types
To test, apply the patch and create a patron list.
1. Search for and select patrons for the list. Selecting a patron should
trigger the display of an "Add patrons" button.
2. Click "Add patrons" and confirm that the add process completes
correctly.
3. Search for and select a patron and also check the box next to an
existing patron. Click "Add patrons" and confirm that no patron is
removed.
4. Check that the "select all" and "clear all" links work correctly.
5. Select patrons on the list and click the "Remove selected" link. You
should be prompted to confirm your choice.
4.a. Click cancel and confirm that the deletion process aborts.
4.b. Click OK and confirm that the deletion process completes.
6. Repeat step 4 with the "Remove selected patrons" at the bottom of the
page.
7. Confirm that the page title and breadcrumbs correctly show the list
name.
8. Switch between us and metric dateformat settings and confirm that
table sorting by date is correct in both cases.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:35:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:35:35 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
Not a native speaker - but using consistent terminology helps translators :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:42:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:42:49 +0000
Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for
improved usability
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25010|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 25011
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25011&action=edit
Bug 11671 - Restructure patron lists add form for improved usability
Non-standard interface features have the potential to cause confusion.
This patch brings various aspects of the patron lists add page into
conformity with other staff client pages.
- Add "select all/clear all" links for the checkboxes
- Add a "remove selected" to the top of the table (see also Lists)
- Split functionality of add from from delete form
- Hide "Add patrons" button until at least one patron has been selected
- Remove non-standard trash can icon from table's checkbox column
- Exclude checkbox column from table sorting
- Add confirmation to deletion actions
- Improve breadcrumb specificity
- Add title-string sorting to date column to accommodate sorting for all
date format types
To test, apply the patch and create a patron list.
1. Search for and select patrons for the list. Selecting a patron should
trigger the display of an "Add patrons" button.
2. Click "Add patrons" and confirm that the add process completes
correctly.
3. Search for and select a patron and also check the box next to an
existing patron. Click "Add patrons" and confirm that no patron is
removed.
4. Check that the "select all" and "clear all" links work correctly.
5. Select patrons on the list and click the "Remove selected" link. You
should be prompted to confirm your choice.
4.a. Click cancel and confirm that the deletion process aborts.
4.b. Click OK and confirm that the deletion process completes.
6. Repeat step 4 with the "Remove selected patrons" at the bottom of the
page.
7. Confirm that the page title and breadcrumbs correctly show the list
name.
8. Switch between us and metric dateformat settings and confirm that
table sorting by date is correct in both cases.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:43:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:43:52 +0000
Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for
improved usability
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |11636
--- Comment #3 from Owen Leonard ---
Should have made this dependent on Bug 11636 since they conflict. Resubmitted
and added the dependency.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:43:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:43:52 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
list during add process
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |11671
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:46:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:46:31 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:46:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:46:35 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24851|0 |1
is obsolete| |
Attachment #24852|0 |1
is obsolete| |
Attachment #24993|0 |1
is obsolete| |
--- Comment #21 from Katrin Fischer ---
Created attachment 25012
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25012&action=edit
[PASSED QA] Bug 11027 : Add a column for basketgroups in late orders table and
improve other columns
This patch makes 4 changes in late orders page :
- adding a new column for basketgroup, displaying
the name and number of the basketgroup
- displaying the name of the basket as well as its
number, with a hyperlink to this basketgroup
- displaying fund in a separate column to make
sorting easier, and renaming it from "budget" to
"fund" (the confusion can be found elsewhere in Koha...)
- displaying branch in a separate column to make
sorting easier (this column could be improved later,
by getting branch from basketgroup if there is one)
For that, in Aquisition.pm, I made some changes to GetLateOrders:
- 3 new columns in SELECT
- 1 new join
To test :
1. Display the list of late orders of your instance.
2. Check you have 3 new columns for basketgroups, fund and branch
3. In basketgroup column you should have "name of basket group (number)"
4. In basket column you should have "name of basket (number)"
5. Check the links for basketgroups. They should send you to the
page displaying information for each basketgroup
(without possibiliy of editing them if they are closed)
Signed-off-by: Mark Tompsett
Signed-off-by: Katrin Fischer
Patches pass QA script and all tests.
Works as described. Also checked sorting and orders which
are not in a basketgroup display correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:46:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:46:48 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
--- Comment #22 from Katrin Fischer ---
Created attachment 25013
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25013&action=edit
[PASSED QA] Bug 11027 - Create a link only if user have required permissions
With this followup, a user without order_manage permission won't be able to
cick on a basket
and a user without group_manage permission won't be able to click on a
basketgroup
Note that the issue for basket is present in current master. So it deserves a
separate bugfix (as bug 11027 is an ENH)
Signed-off-by: Mark Tompsett
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:46:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 19:46:59 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
orders table
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027
--- Comment #23 from Katrin Fischer ---
Created attachment 25014
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25014&action=edit
[PASSED QA] Bug 11027 (QA) : hide link if no basketgroup and use real branch
name
This patch is a answer to remarks made by QA:
- if there is no basketgroup for an order, the basketgroup
column in lastorders.pl is now blank (instead of parentheses)
- the name of the branch is used instead of its code in the
branch column
To test: check late orders, included and not included into basketgroup
Signed-off-by: Mark Tompsett
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:05:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 20:05:30 +0000
Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785
in UNIMARC XSLT should be removed in bootstrap theme
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:05:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 20:05:33 +0000
Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785
in UNIMARC XSLT should be removed in bootstrap theme
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24994|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 25015
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25015&action=edit
[PASSED QA] Bug 11246 : remove useless reference to fields 780 and 785 in
UNIMARC XSLT files for Bootstrap opac
Another fix, 10465, removed fields 780 and 785 from a unimarc xslt file.
This cleanup is needed for bootstrap too
To test : in a UNIMARC Koha, with Bootstrap theme OPAC
1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay sysprefs are
set to "default"
2. apply the patch
3. search some records in OPAC : the list view and the detail view must be
exacty the same as before you apply the patch.
Signed-off-by: Mark Tompsett
Signed-off-by: Katrin Fischer
Changes are consistent with changes done earlier on the prog theme.
Checked that the detail pages and results still display correctly
for UNIMARC.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:31:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 20:31:08 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #19 from Katrin Fischer ---
It still doesn't work in my test installation:
- Checked that the file was copied correctly
- Checked my koha-conf.xml for the QueryParser line.
/home/katrin/koha-dev/etc/searchengine/queryparser.yaml
- Checked QueryParser is activated.
- Keyword search finds my 041$h result.
- language-original:dedede doesn't.
- Changed the record to have 'dut' instead.
- Reindexed with -z
- Keyword search finds dut.
- language-original:dut gives no result.
- No errors in my koha-opac-error_log.
Marcel, does the space make a difference for you? language-original: dut vs.
language-original:dut?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:38:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 20:38:52 +0000
Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to
amount unallocated
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644
--- Comment #5 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #4)
> I am failing to reproduce the problem, here is what I did:
> - My budget had 200,00 unallocated
> - I created a new fund with 200,00, it saved correctly
> - I tried editing the newly created fund, it also saved correctly
>
> Quite sure I am missing something - any hints?
I wish I had some hints to give you! I had to debug this on a production
system. I tried to come up with the best way to reproduce the issue I could. It
may even be that you'd be unable to reproduce the error on a different system,
as this may have something to do with Perl versions. Can you at least verify
the patch does not cause any regressions?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:42:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 20:42:57 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
--- Comment #20 from Katrin Fischer ---
*sigh* outdated index configuration... works alright now :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:44:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 20:44:01 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:44:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 20:44:06 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24996|0 |1
is obsolete| |
--- Comment #21 from Katrin Fischer ---
Created attachment 25016
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25016&action=edit
[PASSED QA] Bug 11619: Duplicate key in QueryParser config
Corrects a double entry for language in yaml file.
Language should have been language-original.
Test plan:
Check that you have language-original in your zebra install.
Specifically, this index should cover MARC21 041$h.
Enable QueryParser and search for a record with this index.
Note that this patch does not enable searching on this
index without QueryParser. This is true for many more indexes
in record.abs that are not included in the getIndexes routine.
Signed-off-by: Jonathan Druart
Signed-off-by: Katrin Fischer
Works as described - make sure you are testing with a current
indexing configuration.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:05:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 21:05:28 +0000
Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from
"Search the catalog"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:05:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 21:05:32 +0000
Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from
"Search the catalog"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24995|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 25017
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25017&action=edit
[PASSED QA] Bug 11572 - Keyword searches no longer detect isbn from "Search the
catalog"
In Koha 3.8, if a standard catalog search was performed and the user
clicked the z39.50 search button, the search string would automatically
be placed in the isbn field for the z39.50 search form.
Changes to the code have since broken this functionality.
Test Plan:
1) From mainpage.pl, use "Search the catalog" to search for the string
"9781570672835"
2) Click the Z39.50 Search button
3) Note the string is placed in the title field
4) Apply this patch
5) Repeat steps 1-2
6) Note the string is placed in the isbn field
Signed-off-by: Mark Tompsett
Signed-off-by: Katrin Fischer
Tested old and new ISBN with and without hyphens.
Also tested some other keyword searches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:27:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 21:27:46 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
on checkin
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
Hi Kyle, 2 things:
- Can you please move the syspref so the alphabetic order is correct?
- Are you very attached to the around the not for loan values
in the librarian message?
It breaks the string into pieces in translation:
msgid "Not for loan status updated from "
And somewhere a 'to' I was too lazy to locate.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:31:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2014 21:31:00 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
--- Comment #53 from Katrin Fischer ---
Hi Kyle, as this is a data privacy relevant feature jQuery would not suffice to
hide as it would still be possible to just turn Javasript off to change the
setting. But that's just a note - I am going to test again ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 06:23:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Feb 2014 05:23:30 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
--- Comment #54 from Heather Braum ---
Katrin, just to help in the explanation, since Kyle mentioned the sponsor
requirement in his most recent comment back to you:
I represent the organization that is sponsoring this development and since we
requested the additional setting on the staff side to be able to turn this
feature on and off through a borrower account, we are having to do this,
because if you have the sys pref OPACPrivacy set to Don't Allow (which we
have), patrons have no ability to even turn this new feature on/off in an OPAC
account (if I remember correctly from our testing a few months ago). We have
that sys pref turned off because it currently wrecks havoc on checkout history
links for items if patrons "opt-out" of checkout history being left. In a
consortia of 42 libraries with materials going everywhere, we have to have that
checkout history to track down materials.
Additionally, if you have a guarantor with 2 or more kids, it's much easier for
this feature to be turned on from the staff side as well -- instead of having
to log into each guarantee's account to turn this feature on. We thought adding
the ability to turn this on and off from the staff side would actually help out
patrons.
I understand the privacy concerns -- we have them too -- and I'll let you all
continue to sort this out, but I wanted to explain where we're coming from as
the sponsor of this development.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 06:38:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Feb 2014 05:38:44 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
--- Comment #55 from Katrin Fischer ---
Hi Heather, thank you for taking the time to explain. I understand why it makes
sense to have the option in the patron account. I might be a bit overly careful
at times as we are quite strict with data privacy here. I just couldn't resist
to point out that jQuery won't be a solution if you might not be allowed to use
this feature for privacy concerns. There is no staff permission and no pref to
turn it totally off currently.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 07:57:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Feb 2014 06:57:08 +0000
Subject: [Koha-bugs] [Bug 11672] New: Untranslatable report areas in step 1
of Guided Reports
Message-ID: