[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

--- Comment #12 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to mathieu saby from comment #11)
> It is not working well, and most of all, improving the display of rrp and
> ecost price on invoices is maybe a loss of time.
> 

Mathieu, are you sure your last test was with the patches correctly applied?

>From what I see, patched version is calculating & displaying unitcost (aka
actual cost) on invoice page, just like it should - and there is an clear
indication stating if given column is with, or without tax.

We are currently testing those patches; so far with the good results
for listincgst/invoiceincgst both yes/yes && no/no.

Less usual combinations (no/yes, yes/no) might be a different story - I believe
invoice.pl may need an additional small change like that:

185c185
>     if ( $bookseller->{'invoiceincgst'} ) {
---
<     if ( $bookseller->{'listincgst'} ) {

to behave properly for "no/yes" and "yes/no" (???).

Anyway, handling prices for yes/no and no/yes combinations are apparently even
more problematic in other places (like parcel.pl, basket.pl, .. - price
calculations/display/column labeling etc. are not always working correctly in
those other scripts - depending on the circumstances). I'm wondering if anyone
is actually using such unusual combinations IRL?

-- 
You are receiving this mail because:
You are watching all bug changes.