[Koha-bugs] [Bug 9303] relative's checkouts in the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #37)

> ::: C4/Reserves.pm
> @@ +270,5 @@
> > +        $sth->execute($reserve_id);
> > +        $res = $sth->fetchrow_hashref();
> > +    }
> > +
> > +    carp("No hold for for reserve_id $reserve_id") unless $res;
> 
> Hm, this change seems unrelated to the bug description?

Yep, looks like an accidental commit. I added another followup to revert that
code change.

> ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
> @@ +1168,5 @@
> > +                    <option value="1">Yes</option>
> > +                [% END %]
> > +            </select>
> > +            <div class="hint">Allow linked patron accounts to view this patron's checkouts from the OPAC</div>
> > +        </li>
> 
> This is different to how we handle the other privacy seetings in that we
> don't allow staff to change those for a patron. I see why staff will want to
> change that setting for a parent requesting it, but at the same time it
> bothers me a bit.

This is a specific requirement of the sponsor, specifically so that a guarantor
can request to be able to view a guaranteed accounts checkouts without the need
to log into the opac as that guaranteed patron to make the change. This option
can easily be hidden via jquery if needed.

> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
> @@ +1,3 @@
> >  [% USE Koha %]
> >  [% USE KohaDates %]
> > +[% USE EncodeUTF8 %]
> 
> The only script using this so far is renew.pl - can you explain a bit?

This is a simple filter plugin that encodes the given variable to utf8. It
addresses some of the encoding issues we have in Koha. Right now our encoding
of data to utf is mixed in throughout the code base when it really should be at
one of two places, the very beginning ( e.g. database queries ) or at the very
end ( e.g. template output ). This plugin allows us to handle utf8 encoding
from the very end of the output chain. In fact, it would be even better if we
could configure Koha's TT to filter every value though this filter before
outputting. At this time however, I have been unable to find a way to do so.
I'm certain we could do this by extending Template::Parser but I'm not sure if
we want to go that far.

-- 
You are receiving this mail because:
You are watching all bug changes.