[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #0)
> [3] Create a new serial_issue_status column to manage the statuses.  It
> might look like this:
> 
> id INTEGER -- status ID
> name VARCHAR(255) -- label of status
> missing BOOLEAN -- whether or not the status should be considered to
> represent an issue that was never received

I'm not sure it is enough.
The status value is checked at several places in the code:

 1/ (planneddate < now() AND serial.status=1) OR serial.STATUS IN (3, 4, 41,
42, 43, 44)

 2/ WHERE ((planneddate < now() AND serial.STATUS =1) OR serial.STATUS = 3)

and some others.

The "missing" boolean won't permit to write a SQL query doing the same thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.