[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #58 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
> > 4) And finally :) what about the defaulting to /var/lock if the zebra lock
> > has not been defined or so? mkdir /var/lock/rebuild: Permission denied at
> > misc/migration_tools/rebuild_zebra.pl line 161. I guess that this permission
> > problem could popup in many cases more..
> 
> Something like this?
> my $lockdir = C4::Context->config("zebra_lockdir") // "/var/lock";
> $lockdir .= "/rebuild";
> unless (-d $lockdir) {
>     make_path($lockdir, {verbose=>0, mode=>oct(755), error=>\$err})
>     $lockdir = "/var/lock" if (@$err);
> }
> my $lockfile = $lockdir . "/rebuild..LCK";

Sorry, that my comment here was not that clear (defaulting was not the right
word, it should better be fall back). I actually meant that we should better
choose another folder than /var/lock. If you run the zebra job without root
permissions, you will probably have no permissions in /var/lock.
Since this should be an exception, why not just fall back to /tmp (OR just skip
the locking stuff: if the install is dubious, who complains..) BTW there are
other places in Koha where write permission in /tmp is just assumed. In every
case, it is much more likely to be so. Your choice.

-- 
You are receiving this mail because:
You are watching all bug changes.