[Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml()

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

--- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just some question from glancing through code:

How do the following remaining statements interact? 
A call somewhere like:
    my $xml = TransformHtmlToXml(\@tags,\@subfields,\@values, 'ITEM');
with the first lines from the routine:
    my ( $tags, $subfields, $values, $auth_type ) = @_;
    my $xml = MARC::File::XML::header('UTF-8');
    $xml .= "<record>\n";
    $auth_type = C4::Context->preference('marcflavour') unless $auth_type;
    MARC::File::XML->default_record_format($auth_type);
Note that MARC::File::XML->default_record_format does not expect ITEM but only:
Valid formats are MARC21, USMARC, UNIMARC and UNIMARCAUTH.
You could argue that this is outside the scope of this report. But you are
removing parameters and not just touching a few lines here of the routine? 

It seems that this routine is only used in items now. The pod refers to unimarc
authority records too. Perhaps it is not used anymore. I have the impression
that your changes are somewhat rigorous and could cut off future use in a
broader sense (biblio or auth instead of item only)? Please note that I do not
oppose to remove them, I am just triggering a discussion..

A more elaborated test plan and even some unit tests now for the
TransformHtmlToXml routine could further help to get this patch further in the
process.

Thanks for your attention.

-- 
You are receiving this mail because:
You are watching all bug changes.