[Koha-bugs] [Bug 11732] Eliminate warning on undefined branchcode

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 12 15:42:15 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11732

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #2)
> I tried to test this, but test 7 fails when I run:
> prove -v t/db_dependent/Reserves.t
> And an error message is not triggered even in master. I suspect I don't have
> things set to pretend to be logged in.
The test creates branches and categories, even sets a pref, so this apparently
requires more digging into other circulation settings.. It is interesting to
know why it fails (with the AddReturn call, I understand), but this report just
fixes a trivial uninitialized value.

> This eyeballs just fine, but I was wondering...
> why not move line 129 to after the if?
> And why not // instead of ||?
Fine with me. New patch submitted.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list