[Koha-bugs] [Bug 10794] Sorting on billing date column in invoices table doesn't work

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Feb 13 08:48:03 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794

--- Comment #7 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
It was implemented and it worked, at least for a while ;)

But indeed, it's not working properly since "Bug 10401: Add ability to merge
invoices" has been pushed - there was 1st extra column with checkboxes added,
and this code

    $("#resultst").dataTable($.extend(true, {}, dataTablesDefaults, {
        sDom: "t",
        "aoColumns": [
            null,null,{ "sType": "title-string" },null,null,null,null
        ],
        aoColumnDefs: [
            { "bSortable": false, "aTargets": [0, 7] }
        ]
    }));

was not fully adjusted to reflect this change ( "sType": "title-string" now
applies to "Vendor" column, not "Billing date"). BTW, I think it may be
something else not quite right with this code; that's what I'm getting in 3.14
and in (not so current) master:
1) "Billing date" sorting is not OK,
2) "Vendor" column is not sortable at all,
3) top/bottom DataTables pagination bars are missing (tested in Firefox 27.0,
might be browser dependant?) - only "top ten" invoices are always displayed in
the table, and it's not possible to change that without pagination bars.

By some trial-and-error, I got it working (1-3) with:

    $("#resultst").dataTable($.extend(true, {}, dataTablesDefaults, {
        aoColumnDefs: [
            { "bSortable": false, "aTargets": [0, 7] },
            { "sType": "string", "aTargets": [ 3 ] }
        ]
    }));

but it's my first real experience with DataTables; not sure if I know what I'm
doing.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list