[Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

--- Comment #1 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Galen Charlton from comment #0)

> acqui/basketgroup.pl:    my $pdf = printpdf($basketgroup, $bookseller,
> $baskets, \%orders, $bookseller->{gstrate} // C4::Context->

Looks like all existing pdfprint() variants are not using this gstrate argument
any longer (that is probably good - they should use gst rates from invoice
records instead).

> acqui/invoice.pl:my $gist = $bookseller->{gstrate} //
> C4::Context->preference("gist") // 0;

This one is fixed by "Bug 10613 - Gst is not calculated correctly on the
invoice page" - which we will really like to be pushed ;)

> acqui/parcel.pl:my $gst = $bookseller->{gstrate} //
> C4::Context->preference("gist") // 0;

Dead code ($gst is set, but never used)?

Yet another improper usage of gist is in the parcels.pl - this is an odd one

   GST => C4::Context->preference('gist'),

I guess it's a part of (apparently never fully implemented) feature for
choosing gst rate of the shipping costs (?).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.