[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23553|0                           |1
        is obsolete|                            |

--- Comment #52 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 25320
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25320&action=edit
Bug 7567 - Undefined $lang triggers warning

Changed:
    $template->param(
        $lang           => 1,
        opac_news       => $opac_news,
        opac_news_count => $opac_news_count,
                );
Into:
    $template->param(
        opac_news       => $opac_news,
        opac_news_count => $opac_news_count,
                );
    $template->param( $lang => 1 ) if $lang;

Because $lang is not defined when you come immediately into
Home -> Tools -> News.

TEST PLAN
---------
1) log into staff client
2) Tools -> News
3) Check koha error log
   - Expecting to see an error like:
koha-news.pl: Problem = a value of 1 has been passed to param without key
4) Apply patch
5) Home -> Tools -> News
6) Check koha error log
   - No error generated

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.