[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23705|0                           |1
        is obsolete|                            |

--- Comment #57 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 25325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25325&action=edit
Bug 7567 - Use, Display, Filter News by Branch

With the branch parameter added to key functions in
C4/NewsChannels.pm, function calls in C4/Members.pm,
mainpage.pl, opac/opac-main.pl, tools/koha-news.pl, and
t/db_dependent/NewsChannels.t were needed.

Some license texts were updated.

Templates were modified to display, allow for entry and editing
of the branches selected.

TEST PLAN
---------
1) Having logged into the staff client, is the news displaying
   correctly? Have you entered a news item which should not
   display for this branch of logged in user?
2) Find a patron (with some items checked out?)
3) Print a slip
   - News which is labelled 'All Branches' or for the same branch
     as the one printing the slip should display on the slip.
   - THIS DOES NOT AFFECT QUICK SLIPS
4) Home -> Tools -> News
   - Can you edit a news item?
   - Does the change save correctly?
   - Can you filter based on location and branch correctly?
   - Can you add a new entry correctly?
   - Can you delete an entry correctly?
5) Open an OPAC client.
   - Does only the news for all branches display?
6) Log into the OPAC client.
   - Does the news for all branches and the specific branch display?
7) prove -v t/db_dependent/NewsChannels.t
   - Does it run and all succeed?
   - Does the code seem to catch the required cases?
8) Comparing the patched and unpatched versions of files affected,
   are the license changes missing anything?

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

1..10
ok 1 - use C4::NewsChannels;
ok 2 - Correctly failed on no parameter!
ok 3 - Successfully added the first dummy news item!
ok 4 - Successfully added the second dummy news item!
ok 5 - Correctly failed on no parameter!
ok 6 - Successfully updated second dummy news item!
ok 7 - Successfully tested get_opac_new id1 (0)!
ok 8 - Successfully tested get_opac_new id2 (0)!
ok 9 - Successfully tested get_opac_news for LIB1!
ok 10 - Successfully tested GetNewsToDisplay for LIB1!

-- 
You are receiving this mail because:
You are watching all bug changes.