[Koha-bugs] [Bug 10789] Excessive and often incorrect use of finish in C4::Acquisitions

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 18 16:31:10 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
[Jonathan: We were looking at this simulaneously..]
QA Comment 2:
Code looks good to me (now). Fixed removed unused sql parameter too passing by.
Few additional comments.
Did some limited testing. Compliments for testing by Marc Veron, and test plan.
This patch actually lacked a test plan. 

Small remark on ModReceiveOrder
+    # we assume we have a unique order
+    my $order = $result_set->[0];
The old code contained this assumption and you will most probably have one.
But we could argue about testing it..

As in the meantime also seen by Jonathan,
t/db_dependent/Acquisition/OrderFromSubscription.t complained: 
Illegal date specified (year = 2015, month = 31, day = 12) at
/usr/share/koha/testclone/C4/SQLHelper.pm line 409.
Use of uninitialized value $serialseq in string at
/usr/share/koha/testclone/C4/Serials.pm line 1542.
This is unrelated to this report.
And:
DBD::mysql::db selectall_arrayref failed: called with 1 bind variables when 2
are needed at /usr/share/koha/testclone/C4/Acquisition.pm line 1199.
DBD::mysql::db selectall_arrayref failed: called with 1 bind variables when 2
are needed at /usr/share/koha/testclone/C4/Acquisition.pm line 1199.
Fixed in the follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list