[Koha-bugs] [Bug 11790] New: C4::Charset should not depend on C4::Context

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 18 23:01:20 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790

            Bug ID: 11790
           Summary: C4::Charset should not depend on C4::Context
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The patch for bug 8437 added a system preference lookup to
C4::Charset::SetMarcUnicodeFlag(), which in turn forces a dependency on
C4::Context (c.f. bug 11730).

This is a bit of a wart, as there's nothing else in C4::Charset that is
dependent on there being a Koha database.  It builds on yet another wart,
introduced by commit 7eca37db, that overloads SetMarcUnicodeFlag() to set
fields in the UNIMARC 100 that have nothing to do with the character encoding.

This should be split apart so that

- C4::Charset doesn't require a dependency on C4::Context
- code that handles anything beyond setting the character set flags is moved
out of SetMarcUnicodeFlag

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list