[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #66 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 25447
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25447&action=edit
Bug 11078: QA Follow-up for missing file permissions on lockfile

The original patch creates a lockfile in the ZEBRA_LOCKDIR.
It can fall back to /var/lock or even /tmp.
If the create fails, it dies. This can be considered as very exceptional.

This followup adjusts the fallback location in /var/lock or /tmp slightly.
It appends the database name to the folder in order to prevent interfering
between multiple Koha instances. Creation of the lockfile has been moved
to a subroutine extending directory and file creation testing.

In the very unlikely case that we cannot create the lockfile (after three
separate tries), this follow-up allows you to continue instead of die.
This is just as we did before we had file locking here. Every time skipping
a reindex could cause more harm than continuing and having the race condition
once in a while.

Test plan:
Test adding and removing lockdir from your koha-conf.xml. Check fallback.
Note that fallback in /var/lock or /tmp must contain database name.
Remove the lockdir config line and remove permissions from fallback. In
this case the reindex should continue but with a warning.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with daemon and one-off invocation simultaneously.
Tested new wait parameter.
Tried all variations of lock directory (changing permissions etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.