[Koha-bugs] [Bug 11644] Cannot update fund if total is equal to amount unallocated

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #14 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

However, I have declined to push Jonathan's follow-up, and instead have pushed
one of my own with the following FIXME (which to be clear, is NOT directed at
Kyle's patch in particular):

+# FIXME - we really need a better way to do this consistently
+# and across the board, be it bigints, Math::FixedPoint, a
+# modernized version of Math::Curency that isn't tied to the system
+# locale, or something else.

The problem with Jonathan's suggestion of using a system preference to specify
the number of decimal places for a currency is that such a thing is not
actually a global attribute -- it's more properly an attribute of the currency.
 Hard-coding the number of decimal places to 2, while not ideal, won't break
things for folks who use JPY.

-- 
You are receiving this mail because:
You are watching all bug changes.