[Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion
                 CC|                            |gmcharlt at gmail.com

--- Comment #15 from Galen Charlton <gmcharlt at gmail.com> ---
> (In reply to Owen Leonard from comment #7)
> > (In reply to M. de Rooy from comment #6)
> > > Enable pref, create new public list in opac.
> > > Disable pref. Edit same list in opac and Save.
> > 
> > I see the problem, but this presents an interesting question... If you have
> > changed your library policy to disallow creation of public lists should it
> > be possible for the general public to keep a list public?
> 
> Good point. If you decide to disallow creation, you should probably also
> think at that moment about what you are doing with the lists made. (In the
> ideal situation, changing the pref should trigger such an action?) I think
> it should not depend on if a user edits his public list sometime after that..
> So on the balance, I would stick to keeping it in the same category. (I
> understand that your patch does that now. I will check later.)

I found another edge case with the current patch:

- patron creates public list
- OpacAllowPublicListCreation is turned off
- patron has no way to change the list to be private

I'm about to attach a follow-up that fills that gap, with the follow-up, a
patron will be able to make there list private.  Per a discussion on #koha, I'm
leaving it to Owen to style the warning message that is part of the follow-up.

Setting to in discussion pending review of my follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.