[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

wajasu <matted-34813 at mypacks.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25528|0                           |1
        is obsolete|                            |
                 CC|                            |matted-34813 at mypacks.net

--- Comment #4 from wajasu <matted-34813 at mypacks.net> ---
Created attachment 25556
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25556&action=edit
0001-SIGNED-OFF-Bug-11211-Move-calculation-code-out-of-C4

I think you might need to get the radio button initially set on "Open" or
"Closed" after clicking a day, so one knows the default.  Less confusion if one
selects repeating events.

Noticed: You can only save one event per day.  But I guess thats the design,
events are ONLY open/closed.

  5) Check out items to verify that the calculation code is using the
     events you just created.

Opened patron's checkout tab and say that the Total charges accumulted
correctly.
(No fines are shown but that seems the current behavior. But that could be
another issue for another day).

  6) If possible, verify that the two affected cronjobs still function
     correctly.

---- staticfines.pl test
Administration finesmode = calc and charge
Cataloged an item.  (or search for one and note barcode number).
Administration->Circulation and fine rules.
    Add a definition rule  line in frst table:
   Patron   All  1  10  days Exact 1.00  1  0   overdue cap=emtpyfield  zeros
for the rest.
Search for patron ( Lillie is a test one).  
Checkout book with noted barcode, but with due date 5 days prior to today.
Note: the patron's library.  Centerville is CPL   PT = patron category
command line:
koha at biblio:~/kohaclone/misc/cronjobs$ ./staticfines.pl -v -c PT -l CPL
xsub: [(($6||0),($5||0),($4||0),$3, $2 - 1, $1 - 1900)] 
CalcFine returning (1, , 1, 1) at /home/koha/kohaclone//C4/Overdues.pm line
261.
Creating fine for borrower 28 with amount : 1 at ./staticfines.pl line 220.
query: INSERT INTO accountlines
                       
(borrowernumber,itemnumber,date,amount,description,accounttype,amountoutstanding,lastincrement,accountno)
                                VALUES (?,?,now(),?,?,'F',?,?,?)
w/ args: 28, 1, 1, staticfine, 1, 1, 12
Fines assessment -- 2014-02-22
Number of Overdue Items:
     counted 1
    reported 1

you can run mysql -uroot -p koha_biblio  and select * from accountlines;  to
see results.

Now navigate to Tools-> Calendar.   selected days with "closed" checked and
saved between the item due date and today's date.
Could see corrent adjustments to amount with more days closed, etc.  Did this
for weekley, yearly, range. with correct results.


---- also ran fines.pl -v  and saw a fine with accountype FU  update
when holidays changed. 

NOTE:
koha at biblio:~/kohaclone$ ./koha_perl_deps.pl -a | grep Plugin
Template::Plugin::JavaScript                  0.01*     0.02      Yes
0.01 in squeeze worked.

Just need libtemplate-plugin-javascript-perl   to be added to control file.

-- 
You are receiving this mail because:
You are watching all bug changes.