[Koha-bugs] [Bug 11707] Additional attributes broken for category code with space

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11707

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 25567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25567&action=edit
[PASSED QA] Bug 11707 - Additional attributes broken for category code with
space

When editing additional attributes of a patron of a category with a code with
space (ie "CAT 3"), the Javascript is broken and Additional attributes are not
displayed.

This patch corrects by adding simple quotes aroud category code in JS code.

Test plan :
- Create an patron additional attribute
- Create a new patron category with a space in code. ie "CAT 3"
- Create a new patron of this category :
/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=CAT 3
=> Without patch the JS is broken (Syntax error, unrecognized expression:
[data-category_code=CAT 3]) and additional attributes are not displayed.
=> With patch the JS is not broken and additional attributes are displayed and
can be edited.

In current Koha version it is not possible to create categroy codes with
blanks.
To test, I changed an existing category code directly in the database.
Then I followed the Test plan.
Without patch, attribute types were not displayed.
With patch, they were displayed as expected.

Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
I recommend not using codes with spaces and fix existing ones.
Koha doesn't allow you to add category codes with spaces, so the only way
to do it is via SQL.
This patch fixes a problem and passes all tests.

-- 
You are receiving this mail because:
You are watching all bug changes.