[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #70 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
With reference to comment48, comment67 and what happened in the meantime, I am
passing QA on this report now.
Code looks good to me. No complaints from koha-qa.

Still want to pass this note to Galen however:
If nicely installed with a lockdir in the zebra dirs and consequently run under
same user context, the locking will work just fine.
And note that if the locking would not work out, there are no serious problems
either. The locking just prevent an incidental race condition.
But the last few days I had some second thoughts about the two fallbacks,
especially when people have no lockdir (although they should) and they might
run zebra under different user contexts (absolutely no recommendation!). In
that (very) rare case we could have two concurrent processes locking files at
two different locations, providing some sense of false security. But I mention
again: this would be an exception built on two faults.
So, for me pushing these two patches is fine. But removing the fallbacks for
the above reason (this could be done in one-liner patch now), would be fine
too, although you could still run rebuild-zebra with different permissions in
the remaining lockdir too..

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.