[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #5)
> Pushed to master, although as you can probably see from the comment I made
> in the commit message, I would suggest that it is a good idea to not lose
> perspective on the difference between a minor convention meant to reduce the
> chance of merge conflicts as opposed to an actual error.

Galen,
Yes I completely agree, it is not an "error".
The (small) problem occurs when the file is already badly sorted. In this case,
the qa script doesn't catch a patch introducing a line in the wrong place.
This means if a pref is added at the end of the file (as we previously did),
there is no warning.

-- 
You are receiving this mail because:
You are watching all bug changes.