[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #8)
> QA comment:
> 1/ I am not sure the code you added to AddReturn is put at the right place.
> I think the code should be put into the
>   if ( $doreturn )
> statement (if the return is not done, I suppose we don't want to update the
> not for loan status).
> Moreover, you will be able to use the existing call to ModItem (and avoid 1
> call to it).
> 
> 2/ Could you add unit tests for this new syspref please?
> 
> Marked as Failed QA.

I deprecated the patch for point 1, as we *do* want to update the not for loan
status even if the return is not done. In fact, the primary reason for this is
to cause a not for loan item to become for loan. I wasn't thinking when I wrote
the qa followup!

-- 
You are receiving this mail because:
You are watching all bug changes.