[Koha-bugs] [Bug 11836] New: population of template variables used by cat-toolbar.inc should be centralized

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11836

            Bug ID: 11836
           Summary: population of template variables used by
                    cat-toolbar.inc should be centralized
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There are a variety of pages that display bib details and the like that use the
cataloging toolbar:

catalogue/detail.pl
catalogue/MARCdetail.pl
catalogue/labeledMARCdetail.pl
catalogue/ISBDdetail.pl
catalogue/moredetail.pl
catalogue/imageviewer.pl

In order to reduce the risk of bugs like bug 11829 and to eliminate error-prone
code duplication, the population of variables required by the cataloging
toolbar should be centralized.  A couple options include:

- a central routine in the Koha namespace
(Koha::Template::Toolbars::Cataloguing?)
- a template block that uses template plugins to fetch the required information

I'm leaning towards the latter so long as the performance penalty of potential
repeated fetches in the database isn't too high.

-- 
You are receiving this mail because:
You are watching all bug changes.