[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #66 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Nice work including QA changes. No complaints from koha-qa. 

Tested prog and bootstrap. Disabled cookies too for a short while :) 

Still found small debatable issue: 
First I selected one record on page 1, page 2 and page 3. After that I selected
all records on page 1. 
It confused me at first to discover that the Browse results on detail are not
in the order of the search results, but apparently in the order of being added
to the list. 
No blocker for me, but we could argue about the order of the list. 

One of the commit messages promised this: 
  In addition to prog and ccsr templates, this patch allows to add 
  selected biblios (from multiple pages) to the cart or a list. 
  To test: 
  - check some biblios from several pages 
  - add them to the cart 
  - add them to a list 
Unfortunately, when I added items from two pages, only the item of the current
page was added. 
Again (with this being my last QA before temporary cutoff date) no blocker for
me :) 
A followup would be pretty on another report though.  

Saw some warnings in the log: 
opac-detail.pl: Use of uninitialized value in concatenation (.) or string at
/usr/share/koha/testclone/opac/opac-detail.pl line 394 
opac-detail.pl: Use of uninitialized value in concatenation (.) or string at
/usr/share/koha/testclone/opac/opac-detail.pl line 400. 
But I have the impression that your patches did not touch these lines.. 

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.