[Koha-bugs] [Bug 11573] change description of charges in account fines

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

wajasu <matted-34813 at mypacks.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matted-34813 at mypacks.net

--- Comment #5 from wajasu <matted-34813 at mypacks.net> ---
I generated a rental, and renewal of rental item:
26/02/2014     Rent, Renewal of Rental Item A heart for God / 1111  View item A
heart for God /         5.00     5.00     Print
26/02/2014     Rent, Rental  View item A heart for God /         5.00     5.00 
   Print

then applied patches
26/02/2014     Rent, Renewal of Rental Item A heart for God / 1111  View item  
       5.00     5.00     Print
26/02/2014     Rent, A heart for God / 1111  View item          5.00     5.00  
  Print


Overall this patch seems to make the  Patron Fines Account tab more succinct
not showing the duplicate title info. It also appends the barcode number for
Rentals and renewal entries.

---But

The Pay Fines tab now has title duplicated in parenthesis, which might need to
be taken off, now that its part of the accountlines description from this
patch.

  koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
could have line 129 removed,
       [% IF line.title %]([% line.title |html_entity %])[% END %] 
but we need to preserve historical context for the historically generated
accountline that may not have a title.

We could:
a) test to see if the title is already in the description and if not, append
it.
(but what if the title changes in the item record? does that matter)
b) perform a one time database update, appending the title to the accountline
description if its not already in there - gotta think about this. -- BIG UPDATE
for some follks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.