[Koha-bugs] [Bug 11573] change description of charges in account fines

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #6 from wajasu <matted-34813 at mypacks.net> ---
Created attachment 25715
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25715&action=edit
Followup Bug-11573-display-derived-account-fines-tab-description

Tested 24485 and 24486 patch ids, but could not signoff so I added a floowup
patch.

Followup patch 'display-derived-account-fines-tab-description'.
  After applying patches 24485 and 24486 above, this patch will adjust things
so that the fines realated Account and Pay Fines tabs will show a description
column that is more concise without the duplicated title problem that this bug
attempts to address.
  The templates have been expanded to handle accounttype codes that I could
find
mentioned in the existing codebase. In the case of the renewal, where no
explicit accounttype code exists as of yet, the template checks for 'enewal' in
the accountline.description field and adjusts accordingly.  The original code
that is building description can be historically preserved (though not shown),
and we will just depend on the other columns to formulate a description.

A barcode is shown if one exists, alongside the title.
The set of accounttype codes handled in the template has been expanded.
Unhandled codes will just appear untransformed as it does now.

Someone with a long history of fines usage can
 'select distinct accounttype from accountlines;' to confirm the set is
sufficiently handled in the pay.tt and boraccount.tt templates.

The reason for this followup was because the original two patches fixed things
by modifying accountlines, but indirectly cause 'Pay fines' tab to have
duplicate titles.

One could work on the 'enewal' hack, but that would require a new accounttype
and testing of other circulation/account/reserve code to consider it in their
where clauses.

Also, this may put us in a better position to translate the description in a
later patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.