From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 00:05:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2013 23:05:22 +0000 Subject: [Koha-bugs] [Bug 11464] New: Saving preferences - Nothing to Save Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Bug ID: 11464 Summary: Saving preferences - Nothing to Save Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If deleting contents from a textbox in preferences.pl, the system doesn't always register changes, and will respond with "Nothing to Save" instead of saving changes. To Test: For example, I'll use PatronSelfRegistrationBorrowerUnwantedField -Type "othernames" and click "Save all OPAC preferences" -Select text in that field and press "delete" key. -Note that Koha does not indicate that anything has been modified. -Click "Save all OPAC preferences" -Koha says "Nothing to Save" In order to delete and save, you have to type something in the box for it to register. So, you have to select, type, delete, then save. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 07:29:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 06:29:11 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 07:29:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 06:29:23 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23825|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 23882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23882&action=edit Bug 11453 - Update EN default UNIMARC bibliographic framework This patch updates default EN UNIMARC bibliographic framework I used the 2008 version of the UNIMARC bibliographic manual, and added updates listed on official site. There are new fields/subfields, those added are hidden by default. There are some description changes, and also a lot of changes to repeatable and mandatory values. To test: a) Functional 1) Remove all bibliographic frameworks 2) Load new file unimarc_framework_DEFAULT.sql 3) Check that it load without errors b) Correctness 1) Take a time and verify that all new fields/subfileds are correct Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 07:53:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 06:53:02 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 07:53:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 06:53:12 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23616|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 23883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23883&action=edit Bug 11411 [ENH] Bootstrap theme (enhancement) for (right to left) This patch will make a small change on the bootstrap-rtl.min.css file to make the welcome statement and the logout link located to the left of the screen. Test plan : 1-apply the patch 2-translate install ar-Arab 3-check the login/logut is on the left and that's it. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 08:01:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 07:01:39 +0000 Subject: [Koha-bugs] [Bug 11398] A typo occurred with occured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 08:01:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 07:01:46 +0000 Subject: [Koha-bugs] [Bug 11398] A typo occurred with occured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23570|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23884&action=edit Bug 11398: A typo occurred with occured This patch cures occured and makes occurred occur. Note that I found them while testing bug 11170. In a follow-up of 11170, I corrected this typo in parcels.tt. This patch touches update22to30.pl and modborrowers.tt Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 08:18:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 07:18:06 +0000 Subject: [Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 08:18:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 07:18:14 +0000 Subject: [Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23497|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23885&action=edit Bug 11389: reenable Pg as a DB scheme that Koha can connect to This patch restores the ability to request a DBI database handle or a DBIx::Class schema object connected to a PostgreSQL database. To address the concerns raised in bug 7188, only "mysql" and "Pg" are recognized as valid DB schemes. If anything else is passed to C4::Context::db_scheme2dbi or set as the db_scheme in the Koha configuration file, the DBD driver to load is assumed to be "mysql". Note that this patch drops any pretense of Oracle support. To test: [1] Apply patch, and verify that the database-dependent tests pass when run against a MySQL Koha database. [2] To test against PostgreSQL, create a Pg database and edit koha-conf.xml to set db_scheme to Pg (and adjust the other DB connection parameters appropriately). The following tests should pass, at minimum: t/Context.t t/db_dependent/Koha_Database.t Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 09:29:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 08:29:49 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|enhancement |new feature -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 09:34:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 08:34:19 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #13 from Chris Cormack --- This mostly applies cleanly on master. I think what we are missing is unit tests, and maybe we should move to the Koha:: namespace? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 12:01:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 11:01:30 +0000 Subject: [Koha-bugs] [Bug 10928] Acq Note does not appear when receiving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10928 --- Comment #4 from mathieu saby --- (In reply to Christopher Brannon from comment #3) > Mathieu, > It could just be that I am not familiar enough with Acquisitions, but I > don't see the problem. When receiving an order, I can see the order note > without the patch. Can you be more specific as to what version of Koha you > are using, and what screen it is missing from? > > Thanks. > > Christopher Hello Maybe it has been fix by an other bug. I can check it now, so I set it in discussion for the moment. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 12:01:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 11:01:42 +0000 Subject: [Koha-bugs] [Bug 10928] Acq Note does not appear when receiving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10928 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 12:05:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 11:05:18 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 12:07:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 11:07:52 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #4 from mathieu saby --- Hello Do you think it will be possible to improve this enh later to use Zebra instead of SQL directly ? I suppose it would improve performance? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 17:48:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 16:48:28 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 22:09:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jan 2014 21:09:59 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Magnus Enger --- 1. Typo in the module name, I think Koha::Sitemaper should be Koha::Sitemapper. 2. XML::Writer is not added to C4::Installer::PerlDependencies. 3. The POD for the script talks about generating files called sitemapindex.xml and sitemapXXXX.xml, but as far as I can see, all output is written to STDOUT and has to be split into different files by hand? 4. XML documents output by the script are missing the declarations, but they might be optional? 5. No tests for the stuff in Koha::Sitemaper and Koha::Sitemaper::Writer? Suggestions: 6. It could perhaps be said explicitly that the --url parameter shuld not include the trailing slash? 7. Could the base URL be taken from the OPACBaseURL syspref instead of being a command line parameter? 8. URLs in the sitemap-file are on the form: http://example.org/bib/171 Some sites might have disabled the Apache rewrite rules that make these URLs functional, so it might be better to have the style /cgi-bin/koha/opac-detail.pl?biblionumber=172 as the default and make the shorter form available through a command line switch? I'm marking this "Failed QA" because of number 2 above. But this would make a very cool addition to Koha, so I hope the issues can be fixed! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 05:13:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 04:13:05 +0000 Subject: [Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 --- Comment #1 from Chris Cormack --- Yep, if you have an old subscription that ended before 2013-12-31 test 22 will fail. If one is older than 2013-08-15 23 will also fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 05:18:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 04:18:42 +0000 Subject: [Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 05:18:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 04:18:50 +0000 Subject: [Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 --- Comment #2 from Chris Cormack --- Created attachment 23886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23886&action=edit Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 05:28:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 04:28:00 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 05:28:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 04:28:09 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23874|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 23887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23887&action=edit Bug 7002: fix some invalid superlibrarian permission checks This patch fixes a problem where if a staff user has superlibrarian permissions, but also has module-specific permissions, they are prevent from editing item records that they should be allowed to. To test: [1] Turn on IndependentBranches. [2] Register a superlibrarian staff user at branch A. [3] Give that new account at least one other module-level permission. This cannot be done through the user interface, however, but can be done via SQL: UPDATE borrowers SET flags = 3 WHERE userid = 'XXX'; [4] Log in as that new superlibrarian. [5] Bring up the item details (catalogue/moredetail.pl) page for an item at branch B. Note that there is no 'Edit Item' link. [6] Similarly, try editing that item (cataloging/additem.pl). Note that the edit form forbids you from touching the item. [7] Finally, try editing that item using the Tools | Batch item modification utility. Note that it doesn't allow you to do so. [8] Apply the patch. [9] Repeat steps 5 through 7. This time, the item actions should be allowed. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 06:43:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 05:43:59 +0000 Subject: [Koha-bugs] [Bug 11465] New: Show counts and amounts on OPAC your summary tabs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465 Bug ID: 11465 Summary: Show counts and amounts on OPAC your summary tabs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, when you enter your patron account on the OPAC, you see the "Checked out" tab on the "your summary" page. Currently, to see the number of holds, number of waiting items, number of check outs, and the amount of fines, you have to click on the tabs. However, one of our librarians has pointed out that it might be better to see the numbers at a glance (especially in regards to fines), as patrons might not realize that they need to click through to view counts and amounts. I propose adding the counts and amounts to the tab headings themselves. This way, patrons will know at a glance where they stand. They can then click the tabs for more details. The counts/amounts are already being passed to the template, so it's an easy change. -- My main question is...do I do patches for bootstrap, ccsr, and prog? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 06:53:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 05:53:48 +0000 Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your summary tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 06:53:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 05:53:53 +0000 Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your summary tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465 --- Comment #1 from David Cook --- Created attachment 23888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23888&action=edit Bug 11465 - Show counts and amounts on OPAC your summary tabs This patch adds counts and amounts to the tabs in the 'your summary' page of the OPAC patron account. _TEST PLAN_ Before applying: 1) Choose a test patron 2) Place a few holds 3) Check in one of the holds so that it is waiting for the patron 4) Check out a few items 5) Check out another item that can generate fines (backdate it a few weeks/months) 6) Run fines.pl to generate fines (make sure your finesmode syspref is set to prod) 7) Check your OPAC patron account. 8) Note the tabs "Checked out, Fines, Holds, and Waiting" Apply the patch 1) Switch your OPAC to the bootstrap theme 2) Refresh your browser for the OPAC patron account screen 3) Note that the applicable counts and amounts appear on the tabs -- At the moment, I just have a Bootstrap patch. This is an easy patch though, so I can duplicate to the other themes if necessary... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:56:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 06:56:31 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:56:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 06:56:39 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 --- Comment #8 from Katrin Fischer --- Created attachment 23889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23889&action=edit [PASSED QA] Bug 9654: Missing space between amount and currency symbol in basket group Changed: $total .= $bookseller->{invoiceprice} // 0; Into: $total .= " " . ($bookseller->{invoiceprice} // 0); in order to add a space between the total and currency in the basket group. Revised test plan: 1) Log into staff client 2) Acquisitions 3) Click 'Search' in the 'Manage orders' box. 4) Click '+ New basket' beside a vendor name. 5) Type 'Bug 9654 Test 1' into basket name. 6) Click 'Save' 7) Click 'Add to basket' 8) Click 'From an external source' 9) Type 'Green Eggs and Ham' into the Title text box. 10) Click 'Search' 11) Click 'Order' on any one of the results. 12) Click 'Add Item' in the 'Item' box. 13) Select a Fund from the dropdown in the 'Accounting details' box. 14) Click 'Save' 15) Click 'Close this basket' 16) Click 'Yes, close (Y)' without checking the attach to a basket group. 17) Click the 'Basket groups' tab. 18) Click '+ New basket group' 19) Notice the listing in 'Ungrouped baskets' lacks a space between the number and the currency. (e.g. Total: 0USD) 20) Apply patch (git bz apply 9654) 21) Refresh the page 22) Notice there is now a space. (e.g. Total: 0 USD) 23) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1) Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Works as described, passes all tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:58:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 06:58:23 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23871|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:08:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 07:08:56 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 --- Comment #9 from Katrin Fischer --- There is still a small problem. When all order lines of an order in the basket group are cancelled, it displays: 0 0. As it was 00 before the patch I think it's still an improvement :) That said... I think this is Samuel's first patch - welcome! :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:11:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 07:11:39 +0000 Subject: [Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:11:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 07:11:50 +0000 Subject: [Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23886|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23890&action=edit [SIGNED OFF] Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer Tests now clean the subscription table before running the tests, so that the will always pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 07:16:00 +0000 Subject: [Koha-bugs] [Bug 11398] A typo occurred with occured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:16:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 07:16:09 +0000 Subject: [Koha-bugs] [Bug 11398] A typo occurred with occured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23884|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23891&action=edit [PASSED QA] Bug 11398: A typo occurred with occured This patch cures occured and makes occurred occur. Note that I found them while testing bug 11170. In a follow-up of 11170, I corrected this typo in parcels.tt. This patch touches update22to30.pl and modborrowers.tt Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Fixes a typo in 2 files. http://bugs.koha-community.org/show_bug.cgi?id=11298 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:22:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 07:22:58 +0000 Subject: [Koha-bugs] [Bug 11466] New: Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Bug ID: 11466 Summary: Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org When system preference AdvancedSearchTypes has other values than 'itemtypes', for ex 'itemtypes|loc', itemtypes selection in opac-suggestions.pl is not populated with available itemtypes. This patch fixes the issue by broadening the strict comparison of ($advanced_search_types eg 'itemtypes') #fails 'itemtypes|loc' to ($advanced_search_types =~ 'itemtypes') #succeeds 'itemtypes|loc' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:54:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 07:54:32 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #24 from Katrin Fischer --- Maybe a configurable statistics field and itemtype according to the pref could work too? This would give more flexibility to more uses cases and could be solved outside of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 09:29:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 08:29:03 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 23892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23892&action=edit Bug 11466 - Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' -------------- -- Synopsis -- -------------- When system preference AdvancedSearchTypes has other values than 'itemtypes', for ex 'itemtypes|loc', itemtypes selection in opac-suggestions.pl is not populated with available itemtypes. This patch fixes the issue by broadening the strict comparison of ($advanced_search_types eg 'itemtypes') #fails 'itemtypes|loc' to ($advanced_search_types =~ 'itemtypes') #succeeds 'itemtypes|loc' Unit tests included --------------- -- Test plan -- --------------- REPLICATING THE ISSUE 1. Set system preference AdvancedSearchTypes to itemtypes|loc 2. Go to opac-suggestions.pl and observe Item type dropdown list 2.1. List should have itemtypes available for selection Thanks for testing! You are awesome! gg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 09:29:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 08:29:37 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Olli-Antti Kivilahti --- Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 09:30:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 08:30:14 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Hours Worked| |1.50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 09:38:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 08:38:22 +0000 Subject: [Koha-bugs] [Bug 11467] New: Untranslatable strings in opac-detail.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Bug ID: 11467 Summary: Untranslatable strings in opac-detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Some strings in Javascript are not properly formatted for translation: $(".title").append(''+json.book.title+' by '+json.book.author+''); $("#catalogue_detail_biblio").append(""+json.book.title+" by "+json.book.author+""+json.book.rating+"% rating based on reviews at iDreamBooks.com"); if (arrPagination[i].author) html += "
by " + arrPagination[i].author; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 09:52:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 08:52:00 +0000 Subject: [Koha-bugs] [Bug 10341] Erro installing new language with Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10341 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 10:11:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 09:11:41 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #4 from Fr?d?ric Demians --- Thanks Magnus for your feedback. Point 3 is definitely abnormal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:18:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 12:18:56 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22679|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 23893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23893&action=edit Proposed patch v2 Fixes you points, except 2. Could you retry and describe further what's wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:19:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 12:19:11 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:40:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 14:40:51 +0000 Subject: [Koha-bugs] [Bug 11468] New: Remove use of smartmatch from DateUtils Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468 Bug ID: 11468 Summary: Remove use of smartmatch from DateUtils Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org As the given/when keywords now generate errors in current perl and their future behaviour is subject to change. Remove them from Dateutils which generates errors in all code using it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:56:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 14:56:30 +0000 Subject: [Koha-bugs] [Bug 11468] Remove use of smartmatch from DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 23894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23894&action=edit Proposed Patch To test compile using a perl version 5.18 or greater without patch warnings are generated for given and when in this module. With patch these warnings no longer occur. See perldelta for 5.18 for details on the change in perl's behaviour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:14:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 15:14:49 +0000 Subject: [Koha-bugs] [Bug 11398] A typo occurred with occured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- A pushing of this patch to master has occurred. Thanking of Marcel has now also occurred. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:16:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 15:16:48 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain --- QA preliminary comment : I thought we wanted not to use Moose, and were favoring Class::Accessor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:22:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 15:22:50 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros at gmail | |.com --- Comment #12 from Petter Goks?yr ?sen --- Thank you for this patch! It works great for item titles, but I still get mangled chars if there is a non ascii char in the Patron name; for example if I make a patron status request: REQUEST: 6301220131216 135338 YAOKOHA|AA1|ACBLA|ADpass|BP1|BQ99| RESPONSE 64 01220140102 161959000200000003000000000000AOHUTL|AA1|AEKeyser S?ze|BLY|CQN|CC5|PCADMIN|PIY|AFGreetings from Koha. | "Keyser S?ze" should be "Keyser S?ze" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:30:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 15:30:10 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- Hi Petter, if you find a problem with a patch feel free to set "Failed QA" - this status can be set by everyone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:42:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 15:42:42 +0000 Subject: [Koha-bugs] [Bug 11469] New: Publication date range assumes that years must always be 4 digits Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11469 Bug ID: 11469 Summary: Publication date range assumes that years must always be 4 digits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org This came up in a project where Koha is used for old manuscripts. The publication date range search will not work if a user enters years < 1000: opac-search.pl: 418 # append year limits if they exist 419 if ($params->{'limit-yr'}) { 420 if ($params->{'limit-yr'} =~ /\d{4}-\d{4}/) { 421 my ($yr1,$yr2) = split(/-/, $params->{'limit-yr'}); 422 push @limits, "yr,st-numeric,ge=$yr1 and yr,st-numeric,le=$yr2"; 423 } 424 elsif ($params->{'limit-yr'} =~ /\d{4}/) { 425 push @limits, "yr,st-numeric=$params->{'limit-yr'}"; 426 } 427 else { 428 #FIXME: Should return a error to the user, incorect date format specified 429 } 430 } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:47:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 15:47:57 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Samuel, and congratulations! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:51:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 16:51:43 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #7 from Fr?d?ric Demians --- (In reply to Paul Poulain from comment #6) > QA preliminary comment : I thought we wanted not to use Moose, and were > favoring Class::Accessor You're correct, but I think it's rather for CGI scripts which can't support Moose start-up penalty (will be possible with Plack). It's not a problem for a CLI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:00:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 17:00:25 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:31:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 17:31:18 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Petter Goks?yr ?sen --- Thanks Katrin - I wasn't aware of that. But anyway - please disregard my last comment about Patron name mangled chars. It may be a problem with my setup. I checked again now and it seems my items also have problems with accents in titles. I only checked with with foreign scripts like russian or arabic alphabets - but they appear to work even without this patch. So clearly there is something funky about my testresults. I will investigate again tomorrow! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:01:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 18:01:35 +0000 Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english language fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145 --- Comment #5 from Owen Leonard --- (In reply to michel from comment #4) > testing version 3.12.07 gives the same error when generating > guided reports I have tried generating guided reports in 3.12.x using both French and German templates and have not encountered an error. Please post a detailed description of the steps to reproduce your error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:01:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 18:01:58 +0000 Subject: [Koha-bugs] [Bug 11470] New: Circulation_transfers.t can fail, spuriously Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 Bug ID: 11470 Summary: Circulation_transfers.t can fail, spuriously Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: gmcharlt at gmail.com QA Contact: gmcharlt at gmail.com Circulation_transfers.t creates some branch transfers, then compares them with expected values. However, some of the tests can fail if enough time happens to pass between the creation of the transfers and the comparison, making the datesent values different. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:06:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 18:06:00 +0000 Subject: [Koha-bugs] [Bug 11470] Circulation_transfers.t can fail, spuriously In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:06:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 18:06:08 +0000 Subject: [Koha-bugs] [Bug 11470] Circulation_transfers.t can fail, spuriously In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 --- Comment #1 from Galen Charlton --- Created attachment 23895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23895&action=edit Bug 11470: fix occassional spurious test failure in Circulation_transfers.t This patch makes Circulation_transfers.t no longer be sensitive to the exact time it runs, avoiding spurious test failures due to datesent being a second off between the creation of the test transfer and the comparison. To test: [1] To simulate the failure, add a "sleep(2);" after the "#Test GetTransfers" comment and run prove -v t/db_dependent/Circulation_transfers.t [2] Remove the sleep and apply the patch. [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:02:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 19:02:42 +0000 Subject: [Koha-bugs] [Bug 11471] New: Basket groups display 0 0 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11471 Bug ID: 11471 Summary: Basket groups display 0 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654#c9 I was looking into the function GetBasketsByBasketgroup, and realized that invoiceprice, from aqbooksellers, is not included in the SQL query. Also, invoiceprice should really be invoicingcurrency. But let's deal with the functional problems, before other problems. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:02:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 19:02:50 +0000 Subject: [Koha-bugs] [Bug 11472] New: MARC21 008 plugin should consult leader to set default type of material Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11472 Bug ID: 11472 Summary: MARC21 008 plugin should consult leader to set default type of material Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently, when you use the MARC21 008 plugin to edit field positions, the type of material is always set to BKS, regardless of the actual material type of the record. This means that you always have to change the material type in the fixed field editor to the appropriate value. It would be nice if the type of material were determined by the current leader value. The "material type" in this context is determined by the Leader/06 and Leader/07. The "input conventions" heading near the bottom of http://www.loc.gov/marc/bibliographic/bdleader.html contains a "dependencies" section that designates the appropriate material type for the 008 based on the Leader/06-07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 19:03:22 +0000 Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11471 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 19:03:22 +0000 Subject: [Koha-bugs] [Bug 11471] Basket groups display 0 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11471 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9654 Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:45:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 19:45:15 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #8 from Magnus Enger --- Thanks for fixing a lot of issues with this script! I have another couple of suggestons: In regards to issue 3, the problem was on my side: I was executing the script through koha-shell, like so: $ sudo koha-shell -c "perl misc/cronjobs/sitemap.pl -h" kohadev This meant that the script was actually beig run as the kohadev-koha user (or something like that), which did not have write permission to the dir I was executing the script in. This caused the XML to be written to STDOUT, instead of to a file. Would it be hard to add an (optional) switch for specifying where the output goes? If sitemap.pl is run without any arguments, it will create the sitemap files. I seem to remember we have a convention that scripts run without arguments should print a help message and exit, but it does not seem to be in the coding guidelines... Maybe add a --run parameter to actually run the script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 21:21:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 20:21:40 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Melissa Lefebvre changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melissa at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 21:51:56 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23893|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 23896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23896&action=edit Proposed patch v3 > This meant that the script was actually beig run as the kohadev-koha user > (or something like that), which did not have write permission to the dir I > was executing the script in. This caused the XML to be written to STDOUT, > instead of to a file. I've added a test on this condition: error message is displayed now. > Would it be hard to add an (optional) switch for specifying where the > output goes? Done. > If sitemap.pl is run without any arguments, it will create the sitemap > files. I seem to remember we have a convention that scripts run without > arguments should print a help message and exit, but it does not seem to be > in the coding guidelines... Maybe add a --run parameter to actually run the > script? I'm not sure on this point. For me, a --run is required for scripts which alter database, and when there is a risk of data loose. This isn't the case here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:23:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 22:23:11 +0000 Subject: [Koha-bugs] [Bug 11471] Basket groups display 0 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11471 --- Comment #1 from M. Tompsett --- Created attachment 23897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23897&action=edit Bug 11471 - Basket groups display 0 0 While testing Bug 9654, I clicked "Edit" on the basket group, and got "0 0" displayed on the "Baskets in this group" text area. It had displayed correctly ("0 USD") when I had clicked "Save". TEST PLAN ========= 1) Log into staff client 2) Acquisitions 3) Click 'Search' in the 'Manage orders' box. 4) Click '+ New basket' beside a vendor name. 5) Type 'Test Basket' into basket name. 6) Click 'Save' 7) Click 'Add to basket' 8) Click 'From an external source' 9) Type 'Green Eggs and Ham' into the Title text box. 10) Click 'Search' 11) Click 'Order' on any one of the results. 12) Click 'Add Item' in the 'Item' box. 13) Select a Fund from the dropdown in the 'Accounting details' box. 14) Click 'Save' 15) Click 'Close this basket' 16) Click 'Yes, close (Y)' without checking the attach to a basket group. 17) Click the 'Basket groups' tab. 18) Click '+ New basket group' 19) Notice the listing in 'Ungrouped baskets' lacks a space between the number and the currency. (e.g. Total: 0USD) 20) Click 'Save' 21) Click 'Edit' 22) Notice it displays incorrectly. (e.g. Total: 00) 23) Apply the patch (git bz apply 11471) 24) Refresh the page. 25) Notice it displays less incorrectly. (e.g. Total: 0USD) NOTE: The space issue is fixed in Bug 9654. This can be applied separately from that bug. 26) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:47:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 22:47:50 +0000 Subject: [Koha-bugs] [Bug 11471] Basket groups display 0 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11471 --- Comment #2 from M. Tompsett --- Created attachment 23898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23898&action=edit Bug 11471 - Basket groups display 0 0 While testing Bug 9654, I clicked "Edit" on the basket group, and got "0 0" displayed on the "Baskets in this group" text area. It had displayed correctly ("0 USD") when I had clicked "Save". TEST PLAN ========= 1) Log into staff client 2) Acquisitions 3) Click 'Search' in the 'Manage orders' box. 4) Click '+ New basket' beside a vendor name. 5) Type 'Test Basket' into basket name. 6) Click 'Save' 7) Click 'Add to basket' 8) Click 'From an external source' 9) Type 'Green Eggs and Ham' into the Title text box. 10) Click 'Search' 11) Click 'Order' on any one of the results. 12) Click 'Add Item' in the 'Item' box. 13) Select a Fund from the dropdown in the 'Accounting details' box. 14) Click 'Save' 15) Click 'Close this basket' 16) Click 'Yes, close (Y)' without checking the attach to a basket group. 17) Click the 'Basket groups' tab. 18) Click '+ New basket group' 19) Notice the listing in 'Ungrouped baskets' lacks a space between the number and the currency. (e.g. Total: 0USD) 20) Drag and drop the entry into the 'Baskets in this group' text area. 21) Click 'Save' 22) Click 'Edit' 23) Notice it displays incorrectly. (e.g. Total: 00) 24) Apply the patch (git bz apply 11471) 25) Refresh the page. 26) Notice it displays less incorrectly. (e.g. Total: 0USD) NOTE: The space issue is fixed in Bug 9654. This can be applied separately from that bug. 27) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:50:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 22:50:27 +0000 Subject: [Koha-bugs] [Bug 11471] Basket groups display 0 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11471 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23897|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2014 22:55:03 +0000 Subject: [Koha-bugs] [Bug 11471] Basket groups display 0 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11471 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 02:20:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 01:20:08 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset at hotmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:01:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 06:01:22 +0000 Subject: [Koha-bugs] [Bug 11473] New: View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Bug ID: 11473 Summary: View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org 1) Malformed conditionals Currently, the majority of "viewlog.tt" is ignored, because we haven't formed the conditionals correctly. (e.g. Using 'module' when we should be using 'loopro.module' [or 'loopro.MODULENAME' like 'loopro.CIRCULATION'], 'info' instead of 'loopro.info', etc.) This means that we always get the raw "loopro.object", which is either a borrowernumber, biblionumber, itemnumber, subscriptionid, or authid, with absolutely no qualifier at all. *SOLUTION* Alas, the solution requires a few systematic changes. Detecting an object as a 'borrowernumber' is easy, since MEMBERS, CIRCULATION, and FINES always use it as its object. Same goes for 'subscriptionid' for SERIALS and 'authid' for AUTHORITIES. For these cases, we just need to fix the variables called in the conditions. However, unfortunately, CATALOGUING sometimes uses biblionumber and sometimes uses itemnumber as its object. This causes the following problem... 2) Conditions in viewlog.pl and viewlog.tt do not correctly differentiate items and biblios. There are conditions that check to see if the 'info' column says 'item'. However, this has erratic results, because 'item' is only logged for item adds and deletions - not modifications. (Authorities also only track 'authority' for additions and deletions - not modifications.) 'biblio' is only tracked for biblio additions. Deletions have no info, while modifications include the record content. In viewlog.tt, logs without an 'info' of 'item' will be labelled and linked as 'biblio'. That means that all item modifications will be treated as biblios and not items. *SOLUTION* Change logaction to prepend the info column with "biblio" for all biblio transactions and "item" for all item transactions. Then, check for the applicable substring in viewlog.pl and viewlog.tt to determine how to link and label the number. For legacy data, have a third option that doesn't label/link the object. Just have the raw number (as we currently do). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 09:30:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 08:30:31 +0000 Subject: [Koha-bugs] [Bug 11384] Koha should not use "ctid" as a column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11384 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2. (created version 3.14.01.002) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 09:35:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 08:35:45 +0000 Subject: [Koha-bugs] [Bug 11391] suggestions.suggesteddate has a problematic default value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11391 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Trivial patch --- Comment #9 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2. (created version 3.14.01.003) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 09:50:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 08:50:28 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #23 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2. (created version 3.14.01.004) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 10:01:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 09:01:25 +0000 Subject: [Koha-bugs] [Bug 9940] Add a new index for original language of document In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9940 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 10:04:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 09:04:17 +0000 Subject: [Koha-bugs] [Bug 10834] Add Sort 1 and Sort 2 to list of searchable patron fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10834 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 10:06:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 09:06:59 +0000 Subject: [Koha-bugs] [Bug 11004] Make xmlControlfield.js use the marcflavour syspref to look for XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 10:11:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 09:11:07 +0000 Subject: [Koha-bugs] [Bug 11338] items that are captured for holds can be deleted without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11338 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 11:46:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 10:46:22 +0000 Subject: [Koha-bugs] [Bug 11474] New: Remove experimental given/when from C4::Utils::Datatables Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Bug ID: 11474 Summary: Remove experimental given/when from C4::Utils::Datatables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org In Perl 5.18 compile time errors are generated because of use of given and when keywords -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 11:56:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 10:56:30 +0000 Subject: [Koha-bugs] [Bug 11474] Remove experimental given/when from C4::Utils::Datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 23899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23899&action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:32:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 11:32:25 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:52:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 11:52:40 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #42 from Martin Renvoize --- I've now also tested this with packages.. everything goes to where one would expect now. Perfect.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:44:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 12:44:42 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22815|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 23900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23900&action=edit Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - defined a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW + 3 days * checkout B2 to P2 with a due date = NOW + 10 days * checkout B3 to P3 with a due date = NOW + 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 13:32:32 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20820|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 23901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23901&action=edit Bug 10833: Multi transport types for advanced notices Test plan: - Choose 2 patrons P1 and P2 - Edit "Patron messaging preferences" and check SMS + email with 2 days in advance for P1 check email with 5 days in advance for P2 - defined a message for the letter code PREDUE for sms and email (tools/letters.pl). - select 2 barcodes (B1, B2). * checkout B1 to P1 with a due date = NOW - 2 days * checkout B2 to P2 with a due date = NOW - 5 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/advance_notices.pl -c - retry the previous sql query, you should have X + 3 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code PREDUE 1 message for P2, email and the letter code PREDUE Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:33:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 13:33:24 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 23902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23902&action=edit Bug 10833: Enhanced a warning message to include the message transport type in the message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:43:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 13:43:30 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:43:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 13:43:59 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:58:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 13:58:41 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olli-antti.kivilahti at jns.fi --- Comment #7 from Olli-Antti Kivilahti --- Sorry for not getting back at these earlier, but here's one more for you! Applying: Bug 10845: Multi transport types for holds fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10845: Multi transport types for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 13:59:59 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #45 from Olli-Antti Kivilahti --- Works well here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:58:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 14:58:58 +0000 Subject: [Koha-bugs] [Bug 11475] New: Batch modification process ends with broken link Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Bug ID: 11475 Summary: Batch modification process ends with broken link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org As reported on the koha-devel list: --- 1- First we search for records with multiple items (books or serials, does not matter) 2- We open this record we found with multiple items for editing 3- We chose "Edit items in batch" option from the "Edit" menu 4- We make corrections on the fields under the "Edit item" (For example we change the collection code as "fiction") 5- We save this using "Save button" at the bottom, after we are done. 6- Just after we save, there will be a button named "Done" available just under the page, and when we click on "Done" we encounter the Error screen. --- The "Done" link points to /cgi-bin/koha/tools/CATALOGUING -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:36:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 15:36:29 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Mathieu! I note that the f7-02 index is probably useless -- the MARC21 007/02 is undefined for all material categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:56:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 15:56:48 +0000 Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master, along with a regression test. Thanks, Joy! I note that a potential follow-up would be to take the 264 indicators into account, in order to select the correct one if the 264 is repeated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:21:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 18:21:05 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:45:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2014 20:45:36 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 10:58:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2014 09:58:09 +0000 Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english language fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145 --- Comment #6 from michel --- is that ok if i send you a database via mail ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 11:31:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2014 10:31:31 +0000 Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english language fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145 --- Comment #7 from Katrin Fischer --- I think it's unlikely that it's something in your configuration or data cuasing this. Could you give a step by step? Maybe it's something in the translations causing this. Could you check it also happens for you when using another language (maybe German)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:28:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2014 23:28:42 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 01:46:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 00:46:24 +0000 Subject: [Koha-bugs] [Bug 11470] Circulation_transfers.t can fail, spuriously In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 01:46:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 00:46:28 +0000 Subject: [Koha-bugs] [Bug 11470] Circulation_transfers.t can fail, spuriously In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23895|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23903&action=edit Bug 11470: fix occassional spurious test failure in Circulation_transfers.t This patch makes Circulation_transfers.t no longer be sensitive to the exact time it runs, avoiding spurious test failures due to datesent being a second off between the creation of the test transfer and the comparison. To test: [1] To simulate the failure, add a "sleep(2);" after the "#Test GetTransfers" comment and run prove -v t/db_dependent/Circulation_transfers.t [2] Remove the sleep and apply the patch. [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 07:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 06:47:08 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 JaTara Barnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30 at gmail.com --- Comment #1 from JaTara Barnes --- Created attachment 23904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23904&action=edit Implements syspref for SCO receipt printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 07:47:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 06:47:14 +0000 Subject: [Koha-bugs] [Bug 11468] Remove use of smartmatch from DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 07:47:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 06:47:17 +0000 Subject: [Koha-bugs] [Bug 11468] Remove use of smartmatch from DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23894|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23905&action=edit Bug 11468 Remove given when from Koha::Dateutils given and when give warnings due to their experimental status as of perl 5.18. Replace the construct with an if/elsif to avoid the keywords Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 08:57:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 07:57:06 +0000 Subject: [Koha-bugs] [Bug 11474] Remove experimental given/when from C4::Utils::Datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 08:57:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 07:57:09 +0000 Subject: [Koha-bugs] [Bug 11474] Remove experimental given/when from C4::Utils::Datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23899|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23906&action=edit Bug 11474: Remove errors caused by use of switch Have replaced a switch statement by an if so we do not get warnings on compilation Note the perldoc for the subroutine was not correct code was not testing that paramater equalled the values but that it contained them. Have amended accordingly Have documented behaviour in case parameter contains neither value. subroutine does not appear to me used elsewhere in codebase Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:02:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 21:02:03 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23887|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 23907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23907&action=edit [PASSED QA] Bug 7002: fix some invalid superlibrarian permission checks This patch fixes a problem where if a staff user has superlibrarian permissions, but also has module-specific permissions, they are prevent from editing item records that they should be allowed to. To test: [1] Turn on IndependentBranches. [2] Register a superlibrarian staff user at branch A. [3] Give that new account at least one other module-level permission. This cannot be done through the user interface, however, but can be done via SQL: UPDATE borrowers SET flags = 3 WHERE userid = 'XXX'; [4] Log in as that new superlibrarian. [5] Bring up the item details (catalogue/moredetail.pl) page for an item at branch B. Note that there is no 'Edit Item' link. [6] Similarly, try editing that item (cataloging/additem.pl). Note that the edit form forbids you from touching the item. [7] Finally, try editing that item using the Tools | Batch item modification utility. Note that it doesn't allow you to do so. [8] Apply the patch. [9] Repeat steps 5 through 7. This time, the item actions should be allowed. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, passes QA script and test suite. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:01:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 21:01:59 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:10:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 21:10:12 +0000 Subject: [Koha-bugs] [Bug 11470] Circulation_transfers.t can fail, spuriously In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 --- Comment #3 from Katrin Fischer --- Created attachment 23908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23908&action=edit [PASSED QA] Bug 11470: fix occassional spurious test failure in Circulation_transfers.t This patch makes Circulation_transfers.t no longer be sensitive to the exact time it runs, avoiding spurious test failures due to datesent being a second off between the creation of the test transfer and the comparison. To test: [1] To simulate the failure, add a "sleep(2);" after the "#Test GetTransfers" comment and run prove -v t/db_dependent/Circulation_transfers.t [2] Remove the sleep and apply the patch. [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:10:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 21:10:40 +0000 Subject: [Koha-bugs] [Bug 11470] Circulation_transfers.t can fail, spuriously In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23903|0 |1 is obsolete| | Attachment #23908|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 23909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23909&action=edit [PASSED QA] Bug 11470: fix occassional spurious test failure in Circulation_transfers.t This patch makes Circulation_transfers.t no longer be sensitive to the exact time it runs, avoiding spurious test failures due to datesent being a second off between the creation of the test transfer and the comparison. To test: [1] To simulate the failure, add a "sleep(2);" after the "#Test GetTransfers" comment and run prove -v t/db_dependent/Circulation_transfers.t [2] Remove the sleep and apply the patch. [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 21:10:37 +0000 Subject: [Koha-bugs] [Bug 11470] Circulation_transfers.t can fail, spuriously In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 21:30:27 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:30:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 21:30:30 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23881|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 23910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23910&action=edit [PASSED QA] Bug 11342 - Error with opac self registration if BorrowersTitles is empty If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches". This patch also fixes a minor string capitalization issue. Test Plan: 1) Enable OPAC self registration 2) Set the system preference BorrowersTitles to be empty 3) View the self registration page 4) Note the lack of branches in the home library pulldown 5) Apply this patch 6) Note the branches now display in the pulldown Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Tested in bootstrap and prog OPAC, with BorrowersTitle configured and emptied. Passes all tests and QA script. Note: The titles pull down has 2 empty entries in master with and without the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:31:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 21:31:12 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:05:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:05:48 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:05:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:05:51 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23880|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 23911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23911&action=edit [PASSED QA] Bug 11316 - plugin icon missing tooltip in addbiblio.pl By adding: title=\"Tag editor\" into the HTML generated in addbiblio, a tooltip displaying 'Tag editor' appears when the moust is hovered over the plugin icon. Test Plan: 1) Log into Staff client 2) Click the 'Search the catalog' tab 3) Type something which will generate results 4) Click the title of a result 5) Click the 'Edit' button 6) Scroll down and click the 'Edit Record' 7) Look through the various tabs and notice that all the plugin icons have no tooltip. 8) Apply the patch 9) Refresh the page 10) All the plugin icons should have the tooltip text of 'Tag editor'. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Adds a title attribute. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:17:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:17:40 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Created attachment 23912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23912&action=edit screenshot of login page in Chromium I was about to pass it, as I like the idea, but it doesn't work very well with the limited width of the login box (see screenshot). In Firefox "different user" is on a new line for me. The screenshot is taken in Chromium. In German the text would even get a bit longer, if you translated it directly. Maybe center both buttons on their own line? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:17:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:17:49 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:18:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:18:39 +0000 Subject: [Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:20:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:20:15 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |karamqubsi at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:31:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:31:31 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |oleonard at myacpl.org --- Comment #4 from Katrin Fischer --- This works nicely, but not sure if it touches the necessary files. I see there is also /koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.css. Adding Owen in cc as he will know and I hope for some hints :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:35:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:35:14 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #16 from Katrin Fischer --- I'd like to ask the library who reported this problem to take a look as I think that would be the best way to find out if the proposed solution works. I noticed while testing that an invalid date will somehow automatically be 'corrected'. I am not sure if this will cause problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:50:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:50:29 +0000 Subject: [Koha-bugs] [Bug 11474] Remove experimental given/when from C4::Utils::Datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:50:32 +0000 Subject: [Koha-bugs] [Bug 11474] Remove experimental given/when from C4::Utils::Datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23906|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23913&action=edit [PASSED QA] Bug 11474: Remove errors caused by use of switch Have replaced a switch statement by an if so we do not get warnings on compilation Note the perldoc for the subroutine was not correct code was not testing that paramater equalled the values but that it contained them. Have amended accordingly Have documented behaviour in case parameter contains neither value. subroutine does not appear to me used elsewhere in codebase Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script, especially t/DateUtils.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:55:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:55:53 +0000 Subject: [Koha-bugs] [Bug 11468] Remove use of smartmatch from DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:55:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2014 22:55:56 +0000 Subject: [Koha-bugs] [Bug 11468] Remove use of smartmatch from DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23905|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23914&action=edit [PASSED QA] Bug 11468 Remove given when from Koha::Dateutils given and when give warnings due to their experimental status as of perl 5.18. Replace the construct with an if/elsif to avoid the keywords Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script, especially t/DateUtils.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 02:08:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 01:08:37 +0000 Subject: [Koha-bugs] [Bug 11477] New: Add names for librarian and borrowers in the logs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Bug ID: 11477 Summary: Add names for librarian and borrowers in the logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, borrowernumber is shown without any other information in the logs. One of our libraries has pointed out that it would be much more useful if they saw the firstname/lastname of the librarian performing tasks and the users connected to those tasks. Seems reasonable to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 02:11:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 01:11:11 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 JaTara Barnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from JaTara Barnes --- Test Case: 1. Log into self-check as normal. 2. Click the "Finish" button. 3. Notice that receipt dialog pops up. 4. Apply patch. 5. Run updatedatabase.pl 6. Set the SelfCheckReceiptPrompt syspref to "Don't show" 6. Log into self-check. 7. Click the "Finish" button. 8. Verify that the receipt dialog does NOT pop up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 02:18:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 01:18:15 +0000 Subject: [Koha-bugs] [Bug 3335] Ability to create lists of items with title/call number and save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3335 JaTara Barnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30 at gmail.com --- Comment #2 from JaTara Barnes --- As of Jan. 2014, this is something that we still need. Once a month, I get a request from one of our librarians to add this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 02:18:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 01:18:28 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11477 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 02:18:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 01:18:28 +0000 Subject: [Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11473 Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:03:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:03:42 +0000 Subject: [Koha-bugs] [Bug 9871] Quiet warns when logging into Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |mtompset at hotmail.com Resolution|--- |DUPLICATE --- Comment #2 from M. Tompsett --- Oops! At least the created duplicate is fixed and pushed. :) *** This bug has been marked as a duplicate of bug 11077 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:03:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:03:42 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #55 from M. Tompsett --- *** Bug 9871 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:10:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:10:45 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:10:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:10:49 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 --- Comment #1 from David Cook --- Created attachment 23915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23915&action=edit Bug 11473 - Fix log viewer template conditions This patch adds the 'loopro' key to the 'module' value, so that conditions are actually triggered in the template logic. (Note: loopro.CIRCULATION is valid, but I changed it for the sake of consistency across the different conditions.) This patch also adds substr checks to the 'info' column when using the cataloguing module. This will check for 'item' and 'biblio', so that the appropriate label qualifer can be shown in the log viewer. If either term is absent, the unqualified number will be shown instead (this will be the majority of action logs at this point). _TEST PLAN_ Before applying: 1) Access log viewer from Tools (or wherever really) 2) Look up logs for circulation, patrons, cataloguing, serial, authorities, etc. 3) Note that the "Object" will always just be a number without qualification. After applying the patch: 1) Look at those same logs 2) Note that the object number for borrowers will usually be prefaced by 'member' (notwithstanding FINES which aren't taken into account in this template yet); new bibs and new items should say 'Item X' or 'Biblio X'. Serials should have a link. Authorities should have a link and an 'auth' preface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:12:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:12:19 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 --- Comment #2 from David Cook --- Created attachment 23916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23916&action=edit Bug 11473 - Remove boilerplate in log viewer template This patch eliminates unnecessary conditions and boilerplate. _TEST PLAN_ Apply the patch. 1) Try viewing logs for circulation, patrons, fines, cataloguines, serials, authorities, etc. 2) Note that everything should look exactly the same as before, with one exception: FINES 3) Fines will now show "member X" for the user associated with the fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:12:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:12:49 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 --- Comment #3 from David Cook --- Created attachment 23917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23917&action=edit Bug 11473 - Improve wording in log viewer template This patch capitalizes 'member' and 'biblio' as object labels in the log viewer. It also adds a "Subscription" label, and changes "auth" to "Authority". _TEST PLAN_ Before applying patch: 1) View logs for patrons, new biblio, serials, and authorities. Apply the patch: 1) Notice the capitalization and new/modified labels. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:13:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:13:20 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 --- Comment #4 from David Cook --- Created attachment 23918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23918&action=edit Bug 11473 - add 'biblio' and 'item' to cataloguing logging info This patch adds the words 'biblio' and 'item' to the 'info' of the cataloguing logs which were missing them (such as biblio delete, biblio mod, item mod, upload cover image). This patch also adds 'authority' for authority mod. _TEST PLAN_ Before applying: 1) Create/view mods for items, biblios, and authorities. 2) Create/view biblio deletion 3) Create/view upload cover image log 4) Note that none of these contain the words 'biblio','item',or 'authority' in their "Info" columns. Apply patch. 5) Repeat steps 1-3 6) Note that the new logs contain 'biblio','item', and 'authority' in their "Info" column, while the past ones don't. 7) Note also that 'biblio' and 'item' will have 'Biblio' and 'Item' appear in their "Object" column for the new logs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:22:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:22:57 +0000 Subject: [Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:23:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:23:00 +0000 Subject: [Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 --- Comment #1 from David Cook --- Created attachment 23919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23919&action=edit Bug 11477 - Add names for librarian and borrowers in the logs This patch adds the first name and surname of the librarian and the user involved in a transaction log, if available. If neither the firstname or the surname is available, then the 'object' number will be prefaced with the 'Member' qualifier. _TEST PLAN_ 0) This patch depends on Bug 11473, so you must apply it first Before applying this patch (11477): 1) View the logs. 2) Note that the Librarian column just has a number 3) Note that the Object column will just say Member X (where X is a number), in the circulation, fines, and patron/member modules. Apply the patch. 4) Reload the logs (you don't need to make new ones) 5) Note that the Librarian and Object columns mentioned above now have firstname and surname appearing (where available) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:23:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:23:53 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 05:42:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 04:42:45 +0000 Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Samuel Crosby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scrosby000 at gmail.com --- Comment #1 from Samuel Crosby --- Created attachment 23920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23920&action=edit Potential bug fix Just put the receive button creation in an if statement. Check the commit message for testing instructions. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:08:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 05:08:45 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Samuel Crosby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scrosby000 at gmail.com --- Comment #1 from Samuel Crosby --- Created attachment 23921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23921&action=edit Moved add barcode to be focus I've moved the barcode interface to the top of the page. I'm not sure if the barcode interface should go there though. Maybe it can be redirected to focus at the bottom of the page if it previously has just entered a barcode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:50:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 05:50:18 +0000 Subject: [Koha-bugs] [Bug 11468] Remove use of smartmatch from DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 05:50:41 +0000 Subject: [Koha-bugs] [Bug 11474] Remove experimental given/when from C4::Utils::Datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:50:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 05:50:57 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:51:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 05:51:16 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:51:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 05:51:35 +0000 Subject: [Koha-bugs] [Bug 11470] Circulation_transfers.t can fail, spuriously In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11470 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 07:04:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 06:04:38 +0000 Subject: [Koha-bugs] [Bug 2327] Performing a z39.50 search on an ISBN causes Koha to throw an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2327 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Just ran into this issue again while searching for an ISBN with a III database over z39.50. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 09:21:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 08:21:14 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #3 from Chris Cormack --- Comment on attachment 23904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23904 Implements syspref for SCO receipt printing Review of attachment 23904: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11415&attachment=23904) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +7886,5 @@ > } > > +$DBversion = "3.15.00.XXX"; > +if(CheckVersion($DBversion)) { > + $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('SelfCheckReceiptPrompt', '0', 'NULL', 'If ON, print receipt dialog pops up when self checkout is finished.', 'YesNo');"); This all looks good, and works well. Our rule of thumb though is to not change behaviour. This syspref is set off, so once you upgrade you will no longer get the prompt showing up. I think it should go into the update as on, so the behaviour doesn't change on upgrade, people can switch it off. It can go in off for new installs though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 09:32:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 08:32:57 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23915|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 23922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23922&action=edit Bug 11473 - Fix log viewer template conditions This patch adds the 'loopro' key to the 'module' value, so that conditions are actually triggered in the template logic. (Note: loopro.CIRCULATION is valid, but I changed it for the sake of consistency across the different conditions.) This patch also adds substr checks to the 'info' column when using the cataloguing module. This will check for 'item' and 'biblio', so that the appropriate label qualifer can be shown in the log viewer. If either term is absent, the unqualified number will be shown instead (this will be the majority of action logs at this point). _TEST PLAN_ Before applying: 1) Access log viewer from Tools (or wherever really) 2) Look up logs for circulation, patrons, cataloguing, serial, authorities, etc. 3) Note that the "Object" will always just be a number without qualification. After applying the patch: 1) Look at those same logs 2) Note that the object number for borrowers will usually be prefaced by 'member' (notwithstanding FINES which aren't taken into account in this template yet); new bibs and new items should say 'Item X' or 'Biblio X'. Serials should have a link. Authorities should have a link and an 'auth' preface. Signed-off-by: Chris Cormack Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 09:33:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 08:33:09 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23916|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 23923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23923&action=edit Bug 11473 - Remove boilerplate in log viewer template This patch eliminates unnecessary conditions and boilerplate. _TEST PLAN_ Apply the patch. 1) Try viewing logs for circulation, patrons, fines, cataloguines, serials, authorities, etc. 2) Note that everything should look exactly the same as before, with one exception: FINES 3) Fines will now show "member X" for the user associated with the fine. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 09:33:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 08:33:24 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23917|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 23924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23924&action=edit Bug 11473 - Improve wording in log viewer template This patch capitalizes 'member' and 'biblio' as object labels in the log viewer. It also adds a "Subscription" label, and changes "auth" to "Authority". _TEST PLAN_ Before applying patch: 1) View logs for patrons, new biblio, serials, and authorities. Apply the patch: 1) Notice the capitalization and new/modified labels. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 09:33:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 08:33:36 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 09:33:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 08:33:41 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23918|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 23925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23925&action=edit Bug 11473 - add 'biblio' and 'item' to cataloguing logging info This patch adds the words 'biblio' and 'item' to the 'info' of the cataloguing logs which were missing them (such as biblio delete, biblio mod, item mod, upload cover image). This patch also adds 'authority' for authority mod. _TEST PLAN_ Before applying: 1) Create/view mods for items, biblios, and authorities. 2) Create/view biblio deletion 3) Create/view upload cover image log 4) Note that none of these contain the words 'biblio','item',or 'authority' in their "Info" columns. Apply patch. 5) Repeat steps 1-3 6) Note that the new logs contain 'biblio','item', and 'authority' in their "Info" column, while the past ones don't. 7) Note also that 'biblio' and 'item' will have 'Biblio' and 'Item' appear in their "Object" column for the new logs Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 09:43:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 08:43:20 +0000 Subject: [Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 09:43:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 08:43:23 +0000 Subject: [Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23919|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23926&action=edit Bug 11477 - Add names for librarian and borrowers in the logs This patch adds the first name and surname of the librarian and the user involved in a transaction log, if available. If neither the firstname or the surname is available, then the 'object' number will be prefaced with the 'Member' qualifier. _TEST PLAN_ 0) This patch depends on Bug 11473, so you must apply it first Before applying this patch (11477): 1) View the logs. 2) Note that the Librarian column just has a number 3) Note that the Object column will just say Member X (where X is a number), in the circulation, fines, and patron/member modules. Apply the patch. 4) Reload the logs (you don't need to make new ones) 5) Note that the Librarian and Object columns mentioned above now have firstname and surname appearing (where available) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 09:07:29 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #17 from Julian Maurice --- I was not able to reproduce the problem, but I suspect that the session is not properly deleted when it should. The following patch ensure that by flushing session after each call to $session->delete(). I hope this will fix the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:07:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 09:07:45 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #18 from Julian Maurice --- Created attachment 23927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23927&action=edit Bug 10952: Always flush session after deletion This is recommended in CGI::Session documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:07:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 09:07:57 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:26:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 09:26:54 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:26:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 09:26:58 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22135|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 23928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23928&action=edit [PASSED QA] Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each enabled instance. Enabling/disabling the use of the indexer is handled using a new(ly introduced) /etc/default/koha-common config file that can be used for other stuff too, and is the Debian way of handling init scripts control variables[1]. Also provide command line tools to manage the running indexer daemons for your instances. Long: Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute incremental reindexing, a requirement from our librarians.[2] Using the indexer daemon should remain "experimental" so is disabled by default. To enable the use of the indexer the user has to tweak the /etc/default/koha-common config file (introduced by this patch). Specifically the USE_INDEXER_DAEMON variable, which is clearly explained in the file. Update frecquency defaults to 30 sec, and can be changed by tweaking the /etc/default/koha-common config file too. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3], but could be easily adjusted to use another if we got a new one (SolR?). As Robin proposed it checks for availability of the relevant files before trying to spawn the daemon. If there's something I could change to make this patches better just let me know. Note: there was a problem Robin found regarding the spawned processes forgetting the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version with the inclusion of the 'export' keyword for the relevant variables. Edit: fixed koha-create to call the koha-indexer script instead, and added -q to make koha-inxeder quiet (useful for the init script). Regards To+ [1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html [2] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [3] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:31:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 09:31:18 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #42 from Martin Renvoize --- All works as expected, no regressions created. I didn't get it fully working with the new daemon mode rebuild_zebra.pl, however I don't think that in itself should fail the patch. The scaffolding to add support for it is all there, but koha-indexer may need some re-factoring to support the different switches that rebuild_zebra contains compared to Tamils indexer. (I'd actually rpefer to see rebuild_zebra become close to Tamils indexer personally). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:41:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 09:41:18 +0000 Subject: [Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 --- Comment #7 from Katrin Fischer --- Thanks Galen :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 11:58:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 10:58:54 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 --- Comment #10 from Jonathan Druart --- > This patch is an improvement, but there is still more work to do. > > - Filters are not cumulative, but when another filter is selected > the first filter is not reset. > - It's not possible to combine > 2 or more filters. Will be possible with bug 10855 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:50:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 11:50:28 +0000 Subject: [Koha-bugs] [Bug 11478] New: Remove experimental given/when from Koha::SimpleMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478 Bug ID: 11478 Summary: Remove experimental given/when from Koha::SimpleMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org As of perl 5.18 the given when keywords are marked as experimental and produce compile time errors. Avoid the unnecessary error by reverting to an if/else -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:00:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:00:11 +0000 Subject: [Koha-bugs] [Bug 11478] Remove experimental given/when from Koha::SimpleMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 23929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23929&action=edit Proposed Patch With patch applied module will not issue errors because of use of experimental features in testsuite with perl >= 5.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:05:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:05:55 +0000 Subject: [Koha-bugs] [Bug 11479] New: Remove experimental given/when from C4::MarcModificationTemplates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Bug ID: 11479 Summary: Remove experimental given/when from C4::MarcModificationTemplates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Compile time warnings are issued by perl 5.18 and greater over use of experimental keywords given and when as behaviour may change in next release. Replace usage of these constructs with core syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:09:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:09:41 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #31 from Jonathan Druart --- Galen, commit 543e1dc6731d4a26b777223920bfe4037e7546dd introduces a call to a nonexistent routine: =head2 ModReserve @@ -1184,7 +1181,7 @@ sub ModReserveFill { # now fix the priority on the others (if the priority wasn't # already sorted!).... unless ( $priority == 0 ) { - _FixPriority({ reserve_id => $reserve_id }); + FixPriority({ reserve_id => $reserve_id }); } } The FixPriority routine does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:15:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:15:30 +0000 Subject: [Koha-bugs] [Bug 11479] Remove experimental given/when from C4::MarcModificationTemplates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 23930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23930&action=edit Proposed patch With patch applied test suite no longer reports 'experimental' warnings from this module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:44:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:44:18 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22685|0 |1 is obsolete| | --- Comment #57 from M. de Rooy --- Created attachment 23931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23931&action=edit Bug 9788: Improvements when calling GetReservesFromItemnumber Description: GetReservesFromItemnumber also returns waiting date. Simplifies some code. Improves item status display on catalogue detail, when placing a hold at opac-reserve and in staff, and on transfers to receive form. This patch builds on work from reports 9367 and 9761. Test plan: Place a future next-av. hold (enable future holds prefs), say 2 days ahead. Check item status on catalogue detail. Nothing to see. Enable ConfirmFutureHolds by inserting a number of days, say 2. Confirm earlier hold by checking it in. Look at item status again on detail. Switch to other opac user. Try to place a hold again. Check item status with item level hold info. Try to place hold in staff, check item level status. Make a transfer for that item. Switch branch. Look at transfers to receive. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:44:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:44:27 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22686|0 |1 is obsolete| | --- Comment #58 from M. de Rooy --- Created attachment 23932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23932&action=edit Bug 9788: Followup removing the alldates parameter Before bug 9788 the alldates parameter of GetReservesFromItemnumber was actually not used in the codebase. The first patch of bug 9788 did change that and passed true by default. But a closer look revealed that we do not really need it. The parameter is removed by this patch; the SQL statement is slightly adjusted: if reservedate<=now or a waitingdate is filled for the requested itemnumber, GetReservesFromItemnumber will return the reserve. This includes so-called future waits: a future hold that has been confirmed ahead of time with pref ConfirmFutureHolds > 0 days. Note that future item-level holds are not really interesting to return; this just corresponds to original behavior. Future next-available holds are not in view at all; they do not contain an item number. Test plan: Actually, the test plan of the first patch is valid. But for completeness I repeat it here: [1] Enable future holds and set ConfirmFutureHolds to 2 days. [2] Place a future next-available hold for 2 days ahead. [3] Check item status on catalogue detail. Available? That is fine. [4] Confirm the future hold by checking it in. ('future wait') [5] Look at item status again on catalogue detail. Must be Waiting now. [6] Switch to OPAC and login as another opac user. Goto Place a hold. [7] Check item status with item level hold info. Is it waiting? [8] Try to place hold in staff, check item level status again. Waiting? [9] Make a transfer for the item. Switch branch. Check hold status on Transfers to receive. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:44:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:44:33 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22687|0 |1 is obsolete| | --- Comment #59 from M. de Rooy --- Created attachment 23933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23933&action=edit Bug 9788: Followup for expirationdate in Letter.pm Pasting comment from the Bugzilla report: Looking bit longer at this code, it is kind of strange to find it there in the first place. Adding maxpickupdelay in Letters.pm should not be there, but it is.. Also this date is not used normally in the default HOLD Available for Pickup notice (that we are generating in this case). And if it would be undef, the expiration date should imo be empty instead of today+0. (before adding maxreservespickupdelay, you should test the allowexpire pref first) So it is an (invisible) bug on its own. Test plan: See former patch. Kyle just discovered this bug, apparently by deleting the maxpickupdelay pref.. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:44:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:44:38 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22688|0 |1 is obsolete| | --- Comment #60 from M. de Rooy --- Created attachment 23934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23934&action=edit Bug 9788: Unit tests for changed routine GetReservesFromItemnumber Adds three tests to Reserves.t for GetReservesFromItemnumber. We test if this routine does not return a future next available hold, a future item level hold. And if it does return a future wait (that is: a confirmed future hold, using ConfirmFutureHolds). Note that Holds.t does also contains some basic tests for this routine, but the additional tests seem to better located in the direct context of tests for bug 9761 for ConfirmFutureHolds. Test plan: Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t. Verify if both tests do not fail. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:44:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:44:43 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22693|0 |1 is obsolete| | --- Comment #61 from M. de Rooy --- Created attachment 23935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23935&action=edit Bug 9788: QA followup 1/ CURRENT_DATE is a mysql and should be replaced with CAST(now() AS date). 2/ The date formatting should be done in the template (using the TT plugin). Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:48:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:48:12 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #62 from M. de Rooy --- One of the patches needed a rebase for changes in Reserves.t. Galen: This patch waits for some months already in PQA and was written long before that. Could you explain why this patch cannot be pushed? What should be improved? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:54:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:54:49 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #34 from Katrin Fischer --- I have taken a longer look at this and have been trying to make up my mind. I also looked at the code and did some testing. - I agree that adding one more place that has to be taken into account when trying to anonymize the reading history seems problematic. We already have the information in statistics, action_logs and old_issues. - Choosing to build this on the existing anonymizing scripts would give us more flexibility in the future. Like Galen suggested, it would be possible to keep the "last n borrowers". - There is currently no automatic way to delete this information from items/deleteditems once you choose to deactivate the feature. This worries me a bit. Some general thoughts: When we discussed this kind of problem at work, there was a point made that the data is not useful after a certain amount of time. Can you blame a borrower for any damage you find after accepting the item at the circulation desk or reshelving it after a selfcheck return? As we are only allowed to keep data that is actually needed, it would be good if there was an option to delete after x days. About the code: 1) Database update needs to be '15' and contain the bug number. 2) Diacritics in the card number on the items tab get mangled. 3) I think the syspref description could be improved a bit. I didn't understand at first what was meant by "This setting is independent of opacreadinghistory/AnonymousPatron". I think something like "the data will be stored independent on your settings for..." might be a bit more clear and also it might be good to warn that the data will be kept for older items/issues when turning it off again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:58:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 12:58:27 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23934|0 |1 is obsolete| | --- Comment #63 from M. de Rooy --- Created attachment 23936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23936&action=edit Bug 9788: Unit tests for changed routine GetReservesFromItemnumber Adds three tests to Reserves.t for GetReservesFromItemnumber. We test if this routine does not return a future next available hold, a future item level hold. And if it does return a future wait (that is: a confirmed future hold, using ConfirmFutureHolds). Note that Holds.t does also contains some basic tests for this routine, but the additional tests seem to better located in the direct context of tests for bug 9761 for ConfirmFutureHolds. Test plan: Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t. Verify if both tests do not fail. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:09:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:09:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23643|0 |1 is obsolete| | Attachment #23644|0 |1 is obsolete| | Attachment #23645|0 |1 is obsolete| | Attachment #23646|0 |1 is obsolete| | Attachment #23647|0 |1 is obsolete| | Attachment #23648|0 |1 is obsolete| | Attachment #23649|0 |1 is obsolete| | Attachment #23650|0 |1 is obsolete| | Attachment #23651|0 |1 is obsolete| | Attachment #23652|0 |1 is obsolete| | Attachment #23653|0 |1 is obsolete| | Attachment #23654|0 |1 is obsolete| | Attachment #23655|0 |1 is obsolete| | Attachment #23656|0 |1 is obsolete| | Attachment #23657|0 |1 is obsolete| | --- Comment #116 from Kyle M Hall --- Created attachment 23937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23937&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:23 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #117 from Kyle M Hall --- Created attachment 23938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23938&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:27 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #118 from Kyle M Hall --- Created attachment 23939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23939&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:31 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #119 from Kyle M Hall --- Created attachment 23940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23940&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:35 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #120 from Kyle M Hall --- Created attachment 23941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23941&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:38 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #121 from Kyle M Hall --- Created attachment 23942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23942&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #122 from Kyle M Hall --- Created attachment 23943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23943&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:47 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #123 from Kyle M Hall --- Created attachment 23944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23944&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:52 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #124 from Kyle M Hall --- Created attachment 23945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23945&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #125 from Kyle M Hall --- Created attachment 23946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23946&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:10:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:10:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #126 from Kyle M Hall --- Created attachment 23947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23947&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:11:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:11:04 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #127 from Kyle M Hall --- Created attachment 23948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23948&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:11:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:11:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #128 from Kyle M Hall --- Created attachment 23949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23949&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:11:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:11:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #129 from Kyle M Hall --- Created attachment 23950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23950&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:11:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:11:17 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #130 from Kyle M Hall --- Created attachment 23951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23951&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:11:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:11:47 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:11:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:11:53 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 23952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23952&action=edit Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:12:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:12:39 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:13:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:13:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #131 from Kyle M Hall --- This new patch set fixes the SIP2 issue. (In reply to Larry Baerveldt from comment #115) > Warning, this code seems to break SIP functionality. C4/ILS.pm is looking > for C4/Accounts.pm, but this update removes it. > > Test: > cd C4/SIP > perl -c ILS.pm > > Can't locate C4/Accounts.pm in @INC (@INC contains: /home/koha/kohaclone > /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 > /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 > /usr/local/lib/site_perl .) at ILS/Transaction/FeePayment.pm line 23. > > Please do not signoff until SIP functionality has been restored. > > - Larry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:47:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:47:55 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:47:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 13:47:58 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23641|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 23953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23953&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:00:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 14:00:11 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 14:08:06 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:08:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 14:08:10 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 23954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23954&action=edit Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:19:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 14:19:58 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 --- Comment #8 from Katrin Fischer --- Comment on attachment 22784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22784 Bug 11126 - Make the holds system optionally give precedence to local holds Review of attachment 22784: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11126&attachment=22784) ----------------------------------------------------------------- Ok, starting with a code review :) Looks good so far: - system preferences are added correctly - new feature is off by default - unit tests are provided Only one small issue with one of the comments: ::: C4/Reserves.pm @@ +915,5 @@ > return ( "Waiting", $res, \@reserves ); # Found it > } else { > + # Lazy fetch for borrower and item. We only need to know about the patron and item > + # each and every time if we are using LocalHoldsPriority. This is a great place to > + # leverage the inherent lazy fetching of DBIx::Class. I think DBIx::Class is currently not yet used here, so the comment could be fixed in a follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:21:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 14:21:49 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #9 from Katrin Fischer --- Coninuing testing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:28:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 14:28:09 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #5 from Koha Team Lyon 3 --- Hi Mathieu, I'm not sure that this choice (including or excl) have to be made in the order. In the actual functioning, it's in the vendor page that you can choose if list price or actual cost are with or without tax. It can be extended to remplacement price or budgeted price. ARe tou sure that a vendor have different politics of prices (including tax or not) ? Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:28:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 14:28:20 +0000 Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:24:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:24:53 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23289|0 |1 is obsolete| | Attachment #23290|0 |1 is obsolete| | Attachment #23291|0 |1 is obsolete| | Attachment #23292|0 |1 is obsolete| | Attachment #23293|0 |1 is obsolete| | Attachment #23562|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 23955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23955&action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:25:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:25:02 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #47 from Jonathan Druart --- Created attachment 23956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23956&action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:25:08 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #48 from Jonathan Druart --- Created attachment 23957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23957&action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:25:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:25:14 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #49 from Jonathan Druart --- Created attachment 23958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23958&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:25:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:25:22 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #50 from Jonathan Druart --- Created attachment 23959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23959&action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:25:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:25:28 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #51 from Jonathan Druart --- Created attachment 23960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23960&action=edit Bug 9016: QA Followup Fix tab characters and POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:26:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:26:21 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #52 from Jonathan Druart --- Last patches fix conflicts with commit b753678c3dff4e0fd2fde008b3c43f0796fcfb05 Bug 11208: regression test for failing SMS messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:28:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:28:21 +0000 Subject: [Koha-bugs] [Bug 11342] Error with opac self registration if BorrowersTitles is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11342 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:28:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:28:33 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Jonathan Druart --- Patches apply cleanly with patches from bug 9016 applied. I rebased them (conflicts in a UT file). Could you retry please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:37:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:37:41 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:42:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:42:16 +0000 Subject: [Koha-bugs] [Bug 2327] Performing a z39.50 search on an ISBN causes Koha to throw an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2327 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|WORKSFORME |--- --- Comment #2 from Chris Nighswonger --- Be sure to change the status of a bug which has been closed to reopened if you have a case where the bug manifests. Also, please include exact details on how to reproduce the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:59:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:59:23 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23602|0 |1 is obsolete| | --- Comment #98 from Jonathan Druart --- Created attachment 23961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23961&action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:59:32 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23775|0 |1 is obsolete| | --- Comment #99 from Jonathan Druart --- Created attachment 23962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23962&action=edit Bug 10855: FIX bad conflict merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:59:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:59:40 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23774|0 |1 is obsolete| | --- Comment #100 from Jonathan Druart --- Created attachment 23963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23963&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:59:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 15:59:48 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23601|0 |1 is obsolete| | --- Comment #101 from Jonathan Druart --- Created attachment 23964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23964&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:01:08 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #102 from Jonathan Druart --- (In reply to Paola Rossi from comment #97) > Search) The form in the left column of the page keeps the current search > values only for non-additional fields. Every time the user selects "Search", > the search values currently chosen for the additional searchable fields are > lost or ruined. > In case of category additional fields, the current search values are lost, > reset to "ALL" every time the user selects "Search". > In case of marc additional fields, the current search values are set to a > Hash value every time the user selects "Search". > > So I pass the patch to "Failed QA" status. Arg, stupid mistake, sorry. - [% IF av.authorised_value == additional_field_filters.${field.name} %] + [% IF av.authorised_value == additional_field_filters.${field.name}.value %] This should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:14:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:14:34 +0000 Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english language fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145 --- Comment #8 from michel --- Here are the steps to get the error : >From the "Plus" menu, choose "Bilans et statistiques" Then choose "assistant de rapports", then "construire nouveau". Etape 1/6 : choose "Circulation" then "suivant" Etape 2/6 : choose "Tabulaire" then "suivant" and here i get "software error..." Using the german language works fine. Using koha 3.14 in french also produces the error. On the other hand, if i try to generate a SQL report nothing happens. Steps : >From the "Assistant de rapports" page, click "cr?er ? partir de SQL". Fill in "nom de rapport" and "notes" with "testFR" Leave "type" as "tabulaire" Paste a sql report (i pasted the report previously generated with the german interface : SELECT borrowers.borrowernumber,biblioitems.biblioitemnumber FROM borrowers LEFT JOIN statistics on (statistics.borrowernumber=borrowers.borrowernumber) LEFT JOIN items on (items.itemnumber = statistics.itemnumber) LEFT JOIN biblioitems on (biblioitems.biblioitemnumber = items.biblioitemnumber) ) Click "enregistrer rapport" You get the message "votre rapport a ?t? sauvegard?" ("your report was saved"). Click "rapports sauvegard?s" -->> you get the table with the saved reports, but the report you have just created does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:16:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:16:53 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #28 from Kyle M Hall --- This problem is actually an issue with Koha's transfer implementation, and is not directly related to this feature. (In reply to Olli-Antti Kivilahti from comment #26) > Rotating collections test case. > > In "Tools" -> "Rotating Collections" -> "Add/Remove items": > When adding item barcodes to the collection, the input field > > should become active > automatically so it is easy to add multiple barcodes rapidly without > touching the > mouse or keyboard. > Enter-press is dealt by the barcode reader so automatic form submittal > should be handled > by the barcode reader. > > In "Rotating collections" -> "Transfer Collection": > When the collection is initially transferred, items are set to trasfer > correctly. > When the collection is transferred while items are still being transferred, > the transfer > destination library doesn't change from the original one. > The holding library changes for all items in the collection to the > destination library on > retransfers as well. > This is tricky if a user accidentally places the wrong destination. > When I try to checkin these items to their new retransfer location, I get > the following messages: > -"This item is part of a rotating collection and needs to be transferred to > " > -"Please return Valkoinen ihmissy?j? / to " > -"Print slip or Cancel transfer" > > When I checkin a Item to a arbitrary branch, I get the following messages: > "This item is part of a rotating collection and needs to be transferred to > " > "Please return Valkoinen ihmissy?j? / to " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:18:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:18:54 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Kyle M Hall --- While I agree that we should try to add unit tests, these patches do not add any new perl subroutines. There are many existing modules that do not have unit tests. > Also unit tests are required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:21:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:21:25 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 --- Comment #6 from Jonathan Druart --- Christopher, The patch is consistent with the test plan: you are allow to modify XXX items and to display XXX items on deletion. It is the same behavior as before the patch. But I agree with you, it is not consistent with the syspref description (the description says: number of items to process). I don't have a quick and small patch to provide. What I know it is that the limit is hardcoded and it is not possible to modify more than 1000 items in a batch, which is a real limitation for some libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:21:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:21:28 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #6 from mathieu saby --- (In reply to Koha Team Lyon 3 from comment #5) > Hi Mathieu, > I'm not sure that this choice (including or excl) have to be made in the > order. In the actual functioning, it's in the vendor page that you can > choose if list price or actual cost are with or without tax. It can be > extended to remplacement price or budgeted price. ARe tou sure that a vendor > have different politics of prices (including tax or not) ? > Sonia This patch does not add a new choice on order page, it only displays the information (as defined on the vendor page, like before). I think it can be useful for librarians who are only creating orders (so they don't need to check the vendor's page). Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:31:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:31:05 +0000 Subject: [Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:33:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:33:59 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:34:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:34:02 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23711|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 23965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23965&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:34:14 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #39 from Galen Charlton --- Pushed to master, along with a follow-up that removes a redundant check on singleBranchMode. Thanks, Kyle! This patch does not update the XSLT for the Bootstrap theme, but I think that can be relegated to bug 11310. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:34:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:34:36 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > I like this idea, but I think we want to display the time in some cases - > like for the due date in case of a hourly loan. Yes, you are right. The last patch takes the 2 formats into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:38:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:38:57 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21008|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 23966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23966&action=edit Bug 8836 - Resurrect Rotating Collections Signed-off-by: jmbroust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:39:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:39:02 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21009|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 23967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23967&action=edit Bug 8836 - Resurrect Rotating Collections - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:39:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:39:08 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21010|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall --- Created attachment 23968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23968&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating collections scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:39:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:39:12 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21011|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 23969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23969&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 3 * Fix bad TT Tag * Fix bad sql query * Fix capitalization ( HTML4 ) * Allow a rotating collection's location to keep AutomaticItemReturn from sending it back to the branch of origin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:51:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:51:44 +0000 Subject: [Koha-bugs] [Bug 11480] New: Tests in Output_JSON.t make invalid assumptions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Bug ID: 11480 Summary: Tests in Output_JSON.t make invalid assumptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: colin.campbell at ptfs-europe.com QA Contact: gmcharlt at gmail.com Output_JSON.t fails on current perl release. Tests in Output_JSON.t assume that items in the generated json string will be in a consistent order. Internally, though, they are held in a hash, an unordered container. In perl versions 5.18 and greater the overhaul of of hashing ensures that hash elements are returned in an unpredictable sequence, (which was previously the theory). As a result the tests checking the output should be rewitten not to make assumptions about the order of elements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:53:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:53:04 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23969|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 23970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23970&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 3 * Fix bad TT Tag * Fix bad sql query * Fix capitalization ( HTML4 ) * Allow a rotating collection's location to keep AutomaticItemReturn from sending it back to the branch of origin * Fix bad query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:56:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 16:56:41 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #35 from Kyle M Hall --- Created attachment 23971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23971&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 4 - Autofocus on barcode field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:00:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:00:12 +0000 Subject: [Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:00:16 +0000 Subject: [Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #1 from Galen Charlton --- Created attachment 23972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23972&action=edit Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:03:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:03:36 +0000 Subject: [Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #2 from Galen Charlton --- I think it would be reasonable to consider making the OPAC XSLT stylesheets not be specific to a particular theme, but instead be shared by all of them. Even if that's the final decision, I think it would be a good idea for this patch to be reviewed and pushed, as having the XSLT be identical in the two major themes prior to moving it will make it easier to validate the consolidation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:06:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:06:09 +0000 Subject: [Koha-bugs] [Bug 11480] Tests in Output_JSON.t make invalid assumptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chris at bigballofwax.co.nz |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 23973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23973&action=edit Proposed Patch Without this patch the test script is run with perl 5.18 will fail on 0 to 3 tests. (0 is a hard one to spot!) differing on every run. With this patch the results will be consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:23:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:23:10 +0000 Subject: [Koha-bugs] [Bug 11481] New: new reservation syspref HoldOnlyWhenAllItemsOnLoan Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Bug ID: 11481 Summary: new reservation syspref HoldOnlyWhenAllItemsOnLoan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org This new syspref sets the following behavior about reserves : When enabled, placing hold is possible only if all the items potentially holdable of a record are on loan. By "potentially holdable", we mean these which can be reserved according to circulation rules and have neither notforloan, withdrawn, lost, nor damaged status. Test Plan : 1) Enable RequestOnOpac and HoldOnlyWhenAllItemsOnLoan sysprefs 2) Choose one borrower (patron1) to place holds : get his category, login and pasword. 3) Go to Administration/Circulation and fine rules. 4) in the ALL libraries table (selected by default) set a circulation rule for the borrower category adding an amount of holds in "Holds allowed" column For a beginning , you can set only one rule with itemtype as All or several rules with different item type. 5) In the pro interface, choose a record with some items : you can choose a notforloan status for one, set an itemtype with a circ rule without holds allowed for another etc. 6) Check out on your count as much items of this record as it's possible. Do not forget to change branch to checkout the items from their homebranch. 7) go to opac and search for the detailed record 8) You do not see the Place hold button yet : you must first authenticate yourself as patron1 to make it appear. Then you can pursue the Placing hold process as usual. 9) reconnect as admin and go to pro interface , search for the detailed record 10) click the Holds tab and enter patron1 in text box 11) the usual form appears : you can choose there the pickup location and select a specific item in the items table. 12) Now, check in one of the items and go back to opac detailed record 13) Even if you are already authentified (as patron1), the "Place hold" icon is no more visible (hold is no more possible) 14) reconnect as admin and go back in the pro interface to the detailed record 15) Enter patron1 again in patron textbox : the "Cannot place hold message" displayed with the following explanation : "All reservable items of the record must be on loan" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:26:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:26:27 +0000 Subject: [Koha-bugs] [Bug 11482] New: new reservation syspref PickupHoldOnlyFromItemBranches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Bug ID: 11482 Summary: new reservation syspref PickupHoldOnlyFromItemBranches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org warning : even if this patch and Bug 11481 can work separately it's necessary to first install Bug 11481 in order to avoid conflict and applying patch issues. The use of this new syspref assumes that other sysprefs OPACAllowUserToChooseBranch and canreservefromotherbranches are set on. it introduces the following behavior about reserves : You can't choose whatever branch as your pickup location. It must be a holding branch of an item. Either you don't mind picking the item at one branch or another and you ask for the very first available item or you select a specific branch and you will get the first checked in item in it. Multiholds is not possible from the pro interface (Place hold button is hidden in the results list). In the hold form the pickup list display only the branch(es) where the items are from. If a branch has no circulation rule allowing holds for its documents, it does not appear in the list. Test plan : 1) Enable RequestOnOpac OPACAllowUserToChooseBranch canreservefromotherbranches and PickupHoldOnlyFromItemBranches syspref 2) Choose one borrower (patron1) to place holds : get his category, login and pasword. 3) Go to Administration/Circulation and fine rules 4) in the ALL libraries table (selected by default) set a circulation rule for the borrower category adding an amount of holds in "Holds allowed" column You can set only one rule for a beginning with itemtype as All or several rules with different item type. 5) In the pro interface, choose a record with some items of different branches. 6) check out some items. do not forget to checkout items on their very homebranch 7) go to opac and search for the detailed record 8) Place a hold and authenticate as patron1. In the pickup list, you must see as options, only the branches of the items. You can choose either the first available item from all these branches or first from a specific one of them. try 'first available'. 9) Go to patron1 user file and click the tab Holds : the hold had been recorded. Pickup location is 'Whatever location from the first available'. 10) reconnect as admin and check in one of the items, a message box appears : confirm the hold. 11) Reconnect as Patron1, go back to the user file and check that the pickup location zone now displays the branch of the returned item. cancel the hold 12) redo a test from stage 6 selecting a specific branch in stage 8 13) go to pro interface to the detailed record, click the Holds tab and enter patron1 in text box 14) the holds form appears. The pickup location displays only the branches of items. Select an option and confirm the hold. 15) the holds table now display a line for the new recorded holds with patron1 name. Check that pickup location list is still restricted to item branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:36:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:36:37 +0000 Subject: [Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha at univ-lyon3.fr Assignee|oleonard at myacpl.org |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 23974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23974&action=edit Bug-11481-HoldOnlyWhenAllItemsOnLoan-new-syspref.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:38:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:38:09 +0000 Subject: [Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha at univ-lyon3.fr Assignee|oleonard at myacpl.org |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 23975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23975&action=edit Bug-11482 PickupHoldOnlyFromItemBranches new syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:39:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:39:54 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #36 from Kyle M Hall --- Created attachment 23976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23976&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 5 - Don't transfer issued and waiting items Items in a rotating collection are automatcially transferred when a collection is transferred. This is a problem for currently checked out items and items on hold marked as "Waiting". This patch resolves this issue by skipping the transfer for those items. When the items are then returned, the librarian will be alerted to transfer the item to the library currently holding that rotating collection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:43:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 17:43:42 +0000 Subject: [Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > Hi Jonathan, I retested this and think I spotted a problem: > > Order: 2 orders > Cancel one order, delete bibliographic record > Item cound is correct, but biblio count doesn't show the cancelled biblio. Since the aqorders.biblionumber is set to null on deleting a biblio I don't know how to get the correct count. I could do something like: COUNT(DISTINCT(COALESCE(aqorders.biblionumber, timestamp))) AS total_biblios in order to get the total number of biblio for a basket. But if a same biblio is ordered in several orders, the value will be wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:15:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 18:15:21 +0000 Subject: [Koha-bugs] [Bug 11483] New: new serial pages missing help Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Bug ID: 11483 Summary: new serial pages missing help Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The new serial frequencies and numbering pattern pages are missing help files. Patch to come. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:17:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 18:17:28 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:17:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 18:17:31 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 --- Comment #1 from Nicole C. Engard --- Created attachment 23977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23977&action=edit Bug 11483: Add missing serial help files The help files for the Serial Numbering Patterns and Frequencies pages were missing. This patch adds them. To test: * Visit the two new serial pages * Click Help * Confirm text and links are right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:45:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 18:45:45 +0000 Subject: [Koha-bugs] [Bug 11484] New: Add option to purge z39.50 search records from import table to cleanup_database.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11484 Bug ID: 11484 Summary: Add option to purge z39.50 search records from import table to cleanup_database.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be good to be able to specifically target import records from z39.50 for cleanup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:45:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 18:45:49 +0000 Subject: [Koha-bugs] [Bug 11484] Add option to purge z39.50 search records from import table to cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11484 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:47:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 18:47:49 +0000 Subject: [Koha-bugs] [Bug 11484] Add option to purge z39.50 search records from import table to cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11484 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:47:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 18:47:51 +0000 Subject: [Koha-bugs] [Bug 11484] Add option to purge z39.50 search records from import table to cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11484 --- Comment #1 from Kyle M Hall --- Created attachment 23978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23978&action=edit Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl It would be good to be able to specifically target import records from z39.50 for cleanup. Test Plan: 1) Apply this patch 2) Import one or more batch record sets into Koha 3) Perform some z39.50 searches 4) Run this command: misc/cronjobs/cleanup_database.pl -v --z3950 5) Verify that only z39.50 records were deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 20:23:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 19:23:50 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Magnus Enger --- (In reply to Fr?d?ric Demians from comment #9) > > If sitemap.pl is run without any arguments, it will create the sitemap > > files. I seem to remember we have a convention that scripts run without > > arguments should print a help message and exit, but it does not seem to be > > in the coding guidelines... Maybe add a --run parameter to actually run the > > script? > > I'm not sure on this point. For me, a --run is required for scripts > which alter database, and when there is a risk of data loose. This isn't > the case here. OK. This is really close now, but I have one last problem: It seems that if I run the script without the -dir parameter, no files are created in the current directory, and the script does not complain, with or without -v. But if I run the script with -dir and the absolute path to the current directory as an argument, the sitemap files ar created just fine. I am testing on a gitified package-install, so I have to use sudo to be able to read koha-conf.xml: $ sudo pwd /home/magnus/scripts/kohaclone # No files are creatd in /home/magnus/scripts/kohaclone: $ sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml perl misc/cronjobs/sitemap.pl -v Creation of Sitemap files in '.' directory Number of biblio records processed: 172 Number of Sitemap files: 1 # Files *are* created in /home/magnus/scripts/kohaclone: $ sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml perl misc/cronjobs/sitemap.pl -v -dir /home/magnus/scripts/kohaclone Creation of Sitemap files in '/home/magnus/scripts/kohaclone' directory Number of biblio records processed: 172 Number of Sitemap files: 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:13:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 20:13:51 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Magnus Enger --- The options seem to do their job nicely, but I see one small problem in the man page: [|] The literal brackets [] result in double brackets in the man page: koha-translate [-i|--install] [-u|--update] [-r|--remove] [-c|--check] [[-v|--verbose]] {lang_code} Just remove the literal brackets and it should be OK. But while yu are in there, could you also put the two synopsis'es (?) into separate ? From this: koha-translate | | | | [|] lang_code koha-translate | | To this: koha-translate | | | | [|] lang_code koha-translate | | As it is now, the two lines are run into one, this will put them on separate lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:16:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 20:16:53 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23896|0 |1 is obsolete| | --- Comment #11 from Fr?d?ric Demians --- Created attachment 23979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23979&action=edit Proposed patch v4 Thanks Magnus. A tricky bug had been introduced at last minute... Fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:18:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 20:18:10 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:30:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 20:30:05 +0000 Subject: [Koha-bugs] [Bug 11485] New: serial renew doing wonky things Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11485 Bug ID: 11485 Summary: serial renew doing wonky things Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Sorry - don't have a better title than that and haven't tested in 3.14 yet. I went to the subscription page and at the top it said it was going to expire on 01/01/2013 (yes it says 'going' instead of 'has expired'). I clicked the 'renew this subscription' link and the pop up all looked right. It had the start date of 01/01/2014 and 12 months. I clicked submit. At this point everything is still okay. I go to receive the latest issue (which is Dec 30, 2013) and it works as I'd expect, but the next issue that's generated is the problem - it has skipped all of 2014 and now is doing 2015!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:35:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 20:35:00 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:50:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 21:50:10 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:50:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 21:50:14 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #12 from Magnus Enger --- Created attachment 23980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23980&action=edit Bug 11190 sitemap.pl -- Generate a Catalog sitemap Add a script sitemap.pl to process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. Thanks Magnus for testing, and helping to improve the script design. Signed-off-by: Magnus Enger All options to the script work as expected and the output looks good. Nice enhancement! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 21:51:09 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:44:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 22:44:13 +0000 Subject: [Koha-bugs] [Bug 2327] Performing a z39.50 search on an ISBN causes Koha to throw an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2327 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from David Cook --- Thanks for mentioning that, Chris! However, it looks like my comment was unfounded. As per usual, I thought that I had checked master, but I had only checked 3.8.0. Jared resolved this issue with bug 8550, which has made it back as far as 3.8.4. I've double-checked master now, and it's working fine. Sorry 'bout that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:54:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 22:54:03 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11304|1 |0 is obsolete| | CC| |dcook at prosentient.com.au --- Comment #18 from David Cook --- Comment on attachment 11304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11304 Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off The first patch was obsoleted, but is needed for folks doing a git bz apply for versions older than 3.8.4 (which hopefully they shouldn't need to do, but still...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 00:30:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 23:30:47 +0000 Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your summary tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 00:57:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2014 23:57:22 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > Hm, there is > http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet- > tmpl/prog/en/includes/datatables.inc; > h=703d1e3e9637aad3923e2ab2fbe557c2b55869db; > hb=e81513199cba41a254820347442719a6fd50ec0b which includes a line with the > articles that is translatable. I am not sure if that is what gets used with > 'anti-the', but it might. Even better than a translatable line would be > making this a system preference, so you can change it anytime without having > to update the po files. Yep, CONFIG_EXCLUDE_ARTICLES_FROM_SORT is the variable that provides the articles. You can see this in "git\koha-tmpl\intranet-tmpl\prog\en\js\datatables.js" It's a modified version of this Datatable plugin: http://datatables.net/plug-ins/sorting#anti_the A system preference might be an idea, although I wonder how that would look? It seems to me that you would need to express quite a few different key->value relationships. Plus, you would need to have translators providing the values for that system preference, at least initially. Would translators be up for that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 01:04:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 00:04:16 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from David Cook --- Applying: Bug 11203 - Datatables in acqusitions do not ignore "stopwords" in titles Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Failed to merge in the changes. Patch failed at 0001 Bug 11203 - Datatables in acqusitions do not ignore "stopwords" in titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 01:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 00:59:57 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- 1) I agree that a newline should be added. 2) I'm not certain about using double quotes as a text qualifier. While this will work for many of the logs, it won't work for any log that contains double quotes within it (such as a cataloguing (biblio or item) modification, authority modification, system preference modification). I think most programs typically use single quotes, double quotes, or spaces as text qualifiers, and all three of these won't work for us, since we have all three of those within our text. We also have commas in our text...and could possibly have tabs...so those two delimiters aren't very useful either without using text qualifiers. Of course, I don't see any easy solution to this problem. I think bibliographic data is too difficult to express in a regular delimited text format, and we're showing entire records in many of the logs. Perhaps we could clean problematic characters (tabs, commas, quotes, etc) from the logs, but then we also compromise the integrity of those logs. Perhaps another idea would be to export using XML formats (ODS,XLSX) instead. (We do this elsewhere in Koha.) Perhaps we should leave the simpler formats for simpler data. 3) "Title" and "author" should be removed from the list. You could probably safely do this without leaving the comment behind. -- Anyway, those are my thoughts. Since this patch doesn't completely fix the log export, I'm tempted to mark it as Failed QA. However, while it isn't a perfect fix, it is better than what we're currently doing, so maybe it's good enough for now. I'm marking it "In Discussion" to see what others think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 02:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 01:31:43 +0000 Subject: [Koha-bugs] [Bug 11480] Tests in Output_JSON.t make invalid assumptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 02:31:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 01:31:47 +0000 Subject: [Koha-bugs] [Bug 11480] Tests in Output_JSON.t make invalid assumptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23973|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 23981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23981&action=edit Bug 11480 Fix invalid assumptions in test Tests for Output::JSON made the invalid assumption that the hash keys of the modules internal structure will always be returned in the same sequence. A hash is an unordered structure. as of perl 5.18 this has beem reinforced by random seeding of the hashing function. See the info in perldelta and the doc for JSON This patch changes the tests to be sequence neutral where the previous test was testing that a new element was added and an existing one was untouched these have been separated into individual tests. Some typos in the messages have been corrected Signed-off-by: Chris Cormack Test Plan 1/ Run t/Output_JSONStream.t , 8 tests should pass (or perhaps fail, but inconsistently under perl 5.18 or greater) 2/ Apply patch 3/ Run t/Output_JSONStream.t 10 tests should pass now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 03:12:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 02:12:08 +0000 Subject: [Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- (In reply to Galen Charlton from comment #2) > I think it would be reasonable to consider making the OPAC XSLT stylesheets > not be specific to a particular theme, but instead be shared by all of them. > Even if that's the final decision, I think it would be a good idea for this > patch to be reviewed and pushed, as having the XSLT be identical in the two > major themes prior to moving it will make it easier to validate the > consolidation. +1 Personally, I don't see a need to duplicate XSLTs across the different themes. I think it just adds more chance of error. In theory, someone might want to tie an XSLT to a theme, so that different themes show different data, but I don't see the purpose of that, since we can already specify different XSLTs in the system preferences. Reduce the boilerplate, me thinks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 04:34:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 03:34:56 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #86 from Galen Charlton --- Comment on attachment 21312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21312 [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions Review of attachment 21312: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6739&attachment=21312) ----------------------------------------------------------------- ::: opac/opac-user.pl @@ +65,4 @@ > } > ); > > +my $OPACDisplayRequestPriority = (C4::Context->preference("OPACDisplayRequestPriority")) ? 1 : 0; This is a regression on bug 7398; OPACDisplayRequestPriority no longer exists. @@ -110,4 @@ > $canrenew = 0; > $template->param( > renewal_blocked_fines => sprintf( '%.02f', $no_renewal_amt ), > - renewal_blocked_fines_amountoutstanding => sprintf( '%.02f', $borr->{amountoutstanding} ), Removing this would cause a regression of bug 8408. @@ -170,5 @@ > $charges += $ac->{'amountoutstanding'} > if $ac->{'accounttype'} eq 'F'; > $charges += $ac->{'amountoutstanding'} > - if $ac->{'accounttype'} eq 'FU'; > - $charges += $ac->{'amountoutstanding'} Removing this would cause a regression on bug 8079. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 04:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 03:36:42 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #87 from Galen Charlton --- Marked as failed QA on account of the three regressions that this patch series would cause. Overall, looks reasonable, and I expect it to pass into master once the regressions have been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 05:05:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 04:05:10 +0000 Subject: [Koha-bugs] [Bug 11486] New: Show renewal count on 'check out' and 'details' tabs in patron record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Bug ID: 11486 Summary: Show renewal count on 'check out' and 'details' tabs in patron record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A librarian has pointed out that the renewal count (2 of 3 renewals remaining) appears on the OPAC, but not on the staff client. This will let librarians see at a glance how many renewals are left for a few scenarios (e.g. letting a patron know how many renewals they have left, knowing how close the patron is to their limit, etc). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 05:07:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 04:07:00 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 05:14:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 04:14:23 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 05:14:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 04:14:27 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 --- Comment #1 from David Cook --- Created attachment 23982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23982&action=edit Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record This patch adds the renewal count to the 'Check out' and "Details' tabs of the patron record. This information already exists in the OPAC view of the patron record. Since librarians might be serving patrons in person who want to know this information without looking it up online, it makes sense to show it in the staff client. There may also be times where librarians want to see how many renewals a patron has left, how many they've used already, etc. when making other decisions. _TEST PLAN_ Before applying: 1) Go to "Check out" with a patron that has some check outs before today 2) Add some check outs for today *Ensure that all issues are for items that can be renewed* 3) Note that the Renew column just says '0' followed by a check box 4) Check the 'Detail' tab. It should say the same. Apply the patch. 5) View the "Details" and "Check out" tabs again 6) Note that the renewal count now appears in the form resembling: 5 of 5 renewals remaining -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 05:39:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 04:39:23 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #38 from Galen Charlton --- Pushed to master, along with a follow-up to make it clear to a circ operator who lacks the force_checkouts permission how to proceed if they cannot make the loan. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 06:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 05:58:35 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 --- Comment #7 from Katrin Fischer --- Hm, not sure about "key-value-relationships" - wouldn't it be just a word list? You don't want to sort differently when switching templates, so I think the actual langauge of a word is not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 13:30:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 12:30:26 +0000 Subject: [Koha-bugs] [Bug 11487] New: Untranslatable tooltip "Dates of birth should be entered in the format ..." Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Bug ID: 11487 Summary: Untranslatable tooltip "Dates of birth should be entered in the format ..." Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The following text is not picked up by the translation toolchain: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: content: 'Dates of birth should be entered in the format "[% format %]"', -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 13:36:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 12:36:19 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #34 from Kyle M Hall --- > After applying the patch, I am not able to add value in input text (as if > they were readonly, but they are not...). Can you post some screenshots, or better yet, a video of this issue? I'm not able to reproduce it, but I'm not sure if I'm looking in the right place either. > Moreover the commit message indicates that 6xx and 7xx fields will be > sortable, but this patch impacts all fields . Is this a real issue? That is, I propose we rename the bug to "move and reorder marc fields". I see this as only adding more flexibility to the marc editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 13:38:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 12:38:44 +0000 Subject: [Koha-bugs] [Bug 11488] New: Untranslatable warning "Are you sure you want to write off ..." Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Bug ID: 11488 Summary: Untranslatable warning "Are you sure you want to write off ..." Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The following text is not picked up by the translation toolchain: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt: var answer = confirm(_("Are you sure you want to write off [% total | format('%.2f') %] in outstanding fines? This cannot be undone!")); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:35:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 13:35:19 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 --- Comment #23 from Kyle M Hall --- Created attachment 23983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23983&action=edit Bug 6254 [QA Followup 1] - can't set patron privacy by default -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:36:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 13:36:58 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #35 from Jonathan Druart --- Created attachment 23984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23984&action=edit Bug 7882: Inputs should be editable disableSelection is deprecated and cause an issue on editing an input (input, select, textarea, etc.) see http://api.jqueryui.com/disableselection/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:39:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 13:39:16 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #36 from Jonathan Druart --- (In reply to Kyle M Hall from comment #34) > > After applying the patch, I am not able to add value in input text (as if > > they were readonly, but they are not...). > > Can you post some screenshots, or better yet, a video of this issue? I'm not > able to reproduce it, but I'm not sure if I'm looking in the right place > either. I did nothing in particular, just open the editor and try to edit an input. Why do you use disableSelection? My patch fixes my issue. > > Moreover the commit message indicates that 6xx and 7xx fields will be > > sortable, but this patch impacts all fields . > > Is this a real issue? That is, I propose we rename the bug to "move and > reorder marc fields". I see this as only adding more flexibility to the marc > editor. It is not an issue, of course. But it is not what it is written in the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:41:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 13:41:04 +0000 Subject: [Koha-bugs] [Bug 11336] Priority is not updated on deleting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #32 from Jonathan Druart --- Fixed by commit 7af64ff7bd26eaa0d8cdb688f0db1526e438f087 Bug 11336: (follow-up) fix typo in previous follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:41:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 13:41:59 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 13:42:04 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23983|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 23985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23985&action=edit Bug 6254 [QA Followup 1] - can't set patron privacy by default * Adds default privacy column to summary table * Adds default privacy to delete category summary * Adds "AFTER categorycode" to the database update * Whitespace cleanup and formatting for affected code blocks * Switch basic DBI queries to DBIx::Class to simplify code -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:51:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 13:51:21 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23985|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 23986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23986&action=edit Bug 6254 [QA Followup 1] - can't set patron privacy by default * Adds default privacy column to summary table * Adds default privacy to delete category summary * Adds "AFTER categorycode" to the database update * Whitespace cleanup and formatting for affected code blocks * Switch basic DBI queries to DBIx::Class to simplify code * Adds reference to misc/cronjobs/batch_anonymise.pl to description -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 13:53:30 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23986|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 23987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23987&action=edit Bug 6254 [QA Followup 1] - can't set patron privacy by default * Adds default privacy column to summary table * Adds default privacy to delete category summary * Adds "AFTER categorycode" to the database update * Whitespace cleanup and formatting for affected code blocks * Switch basic DBI queries to DBIx::Class to simplify code * Adds reference to misc/cronjobs/batch_anonymise.pl to description -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:15:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 14:15:44 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:15:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 14:15:57 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9044 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:15:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 14:15:57 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11475 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:18:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 14:18:25 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:18:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 14:18:29 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 --- Comment #1 from Jonathan Druart --- Created attachment 23988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23988&action=edit Bug 11475: Links are broken when editing/deleting items in batch Bug introduced by bug 9044. Test plan: 1- First we search for records with multiple items (books or serials, does not matter) 2- We open this record we found with multiple items for editing 3- We chose "Edit items in batch" option from the "Edit" menu 4- We make corrections on the fields under the "Edit item" (For example we change the collection code as "fiction") 5- We save this using "Save button" at the bottom, after we are done. 6- Just after we save, there will be a button named "Done" available just under the page, and when we click on "Done" we encounter the Error screen. Before the patch, the "Done" link points to /cgi-bin/koha/tools/CATALOGUING. After applying the patch, the "Done" link points to the biblio detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:50:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 14:50:01 +0000 Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |olli-antti.kivilahti at jns.fi --- Comment #4 from Olli-Antti Kivilahti --- (In reply to Elliott Davis from comment #0) > When an item is overdue and is renewed the fines that were assessed are > removed. This is obviously not a desired behavior. We are facing the same issue. I think this bug doesn't really matter if you recalculate fines daily using the fines.pl cronjob, since when you renew, the fine has already been generated for the overdue period. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:54:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 14:54:29 +0000 Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614 --- Comment #5 from Katrin Fischer --- (In reply to Olli-Antti Kivilahti from comment #4) > (In reply to Elliott Davis from comment #0) > > When an item is overdue and is renewed the fines that were assessed are > > removed. This is obviously not a desired behavior. > > We are facing the same issue. > I think this bug doesn't really matter if you recalculate fines daily using > the fines.pl cronjob, since when you renew, the fine has already been > generated for the overdue period. Hm, I think that is only partially correct. I think it would not touch the fine as long as the item doesn't get overdue again, but it will be a problem when it does get overdue agan. The fines would be recalculated from the new due date. I am not sure if this will be done as a new line in accuntlines or updating the old one. Maybe worth testing out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:55:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 15:55:23 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon at cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:19:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 17:19:24 +0000 Subject: [Koha-bugs] [Bug 11489] New: OPAC search results in 404 error when the only search result is supressed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Bug ID: 11489 Summary: OPAC search results in 404 error when the only search result is supressed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:19:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 17:19:29 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:24:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 17:24:13 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:24:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 17:24:15 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #1 from Kyle M Hall --- Created attachment 23989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23989&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:26:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 17:26:43 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23989|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 23990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23990&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:26:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 17:26:58 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:24:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 18:24:08 +0000 Subject: [Koha-bugs] [Bug 10318] show email on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Melissa Lefebvre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:24:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 18:24:21 +0000 Subject: [Koha-bugs] [Bug 10318] show email on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21921|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:24:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 18:24:27 +0000 Subject: [Koha-bugs] [Bug 10318] show email on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 23991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23991&action=edit now showing primary email address of a patron in the patron search results page added mailto link to the email address http://bugs.koha-community.org/show_bug.cgi?id=10318 Signed-off-by: Melissa Lefebvre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:11:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 19:11:27 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:11:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 19:11:30 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23953|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 23992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23992&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:44:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 19:44:10 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #50 from Kyle M Hall --- Created attachment 23993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23993&action=edit Bug 10558 [QA Follow-up 6] - Use datatables.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:06:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 20:06:35 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #51 from Kyle M Hall --- Created attachment 23994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23994&action=edit Bug 10558 [QA Follow-up 7] - Make strings translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:08:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 20:08:52 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #52 from Kyle M Hall --- Setting to Passed QA again. Regression of 10170 resolved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:13:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 20:13:19 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23994|0 |1 is obsolete| | --- Comment #53 from Kyle M Hall --- Created attachment 23995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23995&action=edit Bug 10558 [QA Follow-up 7] - Make strings translatable Removed trailing whitespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:24:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 20:24:05 +0000 Subject: [Koha-bugs] [Bug 11260] Update German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11260 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23748|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 23996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23996&action=edit Bug 11260: Update German web installer for 3.14 Mandatory: - adds auth_values.sql and .txt with YES_NO referenced in patron_attributes.sql - updates sample notices with redone slip templates (ISSUESLIP, ISSUEQSLIP, RESERVSLIP, TRANSFERSLIP) - adds German translations to subtag_registry.sql and copies updated file from en to de-DE - adds translation for new course_reserves permission to userflags.sql - adds translations for new permissions in userpermissions.sql - Fixes typo IndependantBranches in English userpermissions.sql Optional: - adds csv_profiles.sql and translation of the serial claims profile - adds z39.50 servers for authorities to sample_z3950_servers.sql To test: - Run web installer in English - check all sample files, make sure they all install without SQL errors - check language list on advanced search displays correctly still - check area/language list on tools > news displays correctly still - check permissions for correct spelling of IndependentBranches - Run web installer in German - repeat checks from above - also check: authorised values, especially existence of YES_NO - all permissions are translated now - slip notices are all there and look right - new z39.50 servers for authorities are available - csv profile for serial claims is available and works as expected ... and anything else you can think of. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:24:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 20:24:11 +0000 Subject: [Koha-bugs] [Bug 11260] Update German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11260 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23749|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 23997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23997&action=edit Bug 11260: Update German web installer - frequenciesand numberpatterns Translates the new files for frequencies and numberpatterns To test: - Run the German web installer with all sample files - Check all files import without errors, especially frequencies and numbering patterns - Check frequencies in serials - Check numbering patterns in serials - Create a subscription, check possible choices Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:25:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 20:25:06 +0000 Subject: [Koha-bugs] [Bug 11260] Update German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11260 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23750|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 23998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23998&action=edit Bug 11260: Follow up - normalizing frequencies in English sample file a bit After some discussion in IRC I am throwing in some changes for the English sample frequencies: - Change Vol to Vol. - Change No to No. We had both forms in the file, now it should be consistent. To test: - Run English web installer installing all sample files, especially frequencies - Check installed frequencies - Check available options creating a subscription Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:25:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 20:25:03 +0000 Subject: [Koha-bugs] [Bug 11260] Update German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11260 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:47:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 22:47:05 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 --- Comment #7 from Christopher Brannon --- I will go ahead and sign off on this then and file a new bug regarding the processing issue. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:54:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 22:54:07 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |sandboxes at biblibre.com --- Comment #8 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:54:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 22:54:19 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:54:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 22:54:26 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 --- Comment #9 from sandboxes at biblibre.com --- Created attachment 23999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23999&action=edit Bug 11343: The max number of items to process in a batch is hardcoded Until now, the maximum number of item records to process in a batch was hardcoded to 1000. This patch adds a syspref MaxItemsForBatch in order to allow to adapt this value. Test plan: - set the pref to 2 - try to delete a batch of 3 items: they are not displayed - try to modify a batch of 3 items: you are not allowed to do that - set the pref to 1000 and try again. Now items are displayed and you are allow to modify them. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:58:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 22:58:55 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 --- Comment #8 from David Cook --- (In reply to Katrin Fischer from comment #7) > Hm, not sure about "key-value-relationships" - wouldn't it be just a word > list? You don't want to sort differently when switching templates, so I > think the actual langauge of a word is not needed. Mmm, good point. I'm trying to think of examples where an article in one language might be a non-article in another language... 'The' is an English article, but 'Th?' is a French noun that we wouldn't want to ignore. I suppose the regex might differentiate letters with diacritics... 'A' is the French preposition 'A'/'?' (often when capitalized, the article doesn't have a diacritic). Tricky. Here is a more comprehensive list of articles in multiple languages... http://library.princeton.edu/departments/tsd/katmandu/catcopy/article.html -- That said, an English install might have records in multiple languages and you would probably want to sort all of them without articles. I don't know if there is a way of offering a 100% consistent sort across languages though. Of course, using the articles of the selected language isn't very consistent either, so I'm tempted to say that the system preference is the best bet. I suppose the system preference could make it easier to deal with problems. If you just have English, you could just use English articles. If you just have French, you could just use French, etc. You might even be able to use a few articles from a few languages. I think French + English would have problems though (because of 'A' and maybe 'The'). German + English also looks like it would have problems. "Die" is a pretty common English noun. "Den" maybe less so, but still. Of course, this is all just from a list. I'd be interested to hear from more native speakers. -- Other problematic words I see: 'as' => Portuguese/Gallegan||Galician 'bat' => Basque 'am' => Gaelic 'den' => Danish/German/Norwegian/Swedish 'die' => Afrikaans/German/Yiddish 'et' => Danish/Norwegian (maybe...) 'he' => Hawaiian 'hen' => Greek 'hi' => Icelandic 'i' => Italian 'in' => Friesian 'it' => Friesian 'nina' => Tagalog 'os' => Portugeuse (both for English OS and the French noun Os) 'to' => Greek (Need a native speaker for this one. I thought 'to' was the Greek pronoun for the English 'it') 'ton' => Greek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 00:06:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 23:06:13 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 --- Comment #9 from David Cook --- 'Des' in German is an article, but that's a partitive article in French ('some'/'any' in English) that we probably wouldn't want to ignore. I suppose the ideal system would know the language of the string and ignore the requisite articles, but...in acquisitions we don't necessarily even have a record so it's tough to know the language. Although...I seem to recall seeing a "locale" box somewhere in 3.15 recently...maybe that's something that we should use more of around Koha? I suppose that has the potential to be quite useful or quite messy/difficult though... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 00:07:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 23:07:14 +0000 Subject: [Koha-bugs] [Bug 11490] New: Deleting Batch Items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Bug ID: 11490 Summary: Deleting Batch Items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org This discovery is made based off an enhancement being worked on in bug 11343. It has been discovered that when patch 11343 is in place, if I set the new syspref MaxItemsForBatch to 2, and then try to do a batch delete of 3 items, it won't show the 3 items because of the limit, but it will still allow me to delete beyond the limit. I have concern that even without this patch, staff can delete beyond the hard coded 1000 item limit. Can anyone confirm this issue? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 00:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 23:22:54 +0000 Subject: [Koha-bugs] [Bug 11491] New: Extending report service to have header Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491 Bug ID: 11491 Summary: Extending report service to have header Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org The report service URL generates JSON, but has no header information. It would be nice to have: https://.../cgi-bin/koha/svc/report?id=15 Return just the JSON with no header entry, and: https://.../cgi-bin/koha/svc/report?id=15&header=1 Return the JSON with the first entry as a header entry. And while I'm at it, I'll update the license and strict/warnings to Modern::Perl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 00:37:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 23:37:45 +0000 Subject: [Koha-bugs] [Bug 11491] Extending report service to have header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491 --- Comment #1 from M. Tompsett --- Created attachment 24000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24000&action=edit Bug 11491 - Old License and strict, warnings Replaced License text with latest one from http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence and tweaked copyright lines accordingly. Also changed use strict and use warnings into use Modern::Perl as per PERL2 from the coding guidelines. TEST PLAN --------- 1) less ~/kohaclone/opac/svc/report - The license does not reflect the current license - This will have use strict and use warnings 2) Apply patch - The license should be corrected 3) It should still run https://.../cgi-bin/koha/svc/report?id=## https://.../cgi-bin/koha/svc/report?id=##&header=blah Where ## reflects a public report available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 00:38:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 23:38:17 +0000 Subject: [Koha-bugs] [Bug 11491] Extending report service to have header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 00:39:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 23:39:21 +0000 Subject: [Koha-bugs] [Bug 11491] Extending report service to have header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491 --- Comment #2 from M. Tompsett --- Created attachment 24001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24001&action=edit Bug 11491 - Missing header fields in JSON data Added a header parameter, which when non-empty will add the header fields of the query in question as the first element of the JSON array. TEST PLAN --------- 1) Log into staff client 2) Reports 3) Used save reports 4) Click the Action button on any report 5) Click Edit 6) Make the report public 7) Update the SQL 8) Note the ID number of the report 9) In a new tab https://.../cgi-bin/koha/svc/report?id=## 10) The returned JSON should not have a header. 11) Go to https://.../cgi-bin/koha/svc/report?id=##&header=1 12) The returned JSON should have a header. 13) ~/qa-test-tools/koha-qa.pl -v 2 -c 2 NOTE: There are two patches, but you could just test 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 00:39:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 23:39:23 +0000 Subject: [Koha-bugs] [Bug 11491] Extending report service to have header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24000|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 24002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24002&action=edit Bug 11491 - Old License and strict, warnings Replaced License text with latest one from http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence and tweaked copyright lines accordingly. Also changed use strict and use warnings into use Modern::Perl as per PERL2 from the coding guidelines. TEST PLAN --------- 1) less ~/kohaclone/opac/svc/report - The license does not reflect the current license - This will have use strict and use warnings 2) Apply patch - The license should be corrected 3) It should still run https://.../cgi-bin/koha/svc/report?id=## https://.../cgi-bin/koha/svc/report?id=##&header=blah Where ## reflects a public report available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 00:40:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2014 23:40:17 +0000 Subject: [Koha-bugs] [Bug 11491] Extending report service to have header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 01:52:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 00:52:10 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 02:14:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 01:14:27 +0000 Subject: [Koha-bugs] [Bug 11260] Update German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11260 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master, along with followups to repair issues with the en and de-DE Z39.50 servers SQL. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 02:59:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 01:59:27 +0000 Subject: [Koha-bugs] [Bug 11492] New: Receiving a serial item causes routing list notes to be lost Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Bug ID: 11492 Summary: Receiving a serial item causes routing list notes to be lost Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To replicate: Create a routing list for a subscription Add some borrowers to it Add a note Save it View the routing list, the note should be appearing Receive the next serial in the subscription View the routing list Note that the routing list notes are now gone. Uh oh. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 02:59:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 01:59:44 +0000 Subject: [Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 03:45:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 02:45:13 +0000 Subject: [Koha-bugs] [Bug 11493] New: Batch Item Modification not handling unicode characters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11493 Bug ID: 11493 Summary: Batch Item Modification not handling unicode characters Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: karamqubsi at gmail.com QA Contact: testopia at bugs.koha-community.org Hi, Today while trying to make a batch modification for 10 items related to one bib record , we entered an Arabic characters (? ? ? ) in the -o subfield and we get bad results :?? ?? ?? you can try this by open a bib record with more than 1 item , select all items chose Modify selected items try to enter some Arabic character in any sub-field like in (x - Non-public note) you can put any letters from the Arabic alphabetic ( ? ? ? ? ? ? ...) save . and you will see the results . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 03:47:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 02:47:38 +0000 Subject: [Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 --- Comment #1 from Liz Rea --- Further review shows that the notes are stored in the database, but are not displayed properly. The interface seems to suggest that changing the dropdown would show the list for that particular issue (and it's notes, if it has some). That does not appear to be the case -- for notes, the actual membership of the list I have not checked on (yet). In fact, it looks like it shows the notes for the most recent received serial only, and switching the volume doesn't change the data displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 06:58:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 05:58:59 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #19 from Chris Cormack --- I couldn't reproduce this either, so would like someone who can to sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 08:37:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 07:37:15 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 08:37:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 07:37:18 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23977|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24003&action=edit Bug 11483: Add missing serial help files The help files for the Serial Numbering Patterns and Frequencies pages were missing. This patch adds them. To test: * Visit the two new serial pages * Click Help * Confirm text and links are right Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 08:55:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 07:55:34 +0000 Subject: [Koha-bugs] [Bug 11494] New: Pay patron fines shows cryptic, untranslatable, account types Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11494 Bug ID: 11494 Summary: Pay patron fines shows cryptic, untranslatable, account types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Paying patron fines, the fines table has an Account type -column, which shows cryptic, untranslatable codes, such as "FU". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 09:19:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 08:19:54 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23177|0 |1 is obsolete| | --- Comment #2 from Julian Maurice --- Created attachment 24004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24004&action=edit [SIGNED-OFF] Bug 11309: Duplicated patterns when subscription table is updated Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 09:29:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 08:29:58 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- Steps to reproduce the problem: 1/ Install Koha 3.12 2/ Create some subscriptions. Ensure you have at least two subscriptions with the same numbering pattern, with one of the keys everyX/addX/whenmorethanX/settoX set to NULL 3/ Remember this numbering pattern. 4/ Upgrade to 3.14 5/ Run updatedatabase.pl 6/ The numbering pattern is duplicated Now repeat steps 1 to 4, then apply the patch and run updatedatabase.pl. Numbering pattern should not be duplicated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 09:30:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 08:30:06 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 09:50:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 08:50:35 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 --- Comment #10 from Katrin Fischer --- I guess you are right, there are some overlaps. A list of words won't ever be perfect, but I think perfect is not really achievable here without going totally overboard :) I think a list of words in a pref would give more flexibility, allow the feature to be deactivated totally or adjusted to each libraries collection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:26:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:26:48 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:26:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:26:52 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24003|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 24005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24005&action=edit Bug 11483: Add missing serial help files The help files for the Serial Numbering Patterns and Frequencies pages were missing. This patch adds them. To test: * Visit the two new serial pages * Click Help * Confirm text and links are right Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:27:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:27:52 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- All works as expected. Thank you very much Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:28:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:28:04 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:34:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:34:06 +0000 Subject: [Koha-bugs] [Bug 11495] New: i18n toolchain misses one instance of text "Select titles to: " in bootstrap Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Bug ID: 11495 Summary: i18n toolchain misses one instance of text "Select titles to: " in bootstrap Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The translation toolchain does not pick up one instance of "Select titles to: " for translation from opac-tmpl/bootstrap/en/modules/opac-results.tt This means the text is shown in English until you click one of the checkboxes, then the javascript text is applied and it replaces the English text. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:38:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:38:29 +0000 Subject: [Koha-bugs] [Bug 11496] New: The number of tested records when searching for duplicates during import is too low Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 Bug ID: 11496 Summary: The number of tested records when searching for duplicates during import is too low Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently, only the first 10 records returned by koha for a given matchpoint are tested. This is not enough in some cases, because a significant matching record can be beyond these 10 first results. Please note that when the checkpoint is about fields with unique identifiers, like ISBN, the problem won't occur. On the other hand, when the checkpoint is about something less precise, like an author name, the matching record can be beyond the 10 first results. When that happens, the matchpoint will fail, the match threshold won't be reached, and a duplicate record will be created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:44:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:44:51 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 --- Comment #1 from Matthias Meusburger --- Created attachment 24006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24006&action=edit proposed patch Please note that this is a naive implementation of the fix (I've arbitrarily raised the matching records from 10 to 1000). If you agree that this is an issue, a better patch with a configurable amount of records to search might be proposed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:45:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:45:21 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 10:45:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 09:45:42 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 --- Comment #4 from Julian Maurice --- Maybe this need another patch to remove already created duplicates (maybe only those whose name starts with 'Backup pattern') ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 12:39:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 11:39:23 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 12:39:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 11:39:26 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23323|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 24007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24007&action=edit Bug 11334 - Add facet for home library The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label "Libraries" now reads "Holding libraries" 3) Update the system preference DisplayLibraryFacets to "home library" 4) Check that the facet now reads "Home libraries" 5) Update the preference again to "both home and holding library" 6) Check that both the facets for home and holding library are now displayed. Signed-off-by: Jen DeMuth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 12:40:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 11:40:45 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 --- Comment #6 from Kyle M Hall --- Created attachment 24008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24008&action=edit Bug 11334 [QA Followup] - Add facet for home library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 12:41:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 11:41:44 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Kyle M Hall --- Setting to passed QA, assuming the bad default system pref value was the only issue. Please update the bug status if I am incorrect! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 12:51:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 11:51:19 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #8 from Katrin Fischer --- Hi Kyle, I will take another look and add my sign off lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 12:51:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 11:51:38 +0000 Subject: [Koha-bugs] [Bug 11497] New: i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Bug ID: 11497 Summary: i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Some templates use the following or similar code: [% LibraryNameTitle or "Koha online" %] The translation toolchain fails to pick up the hard-coded string for translation: # grep -E '^#. %[0-9]+\$s: +.* or \"[^"]+".*$' po/de-DE-*.po po/de-DE-i-opac-t-prog-v-3006000.po:#. %4$s: LibraryNameTitle or "Koha online" po/de-DE-i-opac-t-prog-v-3006000.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-i-opac-t-prog-v-3006000.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-i-opac-t-prog-v-3006000.po:#. %2$s: LibraryNameTitle or "Koha online" po/de-DE-i-opac-t-prog-v-3006000.po:#. %2$s: LibraryNameTitle or "Koha online" po/de-DE-i-staff-t-prog-v-3006000.po:#. %1$s: frameworkcode or "Default" po/de-DE-i-staff-t-prog-v-3006000.po:#. %1$s: update.old_branch or "?" po/de-DE-i-staff-t-prog-v-3006000.po:#. %2$s: update.LoginBranchcode or "?" po/de-DE-opac-bootstrap.po:#. %4$s: LibraryNameTitle or "Koha online" po/de-DE-opac-bootstrap.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-opac-bootstrap.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-opac-bootstrap.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-opac-bootstrap.po:#. %2$s: LibraryNameTitle or "Koha online" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 13:16:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 12:16:48 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23526|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 24009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24009&action=edit Bug 9303 [1/2] - relative's checkouts in the opac - Schema Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 13:17:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 12:17:06 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23527|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 24010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24010&action=edit Bug 9303 [2/2] - relative's checkouts in the opac Signed-off-by: Joel Sasse Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 13:51:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 12:51:03 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #7 from Koha Team Lyon 3 --- Ok Mathieu, that's fine so -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 13:59:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 12:59:25 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 13:59:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 12:59:28 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #41 from Kyle M Hall --- Created attachment 24011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24011&action=edit Bug 9303 [QA Followup] - Set AUTO_INCREMENT value for issues.issue_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 14:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 13:05:57 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #42 from Kyle M Hall --- (In reply to Katrin Fischer from comment #38) > In my database, afer update: > old_issues - 1-18 > issues - 19-20 > - returned 19, 20 > old_issues 1-20 > issues empty > - checked out 2 items > old_issues 1-20 > issues 3,4 My bad! I forget to update the auto_increment value. Silly me expected mysql to use the max(issue_id) + 1 by default ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 14:17:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 13:17:30 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #9 from Olli-Antti Kivilahti --- I am sorry, but I still get the same error. Applying: Bug 10845: Multi transport types for holds fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10845: Multi transport types for holds This happens if I apply 10845 directly from 9016 or when I apply the whole feature set with 9016, 10832, 10833, 10845. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:06:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:06:39 +0000 Subject: [Koha-bugs] [Bug 11498] New: can bypass sco timeout with print dialog Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498 Bug ID: 11498 Summary: can bypass sco timeout with print dialog Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org You have to click one of the options on the self check print dialog for the screen to log out. The SelfCheckTimeout system preference doesn't seem to be able to function when the print receipt question is up. So if a patron walks away without making a selection, their checkouts remain on the screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:15:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:15:41 +0000 Subject: [Koha-bugs] [Bug 11483] new serial pages missing help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11483 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master, along with a follow-up fixing typos. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:17:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:17:04 +0000 Subject: [Koha-bugs] [Bug 11499] New: zebra_setup.pl not correctly setting indexing mode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Bug ID: 11499 Summary: zebra_setup.pl not correctly setting indexing mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com Bibliographic and authorities indexing mode is set in several places, including the koha-conf.xml file. The latter is not being properly set by the zebra_setup.pl helper script. I figured this when writing my patches for bug 11096 when I noticed i was getting USMARC data when I shouldn't. To reproduce: - Run the attached regression test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:21:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:21:52 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20917|0 |1 is obsolete| | Attachment #20918|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 24012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24012&action=edit Bug 10845: Multi transport types for holds The HOLD_PRINT and HOLD_PHONE notices become useless. This patch will modify existing notices in order to group them into the main notices 'HOLD'. Like that, on one screen, all these notices can be edited. Test plan: - apply the patch and execute the update database entry. - verify that yours previous HOLD_PHONE and HOLD_PRINT are displayed when editing the HOLD notice (under phone and print). - choose a patron and check sms, email, phone for "Hold filled" (on the patron messaging preferences). - place a hold. - check the item in and confirm the hold. - if the patron has an email *and* a sms number, 2 new messages are put into the sql message_queue table: 1 sms and 1 email. if the patron does not have 1 of them, there are 2 new messages: 1 sms/email and 1 print. if the user has neither of them, there is 1 new message: 1 print. - the generated messages should correspond with the notices defined, depending the message transport type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:22:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:22:15 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #11 from Jonathan Druart --- Created attachment 24013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24013&action=edit Bug 10845: Remove the notice code HOLD_PRINT The HOLD_PRINT notice code is the HOLD notice code with a message transport type equal to 'print'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:22:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:22:46 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #12 from Jonathan Druart --- It should be better now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:39:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:39:02 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:39:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:39:07 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 24014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24014&action=edit Bug 11499 - (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:40:09 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 24015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24015&action=edit Bug 11499 - Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:56:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:56:19 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11096 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 16:56:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 15:56:19 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11499 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 17:22:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 16:22:55 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 17:22:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 16:22:58 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23211|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 24016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24016&action=edit Bug 10774 [QA Followup] - Add support for bootstrap opac theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 17:23:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 16:23:17 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #15 from Kyle M Hall --- Created attachment 24017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24017&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. Signed-off-by: Chris Rohde Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 17:23:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 16:23:26 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24016|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 24018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24018&action=edit Bug 10774 [QA Followup] - Add support for bootstrap opac theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:22:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:22:10 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23366|0 |1 is obsolete| | --- Comment #24 from Tom?s Cohen Arazi --- Created attachment 24019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24019&action=edit [SIGNED-OFF] Bug 11096: (follow-up) add direct regression tests This adds direct tests of indexing and retrieving bib records that are larger than the ISO2709 limit of 99,999 octets. To test: verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:22:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:22:26 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 24020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24020&action=edit Bug 11096 - Wrap each test set configuration into a subtest This makes it easier to read. Also fixes the test count, and is rebased against 11499 which is needed to correctly test the patches for this bug (i.e. indexing mode needs to be correctly set in koha-conf.xml) Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:37:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:37:48 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24014|0 |1 is obsolete| | Attachment #24015|0 |1 is obsolete| | --- Comment #3 from Galen Charlton --- Created attachment 24021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24021&action=edit Bug 11499: (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 The test should fail unless the main page is applied. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:37:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:37:45 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:37:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:37:53 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 --- Comment #4 from Galen Charlton --- Created attachment 24022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24022&action=edit Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:46:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:46:36 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:46:42 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21674|0 |1 is obsolete| | Attachment #21675|0 |1 is obsolete| | Attachment #21676|0 |1 is obsolete| | Attachment #21677|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 24023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24023&action=edit Bug 8007: Discharge - DB changes This patch adds: - syspref useDischarge - the new table discharges - the discharge notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:46:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:46:52 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #37 from Jonathan Druart --- Created attachment 24024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24024&action=edit Bug 8007: Discharge - DBIx changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:47:08 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #38 from Jonathan Druart --- Created attachment 24025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24025&action=edit Bug 8007: Discharge - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:47:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:47:23 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #39 from Jonathan Druart --- Created attachment 24026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24026&action=edit Bug 8007: Discharge management This patch is the main patch. It adds new package and files for the new pages (opac-discharge, members/discharge and members/discharges). At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and a discharge if it has been validated by a librarian. Requirements: aptitude install python-pisa New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Verify a new tab appears in the patron page (intranet and opac). - Verify the discharge cannot be generated if the patron has issues. - Verify the patron can request a discharge from it's opac area. - The request appears on the main page (intranet). - Generate the discharge from the intranet. - Try to download it (from the opac and the intranet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 18:47:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 17:47:31 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #40 from Jonathan Druart --- Created attachment 24027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24027&action=edit Bug 8007: Discharge - Glue This patch adds: - links to the new pages. - syspref description - links on the main page (intranet) - the DISCHARGE type for debarment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 19:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 18:09:57 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #4 from JaTara Barnes --- Created attachment 24028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24028&action=edit Implements syspref for SCO receipt printing - updated to change default to ON -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 19:45:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 18:45:50 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #41 from Chris Cormack --- Comment on attachment 24026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24026 Bug 8007: Discharge management Review of attachment 24026: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8007&attachment=24026) ----------------------------------------------------------------- Just a couple of quick comments, I'll do more. I have to say, I am really not a fan of the ::DataObject:: and ::Service:: idea. I may be overruled on that I guess. I'd prefer a Discharge class I think. ::: Koha/DataObject/Discharge.pm @@ +24,5 @@ > + ); > + > + bless $self, $class; > + return $self; > +} You don't need this, Class::Accessor does this new for you. Including populating the accessors. Thats one of the reasons for using it :) You just call it like this. my $discharge = Koha::DataObject::Discharge->new({borrowernumber => $number, needed => $needed, validated => $validated}); @@ +54,5 @@ > + my $data = $rs->single( { borrower => $self->borrowernumber } ); > + $self->needed( $data->needed ); > + $self->validated( $data->validated ); > + return $self; > +} You could have based this class on Koha::Database and done things like use base qw/Koha::Database/; sub fetch { my $self = shift; my $self->schema->resultset('Discharge')->single( { borrower => $self->borrowernumber}); etc I am a little worried setting a packagewide rs is not safe when run under persistence. But I would need to check that. DBIX::Class is smart, and does pooling and connection reuse for us, we don't need to do it ourselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 19:52:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 18:52:48 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23336|0 |1 is obsolete| | --- Comment #26 from Tom?s Cohen Arazi --- Created attachment 24029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24029&action=edit [SIGNED OFF] Bug 11096: force XML syntax for Zconn and remove MARC::File::USMARC everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 19:53:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 18:53:08 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23337|0 |1 is obsolete| | --- Comment #27 from Tom?s Cohen Arazi --- Created attachment 24030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24030&action=edit [SIGNED OFF] Bug 11096: wrap MARC::Record->new_from_xml call with eval -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 19:53:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 18:53:23 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #28 from Tom?s Cohen Arazi --- Created attachment 24031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24031&action=edit Bug 11096: Make use of MARCXML conditional of DOM being set We have a way of knowing the indexing mode that is in use: C4::Context->config('zebra_bib_index_mode') and C4::Context->config('zebra_auth_index_mode') this patch makes Koha use that to fallback to the old USMARC serialization format for retreiving from Zebra in case we are on a GRS-1 setup. To test. Check tests now pass: $ prove -v t/db_dependent/Search.t Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 20:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 19:04:40 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #42 from Kyle M Hall --- I would recommend ditching the DataObject::Discharge and go with directly using DBIC with Koha::Database. It seems like an unnecessary layer of overhead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 20:07:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 19:07:59 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #43 from Kyle M Hall --- (In reply to Chris Cormack from comment #41) > I have to say, I am really not a fan of the ::DataObject:: and ::Service:: > idea. I may be overruled on that I guess. I'd prefer a Discharge class I > think. I believe in our developer discussions at KohaCon13 the basic consensus was that the DataObject layer was not needed and was just over-complicating everything and adding unnecessary overhead ( it was only in our initial designs to join biblio and biblioitems virtually ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 20:18:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 19:18:54 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #44 from Galen Charlton --- Jonathan: first, let me thank you for engaging with DBIC. (In reply to Kyle M Hall from comment #43) > (In reply to Chris Cormack from comment #41) > > I have to say, I am really not a fan of the ::DataObject:: and ::Service:: > > idea. I may be overruled on that I guess. I'd prefer a Discharge class I > > think. > > I believe in our developer discussions at KohaCon13 the basic consensus was > that the DataObject layer was not needed and was just over-complicating > everything and adding unnecessary overhead ( it was only in our initial > designs to join biblio and biblioitems virtually ). I agree. There are *some* specific cases, most notably bibs, where an intermediate class might be useful to deal with legacy defects in the current data model, and some cases where complicated business logic suggests a container class, but I am not in favor of creating DataObject classes or the like automatically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:19:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:19:24 +0000 Subject: [Koha-bugs] [Bug 11258] Holds queue is still making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:28:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:28:25 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #12 from Nicole C. Engard --- I have seen this, but I would like to note that not always are items.enumchron and serial.serialseq the same thing - I think we actually had someone make it show both a little while back because of just that. I thought I had a bug suggestion a way to break this in to two columns or style it so we can hide one if want but I can't find that bug. I do not vote to removing one altogether though. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:33:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:33:43 +0000 Subject: [Koha-bugs] [Bug 11179] opac-course-details.pl shows item as available when it is checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:34:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:34:43 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:34:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:34:45 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 --- Comment #2 from Nicole C. Engard --- Created attachment 24032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24032&action=edit [SIGNED-OFF] Bug 11475: Links are broken when editing/deleting items in batch Bug introduced by bug 9044. Test plan: 1- First we search for records with multiple items (books or serials, does not matter) 2- We open this record we found with multiple items for editing 3- We chose "Edit items in batch" option from the "Edit" menu 4- We make corrections on the fields under the "Edit item" (For example we change the collection code as "fiction") 5- We save this using "Save button" at the bottom, after we are done. 6- Just after we save, there will be a button named "Done" available just under the page, and when we click on "Done" we encounter the Error screen. Before the patch, the "Done" link points to /cgi-bin/koha/tools/CATALOGUING. After applying the patch, the "Done" link points to the biblio detail page. Signed-off-by: Nicole C. Engard All tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:35:46 +0000 Subject: [Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- Can you provide a screenshot - or instructions to the page where this is a problem so I can see what it used to look like? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:39:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:39:11 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:39:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:39:03 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- Created attachment 24033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24033&action=edit message not showing This patch is awesome and works for everything - but not if the item is on hold. See attached image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:43:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:43:38 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:43:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:43:40 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 --- Comment #4 from Nicole C. Engard --- Created attachment 24034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24034&action=edit [SIGNED-OFF] Bug 11466 - Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' -------------- -- Synopsis -- -------------- When system preference AdvancedSearchTypes has other values than 'itemtypes', for ex 'itemtypes|loc', itemtypes selection in opac-suggestions.pl is not populated with available itemtypes. This patch fixes the issue by broadening the strict comparison of ($advanced_search_types eg 'itemtypes') #fails 'itemtypes|loc' to ($advanced_search_types =~ 'itemtypes') #succeeds 'itemtypes|loc' Unit tests included --------------- -- Test plan -- --------------- REPLICATING THE ISSUE 1. Set system preference AdvancedSearchTypes to itemtypes|loc 2. Go to opac-suggestions.pl and observe Item type dropdown list 2.1. List should have itemtypes available for selection Thanks for testing! You are awesome! gg Signed-off-by: Nicole C. Engard Tests worked as expected. Placed a suggestion and saw the whole list of item types, chose one, saved, checked staff and it loaded as expected. Changed item type in staff and it applied in both views. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:46:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:46:21 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Assignee|koha-bugs at lists.koha-commun |fcapovilla at live.ca |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:50:41 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:50:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:50:44 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23363|0 |1 is obsolete| | --- Comment #1 from Nicole C. Engard --- Created attachment 24035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24035&action=edit [SIGNED-OFF] Add the borrower's cardnumber and phonenumber to the branch overdues. http://bugs.koha-community.org/show_bug.cgi?id=11359 Signed-off-by: Nicole C. Engard All tests pass, this adds data to the Patron column on the overdues with fines report to show the patron's cardnumber and phone number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:51:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:51:13 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 8 21:55:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 20:55:36 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #8 from Nicole C. Engard --- Can we have a test plan? A page with a table we should look at to see it before and after? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 00:23:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jan 2014 23:23:08 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #28 from Jesse Weaver --- Created attachment 24036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24036&action=edit Bug 10486 QA followup: Fix license headers, add tests XSLT.t is the only one modified, so to run the tests, just do: prove t/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 01:19:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 00:19:47 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from David Cook --- (In reply to Nicole C. Engard from comment #2) > Created attachment 24033 [details] > message not showing > > This patch is awesome and works for everything - but not if the item is on > hold. See attached image. Nicole, that was intentional. If you look at the OPAC, you should see the same behaviour, because you shouldn't be able to renew an item that has been placed on hold. I'll move this back to "Needs Signoff", but happy to have a discussion about this, if folks want. I don't think there are cases where you can renew a book that is on hold for someone else, but perhaps I'm wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 01:21:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 00:21:09 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #10) > I guess you are right, there are some overlaps. A list of words won't ever > be perfect, but I think perfect is not really achievable here without going > totally overboard :) I think a list of words in a pref would give more > flexibility, allow the feature to be deactivated totally or adjusted to each > libraries collection. Agreed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 05:13:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 04:13:56 +0000 Subject: [Koha-bugs] [Bug 11500] New: Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Bug ID: 11500 Summary: Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently, the dateformat system preference isn't used when cataloguing items with dates. That is, if you're adding/modifying/viewing a date when cataloguing an item, you'll see it in 'iso' format. This makes sense since this is the date format that is used in the database, but staff might think that they can enter dates based on the dateformat syspref. If we handle the dates based on dateformat, we get around that. Another idea is using the datepicker so that staff don't even need to manually enter dates. Like other parts of Koha, they could just pick the date (ideally in accordance with the dateformat syspref - like in circulation - but this could even work with iso format). We've had one librarian bring it up, but I'm not sure this is something that we're necessarily going to pursue. I thought I would bring it up anyone though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 05:34:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 04:34:50 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 JaTara Barnes changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jendayi30 at gmail.com --- Comment #5 from JaTara Barnes --- Created attachment 24037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24037&action=edit Implements syspref for SCO receipt printing -- updated default value + template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:12:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:12:30 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #6 from JaTara Barnes --- Created attachment 24038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24038&action=edit Implements syspref for SCO receipt -- added code to prog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:31:00 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #7 from M. Tompsett --- Created attachment 24039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24039&action=edit Bug 11415: Add syspref to toggle receipt printing for self-check Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:31:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:31:03 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #8 from M. Tompsett --- Created attachment 24040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24040&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Simple change to updatedatabase.pl to set SCO receipt printing as default Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:31:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:31:06 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #9 from M. Tompsett --- Created attachment 24041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24041&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Updated files to set default to 1 in sysprefs.sql. Also added code to pass the parameter to the template page, Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:31:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:31:09 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #10 from M. Tompsett --- Created attachment 24042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24042&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Added code to update prog Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:35:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:35:47 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #11 from M. Tompsett --- Created attachment 24043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24043&action=edit [SIGNED OFF] Bug 11415: Add syspref to toggle receipt printing for self-check Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:35:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:35:50 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #12 from M. Tompsett --- Created attachment 24044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24044&action=edit [SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing Toggled SCO receipt printing to be on by default for upgrades in updatedatabase.pl. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:35:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:35:53 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #13 from M. Tompsett --- Created attachment 24045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24045&action=edit [SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing Updated files to set default to 1 in sysprefs.sql. Also added code to read the system preference on the template page. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:35:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:35:55 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #14 from M. Tompsett --- Created attachment 24046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24046&action=edit [SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing Added code to update prog theme with same changes as the bootstrap theme. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:36:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:36:14 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23904|0 |1 is obsolete| | CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:36:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:36:31 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:36:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:36:45 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:37:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:37:03 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24038|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:37:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:37:28 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24039|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:37:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:37:44 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24040|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:38:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:38:00 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24041|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:38:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:38:20 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:40:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:40:48 +0000 Subject: [Koha-bugs] [Bug 11501] New: Add Zebra index for "Local-Subjects" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11501 Bug ID: 11501 Summary: Add Zebra index for "Local-Subjects" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, we store MARC21 690 in the Subject index, but perhaps we should also store it in a Local-Subject index. (I'm not really sure why, but it's something that we've done locally for a while.) We might also want to include 691, 695, 696, 697, 698, 699 in both the Subject and Local-Subject indexes, as these are also valid subject fields. It looks like Robin has created bug 10308 to deal with adding authority linking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:51:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:51:32 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from M. Tompsett --- REVISED TEST PLAN ================= 0. ~/qa-test-tools/koha-qa.pl -v 2 -c 4 NOTE: Fix tabs. 1. Log into self-check as normal. (https://.../cgi-bin/koha/sco/sco-main.pl) 2. Check something out. 2. Click the "Finish" button. 3. Notice that receipt dialog pops up. 4. Apply patch. 5. Run updatedatabase.pl 6. Set the SelfCheckReceiptPrompt syspref to "Don't show" 7. Log into self-check. 8. Check something out. 9. Click the "Finish" button. 10. Verify that the receipt dialog does NOT pop up. 11. Set the SelfCheckReceiptPrompt syspref to "Don't show" 12. Log into self-check. 13. Check something out. 14. Click the "Finish" button. 15. Verify that the receipt dialog does NOT pop up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 06:54:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 05:54:32 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #16 from M. Tompsett --- Oops... got hit by the cut-and-paste problem. Fixed step 11. :) REVISED TEST PLAN ================= 0. ~/qa-test-tools/koha-qa.pl -v 2 -c 4 NOTE: Fix tabs. 1. Log into self-check as normal. (https://.../cgi-bin/koha/sco/sco-main.pl) 2. Check something out. 2. Click the "Finish" button. 3. Notice that receipt dialog pops up. 4. Apply patch. 5. Run updatedatabase.pl 6. Set the SelfCheckReceiptPrompt syspref to "Don't show" 7. Log into self-check. 8. Check something out. 9. Click the "Finish" button. 10. Verify that the receipt dialog does NOT pop up. 11. Set the SelfCheckReceiptPrompt syspref to "Show" 12. Log into self-check. 13. Check something out. 14. Click the "Finish" button. 15. Verify that the receipt dialog does NOT pop up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 07:05:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 06:05:19 +0000 Subject: [Koha-bugs] [Bug 11502] New: Branch filter in "Holds To Pull" is too fuzzy Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Bug ID: 11502 Summary: Branch filter in "Holds To Pull" is too fuzzy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, in the "Holds to Pull" list, the filter is too fuzzy/not exact enough. The Scenario: 1 - You have a hold on an item at branch NM 2 - You have a hold on an item at branch NMH 3 - You have a hold on an item at either branch NM, NA, NB Currently, if you filter by 'NM', you'll get all three holds to pull, even though you really only want holds 1 and 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 07:05:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 06:05:29 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 07:17:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 06:17:53 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 07:17:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 06:17:57 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 --- Comment #1 from David Cook --- Created attachment 24047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24047&action=edit Bug 11502 - Branch filter in "Holds To Pull" is too fuzzy This patch uses regex checking via the DataTables fnFilter API method to make the branch filter more precise on the "Holds to Pull" page. The ability to use regex is built into DataTables so this just adds the actual expression. _TEST PLAN_ Before applying: 1) Add library (branches) with codes of NM, NMH, and NB 2) Add items (that can be placed on hold) at all these branches 3) Place a hold on an item that is only available at NM 4) Place a hold on an item that is only available at NMH 5) Place a hold on an item that is only available at NM and NB 6) Go to "Holds to Pull" in the Circulation module 7) Filter by these three different values 8) Note that filtering by "NM" will incorrectly bring up all three holds, while "NMH" and "NB" will only pull up one (like they should). Apply the patch. 9) Shift+refresh the page so that your Javascript refreshes 10) Repeat step 7 (filtering by the different branch values) 11) Note that filtering by "NM" will now only bring up the hold for "NM" and the hold for "NM" and "NB", while the others still only bring up one hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 08:49:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 07:49:27 +0000 Subject: [Koha-bugs] [Bug 11503] New: Several typos Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Bug ID: 11503 Summary: Several typos Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org "Acquistions" in intranet-tmpl/prog/en/modules/help/reports/guided_reports.tt "secton" in intranet-tmpl/prog/en/modules/help/members/member-flags.tt "Van der Griten" (should be Van der Grinten) in intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_120.tt "exisiting" in intranet-tmpl/prog/en/modules/authorities/authorities.tt and intranet-tmpl/prog/en/modules/help/serials/subscription-frequencies.tt "techniqu" in intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_121a.tt "ressource" in intranet-tmpl/prog/en/includes/subtypes_unimarc.inc, opac-tmpl/prog/en/includes/subtypes_unimarc.inc and opac-tmpl/bootstrap/en/includes/subtypes_unimarc.inc "cliam" in intranet-tmpl/prog/en/modules/help/acqui/lateorders.tt "possesion" in intranet-tmpl/prog/en/modules/reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 08:56:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 07:56:07 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 08:56:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 07:56:11 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24047|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24048&action=edit Bug 11502 - Branch filter in "Holds To Pull" is too fuzzy This patch uses regex checking via the DataTables fnFilter API method to make the branch filter more precise on the "Holds to Pull" page. The ability to use regex is built into DataTables so this just adds the actual expression. _TEST PLAN_ Before applying: 1) Add library (branches) with codes of NM, NMH, and NB 2) Add items (that can be placed on hold) at all these branches 3) Place a hold on an item that is only available at NM 4) Place a hold on an item that is only available at NMH 5) Place a hold on an item that is only available at NM and NB 6) Go to "Holds to Pull" in the Circulation module 7) Filter by these three different values 8) Note that filtering by "NM" will incorrectly bring up all three holds, while "NMH" and "NB" will only pull up one (like they should). Apply the patch. 9) Shift+refresh the page so that your Javascript refreshes 10) Repeat step 7 (filtering by the different branch values) 11) Note that filtering by "NM" will now only bring up the hold for "NM" and the hold for "NM" and "NB", while the others still only bring up one hold. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 09:04:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 08:04:09 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 09:04:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 08:04:13 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19007|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 24049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24049&action=edit Bug 10451 - Firefox prints only first page of table with shrink to fit option According to Firefox bug tracker, versions up to 21 doesn't print tables correctly when using shrink to fit option. See: https://bugzilla.mozilla.org/show_bug.cgi?id=684622 However, even with v21 or newer, we still need to add css to print media which instruct it not to break table tag to print all pages of table. This has a side-effect that table starts always on next page, wasting some space on first printed page (but only in Firefox since CSS selector is specific to it). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 09:20:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 08:20:38 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #13 from Olli-Antti Kivilahti --- Reading your test cases, and good job with the description! There is one concern! What if a patron defines to his own messaging preferences sms and email, but has no sms notification number defined nor email. This can easily be done accidentally. This might needlessly bloat our print notifications queue and cause lots of extra costs. Would it be possible to add a check that; if email or sms is succesfully sent, even if the other email or sms has failed, no print notice is generated. This is slightly problematic to implement but shouldn't be too difficult. Also a patron can request email and sms, buth have no such contact details. In this case the email is sent via print notice + the sms replaced with another print notice! In addition there should be a check in place to enforce that a patron cannot set his messaging preferences if sms or email is missing, but that is not in this bug's scope. Or is it the only way to send HOLD notifications via print? What if our patrons don't have sms or email? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 09:44:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 08:44:08 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #14 from Olli-Antti Kivilahti --- BTW Could apply this patch now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 09:56:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 08:56:35 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #15 from Olli-Antti Kivilahti --- If I have had email and sms defined, but subsequently removed those contact details, I suspect this condition brings falsehood: if ( ($mtt eq 'email' and not $to_address) or ($mtt eq 'sms' and not $borrower->{smsalertnumber}) ) { $to_address and $borrower->{smsalertnumber} are defined as empty Strings and validate true in Perl. Thus I have been unable to trigger the double print notification bug, but instead got sms and email notifications with destination of '' == empty String -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 10:05:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 09:05:28 +0000 Subject: [Koha-bugs] [Bug 11504] New: Untranslatable "Item Type" or "Collection Code" in branch transfer limits Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Bug ID: 11504 Summary: Untranslatable "Item Type" or "Collection Code" in branch transfer limits Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The string "Item Type" or "Collection Code" shows up in branch transfer limits, eg. in the text "For all Item Types:", and does not come via the i18n toolchain. The text is hard-coded in admin/branch_transfer_limits.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 10:25:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 09:25:14 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #25 from Fridolin SOMERS --- (In reply to mathieu saby from comment #23) > I did not read all the comments, but for some libraries, what is needed in > statistical table is BOTH items.itype and biblioitems.itemtype, and maybe a > clear indication (a 3rd column "circulation_type" ?) of which type is was > used for circulation rights. Very good idea. I think more information will be better for many libraries. But in another bug because it will be an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 10:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 09:45:37 +0000 Subject: [Koha-bugs] [Bug 11505] New: Untranslatable table headers in Label batch manager Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Bug ID: 11505 Summary: Untranslatable table headers in Label batch manager Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In Label Batch manager, after adding the items to the batch, you're presented with a table showing information about the items. The table column headers are in English, and cannot be translated. The texts are hard-coded in $display_columns in labels/label-edit-batch.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 10:52:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 09:52:45 +0000 Subject: [Koha-bugs] [Bug 11506] New: Untranslatable table headers in several perl files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11506 Bug ID: 11506 Summary: Untranslatable table headers in several perl files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr html_table headers are hard-coded (and therefore untranslatable) in label/label-item-search.pl, label/label-manage.pl, patroncards/edit_batch.pl, patroncards/manage.pl, patroncards/image-manage.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 11:05:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 10:05:26 +0000 Subject: [Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 --- Comment #3 from Jonathan Druart --- Created attachment 24050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24050&action=edit Itemnumbers are display without the patch Hi Nicole, Here a screenshot of a detail page (acquisition details tab). You can see that itemnumbers are displayed, without the patch. If you apply the patch, they disappear. See comment 30 and comment 32 from bug 8230. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 11:40:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 10:40:12 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #45 from Jonathan Druart --- Thanks all 3 of you for your looks! The idea of Service and DataObject was to separate methods for a discharge object from others routines which are not directly linked to the object ("Manager"). Don't you think if we put all the code in a Koha::Discharge package we will get back to a new Koha namespace with big files where responsibilities are not enough separated? What is the problem with having a simple business object? I don't understand where the complexity is added, to me it is simplified. Should I put all methods/routines from Service::Discharge and DataObject::Discharge to Koha::Discharge? I personally think we should not call Koha::Database in pl files, do we agree with that? If you think it is not the way to do, where can I find a RFC / consensus on how developers should develop using oop into Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:36:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:36:54 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22412|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 24051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24051&action=edit Bug 11141: Filters are not kept on receiving. On receiving orders, the librarian has to filter again the pending orders list. This patch stores the filters in a cookie in order to apply them when the librarian finish a receive and come back on the pending orders list. Test plan: 1/ choose a vendor with several baskets and orders. 2/ start to receive an item. 3/ on the pending orders page, add some relevant filters. 4/ receive an item. 5/ you are back on the pending orders page and filters are directly applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:37:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:37:19 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 --- Comment #3 from Jonathan Druart --- Last patch is just a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:45:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:45:58 +0000 Subject: [Koha-bugs] [Bug 11507] New: add the possibility to filter order by parent_ordernumber in receipt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 Bug ID: 11507 Summary: add the possibility to filter order by parent_ordernumber in receipt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org After a transfer of order in a new basket, the ordernumber is changing. Sometimes, we keep a track the old ordernumber so it can be usefull to be able to retrieve the order by the old ordernumber. This patch add the possibility, when receiving shipment, to enter the old ordernumber and to retrieve the order. Test plan : - choose an order and notes its ordernumber - transfer it to a new a basket and notes the new ordernumber _ in receipt page, in the filter box, enter the older ordernumber or the new ordernumber: you can find the order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:50:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:50:02 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22546|0 |1 is obsolete| | Attachment #22547|0 |1 is obsolete| | Attachment #22548|0 |1 is obsolete| | Attachment #22549|0 |1 is obsolete| | Attachment #22550|0 |1 is obsolete| | Attachment #22551|0 |1 is obsolete| | Attachment #22552|0 |1 is obsolete| | Attachment #22553|0 |1 is obsolete| | Attachment #22554|0 |1 is obsolete| | Attachment #22555|0 |1 is obsolete| | Attachment #22556|0 |1 is obsolete| | Attachment #22557|0 |1 is obsolete| | Attachment #22558|0 |1 is obsolete| | Attachment #22559|0 |1 is obsolete| | --- Comment #143 from Jonathan Druart --- Created attachment 24052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24052&action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:50:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:50:14 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #144 from Jonathan Druart --- Created attachment 24053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24053&action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:50:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:50:23 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #145 from Jonathan Druart --- Created attachment 24054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24054&action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:50:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:50:33 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #146 from Jonathan Druart --- Created attachment 24055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24055&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:50:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:50:42 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #147 from Jonathan Druart --- Created attachment 24056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24056&action=edit Bug 7180: The default quantity is 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:50:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:50:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #148 from Jonathan Druart --- Created attachment 24057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24057&action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:51:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:51:01 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #149 from Jonathan Druart --- Created attachment 24058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24058&action=edit Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:51:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:51:11 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #150 from Jonathan Druart --- Created attachment 24059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24059&action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:51:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:51:20 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #151 from Jonathan Druart --- Created attachment 24060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24060&action=edit Bug 7180: FIX License version Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:51:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:51:30 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #152 from Jonathan Druart --- Created attachment 24061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24061&action=edit Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:51:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:51:39 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #153 from Jonathan Druart --- Created attachment 24062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24062&action=edit Bug 7180 - QA Followup - Correct minor language issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:51:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:51:50 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #154 from Jonathan Druart --- Created attachment 24063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24063&action=edit Bug 7180: Restore the "Add order" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:52:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:52:00 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #155 from Jonathan Druart --- Created attachment 24064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24064&action=edit Bug 7180: Remove useless rrp variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:52:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:52:10 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #156 from Jonathan Druart --- Created attachment 24065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24065&action=edit Bug 7180: FIX: discount was divided by 100 twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:52:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:52:55 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #157 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:57:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:57:50 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #10 from M. Tompsett --- Comment on attachment 15203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15203 Proposed patch Review of attachment 15203: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9580&attachment=15203) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt @@ +305,5 @@ > > +[% IF ( CoceProviders ) %] > +KOHA.coce.getURL('[% CoceHost %]', '[% CoceProviders %]'); > +[% END %] > + This was here from the beginning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:58:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:58:07 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #11 from M. Tompsett --- Comment on attachment 16778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16778 Proposed patch (v2) Review of attachment 16778: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9580&attachment=16778) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt @@ +305,5 @@ > > +[% IF ( CoceProviders ) %] > +KOHA.coce.getURL('[% CoceHost %]', '[% CoceProviders %]'); > +[% END %] > + This disappeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 12:58:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 11:58:34 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #12 from M. Tompsett --- Comment on attachment 21162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21162 Proposed patch (v3 rebased on master) Review of attachment 21162: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9580&attachment=21162) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt @@ +333,4 @@ > [% IF OPACLocalCoverImages %]KOHA.LocalCover.GetCoverFromBibnumber(false);[% END %] > [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] > > +<<<<<<< HEAD I think a rebase didn't quite work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:06:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:06:47 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22536|0 |1 is obsolete| | Attachment #22537|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 24066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24066&action=edit Bug-10477 Increased flexibility for upload of Staged When uploading bulk MARC records against existing records need further option to allow the process to just add/merge extra MARC tags rather than having to completely overwrite an existing record or just leave the existing record unchanged. Test Plan: 1. Click on Tools->Stage MARC records for import. 2. Upload the MARC file for ex: first.mrc 3. Click on upload button. 4. Choose Record matching rule: 020$a ISBN. 5. Choose Action if matching record found: Append or update MARC21/UNIMARC tag a text box will appear after choosing enter MARC tag for ex: 700a which you want to merge. 6. Click on Stage for import button. 7. On the next screen click on Manage staged records. 8. You can also edit the record matching rule in manage record screen. 9. Click on Import this batch on catalog button. 10. Next screen will give no of record updated. 11. It will check duplicate field record for ex: 700$aamit is already in record it will skip the tag and move to next. Signed-off-by: Amit Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:06:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:06:54 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 --- Comment #10 from Jonathan Druart --- Created attachment 24067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24067&action=edit Bug-10477-Alter table import_batches Added overlay_action to "appendmarctag" and new column "marctag" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:07:29 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- Rebased patches. I did not test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:11:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:11:08 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22386|0 |1 is obsolete| | Attachment #22734|0 |1 is obsolete| | Attachment #22735|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 24068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24068&action=edit Bug 11023: Toggle "new" status This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjob/toggle_new_status.pl). Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools > items_batchmod permission. - navigate to Home > Tools > Toggle new status - click on the edit button - there are 3 "blocks": * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:11:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:11:13 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #11 from Jonathan Druart --- Created attachment 24069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24069&action=edit Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:11:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:11:18 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #12 from Jonathan Druart --- Created attachment 24070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24070&action=edit Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:11:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:11:34 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #13 from Jonathan Druart --- rebased patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:23:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:23:27 +0000 Subject: [Koha-bugs] [Bug 11508] New: Untranslatable pull-down in auth_subfields_structure.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Bug ID: 11508 Summary: Untranslatable pull-down in auth_subfields_structure.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The pull-down for "Select to display or not:" contains strings "Show All" and "Hide All", these are hard-coded in admin/auth_subfields_structure.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:25:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:25:24 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #13 from Fr?d?ric Demians --- > > +<<<<<<< HEAD > > I think a rebase didn't quite work. It doesn't look good at all! I fix that, and add markup to Bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 13:50:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 12:50:12 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21162|0 |1 is obsolete| | --- Comment #14 from Fr?d?ric Demians --- Created attachment 24071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24071&action=edit Proposed patch v4 Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'prog' and 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:26:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:26:34 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:26:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:26:38 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23013|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 24072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24072&action=edit Bug 10646 - warn if mod_rewrite is not enabled Koha requires mod_rewrite. If it's not enabled in Apache, then koha-create will now abort with a helpful error message. Also adds a warning when not run as root to avoid confusing errors. Test plan: * apply the patch * a2dismod rewrite * run koha-create without sudo, note the error about being root * run koha-create with sudo, note the error about rewrite * a2enmod rewrute * repeat test above, note that it works Signed-off-by: Tomas Cohen Arazi Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:45:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:45:27 +0000 Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21703|0 |1 is obsolete| | --- Comment #26 from Olli-Antti Kivilahti --- Created attachment 24073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24073&action=edit Bug 6113 [ENH] - enhancement to keep previous ids Modified the C4::Biblio::_koha_add_biblioitem() && _koha_add_biblio() to support INSERTing biblionumbers and biblioitemnumbers to the Koha DB. Created validators to make sure the primary keys are positive integers and well below the Perl's LONG_MAX threshold to keep Koha from getting crazy. Duplicate id's are the users responsibility and in normal use conditions they are non-existing, unless the "Koha to MARC mapping" to biblionumber is a user-modifiable MARC field, which is TROUBLE! MySQL takes care of the primary key sequence refreshing. Updated the bulkmarcimport.pl -script to copy the desired legacy id MARC field to the biblionumber- and biblioitemnumber-fields designated in "Koha to MARC mapping", eg. copy field 001 to 999c and 999d. This is handy if you have the legacy id in just 001 and need to populate 999c and 999d to push them to DB. No need to make an extension to the existing migration scripts. Documented the new functionality in bulkmarcimport.pl Created test cases for C4::Biblio.pm modifications. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:48:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:48:11 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12842|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 24074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24074&action=edit Bug 8438: Followup Set the superserials permission for all users with the claim_serials permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:48:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:48:25 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #10 from Jonathan Druart --- Rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:48:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:48:33 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22719|0 |1 is obsolete| | --- Comment #50 from Julian Maurice --- Created attachment 24075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24075&action=edit [SIGNED-OFF] Bug 7162: Factorize code for order cancellation Some code was duplicated, all is now in cancelorder.pl Added possibility to provide a reason for cancellation (or other things, this is saved in aqorders.notes) Signed-off-by: Corinne Bulac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:48:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:48:46 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22720|0 |1 is obsolete| | --- Comment #51 from Julian Maurice --- Created attachment 24076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24076&action=edit [SIGNED-OFF] Bug 7162 [Follow-up] Fix referrer URL when coming from parcel.pl Signed-off-by: Corinne Bulac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:49:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:49:02 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22721|0 |1 is obsolete| | --- Comment #52 from Julian Maurice --- Created attachment 24077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24077&action=edit Bug 7162; Factorize code for order cancellation (QA fixes) * Remove tab characters in acqui/addorder.pl * Remove FIXME in acqui/cancelorder.pl * Fix typos: "canceled" -> "cancelled", "occured" -> "occurred" * Replace "Click here" link by "OK" * Add a column to aqorders to store cancellation reason instead of having it in aqorders.notes, to avoid having untranslatable strings in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:49:44 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #53 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:53:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:53:20 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23708|0 |1 is obsolete| | --- Comment #33 from Julian Maurice --- Created attachment 24078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24078&action=edit Bug 8064: Merge several biblios Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:53:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:53:32 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23709|0 |1 is obsolete| | --- Comment #34 from Julian Maurice --- Created attachment 24079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24079&action=edit Bug 8064: Change the way target record is built. Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:53:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:53:42 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23710|0 |1 is obsolete| | --- Comment #35 from Julian Maurice --- Created attachment 24080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24080&action=edit Bug 8064: Fix issues with control fields and non-repeatable check Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:54:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:54:49 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20946|0 |1 is obsolete| | Attachment #22746|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 24081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24081&action=edit Bug 10857: Add facets cancellation When searching (at the OPAC or pro), facets can be enabled but never disabled. So a user is obliged to relaunch the search. This patch adds a new link "[x]" at the right of each selected facet. This link relaunch the search without this facet. Test plan: - Launch a search (OPAC and pro) - Enable some facets - Disable some facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:54:57 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #36 from Jonathan Druart --- Created attachment 24082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24082&action=edit Bug 10857: Encode 'limit' parameter values to allow facets with '&' character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:55:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:55:34 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #37 from Jonathan Druart --- rebased patch. Only available for the prog theme (for now). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 14:56:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 13:56:03 +0000 Subject: [Koha-bugs] [Bug 11509] New: koha-create should print better usage information Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Bug ID: 11509 Summary: koha-create should print better usage information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The usage information is not helpful as-is. It can be refactored a bit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:02:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:02:13 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21583|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 24083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24083&action=edit Bug 10212: Columns configuration for tables - Add Colvis files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:02:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:02:21 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21584|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 24084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24084&action=edit Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the checkouts page (circ/circulation.pl). 4/ Check that you cannot hide the 3 last columns on the issues table. 5/ Check that you cannot hide the 2 last columns on the holds table. 6/ Try to hide/show columns. 7/ Go on the columns configuration page (admin/columns_settings.pl). 8/ Only the last tab are filled with data. Check/uncheck checkboxes and save. 9/ Go on the checkouts/holds page and check that the behavior is what you expected. 10/ Give me some feedback :) * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:02:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:02:35 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21585|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 24085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24085&action=edit Bug 10212: Make the table names translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:03:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:03:03 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #26 from Jonathan Druart --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:05:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:05:38 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23580|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart --- Created attachment 24086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24086&action=edit Bug 9593 Prices not imported correctly from a staged file Initial bug : When there's a round price with no decimals after it, or when the symbol is after the digits, the price is not captured by regular expression in MungeMarcPrice routine and the variable is not initialized. Enhancement : The MungeMarcPrice routine had been widely modified. It 's still possible to priority pick the active currency but unlike the previous mechanism that worked only for prices preceded by the currency sign, it's now valid wherever the symbol is situated. As symbol you may enter a pure currency sign as well as a string including it like '$US'. Moreover, an 'isocode' column had been added in currency table (editable in the pro interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:06:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:06:11 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #57 from Jonathan Druart --- rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:08:18 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23625|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 24087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24087&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are not in OPACHideOpenURLForItemTypes) 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" 9/ Repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:08:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:08:26 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23626|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 24088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24088&action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:08:33 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23627|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 24089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24089&action=edit Bug 8995: Show OpenURL links in bootstrap theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:08:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:08:48 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #13 from Jonathan Druart --- rebased patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:13:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:13:54 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:13:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:13:58 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 24090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24090&action=edit Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:14:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:14:34 +0000 Subject: [Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- fatal: sha1 information is lacking or useless (C4/Reserves.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:15:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:15:05 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:29:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:29:31 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 --- Comment #15 from Petter Goks?yr ?sen --- Created attachment 24091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24091&action=edit [SIGNED-OFF] Sorry about the confusion. I forgot to start the SIP server manually, using the koha-start-sip command instead. So naturally then I couldnt see any effect. But now I did it the right way! And I can confirm that this patch solves all issues with mangled characters in SIP messages. Confirmed that it looks good with Norwegian characters in patron name and in book titles. Signed-off-by: Petter Goksoyr Asen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:45:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:45:10 +0000 Subject: [Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 --- Comment #1 from Koha Team Lyon 3 --- Created attachment 24092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24092&action=edit Bug 11507 - add the possibility to filter order by parent_ordernumber in receipt After a transfer of order in a new basket, the ordernumber is changing. Sometimes, we keep a track the old ordernumber so it can be usefull to be able to retrieve the order b Test plan : - choose an order and notes its ordernumber - transfer it to a new a basket and notes the new ordernumber _ in receipt page, in the filter box, enter the older ordernumber or the new ordernumber: you can find the order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:45:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:45:40 +0000 Subject: [Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 15:47:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 14:47:32 +0000 Subject: [Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:01:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:01:40 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23982|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard --- Created attachment 24093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24093&action=edit [SIGNED-OFF] Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record This patch adds the renewal count to the 'Check out' and "Details' tabs of the patron record. This information already exists in the OPAC view of the patron record. Since librarians might be serving patrons in person who want to know this information without looking it up online, it makes sense to show it in the staff client. There may also be times where librarians want to see how many renewals a patron has left, how many they've used already, etc. when making other decisions. _TEST PLAN_ Before applying: 1) Go to "Check out" with a patron that has some check outs before today 2) Add some check outs for today *Ensure that all issues are for items that can be renewed* 3) Note that the Renew column just says '0' followed by a check box 4) Check the 'Detail' tab. It should say the same. Apply the patch. 5) View the "Details" and "Check out" tabs again 6) Note that the renewal count now appears in the form resembling: 5 of 5 renewals remaining Signed-off-by: Nicole C. Engard All tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:01:38 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:02:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:02:21 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 --- Comment #5 from Nicole C. Engard --- Signed off! I'll report another bug - I think that just cause you can't renew doesn't mean you shouldn't see that you did renew :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:07:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:07:46 +0000 Subject: [Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:07:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:07:48 +0000 Subject: [Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23569|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard --- Created attachment 24094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24094&action=edit [SIGNED-OFF] Bug 11397: Remove the itemnumber list on the Acquisition detail tab Test plan: - verify this patch does not introduce regression on the enhancement introduced by bug 8230. - verify the itemnumber list does not appears anymore. Signed-off-by: Nicole C. Engard The acquisitions details tab on the holdings table in the staff client no longer shows the links to the items. Tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:11:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:11:51 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23261|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart --- Created attachment 24095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24095&action=edit Bug 9811: Patron search improvement This patch add DataTables using server-side processing for the patrons search. It adds: - 1 module C4/Utils/DataTables/Members.pm - 2 services svc/members/search and svc/members/add_to_list - 1 template members/tables/members_results.tt - 1 new practice which is to add template for DataTables in a subdirectory named 'tables'. Impacted scripts: members/members-home.pl and members/members.pl To go further: We can imagine that all patrons searches use the same service with no big changes: 1 little template creates a JSON file and to implement DataTables on the template page, that's all. Amended patch: Since bug 10565 has been pushed, these patches don't apply cleanly. I had to rewrite a part of the patron list feature. I removed the choice to add all resultant patrons from a search. I think this choice is useless with this patch: we are able to display the number of patrons we want and to select all of them. Test plan: - Check that there is no regression on searching patrons. - Try filters on the left of the screen. - Try to sort each column. - Try the "Browse by last name" links. - Check that the "Clear" button clears yours filters. - Try with IndependantBranches ON and OFF. - Verify this feature does not break the patron list feature (cf bug 10565). Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer Passes all tests and QA script, couldn't find any regressions or problems. Some notes left on the bug. Bug 9811: Add unit tests for C4::Utils::DT::Members Signed-off-by: Katrin Fischer Bug 9811: QA followup - removes 2 tabs - removes mysqlisms - add sort on borrowernotes - fix wrong capitalization - cat => Category Signed-off-by: Katrin Fischer Thx for fixing these! Bug 9811 - multilines notes brakes JSON In new patron search feature, the search results are fetched using Ajax and returned in JSON format. The JSON is created by TT using koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt. One of the fields is the borrower notes. When this notes contains several lines, the JSON is broken. This patch uses TT fileters to consert in notes linefeeds into HTML line break (html_line_break) and then remove linefeeds (collapse). Test plan : - perform a member search that does not return a borrower with a circ note - edit one of the borrowers returned by this search - enter serveral lines of text in "Circulation note" and save - reperform the member search => circ note is well displayed on several lines Bug 9811: use count(primary_key) instead of count(*) Bug 9811: A limit clause should be always added. By default, we want to retrieve 20 first results. Bug 9811: Load the page without any data. Displaying the first 20 patrons is not useful. With this patch, the table is hidden and no record is retrieved by default. On the same way, the existing side effect on redirect disappears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:13:34 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #75 from Jonathan Druart --- Rebased patch. Fix conflicts with bug 10834 and add support for search on sort1 and sort2 fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:21:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:21:08 +0000 Subject: [Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Hello, I am something like that in my patches queue. The way you do that will work but will certainly introduce side effect. For ex. in acqui/orderreceive.pl: $results = SearchOrders({ ordernumber => $ordernumber }) if $ordernumber; The search on the parent ordernumber has to be done explicitly. Marked as Failed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:26:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:26:45 +0000 Subject: [Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 --- Comment #3 from Jonathan Druart --- You can have a look at the Matthias's work in the BibLibre repository: http://git.biblibre.com/?p=kohac;a=shortlog;h=refs/heads/paris-sud/ft/MT13320 See the 3 patches on top (Marked MT13320). It is not validated in our side for the moment, so I don't submit a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:33:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:33:21 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:33:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:33:26 +0000 Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21461|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 24096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24096&action=edit Bug 10942: Provide a way for package upgrades to update template translations This patch adds a new config variable AUTOMATIC_TRANSLATIONS_UPDATE at /etc/default/koha-common that is used to control whether the upgrade process should trigger a $ koha-translate --update command for each installed template translation language. To test: - Have a koha-common setup with some languages installed (e.g. koha-translate --install es-ES) - Apply the patch and build a package for it. - Install it. - A new AUTOMATIC_TRANSLATIONS_UPDATE config variable should be in place at /etc/default/koha-common - Set AUTOMATIC_TRANSLATIONS_UPDATE to 'yes' - Re-install the package to trigger the post-install script - Verify that translations get updated. Edit: added a warning message for the case AUTOMATIC_TRANSLATIONS_UPDATE=no and there are translations installed (so they need to get updated). Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:39:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:39:18 +0000 Subject: [Koha-bugs] [Bug 11510] New: Typo in koha-translate usage message Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Bug ID: 11510 Summary: Typo in koha-translate usage message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The koha-translate's usage message has a couple of inconsistencies: '--all' should be '--available' and '--help' is missing from the usage examples. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:39:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:39:31 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:43:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:43:07 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Hi David, Could you explain why you match the < and >? The ^$ are not enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:44:30 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:44:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:44:35 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 24097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24097&action=edit Bug 11510: koha-translate usage message fixes The koha-translate's usage message has a couple of inconsistencies: '--all' should be '--available' and '--help' is missing from the usage examples. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:50:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:50:14 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24090|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 24098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24098&action=edit Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 16:57:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 15:57:53 +0000 Subject: [Koha-bugs] [Bug 11511] New: Keep stats on opac logins Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11511 Bug ID: 11511 Summary: Keep stats on opac logins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would be nice to be able to keep stats on the number of times users are logging in to the opac. Maybe a table (or part of the stats table) that stores borrowernumber (so we could query patron categories and branches) and the number of times they clicked the 'login' button on the opac? or if in the stats table the date/time of the login so it can be counted in a report? Just an idea - I often get asks about the number of logins to the opac. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:07:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:07:49 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 --- Comment #3 from Mirko Tietgen --- (In reply to mathieu saby from comment #2) > Maybe it is in ccl.properties, but I believe it would be a bad idea to > follow it on this point ;-) > The 2 information should be in different indexes. In Unimarc, we use pl for > 210 (the same as 260) and Country-publication for 102$a field (if I remember > well) for the country. At the moment, it is 008/15-17 and ALL 260 subfields. I'm not trying to make it worse but better, but based on what is in that file. ;) And I would like to get 260$e (Place of manufacture) out of the index. But perhaps you are right, ignoring what ccl.properties says and instead setting up an index just for 260$a would be a better idea. Maybe others have an opinion on that? > By the way, the "pl" index is completely useless for the average user in an > academic or public library, at least according to my experience. Because > I've never seen a reader looking for "a book published in London", or "All > the books published in Paris". > I think it's more a librarian-centered information. We have a lot of video material and a search for ?movies from $country? is very likely. ?movies published in London? not so much I guess. ;D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:14:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:14:04 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20537|0 |1 is obsolete| | --- Comment #17 from Matthias Meusburger --- Created attachment 24099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24099&action=edit proposed patch This patch solves the problems previously discussed: - The 3 new fields (origin, domain and ccode) that had an unclear use-case and were too specific were removed from the patch, as Bug 10855 will do the job in a more generic way. - The hardcoding for 995$l was replaced by a marc-agnostic version (as Fridolin suggested in his last comment). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:14:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:14:34 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:29:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:29:16 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #16 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #13) > Reading your test cases, and good job with the description! > > There is one concern! > What if a patron defines to his own messaging preferences sms and email, but > has no sms notification number defined nor email. > This can easily be done accidentally. > This might needlessly bloat our print notifications queue and cause lots of > extra costs. If no sms and email are defined, a print notice will be generated. Feel free to fix the preferences or not to sent the notification :) What do you propose ? > Would it be possible to add a check that; > if email or sms is succesfully sent, even if the other email or sms has > failed, no print notice is generated. This is slightly problematic to > implement but shouldn't be too difficult. The behavior I developed is the behavior needed by our customer. Maybe a syspref could be let the choice, but it is out of the scope of this patch. > Also a patron can request email and sms, buth have no such contact details. > In this case the email is sent via print notice + the sms replaced with > another print notice! No, normally only 1 print notice is generated. (In reply to Olli-Antti Kivilahti from comment #15) > If I have had email and sms defined, but subsequently removed those contact > details, I suspect this condition brings falsehood: > > if ( ($mtt eq 'email' and not $to_address) or ($mtt eq 'sms' and not > $borrower->{smsalertnumber}) ) { > > $to_address and $borrower->{smsalertnumber} are defined as empty Strings and > validate true in Perl. > > Thus I have been unable to trigger the double print notification bug, but > instead got sms and email notifications with destination of '' == empty > String 1 sms and 1 email have been generated with and empty to_address? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:43:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:43:25 +0000 Subject: [Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:43:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:43:29 +0000 Subject: [Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23890|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 24100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24100&action=edit Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer Tests now clean the subscription table before running the tests, so that the will always pass. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:53:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:53:25 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #41 from MJ Ray (software.coop) --- (In reply to Paola Rossi from comment #38) > Kind Paul, I wanted to say: > "I don't sign off the patch" > because the master was already OK without applying the patch: the master > didn't show diacritics badly. That diacritic was o-umlaut which is character F6 in the latin-1 character set, wasn't it? Therefore, I think it wouldn't trigger both aspects of this bug. You're correct that the test case isn't great in that regard. I'm still getting "Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 819" when attempting to print a record containing a stroked-l (B3 from latin-2, whatever that is in utf8). I will investigate further soon but would really appreciate any thoughts from the wise heads here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:54:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:54:43 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23879|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 24101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24101&action=edit Bug 11432 - 404.pl redirect for single, hidden result makes no sense. In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN --------- 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client -> home -> administration -> global system preferences -> OPAC 5) OpacHiddenItems add "homebranch: [MAL,DAV,PAP]", changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:55:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:55:31 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 --- Comment #6 from Jonathan Druart --- Created attachment 24102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24102&action=edit Bug 11432: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 17:57:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 16:57:10 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #7 from Jonathan Druart --- I added a followup in order to hide the facets block if no result is displayed. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 18:41:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 17:41:46 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #5 from Kyle M Hall --- > As staff member you can overwrite hold limitations and it might make sense > to put a hold on a damaged item to make sure it gets set aside when being > returned for repair. Do you know any libraries that use this workflow? I don't see how that is very useful, as you won't know the item is damaged until it gets returned and the librarian sees the damage. At that point you don't need the hold! > But with your patch, the item level hold I set on the damaged item is not > triggered on return. As there is only one item level hold on this record > now, the hold will never trigger. I'm not quite understanding the problem here. You can also force holds that go against the circulation rules, and those holds will never be filled, so this is no without precedent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 19:33:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 18:33:33 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #6 from Nicole C. Engard --- Created attachment 24103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24103&action=edit no option to limit on ccode I don't even see an option for collection code in the opac top issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 19:41:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 18:41:16 +0000 Subject: [Koha-bugs] [Bug 9728] XISBN use simple search instead of SQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- The UT updates have been pushed to 3.12.x, will be in 3.12.9. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 19:42:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 18:42:37 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #7 from Owen Leonard --- > I don't even see an option for collection code in the opac top issue. You have to have the AdvancedSearchTypes preference set to 'ccode' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 19:54:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 18:54:16 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 24104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24104&action=edit Bug 11439: (follow up) add missing rollback call This UT got wrapped inside a transaction with autocommit=0 but the rollback call was inadvertedly ommited. Adding it. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 19:54:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 18:54:46 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 19:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 18:54:57 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 20:02:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 19:02:44 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 20:02:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 19:02:48 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23954|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 24105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24105&action=edit Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 20:02:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 19:02:44 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 20:11:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 19:11:27 +0000 Subject: [Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 20:24:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 19:24:40 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #57 from Kyle M Hall --- Owen, how do these results differ from the same tests pre-patch? I think it's safe to say hold rules are generally on the fritz. The issue is that the code between opac and intranet holds is not unified. It needs to be done, but it's gonna be a lot of work. If this patch corrects the holds behavior in at least one case and doesn't break it in others, I think it should still be pushed. (In reply to Owen Leonard from comment #56) > I'm not sure what the test plan is for this, but here's what I just tried in > the staff client: > > - Circ rule: NPL patrons of type J limited to 1 hold > > - Can place multiple holds at once which exceed circ rule > - Can place multiple holds at once which exceed maxreserves > - Single holds not blocked until maxreserves limit is reached > > - Circ rule: All patrons limited to 1 DVD hold > > - Can place multiple holds at once which exceed circ rule > - Can place multiple holds at once which exceed maxreserves > - Single holds not blocked until maxreserves limit is reached > > - Circ rule: Staff patrons limited to 1 Audio book hold > > - Can place multiple holds at once which exceed circ rule > - Can place multiple holds at once which exceed maxreserves > - Single holds not blocked until maxreserves limit is reached > > In summary: Circulation rule hold limits by patron type, item type, and/or > branch do not work. The maxreserves limit rule only works if you place holds > one at a time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 21:15:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 20:15:02 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- I'm failing this because it doesn't address the root cause, which is that opac-search.pl is failing to count hits correctly when bibs get filtered out because all of their items are hidden. To see what I mean, try the following test: [1] Arrange a search that returns two hits. [2] Edit the items on one of the bibs so that all of them would be hidden. [3] Run the search. The OPAC will report two hits, but display a result list containing only one hit. It should actually be redirecting to that bib. The root issue is described in bug 8462. Putting aside the notion of further work to materialize the hidden status of the items attached to a bib so that the search engine can filter them out automatically, I think there's room for a patch for that bug that simply arranges so that $total and $hits are calculated correctly; I think that it is a far less productive direction to pile on more code that attempts to work around $total being incorrect. Jonathan: regarding your follow-up, one thing to note is that the Bootstrap theme already -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 21:15:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 20:15:10 +0000 Subject: [Koha-bugs] [Bug 11512] New: Forced holds that violate issuing rules will never be filled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Bug ID: 11512 Summary: Forced holds that violate issuing rules will never be filled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently in Koha, if you choose to force a hold from the staff side that would contravened the current issuing rules, that hold will never be filled, as it is always skipped over by CheckReserves. I think the only way to resolve this is to add a flag to the reserves table to alert the system that despite the fact that this hold should usually be skipped over, in this case, it should not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 22:48:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 21:48:20 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Robin Sheat --- I'm going to pass QA on this because I wrote it, Tom?s tested it, and it's packaging related :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 9 23:20:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 22:20:06 +0000 Subject: [Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 kholt at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholt at roseville.ca.us --- Comment #8 from kholt at roseville.ca.us --- Having this problem with Xmen and X-men in our catalog (3 results versus 235). Actually X men and X-men gives same number of results so maybe that's the best we can do for now? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 00:21:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jan 2014 23:21:42 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #37 from David Cook --- I think this would be a great addition to Koha. As Galen mentioned, I'm not sure how many libraries would want this, but as Robin (I think) mentioned, they probably just don't know they want this yet. I suppose I rather Koha be a forerunner rather than playing catch-up when it comes to encryption. P.S. It does give me an excuse to finally play with GPG... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 06:12:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 05:12:16 +0000 Subject: [Koha-bugs] [Bug 11513] New: Warnings in Patron categories Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Bug ID: 11513 Summary: Warnings in Patron categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Floody warnings were discovered during testing Koha. To reproduce what was discovered: 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Review error log, several warnings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 06:12:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 05:12:41 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 06:13:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 05:13:56 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #1 from M. Tompsett --- Created attachment 24106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24106&action=edit Bug 11513 - Warnings in Patron categories TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Review error log, several warnings. 5) Apply patch 6) Refresh page 7) Review error log, no warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 07:28:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 06:28:06 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24106|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 24107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24107&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This patch silences them. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Click 'Home' 13) Click 'Administration' 14) Click 'Patron categories' 15) Click '+ New category' 16) Enter a dummy category and click 'Save' 17) Click 'Edit' for the dummy category. 18) Change a value and click 'Save' 19) Click 'Delete' for the dummy category. 20) Confirm to delete. 21) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 07:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 06:31:35 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 10:17:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 09:17:09 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Aur?lie Fichot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aurelie.fichot at iepg.fr --- Comment #3 from Aur?lie Fichot --- Test on sandbox The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11030:

Something went wrong !

Applying: Bug 11030 : add fields 947,969,359 in unimarc_complete french framework fatal: sha1 information is lacking or useless (installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11030 : add fields 947,969,359 in unimarc_complete french framework When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11030 - Add 359, 947 and 969 fields in french unimarc_complete framework 21930 - [PATCH] Bug 11030 : add fields 947,969,359 in unimarc_complete french framework Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/PATCH-Bug-11030--add-fields-947969359-in-unimarcco-HLgPoP.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 10:33:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 09:33:14 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Nicolas Bravais -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 10:33:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 09:33:29 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24051|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 10:33:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 09:33:36 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 24108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24108&action=edit Bug 11141: Filters are not kept on receiving. On receiving orders, the librarian has to filter again the pending orders list. This patch stores the filters in a cookie in order to apply them when the librarian finish a receive and come back on the pending orders list. Test plan: 1/ choose a vendor with several baskets and orders. 2/ start to receive an item. 3/ on the pending orders page, add some relevant filters. 4/ receive an item. 5/ you are back on the pending orders page and filters are directly applied. Signed-off-by: Nicolas Bravais -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 10:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 09:40:55 +0000 Subject: [Koha-bugs] [Bug 11514] New: Untranslatable "Uncertain" text in acq Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Bug ID: 11514 Summary: Untranslatable "Uncertain" text in acq Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Hard-coded, untranslatable text in acquisitions: acqui/basket.pl: $line{rrpgste} .= ' (Uncertain)'; acqui/invoice.pl: $line{rrp} .= ' (Uncertain)'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 10:52:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 09:52:54 +0000 Subject: [Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23975|0 |1 is obsolete| | --- Comment #3 from Koha Team Lyon 3 --- Created attachment 24109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24109&action=edit Bug 11482 PickupHoldOnlyFromItemBranches new syspref patch redone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 10:53:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 09:53:07 +0000 Subject: [Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:04:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:04:19 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 nicolas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.bravais at gmail.com --- Comment #6 from nicolas --- Filters are still applied after receiving an item. (tested with title, then basket, then author+basket) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:18:46 +0000 Subject: [Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11481 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:18:46 +0000 Subject: [Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11482 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:23:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:23:12 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #8 from sandboxes at biblibre.com --- Patch tested with a sandbox, by isabelle.beroud at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:23:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:23:25 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21273|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:23:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:23:32 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #9 from sandboxes at biblibre.com --- Created attachment 24110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24110&action=edit Bug 10922: Display if prices are tax exc. or inc. when creating a new order This patch adds "(tax inc.)" or "(tax exc.)" after the "Vendor price", "Replacement cost", "Budgeted cost" and "Actual cost" when entering a new order. Actual cost must probably not be displayed here, but it will be the subject of an other patch. To test : - create 2 vendors, with differents values for "List prices includes tax" and "Invoiced prices does includes tax" options - create baskets for these 2 vendors - create an order in each basket, and look at the "tax. inc." and "tax exc" mention. It should be consistent with the options for each vendor - look at an order adding "&close=1" to the normal URL of the order. You must see the order without ability to edit it, but with the same mentions "tax inc." and "tax exc." Signed-off-by: isabelle.beroud at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:23:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:23:38 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 nicolas changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nicolas.bravais at gmail.com --- Comment #2 from nicolas --- This patch apply correctly. I create an authorithy following all these steps without saving the record (with 600$a and 700$a). Works great ! But... When the authority already exists, the message box still indicates "No matching authority found." (when the record is not saved, and when it is) Even if we can check with the regular "Tag Editor" button, it can be really confusing to have both "authority checking system"... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:26:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:26:07 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #76 from Jonathan Druart --- Created attachment 24111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24111&action=edit Bug 9811: FIX branches loop was not correctly set The branches loop was not set with the values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:40:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:40:54 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 --- Comment #7 from Jonathan Druart --- Hi Tom?s, The rollback is not necessary when put at the end. Some others UT files don't execute the rollback (explicitly). I will sign off your patch but I am not sure it is essential. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:41:11 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:41:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:41:14 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24104|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 24112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24112&action=edit Bug 11439: (follow up) add missing rollback call This UT got wrapped inside a transaction with autocommit=0 but the rollback call was inadvertedly ommited. Adding it. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:49:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:49:18 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jean-manuel.broust at univ-lyo | |n2.fr --- Comment #77 from jmbroust --- Tested on sandbox 16 biblibre. We tried to test this patch. We have detected several problems : - A clic on Cancel button makes appear a branch (m?diath?que de pr?t) whereas we didn't select this branch - Synchronization and consistency problems with the two text search boxes (searchmember and searchmember_filter) - Problems with Back button : old searches are saved and performed - This patch looks like the advanced research : is it made to filter results after a search or to perform the same search as an advanced research ? - We have detected encoding problems, example : Cat??gorie (fr-FR) Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:51:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:51:37 +0000 Subject: [Koha-bugs] [Bug 11515] New: Encoding problem with OpacBrowseResults Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Bug ID: 11515 Summary: Encoding problem with OpacBrowseResults Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When OpacBrowseResults syspref is on, the detail page contains a results browser. When search therm contains non-ASCII character, the search query is not well encoded in this browser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:51:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:51:55 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6483 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:51:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:51:55 +0000 Subject: [Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11515 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:54:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:54:15 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 nicolas changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nicolas.bravais at gmail.com --- Comment #16 from nicolas --- Patch apply correctly (tested with all the new status in OPAC, "serials to claim" and on the serials module page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 11:58:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 10:58:30 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #10 from Koha Team Lyon 3 --- I made test : I created 2 vendors : - one with List prices and Invoiced prices : option tax includes - One another with List prices and Invoiced prices : option tax excludes For these 2 vendors, I created baskets and an order, in each basket. The "tax. inc." and "tax exc" mention were consistent with the options for each vendor : it?s ok. Then adding "&close=1" to the normal URL of the order, there are the same mentions "tax inc." and "tax exc." Isabelle Beroud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:01:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:01:29 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #78 from Jonathan Druart --- (In reply to jmbroust from comment #77) > Tested on sandbox 16 biblibre. > > We tried to test this patch. We have detected several problems : > - A clic on Cancel button makes appear a branch (m?diath?que de pr?t) > whereas we didn't select this branch Fixed by the last patch. > - Synchronization and consistency problems with the two text search boxes > (searchmember and searchmember_filter) Could you detail please? > - Problems with Back button : old searches are saved and performed I don't know how to fix that :-/ I will see while the QA step. > - This patch looks like the advanced research : is it made to filter results > after a search or to perform the same search as an advanced research ? Filters allow you to refine your search. > - We have detected encoding problems, example : Cat??gorie (fr-FR) Not introduced by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:16:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:16:43 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #79 from jmbroust --- (In reply to Jonathan Druart from comment #78) > > - Synchronization and consistency problems with the two text search boxes > > (searchmember and searchmember_filter) > > Could you detail please? Example 1 : we make a research "Maxime" with the top search box and then a research "Jean" with the filter search. When we clic on the back button, "Jean" didn't appear in the filter search field (it's "Maxime" instead). Example 2 : When we make an advanced research, fields are automatically filled in the filter research. So the synchronisation doesn't work everytime. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:18:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:18:05 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #1 from Fridolin SOMERS --- Created attachment 24113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24113&action=edit Bug 11515 - Encoding problem with OpacBrowseResults When OpacBrowseResults syspref is on, the detail page contains a results browser. When search terms contains non-ASCII character, the search query is not well encoded in this browser. This patch adds the URI-coding to search terms into session to avoid any encoding problem with diacritics and URI specific characters like ?,& ... So that TT parameter 'busc' is already URI encoded and can be used to recreate seach URL. Test plan : - Set OpacBrowseResults on - At OPAC, perform a search with a diacritique. For example 'd?j?' - Go to detail page of a result => You see browser under "Browser results" - Click on "Back to results" => You get same results and same search term with correct encoding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:18:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:18:51 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:19:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:19:04 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:31:39 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- David, Don't you think it is useless to display the information if not renewal is possible? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:31:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:31:54 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:31:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:31:57 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 --- Comment #7 from Jonathan Druart --- Created attachment 24114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24114&action=edit Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record This patch adds the renewal count to the 'Check out' and "Details' tabs of the patron record. This information already exists in the OPAC view of the patron record. Since librarians might be serving patrons in person who want to know this information without looking it up online, it makes sense to show it in the staff client. There may also be times where librarians want to see how many renewals a patron has left, how many they've used already, etc. when making other decisions. _TEST PLAN_ Before applying: 1) Go to "Check out" with a patron that has some check outs before today 2) Add some check outs for today *Ensure that all issues are for items that can be renewed* 3) Note that the Renew column just says '0' followed by a check box 4) Check the 'Detail' tab. It should say the same. Apply the patch. 5) View the "Details" and "Check out" tabs again 6) Note that the renewal count now appears in the form resembling: 5 of 5 renewals remaining Signed-off-by: Nicole C. Engard All tests pass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:32:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:32:03 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 --- Comment #8 from Jonathan Druart --- Created attachment 24115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24115&action=edit Bug 11486: Don't display the number of remaining renewals if == 0 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:36:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:36:10 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #80 from Jonathan Druart --- (In reply to jmbroust from comment #79) > (In reply to Jonathan Druart from comment #78) > > > > - Synchronization and consistency problems with the two text search boxes > > > (searchmember and searchmember_filter) > > > > Could you detail please? > Example 1 : we make a research "Maxime" with the top search box and then a > research "Jean" with the filter search. When we clic on the back button, > "Jean" didn't appear in the filter search field (it's "Maxime" instead). > Example 2 : When we make an advanced research, fields are automatically > filled in the filter research. So the synchronisation doesn't work everytime. It is the behavior of the browser. In fact, when you use the filters, the page is not reloaded entirely, only the results table. What you describe is a correct behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:38:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:38:08 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #81 from Jonathan Druart --- (In reply to Jonathan Druart from comment #78) > > - Problems with Back button : old searches are saved and performed > > I don't know how to fix that :-/ I will see while the QA step. I don't have a solution for that. A workaround would be to open the patron detail page into a new tab/window. I switch back the status to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 12:44:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 11:44:51 +0000 Subject: [Koha-bugs] [Bug 11516] New: OPAC highlight lost in results browser Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Bug ID: 11516 Summary: OPAC highlight lost in results browser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When OpacHighlightedWords syspref is on, the current search terms are highlighted in results and detail pages. This workes in detail page with the URL param 'query_desc'. This parameter must be managed in results browser (appears when OpacBrowseResults syspref is on) links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:04:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:04:19 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 --- Comment #1 from Fridolin SOMERS --- Created attachment 24116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24116&action=edit Bug 11516 - OPAC highlight lost in results browser When OpacHighlightedWords syspref is on, the current search terms are highlighted in results and detail pages. This workes in detail page with the URL param 'query_desc'. This parameter must be managed in results browser (appears when OpacBrowseResults syspref is on) links. This patch adds query_desc parameter in results list and changes next and previous links to be build into TT instead of perl to manage query_desc parameter only into TT. Test plan : - Edit sysprefs : OpacHighlightedWords on, OpacBrowseResults on, OPACXSLTDetailsDisplay off, OPACXSLTResultsDisplay off (highlight actually does not work with XSLT) - Perform a search with a term existing into title => You see the term highlighted in search results - Go to detail of a result with highlight => You see the term highlighted - Click on "Next" => you see query_desc in URL, and if search term is present it is highlighted - Same for "Previous" - Click on "Browse results" - Click on a result => you see query_desc in URL, and if search term is present it is highlighted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:04:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:04:42 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:04:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:04:52 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:11:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:11:12 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22405|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 24117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24117&action=edit Bug 11051 - remove unneccessary SQL queries in GetBranches The way GetBranches was written, it will issue one query to get all branches, and then one query per branch for the branch relations. This patch pre-fetches the relations table (as we need it all anyway) and so makes the whole process happen in two queries, rather than take 1+N, where N is the number of branches. This might not seem like much, but when you do a search, GetBranches is called once for each result, so 25. And you might have 10 branches. This causes 275 database requests when you could get away with 50. >From profiling, when you run a search, this is the thing that calls DBI::st::execute the most. Refer: http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-Branch-pm-146-line.html#125 Test Plan: * Have a database with branches and relationships between the branches. (these are 'Lubrary groups' in the UI. * Make sure the relationships show up correctly after applying the patch. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:11:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:11:47 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24117|Bug 11051 - remove |[PASSED QA]Bug 11051 - description|unneccessary SQL queries in |remove unneccessary SQL |GetBranches |queries in GetBranches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:12:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:12:56 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Jonathan Druart --- I marked the patch I tested as passed qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:16:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:16:53 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24116|0 |1 is obsolete| | --- Comment #2 from Fridolin SOMERS --- Created attachment 24118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24118&action=edit Bug 11516 - OPAC highlight lost in results browser When OpacHighlightedWords syspref is on, the current search terms are highlighted in results and detail pages. This workes in detail page with the URL param 'query_desc'. This parameter must be managed in results browser (appears when OpacBrowseResults syspref is on) links. This patch adds query_desc parameter in results list and changes next and previous links to be build into TT instead of perl to manage query_desc parameter only into TT. Test plan : - Edit sysprefs : OpacHighlightedWords on, OpacBrowseResults on, OPACXSLTDetailsDisplay off, OPACXSLTResultsDisplay off (highlight actually does not work with XSLT) - Perform a search with a term existing into title => You see the term highlighted in search results - Go to detail of a result with highlight => You see the term highlighted - Click on "Next" => you see query_desc in URL, and if search term is present it is highlighted - Same for "Previous" - Click on "Browse results" - Click on a result => you see query_desc in URL, and if search term is present it is highlighted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:17:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:17:49 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22593|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 24119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24119&action=edit Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. Signed-off-by: Nicolas Bravais -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:18:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:18:56 +0000 Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 --- Comment #13 from Kyle M Hall --- Yes, it's still valid unless 6427 manages to get pushed first. In either case I will have to add a followup to 6427 for this same behavior. This patch will at the very least implement the permission itself. Adding the limit to the new accounting system will be a fairly simple process. (In reply to Jonathan Druart from comment #12) > Kyle, > Since bug 6427 deletes all the files that this patch changes, is it still > valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:25:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:25:01 +0000 Subject: [Koha-bugs] [Bug 11517] New: MARC21slim2intranetResults.xsl has swapped braille and combination Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11517 Bug ID: 11517 Summary: MARC21slim2intranetResults.xsl has swapped braille and combination Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org braille combination But MARC21 format says: 00 - Category of material f - Tactile material 01 - Specific material designation b - Braille c - Combination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:46:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:46:38 +0000 Subject: [Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23867|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 24120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24120&action=edit Bug 7965 : Silence warns in staff log Silence warns in C4::Bookseller to test 1/ run prove t/db_dependent/Bookseller.t Notice lots of Use of uninitialized value $delay in numeric lt (<) at /var/lib/jenkins/jobs/Koha_master/workspace/C4/Bookseller.pm line 134 type lines 2/ apply patch 3/ run prove t/db_dependent/Bookseller.t Notice warns are gone Signed-off-by: Katrin Fischer Tiny change, positive consequences. Passes QA script and all tests. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:46:35 +0000 Subject: [Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 13:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 12:59:57 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #17 from Jonathan Druart --- QA comment: There are some concerns here, I think: There is another readonly field in the circulation.tt file. Trying to test it, I entered an invalid date (14/14/2014), and I got a crashing error (The 'month' parameter ("14") to DateTime::new did not pass the 'an integer between 1 and 12' callback). In fact the INVALID_DATE error code is set only if the date does not match the syspref format. If we allow the user to enter what he wants, we have to catch correctly any error. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:03:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:03:43 +0000 Subject: [Koha-bugs] [Bug 11518] New: Add new method to Koha::Schema::Result::Item that will always return the correct itemtype Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Bug ID: 11518 Summary: Add new method to Koha::Schema::Result::Item that will always return the correct itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There are many disparate areas of Koha that deal with item level itemtypes vs record level itemtypes. We can take advantage of DBIx::Class to make smarter objects that automatically return the correct value depending on the system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:03:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:03:51 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:04:03 +0000 Subject: [Koha-bugs] [Bug 11519] New: Keep local MARC tags during data import Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11519 Bug ID: 11519 Summary: Keep local MARC tags during data import Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org Ability to nominate MARC tags for "Local use", so existing data wouldn't get overwritten or deleted during data import. New data will get added as duplicate tag or subfield (depending on the setting preference for each "Local" MARC tag). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:04:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:04:21 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #18 from Katrin Fischer --- We have asked the library who reported this to take a look, but catching errors is indeed the biggest problem I see. I think it's not so bad that this only fixes the due date, as we are still trying to figure out the best way of doing it. Javascript alerts seemed to work ok for this library in the past, so I think we might be able to do that, although server side would probably be the most accessible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:04:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:04:58 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #1 from Kyle M Hall --- Just an fyi, I this idea came to me while reading the reports for bug 9448 and bug 11463. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:05:57 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #2 from Kyle M Hall --- Not bug 9448, I meant bug 9532 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:07:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:07:18 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:07:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:07:21 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #3 from Kyle M Hall --- Created attachment 24121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24121&action=edit Bug 11518 - Add new method to Koha::Schema::Result::Item that will always return the correct itemtype There are many disparate areas of Koha that deal with item level itemtypes vs record level itemtypes. We can take advantage of DBIx::Class to make smarter objects that automatically return the correct value depending on the system preference. Test Plan: 1) Apply this patch 2) Run t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:10:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:10:58 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #4 from Kyle M Hall --- In the future we could even override $item->itype() to return the correct value via system preference. Not sure if this would be a good idea or a bad one. In some cases it would likely eliminate accidental bugs. From the DBIC FAQ: How do I override a run time method (e.g. a relationship accessor)? If you need access to the original accessor, then you must "wrap around" the original method. You can do that either with Moose::Manual::MethodModifiers or Class::Method::Modifiers. The code example works for both modules: package Your::Schema::Group; use Class::Method::Modifiers; # ... declare columns ... __PACKAGE__->has_many('group_servers', 'Your::Schema::GroupServer', 'group_id'); __PACKAGE__->many_to_many('servers', 'group_servers', 'server'); # if the server group is a "super group", then return all servers # otherwise return only servers that belongs to the given group around 'servers' => sub { my $orig = shift; my $self = shift; return $self->$orig(@_) unless $self->is_super_group; return $self->result_source->schema->resultset('Server')->all; }; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:19:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:19:12 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24021|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 24122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24122&action=edit Bug 11499: (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 The test should fail unless the main page is applied. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:19:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:19:23 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24022|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 24123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24123&action=edit Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Passes unit test, koha-qa.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:19:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:19:33 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:34:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:34:28 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:34:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:34:31 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 --- Comment #16 from Kyle M Hall --- Created attachment 24124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24124&action=edit Bug 9865: SIP msg encoding configurable via SIPconfig.xml The accounts->login tag in SIPconfig.xml can now accept a new parameter, "encoding". It will be mostly used to encore to utf8. For this, simply add the parameter: encoding="utf8" note: this patch was made by Adrien Saurat I have simply rebased it Signed-off-by: Chris Cormack Works as advertised, does nothing if encoding is not set. Blows up all the machines that can't handled utf8 if it is set :) But that's not Koha's fault. :) Signed-off-by: Petter Goksoyr Asen But now I did it the right way! And I can confirm that this patch solves all issues with mangled characters in SIP messages. Confirmed that it looks good with Norwegian characters in patron name and in book titles. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:34:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:34:39 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #38 from Koha Team Lyon 3 --- I made several searchs and tested several facets : authors - series - topics and I have used several facets in the same time (in the same categries or not). When I remove a facet with [x], I have the logical number of results. I have the same results in OPAC or in pro interface. It's ok for me. Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:34:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:34:46 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:34:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:34:53 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:36:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:36:11 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #39 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:36:27 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:36:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:36:32 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:36:40 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #40 from sandboxes at biblibre.com --- Created attachment 24125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24125&action=edit Bug 10857: Add facets cancellation When searching (at the OPAC or pro), facets can be enabled but never disabled. So a user is obliged to relaunch the search. This patch adds a new link "[x]" at the right of each selected facet. This link relaunch the search without this facet. Test plan: - Launch a search (OPAC and pro) - Enable some facets - Disable some facets Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:36:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:36:44 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #41 from sandboxes at biblibre.com --- Created attachment 24126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24126&action=edit Bug 10857: Encode 'limit' parameter values to allow facets with '&' character. Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:37:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:37:23 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 --- Comment #17 from Kyle M Hall --- Created attachment 24127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24127&action=edit Bug 9865 [QA Followup] - Give better usage examples in example SIPconfig.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:46:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:46:06 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:46:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:46:09 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24032|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 24128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24128&action=edit Bug 11475: Links are broken when editing/deleting items in batch Bug introduced by bug 9044. Test plan: 1- First we search for records with multiple items (books or serials, does not matter) 2- We open this record we found with multiple items for editing 3- We chose "Edit items in batch" option from the "Edit" menu 4- We make corrections on the fields under the "Edit item" (For example we change the collection code as "fiction") 5- We save this using "Save button" at the bottom, after we are done. 6- Just after we save, there will be a button named "Done" available just under the page, and when we click on "Done" we encounter the Error screen. Before the patch, the "Done" link points to /cgi-bin/koha/tools/CATALOGUING. After applying the patch, the "Done" link points to the biblio detail page. Signed-off-by: Nicole C. Engard All tests pass Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 14:48:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 13:48:19 +0000 Subject: [Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Aur?lie Fichot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aurelie.fichot at iepg.fr --- Comment #2 from Aur?lie Fichot --- I do the test plan but I always see the Place hold button... :-(((( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:05:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:05:38 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23822|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:05:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:05:42 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:06:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:06:46 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:06:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:06:49 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24112|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 24129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24129&action=edit Bug 11439: (follow up) add missing rollback call This UT got wrapped inside a transaction with autocommit=0 but the rollback call was inadvertedly ommited. Adding it. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:10:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:10:06 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr --- Comment #2 from jmbroust --- Tested on sandbox 16 biblibre We had no existing basketgroups in database. So we only tested on basketgroup creation : closing date and creation date seem to work fine but we couldn't test with different dates. It would be better to test this patch on several days and with existing basket groups in database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:12:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:12:17 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24043|0 |1 is obsolete| | Attachment #24044|0 |1 is obsolete| | Attachment #24045|0 |1 is obsolete| | Attachment #24046|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 24130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24130&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Toggled SCO receipt printing to be on by default for upgrades in updatedatabase.pl. Updated files to set default to 1 in sysprefs.sql. Also added code to read the system preference on the template page. Added code to update prog theme with same changes as the bootstrap theme. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:13:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:13:50 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 nicolas changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nicolas.bravais at gmail.com --- Comment #15 from nicolas --- All the covers are the same with or without Coce. And the exact same covers are retrieved (no more, no less...) With 'Bootstrap' and 'prog'. At one time there was 2 covers for the same biblios (one slightly bigger than the other one. For example : http://ecx.images-amazon.com/images/I/613QE5KV4YL._SL160_.jpg and http://images.amazon.com/images/P/2700036336.01.TZZZZZZZ.jpg Nevertheless it looks like it's an random accident since I didn't manage to re-create this error... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:22:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:22:42 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24130|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 24131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24131&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Toggled SCO receipt printing to be on by default for upgrades in updatedatabase.pl. Updated files to set default to 1 in sysprefs.sql. Also added code to read the system preference on the template page. Added code to update prog theme with same changes as the bootstrap theme. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. No regressions noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:23:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:23:01 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:23:05 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #19 from Kyle M Hall --- Created attachment 24132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24132&action=edit Bug 11415 [QA Followup] - Add syspref to toggle SCO receipt printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:42:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:42:29 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:42:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:42:31 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23999|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 24133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24133&action=edit Bug 11343: The max number of items to process in a batch is hardcoded Until now, the maximum number of item records to process in a batch was hardcoded to 1000. This patch adds a syspref MaxItemsForBatch in order to allow to adapt this value. Test plan: - set the pref to 2 - try to delete a batch of 3 items: they are not displayed - try to modify a batch of 3 items: you are not allowed to do that - set the pref to 1000 and try again. Now items are displayed and you are allow to modify them. Signed-off-by: Christopher Brannon Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:47:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:47:59 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 nicolas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.bravais at gmail.com --- Comment #13 from nicolas --- The SysPref is present in the database (we looked for MembershipExpiryDaysNotice in PHPMyAdmin), but not in the Administration interface... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:51:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:51:30 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #16 from Fr?d?ric Demians --- Thanks for testing. > All the covers are the same with or without Coce. And the exact same > covers are retrieved (no more, no less...) I may depend of your database. Do you have biblio records with ISBN-13? Do you have bilio records for DVD/CD-Audio? There are not retrieved with Amazon 'standard' cover but should be retrieved with Coce. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:51:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:51:47 +0000 Subject: [Koha-bugs] [Bug 11452] Add some tests for Koha::Template::Plugin::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11452 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:51:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:51:50 +0000 Subject: [Koha-bugs] [Bug 11452] Add some tests for Koha::Template::Plugin::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11452 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23833|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 24134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24134&action=edit Bug 11452 Add unit tests for Koha::Template::Plugin::Cache To test run prove t/Koha_Template_Plugin_Cache.t Signed-off-by: Katrin Fischer Works nicely. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:54:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:54:42 +0000 Subject: [Koha-bugs] [Bug 11520] New: Invoice isn't really an invoice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520 Bug ID: 11520 Summary: Invoice isn't really an invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 24135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24135&action=edit invoice example What is the purpose of having the replacement cost show on the invoice details screen? From our point of view replacement costs have nothing to do with invoices so it just isn't helpful here. Why does the total column show the amount from the order? In this case the order amount entered was $240.35 but the actual amount from the invoice was $236.47. Again what do order amounts have to do with invoice details - which should only be about what was paid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:55:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:55:41 +0000 Subject: [Koha-bugs] [Bug 11480] Tests in Output_JSON.t make invalid assumptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:55:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:55:43 +0000 Subject: [Koha-bugs] [Bug 11480] Tests in Output_JSON.t make invalid assumptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23981|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 24136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24136&action=edit Bug 11480 Fix invalid assumptions in test Tests for Output::JSON made the invalid assumption that the hash keys of the modules internal structure will always be returned in the same sequence. A hash is an unordered structure. as of perl 5.18 this has beem reinforced by random seeding of the hashing function. See the info in perldelta and the doc for JSON This patch changes the tests to be sequence neutral where the previous test was testing that a new element was added and an existing one was untouched these have been separated into individual tests. Some typos in the messages have been corrected Signed-off-by: Chris Cormack Test Plan 1/ Run t/Output_JSONStream.t , 8 tests should pass (or perhaps fail, but inconsistently under perl 5.18 or greater) 2/ Apply patch 3/ Run t/Output_JSONStream.t 10 tests should pass now Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:56:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:56:53 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr --- Comment #20 from jmbroust --- Tested on sandbox 16 biblibre This patch works well ! Tests with Firefox and Internet Explorer. We wonder if it's not a problem for public computers without identification. For example, in our library, lot of research are performed with computers only catalog access. If a patron log after several anonymous searches, he would have the all precedent anonymous searches in his search history. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:57:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:57:11 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #21 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Charlene Criton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:57:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:57:33 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:57:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:57:38 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:57:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:57:43 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23927|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:57:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:57:49 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #22 from sandboxes at biblibre.com --- Created attachment 24137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24137&action=edit Bug 10952: Store anonymous search history in session Storing search history into cookie can cause problems, due to the size limitation of 4KB. The solution here is to store search history into the CGI::Session object, so there is no size limitation (but anonymous search history still remember up to 15 requests max.) Test plan: - Go to OPAC in anonymous mode. - Check that the "Search history" link is *not* shown in the top right corner of the page - Make some searches on /cgi-bin/koha/opac-search.pl - The "Search history" link must appear. Click. - Your search history must be displayed. - Try to log in with invalid username/password - Go back to search history, it's still there - Now log in with valid username/password - Your anonymous search history must be saved into your own search history. Signed-off-by: Chris Cormack Restoring original sign offs and comments below Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Well, search history saving is similar before and after patch. i.e. anonmymous search is saved when user logs in, but cookie KohaOpacRecentSearches is empty. Shows current an previous session searches Signed-off-by: Katrin Fischer All tests and QA script pass, works as described. Signed-off-by: Charlene Criton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:57:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:57:53 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #23 from sandboxes at biblibre.com --- Created attachment 24138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24138&action=edit Bug 10952: comments fixes and unit tests - Remove unit tests for ParseSearchHistoryCookie, which doesn't exist anymore - Add unit tests for ParseSearchHistorySession and SetSearchHistorySession - Remove/Modify comments about search history cookie Signed-off-by: Chris Cormack Tests fixed and moved, and comments tidied up Signed-off-by: Charlene Criton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 15:57:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 14:57:57 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #24 from sandboxes at biblibre.com --- Created attachment 24139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24139&action=edit Bug 10952: Always flush session after deletion This is recommended in CGI::Session documentation. Signed-off-by: Charlene Criton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:06:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:06:51 +0000 Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 --- Comment #5 from Owen Leonard --- (In reply to Katrin Fischer from comment #4) > This works nicely, but not sure if it touches the necessary files. I see > there is also /koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.css. Yeah there is a better way to handle this, although no one can be blamed for not knowing it because I haven't done a good job of laying out the guidelines. Two main points to consider: 1. No changes should be made to the files in bootstrap/lib unless they are "official upgrades" to these files, which are all created and maintained outside of the Koha project. If bootstrap-rtl.css has an error it and there isn't an "official upgrade" then the correction needs to be applied in Koha's custom RTL CSS. 2. All CSS in the Bootstrap theme is generated from LESS files (in bootstrap/less), so changes to CSS should be done in the LESS file. There is a specific rtl CSS file there: bootstrap/less/right-to-left.less, where this patch's changes should be made. Then the less file should be compiled and the resulting file put in bootstrap/css. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:12:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:12:42 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:13:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:13:45 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22981|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 24140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24140&action=edit Bug 11248: Encoding issue on sending a list (INTRANET) Signed-off-by: Katrin Fischer Sending an intranet list from translated templates requires a new list template for the intranet. I have added the needed changes in a follow-up. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:13:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:13:54 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22982|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 24141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24141&action=edit Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. Signed-off-by: Katrin Fischer Works nicely. Links to the OPAC are correct. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:14:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:14:26 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23369|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 24142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24142&action=edit Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:14:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:14:22 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:23:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:23:43 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #5 from Kyle M Hall --- Created attachment 24143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24143&action=edit Bug 11518 [Followup] - Change method name from 'itemtype' to 'effective_itemtype' for clarity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:24:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:24:27 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:28:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:28:11 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Aur?lie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:28:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:28:25 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24118|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:28:31 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 24144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24144&action=edit Bug 11516 - OPAC highlight lost in results browser When OpacHighlightedWords syspref is on, the current search terms are highlighted in results and detail pages. This workes in detail page with the URL param 'query_desc'. This parameter must be managed in results browser (appears when OpacBrowseResults syspref is on) links. This patch adds query_desc parameter in results list and changes next and previous links to be build into TT instead of perl to manage query_desc parameter only into TT. Test plan : - Edit sysprefs : OpacHighlightedWords on, OpacBrowseResults on, OPACXSLTDetailsDisplay off, OPACXSLTResultsDisplay off (highlight actually does not work with XSLT) - Perform a search with a term existing into title => You see the term highlighted in search results - Go to detail of a result with highlight => You see the term highlighted - Click on "Next" => you see query_desc in URL, and if search term is present it is highlighted - Same for "Previous" - Click on "Browse results" - Click on a result => you see query_desc in URL, and if search term is present it is highlighted Signed-off-by: Aur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:29:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:29:36 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:31:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:31:01 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 --- Comment #5 from Aur?lie Fichot --- YES ! The current search terms are highlighted in results and detail pages (but not in the "Browse results" but perhaps it's normal...). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:32:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:32:05 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #17 from nicolas --- Created attachment 24145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24145&action=edit screenshot with 2 cover screenshot with 2 cover -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:33:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:33:12 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #14 from sandboxes at biblibre.com --- Patch tested with a sandbox, by juliette et r?my -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:33:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:33:33 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:33:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:33:38 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:33:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:33:41 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:33:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:33:43 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24070|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:33:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:33:50 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #15 from sandboxes at biblibre.com --- Created attachment 24146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24146&action=edit Bug 11023: Toggle "new" status This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjob/toggle_new_status.pl). Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools > items_batchmod permission. - navigate to Home > Tools > Toggle new status - click on the edit button - there are 3 "blocks": * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. Signed-off-by: juliette et r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:33:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:33:54 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #16 from sandboxes at biblibre.com --- Created attachment 24147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24147&action=edit Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. Signed-off-by: juliette et r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:33:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:33:57 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #17 from sandboxes at biblibre.com --- Created attachment 24148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24148&action=edit Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t Signed-off-by: juliette et r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:34:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:34:55 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #18 from nicolas --- Same thing with CD and ISBN-13. And several biblios have double cover on search results Also, with the one book with a cover from Coce, the bootstrap theme does not display this cover. Just an empty space under the "no image available" from Amazon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:36:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:36:19 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 nicolas changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nicolas.bravais at gmail.com --- Comment #12 from nicolas --- Patch works correctly! thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:37:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:37:38 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:44:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:44:05 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #27 from Koha Team Lyon 3 --- Test after placing syspref UseTablesortForCirc = enable It works for checkout table and for holds table : column is hided and you can add it with the link "show/hide columns" "if Cannot be toggled" in admin. If "Cannot be toggled" is check you can't see the column name with the link "show/hide columns" It's a wonderful patch and it'll be great if we can have the thing in the serials module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:46:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:46:10 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #28 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:46:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:46:30 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:46:35 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:46:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:46:41 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24085|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:46:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:46:48 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #29 from sandboxes at biblibre.com --- Created attachment 24149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24149&action=edit Bug 10212: Columns configuration for tables - Add Colvis files Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:46:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:46:53 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #30 from sandboxes at biblibre.com --- Created attachment 24150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24150&action=edit Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the checkouts page (circ/circulation.pl). 4/ Check that you cannot hide the 3 last columns on the issues table. 5/ Check that you cannot hide the 2 last columns on the holds table. 6/ Try to hide/show columns. 7/ Go on the columns configuration page (admin/columns_settings.pl). 8/ Only the last tab are filled with data. Check/uncheck checkboxes and save. 9/ Go on the checkouts/holds page and check that the behavior is what you expected. 10/ Give me some feedback :) * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:46:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:46:57 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #31 from sandboxes at biblibre.com --- Created attachment 24151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24151&action=edit Bug 10212: Make the table names translatable Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:47:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:47:06 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #9 from Jonathan Druart --- QA comment: It is not perfect but it is far better than it is currently. 2 first patches could be squashed for more visibility. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:47:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:47:34 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23922|0 |1 is obsolete| | Attachment #23923|0 |1 is obsolete| | Attachment #23924|0 |1 is obsolete| | Attachment #23925|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 24152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24152&action=edit Bug 11473 - Fix log viewer template conditions This patch adds the 'loopro' key to the 'module' value, so that conditions are actually triggered in the template logic. (Note: loopro.CIRCULATION is valid, but I changed it for the sake of consistency across the different conditions.) This patch also adds substr checks to the 'info' column when using the cataloguing module. This will check for 'item' and 'biblio', so that the appropriate label qualifer can be shown in the log viewer. If either term is absent, the unqualified number will be shown instead (this will be the majority of action logs at this point). _TEST PLAN_ Before applying: 1) Access log viewer from Tools (or wherever really) 2) Look up logs for circulation, patrons, cataloguing, serial, authorities, etc. 3) Note that the "Object" will always just be a number without qualification. After applying the patch: 1) Look at those same logs 2) Note that the object number for borrowers will usually be prefaced by 'member' (notwithstanding FINES which aren't taken into account in this template yet); new bibs and new items should say 'Item X' or 'Biblio X'. Serials should have a link. Authorities should have a link and an 'auth' preface. Signed-off-by: Chris Cormack Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:47:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:47:39 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 --- Comment #11 from Jonathan Druart --- Created attachment 24153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24153&action=edit Bug 11473 - Remove boilerplate in log viewer template This patch eliminates unnecessary conditions and boilerplate. _TEST PLAN_ Apply the patch. 1) Try viewing logs for circulation, patrons, fines, cataloguines, serials, authorities, etc. 2) Note that everything should look exactly the same as before, with one exception: FINES 3) Fines will now show "member X" for the user associated with the fine. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:47:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:47:43 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 --- Comment #12 from Jonathan Druart --- Created attachment 24154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24154&action=edit Bug 11473 - Improve wording in log viewer template This patch capitalizes 'member' and 'biblio' as object labels in the log viewer. It also adds a "Subscription" label, and changes "auth" to "Authority". _TEST PLAN_ Before applying patch: 1) View logs for patrons, new biblio, serials, and authorities. Apply the patch: 1) Notice the capitalization and new/modified labels. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:47:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:47:48 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 --- Comment #13 from Jonathan Druart --- Created attachment 24155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24155&action=edit Bug 11473 - add 'biblio' and 'item' to cataloguing logging info This patch adds the words 'biblio' and 'item' to the 'info' of the cataloguing logs which were missing them (such as biblio delete, biblio mod, item mod, upload cover image). This patch also adds 'authority' for authority mod. _TEST PLAN_ Before applying: 1) Create/view mods for items, biblios, and authorities. 2) Create/view biblio deletion 3) Create/view upload cover image log 4) Note that none of these contain the words 'biblio','item',or 'authority' in their "Info" columns. Apply patch. 5) Repeat steps 1-3 6) Note that the new logs contain 'biblio','item', and 'authority' in their "Info" column, while the past ones don't. 7) Note also that 'biblio' and 'item' will have 'Biblio' and 'Item' appear in their "Object" column for the new logs Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:51:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:51:05 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24137|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 24156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24156&action=edit Bug 10952: Store anonymous search history in session Storing search history into cookie can cause problems, due to the size limitation of 4KB. The solution here is to store search history into the CGI::Session object, so there is no size limitation (but anonymous search history still remember up to 15 requests max.) Test plan: - Go to OPAC in anonymous mode. - Check that the "Search history" link is *not* shown in the top right corner of the page - Make some searches on /cgi-bin/koha/opac-search.pl - The "Search history" link must appear. Click. - Your search history must be displayed. - Try to log in with invalid username/password - Go back to search history, it's still there - Now log in with valid username/password - Your anonymous search history must be saved into your own search history. Signed-off-by: Chris Cormack Restoring original sign offs and comments below Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors Well, search history saving is similar before and after patch. i.e. anonmymous search is saved when user logs in, but cookie KohaOpacRecentSearches is empty. Shows current an previous session searches Signed-off-by: Katrin Fischer All tests and QA script pass, works as described. Signed-off-by: Charlene Criton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:51:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:51:10 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24138|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 24157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24157&action=edit Bug 10952: comments fixes and unit tests - Remove unit tests for ParseSearchHistoryCookie, which doesn't exist anymore - Add unit tests for ParseSearchHistorySession and SetSearchHistorySession - Remove/Modify comments about search history cookie Signed-off-by: Chris Cormack Tests fixed and moved, and comments tidied up Signed-off-by: Charlene Criton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:51:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:51:15 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24139|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 24158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24158&action=edit Bug 10952: Always flush session after deletion This is recommended in CGI::Session documentation. Signed-off-by: Charlene Criton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:51:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:51:27 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:56:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:56:10 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com --- Comment #13 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Nicolas B. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:56:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:56:27 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:56:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:56:32 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:56:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:56:39 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 --- Comment #14 from sandboxes at biblibre.com --- Created attachment 24159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24159&action=edit Bug-10477 Increased flexibility for upload of Staged When uploading bulk MARC records against existing records need further option to allow the process to just add/merge extra MARC tags rather than having to completely overwrite an existing record or just leave the existing record unchanged. Test Plan: 1. Click on Tools->Stage MARC records for import. 2. Upload the MARC file for ex: first.mrc 3. Click on upload button. 4. Choose Record matching rule: 020$a ISBN. 5. Choose Action if matching record found: Append or update MARC21/UNIMARC tag a text box will appear after choosing enter MARC tag for ex: 700a which you want to merge. 6. Click on Stage for import button. 7. On the next screen click on Manage staged records. 8. You can also edit the record matching rule in manage record screen. 9. Click on Import this batch on catalog button. 10. Next screen will give no of record updated. 11. It will check duplicate field record for ex: 700$aamit is already in record it will skip the tag and move to next. Signed-off-by: Amit Gupta Signed-off-by: Nicolas B. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:56:43 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 --- Comment #15 from sandboxes at biblibre.com --- Created attachment 24160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24160&action=edit Bug-10477-Alter table import_batches Added overlay_action to "appendmarctag" and new column "marctag" Signed-off-by: Nicolas B. Signed-off-by: Nicolas B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 16:58:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 15:58:48 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- The choice to "unhighlight" search terms is not remembered when moving between pages. If this is not an issue, please reset status to "Signed off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:02:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:02:45 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #42 from Kyle M Hall --- Needs updated to include bootstrap theme. Other than that, it looks great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:03:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:03:29 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 --- Comment #3 from mathieu saby --- (In reply to jmbroust from comment #2) > Tested on sandbox 16 biblibre > We had no existing basketgroups in database. So we only tested on > basketgroup creation : > closing date and creation date seem to work fine but we couldn't test with > different dates. It would be better to test this patch on several days and > with existing basket groups in database. Thank you for testing. The other solution could be to alter by hand the database before applying the patch, but is less secure. To sum up what is still to test : A. The creation and editing of bg with the patch => seems ok for you B. The transformation of existing data (when a bg is closed, the application of the patch should copy into the bg the date of the most recent basket closing date) => not yet tested Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:08:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:08:37 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 --- Comment #4 from mathieu saby --- By the way, record.abs is going to be deprecated in next version (or maybe later). So if you think that indexing is inconsistent you need to edit also the DOM configuration files. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:09:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:09:53 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:09:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:09:56 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 --- Comment #1 from Owen Leonard --- Created attachment 24161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24161&action=edit Bug 11503 - Several typos This patch corrects several typos: Some reported in Bug 11503, others found during a systematic spell check of the help files. To test, examine the changes and confirm that the spelling changes are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:10:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:10:16 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #29 from Tom?s Cohen Arazi --- Made the use of MARCXML for serialization dependent on having DOM set as Galen proposed on comment #21. Tests now pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:11:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:11:41 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #16 from Galen Charlton --- I have pushed the GetBranches() patch to master. Thanks, Robin! I'll reset the bug to signed off for the other patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:11:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:11:51 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:11:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:11:57 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:12:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:12:04 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:12:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:12:17 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24117|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:12:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:12:30 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #30 from Tom?s Cohen Arazi --- Please recall that I made the bug depend on bug 11499 (fixes correctly setting indexing mode in the test scripts) so apply the patches in order, on top of the patches for that bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:12:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:12:53 +0000 Subject: [Koha-bugs] [Bug 11475] Batch modification process ends with broken link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11475 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:13:12 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:13:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:13:32 +0000 Subject: [Koha-bugs] [Bug 11452] Add some tests for Koha::Template::Plugin::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11452 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:14:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:14:00 +0000 Subject: [Koha-bugs] [Bug 11499] zebra_setup.pl not correctly setting indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:14:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:14:32 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed the follow-up to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:14:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:14:49 +0000 Subject: [Koha-bugs] [Bug 11480] Tests in Output_JSON.t make invalid assumptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11480 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:15:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:15:13 +0000 Subject: [Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:23:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:23:30 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:23:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:23:35 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #43 from Jonathan Druart --- Created attachment 24162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24162&action=edit Bug 10857: Add facets cancellation - bootstrap theme. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:25:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:25:19 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24162|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 24163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24163&action=edit Bug 10857: Add facets cancellation - bootstrap theme. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:38:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:38:18 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #32 from Jonathan Druart --- I will provide unit tests for new routines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:42:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:42:36 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24107|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 24164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24164&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. This fix splits the admin/categorie.pl changes and the template changes, so that oldstable may be able to use this. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Click 'Home' 13) Click 'Administration' 14) Click 'Patron categories' 15) Click '+ New category' 16) Enter a dummy category and click 'Save' 17) Click 'Edit' for the dummy category. 18) Change a value and click 'Save' 19) Click 'Delete' for the dummy category. 20) Confirm to delete. 21) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:43:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:43:53 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 17:56:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 16:56:41 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Galen Charlton --- Pushed to master, along with a follow-up that fixes the doubled (and tripled, etc.) search history issue that Katrin found, and a follow-up that removes that last remaining reference to the KohaOpacRecentSearches cookie. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:02:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:02:39 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:02:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:02:42 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 --- Comment #1 from Owen Leonard --- Created attachment 24165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24165&action=edit Bug 11476 - Opac self registration title pull down offers 2 empty options If you have patron titles enabled, the OPAC patron details form lists 2 empty spaces instead of 1. An empty option is passed by the script, so the template does not need to include one. To test you must have at least one patron title set in BorrowersTitles system preference and OPACPatronDetails must be set to "allow." 1. Apply the patch 2. Log in to the OPAC 3. Click the "personal details" tab. 4. Click the "salutation" dropdown. There should be only one blank line preceding the existing titles. Test in both prog and bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:07:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:07:18 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:18:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:18:09 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:18:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:18:22 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:18:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:18:28 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 24166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24166&action=edit Bug 11018 - Add order from a reverted file Weird behavior: When an import is undone into catalog, the status is set to "reverted". But if you open the add orders from iso2709, the status is automatically set to "imported" and does not appear in the list. So it is not possible to import a reverted batch. Test plan: - verify you reproduce the weird behavior - apply this patch - import a file and the batch into the catalog - verify (in the your mysql/MariaDB cli) the status is "imported" - verify it does not appears in the add orders from iso2809 page - undo the import - verify (in the your mysql/MariaDB cli) the status is "reverted" - verify it appears in the add orders from iso2809 page and the status is always "reverted" - finish the order Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:29:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:29:20 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Pierre Angot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #5 from Pierre Angot --- Can't verify mysql/MariaDB cli on sandbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:32:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:32:47 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #33 from Jonathan Druart --- Created attachment 24167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24167&action=edit Bug 10212: Columns configuration for tables - QA FIX - use YAML is missing in package - get_tables and get_excluded are useless routines and can be removed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:32:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:32:54 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #34 from Jonathan Druart --- Created attachment 24168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24168&action=edit Bug 10212: Columns configuration for tables - Unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:39:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:39:45 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24164|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 24169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24169&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Click 'Home' 13) Click 'Administration' 14) Click 'Patron categories' 15) Click '+ New category' 16) Enter a dummy category and click 'Save' 17) Click 'Edit' for the dummy category. 18) Change a value and click 'Save' 19) Click 'Delete' for the dummy category. 20) Confirm to delete. 21) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:49:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:49:30 +0000 Subject: [Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 --- Comment #1 from Owen Leonard --- Created attachment 24170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24170&action=edit Bug 11381 - IDreamBooks too close to title on bootstrap Styling of IDreamBooks elements is not correct in the bootstrap theme because the relevant CSS was not transferred from the prog theme. This patch adds it back. To test, switch to the bootstrap theme and enable IDreamBooks system preferences in the OPAC, particularly IDreamBooksReadometer. Find a book in the OPAC which shows IDreamBooks review data and confirm that everything looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 18:49:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 17:49:27 +0000 Subject: [Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:25:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:25:55 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from M. Tompsett --- Found some additional circ/circulations.pl warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:26:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:26:40 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #5 from M. Tompsett --- Created attachment 24171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24171&action=edit Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:34:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:34:22 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24029|0 |1 is obsolete| | Attachment #24030|0 |1 is obsolete| | Attachment #24031|0 |1 is obsolete| | --- Comment #31 from Tom?s Cohen Arazi --- Created attachment 24172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24172&action=edit Bug 11096: force XML syntax for Zebra in DOM I was asked to squash the patches, so here we go. I removed the signoffs they had because I know you will sign them again :-P To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:38:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:38:20 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23582|0 |1 is obsolete| | Attachment #23583|0 |1 is obsolete| | Attachment #23584|0 |1 is obsolete| | Attachment #23585|0 |1 is obsolete| | Attachment #23586|0 |1 is obsolete| | Attachment #23587|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 24173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24173&action=edit Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:38:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:38:34 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 --- Comment #8 from Kyle M Hall --- Created attachment 24174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24174&action=edit Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:38:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:38:37 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 --- Comment #9 from Kyle M Hall --- Created attachment 24175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24175&action=edit Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:38:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:38:40 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 --- Comment #10 from Kyle M Hall --- Created attachment 24176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24176&action=edit Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:38:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:38:42 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 --- Comment #11 from Kyle M Hall --- Created attachment 24177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24177&action=edit Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 19:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 18:38:46 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 --- Comment #12 from Kyle M Hall --- Created attachment 24178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24178&action=edit Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 20:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 19:05:32 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from M. Tompsett --- Sorry to make this a split effort, but since my error log entries really did overlap with this bug, I figured I'd add my patch here. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 20:22:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 19:22:02 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #58 from Owen Leonard --- (In reply to Kyle M Hall from comment #57) > Owen, how do these results differ from the same tests pre-patch? I think a better question from the tester's point of view is: What problem is this patch supposed to fix? Any small improvement is good, and a test plan will tell me how to verify it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 20:57:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 19:57:03 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24171|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 24179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24179&action=edit Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 20:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 19:57:45 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24171|1 |0 is obsolete| | --- Comment #8 from M. Tompsett --- Comment on attachment 24171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24171 Bug 11182 - Warnings in circulation Silly git bz obsoleted this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 21:25:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 20:25:15 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 21:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 20:25:18 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24166|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 24180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24180&action=edit Bug 11018 - Add order from a reverted file Weird behavior: When an import is undone into catalog, the status is set to "reverted". But if you open the add orders from iso2709, the status is automatically set to "imported" and does not appear in the list. So it is not possible to import a reverted batch. Test plan: - verify you reproduce the weird behavior - apply this patch - import a file and the batch into the catalog - verify (in the your mysql/MariaDB cli) the status is "imported" - verify it does not appears in the add orders from iso2809 page - undo the import - verify (in the your mysql/MariaDB cli) the status is "reverted" - verify it appears in the add orders from iso2809 page and the status is always "reverted" - finish the order Signed-off-by: Pierre Angot Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 21:35:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 20:35:55 +0000 Subject: [Koha-bugs] [Bug 11521] New: Patron Cardnumber scanning causing patron record to be saved. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11521 Bug ID: 11521 Summary: Patron Cardnumber scanning causing patron record to be saved. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For some reason in 3.12 forward when entering a new patron, if you scan the patron's barcode (cardnumber) the system now saves the patron record rather than just moving you on to the next field. Ed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 21:37:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 20:37:14 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 21:37:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 20:37:16 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22865|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 24181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24181&action=edit [SIGNED OFF] Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 21:46:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 20:46:05 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 22:03:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 21:03:44 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 22:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 21:03:47 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 --- Comment #1 from Owen Leonard --- Created attachment 24182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24182&action=edit Bug 11505 - Untranslatable table headers in Label batch manager The label batch manager script hard-codes the table header cell labels in order to pass them to an HTML-building function. This obviously isn't the best solution for internationalization, but picking the whole scheme apart would be very complicated. Instead this patch uses a SWITCH statement to check for each possible case and outputs the correct translatable string for each. To test, apply the patch and run "perl translate update" for any translation. Check the revised po file and confirm that the new strings are present. View the label batch edit page and confirm that the table headings look correct: Tools -> Labels -> Manage batches -> Edit batch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 22:07:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 21:07:26 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 22:27:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 21:27:26 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 23:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 22:50:41 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 23:51:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 22:51:23 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon at cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 23:54:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 22:54:49 +0000 Subject: [Koha-bugs] [Bug 11522] New: self registration formatting Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Bug ID: 11522 Summary: self registration formatting Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Created attachment 24183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24183&action=edit "Required" text out of place. If you require a birth date in self registration, the red "Required" text appears below and to the left, instead of to the right of the required element. (see attachment) Looking in firebug, it appears there are empty paragraph marks. If these were to be removed, placement should be restored. (see attachment) Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 10 23:56:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jan 2014 22:56:19 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 --- Comment #1 from Christopher Brannon --- Created attachment 24184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24184&action=edit Out of place empty paragraph. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 03:49:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 02:49:20 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 03:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 02:49:25 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24182|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24185&action=edit Bug 11505 - Untranslatable table headers in Label batch manager The label batch manager script hard-codes the table header cell labels in order to pass them to an HTML-building function. This obviously isn't the best solution for internationalization, but picking the whole scheme apart would be very complicated. Instead this patch uses a SWITCH statement to check for each possible case and outputs the correct translatable string for each. To test, apply the patch and run "perl translate update" for any translation. Check the revised po file and confirm that the new strings are present. View the label batch edit page and confirm that the table headings look correct: Tools -> Labels -> Manage batches -> Edit batch. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 04:15:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 03:15:03 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24019|0 |1 is obsolete| | --- Comment #32 from Chris Cormack --- Created attachment 24186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24186&action=edit Bug 11096: (follow-up) add direct regression tests This adds direct tests of indexing and retrieving bib records that are larger than the ISO2709 limit of 99,999 octets. To test: verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton Signed-off-by: Tomas Cohen Arazi Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 04:15:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 03:15:20 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 04:15:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 03:15:24 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24020|0 |1 is obsolete| | --- Comment #33 from Chris Cormack --- Created attachment 24187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24187&action=edit Bug 11096 - Wrap each test set configuration into a subtest This makes it easier to read. Also fixes the test count, and is rebased against 11499 which is needed to correctly test the patches for this bug (i.e. indexing mode needs to be correctly set in koha-conf.xml) Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 04:15:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 03:15:42 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24172|0 |1 is obsolete| | --- Comment #34 from Chris Cormack --- Created attachment 24188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24188&action=edit Bug 11096: force XML syntax for Zebra in DOM This patch makes Koha <-> Zebra use MARCXML for the serialization. We currently use the USMARC, which remains for GRS-1. This functions are modified for that purpose: - C4::Context->Zconn - C4::Context-_new_Zconn - C4::Search->* - C4::AuthoritiesMarc->SearchAuthorities - C4::AuthoritiesMarc->merge - C4::AuthoritiesMarc->FindDuplicateAuthority C4::Context->config('zebra_bib_index_mode') and C4::Context->config('zebra_auth_index_mode') Calls to the unsafe ZOOM::Record->render()[2] method are removed. Due to this last change the code for building facets was rewritten. And for performance on the facets creation I pushed higher version dependencies for MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string). Calls to MARC::Record->new_from_xml and MARC::Record->new_from_usmarc are wrapped with eval for catching problems [2]. To test: - prove t/db_dependent/Search.t should pass. - Searching should remain functional. - Indexing and searching for a big record should work (that's what the unit tests do). Regards To+ [1] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render() [2] a record that cannot be parsed by MARC::Record is simply skipped (bug 10684) Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 04:49:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 03:49:06 +0000 Subject: [Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 04:49:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 03:49:09 +0000 Subject: [Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24170|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24189&action=edit Bug 11381 - IDreamBooks too close to title on bootstrap Styling of IDreamBooks elements is not correct in the bootstrap theme because the relevant CSS was not transferred from the prog theme. This patch adds it back. To test, switch to the bootstrap theme and enable IDreamBooks system preferences in the OPAC, particularly IDreamBooksReadometer. Find a book in the OPAC which shows IDreamBooks review data and confirm that everything looks correct. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 05:10:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 04:10:52 +0000 Subject: [Koha-bugs] [Bug 11523] New: Customized xslt display and framework Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11523 Bug ID: 11523 Summary: Customized xslt display and framework Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: eugenegf at yahoo.com QA Contact: testopia at bugs.koha-community.org If I add/customize display through modifying xslt, can I make xslts that would only be applicable to a particular framework. For example, in a certain framework, I want general notes to not show in title notes(opac)/description(intranet) but instead shown below say Publisher details area. This was first posted in Koha-general http://koha.1045719.n5.nabble.com/koha-xslt-and-framework-td5783402.html#a5783566 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 05:20:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 04:20:14 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 05:20:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 04:20:18 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24165|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24190&action=edit Bug 11476 - Opac self registration title pull down offers 2 empty options If you have patron titles enabled, the OPAC patron details form lists 2 empty spaces instead of 1. An empty option is passed by the script, so the template does not need to include one. To test you must have at least one patron title set in BorrowersTitles system preference and OPACPatronDetails must be set to "allow." 1. Apply the patch 2. Log in to the OPAC 3. Click the "personal details" tab. 4. Click the "salutation" dropdown. There should be only one blank line preceding the existing titles. Test in both prog and bootstrap. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 06:04:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 05:04:49 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 --- Comment #2 from M. Tompsett --- Comment on attachment 24161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24161 Bug 11503 - Several typos Review of attachment 24161: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11503&attachment=24161) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/subtypes_unimarc.inc @@ +29,4 @@ > > > > + Removed extra S. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt @@ +158,4 @@ > >
> > + Removed excess i. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_121a.tt @@ +48,4 @@ > > [% END %] > [% IF ( f2d ) %] > + Added missing e. Check. @@ +52,2 @@ > [% ELSE %] > + Added missing e. Check. @@ +226,4 @@ > > [% END %] > [% IF ( f5y ) %] > + Added missing t. Check. @@ +230,2 @@ > [% ELSE %] > + Added missing t. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/about.tt @@ +10,4 @@ > >

Perl modules

> > +

This tab lists all the dependent Perl modules for Koha and whether or not you have them installed, and the version number. If you are reporting an issue, the developer may ask what is the state of the Perl modules you have installed.

Changes a to e for dependent. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/basket.tt @@ +101,4 @@ > >

Clicking the 'Uncertain Prices' button will call up a list of items with uncertain prices to quick editing.

> > +

Important: The Uncertain Prices page is independent of the basket. It is linked to the vendor so you will see all items on order with uncertain prices for that vendor.

Changes e to o for vendor. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/lateorders.tt @@ +14,4 @@ > >

Note: The Estimated Delivery Date is based on the Delivery time value entered on the vendor record.

> > +

There is a default acquisitions claim letter. If you would rather use a different one, you can create that in the notices module and choose it from the menu above the list of late items.

Corrects spelling of claim. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/auth_subfields_structure.tt @@ +20,4 @@ >
    >
  • 'Text for librarian' is what appears before the subfield in the librarian interface.
    • >
  • 'Text for OPAC' is what appears before the field in the OPAC.If left empty, the text for librarian is used instead
    • > +
  • If 'Repeatable' is checked, the field will have a plus sign next to it in the MARC cataloging module which allows you to add multiples of that tag.
    • Corrected monologue to module. -- missed double space, but HTML will cover that. Okay. @@ +50,4 @@ >
      >
    • (! means 'not visible' or in the case of collapsed 'not collapsed')
      • >
    • If 'Is a url' is checked, the subfield is a url and can be clicked
      • > +
    • 'Authorized Value' allows the librarian to select an authorized value list from which catalogers must choose an option.
      • Changed cataloguers to catalogers. FEEDBACK DESIRED. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/authorised_values.tt @@ +33,4 @@ >
    • 'MANUAL_INV' includes values for manual invoicing.
      • >
    • 'NOT_LOAN' is used to list reasons why a title is not for loan.
      • >
    • 'PROC' is for the location to be used for NewItemsDefaultLocation (change description as desired), also the location expected by InProcessingToShelvingCart.
      • > +
    • 'REPORT_GROUP' provides a way to sort and filter your reports, the default values in this category include the Koha modules (Accounts, Acquisitions, Catalog, Circulation, Patrons)
      • Corrected spelling of Acquisitions. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/item_circulation_alerts.tt @@ +16,4 @@ >
    • To set preferences for all libraries, keep the menu set to 'Default'
      • >
    > > +
  • By default all item types and all patrons are notified of check ins and check outs. To change this, click on the item/patron type combination that you would like to stop notices for.
    • Changed combo to combination. Good idea. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/preferences.tt @@ +16,4 @@ > >
      >
    • Acquisitions: holds preferences related to acquisitions such as handling patron suggestions and local taxes.
      • > +
    • Administration: holds administrative preferences such as admin email address, sessions and timeout.
      • Added missing e in timeout. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/smart-rules.tt @@ +23,4 @@ > >

      Default Circulation Rules

      > > +

      Using the issuing rules matrix you can define rules that depend on patron/item type combinations. To set your rules, choose a library from the pull down (or 'all libraries' if you want to apply these rules to all libraries)

      Corrected 'typecombos' to 'type combinations'. Check. @@ +33,4 @@ >
    • Limit the number of items a patron can have checked out at the same time by entering a number in the 'Current Checkouts Allowed' field
      • >
    • Define the period of time an item can be checked out to a patron by entering the number of units (days or hours) in the 'Loan Period' box.
      • >
    • Choose which unit of time, Days or Hours, that the loan period and fines will be calculate in
      • > +
    • You can also define a hard due date for a specific patron category and item type. A hard due date ignores your usual circulation rules and makes it so that all items of the type defined are due on, before or after the date you specify.
      • Adding missing space between all and items. Check. @@ +57,4 @@ > >
    • Next decide if the patron can renew this item type and if so, enter how many times they can renew it in the 'Renewals Allowed' box
      • >
    • If the patron can place holds on this item type, enter the total numbers of items (of this type) that can be put on hold in the 'Holds Allowed' field
      • > +
    • Finally, if you charge a rental fee for the item type and want to give a specific patron type a discount on that fee, enter the percentage discount (without the % symbol) in the 'Rental Discount' field
      • Added missing space between fee and for. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/mainpage.tt @@ +11,4 @@ >
    • Read Koha documentation
      • >
    • Read/Write to the Koha wiki
      • >
    • Read and contribute to discussions
      • > +
    • Report Koha bugs
      • Capitalized Koha. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/members/member-flags.tt @@ +45,4 @@ >
    • parameters >
        >
      • Manage Koha system settings (Administration panel)
        • > +
      • This section can be expanded
        • Corrected spelling of section. Check. @@ +71,4 @@ > >
      • editcatalogue >
          > +
        • Edit Catalog (Modify bibliographic/holdings data)
          • Added missing l in holdings. Check. @@ +88,4 @@ > >
        • management >
            > +
          • Set library management parameters (deprecated) Corrected spelling of parameters. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/plugins/plugins-home.tt @@ +2,4 @@ > >

            Plugins

            > > +

            Koha's Plugin System allows for you to add additional tools and reports to Koha that are specific to your library. Plugins are installed by uploading KPZ ( Koha Plugin Zip ) packages. A KPZ file is just a zip file containing the perl files, template files, and any other files necessary to make the plugin work.

            Removed excess c from necessary. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/plugins/plugins-upload.tt @@ +2,4 @@ > >

            Upload Koha plugin

            > > +

            Koha's plugin system allows for you to add additional tools and reports to Koha that are specific to your library. Plugins are installed by uploading KPZ ( Koha Plugin Zip ) packages. A KPZ file is just a zip file containing the perl files, template files, and any other files necessary to make the plugin work.

            Corrected the spelling of necessary. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/reports/guided_reports.tt @@ +84,4 @@ > >

            Reports can also be added by duplicating an existing report. Visit the 'Saved reports' page to see all of the reports listed on your system.

            > > +

            To the right of every report there is an 'Actions' pull down. Clicking that and choose 'Duplicate' to use an existing report as the basis for your new report. That will populate the new report form with the existing SQL for easy editing and resaving.

            Added missing g to Clicking. Check. @@ +167,4 @@ >
          • 1 = Circulation
            • >
          • 2 = Catalog
            • >
          • 3 = Patrons
            • > +
          • 4 = Acquisitions
            • Corrected spelling of Acquisitions. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/reserve/request.tt @@ +28,4 @@ > >
          • If the patron has specified that they don't want the item after a certain date, or if you have limits on hold lengths, you can enter an expiration date for the hold in the 'Hold expires on date' >
              > +
            • To have expired holds cancelled automatically you will need to have the Expired Holds cron job set to run on a regular basis.
              • Corrected spelling of cancelled. Is this another American vs. non-American English issue? @@ +40,4 @@ > >

              Managing Holds

              > > +

              Holds can be altered and cancelled from the Holds tab found on the left of the bibliographic record.

              Corrected spelling of cancelled. Same question. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/serials/serials-edit.tt @@ +1,3 @@ > [% INCLUDE 'help-top.inc' %] > > +

              Receiving Serials

              Corrected spelling of Receiving. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/serials/subscription-detail.tt @@ +4,4 @@ > >

              This page shows you all of the information about your subscription including issue history.

              > > +

              From here you can edit your subscription, renew it and/or receive issues.

              Corrected spelling of receive. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/serials/subscription-frequencies.tt @@ +4,4 @@ > >

              Koha keeps a record of publication frequencies for easy management and duplication.

              > > +

              From this page you can view all of the existing frequencies in your system and create new ones.

              Removed extra i from existing. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/holidays.tt @@ +10,4 @@ >
            • Choose the method for calculating due date - either include days the library is closed in the calculation or don't include them.
              • >
            >
            • > +
          • Get there: More > Administration > Global System Preferences > Circulation > finesCalendar Is that supposed to be finesCalendar or Fines Calendar? ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/marc_modification_templates.tt @@ +4,4 @@ > >

            The MARC Modification Templates system gives Koha users the power to make alterations to MARC records automatically while staging MARC records for import.

            > > +

            This tool is useful for altering MARC records from various vendors/sources work with your MARC framework. The system essentially allows one to create a basic script using actions to Copy, Move, Add, Update and Delete fields.

            Corrected spelling of vendors. Check. @@ +18,4 @@ >
          • Click 'Add action'
            • >
          > > +

          Each action can also have an optional condition to check the value or existence of another field. For example you might want to add the call number to the item record if it's not already there.

          Corrected spelling of existence. What about a comma after For example? @@ +22,4 @@ > >
            >
          • Choose 'Copy'
            • > +
          • Decide if you want to copy the first occurrence or all occurrences of the field
            • Corrected occurance to occurrence. Check. @@ +36,4 @@ > >
              >
            • Choose 'Copy'
              • > +
            • Decide if you want to copy the first occurrence or all occurrences of the field
              • Corrected occurance to occurrence. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/quotes-upload.tt @@ +26,4 @@ >
            • Delete Quote(s)
              • >
                >
              1. This option allows for the deletion of one or more quotes at a time.
                2. > +
              2. Select the quote(s) you desire to delete by clicking on the corresponding quote id.
                3. Corrected spelling of corresponding. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/quotes.tt @@ +26,4 @@ >
              3. Delete Quote(s)
                4. >
                  >
                1. This option allows for the deletion of one or more quotes at a time.
                  2. > +
                2. Select the quote(s) you desire to delete by clicking on the corresponding quote id.
                  3. Corrected spelling of corresponding. Check. ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ +246,4 @@ >
                3. No copies are available to be placed on hold
                  4. > [% END %] > [% IF ( alreadypossession ) %] > +
                4. [% borrowerfirstname %] [% borrowersurname %] is already in possession of one item
                  5. Added missing s to possession. Check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 06:08:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 05:08:03 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- Take note of the one's I didn't put "Check" or "Okay" on. I did suggest another edit as well. There were American vs. non-American English questions in my mind. What is it supposed to be? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 15:40:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 14:40:14 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 --- Comment #9 from Katrin Fischer --- Created attachment 24191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24191&action=edit [PASSED QA] Bug 11334 [QA Followup] - Add facet for home library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 15:40:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 14:40:47 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 15:40:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 14:40:51 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24007|0 |1 is obsolete| | Attachment #24008|0 |1 is obsolete| | Attachment #24191|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 24192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24192&action=edit [PASSED QA] Bug 11334 - Add facet for home library The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label "Libraries" now reads "Holding libraries" 3) Update the system preference DisplayLibraryFacets to "home library" 4) Check that the facet now reads "Home libraries" 5) Update the preference again to "both home and holding library" 6) Check that both the facets for home and holding library are now displayed. Signed-off-by: Jen DeMuth Signed-off-by: Katrin Fischer Passes all tests and QA script. Changes apply to both prog and bootstrap OPAC and staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 15:41:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 14:41:08 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 --- Comment #11 from Katrin Fischer --- Created attachment 24193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24193&action=edit [PASSED QA] Bug 11334 [QA Followup] - Add facet for home library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 15:43:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 14:43:00 +0000 Subject: [Koha-bugs] [Bug 11334] Add facet for home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 --- Comment #12 from Katrin Fischer --- I am not sure if the change in the label could be confusing to patrons - it might be an idea to still show "Libraries" when only home or holding library are displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 16:00:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 15:00:56 +0000 Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text "Select titles to: " in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 16:00:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 15:00:59 +0000 Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text "Select titles to: " in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 --- Comment #1 from Katrin Fischer --- Created attachment 24194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24194&action=edit Bug 11495: Make "Select titles to: " translatable Fixes translation of "Select titles to: " on the Bootstrap OPAC result page. Test plan: - Update one of the po files running: perl translate update - Verify that "Select titles to: " is only listed once for search-results.tt Apply patch - Verify addings titles to lists and cart from the result list still works as expected - Rerun the po file update - Verify the string is now listed twice for search-results.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 16:01:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 15:01:24 +0000 Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text "Select titles to: " in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 16:13:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 15:13:15 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #20 from Katrin Fischer --- Now Kyle was faster with doing QA:) Welcome JaTara! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 17:45:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 16:45:18 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 --- Comment #10 from Katrin Fischer --- Created attachment 24195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24195&action=edit test case home library/pickup library Kyle, I have double checked everything, but the test case described in the attached PDF doesn't seem to give the correct result to me. Could you please take a look? When I turn off LocalHoldsPriority the hold for R is triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 17:45:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 16:45:39 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 19:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 18:41:05 +0000 Subject: [Koha-bugs] [Bug 11520] Invoice isn't really an invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure about the replacement cost - do you mean the RRP column? I think this is "recommended retail price". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 19:58:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 18:58:55 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 20:47:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 19:47:35 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24171|0 |1 is obsolete| | Attachment #24179|0 |1 is obsolete| | --- Comment #10 from Jesse Weaver --- Created attachment 24196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24196&action=edit Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 20:47:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 19:47:42 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #88 from Katrin Fischer --- Comment on attachment 22877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22877 Bug 7825: Changed OPACItemHolds syspref to be no|tes|force choice Review of attachment 22877: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7825&attachment=22877) ----------------------------------------------------------------- Hi Jonathan, in your comment you wrote: The value field should not be change. We have to keep '1' for 'yes' and '' for 'no'. But I still see the yes/no in the database update and syspref part? ::: installer/data/mysql/sysprefs.sql @@ +228,4 @@ > ('OpacHiddenItems','','','This syspref allows to define custom rules for hiding specific items at opac. See docs/opac/OpacHiddenItems.txt for more informations.','Textarea'), > ('OpacHighlightedWords','1','','If Set, then queried words are higlighted in OPAC','YesNo'), > ('OpacHoldNotes','0','','Show hold notes on OPAC','YesNo'), > +('OPACItemHolds','yes','no|yes|force','Allow OPAC users to place hold on specific items. If No, users can only request next available copy. If Yes, users can choose between next available and specific copy. If Force, users *must* choose a specific copy.','Choice'), Should be 0 and 1? ::: installer/data/mysql/updatedatabase.pl @@ +7745,5 @@ > > + > +$DBversion = "3.13.00.XXX"; > +if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > + $dbh->do("UPDATE systempreferences SET type = 'Choice', options = 'no|yes|force' WHERE variable = 'OPACItemHolds'"); Should be 0 and 1? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 20:48:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 19:48:54 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #89 from Katrin Fischer --- I will wait for a follow-up and then continue on this as soon as I can. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 20:55:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 19:55:45 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 20:55:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 19:55:48 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24190|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24197&action=edit [PASSED QA] Bug 11476 - Opac self registration title pull down offers 2 empty options If you have patron titles enabled, the OPAC patron details form lists 2 empty spaces instead of 1. An empty option is passed by the script, so the template does not need to include one. To test you must have at least one patron title set in BorrowersTitles system preference and OPACPatronDetails must be set to "allow." 1. Apply the patch 2. Log in to the OPAC 3. Click the "personal details" tab. 4. Click the "salutation" dropdown. There should be only one blank line preceding the existing titles. Test in both prog and bootstrap. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described for existing and creating new accounts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 21:01:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 20:01:06 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #11 from Jesse Weaver --- Created attachment 24198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24198&action=edit Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 21:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 20:01:04 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 21:35:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 20:35:42 +0000 Subject: [Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 21:35:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 20:35:45 +0000 Subject: [Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24189|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24199&action=edit [PASSED QA] Bug 11381 - IDreamBooks too close to title on bootstrap Styling of IDreamBooks elements is not correct in the bootstrap theme because the relevant CSS was not transferred from the prog theme. This patch adds it back. To test, switch to the bootstrap theme and enable IDreamBooks system preferences in the OPAC, particularly IDreamBooksReadometer. Find a book in the OPAC which shows IDreamBooks review data and confirm that everything looks correct. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described. Tested with "The help". http://bugs.koha-community.org/show_bug.cgi?id=11281 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 21:41:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 20:41:16 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24185|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24200&action=edit [PASSED QA] Bug 11505 - Untranslatable table headers in Label batch manager The label batch manager script hard-codes the table header cell labels in order to pass them to an HTML-building function. This obviously isn't the best solution for internationalization, but picking the whole scheme apart would be very complicated. Instead this patch uses a SWITCH statement to check for each possible case and outputs the correct translatable string for each. To test, apply the patch and run "perl translate update" for any translation. Check the revised po file and confirm that the new strings are present. View the label batch edit page and confirm that the table headings look correct: Tools -> Labels -> Manage batches -> Edit batch. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, passes all tests. Similar fixes are probably needed for other pages of the labels modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 21:42:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 20:42:00 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 21:57:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 20:57:38 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #10 from Katrin Fischer --- I tried this with Firefox 26 in Ubuntu for a result page in staff and a very full cart. Without the patch, the pages prints nicely. With the patch, we have the navigation on the first page and the rest on the second. This is quite a regression in newer Firefox versions. I hesitate to pass QA on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 22:18:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 21:18:53 +0000 Subject: [Koha-bugs] [Bug 11524] New: Strange URL parameters in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524 Bug ID: 11524 Summary: Strange URL parameters in OPAC Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org While testing some patches, I noticed that the OPAC will generate 'strange' URLs when you repeat the following steps: - Log into the OPAC - Do a search for any search term in simple search - Change the sorting The resulting URL is: http://localhost/cgi-bin/koha/opac-search.pl?idx=kw&q=der&sort_by=pubdate_dsc&addto=Add+to...&biblionumber=2&loggedinuser=&biblionumber=4&loggedinuser=&biblionumber=7&loggedinuser=&biblionumber=8&loggedinuser=&biblionumber=9&loggedinuser=&biblionumber=10&loggedinuser=&biblionumber=11&loggedinuser=&biblionumber=13&loggedinuser=&biblionumber=14&loggedinuser=&biblionumber=18&loggedinuser=&biblionumber=19&loggedinuser=&biblionumber=23&loggedinuser=&biblionumber=32&loggedinuser=&biblionumber=35&loggedinuser=&biblionumber=38&loggedinuser=&biblionumber=40&loggedinuser=&biblionumber=47&loggedinuser=&biblionumber=50&loggedinuser=&biblionumber=58&loggedinuser=&biblionumber=60&loggedinuser= I think this could be an unwanted side effect of the search history patches that were recently pushed (bug 10952). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 22:38:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 21:38:28 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 22:38:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 21:38:31 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24125|0 |1 is obsolete| | Attachment #24126|0 |1 is obsolete| | Attachment #24163|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer --- Created attachment 24201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24201&action=edit [PASSED QA] Bug 10857: Add facets cancellation When searching (at the OPAC or pro), facets can be enabled but never disabled. So a user is obliged to relaunch the search. This patch adds a new link "[x]" at the right of each selected facet. This link relaunch the search without this facet. Test plan: - Launch a search (OPAC and pro) - Enable some facets - Disable some facets Signed-off-by: sonia bouis Signed-off-by: Katrin Fischer Patches pass all tests and QA script. Nice feature! Tested in Boostrap and Prog, adding end removing multiple facets in different sequences, adding and removing the availability limit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 22:38:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 21:38:39 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #46 from Katrin Fischer --- Created attachment 24202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24202&action=edit [PASSED QA] Bug 10857: Encode 'limit' parameter values to allow facets with '&' character. Signed-off-by: sonia bouis Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 22:38:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 21:38:44 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #47 from Katrin Fischer --- Created attachment 24203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24203&action=edit [PASSED QA] Bug 10857: Add facets cancellation - bootstrap theme. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 22:41:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 21:41:06 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11524 --- Comment #48 from Katrin Fischer --- I think maybe the little x could be formatted a bit differently to be more obvious, but that is not enough for failing QA on this :) I discovered bug 11524 while testing this, which could be related to bug 10952 this depends on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 22:41:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 21:41:06 +0000 Subject: [Koha-bugs] [Bug 11524] Strange URL parameters in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10857 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 11 22:54:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jan 2014 21:54:24 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #35 from Katrin Fischer --- The QA script passes now for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:38:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:38:00 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:38:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:38:04 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24097|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 24204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24204&action=edit Bug 11510: koha-translate usage message fixes The koha-translate's usage message has a couple of inconsistencies: '--all' should be '--available' and '--help' is missing from the usage examples. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:39:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:39:16 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:39:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:39:19 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24098|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 24205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24205&action=edit Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:46:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:46:44 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23112|0 |1 is obsolete| | --- Comment #29 from Chris Cormack --- Created attachment 24206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24206&action=edit Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC This adds a new page to the OPAC that can search several Z39.50 targets using Pazpar2. Test plan: 1) Apply patches. 2) Update database. 3) Add one or more Z39.50 targets, using the Administration -> External targets screen. Note that not all targets support keyword search, but here are some that do: * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8 * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8 4) Perform a search on the OPAC, check to see if the "external targets" notice pops up at the top. 5) Click on the results link near that message. 6) This should bring back results from all enabled targets, all of which should be clickable to bring up a detailed view of the record. (This version fixes some typos and accidental changes.) Signed-off-by: Chris Cormack Fixing some conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:47:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:47:01 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23113|0 |1 is obsolete| | --- Comment #30 from Chris Cormack --- Created attachment 24207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24207&action=edit Bug 10486 followup - fix pazpar2 configuration file This removes some deprecated elements and changes the name of some others. For an existing install, you will need to make the following changes to your installed pazpar2.xml configuration file: 1. Remove the and tags from , and . 2. Change the tags to . Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:47:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:47:14 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24036|0 |1 is obsolete| | --- Comment #31 from Chris Cormack --- Created attachment 24208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24208&action=edit Bug 10486 QA followup: Fix license headers, add tests XSLT.t is the only one modified, so to run the tests, just do: prove t/XSLT.t Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:48:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:48:04 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #32 from Chris Cormack --- Seems to work fine, last thing needed is the bootstrap templates. Then I'm happy to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 01:57:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 00:57:31 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24181|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 24209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24209&action=edit Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 04:38:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 03:38:09 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- This eyeballs well, but step-by-step instructions would really help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 04:54:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 03:54:45 +0000 Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 04:54:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 03:54:47 +0000 Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22426|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 24210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24210&action=edit [SIGNED OFF] Bug 11136 - action_logs should be a MyISAM table, not InnoDB The table action_logs is written too at a higher rate than practically any other table. Additionally, action_logs has no foreign key constraints. It seems that this would be a somewhat unique situation where using MyISAM would provide quite a performance boost for large sites with many transactions that use the Action Logs. TEST PLAN --------- NOTE: These instructions toast the database, so backup as needed! 1) open mysql client 2) use the koha database 3) show create table action_logs; -- This should currently be InnoDB listed as the engine. 4) close mysql client 5) apply patch 6) ./installer/data/mysql/updatedatabase.pl -- This should apply the update. 7) open mysql client 8) use the koha database 9) show create table action_logs; -- The engine should now be MyISAM. 10) drop the koha database 11) create the koha database 12) close mysql client 13) go to the staff client and do the web installation 14) open mysql client 15) use the koha database 16) show create table action_logs; -- The engine should now be MyISAM. Also, the AUTO_INCREMENT won't be shown, since the log file is currently empty. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 04:57:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 03:57:24 +0000 Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- I agreed with Kyle's reasoning, noted that both the fresh install and update are done. This will need a number tweak before being pushed to master, as it is 3.13 instead of the expected 3.15, but that's not really an issue I think. Signed off! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 05:01:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 04:01:59 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11432 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 05:01:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 04:01:59 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11489 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 05:03:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 04:03:52 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 --- Comment #9 from M. Tompsett --- Galen, is 11489 the type of patch you were talking about on the IRC channel? If so, perhaps Jonathan Druart's patch combined with 11489 would be the proper solution? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 05:34:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 04:34:22 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- To be honest, I'm confused by the description. I'm a non-librarian. So there is order entry and order receiving, right? When do these fields get set? I didn't go read the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 05:42:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 04:42:25 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 --- Comment #11 from M. Tompsett --- Comment on attachment 23092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23092 Bug 11148: Two routines are useless in Koha::DateUtils Review of attachment 23092: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11148&attachment=23092) ----------------------------------------------------------------- ::: t/DateUtils.t @@ -68,5 @@ > cmp_ok $date_string, 'eq', '16/06/2011', 'metric output (date only)'; > > -$date_string = output_pref({ dt => $dt, dateformat => 'metric', timeformat => '24hr' }); > -cmp_ok $date_string, 'eq', '16/06/2011 12:00', > - 'output_pref_due preserves non midnight HH:SS'; Why did you cut this test? The text is wrong, but the function call is output_pref, which is still used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 08:13:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 07:13:29 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 08:13:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 07:13:35 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #122 from Chris Cormack --- Created attachment 24211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24211&action=edit Bug 7143 : Updating about page and history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 09:03:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 08:03:37 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- When items are created on order (AcqCreateItem = on order) the subfields of those items will be updated as set in this preference automatically during the receive process. For example this will allow to remove the 'on order' status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 09:41:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 08:41:04 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #33 from Katrin Fischer --- Comment on attachment 24206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24206 Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC Review of attachment 24206: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10486&attachment=24206) ----------------------------------------------------------------- Hi Jesse, I got curious and took a look at the code. Looks mostly good (as far as I can tell), but I spotted some translation issues in the templates. Could you take a look please? ::: C4/Search.pm @@ +72,4 @@ > &GetDistinctValues > &enabled_staff_search_views > &PurgeSearchHistory > + &GetExternalSearchTargets New routine - being super strict I would expect some unit tests :) ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/external-targets.tt @@ +27,5 @@ > + $( '#targets tr[data-targetid=[% saved_id %]]' ).addClass( 'updated' ); > + [% END %] > + > + $( '#targets .delete' ).click( function() { > + return confirm( _( 'Are you sure you wish to delete this target?' ) ); Please use "" else a translation using ' can break the Javascript code. ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-external-search.tt @@ +67,5 @@ > + } ); > +} > + > +function search( offset, reset_search ) { > + $( '#pazpar2-status' ).html( 'Searching external targets... ' ); 'Searching external targets' is untranslatable. Marking all spotted translation problems with 'T'. @@ +77,5 @@ > + } > + > + function callback( data ) { > + if ( data.error ) { > + $( '#pazpar2-status' ).html( 'Error searching external targets.' ); T @@ +82,5 @@ > + return; > + } > + > + if ( !data.total ) { > + $( '#pazpar2-status' ).html( 'No results found in the external targets.' ); T @@ +88,5 @@ > + } > + > + $( '#results tbody' ).empty(); > + > + $( '#pazpar2-status' ).html( '' + _( 'Found ' ) + data.total + _( ' results in ' ) + $( '#targets-facet input:checked' ).length + _( ' external targets.' ) + '' ); T (single quotes). Also a bit hard to translate, as this will be split up in the translation file. @@ +104,5 @@ > + > + if ( resultRenderCache[ hit.recid[0] ] ) { > + results.push( resultRenderCache[ hit.recid[0] ] ); > + } else { > + results.push( hit['md-work-title'] ? hit['md-work-title'][0] : 'Loading...' ); T @@ +131,5 @@ > + var cur_page = data.start / results_per_page; > + var max_page = Math.floor( data.total / results_per_page ); > + > + if ( cur_page != 0 ) { > + pages.push( '<< Previous' ); T @@ +143,5 @@ > + } > + } > + > + if ( cur_page < max_page ) { > + pages.push( ' Next >>' ); T ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt @@ +319,4 @@ > } > + > + first_succeeded = true; > + FinishExternalSearch( 'pazpar2', _("Found __LINK__ in ") + num_targets + _(" external targets"), data.total, '/cgi-bin/koha/opac-external-search.pl?q=' + escape( querystring ) ); This looks interesting. Maybe a replacement like __LINK__ could make translating the sentences easier. ::: opac/opac-external-search.pl @@ +17,5 @@ > +# with Koha; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + > +use strict; > +use warnings; Could be using Modern Perl instead. ::: opac/opac-search.pl @@ +884,5 @@ > > +$template->{VARS}->{OPACSearchExternalTargets} = C4::Context->preference('OPACSearchExternalTargets'); > +$template->{VARS}->{external_search_targets} = GetExternalSearchTargets( C4::Context->userenv ? C4::Context->userenv->{branch} : '' ); > + > +$template->{VARS}->{OverDriveLibraryID} = C4::Context->preference('OverDriveLibraryID'); I think some of those lines could now be replaced using the TT plugin for looking up the system preferences from the template. Just noting, it's ok to leave it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 10:04:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 09:04:17 +0000 Subject: [Koha-bugs] [Bug 11258] Holds queue is still making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I am sorry, but I can't seem to reproduce the bug on current master. I followed the test plan, but my holds queue entry is the same before and after applying the patch. >1) Create a test record with 2 items with different itemtypes Branches, itemtype, barcode Midway, Books, t1 Midway, Computer files, t2 >2) Set the Default holds policy by item type for the first > item to "From any library" Midway: Books, from any library >3) Set the Default holds policy by item type for the second > item to "From home library" Midway: Computer files, from home library >4) Place a record level hold for a patron from another library, > but for pickup at the same library as the item is from Switched to Riverside, placed a title level hold for a Riverside patron, pickup location is Midway. >5) Rebuild the holds queue Entry reads: Books, t1 or any available >6) View the holds queue, note the item is listed, though this > patron cannot place a hold on this item I couldn't reproduce this. >7) Apply this patch >8) Repeat step 5, note the hold is no longer in the queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 11:50:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 10:50:21 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #23 from Katrin Fischer --- Working on this now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 12:18:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 11:18:10 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer --- Some notes: 1) The feature is activated by default on updated installations. I think it would be better to only activate it on new installations. 2) The return date defaults to "today 23:59". Wouldn't it make more sense to default to "yesterday 23:95"? And consequently, should we allow setting return dates in the future? 3) If you use the date the plugin suggests, check the checkbox for keeping the date and then submit the form with empty barcode or return a book, following error occurs: Template process failed: undef error - Can't use string ("") as a HASH ref while "strict refs" in use at /home/katrin/kohaclone/Koha/Template/Plugin/Borrowers.pm line 47. It also happens with a return date in the past, book was not checked out. X) We have the same problem here as we have on bug 10995. For accessibility reasons we should allow manual entry of the date and time, but we need to catch the errors. If you enter an invalid date now, you get a nasty perl error. I got: Can't call method "ymd" on an undefined value at /usr/share/perl5/DateTime/Format/MySQL.pm line 84. Failed for 2) and 3). X) is kind of a difficult one. I really think we need a general solution here, but not sure how to achieve it. Not going to fail for that right now, but welcoming ideas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 12:20:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 11:20:48 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #41 from Katrin Fischer --- Hi Jonathan, I am sorry, but there are too many conflicts outside of updatedatabase. Could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 12:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 11:46:35 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 14:43:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 13:43:36 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #26 from Katrin Fischer --- Team Lyon, there is an open question from Jonathan in comment 25 - could you please take a look? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 16:20:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 15:20:57 +0000 Subject: [Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 16:21:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 15:21:01 +0000 Subject: [Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23885|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24212&action=edit [PASSED QA] Bug 11389: reenable Pg as a DB scheme that Koha can connect to This patch restores the ability to request a DBI database handle or a DBIx::Class schema object connected to a PostgreSQL database. To address the concerns raised in bug 7188, only "mysql" and "Pg" are recognized as valid DB schemes. If anything else is passed to C4::Context::db_scheme2dbi or set as the db_scheme in the Koha configuration file, the DBD driver to load is assumed to be "mysql". Note that this patch drops any pretense of Oracle support. To test: [1] Apply patch, and verify that the database-dependent tests pass when run against a MySQL Koha database. [2] To test against PostgreSQL, create a Pg database and edit koha-conf.xml to set db_scheme to Pg (and adjust the other DB connection parameters appropriately). The following tests should pass, at minimum: t/Context.t t/db_dependent/Koha_Database.t Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, some additional notes: - Installed Postgres following http://wiki.ubuntuusers.de/PostgreSQL - Created a database user koha - Created a database koha - Changed the koha-conf.xml file Pg koha localhost 5432 koha xxxx - Installed libdbd-pg-perl - Ran the web installer until step 3 everything looked ok Step 3 complains: Password for user koha: psql: fe_sendauth: no password supplied - Both t/Context.t and t/db_dependent/Koha_Database.t pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 20:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 19:26:04 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 --- Comment #27 from Katrin Fischer --- Comment on attachment 23987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23987 Bug 6254 [QA Followup 1] - can't set patron privacy by default Review of attachment 23987: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6254&attachment=23987) ----------------------------------------------------------------- Kyle, we are really almost there, but there is a translation problem: ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt @@ +276,5 @@ > + Enrollment fee: [% category.enrolmentfee | format('%.02f') %] > + Receives overdue notices: [% IF ( category.overduenoticerequired ) %]Yes[% ELSE %]No[% END %] > + Lost items in staff client[% IF ( category.hidelostitems ) %]Hidden by default[% ELSE %]Shown[% END %] > + Hold fee: [% category.reservefee | format('%.02f') %] > + Default privacy: [% category.default_privacy %] I think this should be a SWITCH making the never, forever and default translatable. The configuration page already does it correctly. @@ +404,5 @@ > No limitation > [% END %] > > + > + [% loo.default_privacy %] And here. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 20:26:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 19:26:24 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 21:39:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 20:39:44 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 21:39:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 20:39:48 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24035|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 24213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24213&action=edit [PASSED QA] Add the borrower's cardnumber and phonenumber to the branch overdues. http://bugs.koha-community.org/show_bug.cgi?id=11359 Signed-off-by: Nicole C. Engard All tests pass, this adds data to the Patron column on the overdues with fines report to show the patron's cardnumber and phone number. Signed-off-by: Katrin Fischer This works as described and passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 21:41:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 20:41:57 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- An idea: If we made the line breaks (
                  ) dependent on the existance of the phone number/email address we could save some space. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 22:24:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 21:24:43 +0000 Subject: [Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 22:24:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 21:24:46 +0000 Subject: [Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23926|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24214&action=edit [PASSED QA] Bug 11477 - Add names for librarian and borrowers in the logs This patch adds the first name and surname of the librarian and the user involved in a transaction log, if available. If neither the firstname or the surname is available, then the 'object' number will be prefaced with the 'Member' qualifier. _TEST PLAN_ 0) This patch depends on Bug 11473, so you must apply it first Before applying this patch (11477): 1) View the logs. 2) Note that the Librarian column just has a number 3) Note that the Object column will just say Member X (where X is a number), in the circulation, fines, and patron/member modules. Apply the patch. 4) Reload the logs (you don't need to make new ones) 5) Note that the Librarian and Object columns mentioned above now have firstname and surname appearing (where available) Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 22:42:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 21:42:25 +0000 Subject: [Koha-bugs] [Bug 10318] show email on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 22:42:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 21:42:28 +0000 Subject: [Koha-bugs] [Bug 10318] show email on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23991|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 24215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24215&action=edit [PASSED QA] Show primary email in patron search results Now showing primary email address of a patron in the patron search results page added mailto link to the email address http://bugs.koha-community.org/show_bug.cgi?id=10318 Signed-off-by: Melissa Lefebvre Signed-off-by: Katrin Fischer Works as described, template only change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 22:43:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 21:43:11 +0000 Subject: [Koha-bugs] [Bug 10318] show email on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This works nicely. A little improvement would be to avoid the additional blank line that is added, when a patron has an email, but no postal address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 22:46:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 21:46:33 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|oleonard at myacpl.org |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 22:46:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 21:46:47 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 23:29:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 22:29:12 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 23:29:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 22:29:15 +0000 Subject: [Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24034|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 24216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24216&action=edit [PASSED QA] Bug 11466 - Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' -------------- -- Synopsis -- -------------- When system preference AdvancedSearchTypes has other values than 'itemtypes', for ex 'itemtypes|loc', itemtypes selection in opac-suggestions.pl is not populated with available itemtypes. This patch fixes the issue by broadening the strict comparison of ($advanced_search_types eg 'itemtypes') #fails 'itemtypes|loc' to ($advanced_search_types =~ 'itemtypes') #succeeds 'itemtypes|loc' Unit tests included --------------- -- Test plan -- --------------- REPLICATING THE ISSUE 1. Set system preference AdvancedSearchTypes to itemtypes|loc 2. Go to opac-suggestions.pl and observe Item type dropdown list 2.1. List should have itemtypes available for selection Thanks for testing! You are awesome! gg Signed-off-by: Nicole C. Engard Tests worked as expected. Placed a suggestion and saw the whole list of item types, chose one, saved, checked staff and it loaded as expected. Changed item type in staff and it applied in both views. Signed-off-by: Katrin Fischer Works as described, passes all tests including new regression tests. Restores old functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 23:47:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 22:47:12 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer --- Hi Kyle, there is a conflict in Branches.pm. I tried to resolve it, but started wondering about @bind_parameters. You remove the push line, so it never gets assigned, but is used later on. Also I think we should use ? instead of $branches. my $query="SELECT * FROM branches"; my @bind_parameters; if ($onlymine && C4::Context->userenv && C4::Context->userenv->{branch}){ - $query .= ' WHERE branchcode = ? '; - push @bind_parameters, C4::Context->userenv->{branch}; + my $branches = GetIndependentGroupModificationRights({ stringify => 1 }); + $query .= qq{ WHERE branchcode IN ( $branches ) }; } $query .= " ORDER BY branchname"; $sth = $dbh->prepare($query); $sth->execute(@bind_parameters); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 12 23:53:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jan 2014 22:53:26 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #26 from Katrin Fischer --- Hi Kyle, I am a bit worried about the stringify because it will break escaping by dbi. I think it would be better using a list: There is an example for that in our coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL10:_Placeholders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 01:54:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 00:54:20 +0000 Subject: [Koha-bugs] [Bug 9858] Add button in "Search Engine Configuration" is not working. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9858 Samuel Crosby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scrosby000 at gmail.com --- Comment #1 from Samuel Crosby --- I found tried to reproduce your bug, the "Add" button seems to work, it just appears as plain text, but it can be clicked provided you enter the details for the new search index. Maybe this has been fixed since your bug report was created. I did find however that saving led to a YAML_DUMP_ERR_FILE_OUTPUT. Manually adding the search index into the indexes.yaml works, so it must be that it won't properly format it when adding to the file (it says that the file/directory does not exist, but it must be able to see it as the page would not display existing indexes if it couldn't see it). I'll continue try to figure out why it won't dump the index config into the indexes.yaml. I'll also make it so "Add" seems properly like a button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 02:57:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 01:57:15 +0000 Subject: [Koha-bugs] [Bug 9858] Add button in "Search Engine Configuration" is not working. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9858 --- Comment #2 from Samuel Crosby --- Nevermind, was a problem on my end. I created the directories through root, and mykoha-koha couldn't write to the indexes file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 03:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 02:23:28 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #4 from M. Tompsett --- Could I ask that the second when be changed? having two whens in the sentence makes it hard to read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 07:06:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 06:06:44 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from M. Tompsett --- Assuming cataloguer should become cataloger and canceled should become cancelled, I have no problem. I confirmed the variable is finesCalendar. Those changes being more of an American spelling, which I suspect en is supposed to be. I'm going to sign this off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 07:08:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 06:08:08 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #5 from Katrin Fischer --- Neither Jonathan nor I are native speakers - maybe just make a suggestion what would sound better to you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 07:25:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 06:25:44 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24161|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 24217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24217&action=edit [SIGNED OFF] Bug 11503 - Several typos This patch corrects several typos: Some reported in Bug 11503, others found during a systematic spell check of the help files. To test, examine the changes and confirm that the spelling changes are correct. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 07:33:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 06:33:29 +0000 Subject: [Koha-bugs] [Bug 11525] New: No way to turn off search word hilighting in staff UI by default Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11525 Bug ID: 11525 Summary: No way to turn off search word hilighting in staff UI by default Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There is no way to turn off the search word hilighting in the staff UI by default. The syspref OpacHighlightedWords doesn't seem to apply to the staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 07:39:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 06:39:18 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 --- Comment #6 from Bob Birchall --- (In reply to M. Tompsett from comment #3) > Take note of the one's I didn't put "Check" or "Okay" on. I did suggest > another edit as well. There were American vs. non-American English questions > in my mind. What is it supposed to be? US usage is 'catalogers'; usage in other english speaking countries is 'cataloguers' - should prolly be left with US spelling and changed in translations. 'Cancelled' seems to be used everywhere except in US, but even there it may not be consistent. I saw 'canceled' used by the NY Times and Seattle Post however Avis website has 'cancelled'. I saw other .com websites with 'cancelled' but maybe not all are US sites? 'finesCalendar' is a reference to the sys pref, not to the object of the sys pref, and so is correct, imo. I think a comma after 'For example' is not necessary, but would not be incorrect either. I hope this helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 07:39:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 06:39:23 +0000 Subject: [Koha-bugs] [Bug 11526] New: search word hilighting does not handle multi-word phrases well Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11526 Bug ID: 11526 Summary: search word hilighting does not handle multi-word phrases well Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org Do a multi-word phrase search. The results page will highlight all instances of the searched words, even when the "word" is simply a fragment of other word. for example 'kw,phr: a world' will highlight every 'a' in the search results, even in the middle of words. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 08:42:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 07:42:12 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 --- Comment #3 from Fridolin SOMERS --- (In reply to M. Tompsett from comment #2) > This eyeballs well, but step-by-step instructions would really help. There is a test plan into patch comment : Subject: [PATCH] Bug 11254 - breeding search must normalize ISBN When importing records, the ISBN is normalized and stored into database (see C4::Breeding::ImportBreeding). But when searching with ISBN into reservoir, it is not normalized (see C4::Breeding::BreedingSearch). So search does not match. This patch adds the normalisation to breeding search. Also replaces call private method _isbn_cleanup by GetNormalizedISBN, the correct public method. Also allows the breeding search on ISBN with hyphens. Test plan : - Import a record with ISBN 13 with hyphens. ie 978-2-8153-0357-6 - Go to cataloguing : cataloguing/addbooks.pl - Enter ISBN 13 with hyphens. ie 978-2-8153-0357-6 => the imported record is found - Enter ISBN 13 without hyphens. ie 9782815303576 => the imported record is found - Enter normalized ISBN. ie 2815303574 => the imported record is found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 08:53:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 07:53:28 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Fridolin SOMERS --- (In reply to Kyle M Hall from comment #6) > The choice to "unhighlight" search terms is not remembered when moving > between pages. If this is not an issue, please reset status to "Signed off". The "Unhighlight" link is a JavaScript function. I think it is used only some times to maybe have a clearer look at record datas. So in my opinion, this choice should not be remembered when moving to another result. Note that in results page, "unhighlight" choice is not remembered when moving to another results page. (but not in the "Browse results" but perhaps it's normal...).(In reply to Aur?lie Fichot from comment #5) > but not in the "Browse results" but perhaps it's normal... It is normal. It would be to much highlight in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 09:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 08:13:10 +0000 Subject: [Koha-bugs] [Bug 11527] New: Do not pick up MARC subfield codes for translation from XSLTs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11527 Bug ID: 11527 Summary: Do not pick up MARC subfield codes for translation from XSLTs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr For example, from intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl the following string is pick up for translation: abhfgknps and it shows up as msgid "abhfgknps" There is no sense in "translating" that, it's just confusing for translators. It really should not be picked up for translation in the first place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 09:47:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 08:47:12 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 09:47:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 08:47:17 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #90 from Jonathan Druart --- Created attachment 24218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24218&action=edit Bug 7825: Clarify the yes and no values The value of the pref should be '1' (for yes) or '0' (for no). The options could be kept as 'yes' and 'no': since the ImplicitTyping is set, yes/no would become '1/0'. But I think it is preferable not to use the yes/no value in order not to introduce a bug here if ImplicitTyping is unset later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 10:04:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 09:04:17 +0000 Subject: [Koha-bugs] [Bug 11524] Strange URL parameters in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- I reproduced the issue on 3.14.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 10:07:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 09:07:58 +0000 Subject: [Koha-bugs] [Bug 11524] Strange URL parameters in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524 --- Comment #2 from Katrin Fischer --- Ah ok, that would mean it's unrelated to the search history changes. Sorry for that then :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 10:11:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 09:11:42 +0000 Subject: [Koha-bugs] [Bug 11524] Strange URL parameters in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524 --- Comment #3 from Jonathan Druart --- Hum, in fact I am not sure. What is the problem? The biblionumber list or the repeated loggedinuser? or both :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 10:14:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 09:14:12 +0000 Subject: [Koha-bugs] [Bug 11524] Strange URL parameters in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524 --- Comment #4 from Katrin Fischer --- We keep telling users they can save every search request URL and it will still work when they use it later... this is some kind of monster URL. And to me it looks like it could cover up another problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 10:17:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 09:17:41 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 --- Comment #12 from Jonathan Druart --- (In reply to M. Tompsett from comment #11) > Why did you cut this test? The text is wrong, but the function call is > output_pref, which is still used. I really don't know! Maybe because there was the 'output_pref_due' in the unit test description and I read too quickly! I will submit a new followup to reintroduce it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 10:18:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 09:18:26 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 --- Comment #13 from Jonathan Druart --- Created attachment 24219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24219&action=edit Bug 11148: Previous patch delete usefull unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 11:07:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 10:07:02 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 charlene.criton at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charlene.criton at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 12:20:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 11:20:54 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22883|0 |1 is obsolete| | --- Comment #27 from Koha Team Lyon 3 --- Created attachment 24220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24220&action=edit Bug 8231 Systematic warning at check in if borrower is restricted very good question Jonathan : yes it was intended because I thought it was no more necesary but it is indeed. I put back the comparison. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 12:58:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 11:58:36 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23676|0 |1 is obsolete| | Attachment #23677|0 |1 is obsolete| | Attachment #23678|0 |1 is obsolete| | Attachment #23679|0 |1 is obsolete| | Attachment #23680|0 |1 is obsolete| | Attachment #23681|0 |1 is obsolete| | Attachment #23682|0 |1 is obsolete| | Attachment #23712|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart --- Created attachment 24221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24221&action=edit Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 12:58:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 11:58:47 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #43 from Jonathan Druart --- Created attachment 24222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24222&action=edit Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 12:58:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 11:58:52 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #44 from Jonathan Druart --- Created attachment 24223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24223&action=edit Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 12:58:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 11:58:57 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #45 from Jonathan Druart --- Created attachment 24224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24224&action=edit Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 12:59:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 11:59:03 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #46 from Jonathan Druart --- Created attachment 24225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24225&action=edit Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 12:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 11:59:08 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #47 from Jonathan Druart --- Created attachment 24226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24226&action=edit Bug 10807: Add an authority search history for the OPAC - bootstrap Patch for the bootstrap theme Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 13:00:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 12:00:11 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #48 from Jonathan Druart --- Last patches fix big conflict with bug 10952. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 13:06:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 12:06:48 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Passed QA, but I think it prudent to ask the question "Is there any reason we shouldn't allow orders from reverted batches?" I can't imagine a reason not to, but I'm not very imaginative ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 13:48:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 12:48:47 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|move or reorder 6xx and 7xx |Add ability to move and |fields |reorder fields in MARC | |editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 13:50:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 12:50:05 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23521|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 24227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24227&action=edit Bug 7882 - Add ability to move and reorder fields in MARC editor Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images Primary authorship by Elliott Davis. To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields Signed-off-by: Kyle M Hall Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 13:50:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 12:50:21 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 13:50:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 12:50:26 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23984|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall --- Created attachment 24228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24228&action=edit Bug 7882: Inputs should be editable disableSelection is deprecated and cause an issue on editing an input (input, select, textarea, etc.) see http://api.jqueryui.com/disableselection/ Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 14:14:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 13:14:35 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Yves Tomic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yves.tomic at u-psud.fr --- Comment #25 from Yves Tomic --- The purpose of this patch is to give the possibility to users to select some results while browsing the results pages without going to the detail page immediately. After having browsed the results, the users can display the selected results and navigate through them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 14:15:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 13:15:13 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #39 from Jonathan Druart --- Works as expected. My only concern is about the page loading time. Tested now: Before the patch: 1.12s (onload: 2.62s) 983ms (onload: 2.35s) 1.14s (onload: 2.5s) After the patch: 1.6s (onload: 2.69s) 1.87s (onload: 3.04s) 1.59s (onload: 2.78s) tested with firebug. Maybe we should add a new pref here in order not to increase load time for low/old computers. I let the RM takes the decision. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 15:20:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 14:20:14 +0000 Subject: [Koha-bugs] [Bug 11528] New: TrackClicks feature messes up proxied EBSCO e-books links? Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528 Bug ID: 11528 Summary: TrackClicks feature messes up proxied EBSCO e-books links? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Enabling the TrackClicks feature (track anonymously)seems to mess up links to EBSCO e-books. It was reported as a problem for a link to an e-book in the EBSCO Ebooks database. When you click on the link, it eventually resolves to the search interface of another one of our EBSCO databases (Alt HealthWatch). Could this be a proxy issue? The reporter is using EZProxy. It didn't seem to affect URLs connection to e-books for ebrary, Taylor & Francis, or Oxford. Would we have to do something special in the ezproxy config or the EBSCO stanza to allow the TrackClicks feature to work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 15:22:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 14:22:41 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #28 from Jonathan Druart --- Hi Olivier, The last patch has not been signed off, I switch the status back accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 15:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 14:26:04 +0000 Subject: [Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 15:46:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 14:46:58 +0000 Subject: [Koha-bugs] [Bug 11529] New: Add subtitle field to biblio table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Bug ID: 11529 Summary: Add subtitle field to biblio table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 5652 added the ability to see the record subtitle from the checkout and holds summaries, but does so by loading and parsing the entire MARC record. This seems to be causing somewhat significant slowdowns on some Koha installations and the speed could be greatly improved by just adding it to the biblio table the same way the title is stored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 16:14:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 15:14:07 +0000 Subject: [Koha-bugs] [Bug 11530] New: Recalculating a book's total issue count from items.issues or statistics-table with update_totalissues.pl ignores deleted_items. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11530 Bug ID: 11530 Summary: Recalculating a book's total issue count from items.issues or statistics-table with update_totalissues.pl ignores deleted_items. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org -------------------------- - REPLICATING THIS ISSUE - -------------------------- If we had a biblio, with 4 items, each being issued 50 times. Running the update_totalissues.pl in stats or items -mode would yield a biblioitems.totalissues value of 200. If we get rid of one of the books, and recalculate, the biblioitems.totalissues value will drop to 150! update_totalissues.pl works in incremental mode, but a recalculation will ignore deleted items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 16:28:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 15:28:36 +0000 Subject: [Koha-bugs] [Bug 8683] Acq: Clear button doesn't clear all item fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8683 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 17:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 16:28:31 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle field to biblio table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #1 from Heather Braum --- I want to add some additional information to this bug report -- the checkout and holds summaries now display the entire 245 MARC field -- not just subtitle (245$b). Information like the 245$h [gmd], 245$n (number of work) and 245$p part of work, also display -- which are very useful pieces of information, especially with graphic novels. But, loading this entire field in large systems does appear to cause page loading. I wonder if all 4 subfields need to be added to the biblio table, not just the 245$b subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:16:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:16:04 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon at cdalibrary.org --- Comment #35 from Christopher Brannon --- I cannot sign off on this patch. The following error comes up when I try to apply it to a sandbox: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 7376:

                  Something went wrong !

                  Applying: Bug 7376 - Transfer limits should be checked at check-in fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7376 - Transfer limits should be checked at check-in When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 7376 - Transfer limits should be checked at check-in 23168 - Bug 7376 - Transfer limits should be checked at check-in Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-7376---Transfer-limits-should-be-checked-at-ch-u0UdEh.patch . Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:34:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:34:09 +0000 Subject: [Koha-bugs] [Bug 11531] New: Cannot add new libraries to the transport cost if previously used. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11531 Bug ID: 11531 Summary: Cannot add new libraries to the transport cost if previously used. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library! To reproduce: 1) Enable the transport cost matrix 2) Set some transport cost values in the matrix 3) Save the matrix 4) Create a new library 5) View the transport cost matrix again 6) Note the uneditable fields for the new branch Cause: The transport cost matrix assumes either every library is in the transport_matrix table, or that no libraries are in it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:39:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:39:32 +0000 Subject: [Koha-bugs] [Bug 11531] Cannot add new libraries to the transport cost if previously used. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11531 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:42:03 +0000 Subject: [Koha-bugs] [Bug 11531] Cannot add new libraries to the transport cost if previously used. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11531 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:42:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:42:06 +0000 Subject: [Koha-bugs] [Bug 11531] Cannot add new libraries to the transport cost if previously used. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11531 --- Comment #1 from Kyle M Hall --- Created attachment 24229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24229&action=edit Bug 11531 - Cannot add new libraries to the transport cost if previously used. If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library! Test Plan: 1) Enable the transport cost matrix 2) Set some transport cost values in the matrix 3) Save the matrix 4) Create a new library 5) View the transport cost matrix again 6) Note the uneditable fields for the new branch 7) Apply this patch 8) View the transport cost matrix again 9) Note you can now edit the fields for the new branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:42:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:42:21 +0000 Subject: [Koha-bugs] [Bug 11531] Cannot add new libraries to the transport cost if previously used. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11531 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:45:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:45:18 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon --- Kyle, This issue appears to no longer apply. I tested on a sandbox against master, and with hidelostitems set to show, item shows as lost. If set to Don't show, record shows without any item showing. Please confirm test parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:53:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:53:48 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #29 from sandboxes at biblibre.com --- Patch tested with a sandbox, by JMBroust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:54:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:54:04 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 18:54:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 17:54:11 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 --- Comment #30 from sandboxes at biblibre.com --- Created attachment 24230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24230&action=edit Bug 8231 Systematic warning at check in if borrower is restricted Display, at check in, a reminder of an already existing suspension date even if the returned document is not late Signed-off-by: JMBroust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 19:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 18:27:43 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24105|0 |1 is obsolete| | --- Comment #4 from Magnus Enger --- Created attachment 24231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24231&action=edit [SIGNED-OFF] Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger Works as expected with and without -v. Man page looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 19:27:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 18:27:39 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 19:32:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 18:32:06 +0000 Subject: [Koha-bugs] [Bug 11532] New: Possible errors when selectbranchprinter.pl redirects to a POSTed script Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11532 Bug ID: 11532 Summary: Possible errors when selectbranchprinter.pl redirects to a POSTed script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1) Set library to a branch 2) Search for a record, edit the item, then save the item ( note the lack of url parameters now ). 3) From the item editor, select "Set library" by clicking the library name in the upper right corner 4) Select a new library, click submit 5) Note the error This is a fundamental issue with the way selectbranchprinter.pl redirects to the previous page. If the page that selectbranchprinter.pl is redirecting to was submitted via POST parameters, errors such is this one may occur. If it was via GET, everything will work just fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 19:45:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 18:45:54 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23528|0 |1 is obsolete| | --- Comment #34 from Jared Camins-Esakov --- Created attachment 24232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24232&action=edit Bug 10691: 5xx not properly linked by authid in authority search result list [Staff] This patch changes the URL and data used to show the 'see also' links on the Staff's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a entries with plain text (i.e. no linking) - Make sure zebra is running and changes got indexed. - In the staff interface search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id for linked authorities, and to an authority search result in the case of plain text entries. - Check that the authority search from the cataloguing interface still works as usual. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No errors Signed-off-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 19:46:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 18:46:03 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nengard at gmail.com --- Comment #7 from Katrin Fischer --- Some of the typos are in the help files - adding Nicole as she copies the texts from the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 19:46:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 18:46:28 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23529|0 |1 is obsolete| | --- Comment #35 from Jared Camins-Esakov --- Created attachment 24233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24233&action=edit Bug 10691: 5xx not properly linked by authid in authority search result list This patch changes the URL and data used to show the 'see also' links on the OPAC's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a without linking (i.e. plain text) - Make sure zebra is running and changes got indexed. - In the OPAC search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id in the case of linked authorities, and to an authority search in the case of plain text names. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No errors Signed-off-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 19:46:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 18:46:52 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 19:46:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 18:46:55 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23530|0 |1 is obsolete| | --- Comment #36 from Jared Camins-Esakov --- Created attachment 24234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24234&action=edit Bug 10691: (follow-up) restore behaviour for control field ($w) As noted by Jared, on the presence of 4XX$w or 5XX$w the display got broken by this refactoring. This patch restores de previous behaviour in that front. The OPAC themes get fixed too, and the Bootstrap one gets this fix too. Applied the fix that Galen proposed on comment #30 regarding Zeno's fix in bug 11174. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:18:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:18:59 +0000 Subject: [Koha-bugs] [Bug 11532] Possible errors when selectbranchprinter.pl redirects to a POSTed script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11532 --- Comment #1 from Kyle M Hall --- Created attachment 24235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24235&action=edit Bug 11532 - Possible start for a fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:20:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:20:33 +0000 Subject: [Koha-bugs] [Bug 11533] New: "use" QueryParser breaks authority search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Bug ID: 11533 Summary: "use" QueryParser breaks authority search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: - Set a dev install (i did it using DOM) and launch zebrasrv. - Verify that ~/koha-dev/koha-conf.xml points to an existent file in the 'queryparser_config' section. - Initialize the DB with the default data add a few authority records and reindex. - Search for the authority records (More > Authorities) => The results are there - Enable QP (sysprefs > "use" QueryParser - Do the same search => No results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:30:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:30:16 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 24236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24236&action=edit Bug 11533: (regression test) QP breaks authority search This patch duplicates the SearchAuthority tests, with QP enabled. Searching shouldn't be affected by QP. Instructions for manually reproducing this can be read in the first comment for the bug entry. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:30:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:30:29 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:30:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:30:35 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24217|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 24237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24237&action=edit [PASSED QA] Bug 11503 - Several typos This patch corrects several typos: Some reported in Bug 11503, others found during a systematic spell check of the help files. To test, examine the changes and confirm that the spelling changes are correct. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:31:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:31:28 +0000 Subject: [Koha-bugs] [Bug 11534] New: impossible to remove instructions on course reserve Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Bug ID: 11534 Summary: impossible to remove instructions on course reserve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Hi, On editing a course reserve, i can not remove an instructor. When i click on remove, nothing happens. Someone has already tested it? Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:31:43 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|impossible to remove |impossible to remove |instructions on course |instructors on course |reserve |reserve -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:32:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:32:07 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:39:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:39:06 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:39:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:39:10 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24204|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24238&action=edit [PASSED QA] Bug 11510: koha-translate usage message fixes The koha-translate's usage message has a couple of inconsistencies: '--all' should be '--available' and '--help' is missing from the usage examples. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, tested using instructions on http://wiki.koha-community.org/wiki/Testing_man_pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:58:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:58:23 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:58:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:58:26 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24205|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 24239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24239&action=edit [PASSED QA] Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Removed trailing " from: $scriptname [db usage mode] [options] instancename" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 20:59:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 19:59:45 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24239|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 24240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24240&action=edit [PASSED QA] Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Removed trailing " from: $scriptname [db usage mode] [options] instancename" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 21:03:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 20:03:25 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |katrin.fischer at bsz-bw.de --- Comment #91 from Katrin Fischer --- Thx Jonathan, back to testing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 21:27:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 20:27:29 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #92 from Katrin Fischer --- Hi Jonathan, I fixed the database update to be 15 and include the bug number, but now I am stuck: I can't get force to behave as described in the bootstrap theme. It behaves like 'no', not allowing me to set item level holds. I have checked in the database the value for the pref is really set to 'force' and have tried reloading the Javascript. Jonathan, can you please check and also include the other 2 changes if another patch is needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 21:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 20:38:46 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 21:38:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 20:38:50 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24231|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 24241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24241&action=edit [PASSED QA] Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger Works as expected with and without -v. Man page looks good. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 21:41:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 20:41:24 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- I think it makes sense to me not to allow it. Hm, can't really explain it beyond that reverted to indicate "unwanted" to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 21:44:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 20:44:19 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de --- Comment #49 from Katrin Fischer --- Starting to test... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 22:49:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 21:49:52 +0000 Subject: [Koha-bugs] [Bug 11535] New: Patron self-registration form does not sanitize its input Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Bug ID: 11535 Summary: Patron self-registration form does not sanitize its input Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The OPAC patron self-registration form does not sanitize its input, thereby allowing rude folks to inject unwanted JavaScript in the staff interface. This is annoying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:00:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:00:39 +0000 Subject: [Koha-bugs] [Bug 10318] show email on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Ketan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:01:04 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:01:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:01:20 +0000 Subject: [Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:01:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:01:43 +0000 Subject: [Koha-bugs] [Bug 10896] Add a --verbose option to koha-translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:02:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:02:04 +0000 Subject: [Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:02:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:02:19 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:02:37 +0000 Subject: [Koha-bugs] [Bug 11510] Typo in koha-translate usage message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:02:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:02:58 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:04:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:04:00 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:04:03 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 --- Comment #1 from Galen Charlton --- Created attachment 24242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24242&action=edit Bug 11535: sanitize input from patron self-registration form This patch adds the use of C4::Scrubber to the processing of input from the patron self-registration form, thereby closing off one avenue for Javascript injection. To test: [1] Use the OPAC self-registration form to enter a new patron, and set its address to something like: BAD [2] In the staff interface, bring up the new patron record. The address will show up in red, indicating a successful HTML injection. [3] Apply the patch and use self-registration to enter a new patron with a similar case of unwanted HTML coding. [4] Bring up the second patron in the staff interface. This time, the undesirable HTML tag should not be present. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:07:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:07:22 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|oleonard at myacpl.org |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:45:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:45:06 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 --- Comment #4 from David Cook --- (In reply to Jonathan Druart from comment #3) > Hi David, > Could you explain why you match the < and >? > The ^$ are not enough? Sure, Jonathan. It's because DataTables interprets all the data in a table cell as one long string. Sometimes, your string might be BRANCH. Other times, it might be BRANCH
                  BRANCH1
                  BRANCH2. If you were to only use ^$, 'BRANCH' would only match the first scenario. It wouldn't match the second, because the string ends with BRANCH2 - not BRANCH. However, we want it to match both scenarios, so we need to include < and >. In fact, there are 4 scenarios I see: 1) ^BRANCH$ (i.e. the string is only BRANCH) 2) ^BRANCH< (i.e. the string begins with BRANCH) 3) >BRANCH< (i.e. the string contains BRANCH in the middle somewhere) 4) >BRANCH$ (i.e. the string ends with BRANCH) Does that answer your question? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:48:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:48:03 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #6) > David, > Don't you think it is useless to display the information if not renewal is > possible? Honestly, I don't have a strong opinion either way. I was just trying to stay consistent with current behaviour. I'm more than happy for Nicole to open a bug to change current behaviour in the OPAC (and the staff client as well presuming this gets in). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:48:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:48:03 +0000 Subject: [Koha-bugs] [Bug 11536] New: patron self registration fails when PatronSelfRegistrationDefaultCategory is set to nonexistent borrower category code Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11536 Bug ID: 11536 Summary: patron self registration fails when PatronSelfRegistrationDefaultCategory is set to nonexistent borrower category code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org To replicate: Turn on PatronSelfRegistration set PatronSelfRegistrationDefaultCategory to a category code that doesn't exist. On the sample data, I used A. Try to register a borrower through the OPAC - everything will look like it worked, however the borrower will not be assigned a user.name - they cannot log in. Check in the staff client - the borrower was not created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:51:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:51:37 +0000 Subject: [Koha-bugs] [Bug 11537] New: Increasing test coverage for C4::Log Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Bug ID: 11537 Summary: Increasing test coverage for C4::Log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: manuelimel at gmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:59:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:59:15 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dhorsman at xtra.co.nz --- Comment #1 from AlexHorsman --- Created attachment 24243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24243&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 13 23:59:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 22:59:43 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:02:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:02:43 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24243|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 24244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24244&action=edit bug 11537: Increasing test coverage for C4::Log To test: 1. run prove t/Log.t Notice 1 test is run 2. apply patch 3. run prove t/Log.t Notice 3 tests are run Signed-off-by: Liz Rea 3 tests are in fact run. Thanks for the patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:04:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:04:18 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24243|1 |0 is obsolete| | CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:04:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:04:41 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24244|0 |1 is obsolete| | --- Comment #3 from Liz Rea --- Comment on attachment 24244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24244 bug 11537: Increasing test coverage for C4::Log Removing, as signoff has to be outside catalyst. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:12:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:12:30 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:12:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:12:33 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24243|0 |1 is obsolete| | --- Comment #4 from David Cook --- Created attachment 24245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24245&action=edit bug 11537: Increasing test coverage for C4::Log To test: 1. run prove t/Log.t Notice 1 test is run 2. apply patch 3. run prove t/Log.t Notice 3 tests are run Signed-off-by: David Cook Works as described. I think there might be a typo in "Testing git log status". Should this read "Testing get log status"? (Noticed while looking at the code/running perl t/Log.t.) In any case, thanks for the patch. Looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:16:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:16:26 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24245|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 24246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24246&action=edit bug 11537: Increasing test coverage for C4::Log To test: 1. run prove t/Log.t Notice 1 test is run 2. apply patch 3. run prove t/Log.t Notice 3 tests are run Signed-off-by: David Cook Works as described. I think there might be a typo in "Testing git log status". Should this read "Testing get log status"? (Noticed while looking at the code/running perl t/Log.t.) In any case, thanks for the patch. Looks good! Signed-off-by: Chris Cormack Fixed typo, thanks David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:17:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:17:59 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:18:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:18:03 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24242|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 24247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24247&action=edit Bug 11535: sanitize input from patron self-registration form This patch adds the use of C4::Scrubber to the processing of input from the patron self-registration form, thereby closing off one avenue for Javascript injection. To test: [1] Use the OPAC self-registration form to enter a new patron, and set its address to something like: BAD [2] In the staff interface, bring up the new patron record. The address will show up in red, indicating a successful HTML injection. [3] Apply the patch and use self-registration to enter a new patron with a similar case of unwanted HTML coding. [4] Bring up the second patron in the staff interface. This time, the undesirable HTML tag should not be present. Signed-off-by: Galen Charlton Signed-off-by: Liz Rea Tags are not present on testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 00:42:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jan 2014 23:42:49 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #40 from Galen Charlton --- (In reply to Bernardo Gonzalez Kriegel from comment #25) > Works as described, but still could not expand or collapse fields. This is still a problem -- ExpandField() cataloging.js, and possibly other routines, are expecting that subfields are contained in a
                  , not
                5. , and would need to be updated. Another thing that gets broken by the patch is the ability to client on the little triangle icons next to each subfield to move them up or down. That should either be made to work, or it should be removed (on account that the subfields become sortable with this patch). I'm failing the patch for those reasons, but they won't be difficult to deal with. There's a more serious issue, however, which isn't caused by this patch but which would become more obvious with it -- if you open the record again in the editor, field order isn't maintained. For example, if you construct your record so that subject headings are in the following order: 650 $aElizabethan theatre 600 $aShakespeare, William then open it up again in the editor, the 600 will be displayed before the 650, even though the 650 field is stored first in the record. This has the potential to be seriously confusing to users, and I feel that a patch that allows sorting of the fields in a user-specified order needs to be accompanied by work that makes the editor display existing fields in the order that they appear in the record. The increase in the time (as measured by Jonathan) it takes to render the editor is unfortunate, but IMO does not quite rise to the level that calls for a new syspref. Now if Bernardo's experience (36 seconds!) were the norm, that would be unacceptably slow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:13:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:13:50 +0000 Subject: [Koha-bugs] [Bug 11538] New: add span to internet facets Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11538 Bug ID: 11538 Summary: add span to internet facets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: francescalamoore at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com the label for Libraries in the intranet is not easily css selectable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:14:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:14:07 +0000 Subject: [Koha-bugs] [Bug 11539] New: C4::Barcodes::PrinterConfig does not appear to be being used anywhere Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 Bug ID: 11539 Summary: C4::Barcodes::PrinterConfig does not appear to be being used anywhere Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: thomas.houlker at hibs.school.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:14:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:14:13 +0000 Subject: [Koha-bugs] [Bug 11540] New: Increasing test coverage for C4::Charset Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Bug ID: 11540 Summary: Increasing test coverage for C4::Charset Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: emmaheath.student at wegc.school.nz QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:14:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:14:14 +0000 Subject: [Koha-bugs] [Bug 11541] New: Increasing test coverage for C4::Installer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Bug ID: 11541 Summary: Increasing test coverage for C4::Installer Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: aleishaamohia at hotmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:14:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:14:28 +0000 Subject: [Koha-bugs] [Bug 11542] New: Incressing test coverage for C4::Print Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Bug ID: 11542 Summary: Incressing test coverage for C4::Print Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: daniel.barker.nz at gmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:14:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:14:36 +0000 Subject: [Koha-bugs] [Bug 11543] New: Increasing test coverage for C4::Category Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Bug ID: 11543 Summary: Increasing test coverage for C4::Category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: romanwilton at gmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:14:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:14:39 +0000 Subject: [Koha-bugs] [Bug 11544] New: increasing test coverage for C4::Installer_PerlModule Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 Bug ID: 11544 Summary: increasing test coverage for C4::Installer_PerlModule Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: dhorsman at xtra.co.nz QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:16:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:16:15 +0000 Subject: [Koha-bugs] [Bug 11545] New: Increasing test coverage for C4::Languages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Bug ID: 11545 Summary: Increasing test coverage for C4::Languages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: manuelimel at gmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:19:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:19:20 +0000 Subject: [Koha-bugs] [Bug 11538] add span to internet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11538 --- Comment #1 from Francesca --- Created attachment 24248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24248&action=edit propose patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:19:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:19:39 +0000 Subject: [Koha-bugs] [Bug 11538] add span to internet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11538 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:12 +0000 Subject: [Koha-bugs] [Bug 11542] Incressing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 --- Comment #1 from Daniel Barker --- Created attachment 24249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24249&action=edit Propsed Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:12 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 --- Comment #1 from Emma Heath --- Created attachment 24251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24251&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:12 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #1 from Aleisha Amohia --- Created attachment 24250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24250&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:18 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 --- Comment #1 from Roman Amor --- Created attachment 24252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24252&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:29 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:31 +0000 Subject: [Koha-bugs] [Bug 11542] Incressing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Daniel Barker changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:32 +0000 Subject: [Koha-bugs] [Bug 11544] increasing test coverage for C4::Installer_PerlModule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 --- Comment #1 from AlexHorsman --- Created attachment 24253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24253&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:33 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:36 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Emma Heath changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:38 +0000 Subject: [Koha-bugs] [Bug 11545] Increasing test coverage for C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 --- Comment #1 from Merllissia Manueli --- Created attachment 24254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24254&action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:45 +0000 Subject: [Koha-bugs] [Bug 11545] Increasing test coverage for C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Merllissia Manueli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:27:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:27:52 +0000 Subject: [Koha-bugs] [Bug 11544] increasing test coverage for C4::Installer_PerlModule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:29:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:29:13 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 --- Comment #1 from Tom Houlker --- Created attachment 24255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24255&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:29:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:29:27 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 Tom Houlker changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:44:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:44:31 +0000 Subject: [Koha-bugs] [Bug 11546] New: facets labels are not css selectable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Bug ID: 11546 Summary: facets labels are not css selectable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: francescalamoore at gmail.com QA Contact: testopia at bugs.koha-community.org add span tags to h5 headings to make them easily selectable in css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:47:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:47:59 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 --- Comment #1 from Francesca --- Created attachment 24256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24256&action=edit propose patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 02:48:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 01:48:12 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:27:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:27:22 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Daniel Barker changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24252|0 |1 is obsolete| | --- Comment #2 from Daniel Barker --- Created attachment 24257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24257&action=edit Bug 11543: Increasing test coverage for Category.pm To test: 1. Run prove t/Coverage.t 2. Apply patch 3. Run prove t/Coverage.t - Notice 2 tests were run Signed-off-by: daniel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:27:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:27:48 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Daniel Barker changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24257|0 |1 is obsolete| | --- Comment #3 from Daniel Barker --- Created attachment 24258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24258&action=edit Bug 11543: Increasing test coverage for Category.pm To test: 1. Run prove t/Coverage.t 2. Apply patch 3. Run prove t/Coverage.t - Notice 2 tests were run Signed-off-by: daniel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:28:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:28:58 +0000 Subject: [Koha-bugs] [Bug 11542] Incressing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24249|0 |1 is obsolete| | --- Comment #2 from Roman Amor --- Created attachment 24259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24259&action=edit bug 11542: Increase test coverage for Print.pm to test 1. run prove t/Print.t 2. apply patch 3. run prove t/Print.t Notice more tests are done Signed-off-by: Roman Amor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:29:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:29:39 +0000 Subject: [Koha-bugs] [Bug 11545] Increasing test coverage for C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24254|0 |1 is obsolete| | --- Comment #2 from AlexHorsman --- Created attachment 24260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24260&action=edit bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:34:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:34:55 +0000 Subject: [Koha-bugs] [Bug 9629] Replace YUI button on patron category administration pages with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9629 --- Comment #5 from Aleisha Amohia --- Created attachment 24261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24261&action=edit Bug 9629 - Replace YUI button on patron category administration page with Bootstrap This patch converts the toolbar used by the patrons [category] administration to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view the patrons [category] administration page and confirm that the button looks correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described, looks correct and works correctly. Signed-off-by: Katrin Fischer Works nicely, no problems found. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:36:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:36:05 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 --- Comment #2 from Aleisha Amohia --- Created attachment 24262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24262&action=edit bug 11546 facets labels are not css selectable To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:36:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:36:31 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:37:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:37:01 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Emma Heath changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24251|0 |1 is obsolete| | --- Comment #2 from Emma Heath --- Created attachment 24263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24263&action=edit Bug:11540 increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:37:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:37:31 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #2 from Francesca --- Created attachment 24264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24264&action=edit Bug 11541: Increasing coverage of Installer.pm To test 1. Run prove t/Installer.t 2. Apply patch 3. Run prove t/Installer.t Notice more tests are run Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:38:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:38:30 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |francescalamoore at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:42:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:42:36 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 --- Comment #2 from Emma Heath --- Created attachment 24265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24265&action=edit bug 11539: removing 2 unused files Signed-off-by: Emma Heath -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:42:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:42:55 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Tom Houlker changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24263|0 |1 is obsolete| | --- Comment #3 from Tom Houlker --- Created attachment 24266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24266&action=edit Bug:11540 increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:45:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:45:22 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:46:42 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:50:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:50:51 +0000 Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Samuel Crosby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |scrosby000 at gmail.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 03:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 02:51:09 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Samuel Crosby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |scrosby000 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 04:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 03:50:20 +0000 Subject: [Koha-bugs] [Bug 11547] New: have an alert at checkout to say 'you already read this' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11547 Bug ID: 11547 Summary: have an alert at checkout to say 'you already read this' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you're keeping the patron's reading history it would be great to have an alert at check out that says 'this patron already read this' do they really want to check it out. Or some such thing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 04:52:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 03:52:55 +0000 Subject: [Koha-bugs] [Bug 11548] New: notice when card about to expire Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11548 Bug ID: 11548 Summary: notice when card about to expire Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice to have a notice emailed when the patron's card is about to expire. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 05:55:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 04:55:01 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Marcel, why do you think that these patches are necessary? I suppose, in the case of the OPAC, it might make sense to return a 404 instead of a 500, but when is an opac-showmarc.pl query string going to be malformed? In the case of the staff client, I got a 404 both before/after trying the patch, so I'm not sure that it's necessary. I imagine that there must already be checking higher up in showmarc.pl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:18:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:18:03 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:18:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:18:08 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:30:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:30:07 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- The patch works, but I'm not sure that this improves the current behaviour. I suppose the "Logout" button was added so that people could end their session here? I suppose they could just use the "Previous page" button and then logout from there (or continue doing what they were doing). In any case, "Log in" should probably be "Login" to match the other button. Also, we might consider something more explanatory like: "Error: You do not have permission to access this page. Login as a different user or return to the previous page." Maybe even moving the "Previous page" button down to the bottom left corner to improve the aesthetic of the page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:35:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:35:56 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #3 from David Cook --- I ran into a problem with the test plan. t/Installer.t doesn't exist prior to this patch. Is this patch introducing a new test, or is this supposed to be an improvement of t/Installer_pm.t? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:43:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:43:29 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #4 from Chris Cormack --- Ah yes, this new patch tests C4::Installer t/Installer_pm.t on the other hand tests C4::Installer::PerlModules So yep, it is a new test file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:51:59 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:52:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:52:03 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24247|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24267&action=edit [PASSED QA] Bug 11535: sanitize input from patron self-registration form This patch adds the use of C4::Scrubber to the processing of input from the patron self-registration form, thereby closing off one avenue for Javascript injection. To test: [1] Use the OPAC self-registration form to enter a new patron, and set its address to something like: BAD [2] In the staff interface, bring up the new patron record. The address will show up in red, indicating a successful HTML injection. [3] Apply the patch and use self-registration to enter a new patron with a similar case of unwanted HTML coding. [4] Bring up the second patron in the staff interface. This time, the undesirable HTML tag should not be present. Signed-off-by: Galen Charlton Signed-off-by: Liz Rea Tags are not present on testing. Signed-off-by: Katrin Fischer Confirmed bug and that the patch fixes it. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:55:11 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:55:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:55:15 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24246|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 24268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24268&action=edit [PASSED QA] Bug 11537: Increasing test coverage for C4::Log To test: 1. run prove t/Log.t Notice 1 test is run 2. apply patch 3. run prove t/Log.t Notice 3 tests are run Signed-off-by: David Cook Works as described. I think there might be a typo in "Testing git log status". Should this read "Testing get log status"? (Noticed while looking at the code/running perl t/Log.t.) In any case, thanks for the patch. Looks good! Signed-off-by: Chris Cormack Fixed typo, thanks David Signed-off-by: Katrin Fischer Works as described: 1..3 ok 1 - use C4::Log; ok 2 - Testing GetLogStatus ok 3 - Testing hash is non empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 06:56:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 05:56:08 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Welcome Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 07:09:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 06:09:07 +0000 Subject: [Koha-bugs] [Bug 10812] Warn when a user had already checked out a title in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 11547 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 07:09:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 06:09:07 +0000 Subject: [Koha-bugs] [Bug 11547] have an alert at checkout to say 'you already read this' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10812 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 07:10:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 06:10:49 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24256|0 |1 is obsolete| | Attachment #24262|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 24269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24269&action=edit bug 11546 facets labels are not css selectable To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 07:13:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 06:13:03 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #5 from David Cook --- (In reply to Chris Cormack from comment #4) > Ah yes, this new patch tests > > C4::Installer > > t/Installer_pm.t on the other hand tests > C4::Installer::PerlModules > > So yep, it is a new test file. Cool. In that case, don't we need to add a call to this test elsewhere in Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 07:13:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 06:13:29 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 --- Comment #10 from paxed --- I didn't see the "Van der Griten" fixed in there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 07:19:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 06:19:00 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #6 from Chris Cormack --- Nope, if its in the t/ dir, it gets run (by jenkins and by make test) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 07:53:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 06:53:45 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- Hi Marjorie, I was able to do this in Master and the instructor was removed correctly. What browser and OS are you using? Cheers, Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:03:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:03:27 +0000 Subject: [Koha-bugs] [Bug 9629] Replace YUI button on patron category administration pages with Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9629 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24261|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:33:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:33:31 +0000 Subject: [Koha-bugs] [Bug 11252] rebuild_zebra.pl should not have --munge-config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:35:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:35:44 +0000 Subject: [Koha-bugs] [Bug 10453] updating child to adult loses password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:41:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:41:44 +0000 Subject: [Koha-bugs] [Bug 9858] Add button in "Search Engine Configuration" is not working. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9858 --- Comment #3 from Hend --- Currently , i could add a new search index through the staff client. But as you had said it's not added to indexes.yaml. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:48:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:48:38 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #93 from Jonathan Druart --- (In reply to Katrin Fischer from comment #92) > Hi Jonathan, > I fixed the database update to be 15 and include the bug number, but now I > am stuck: I can't get force to behave as described in the bootstrap theme. > It behaves like 'no', not allowing me to set item level holds. > I have checked in the database the value for the pref is really set to > 'force' and have tried reloading the Javascript. Katrin, I am very sorry! I was sure to test all cases but it seems I missed something. Given that it is a specific case and the code is different from the prog theme, I am sure I have tested it! Anyway, it could not work with this code... I will provide a followup. > Jonathan, can you please check and also include the other 2 changes if > another patch is needed? Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:49:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:49:20 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:49:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:49:27 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24218|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart --- Created attachment 24270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24270&action=edit Bug 7825: Clarify the yes and no values The value of the pref should be '1' (for yes) or '0' (for no). The options could be kept as 'yes' and 'no': since the ImplicitTyping is set, yes/no would become '1/0'. But I think it is preferable not to use the yes/no value in order not to introduce a bug here if ImplicitTyping is unset later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:49:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:49:35 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #95 from Jonathan Druart --- Created attachment 24271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24271&action=edit Bug 7825: FIX the force value for the bootstrap theme If the pref was set to 'force', the item selection was not shown. .copiesrow should be hidden before showing specific #copiesrow_ID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 09:59:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 08:59:52 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 charlene.criton at univ-lyon2.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charlene.criton at univ-lyon2. | |fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 10:21:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 09:21:31 +0000 Subject: [Koha-bugs] [Bug 11523] Customized xslt display and framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11523 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |INVALID --- Comment #1 from Liz Rea --- Hi Eugene, This isn't really the forum for your question, so I am closing this bug. The answer to your question is that XSLTs are not currently per framework. With this knowledge, you may want to open a new bug requesting that feature. Hope this helps, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 10:24:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 09:24:10 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #5 from Jonathan Druart --- (In reply to David Cook from comment #4) > Does that answer your question? Yes, thanks David. Looking at the tt code, I seen that the cell contain 'reserveloo.holdingbranch', and I supposed it was a simple branch. But in fact, this field is built with a concat in the sql query. I should have read the test plan entirely... So the patch works great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 10:25:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 09:25:41 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24048|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 24272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24272&action=edit Bug 11502 - Branch filter in "Holds To Pull" is too fuzzy This patch uses regex checking via the DataTables fnFilter API method to make the branch filter more precise on the "Holds to Pull" page. The ability to use regex is built into DataTables so this just adds the actual expression. _TEST PLAN_ Before applying: 1) Add library (branches) with codes of NM, NMH, and NB 2) Add items (that can be placed on hold) at all these branches 3) Place a hold on an item that is only available at NM 4) Place a hold on an item that is only available at NMH 5) Place a hold on an item that is only available at NM and NB 6) Go to "Holds to Pull" in the Circulation module 7) Filter by these three different values 8) Note that filtering by "NM" will incorrectly bring up all three holds, while "NMH" and "NB" will only pull up one (like they should). Apply the patch. 9) Shift+refresh the page so that your Javascript refreshes 10) Repeat step 7 (filtering by the different branch values) 11) Note that filtering by "NM" will now only bring up the hold for "NM" and the hold for "NM" and "NB", while the others still only bring up one hold. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 10:32:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 09:32:23 +0000 Subject: [Koha-bugs] [Bug 11524] Strange URL parameters in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #5 from Liz Rea --- mine was slightly different, it came out like this: http://opac.lizpc/cgi-bin/koha/opac-search.pl?idx=kw&q=science&sort_by=title_az&addto=Add+to...&biblionumber=73&biblionumber=92&biblionumber=4489&biblionumber=5006&biblionumber=5254&biblionumber=5531&biblionumber=5532&biblionumber=5545&biblionumber=7162&biblionumber=7798&biblionumber=12628&biblionumber=13388&biblionumber=17131&biblionumber=17515&biblionumber=17517&biblionumber=18837&biblionumber=18866&biblionumber=18926&biblionumber=22039&biblionumber=22453&newtag22453= Replicated the same way on current master, changed sort from relevance to Title A-Z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 10:41:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 09:41:23 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- Flagged for Catalyst Academy, if worse comes to worse. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 11:10:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 10:10:54 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #31 from Jonathan Druart --- It works as before the rebase, no regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 11:11:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 10:11:13 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24230|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 24273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24273&action=edit Bug 8231 Systematic warning at check in if borrower is restricted Display, at check in, a reminder of an already existing suspension date even if the returned document is not late Test plan : 1) Apply the patch 2) Go to a borrower checkout page and checkout some documents with different passed duedate using "Specify due date" function. Checkout out one with the default duedate. 3) Check in the document with the bigger delay : You will get the message : 'X is now restricted until ...' 4) Check in one of the document with a smaller delay : You 'll get a different message : 'Reminder : Patron was earlier restricted untill...'. 5) Check in the document which is not late : You 'll get the same message as the previous one Signed-off-by: JMBroust Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 11:11:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 10:11:42 +0000 Subject: [Koha-bugs] [Bug 11521] Patron Cardnumber scanning causing patron record to be saved. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11521 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- I confirm this bug on current master, was possibly introduced with bug 9783. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 11:26:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 10:26:11 +0000 Subject: [Koha-bugs] [Bug 6779] Don't allow patron renewal x days before expiry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:03:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:03:53 +0000 Subject: [Koha-bugs] [Bug 11549] New: After transferring an order, receive and cancel the receipt will delete the order Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Bug ID: 11549 Summary: After transferring an order, receive and cancel the receipt will delete the order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 5349 introduces the ability to transfer an order from a basket to another. After a transfer, if an order is received and the receipt is canceled, the order will be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:04:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:04:06 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:19:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:19:26 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:19:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:19:28 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #1 from Jonathan Druart --- Created attachment 24274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24274&action=edit Bug 11549: Add regression test test plan: prove t/db_dependent/Acquisition/TransferOrder.t should fail before the patch and success after applying it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:19:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:19:33 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #2 from Jonathan Druart --- Created attachment 24275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24275&action=edit Bug 11549: FIX receive and cancel the receipt after a transfer. To reproduce the issue: - transfer an order from a basket to another. Note the previous ordernumber (X) and the new one (Y). - receive the order - cancel the receipt - verify the order has been deleted: select count(*) from aqorders where ordernumber=Y; select * from aqorders_transfers where ordernumber_from = X; The value for ordernumber_to is null. To test this patch: - apply this patch - transfer an order from a basket to another - receive the order - cancel the receipt - verify the order still exist in the basket where the transfer has been done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:19:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:19:37 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #3 from Jonathan Druart --- Created attachment 24276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24276&action=edit Bug 11549: Interpolate variables into SQL statements should not be allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:21:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:21:34 +0000 Subject: [Koha-bugs] [Bug 11550] New: GetOrder returns something even if the order does not exist Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11550 Bug ID: 11550 Summary: GetOrder returns something even if the order does not exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org I did not find somewhere it can cause a problem, but the GetOrder routine always returns a hashref with a key 'orderdate'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:25:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:25:25 +0000 Subject: [Koha-bugs] [Bug 11550] GetOrder returns something even if the order does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:25:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:25:28 +0000 Subject: [Koha-bugs] [Bug 11550] GetOrder returns something even if the order does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11550 --- Comment #1 from Jonathan Druart --- Created attachment 24277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24277&action=edit Bug 11550: GetOrder always returns a non empty hashref If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 12:37:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 11:37:44 +0000 Subject: [Koha-bugs] [Bug 11550] GetOrder returns something even if the order does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 13:59:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 12:59:01 +0000 Subject: [Koha-bugs] [Bug 11551] New: Allow to search on ordernumber in histsearch.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Bug ID: 11551 Summary: Allow to search on ordernumber in histsearch.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The orders search does not allow to search on the ordernumber. On the way, the parent ordernumber could be requested too in order to display the 'children' for a given order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 13:59:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 12:59:12 +0000 Subject: [Koha-bugs] [Bug 11551] Allow to search on ordernumber in histsearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:01:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:01:57 +0000 Subject: [Koha-bugs] [Bug 11551] Allow to search on ordernumber in histsearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #1 from Jonathan Druart --- Created attachment 24278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24278&action=edit Bug 11507: Allow to search on parent ordernumber in histsearch.pl It is now possible to search on the ordernumber on the order search page. Also search on parent_ordernumber is possible. Like that, you are allow to search children for a given ordernumber. Test plan: 1/ create a basket and 1 order with at least 2 items. 2/ receive partialy the order (receive only 1 item). 3/ note that a new ordernumber is created for item not received. 4/ go on the order search form and search for the original ordernumber without checking the new checkbox "Display children too." => only 1 order (the parent) is displayed. 5/ now check the checkbox and search again => the parent order is displayed but children too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:01:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:01:54 +0000 Subject: [Koha-bugs] [Bug 11551] Allow to search on ordernumber in histsearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:02:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:02:05 +0000 Subject: [Koha-bugs] [Bug 11551] Allow to search on ordernumber in histsearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #2 from Jonathan Druart --- Created attachment 24279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24279&action=edit Bug 11551: Add unit tests for GetHistory prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:03:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:03:05 +0000 Subject: [Koha-bugs] [Bug 11551] Allow to search on ordernumber in histsearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24278|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 24280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24280&action=edit Bug 11551: Allow to search on parent ordernumber in histsearch.pl It is now possible to search on the ordernumber on the order search page. Also search on parent_ordernumber is possible. Like that, you are allow to search children for a given ordernumber. Test plan: 1/ create a basket and 1 order with at least 2 items. 2/ receive partialy the order (receive only 1 item). 3/ note that a new ordernumber is created for item not received. 4/ go on the order search form and search for the original ordernumber without checking the new checkbox "Display children too." => only 1 order (the parent) is displayed. 5/ now check the checkbox and search again => the parent order is displayed but children too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:16:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:16:21 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #30 from Sophie MEYNIEUX --- This patch introduce a new bug in 3.8.x It uses C4::Members::GetBorrowerCategorycode that is introduced only in 3.10 with http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742 This patch should be reverted for 3.8.x version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:20:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:20:50 +0000 Subject: [Koha-bugs] [Bug 11552] New: After a transfer, allow to search on the original order line Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 Bug ID: 11552 Summary: After a transfer, allow to search on the original order line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org If an order is transferred from a basket to another, it should be possible to retrieve it with the original ordernumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:21:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:21:15 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #2 from marjorie barry-vila --- Hi Liz, I'm using firefox 26.0 and windows 7. I also tested on google chrome 31 et IE11 but it does not work. I tested also on http://intranet.bywatersolutions.com but it does the same, i can not remove instructors. An idea? Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:21:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:21:56 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11552 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:21:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:21:56 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11549 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:23:05 +0000 Subject: [Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- Have a look at bug 11549 and bug 11552, they should fix your issue. *** This bug has been marked as a duplicate of bug 11552 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:23:05 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Jonathan Druart --- *** Bug 11507 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:24:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:24:33 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:24:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:24:36 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 --- Comment #2 from Jonathan Druart --- Created attachment 24281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24281&action=edit Bug 11552; After a transfer, allow to search on the original order line If an order is transferred from a basket to another, it should be possible to retrieve it with the original ordernumber. Test plan: - transfer an order - note the original ordernumber and the new one - receive the order and, on the parcel page, try to find your order with the original ordernumber and the new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:47:08 +0000 Subject: [Koha-bugs] [Bug 11538] add span to internet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11538 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:47:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:47:11 +0000 Subject: [Koha-bugs] [Bug 11538] add span to internet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11538 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24248|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 24282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24282&action=edit [SIGNED-OFF] Bug 11538 make Libraries css selectable To test: 1. do a search in the intranet and see facets 2. inspect the Libraries facet and observe that it now has a span. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:52:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:52:51 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:53:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:53:19 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 14:53:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 13:53:21 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24237|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 24283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24283&action=edit Bug 11503 [Follow-up] Several typos There is still a typo left to fix which I didn't catch because I was doing a spell-check and didn't double-check the bug report: Van der Griten -> Van der Grinten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:00:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:00:12 +0000 Subject: [Koha-bugs] [Bug 11553] New: Balance exceeding noissuescharge should be more prominent when AllowFineOverride is enabled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11553 Bug ID: 11553 Summary: Balance exceeding noissuescharge should be more prominent when AllowFineOverride is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When AllowFineOverride is enabled, the librarian is not given a specific warning about the balance exceeding noissuescharge until he or she has scanned in an item. There should at the least a warning above the barcode field to let the librarian know right away the patron owes more than the amount set in noissuescharge. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:18:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:18:36 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Owen Leonard --- I like the idea that we might place focus on the input field if the page is being redisplayed after a barcode was entered. If we did might even add an "Add item" link to the page which lists existing shelves. I don't think this patch is the correct solution, and anyway it inadvertently adds a couple of patch files which we don't want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:18:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:18:42 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:33:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:33:16 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24237|1 |0 is obsolete| | --- Comment #12 from M. Tompsett --- Comment on attachment 24237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24237 [PASSED QA] Bug 11503 - Several typos This is the main patch which was already pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:34:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:34:36 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:34:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:34:40 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24283|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 24284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24284&action=edit [SIGNED OFF] Bug 11503 [Follow-up] Several typos There is still a typo left to fix which I didn't catch because I was doing a spell-check and didn't double-check the bug report: Van der Griten -> Van der Grinten Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:36:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:36:05 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #6 from Owen Leonard --- (In reply to David Cook from comment #5) > I suppose the "Logout" button was added so that people could end their > session here? Yeah I've always wondered what the workflow there was: "Ooops, I reached a page I can't access. Instead of logging in as a different user right now I'm going to log out completely and give up." > In any case, "Log in" should probably be "Login" to match the other button. Actually now that I look at it I think they should both be "Log in." "Login" should be used as a noun, "Log in" as a verb. > Also, we might consider something more explanatory like: > "Error: You do not have permission to access this page. > > Login as a different user or return to the previous page." > > Maybe even moving the "Previous page" button down to the bottom left corner > to improve the aesthetic of the page? I like these suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:37:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:37:24 +0000 Subject: [Koha-bugs] [Bug 11554] New: Capitalization fix in patron account on fines tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Bug ID: 11554 Summary: Capitalization fix in patron account on fines tab Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: h.meissner.82 at web.de Reporter: h.meissner.82 at web.de QA Contact: testopia at bugs.koha-community.org Home > Patrons > Pay fines: Change "Total Due" to "Total due" Home > Patrons > Manual Invoice: Change "Manual Invoice" to "Manual invoice" Home > Patrons > Manual credit: Change "Credit Type" to "Credit type" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:40:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:40:42 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:45:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:45:08 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #3 from Owen Leonard --- I can reproduce this bug in FF26 on Win7, also in FF26 and Chromium on Ubuntu. Nothing happens when I click the "remove" link but no JavaScript errors are reported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:45:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:45:15 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:45:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:45:39 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24266|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 24285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24285&action=edit [SIGNED-OFF] Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:45:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:45:57 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 24286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24286&action=edit Bug 11540: (folowup) add a couple of tests more This patch makes sure all scenarios are covered for SetUTF8Flag. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 15:53:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 14:53:18 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #4 from Owen Leonard --- A card number is passed to RemoveInstructor() in order to remove a the
                  containing the relevant field: $( '#borrower_' + cardnumber ).remove(); ...but the
                  looks like this:
                  ...and the number passed to the function is this: 11960 Could the JavaScript engine in Liz's browser have different type handling? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:33:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:33:22 +0000 Subject: [Koha-bugs] [Bug 11538] add span to internet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- I create a patch for that in bug 11312. *** This bug has been marked as a duplicate of bug 11312 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:33:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:33:22 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francescalamoore at gmail.com --- Comment #4 from Jonathan Druart --- *** Bug 11538 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:33:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:33:49 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #5 from Jonathan Druart --- *** Bug 11546 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:33:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:33:49 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- I create a patch for that in bug 11312. *** This bug has been marked as a duplicate of bug 11312 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:35:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:35:42 +0000 Subject: [Koha-bugs] [Bug 11555] New: Make "All" one of the default options for datatables Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Bug ID: 11555 Summary: Make "All" one of the default options for datatables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There are many instances where librarians would like to have the ability to see all the rows in a datatable at one. It seems prudent to make this a default option for datatables, rather than change it on a case by case basis. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:36:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:36:28 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23191|0 |1 is obsolete| | Attachment #23192|0 |1 is obsolete| | Attachment #23193|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 24287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24287&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:36:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:36:37 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #7 from Jonathan Druart --- Created attachment 24288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24288&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:36:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:36:43 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #8 from Jonathan Druart --- Created attachment 24289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24289&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:41:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:41:58 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:42:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:42:05 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 --- Comment #1 from Kyle M Hall --- Created attachment 24290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24290&action=edit Bug 11555 - Make "All" one of the default options for datatables There are many instances where librarians would like to have the ability to see all the rows in a datatable at one. It seems prudent to make this a default option for datatables, rather than change it on a case by case basis. Test Plan: 1) View the circulation history for a patron 2) Note you can select to view 10, 25, 50, or 100 entries 3) Apply this patch 4) Reload the circulation history page for a patron 5) Note the new "All" option 6) Verify the "All" option shows all the rows at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 16:42:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 15:42:14 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:10:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:10:35 +0000 Subject: [Koha-bugs] [Bug 11523] Make framework code available to stylesheets to allow for more customized display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |katrin.fischer at bsz-bw.de Resolution|INVALID |--- Summary|Customized xslt display and |Make framework code |framework |available to stylesheets to | |allow for more customized | |display --- Comment #2 from Katrin Fischer --- I think we could try to clarify the title and description a bit and keep this bug open. I am trying to :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:21:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:21:18 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Kyle M Hall --- I'm still seeing this error in master: http://screencast.com/t/gvuoF4pyebF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:35:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:35:21 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:35:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:35:53 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton --- Pushed to master. Congratulations on having your first patch accepted into Koha, Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:36:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:36:11 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:36:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:36:54 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #5 from Christopher Brannon --- My bad. I don't know why it worked before. I just tested it again and now I am getting the same results. Thanks for confirming. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:45:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:45:12 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:45:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:45:25 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:45:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:45:31 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 24291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24291&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:45:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:45:58 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from M. Tompsett --- Using a copy of our old data on a git install, I found we had a three copies of a book '101 Stupid Things Trainers Do To Sabotage Success' (1 biblio, 3 items), and one was lost. I deleted the two we had, and kept the lost one. I went to the system preferences and toggled it between looking at the OPAC search for 'stupid things' which was unique, and I have it showing and not showing the 1 item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:48:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:48:53 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #9 from Christopher Brannon --- (In reply to M. Tompsett from comment #8) > Using a copy of our old data on a git install, I found we had a three copies > of a book '101 Stupid Things Trainers Do To Sabotage Success' (1 biblio, 3 > items), and one was lost. I deleted the two we had, and kept the lost one. I > went to the system preferences and toggled it between looking at the OPAC > search for 'stupid things' which was unique, and I have it showing and not > showing the 1 item. I had a similar result the first time, which prompted my request for confirmation above. But when I went to try it today, it gave the error. I have tested twice now, and the patch does work. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 17:58:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 16:58:33 +0000 Subject: [Koha-bugs] [Bug 11556] New: Send any notice to any patron (or all patrons) on demand Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 Bug ID: 11556 Summary: Send any notice to any patron (or all patrons) on demand Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: flanagan at ucar.edu QA Contact: testopia at bugs.koha-community.org Sometimes I'm looking at a patron record with too many overdues and I wish I could send an Overdue Notice right then and there, without waiting for the next autosend email to go out to him/her. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:03:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:03:17 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:13:12 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #10 from M. Tompsett --- Oops... I got a cross-problem with the OpacHiddenItems. I'm doing further retesting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:30:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:30:12 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #11 from M. Tompsett --- TEST PLAN --------- home cataloguing new from z39.50 purple search import (Abbott & Costello cartoons.) 9 set the default type. save > save and edit items add a lost item rather than wait, I reindexed it immediately: $ ./misc/migration_tools/rebuild_zebra.pl -b -a -z -v made sure system preference for hidelostitems was Show search Staff, found search OPAC, found toggle the systempreference search staff, found search OPAC, 404 apply patch search OPAC, no results -- facets still show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:34:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:34:40 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #12 from M. Tompsett --- Created attachment 24292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24292&action=edit Hide facets if there are no results to show (because they are hidden) I believe that the second patch from 11489 will make this patch better. Notice how facets still displayed. This patch will remove the facets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:35:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:35:40 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24292|0 |1 is patch| | --- Comment #13 from M. Tompsett --- Comment on attachment 24292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24292 Hide facets if there are no results to show (because they are hidden) It is a patch, but it isn't mine. It is from Jonathan Druart . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:38:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:38:20 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:38:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:38:23 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24102|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 24293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24293&action=edit [SIGNED OFF] Bug 11432: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:39:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:39:36 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 --- Comment #5 from Chris Cormack --- Francesca, Perhaps you could test Jonathan's patch on bug 11312, and sign off on that. Which I'm sure Jonathan would appreciate. And we will find a new bug to get your first patch into Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:40:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:40:29 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24292|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 24294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24294&action=edit [SIGNED OFF] Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:46:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:46:28 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10584 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:46:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:46:28 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11489 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:46:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:46:39 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11432 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:46:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:46:39 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10584 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:49:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:49:32 +0000 Subject: [Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from M. Tompsett --- I moved the second patch to bug 11489, and I believe it solves the issues from bug 10584 as well. *** This bug has been marked as a duplicate of bug 11489 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:49:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:49:32 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #15 from M. Tompsett --- *** Bug 11432 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 18:52:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 17:52:13 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 19:01:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 18:01:50 +0000 Subject: [Koha-bugs] [Bug 11276] Sprite icons not in right spot on translated templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11276 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 20:30:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 19:30:35 +0000 Subject: [Koha-bugs] [Bug 11537] Increasing test coverage for C4::Log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 --- Comment #9 from Galen Charlton --- Upon Jenkins (the continuous integration service) complaining, I've also pushed a follow-up that mocks the calls to C4::Context::preference() that C4::Log::GetLogStatus() makes, which will allow the test to pass without requiring that a Koha database is present and pointed to by a valid Koha configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 20:35:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 19:35:33 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 20:35:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 19:35:36 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24284|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 24295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24295&action=edit [PASSED QA] Bug 11503 [Follow-up] Several typos There is still a typo left to fix which I didn't catch because I was doing a spell-check and didn't double-check the bug report: Van der Griten -> Van der Grinten Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 20:55:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 19:55:28 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24255|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 20:57:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 19:57:04 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 20:57:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 19:57:08 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24265|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 24296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24296&action=edit bug 11539: removing 2 unused files Signed-off-by: Emma Heath Signed-off-by: Kyle M Hall No instances of PrinterConfig found in the codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 20:58:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 19:58:44 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24250|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:03:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:03:55 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24264|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 24297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24297&action=edit Bug 11541: Increasing coverage of Installer.pm To test 1. Run prove t/Installer.t 2. Apply patch 3. Run prove t/Installer.t Notice more tests are run Signed-off-by: Francesca Moore Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:05:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:05:41 +0000 Subject: [Koha-bugs] [Bug 11545] Increasing test coverage for C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:05:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:05:46 +0000 Subject: [Koha-bugs] [Bug 11545] Increasing test coverage for C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24260|0 |1 is obsolete| | --- Comment #3 from Magnus Enger --- Created attachment 24298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24298&action=edit [SIGNED-OFF] bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h Signed-off-by: Magnus Enger Adds another passing test. I took th liberty of moving the test plan from the subject to the commit message. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:06:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:06:17 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #8 from Kyle M Hall --- Created attachment 24299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24299&action=edit Bug 11541 [Followup] - Increasing test coverage for C4::Installer Tests succeed, but cause many warnings: prove t/Installer.t t/Installer.t .. 1/9 "my" variable $self masks earlier declaration in same scope at t/Installer.t line 19. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 20. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 21. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 22. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 23. Odd number of elements in anonymous hash at t/Installer.t line 17. Use of uninitialized value within @ARGV in anonymous hash ({}) at t/Installer.t line 17. The patch remedies that. Test Plan: 1) Apply first patch on this bug 2) Run "prove t/Installer.t" 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) Note the warnings are gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:06:43 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24297|Bug 11541: Increasing |[SIGNED-OFF] Bug 11541: description|coverage of Installer.pm |Increasing coverage of | |Installer.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:09:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:09:39 +0000 Subject: [Koha-bugs] [Bug 11542] Incressing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:09:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:09:42 +0000 Subject: [Koha-bugs] [Bug 11542] Incressing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24259|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 24300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24300&action=edit bug 11542: Increase test coverage for Print.pm to test 1. run prove t/Print.t 2. apply patch 3. run prove t/Print.t Notice more tests are done Signed-off-by: Roman Amor Signed-off-by: Kyle M Hall UT passes, also passes koha-qa.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:10:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:10:05 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hi Jonathan, I think I found a small problem: if you don't save, but go back with cancel, because you picked the wrong order, the filters are still lost. Could this be fixd as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:11:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:11:44 +0000 Subject: [Koha-bugs] [Bug 11542] Increasing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|chris at bigballofwax.co.nz |romanwilton at gmail.com Summary|Incressing test coverage |Increasing test coverage |for C4::Print |for C4::Print -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:12:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:12:30 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Galen Charlton --- I've pushed the follow-up to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:13:10 +0000 Subject: [Koha-bugs] [Bug 11544] increasing test coverage for C4::Installer_PerlModule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:13:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:13:14 +0000 Subject: [Koha-bugs] [Bug 11544] increasing test coverage for C4::Installer_PerlModule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24253|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 24301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24301&action=edit bug 11544: increasing test coverage for Installer_PerlModules.pm To test 1. run prove t/Installer_PerlModules.t 2. apply patch 3. run prove t/Installer_PerlModules.t notices more tests are run Signed-off-by: Magnus Enger Adds another passing test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:17:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:17:31 +0000 Subject: [Koha-bugs] [Bug 11542] Increasing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:17:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:17:35 +0000 Subject: [Koha-bugs] [Bug 11542] Increasing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24300|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 24302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24302&action=edit [PASSED QA] bug 11542: Increase test coverage for Print.pm to test 1. run prove t/Print.t 2. apply patch 3. run prove t/Print.t Notice more tests are done Signed-off-by: Roman Amor Signed-off-by: Kyle M Hall UT passes, also passes koha-qa.pl Signed-off-by: Katrin Fischer Tests pass :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:18:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:18:26 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Emma Heath changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24285|0 |1 is obsolete| | --- Comment #6 from Emma Heath --- Created attachment 24304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24304&action=edit Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:18:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:18:24 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24297|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Created attachment 24303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24303&action=edit Bug 11541: Increasing coverage of Installer.pm To test 1. Run prove t/Installer.t 2. Apply patch 3. Run prove t/Installer.t Notice more tests are run Signed-off-by: Francesca Moore Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:19:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:19:09 +0000 Subject: [Koha-bugs] [Bug 11544] increasing test coverage for C4::Installer_PerlModule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24301|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 24305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24305&action=edit bug 11544: increasing test coverage for Installer_PerlModules.pm To test 1. run prove t/Installer_PerlModules.t 2. apply patch 3. run prove t/Installer_PerlModules.t notices more tests are run Signed-off-by: Magnus Enger Adds another passing test. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:19:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:19:16 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:19:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:19:19 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24299|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 24306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24306&action=edit Bug 11541 [Followup] - Increasing test coverage for C4::Installer Tests succeed, but cause many warnings: prove t/Installer.t t/Installer.t .. 1/9 "my" variable $self masks earlier declaration in same scope at t/Installer.t line 19. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 20. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 21. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 22. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 23. Odd number of elements in anonymous hash at t/Installer.t line 17. Use of uninitialized value within @ARGV in anonymous hash ({}) at t/Installer.t line 17. The patch remedies that. Test Plan: 1) Apply first patch on this bug 2) Run "prove t/Installer.t" 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) Note the warnings are gone Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:19:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:19:33 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Emma Heath changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24286|0 |1 is obsolete| | --- Comment #7 from Emma Heath --- Created attachment 24307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24307&action=edit Bug 11540: (folowup) add a couple of tests more This patch makes sure all scenarios are covered for SetUTF8Flag. Regards To+ Signed-off-by: Emma Heath -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:19:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:19:30 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Emma Heath changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:24:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:24:04 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- This patch assumes that at least one patron category exists, but does not create or mock any. I believe the test would fail without any categories in the database. The best course of action would be to create a dummy category before running the test, then roll back the insert at the end of the test. In addition, it would be good practice to move this file to t/db_dependent since this test is indeed dependent on the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:25:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:25:26 +0000 Subject: [Koha-bugs] [Bug 11545] Increasing test coverage for C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:25:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:25:30 +0000 Subject: [Koha-bugs] [Bug 11545] Increasing test coverage for C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24298|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 24308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24308&action=edit [PASSED QA] bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h Signed-off-by: Magnus Enger Adds another passing test. I took th liberty of moving the test plan from the subject to the commit message. :-) Signed-off-by: Katrin Fischer Tests pass :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:26:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:26:59 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24287|0 |1 is obsolete| | --- Comment #9 from Francesca --- Created attachment 24309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24309&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:29:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:29:56 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24309|0 |1 is obsolete| | --- Comment #10 from Francesca --- Created attachment 24310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24310&action=edit signed-off Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:31:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:31:03 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24288|0 |1 is obsolete| | --- Comment #11 from Francesca --- Created attachment 24311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24311&action=edit signed-off Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:32:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:32:17 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24289|0 |1 is obsolete| | --- Comment #12 from Francesca --- Created attachment 24312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24312&action=edit signed-off Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:35:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:35:16 +0000 Subject: [Koha-bugs] [Bug 9212] Parentheses in subject headings break search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 --- Comment #13 from Kyle M Hall --- *** Bug 8783 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:35:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:35:16 +0000 Subject: [Koha-bugs] [Bug 8783] Parentheses not escaped properly in queries when using XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8783 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 9212 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:36:40 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:36:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:36:44 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24296|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 24313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24313&action=edit [PASSED QA] bug 11539: removing 2 unused files Signed-off-by: Emma Heath Signed-off-by: Kyle M Hall No instances of PrinterConfig found in the codebase Signed-off-by: Katrin Fischer Couldn't find any reference to those files in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:51:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:51:11 +0000 Subject: [Koha-bugs] [Bug 11545] Increasing test coverage for C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master, along with a follow-up that moves Languages.t to t/db_dependent. That signals that the test script requires that there be a Koha database to connect to, as is required in order to test getAllLanguages(). Congratulations on having your first patch accepted into Koha, Merllissia! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:51:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:51:47 +0000 Subject: [Koha-bugs] [Bug 11542] Increasing test coverage for C4::Print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11542 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Congratulations on having your first patch accepted into Koha, Daniel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 21:56:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 20:56:53 +0000 Subject: [Koha-bugs] [Bug 11539] C4::Barcodes::PrinterConfig does not appear to be being used anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11539 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Congratulations on having your first patch accepted into Koha, Tom! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:01:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:01:56 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:01:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:01:59 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24303|0 |1 is obsolete| | Attachment #24306|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 24314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24314&action=edit [PASSED QA] Bug 11541: Increasing coverage of Installer.pm To test 1. Run prove t/Installer.t 2. Apply patch 3. Run prove t/Installer.t Notice more tests are run Signed-off-by: Francesca Moore Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer All tests pass :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:02:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:02:13 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #12 from Katrin Fischer --- Created attachment 24315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24315&action=edit [PASSED QA] Bug 11541 [Followup] - Increasing test coverage for C4::Installer Tests succeed, but cause many warnings: prove t/Installer.t t/Installer.t .. 1/9 "my" variable $self masks earlier declaration in same scope at t/Installer.t line 19. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 20. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 21. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 22. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 23. Odd number of elements in anonymous hash at t/Installer.t line 17. Use of uninitialized value within @ARGV in anonymous hash ({}) at t/Installer.t line 17. The patch remedies that. Test Plan: 1) Apply first patch on this bug 2) Run "prove t/Installer.t" 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) Note the warnings are gone Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:04:40 +0000 Subject: [Koha-bugs] [Bug 11324] "Delete All Items" fails except on "Normal Tab" 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11324 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dhorsman at xtra.co.nz --- Comment #1 from AlexHorsman --- we have tested and we can successfully re-create this issue, we will work on a fix now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:12:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:12:32 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:12:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:12:35 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24304|0 |1 is obsolete| | Attachment #24307|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 24316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24316&action=edit [PASSED QA] Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Tests pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:12:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:12:56 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 --- Comment #9 from Katrin Fischer --- Created attachment 24317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24317&action=edit [PASSED QA] Bug 11540: (folowup) add a couple of tests more This patch makes sure all scenarios are covered for SetUTF8Flag. Regards To+ Signed-off-by: Emma Heath Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:14:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:14:28 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Meg changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janegcpl at gmail.com --- Comment #16 from Meg --- I have tested the patch and it works! OPAC hides lost/missing items and no longer displays 404 error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:16:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:16:10 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:16:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:16:13 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24258|0 |1 is obsolete| | --- Comment #5 from Roman Amor --- Created attachment 24318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24318&action=edit Bug 11543: Increasing test coverage for Category.pm To test: 1. Run prove t/db_dependent/Category.t 2. Apply patch 3. Run prove t/db_dependent/Category.t - Notice 2 tests were run Signed-off-by: daniel Made the requested changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:23:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:23:21 +0000 Subject: [Koha-bugs] [Bug 11544] increasing test coverage for C4::Installer_PerlModule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:23:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:23:24 +0000 Subject: [Koha-bugs] [Bug 11544] increasing test coverage for C4::Installer_PerlModule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24305|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 24319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24319&action=edit [PASSED QA] bug 11544: increasing test coverage for Installer_PerlModules.pm To test 1. run prove t/Installer_PerlModules.t 2. apply patch 3. run prove t/Installer_PerlModules.t notices more tests are run Signed-off-by: Magnus Enger Adds another passing test. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Tests pass :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:26:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:26:10 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 --- Comment #1 from Emma Heath --- Created attachment 24320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24320&action=edit Bug 11488 Untranslatable warning "Are you sure you want to write off ..." Test plan 1. create some fines 2. to attempt to write off all the fines 3. make sure the messege still displays -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 22:29:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 21:29:45 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Emma Heath changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |emmaheath.student at wegc.scho | |ol.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:14:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:14:59 +0000 Subject: [Koha-bugs] [Bug 11544] increasing test coverage for C4::Installer_PerlModule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11544 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:15:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:15:38 +0000 Subject: [Koha-bugs] [Bug 11540] Increasing test coverage for C4::Charset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Congratulations on having your first patch accepted to Koha, Emma! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:21:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:21:10 +0000 Subject: [Koha-bugs] [Bug 11231] notes should be reservenotes in pendingreserves.pl and reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francescalamoore at gmail.com --- Comment #1 from Francesca --- the notes don't display on the page(pull reserves) at all, so you are currently asking for data that isn't displayed. Also, when I changed "notes," for "reserves.reservenote", the page didn't display the reserve at all. I'm just a bit confused over why this fix needs to be done now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:24:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:24:37 +0000 Subject: [Koha-bugs] [Bug 11541] Increasing test coverage for C4::Installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton --- Pushed to master, along with a couple follow-ups to put the test in the db_dependent subdirectory and test the values of the fields in the $installer object more precisely. Congratulations on having your first patch accepted into Koha, Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:36:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:36:51 +0000 Subject: [Koha-bugs] [Bug 5002] No error message if category code already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Corey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agent.075 at gmail.com --- Comment #4 from Corey --- Could not resolve the issue, but someone may be able to investigate further and add an IF & ELSE statement in the categorie.pl document (/koha/admin) In the categorie.pl document, there is an ADD_VALIDATE section that is called by the ADD_FORM, which the rule should be positioned. The IF & ELSE statement should be that IF a category code that the administrator wants to add already exists, then an error message should arise; ELSE, proceed with the new category code. That should help quite a bit, I gave up... :( -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:37:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:37:48 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 Daniel Barker changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:37:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:37:51 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 --- Comment #3 from Daniel Barker --- Created attachment 24321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24321&action=edit Bug:8168 Fixing header of non csv files 1. make some overdues books 2. run the overdue notices script without the -csv 3. check emails notice csv header is in the email 4. apply the patch 5. run the overdue notice again 6. check email notice csv header is absent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:40:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:40:03 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 --- Comment #1 from Aleisha Amohia --- Created attachment 24322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24322&action=edit Bug 11487: Untranslatable tooltip "Dates of birth should be entered in the format ..." Test plan: 1. Test that tooltip still shows 2. We couldn't test the translations so please can someone else test it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:40:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:40:50 +0000 Subject: [Koha-bugs] [Bug 11324] "Delete All Items" fails except on "Normal Tab" 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11324 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:40:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:40:53 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:40:52 +0000 Subject: [Koha-bugs] [Bug 11324] "Delete All Items" fails except on "Normal Tab" 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11324 --- Comment #2 from AlexHorsman --- Created attachment 24323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24323&action=edit bug 11324: delete all only works on 'normal' tab test plan 1. find a book with some items 2. in the marc tab click edit and choose delete all 3. notice it doesn't work 4. apply the patch 5. refresh page 6. try delete all again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:41:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:41:02 +0000 Subject: [Koha-bugs] [Bug 11231] notes should be reservenotes in pendingreserves.pl and reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 --- Comment #2 from Galen Charlton --- Carrying over a comment I made in IRC, the holds to pull report originally took the note field from the bib record. However, that's not necessarily all that useful, and the notes were removed from the template by commit a13c0db. However, that commit did not remove the notes column from the SQL. One reasonable resolution would be to simply remove 'notes' from the SQL query. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:41:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:41:37 +0000 Subject: [Koha-bugs] [Bug 11231] notes should be reservenotes in pendingreserves.pl and reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 --- Comment #3 from Galen Charlton --- Ditto for the hold ratios report; at present I don't see any particular reason why either bib-level or request-level notes need to be displayed in that report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:51:59 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 --- Comment #3 from Francesca --- Created attachment 24324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24324&action=edit bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 14 23:53:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 22:53:23 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |francescalamoore at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 00:06:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 23:06:48 +0000 Subject: [Koha-bugs] [Bug 11231] notes should be reservenotes in pendingreserves.pl and reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 00:06:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 23:06:50 +0000 Subject: [Koha-bugs] [Bug 11231] notes should be reservenotes in pendingreserves.pl and reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 --- Comment #4 from Francesca --- Created attachment 24325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24325&action=edit 11231 notes should be reservenotes notes have been removed as they were not displaying in the first place. 1.apply patch 2.verify that both reports work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 00:19:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jan 2014 23:19:10 +0000 Subject: [Koha-bugs] [Bug 11241] DHXD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11241 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 01:29:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 00:29:44 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 01:45:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 00:45:51 +0000 Subject: [Koha-bugs] [Bug 11447] Hide existing item(s) that is/are linked to the bibliographic record when adding a new item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11447 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- I agree with this on the condition that it's an ajax type hide/show and not a systempreference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 01:51:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 00:51:40 +0000 Subject: [Koha-bugs] [Bug 11014] Slip Print Problem in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11014 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- Agreed, this is problematic, I wish chrome did things in a standard way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:28:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:28:24 +0000 Subject: [Koha-bugs] [Bug 11557] New: Collector bug for Academy bootstrap3 upgrading work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 Bug ID: 11557 Summary: Collector bug for Academy bootstrap3 upgrading work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org This bug is a collector for the work done by Catalyst Academy on upgrading the OPAC to bootstrap 3. These patches are probably incomplete, but possibly a starting point for the work to be done upgrading the OPAC to bootstrap3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:29:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:29:05 +0000 Subject: [Koha-bugs] [Bug 11558] New: Collector bug for Academy bootstrap3 upgrading work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Bug ID: 11558 Summary: Collector bug for Academy bootstrap3 upgrading work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org This bug is a collector for the work done by Catalyst Academy on upgrading the OPAC to bootstrap 3. These patches are probably incomplete, but possibly a starting point for the work to be done upgrading the OPAC to bootstrap3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:53:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:53:53 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #1 from Merllissia Manueli --- Created attachment 24326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24326&action=edit Upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:55:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:55:54 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Merllissia Manueli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24326|0 |1 is obsolete| | --- Comment #2 from Merllissia Manueli --- Created attachment 24327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24327&action=edit Upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:57:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:57:06 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #3 from AlexHorsman --- Created attachment 24328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24328&action=edit upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:57:45 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #4 from Roman Amor --- Created attachment 24329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24329&action=edit Upgraded Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:57:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:57:46 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24328|0 |1 is obsolete| | --- Comment #5 from AlexHorsman --- Created attachment 24330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24330&action=edit upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:58:04 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24329|0 |1 is obsolete| | --- Comment #6 from Roman Amor --- Created attachment 24331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24331&action=edit Upgraded Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:58:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:58:07 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24330|0 |1 is obsolete| | --- Comment #7 from AlexHorsman --- Created attachment 24332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24332&action=edit upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:58:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:58:18 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24331|0 |1 is obsolete| | --- Comment #8 from Roman Amor --- Created attachment 24333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24333&action=edit Upgraded Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:58:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:58:25 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #9 from AlexHorsman --- Created attachment 24334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24334&action=edit updating bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:58:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:58:34 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24333|0 |1 is obsolete| | --- Comment #10 from Roman Amor --- Created attachment 24335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24335&action=edit Upgraded Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:58:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:58:40 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #11 from AlexHorsman --- Created attachment 24336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24336&action=edit upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:58:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:58:48 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #12 from Roman Amor --- Created attachment 24337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24337&action=edit Upgrading Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:58:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:58:58 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #13 from AlexHorsman --- Created attachment 24338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24338&action=edit upgrading from bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:59:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:59:04 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #14 from Roman Amor --- Created attachment 24339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24339&action=edit Upgraded Bootstrap form 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:59:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:59:15 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #15 from Merllissia Manueli --- Created attachment 24340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24340&action=edit Upgrading boostrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:59:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:59:26 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24335|0 |1 is obsolete| | --- Comment #16 from Roman Amor --- Created attachment 24341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24341&action=edit Upgraded Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 03:59:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 02:59:33 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Merllissia Manueli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24327|0 |1 is obsolete| | --- Comment #17 from Merllissia Manueli --- Created attachment 24342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24342&action=edit Upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:00:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:00:14 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Merllissia Manueli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24342|0 |1 is obsolete| | --- Comment #18 from Merllissia Manueli --- Created attachment 24343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24343&action=edit Upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:00:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:00:29 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Merllissia Manueli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24343|0 |1 is obsolete| | --- Comment #19 from Merllissia Manueli --- Created attachment 24344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24344&action=edit Upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:01:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:01:21 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Summary|Collector bug for Academy |Collector bug for Academy |bootstrap3 upgrading work |bootstrap3 upgrading work | |- Not ready (not even | |close) for use yet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:01:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:01:54 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #20 from Emma Heath --- Created attachment 24345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24345&action=edit Upgrading opac-results.tt to bootstrap 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:02:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:02:14 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24338|0 |1 is obsolete| | --- Comment #21 from AlexHorsman --- Created attachment 24346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24346&action=edit upgrading from bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:02:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:02:15 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #22 from Emma Heath --- Created attachment 24347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24347&action=edit Upgrading opac-readingrecord.tt to bootstrap 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:03:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:03:01 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #23 from Emma Heath --- Created attachment 24348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24348&action=edit upgrading opac-reserve.tt to bootstrap3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:03:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:03:18 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #24 from Emma Heath --- Created attachment 24349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24349&action=edit upgrading opac-advsearch.tt to bootstrap3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:03:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:03:32 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #25 from Emma Heath --- Created attachment 24350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24350&action=edit Upgrading opac-advsearch.tt to Bootstrap 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:04:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:04:13 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #26 from Emma Heath --- Created attachment 24351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24351&action=edit Upgrading opac-memberentry.tt to bootstrap 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:07:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:07:00 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #27 from Aleisha Amohia --- Created attachment 24352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24352&action=edit Upgrading opac-overdrive-search.tt from Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:07:16 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24326|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:07:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:07:17 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #28 from Aleisha Amohia --- Created attachment 24353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24353&action=edit Upgrading opac-registration-confirmation.tt from Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:07:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:07:34 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #29 from Aleisha Amohia --- Created attachment 24354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24354&action=edit Upgrading opac-registration-email-sent.tt from Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:07:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:07:57 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24327|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:08:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:08:00 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #30 from Aleisha Amohia --- Created attachment 24355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24355&action=edit Upgrading opac-registration-invalid.tt from Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:08:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:08:09 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24328|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:08:20 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24329|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:08:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:08:31 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24330|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:09:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:09:11 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #31 from Aleisha Amohia --- Created attachment 24356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24356&action=edit Upgrading opac-shelves.tt from Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:09:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:09:30 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #32 from Aleisha Amohia --- Created attachment 24357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24357&action=edit Upgrading opac-downloadcart.tt from Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:09:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:09:46 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #33 from Aleisha Amohia --- Created attachment 24358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24358&action=edit Upgrading opac-imageviewer.tt from Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:10:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:10:04 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #34 from Aleisha Amohia --- Created attachment 24359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24359&action=edit Upgrading opac-detail.tt from Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:11:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:11:13 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24331|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:11:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:11:25 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24333|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:11:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:11:31 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24335|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:11:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:11:47 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24338|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:12:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:12:54 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #35 from Merllissia Manueli --- Created attachment 24360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24360&action=edit Upgrading booststrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:13:10 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Merllissia Manueli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24326|0 |1 is obsolete| | Attachment #24327|0 |1 is obsolete| | Attachment #24344|0 |1 is obsolete| | --- Comment #36 from Merllissia Manueli --- Created attachment 24361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24361&action=edit Upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:14:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:14:30 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #37 from Tom Houlker --- Created attachment 24362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24362&action=edit upgrading ilsdi.tt from bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:14:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:14:41 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Daniel Barker changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24328|0 |1 is obsolete| | Attachment #24330|0 |1 is obsolete| | Attachment #24332|0 |1 is obsolete| | --- Comment #38 from Daniel Barker --- Created attachment 24363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24363&action=edit upgrading bootstrap from 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:14:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:14:55 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #39 from Tom Houlker --- Created attachment 24364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24364&action=edit upgraded opac-search-history.tt to bootstrap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:15:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:15:08 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #40 from Daniel Barker --- Created attachment 24365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24365&action=edit Upgrade bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:15:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:15:17 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #41 from Tom Houlker --- Created attachment 24366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24366&action=edit upgraded opac-browser.tt to botstrap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:15:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:15:22 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #42 from Daniel Barker --- Created attachment 24367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24367&action=edit Upgrading bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:15:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:15:32 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #43 from Tom Houlker --- Created attachment 24368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24368&action=edit Upgraded opac-authoritiessearchresultlist.tt to bootstrap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:15:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:15:42 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #44 from Daniel Barker --- Created attachment 24369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24369&action=edit messeging.tt bootstrap 3.0 upgrading from 2.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:15:51 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #45 from Tom Houlker --- Created attachment 24370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24370&action=edit upgraded opac-authorities-home.tt to bootstrap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:16:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:16:09 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24342|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:16:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:16:13 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #46 from Tom Houlker --- Created attachment 24371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24371&action=edit upgraded opac/ISBDdetail.tt to bootsrtap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:16:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:16:24 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24343|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:17:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:17:01 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #47 from Tom Houlker --- Created attachment 24372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24372&action=edit upgraded modules/opac-account.tt to bootstrap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:17:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:17:24 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #48 from Tom Houlker --- Created attachment 24373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24373&action=edit chenged '.radio.inline' in module/opac-memberentry.tt and module/opac-reserve.tt to '-inline' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:18:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:18:44 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24329|0 |1 is obsolete| | Attachment #24331|0 |1 is obsolete| | Attachment #24333|0 |1 is obsolete| | Attachment #24335|0 |1 is obsolete| | Attachment #24341|0 |1 is obsolete| | --- Comment #49 from Roman Amor --- Created attachment 24374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24374&action=edit Upgraded Bootstrap 2.3 to 3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:20:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:20:24 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24326|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:20:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:20:52 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #50 from Francesca --- Created attachment 24375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24375&action=edit changing html from bootstrap v2.3 to bootstrap v3.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:20:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:20:56 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24327|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:22:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:22:21 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24328|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:22:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:22:34 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24329|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:22:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:22:53 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24330|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:23:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:23:52 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24331|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 04:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 03:31:39 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24333|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 05:23:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 04:23:54 +0000 Subject: [Koha-bugs] [Bug 11520] Invoice isn't really an invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520 --- Comment #2 from Nicole C. Engard --- RRP matches with the data you enter when you receive in the 'replacement price field' There is no field labeled with 'recommended retail price' in the ordering or receipt process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 06:13:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 05:13:00 +0000 Subject: [Koha-bugs] [Bug 11557] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Liz Rea --- *** This bug has been marked as a duplicate of bug 11558 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 06:13:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 05:13:00 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #51 from Liz Rea --- *** Bug 11557 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 07:31:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 06:31:27 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24335|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 07:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 06:31:35 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #6 from M. Tompsett --- How about? Upon receiving items, update their subfields if they were created when placing an order (e.g. 995\$o=5) Does this make sense? I intentionally chose "placing an order", because that is the value in the drop down for the AcqCreateItem system preference above it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 07:31:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 06:31:41 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24341|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 07:33:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 06:33:03 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24332|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 07:33:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 06:33:11 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24344|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 07:44:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 06:44:37 +0000 Subject: [Koha-bugs] [Bug 11559] New: Professional cataloger's interface Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Bug ID: 11559 Summary: Professional cataloger's interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The current MARC record editor interface works well for novice catalogers, but is a little bit too unwieldy for professionals. Some goals of a new interface: * Textual, much more compact record view * Free entry of tags and subfields * As much as possible, keyboard-driven UI * Direct import and export of USMARC/MARCXML records * Integrated Z39.50 searching Some other future goals, which may not be included in this patch series, include: * Authority linking/editing, with autocomplete * Batch record import/export While consolidated patches will be coming soon, the code is available at http://github.com/pianohacker/koha, branch pci. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 07:45:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 06:45:10 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 09:22:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 08:22:07 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #6 from Katrin Fischer --- Hi Kyle, about the workflow: yes, I can see that happen. I remember during one of my jobs in a public library we would put in a note if we noticed loose pages on checkout so it could go into repair after return and the patron would not be blamed for the damage. But... as you point out correctly, overwriting holds restrictions from staff is basically not working right. The holds don't get triggered. So I think I agree that we can't block this patch because of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 09:52:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 08:52:12 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22868|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 24376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24376&action=edit Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived Test plan: Update the updatedb entry and search the pref in the admin module. The explanation should have been updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:03:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:03:53 +0000 Subject: [Koha-bugs] [Bug 11546] facets labels are not css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 --- Comment #6 from Jonathan Druart --- It seems I was a little bit boorish, I am sorry Francesca. I did not see it was your first patch! I will add it on bug 11312. Thank you for your signoff! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:04:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:04:49 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24310|0 |1 is obsolete| | Attachment #24311|0 |1 is obsolete| | Attachment #24312|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 24377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24377&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:04:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:04:54 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #14 from Jonathan Druart --- Created attachment 24378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24378&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:04:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:04:59 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #15 from Jonathan Druart --- Created attachment 24379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24379&action=edit Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:05:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:05:09 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #16 from Jonathan Druart --- Created attachment 24380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24380&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:07:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:07:14 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #17 from Jonathan Druart --- I added the Francesca's patch (from bug 11546). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:16:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:16:25 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 --- Comment #8 from Jonathan Druart --- Created attachment 24381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24381&action=edit Bug 11141: Filters should be kept if the receive is cancelled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:17:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:17:19 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Hi Jonathan, > I think I found a small problem: if you don't save, but go back with cancel, > because you picked the wrong order, the filters are still lost. Could this > be fixd as well? Hi Katrin, Yes it seems consistent. Last patch fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 10:30:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 09:30:51 +0000 Subject: [Koha-bugs] [Bug 11560] New: Untranslatable "Close" in greybox popup Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11560 Bug ID: 11560 Summary: Untranslatable "Close" in greybox popup Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In staff client, clicking on the "MARC preview" when viewing title details pops up a javascript-constructed "window" with untranslatable "Close" on top-right. The string is hard-coded in greybox/gb_scripts.js -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 11:41:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 10:41:54 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 --- Comment #1 from Holger Mei?ner --- Created attachment 24382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24382&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 11:42:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 10:42:26 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 11:46:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 10:46:21 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 11:52:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 10:52:21 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 --- Comment #2 from Holger Mei?ner --- Comment on attachment 24382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24382 Proposed patch Review of attachment 24382: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11554&attachment=24382) ----------------------------------------------------------------- Works as described. To test: Create patron account with outstanding fines. Open "Fines" tab. Confirm that capitalization is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 11:55:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 10:55:57 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24211|0 |1 is obsolete| | --- Comment #123 from Chris Cormack --- Created attachment 24383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24383&action=edit Bug 7143 : Updating about page and history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 11:58:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 10:58:23 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24382|0 |1 is obsolete| | Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz Assignee|h.meissner.82 at web.de |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Created attachment 24384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24384&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:00:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:00:31 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #88 from Jonathan Druart --- Comment on attachment 21312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21312 [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions Review of attachment 21312: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6739&attachment=21312) ----------------------------------------------------------------- ::: opac/opac-user.pl @@ +157,4 @@ > if ($issues){ > foreach my $issue ( sort { $b->{date_due}->datetime() cmp $a->{date_due}->datetime() } @{$issues} ) { > # check for reserves > + my ( $restype, $res, undef ) = CheckReserves( $issue->{'itemnumber'} ); This is a regression of bug 9367. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:03:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:03:55 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:04:03 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21312|0 |1 is obsolete| | Attachment #21313|0 |1 is obsolete| | Attachment #21314|0 |1 is obsolete| | Attachment #21315|0 |1 is obsolete| | Attachment #21316|0 |1 is obsolete| | Attachment #21317|0 |1 is obsolete| | --- Comment #89 from Jonathan Druart --- Created attachment 24385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24385&action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:04:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:04:48 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #90 from Jonathan Druart --- Created attachment 24386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24386&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:05:57 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #91 from Jonathan Druart --- Created attachment 24387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24387&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:06:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:06:11 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #92 from Jonathan Druart --- Created attachment 24388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24388&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces "opac actions such as placing a hold or reserve" by "opac actions such as placing holds or renrw books" - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo "categori" and syspref name case Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:06:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:06:20 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #93 from Jonathan Druart --- Created attachment 24389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24389&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening

                  instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : instead of , maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) => OK, both actions are blocked. b) category: use syspref (default) syspref: don't block => OK, both actions possible. c) category: block syspref: don't block => OK, both actions are blocked. d) category: block syspref: block => OK, both actions are blocked. e) category: don't block sypref: block => OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:06:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:06:38 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #94 from Jonathan Druart --- Created attachment 24390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24390&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: "you account" - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization "Don't Block" in system preference description. - Adding . to the end of the warning, when renewals are blocked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:06:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:06:46 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #95 from Jonathan Druart --- Created attachment 24391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24391&action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:06:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:06:54 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #96 from Jonathan Druart --- Created attachment 24392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24392&action=edit Bug 6739: template changes for the bootstrap theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:12:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:12:30 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24384|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Created attachment 24393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24393&action=edit Bug 11554 Capitalization fix in patron account on fines tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:12:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:12:43 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:34:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:34:54 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #26 from Jonathan Druart --- The patch should fix the existing rows in the statistics table. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:45:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:45:47 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #2 from Olli-Antti Kivilahti --- I am not seeing a way to endorse this bug, but I'll endorse it by commenting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:57:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:57:18 +0000 Subject: [Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m QA Contact|paul.poulain at biblibre.com |jonathan.druart at biblibre.co | |m --- Comment #16 from Jonathan Druart --- I don't know why this one is still needs signoff. It has been signed off twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:58:04 +0000 Subject: [Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart --- QA comment: The patch works great, see the 2 pdf I will send. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 12:59:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 11:59:03 +0000 Subject: [Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14398|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 24394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24394&action=edit Bug 9210 : letters generated for holds are missing wrapping for words and lines. This commit adds wrapping styles to print-notices.tt template Test plan: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 13:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 12:00:16 +0000 Subject: [Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #19 from Jonathan Druart --- Created attachment 24395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24395&action=edit pdf generated without the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 13:00:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 12:00:41 +0000 Subject: [Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #20 from Jonathan Druart --- Created attachment 24396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24396&action=edit pdf generated with the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 13:05:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 12:05:10 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for recieving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply QA Contact|koha.sekjal at gmail.com | --- Comment #14 from Jonathan Druart --- fatal: sha1 information is lacking or useless (C4/Acquisition.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 13:06:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 12:06:46 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Jonathan Druart --- fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/userpermissions.sql). Please provide 1 file for DB changes and 1 file (at least) for others changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 13:07:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 12:07:04 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 13:10:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 12:10:14 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #31 from Kyle M Hall --- (In reply to Sophie MEYNIEUX from comment #30) > This patch introduce a new bug in 3.8.x > It uses C4::Members::GetBorrowerCategorycode that is introduced only in 3.10 > with http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742 > > This patch should be reverted for 3.8.x version This patch has now been reverted in 3.8.x and the reversion will be part of 3.8.22 Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 13:29:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 12:29:54 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 --- Comment #4 from M. de Rooy --- (In reply to David Cook from comment #3) > Marcel, why do you think that these patches are necessary? Hi David. Thanks for testing. They are not that important :) But I would like to reduce the 500s in my log (especially from opac, mainly coming from Googlebot). Testing if something is what it should be, cannot hurt BTW :) > I suppose, in the case of the OPAC, it might make sense to return a 404 > instead of a 500, but when is an opac-showmarc.pl query string going to be > malformed? That is indeed somewhat less likely, but not imaginary. 1) Someone saved a URL. The record does no longer exist. 2) User 1 deleted the record, Zebra has not been updated yet. User 2 clicks on the link. 3) If the marcxml of a record is malformed (due to some earlier error or so), GetMarcBiblio returns undef. We should check that and not assume a valid MARC::Record object. > In the case of the staff client, I got a 404 both before/after trying the > patch, so I'm not sure that it's necessary. I imagine that there must > already be checking higher up in showmarc.pl? Really? I got the following 500 error on an wrong biblio number: Can't call method "as_formatted" on an undefined value at /usr/share/koha/testclone/catalogue/showmarc.pl line 82. You should be able to repeat this error in current master.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 14:00:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 13:00:11 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Hm, why not only the branchcodes for those where no specific rule exists? I > should really have tested first, sorry for confusing. Overdues is quite a > sensitive area for us. The routine returns all branchcodes with overdue rules defined. If you have only specific rules, all branches with at least a rule defined will be returned. But if you have at least 1 default rule, ALL branchcodes should be returned (the default rule affect all branches). If the routine does not return all branchcodes, the issue described by Sophie occurs. It will only affect instance with at least a default rule defined. This is marked as major but I think it is a critical one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 14:41:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 13:41:42 +0000 Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 14:59:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 13:59:06 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- I did not test this patch but the issue makes me think to bug 10952. Julian fixed the issue storing the values in session instead of cookies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:18:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:18:07 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- I really don't know why but this patch does not work. After applying it: ./translate update fr-FR I don't find the string in the po file. Marked as Failed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:21:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:21:49 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |emmaheath.student at wegc.scho |ity.org |ol.nz Severity|enhancement |normal --- Comment #2 from Owen Leonard --- This has a few problems which need to be addressed: Line 19: A tab character was introduced for indentation. Should be spaces. Line 20: var answer = "confirm(msg); <-- That quotation mark shouldn't be there. But the big problem is that even with these problems corrected the patch doesn't work to make the string translatable. I'm not sure what the cause is, but I have a suggestion which might fix the problem and make the string more translation-friendly. In general it's bad practice to add template variables into the middle of a sentence because it makes assumptions about sentence structure in other languages: _("Are you sure you want to write off [% total | format('%.2f') %] in outstanding fines? This cannot be undone!") It would probably be better to move the template variable to the end. Something like this: _("Are you sure you want to write off these outstanding fines? This cannot be undone! Total writeoff:") + [% total | format('%.2f') %] Finally: The test plan has to include another step: Making sure the translation script really picks up the string: In misc/translator run "perl translate update en-GB" (or whatever language you'd like to test). Check the regenerated po file (en-GB-i-staff-t-prog-v-3006000.po in this case) to make sure the string is there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:21:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:21:47 +0000 Subject: [Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23974|0 |1 is obsolete| | --- Comment #3 from Koha Team Lyon 3 --- Created attachment 24397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24397&action=edit Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref "Place hold" button works now as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:21:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:21:57 +0000 Subject: [Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:33:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:33:36 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11487 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:33:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:33:35 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11488 --- Comment #3 from Jonathan Druart --- see Owen's comment on bug 11488. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:38:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:38:41 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- I think this change needs unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:39:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:39:55 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #17 from Olli-Antti Kivilahti --- Created attachment 24398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24398&action=edit Bug 10845: Preventing duplicate print notices and enforcing a print notice if no notices can be generated ------------------------- - REPLICATING THE ISSUE - ------------------------- 1. Set a Patrons "Hold filled"-messaging preference to SMS + Email 2. Remove the SMS number (sms notification number) and all email addresses. 3. Make a reservation for this Patron. 4. Check-in the reserved Item. 5. message_queue-table has two generated print notices for the Hold_filled event. One for both failed message transport types, email and sms. 1. Set a Patrons "Hold filled"-messaging preference to empty, remove all checks from boxes. 2. Make a reservation for this Patron 3. Check-in the reserved Item. 4. message_queue-table has no message for the Hold-filled event. This is problematic because a Patron should get somekind of a notification for a filled Hold. ----------------------------- - AFTER APPLYING THIS PATCH - ----------------------------- If all message transport types for "Hold filled" fail, a print notice is queued in the message_queue-table. Only one print message is queued even if many transports attempts fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:44:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:44:38 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal --- Comment #4 from Owen Leonard --- I suggest: var dob = _("Dates of birth should be entered in this format:")+ " '"+[% format %]+"'"; ...and note that my comment on Bug 11488 about tab indentation is true of this patch as well. Ditto on the translation test step. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:44:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:44:46 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24012|0 |1 is obsolete| | --- Comment #18 from Olli-Antti Kivilahti --- Created attachment 24399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24399&action=edit Bug 10845: Multi transport types for holds The HOLD_PRINT and HOLD_PHONE notices become useless. This patch will modify existing notices in order to group them into the main notices 'HOLD'. Like that, on one screen, all these notices can be edited. Test plan: - apply the patch and execute the update database entry. - verify that yours previous HOLD_PHONE and HOLD_PRINT are displayed when editing the HOLD notice (under phone and print). - choose a patron and check sms, email, phone for "Hold filled" (on the patron messaging preferences). - place a hold. - check the item in and confirm the hold. - if the patron has an email *and* a sms number, 2 new messages are put into the sql message_queue table: 1 sms and 1 email. if the patron does not have 1 of them, there are 2 new messages: 1 sms/email and 1 print. if the user has neither of them, there is 1 new message: 1 print. - the generated messages should correspond with the notices defined, depending the message transport type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:45:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:45:27 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24013|0 |1 is obsolete| | --- Comment #19 from Olli-Antti Kivilahti --- Created attachment 24400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24400&action=edit Bug 10845: Remove the notice code HOLD_PRINT The HOLD_PRINT notice code is the HOLD notice code with a message transport type equal to 'print'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:52:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:52:03 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24400|0 |1 is obsolete| | --- Comment #20 from Olli-Antti Kivilahti --- Created attachment 24401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24401&action=edit Bug 10845: Remove the notice code HOLD_PRINT The HOLD_PRINT notice code is the HOLD notice code with a message transport type equal to 'print'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:55:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:55:26 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #4 from Koha Team Lyon 3 --- I did several tests of transfers (from a basket, from the receipt page, after a double transfer). Every time, I received the document and cancelled the reception: the document returns as awaiting to be received. The discount of document to be received is OK. Everything is OK for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:55:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:55:53 +0000 Subject: [Koha-bugs] [Bug 10808] Thesaurus search form does not correspond to current search query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:56:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:56:19 +0000 Subject: [Koha-bugs] [Bug 10605] Problems with translated cart email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #34 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:56:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:56:55 +0000 Subject: [Koha-bugs] [Bug 11535] Patron self-registration form does not sanitize its input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11535 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:57:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:57:04 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #5 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:57:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:57:22 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:57:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:57:26 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:57:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:57:31 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:57:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:57:38 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #6 from sandboxes at biblibre.com --- Created attachment 24402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24402&action=edit Bug 11549: Add regression test test plan: prove t/db_dependent/Acquisition/TransferOrder.t should fail before the patch and success after applying it. Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:57:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:57:41 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 24403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24403&action=edit Bug 11549: FIX receive and cancel the receipt after a transfer. To reproduce the issue: - transfer an order from a basket to another. Note the previous ordernumber (X) and the new one (Y). - receive the order - cancel the receipt - verify the order has been deleted: select count(*) from aqorders where ordernumber=Y; select * from aqorders_transfers where ordernumber_from = X; The value for ordernumber_to is null. To test this patch: - apply this patch - transfer an order from a basket to another - receive the order - cancel the receipt - verify the order still exist in the basket where the transfer has been done. Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 15:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 14:57:45 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 24404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24404&action=edit Bug 11549: Interpolate variables into SQL statements should not be allowed Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:02:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:02:43 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24401|0 |1 is obsolete| | --- Comment #21 from Olli-Antti Kivilahti --- Created attachment 24405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24405&action=edit [SIGNED-OFF] Bug 10845: Remove the notice code HOLD_PRINT The HOLD_PRINT notice code is the HOLD notice code with a message transport type equal to 'print'. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:03:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:03:09 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24399|0 |1 is obsolete| | --- Comment #22 from Olli-Antti Kivilahti --- Created attachment 24406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24406&action=edit [SIGNED-OFF] Bug 10845: Multi transport types for holds The HOLD_PRINT and HOLD_PHONE notices become useless. This patch will modify existing notices in order to group them into the main notices 'HOLD'. Like that, on one screen, all these notices can be edited. Test plan: - apply the patch and execute the update database entry. - verify that yours previous HOLD_PHONE and HOLD_PRINT are displayed when editing the HOLD notice (under phone and print). - choose a patron and check sms, email, phone for "Hold filled" (on the patron messaging preferences). - place a hold. - check the item in and confirm the hold. - if the patron has an email *and* a sms number, 2 new messages are put into the sql message_queue table: 1 sms and 1 email. if the patron does not have 1 of them, there are 2 new messages: 1 sms/email and 1 print. if the user has neither of them, there is 1 new message: 1 print. - the generated messages should correspond with the notices defined, depending the message transport type. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:06:25 +0000 Subject: [Koha-bugs] [Bug 11324] "Delete All Items" fails except on "Normal Tab" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11324 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Version|3.14 |master Assignee|koha-bugs at lists.koha-commun |dhorsman at xtra.co.nz |ity.org | Summary|"Delete All Items" fails |"Delete All Items" fails |except on "Normal Tab" 3.14 |except on "Normal Tab" --- Comment #3 from Owen Leonard --- If [% countorders %] and [% countdeletedorders %] are coming up empty on MARCdetail.pl and other pages it's because the variable is not being set. If the variable is not being set, assuming those numbers are zero is inaccurate. Since confirm_deletion() is designed to warn users before taking potentially destructive action I think it's important that it get accurate data. A quick look suggests it's simply necessary to copy the relevant code from detail.pl to the other affected pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:08:20 +0000 Subject: [Koha-bugs] [Bug 11561] New: Preventing duplicate print notices and enforcing a print notice if no notices can be generated Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11561 Bug ID: 11561 Summary: Preventing duplicate print notices and enforcing a print notice if no notices can be generated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:08:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:08:34 +0000 Subject: [Koha-bugs] [Bug 11561] Preventing duplicate print notices and enforcing a print notice if no notices can be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11561 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10845 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:08:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:08:34 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11561 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:09:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:09:31 +0000 Subject: [Koha-bugs] [Bug 11561] Preventing duplicate print notices and enforcing a print notice if no notices can be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11561 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 24407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24407&action=edit Bug 11561: Preventing duplicate print notices and enforcing a print notice if no notices can be generated ------------------------- - REPLICATING THE ISSUE - ------------------------- 1. Set a Patrons "Hold filled"-messaging preference to SMS + Email 2. Remove the SMS number (sms notification number) and all email addresses. 3. Make a reservation for this Patron. 4. Check-in the reserved Item. 5. message_queue-table has two generated print notices for the Hold_filled event. One for both failed message transport types, email and sms. 1. Set a Patrons "Hold filled"-messaging preference to empty, remove all checks from boxes. 2. Make a reservation for this Patron 3. Check-in the reserved Item. 4. message_queue-table has no message for the Hold-filled event. This is problematic because a Patron should get somekind of a notification for a filled Hold. ----------------------------- - AFTER APPLYING THIS PATCH - ----------------------------- If all message transport types for "Hold filled" fail, a print notice is queued in the message_queue-table. Only one print message is queued even if many transports attempts fail. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:10:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:10:54 +0000 Subject: [Koha-bugs] [Bug 11561] Preventing duplicate print notices and enforcing a print notice if no notices can be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11561 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Olli-Antti Kivilahti --- Apparently not everyone uses print notifications. Maybe a syspref should be added to control the behaviour? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:11:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:11:48 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:15:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:15:53 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #23 from Olli-Antti Kivilahti --- There is a problem with this patch. On some occasions it is possible for a Patron to receive two print notices, if both email and sms notifications are enabled for "Hold filled" -event, but are not set in the Patron's details. Also if no message transport types are defined for "Hold filled", the patron gets no notification whatsoever about his hold status. Joubu promised to add a print checkbox to the Patron messaging preferences, thus alleviating this issue a bit, but making it possible for a patron to receive 3 print notices about this same event. One solution for this behaviour is in bug 11561. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:17:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:17:55 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24324|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 24408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24408&action=edit Bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:17:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:17:52 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:27:43 +0000 Subject: [Koha-bugs] [Bug 11562] New: QA: the sysprefs.sql is not correctly sorted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Bug ID: 11562 Summary: QA: the sysprefs.sql is not correctly sorted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at biblibre.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:30:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:30:25 +0000 Subject: [Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:30:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:30:29 +0000 Subject: [Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 --- Comment #1 from Jonathan Druart --- Created attachment 24409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24409&action=edit Bug 11562: sysprefs.sql is not correctly sorted. The QA tools does not manage to catch error sorting on the sysprefs.sql file if it is already bad sorted. This patch tidies up the sysprefs file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:30:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:30:51 +0000 Subject: [Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:31:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:31:49 +0000 Subject: [Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 --- Comment #2 from Jonathan Druart --- This one needs a quick push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 16:33:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 15:33:56 +0000 Subject: [Koha-bugs] [Bug 11563] New: Class noEnterSubmit no longer functioning Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Bug ID: 11563 Summary: Class noEnterSubmit no longer functioning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:01:08 +0000 Subject: [Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #21 from Galen Charlton --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:01:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:01:12 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #8 from M. Tompsett --- Two things I noticed when I tested. 1) The order of the system preference text box was changed. I don't think that is problem, but felt I should note that. 2) I noticed the default was 0. Should it be 0, or should it be blank? Since this is really outside the scope of updating the explanation, I'm ignoring it, even if it is a potential problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:02:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:02:35 +0000 Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Congratulations on having your first patch accepted into Koha, Holger! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:03:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:03:14 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|String patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:03:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:03:17 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24376|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 24410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24410&action=edit [SIGNED OFF] Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived Test plan: Update the updatedb entry and search the pref in the admin module. The explanation should have been updated. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:06:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:06:28 +0000 Subject: [Koha-bugs] [Bug 11042] Color issue for selected tab under search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:06:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:06:36 +0000 Subject: [Koha-bugs] [Bug 11042] Color issue for selected tab under search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22433|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 24411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24411&action=edit Bug 11042: Updated staff global.css so that it does not override rules in custom.css Test plan: put \#header_search ul.ui-tabs-nav li.ui-tabs-selected { background-color: #FFFFF1; border: 1px solid #800000; !important; border-top: 0 !important; top: -1px; } in the pref IntranetUserCSS. Go on the intranet main page. Look at the borders of the selected tab in the search header. They should be burgundy-coloured. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:09:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:09:18 +0000 Subject: [Koha-bugs] [Bug 11042] Color issue for selected tab under search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, oleonard at myacpl.org --- Comment #3 from Jonathan Druart --- Owen, do you agree with this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:14:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:14:03 +0000 Subject: [Koha-bugs] [Bug 9216] Make table headings translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a file for table |Make table headings |headings translation and |translatable |copy of this file during | |the translation process | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:31:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:31:45 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:31:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:31:49 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22664|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 24412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24412&action=edit bug_11184: correct attribute cloning for the maint screen To test - Patron details entry page: * Have ExtendedPatronAttributes enabled. Check that "Additional attributes and identifiers" section behaves. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:34:27 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- This behavior is not present in 3.12.7, but it is present on 3.15 in the sandboxes. I do not know if this is affecting 3.14. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:42:03 +0000 Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:42:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:42:07 +0000 Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21493|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 24413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24413&action=edit Bug 10955 - Add ability to skip deletions in zebraqueue It seems that record deletions can cause extreme slowdowns for Koha installations with extremely large numbers of records. It would be helpful to be able to skip record deletions when processing the zebraqueue with rebuild_zebra.pl so the deletions can be processed with a lower frequency. Test Plan: 1) Disable any zebra indexing cronjobs you may have 2) Delete a record 3) Note the operation recordDelete in the zebraqueue table having done = 0 4) Run misc/migration_tools/rebuild_zebra.pl -b -z --skip-deletes 5) Note the delete still has done = 0 6) Run misc/migration_tools/rebuild_zebra.pl -b -z 7) Note the delete now has done = 1 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:46:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:46:05 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24408|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 24414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24414&action=edit Bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Simple patch. It works for prog and bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 17:46:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 16:46:43 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:04:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:04:17 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:04:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:04:21 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22385|0 |1 is obsolete| | Attachment #22921|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 24415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24415&action=edit Bug 11138 - Add auto_unsuspend_reserves to crontab.example To test: Set up and run the cronjobs from crontab.example with a hold set to unsuspend today. The hold should be unsuspended. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:05:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:05:54 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 --- Comment #6 from Jonathan Druart --- Created attachment 24416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24416&action=edit Bug 11138 - auto_unsuspend_holds cronjob not in default cron jobs. to test: Install the packages with this patch, observe the /etc/cron.daily/koha-common file - auto_unsuspend_holds should now be in the default list. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:15:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:15:40 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #124 from Jonathan Druart --- Comment on attachment 24383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24383 Bug 7143 : Updating about page and history Review of attachment 24383: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7143&attachment=24383) ----------------------------------------------------------------- Why did you add tabulation characters? They break the 2 lines. ::: docs/history.txt @@ +211,4 @@ > February 1-3 2005 Chris Cormack, Rachel Hamilton-Williams and Russel Garlick demonstrate Koha and man a stand at Alia Online, in Australia. Irma Birchall helps out also. > February 6 2005 Koha 2.2, Software Overview and Description of Features -- is now available on http://www.kohadocs.org > February 7 2005 Paul Poulain announces he has hired Henri Damien Laurent to work with him on Koha > +February 10 2005 "Koha Architectural Study" by Nicholas Rosasco and Erik Bakke. New doc on kohadocs.org This breaks the display. @@ +223,4 @@ > May 2 2005 Koha translated to Swedish translation,sweden > May 6 2005 Argentinian start work on customising Koha for use in Argentinian Universities Argentina > May 8 2005 Stephen Hedges starts work on 2.2 Users guide > +May 15 2005 New document on http://www.kohadocs.org "Command-line scripts," Jared Jennings' translation of Paul Poulain's original French document. Look for it in section 2.3 "Maintenance and Troubleshooting." This breaks the display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:15:51 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:15:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:15:55 +0000 Subject: [Koha-bugs] [Bug 11174] Wrong parameter 'valuec' in opac-authoritiessearchresultlist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:16:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:16:42 +0000 Subject: [Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:17:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:17:11 +0000 Subject: [Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:21:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:21:55 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:21:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:21:59 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23231|0 |1 is obsolete| | Attachment #23232|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 24417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24417&action=edit Bug 11329: Check for marc record in opac-showmarc Instead of just running as_formatted, check if GetMarcBiblio returned a reference. If you e.g. did not pass an id, return 404 instead of 500. Consistent with opac-export.pl Test plan: [1] Run opac-showmarc.pl with valid biblionumber in id parameter. [2] Remove id parameter from URL. You should get a 404 now. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:22:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:22:08 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 --- Comment #6 from Jonathan Druart --- Created attachment 24418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24418&action=edit Bug 11329: Check for marc record in catalogue/showmarc Intranet counterpart patch. Same check as in opac/opac-showmarc. Test plan: [1] Run showmarc.pl with valid biblionumber in id parameter. [2] Remove id parameter from URL. You should get a 404 now. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:24:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:24:13 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- It work well for me, i am redirected to 404. It is not the best, I think we should catch the error and display a suitable warning. But it improves the actual state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:27:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:27:26 +0000 Subject: [Koha-bugs] [Bug 11522] self registration formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Congratulations on having your first patch accepted into Koha, Francesca! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:48:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:48:29 +0000 Subject: [Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern match instead of equals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:48:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:48:49 +0000 Subject: [Koha-bugs] [Bug 11410] Cataloging search finds no results for searches with ampersands In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:48:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:48:54 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:48:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:48:58 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24318|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 24419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24419&action=edit Bug 11543: Increasing test coverage for Category.pm To test: 1. Run prove t/db_dependent/Category.t 2. Apply patch 3. Run prove t/db_dependent/Category.t - Notice 2 tests were run Signed-off-by: daniel Made the requested changes. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:49:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:49:05 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 --- Comment #7 from Jonathan Druart --- Created attachment 24420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24420&action=edit Bug 11543: (followup) Increasing test coverage for Category.pm Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 18:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 17:49:24 +0000 Subject: [Koha-bugs] [Bug 10735] koha-dump not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 19:07:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 18:07:42 +0000 Subject: [Koha-bugs] [Bug 11564] New: Sorting any search on a date column fails! Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11564 Bug ID: 11564 Summary: Sorting any search on a date column fails! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It appears that any attempt to sort a search on a date column fails. The two date columns that can be searched on are publication date and acquisition date. Video: http://screencast.com/t/yaRfaqA7mW2r I've also reproduced this on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 19:36:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 18:36:39 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 --- Comment #10 from M. Tompsett --- You can't do multiple statements in the $dbh->do(); http://search.cpan.org/~timb/DBI-1.630/DBI.pm#do -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 19:45:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 18:45:04 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21587|1 |0 is obsolete| | --- Comment #11 from M. Tompsett --- Comment on attachment 21587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21587 Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults This is closer to correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 19:45:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 18:45:25 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23772|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Comment on attachment 23772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23772 Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults This breaks the do() in addition to the $c issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:04:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:04:44 +0000 Subject: [Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:20:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:20:33 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:20:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:20:37 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21587|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 24421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24421&action=edit Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults This patch adds a default record matching rule for biblionumber using the 999$c and the Local-Number index. This is part of the optional marc21 SQL, as well as in the updatabase.pl script. TEST PLAN --------- 1) Back up your DB, because you probably want it back. 2) Apply the patch 3) Run the QA test tool. 4) Run updatedatabase.pl 5) Export some MARC bibliographic records from Koha 6) Import those same MARC bibliographic records using the "KohaBiblio" record matching rule. 7) The incoming records should match perfectly 8) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. 9) drop the koha database 10) create the koha database 11) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 12) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. 13) Restore your DB backup. :) I wasn't able to do steps 5-7 properly, because of the lack of 999$c MARC records in my data as far as I know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:41:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:41:02 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:41:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:41:06 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24419|0 |1 is obsolete| | Attachment #24420|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 24422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24422&action=edit [PASSED QA] Bug 11543: Increasing test coverage for Category.pm To test: 1. Run prove t/db_dependent/Category.t 2. Apply patch 3. Run prove t/db_dependent/Category.t - Notice 2 tests were run Signed-off-by: daniel Made the requested changes. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:41:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:41:26 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 --- Comment #9 from Katrin Fischer --- Created attachment 24423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24423&action=edit [PASSED QA] Bug 11543: (followup) Increasing test coverage for Category.pm Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:52:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:52:21 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:52:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:52:27 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24383|0 |1 is obsolete| | --- Comment #125 from Chris Cormack --- Created attachment 24424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24424&action=edit Bug 7143 : Updating about page and history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:58:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:58:48 +0000 Subject: [Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15202|0 |1 is obsolete| | Attachment #15259|0 |1 is obsolete| | Attachment #16942|0 |1 is obsolete| | --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 24425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24425&action=edit Bug 9579: use String::Multibyte to correctly truncate facets Bug 9579: use String::Multibyte to correctly truncate facets As Bernardo pointed on comment #17, the incorrect display of multibyte strings in facets is related to the way they are currently truncated. C4::Search::getRecords relies on CORE::substr for the task, which only counts bytes, and thus doesn't check it is breaking multi-byte characters. This patch replaces both the use of CORE::substr and CORE::length for their String::Multibyte counterpart. To test: - Set FacetLabelTruncationLength = 4 to make sure it will try to truncate the facet label. - Add a record with multiple multibyte characters in the author name (copy and paste '??' several times so it is looong). Note: make sure there are at least two records so you're presented the search results. - Reindex zebra to make it possible to search the record. - Search for the record. - Notice the facet with cyrillic characters is broken in the place it gets truncated. - Apply the patch and repeat the search. - Notice the string is not broken. - Sign off. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:59:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:59:15 +0000 Subject: [Koha-bugs] [Bug 11543] Increasing test coverage for C4::Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Congratulations on having your first patch accepted into Koha, Roman! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 20:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 19:59:32 +0000 Subject: [Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Assignee|fridolyn.somers at biblibre.co |tomascohen at gmail.com |m | --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 24426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24426&action=edit Bug 9579: (followup) add dependency for String::Multibyte Bug 9579: (followup) add dependency for String::Multibyte -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 21:16:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 20:16:34 +0000 Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Summary|Incorrect display of |Facets truncation broken |UNICODE symbols in 'Refine |for multi-byte characters |Search Results' | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 21:36:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 20:36:09 +0000 Subject: [Koha-bugs] [Bug 11042] Color issue for selected tab under search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #4 from Owen Leonard --- I don't find that this patch solves the problem completely: The tab border color only changes on the sides, not on the bottom. Am I not seeing what you're seeing Jonathan? Removing instances of !important is a good goal in general, and I note that the latest version of jQueryUI doesn't have the same use of !important that 1.8.23 has. The real solution to this bug may be an upgrade to jQueryUI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 21:40:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 20:40:00 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Kyle M Hall --- (In reply to Katrin Fischer from comment #26) > Hi Kyle, I am a bit worried about the stringify because it will break > escaping by dbi. I think it would be better using a list: > > There is an example for that in our coding guidelines: > http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL10:_Placeholders Using placeholders would end up complicating every single query in an extreme manner. That practice of using placeholders is to prevent SQL injection attacks. That is not an issue here. An attack such as that is absolutely not possible in this case, since what we are turning into a string is a list of branchcodes that were just pulled from the database. Good question though! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 21:40:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 20:40:18 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24380|0 |1 is obsolete| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 21:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 20:47:07 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer --- I tested and saw some small issues that could be fixed in a follow up. As we don't have bootstrap in 3.12 the boostrap follow up would be best as a separate patch. INTRANET & PROG OPAC The span for the author facet is not closing correctly: +[% IF facets_loo.type_label_Authors %][% END %] Also it would be nice, if all use were following the same naming schema. Most ids use a minus, but we have 2 using an underscore instead. BOOTSTRAP The HTML structure here is a bit different than for the other 2 themes. The patch adds a span inside a h5 tag. It would be cleaner, if we changed it, so the h5 tag has the id. In order to do that the

                  before and the
                  after the facet block can be deleted and the span has to be changed to h5. The result would look someting like this: [% IF ( facets_loo.type_label_Topics ) %]
                  Topics
                  [% END %] We could also standardize the naming scheme a bit more, by using all lowercase ids. This way it would be the same ids for all 3 templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 21:50:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 20:50:25 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #28 from Kyle M Hall --- Actually, there is one case where it's possible that the passed in branch parameter could be stringified directly. I will add a followup to escape that parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 21:56:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 20:56:09 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23992|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 24427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24427&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 22:12:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 21:12:00 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer --- Kyle, the attached patch introduces a lot of old super librarian checks. Please take a look. I just did a quick search for "flags". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 22:14:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 21:14:20 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #31 from Kyle M Hall --- Created attachment 24428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24428&action=edit Bug 10276i [QA Followup] - Extend IndependentBranches to support groups of libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 22:19:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 21:19:32 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #32 from Kyle M Hall --- Indeed it does! I'll add another followup for that. (In reply to Katrin Fischer from comment #30) > Kyle, the attached patch introduces a lot of old super librarian checks. > Please take a look. I just did a quick search for "flags". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 23:22:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 22:22:41 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 23:34:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 22:34:47 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 --- Comment #14 from David Cook --- (In reply to M. Tompsett from comment #13) > Created attachment 24421 [details] [review] > Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults > > This patch adds a default record matching rule for biblionumber > using the 999$c and the Local-Number index. > > This is part of the optional marc21 SQL, as well as in the > updatabase.pl script. > > TEST PLAN > --------- > 1) Back up your DB, because you probably want it back. > 2) Apply the patch > 3) Run the QA test tool. > 4) Run updatedatabase.pl > 5) Export some MARC bibliographic records from Koha > 6) Import those same MARC bibliographic records using the > "KohaBiblio" record matching rule. > 7) The incoming records should match perfectly > 8) Check the mysql tables (marc_matchers, matchpoints, > matcher_matchpoints, matchpoint_components, > matchpoint_component_norms) to make sure the values were > inserted as expected. > 9) drop the koha database > 10) create the koha database > 11) Go to the staff client page, and do a "fresh" install making > sure to select lots of optional marc 21 matching rules so > the .../marc21/optional/marc21_default_matching_rules.sql > gets triggered. > 12) Check the mysql tables (marc_matchers, matchpoints, > matcher_matchpoints, matchpoint_components, > matchpoint_component_norms) to make sure the values were > inserted as expected. > 13) Restore your DB backup. :) > > I wasn't able to do steps 5-7 properly, because of the lack > of 999$c MARC records in my data as far as I know. Thanks for the update. I've been putting this one off as a trivial enhancement for a little while. You should be able to do steps 5-7. Your Koha biblionumber is stored as your 999$c. If you don't have one in your Koha records, something is seriously wrong. That said, it won't show up for you in Koha, as it's a hidden field everywhere. You'd have to verify its existence by checking the marcxml in the biblioitems table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 23:42:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 22:42:20 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #33 from Chris Cormack --- (In reply to Kyle M Hall from comment #27) > (In reply to Katrin Fischer from comment #26) > > Hi Kyle, I am a bit worried about the stringify because it will break > > escaping by dbi. I think it would be better using a list: > > > > There is an example for that in our coding guidelines: > > http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL10:_Placeholders > > Using placeholders would end up complicating every single query in an > extreme manner. That practice of using placeholders is to prevent SQL > injection attacks. That is not an issue here. An attack such as that is > absolutely not possible in this case, since what we are turning into a > string is a list of branchcodes that were just pulled from the database. > Good question though! It is absolutely possible, if someone, through XSS or CRSF or another means has managed to get sql into the db, this will then fetch and run it. The only time we should not use placeholders is in a case like SELECT * FROM fish WHERE name="fish"; However, SQL injection is not the only reason, for using placeholders. They are for db independence, they will escape characters in the way that is safe for the rdbms running underneath. So we dont need to bother doing the escaping ourself, eg, what if branchcode had a character that would bust the query, GetIndependentGroupModificationRights is doing no escaping/sanitation, ie it is handing back what is in the db, with , '. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 15 23:59:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 22:59:56 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24424|0 |1 is obsolete| | --- Comment #126 from Chris Cormack --- Created attachment 24429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24429&action=edit Bug 7143 : Updating about page and history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 00:02:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 23:02:11 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #34 from Galen Charlton --- (In reply to Chris Cormack from comment #33) > So we dont need to bother doing the escaping ourself, eg, what if branchcode > had a character that would bust the query, > GetIndependentGroupModificationRights is doing no escaping/sanitation, ie it > is handing back what is in the db, with , '. And $dbh->quote() is not the answer, either. I am taking a hard line on this: I will never knowingly push patches that add violations of SQL10 (and certainly not a bunch of them in one fell swoop). I see no upside for the short- and long-term health of the codebase to do so. (In reply to Kyle M Hall from comment #27) > Using placeholders would end up complicating every single query in an > extreme manner. No, it wouldn't. There is an example of how to handle it in code you've written yourself, i.e., ModCourseInstructors(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 00:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Jan 2014 23:05:57 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.14 --- Comment #2 from bondiurbano --- Yes, it still happens for 3.14.1. The same diagnostic. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:05:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:05:43 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:12:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:12:52 +0000 Subject: [Koha-bugs] [Bug 11565] New: decreaseLoanHighHolds needs Override Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Bug ID: 11565 Summary: decreaseLoanHighHolds needs Override Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking out to someone that is homebound or in a limited access area (such as a bookmobile that comes through once a month), it is necessary to set a fixed loan period. There needs to be a way to override this feature on the fly. It might be worth having a rule under Circulation and Fine Rules to specify an item type or patron category that ignores this preference, but it is still necessary to be able to override on the fly. I would envision an option on the warning box that allows you to continue to check out at the normal (or specified) due date, if you have a permission set for your account. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:13:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:13:28 +0000 Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24425|0 |1 is obsolete| | Attachment #24426|0 |1 is obsolete| | --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 24430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24430&action=edit Bug 9579: Facets truncation broken for multi-byte characters We seem to be relying on whatever Zoom::Results->render return, and Perl doesn't explicitly consider it UNICODE data. That's why CORE::substr (and probably CORE::length too) cut the bytes wrong. This patch just decodes the UTF-8 data that render() returns and then Perl behaves, heh. It uses Encode::decode_utf8 which is already a dependency for the current stable Koha releases. To test: - Set FacetLabelTruncationLength = 4 to make sure it will try to truncate the facet label. - Add a record with multiple multibyte characters in the author name (copy and paste a cyrillic character several times so it is looong). Note: make sure there are at least two records so you're presented the search results. - Reindex zebra to make it possible to search the record. - Search for the record. - Notice the facet with cyrillic characters is broken in the place it gets truncated. - Apply the patch and repeat the search. - Notice the string is not broken. - Sign off. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:16:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:16:51 +0000 Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 --- Comment #21 from Tom?s Cohen Arazi --- Sorry for spamming this bug :-D This solution should be used for the stable branches. The work on bug 11096 already covers this problem as the whole record fields are decoded in the first place. I hope this can move fast so it is on stable soon, as backporting 11096 seems a bit more difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:29:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:29:25 +0000 Subject: [Koha-bugs] [Bug 11566] New: Fixing accessibility on OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 Bug ID: 11566 Summary: Fixing accessibility on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: manuelimel at gmail.com QA Contact: testopia at bugs.koha-community.org We used wave.webaim.org toolbar to find errors on webpages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:49:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:49:18 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 --- Comment #52 from Tom Houlker --- Created attachment 24431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24431&action=edit updated the accessability of opac-passwd.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:50:41 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #1 from Tom Houlker --- Created attachment 24432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24432&action=edit updated the accessability of opac-passwd.tt http://bugs.koha-community.org/show_bug.cgi?id=11558 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:52:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:52:59 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #2 from Aleisha Amohia --- Created attachment 24433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24433&action=edit Bug 11566: Fixing accessibility on OPAC in opac-authorities-home.tt Removed unnecessary fieldset around Submit button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:53:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:53:15 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #3 from Emma Heath --- Created attachment 24434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24434&action=edit Bug 11566: Fixing accesssibility on OPAC in opac-memberentry.tt Removed unnecessary fieldset around save button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:53:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:53:27 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #4 from Aleisha Amohia --- Created attachment 24435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24435&action=edit Bug 11566: Fixing accessibility on OPAC in opac-addbybiblionumber.tt Removed unnecessary fieldset around save button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:59:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:59:35 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #5 from Merllissia Manueli --- Created attachment 24436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24436&action=edit Improved accessibility by removing
                  tags as they were unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 01:59:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 00:59:52 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #6 from Merllissia Manueli --- Created attachment 24437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24437&action=edit Improved Accessability by adding 'Order by Date' label -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 02:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 01:00:09 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #7 from Merllissia Manueli --- Created attachment 24438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24438&action=edit Improving Accessability of privacy page by adding tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 02:00:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 01:00:27 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #8 from Merllissia Manueli --- Created attachment 24439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24439&action=edit Improved Accessibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 02:05:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 01:05:38 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #9 from Emma Heath --- Comment on attachment 24434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24434 Bug 11566: Fixing accesssibility on OPAC in opac-memberentry.tt Review of attachment 24434: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11566&attachment=24434) ----------------------------------------------------------------- *submit button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 02:06:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 01:06:01 +0000 Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566 --- Comment #10 from AlexHorsman --- Created attachment 24440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24440&action=edit improved accessibilty by adding legend for suggestion form and submit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 02:47:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 01:47:22 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 --- Comment #15 from M. Tompsett --- There are multiple ways to export. The first way is probably the best. Home -> Tools -> Export data AND Home -> Search the catalogue -> find a specific biblio -> Save -> MARC (Unicode / UTF-8) (Only the UTF-8 and MARCXML ones will save 999$c data) I also ran into a nasty save problem for a title: Identification of an ?Unidentified? Holle List (The): The Last Word (list) I suspect the ticks or brackets caused the issue, but that is a different bug. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 03:04:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 02:04:00 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 03:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 02:04:03 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24421|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 24441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24441&action=edit [SIGNED OFF] Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults This patch adds a default record matching rule for biblionumber using the 999$c and the Local-Number index. This is part of the optional marc21 SQL, as well as in the updatabase.pl script. TEST PLAN --------- 1) Back up your DB, because you probably want it back. 2) Apply the patch 3) Run the QA test tool. 4) Run updatedatabase.pl 5) Export some MARC bibliographic records from Koha 6) Import those same MARC bibliographic records using the "KohaBiblio" record matching rule. 7) The incoming records should match perfectly 8) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. 9) drop the koha database 10) create the koha database 11) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 12) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. 13) Restore your DB backup. :) I corrected any problems I found with the patch, particularly the $c issue. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 04:00:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 03:00:50 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Roman Amor changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 04:00:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 03:00:53 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 --- Comment #1 from Roman Amor --- Created attachment 24442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24442&action=edit Bug 11363 - Changed the unit names form an import to a switch case so that it is in the .tt so that it can be translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 04:05:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 03:05:47 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 04:27:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 03:27:08 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 --- Comment #4 from M. Tompsett --- Created attachment 24443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24443&action=edit MARC file of ISBN 978-0-12-345678-6 Sample data file that I used for testing. https://www.forewordreviews.com/reviews/the-little-book-of-string-theory/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 04:48:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 03:48:12 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 --- Comment #5 from M. Tompsett --- I reset my data to several months ago, to make sure I didn't have the sample record I have attached. I did a staff client update. I imported the record, and added an item. I triggered a reindex: $ ./misc/migration_tools/rebuild_zebra.pl -b -a -z -v I went home, and clicked Cataloging to do a Cataloging Search. I searched for 9780691142890, and it didn't come up, except in the reservoir. I searched for 978-0-691-14289-0, and it came up in both the catalog and the reservoir. I went to the biblio record, and edited the record to not have hyphens in the ISBN (020$a). I triggered a reindex: $ ./misc/migration_tools/rebuild_zebra.pl -b -a -z -v I went home, and clicked Cataloging to do a Cataloging Search. I searched for 9780691142890, and it came up in both the catalog and the reservoir. I searched for 978-0-691-14289-0, and it didn't come up, except in the reservoir. Shouldn't it be coming up for both the reservoir and the catalog regardless of hypens? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 05:48:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 04:48:27 +0000 Subject: [Koha-bugs] [Bug 5071] Make the 'koha' package set things up so that zebra etc. just work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5071 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 06:24:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 05:24:00 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #64 from Galen Charlton --- I expect to push this some time on Thursday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 06:34:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 05:34:40 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 --- Comment #3 from paxed --- (In reply to Owen Leonard from comment #2) > > It would probably be better to move the template variable to the end. > Something like this: > > _("Are you sure you want to write off these outstanding fines? This cannot > be undone! Total writeoff:") + [% total | format('%.2f') %] > No. Just... no. That is much worse. Hard-coding the placement of the number will create it's own problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 06:49:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 05:49:55 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 --- Comment #5 from paxed --- (In reply to Owen Leonard from comment #4) > I suggest: > > var dob = _("Dates of birth should be entered in this format:")+ " '"+[% > format %]+"'"; > > ...and note that my comment on Bug 11488 about tab indentation is true of > this patch as well. > > Ditto on the translation test step. Please do not advocate hard-coding the placement of placeholders, it makes translation harder. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 08:41:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 07:41:07 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24429|0 |1 is obsolete| | --- Comment #127 from M. de Rooy --- Created attachment 24444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24444&action=edit Bug 7143 : Updating about page and history Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 08:43:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 07:43:03 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 08:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 07:44:30 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #128 from M. de Rooy --- Trivial patch, only string changes for about. No need (imho) for a separate QA session :) Looks good to me, no qa tools complaints. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 08:45:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 07:45:35 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #65 from M. de Rooy --- (In reply to Galen Charlton from comment #64) > I expect to push this some time on Thursday. Good to hear. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:03:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:03:58 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from M. de Rooy --- (In reply to M. Tompsett from comment #8) > Two things I noticed when I tested. > 1) The order of the system preference text box was changed. I don't think > that is problem, but felt I should note that. Just looking at the patch, I do not understand your remark. > 2) I noticed the default was 0. Should it be 0, or should it be blank? Since > this is really outside the scope of updating the explanation, I'm ignoring > it, even if it is a potential problem. I agree that it should be blank. In the code I see a split on this pref without further testing. (May not harm, but correcting it is better.) Although you formally could say that it is actually outside report scope, I would like to ask Jonathan to just handle this tiny 'bug' within the same db revision (in the same update statement). No need to touch the same code in two reports. For this reason setting it to Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:04:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:04:37 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:18:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:18:12 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24377|0 |1 is obsolete| | Attachment #24378|0 |1 is obsolete| | Attachment #24379|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 24445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24445&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:18:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:18:17 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #20 from Jonathan Druart --- Created attachment 24446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24446&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:18:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:18:25 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #21 from Jonathan Druart --- Created attachment 24447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24447&action=edit Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:18:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:18:33 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #22 from Jonathan Druart --- Created attachment 24448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24448&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:19:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:19:30 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Jonathan Druart --- (In reply to Katrin Fischer from comment #18) > INTRANET & PROG OPAC > The span for the author facet is not closing correctly Hum... (/me is hidden) > Also it would be nice, if all use were following the same naming schema. > Most ids use a minus, but we have 2 using an underscore instead. Yes of course! I don't know what I did... > BOOTSTRAP > The HTML structure here is a bit different than for the other 2 themes. The > patch adds a span inside a h5 tag. It would be cleaner, if we changed it, so > the h5 tag has the id. In order to do that the
                  before and the
                  > after the facet block can be deleted and the span has to be changed to h5. > The result would look someting like this: > > [% IF ( facets_loo.type_label_Topics ) %]
                  id="facets-Topics">Topics
                  [% END %] > > We could also standardize the naming scheme a bit more, by using all > lowercase ids. This way it would be the same ids for all 3 templates. In fact I forgot to re-upload a patch for the bootstrap theme. It is why the code was completely different. I replaced the span with h5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:19:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:19:43 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:19:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:19:45 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23752|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 24449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24449&action=edit Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC The name of a staff member who managed a suggestion is shown in the the OPAC if the new system preference OpacSuggestionManagedBy is set to 'Show'. This is also the default. If the preference is set to 'Don't show' the staff members name is not displayed and the column 'Managed by' in the table of suggestions in the patron account is not displayed. To test: - Create a one or more suggestions - 'Manage' them by accecpting or rejecting - Go to your patron account and check that the staff member name is shown for your suggestions - Apply patch, run database update - Check the name is still shown - Switch the preference to 'Don't show' - Check the name is no longer shown and the table still displays correctly, but without the 'Managed by' column - Repeat those tests for both bootstrap and prog theme! Signed-off-by: Chris Cormack Works as advertised, the only little nitpick is you could just do [% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %] However you are following the custom in that file already, so that's fine Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:20:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:20:20 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #4 from M. de Rooy --- Looks good to me. No koha-qa complaints. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:23:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:23:25 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 --- Comment #8 from Katrin Fischer --- I agree, everything holds related can't have enough regression tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:26:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:26:11 +0000 Subject: [Koha-bugs] [Bug 11567] New: Shortcut is searching with every keypress Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11567 Bug ID: 11567 Summary: Shortcut is searching with every keypress Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: vanoudt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Just updated to 3.14.1, and noticed that any keypress (including F3!!) anywhere on most staff pages (including in input fields in the system preferences) activates the "Search" shortcut. For instance, in system preferences, if you try and search for a system preference, you start typing and it instead types one letter into the "Search the catalogue" field and then does the search. This makes the staff interface quite useless IMHO. A simple fix - I think, not sure if it's right - is to set the default_option for "disable_in_input" to true in /intranet-tmpl/lib/shortcut/shortcut.js. THat is: var default_options = { 'type':'keydown', 'propagate':false, 'disable_in_input':true, 'target':document, 'keycode':false } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 09:29:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 08:29:59 +0000 Subject: [Koha-bugs] [Bug 11567] Shortcut is searching with every keypress In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11567 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:00:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:00:24 +0000 Subject: [Koha-bugs] [Bug 11568] New: Wrong language code in de-DE/mandatory/subtag_registry.sql Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11568 Bug ID: 11568 Summary: Wrong language code in de-DE/mandatory/subtag_registry.sql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Commit bbe6497 adds the following line to file de-DE/mandatory/subtag_registry.sql VALUES( 'Laoo', 'script', 'en', 'Laotisch'); That should be 'de', not 'en'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:06:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:06:48 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from M. de Rooy --- Tomas: Thank you for your patch. I have a comment however :) You use binmode on STDOUT in the module, but you print to a file handle. So that should not be enough. I would suggest to replace the binmode by adding the encoding to the output file handles. Note that I also had a wide character warning in my log on admin/import_export_framework. You probably need to touch code there as well? I tested with a Chinese character; that went well (export and re-import). Since you actually leave it to Perl to decide the encoding, Perl made the right choice here. But with some Latin characters only, export and re-import made them disappear.. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:09:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:09:29 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 --- Comment #4 from M. de Rooy --- (In reply to M. de Rooy from comment #3) > Tomas: Thank you for your patch. I have a comment however :) You use binmode > on STDOUT in the module, but you print to a file handle. So that should not > be enough. I would suggest to replace the binmode by adding the encoding to > the output file handles. Note that I also had a wide character warning in my > log on admin/import_export_framework. You probably need to touch code there > as well? > I tested with a Chinese character; that went well (export and re-import). > Since you actually leave it to Perl to decide the encoding, Perl made the > right choice here. But with some Latin characters only, export and re-import > made them disappear.. > > Failed QA Some confusion: The binmode is not in the module, but printing to the file handle is. So please correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:22:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:22:27 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from M. de Rooy --- Even more confusion: Please forget the former two comments. I am retesting. Something went wrong. The warning on the wide char is not from your patch after all. Back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:33:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:33:26 +0000 Subject: [Koha-bugs] [Bug 11569] New: Typo in userpermissions.sql Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11569 Bug ID: 11569 Summary: Typo in userpermissions.sql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com userpermissions.sql: (13, 'manage_staged_marc', 'Managed staged MARC records, including completing and reversing imports'), That should probably be "Manage staged..." - There's an extra 'd' in 'Managed' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:42:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:42:41 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:42:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:42:44 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22740|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 24450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24450&action=edit Bug 9114: import/export routines should use UTF-8 Currently both the import_export_framework.pl script and the associated libs output data with Perl's default encoding, ISO-8859. This patch properly sets the binmode to UTF-8 for the CGI script, and makes the C4::ImportExportFramework routines apply the ":encoding(UTF-8)" layer to file descriptors. To test: Export step test - Use some non-ASCII character(s) in some field description in a chosen framework. - Export the framework at Administration > MARC frameworks - Run this to check the file is ISO-8859 encoded: $ file export_XXX.csv export_XXX.csv: ISO-8859 text, with very long lines (Note: try SQL and other output formats too. But not ODS) - Apply the patch - Export the framework again (change the name), and test encoding: $ file export_XXX_2.csv export_XXX_2.csv: UTF-8 Unicode text Import step test I assume you have two files, export_XXX.csv (ISO-8859 encoded) and export_XXX_2.csv (XXX will depend on your framework's code) - Reset your testing branch to master - Import export_XXX.csv - The string with non-ASCII chars is truncated at the first non-ASCII char's position (Note: this is the current behaviour). - Import export_XXX_2.csv - The non-ASCII chars are broken, the logs show errors on non-UNICODE chars. (Note: even thou UTF-8 is the expected encoding it is treated as ISO-8859). - Apply the patch - Import the good (UTF-8 as expected) file and check everything worked as expected. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Marcel de Rooy Tested export and re-import with CSV containing Latin chars and containing Chinese chars. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:43:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:43:36 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:43:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:43:45 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 10:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 09:58:04 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #3 from Jonathan Druart --- Could you check with the master branch please? Maybe bug 11336 fixes your issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 11:03:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 10:03:59 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 11:04:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 10:04:04 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #11 from Jonathan Druart --- Created attachment 24451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24451&action=edit Bug 11237: Update default value for pref AcqItemSetSubfieldsWhenReceived The default value for this pref should be an empty string, not "0". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 11:06:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 10:06:27 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #12 from Jonathan Druart --- (In reply to M. de Rooy from comment #10) > (In reply to M. Tompsett from comment #8) > > Two things I noticed when I tested. > > 1) The order of the system preference text box was changed. I don't think > > that is problem, but felt I should note that. > > Just looking at the patch, I do not understand your remark. Before the patch, it was pref description Now it is: pref description I thought it is better but maybe i am wrong. Feel free to change the order if you disagree. > I agree that it should be blank. In the code I see a split on this pref > without further testing. (May not harm, but correcting it is better.) > Although you formally could say that it is actually outside report scope, I > would like to ask Jonathan to just handle this tiny 'bug' within the same db > revision (in the same update statement). No need to touch the same code in > two reports. Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 11:34:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 10:34:35 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #13 from M. de Rooy --- (In reply to Jonathan Druart from comment #12) > Before the patch, it was pref description > Now it is: pref description > I thought it is better but maybe i am wrong. Feel free to change the order > if you disagree. I agree. > > > I agree that it should be blank. In the code I see a split on this pref > > without further testing. (May not harm, but correcting it is better.) > > Although you formally could say that it is actually outside report scope, I > > would like to ask Jonathan to just handle this tiny 'bug' within the same db > > revision (in the same update statement). No need to touch the same code in > > two reports. > > Done! Thanks. If Mark would be willing to sign off on the follow-up, I will finish the QA step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 12:16:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 11:16:30 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|PurgeSearchHistory should |PurgeSearchHistory should |be merge into the |be merged into the |C4::Search::History module |C4::Search::History module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 12:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 11:56:52 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10677 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 12:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 11:56:52 +0000 Subject: [Koha-bugs] [Bug 10677] C4::Search::GetSearchHistory is broken and unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10807 --- Comment #1 from Jonathan Druart --- Note that I remove this routine in bug 10807. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 13:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 12:28:31 +0000 Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- I disagree with this patch for 1 reason: the MyISAM engine does not support transactions. So when unit tests are launched, the action_logs table will be filled even if the queries are executed into a transaction. I am not sure it is blocker but I have to note this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 13:44:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 12:44:15 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #14 from M. Tompsett --- (In reply to M. de Rooy from comment #10) > (In reply to M. Tompsett from comment #8) > > Two things I noticed when I tested. > > 1) The order of the system preference text box was changed. I don't think > > that is problem, but felt I should note that. > > Just looking at the patch, I do not understand your remark. In the koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref diff the "pref" line comes before the description initially, and after in the patch. This does not break functionality, but it does change the way it displays in the Acquisition system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 13:55:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 12:55:04 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #103 from Paola Rossi --- I test against master 3.15.00.012 The patch "Update database entry" needs to be rebased. Applying: Bug 10855: Search subscriptions by additional fields on the claim page fatal: sha1 information is lacking or useless (C4/Serials.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10855: Search subscriptions by additional fields on the claim page So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:03:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:03:16 +0000 Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart --- QA comment: It works well but could be improved. The permissions in the .pl are not checked in the template files. So it could happen a link is displayed but the user is rejected if he clicks. Example: set circulate, catalogue and updatecharges>remaining_permissions. Go on a patron page, the 'Fines' tab is displayed on the left. Click on it, you are redirected to the loggin page with an error "Error: You do not have permission to access this page." Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:12:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:12:10 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:12:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:12:15 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23599|0 |1 is obsolete| | Attachment #23600|0 |1 is obsolete| | Attachment #23961|0 |1 is obsolete| | Attachment #23962|0 |1 is obsolete| | Attachment #23963|0 |1 is obsolete| | Attachment #23964|0 |1 is obsolete| | --- Comment #104 from Jonathan Druart --- Created attachment 24452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24452&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:12:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:12:24 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #105 from Jonathan Druart --- Created attachment 24453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24453&action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:12:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:12:32 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #106 from Jonathan Druart --- Created attachment 24454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24454&action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:12:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:12:39 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #107 from Jonathan Druart --- Created attachment 24455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24455&action=edit Bug 10855: FIX bad conflict merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:12:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:12:46 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #108 from Jonathan Druart --- Created attachment 24456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24456&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:12:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:12:53 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #109 from Jonathan Druart --- Created attachment 24457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24457&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:23:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:23:25 +0000 Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from M. Tompsett --- After further reading, and looking through Koha, I realized that many of our testing modules have begun to use a: $dbh->{AutoCommit} = 0; This is in stark contrast to the autocommit=1 which is implied in MyISAM. Unless there is a way to disconnect all unit tests from triggering an insert into action_logs, we have a problem if there is $dbh->rollback(). If not for this problem, it would be good. Also, have we bench marked action_logs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:26:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:26:24 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #15 from M. de Rooy --- (In reply to M. Tompsett from comment #14) > (In reply to M. de Rooy from comment #10) > > (In reply to M. Tompsett from comment #8) > > > Two things I noticed when I tested. > > > 1) The order of the system preference text box was changed. I don't think > > > that is problem, but felt I should note that. > > > > Just looking at the patch, I do not understand your remark. > > In the > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref > diff the "pref" line comes before the description initially, and after in > the patch. This does not break functionality, but it does change the way it > displays in the Acquisition system preferences. Thanks for clarification, Mark. Could you sign the follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:39:38 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:39:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:39:40 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24442|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 24458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24458&action=edit [SIGNED-OFF] Bug 11363 - Label printer profile units are not translatable Changed the unit names form an import to a switch case so that it is in the .tt so that it can be translated Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:42:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:42:23 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:54:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:54:27 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |romanwilton at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:55:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:55:40 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 --- Comment #4 from Owen Leonard --- (In reply to paxed from comment #3) > No. Just... no. That is much worse. Hard-coding the placement of the number > will create it's own problems. Please provide a better alternative, with explanation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 14:57:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 13:57:13 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 --- Comment #6 from Owen Leonard --- (In reply to paxed from comment #5) > Please do not advocate hard-coding the placement of placeholders, it makes > translation harder. If you would like to convince me, please don't criticize without providing an explanation. Help me understand rather than just telling me I'm wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:02:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:02:22 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 --- Comment #7 from Jonathan Druart --- Since the strings are currently not translatable, Owen's proposition seems to be a good compromise. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:09:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:09:41 +0000 Subject: [Koha-bugs] [Bug 11567] Shortcut is searching with every keypress In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11567 --- Comment #1 from Owen Leonard --- I can't reproduce this problem in Firefox 26 or Chrome 31 on Windows 7. Please try clearing your browser cache. If the problem persists, please reply with your operating system and browser version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:12:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:12:57 +0000 Subject: [Koha-bugs] [Bug 11567] Shortcut is searching with every keypress In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11567 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #2 from Magnus Enger --- I had something like this, when i was using the Norwegian translation. The problem seemed to be caused by me upgrading Koha but forgetting to update the templates (sudo koha-translate -u nb-NO). After I updated the translated templates, the problem disappeared. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:31:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:31:55 +0000 Subject: [Koha-bugs] [Bug 11570] New: Upgrade jQueryUI to latest version Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Bug ID: 11570 Summary: Upgrade jQueryUI to latest version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Koha master currently uses jQueryUI version 1.8.23. We should upgrade to the latest version, currently 1.10.3. This upgrade would not conflict with our version of jQuery. At the very least the upgrade would help with Bug 11042 because of improvements to the default jQueryUI CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:32:35 +0000 Subject: [Koha-bugs] [Bug 11567] Shortcut is searching with every keypress In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11567 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- This might have been caused by bug 11035 being pushed to stable (3.14.x) and published with 3.14.1 and thus people that forgot to update its template translations had this sympthoms. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:46:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:46:39 +0000 Subject: [Koha-bugs] [Bug 11571] New: Bug 7934 introduces a regression in the translate script Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Bug ID: 11571 Summary: Bug 7934 introduces a regression in the translate script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Bug 7934 breaks the -f option introduced by bug 9161. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:47:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:47:03 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- This patch introduces a regression. See bug 11571. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:48:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:48:55 +0000 Subject: [Koha-bugs] [Bug 5184] Upgrade jQuery to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #27 from Owen Leonard --- A separate bug has been created for the upgrade to 1.10.3, Bug 11570. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:48:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:48:56 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Bug 7747 depends on bug 5184, which changed state. Bug 5184 Summary: Upgrade jQuery to the latest version http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:48:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:48:57 +0000 Subject: [Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Bug 7977 depends on bug 5184, which changed state. Bug 5184 Summary: Upgrade jQuery to the latest version http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:48:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:48:57 +0000 Subject: [Koha-bugs] [Bug 8078] my summary showing contents of incorrect tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8078 Bug 8078 depends on bug 5184, which changed state. Bug 5184 Summary: Upgrade jQuery to the latest version http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:50:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:50:03 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrade jQueryUI to latest |Upgrade jQueryUI to latest |version |version in the staff client --- Comment #1 from Owen Leonard --- I'm revising the scope of this bug to cover the staff client only. A separate bug should cover the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:53:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:53:00 +0000 Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the translate script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 --- Comment #1 from Jonathan Druart --- Created attachment 24459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24459&action=edit Bug 11571: FIX regression introduced by bug 7934 Bug 7934 breaks the -f option introduced by bug 9161. While the generation of the command tmpl_process3.pl, a space is missing if the -x option is given. The tmpl_process3.pl is called like: /home/koha/src/misc/translator/tmpl_process3.pl -q update -i /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ -s /home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po -r -x 'help'-f pay.tt Test plan: - ./translate update fr-FR -f pay.tt - put a warn at LangInstaller.pm line 375. - note the execution time and the output. The options in the command contain "-x 'help'-f pay.tt" The -f param is not passed to the script. - apply this patch and verify the output and the execution time is not correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:52:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:52:57 +0000 Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the translate script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 15:55:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 14:55:52 +0000 Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the translate script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:00:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:00:06 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #19 from Katrin Fischer --- The library we asked to test reported that it's ok now and they can enter dates. I think we still need some error handling, but in general this seems to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:09:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:09:55 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:09:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:09:59 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24320|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 24460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24460&action=edit Bug 11488 Untranslatable warning "Are you sure you want to write off ..." Test plan: - ./translate update LANG - translate the string into your po file - ./translate install LANG - Verify the string is translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:10:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:10:21 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- What about this solution? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:21:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:21:14 +0000 Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I think both opinions are valid here. The best way to translate something is with a placeholder in the sentence. Because this way, you can build your sentence the way you want with the variable in whatever position it needs to be. The problem is, that we have to differentiate a bit between TT code and Javascript code, because of bug bug 7327. So if you use + the string will get cut up into small separate pieces that might not be easy to translate if the variable is in the middle of a sentence. So Owen's suggestion makes sense. Could we use a different technique here? Maybe add a placeholder in a different way that is then replaced by the Javascript? I think the datatables navigation/paging seems to do something like this. And just now I see that Jonathan proposed something like it... :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:33:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:33:31 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #129 from Galen Charlton --- Pushed to master, along with a follow-up adding Holger Mei?ner's name to the about page. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:33:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:33:43 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:34:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:34:11 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:43:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:43:36 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC|paul.poulain at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:56:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:56:20 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #37 from Jonathan Druart --- Still good to me. No regression found since my last tests. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:57:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:57:31 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Jonathan Druart --- Tested on top of bug 10691. All works great. Maybe it would be better to split patches for the OPAC. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:57:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:57:39 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:58:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:58:18 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24232|0 |1 is obsolete| | Attachment #24233|0 |1 is obsolete| | Attachment #24234|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 24461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24461&action=edit Bug 10691: 5xx not properly linked by authid in authority search result list [Staff] This patch changes the URL and data used to show the 'see also' links on the Staff's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a entries with plain text (i.e. no linking) - Make sure zebra is running and changes got indexed. - In the staff interface search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id for linked authorities, and to an authority search result in the case of plain text entries. - Check that the authority search from the cataloguing interface still works as usual. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No errors Signed-off-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:58:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:58:25 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #39 from Jonathan Druart --- Created attachment 24462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24462&action=edit Bug 10691: 5xx not properly linked by authid in authority search result list This patch changes the URL and data used to show the 'see also' links on the OPAC's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a without linking (i.e. plain text) - Make sure zebra is running and changes got indexed. - In the OPAC search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id in the case of linked authorities, and to an authority search in the case of plain text names. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No errors Signed-off-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:58:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:58:31 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #40 from Jonathan Druart --- Created attachment 24463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24463&action=edit Bug 10691: (follow-up) restore behaviour for control field ($w) As noted by Jared, on the presence of 4XX$w or 5XX$w the display got broken by this refactoring. This patch restores de previous behaviour in that front. The OPAC themes get fixed too, and the Bootstrap one gets this fix too. Applied the fix that Galen proposed on comment #30 regarding Zeno's fix in bug 11174. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jared Camins-Esakov Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 16:59:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 15:59:40 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23399|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 24464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24464&action=edit Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap) If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as decribed. No koha-qa errors Nice view on staff and both opac Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:23:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:23:06 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #2 from Owen Leonard --- Created attachment 24465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24465&action=edit Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.3. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes: background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:23:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:23:02 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:34:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:34:43 +0000 Subject: [Koha-bugs] [Bug 11282] Not possible to create multiple restrictions from patron details/new restriction overwrites existing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11282 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:38:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:38:59 +0000 Subject: [Koha-bugs] [Bug 11412] Bulkmarcimport can crash when searching for duplicates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:47:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:47:13 +0000 Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Trivial patch --- Comment #11 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:49:44 +0000 Subject: [Koha-bugs] [Bug 11419] z39.50 searches not displaying errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11419 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:51:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:51:23 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21429|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 24466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24466&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:56:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:56:31 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24466|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 24467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24467&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 17:58:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 16:58:56 +0000 Subject: [Koha-bugs] [Bug 8018] New subfields have a default max length of zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8018 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.2. (creates version 3.14.01.005) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 18:04:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 17:04:31 +0000 Subject: [Koha-bugs] [Bug 7933] Fields in marc display not the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933 --- Comment #29 from Fridolin SOMERS --- Is there something blocking master integration ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 18:20:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 17:20:27 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24467|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 24468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24468&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 18:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 17:21:16 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 18:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 17:40:37 +0000 Subject: [Koha-bugs] [Bug 7934] Separate po file for help pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11571 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 18:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 17:40:37 +0000 Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the translate script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Depends on| |7934 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 20:27:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 19:27:52 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 20:27:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 19:27:55 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24451|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 24469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24469&action=edit [SIGNED OFF] Bug 11237: Update default value for pref AcqItemSetSubfieldsWhenReceived The default value for this pref should be an empty string, not "0". Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 20:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 19:37:56 +0000 Subject: [Koha-bugs] [Bug 11487] Untranslatable tooltip "Dates of birth should be entered in the format ..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- This bug is proving to be quite the instruction for the high school students. Mostly in how not to communicate if you want someone to work on your fix. Thanks Owen and Jonathan for bringing it back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:00:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:00:22 +0000 Subject: [Koha-bugs] [Bug 11572] New: Keyword searches no longer detect isbn from "Search the catalog" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 Bug ID: 11572 Summary: Keyword searches no longer detect isbn from "Search the catalog" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In Koha 3.8, if a standard catalog search was performed and the user clicked the z39.50 search button, the search string would automatically be placed in the isbn field for the z39.50 search form. Changes to the code have since broken this functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:04:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:04:23 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 --- Comment #1 from Kyle M Hall --- Created attachment 24470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24470&action=edit Bug 11572 - Keyword searches no longer detect isbn from "Search the catalog" In Koha 3.8, if a standard catalog search was performed and the user clicked the z39.50 search button, the search string would automatically be placed in the isbn field for the z39.50 search form. Changes to the code have since broken this functionality. Test Plan: 1) From mainpage.pl, use "Search the catalog" to search for the string "9781570672835" 2) Click the Z39.50 Search button 3) Note the string is placed in the title field 4) Apply this patch 5) Repeat steps 1-2 6) Note the string is placed in the isbn field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:04:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:04:21 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:04:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:04:29 +0000 Subject: [Koha-bugs] [Bug 11572] Keyword searches no longer detect isbn from "Search the catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:12:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:12:18 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Merllissia Manueli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |manuelimel at gmail.com --- Comment #5 from Merllissia Manueli --- Still receiving these errors: [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:14:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:14:24 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #6 from Merllissia Manueli --- Still receiving these errors: [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:16:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:16:58 +0000 Subject: [Koha-bugs] [Bug 11551] Allow to search on ordernumber in histsearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 AlexHorsman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dhorsman at xtra.co.nz --- Comment #4 from AlexHorsman --- trying to test this: prove t/db_dependent/Acquisition.t but getting this error: t/db_dependent/Acquisition.t .. 1/66 Use of uninitialized value $orderstatus in string ne at /usr/share/koha/lib/C4/Acquisition.pm line 2242. # Failed test 'GetHistory with a given ordernumber returns 1 order' # at t/db_dependent/Acquisition.t line 184. # got: '4' # expected: '1' Use of uninitialized value $orderstatus in string ne at /usr/share/koha/lib/C4/Acquisition.pm line 2242. # Failed test 'GetHistory with a given ordernumber and search_children_too set returns 2 orders' # at t/db_dependent/Acquisition.t line 186. # got: '4' # expected: '2' # Looks like you failed 2 tests of 66. t/db_dependent/Acquisition.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/66 subtests Test Summary Report ------------------- t/db_dependent/Acquisition.t (Wstat: 512 Tests: 66 Failed: 2) Failed tests: 56-57 Non-zero exit status: 2 Files=1, Tests=66, 1 wallclock secs ( 0.06 usr 0.00 sys + 0.94 cusr 0.07 csys = 1.07 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:39:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:39:49 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:39:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:39:52 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24236|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 24471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24471&action=edit Bug 11533: (regression test) QP breaks authority search This patch duplicates the SearchAuthority tests, with QP enabled. Searching shouldn't be affected by QP. Instructions for manually reproducing this can be read in the first comment for the bug entry. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:39:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:39:57 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 --- Comment #3 from Galen Charlton --- Created attachment 24472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24472&action=edit Bug 11533: fix authority searching with no sorting when QueryParser is enabled This patch fixes an issue where chosing 'None' as the sort order for an authority search would result in zero hits if QueryParser is eanbled. This patch also adds some additional test cases. To test: [1] Enable QueryParser. [2] Perform an authority search in the staff interface that uses 'Heading A-Z' as the sort order and returns hits. [3] Run the same search, but with the sort order set to 'None'. No hits are returned. [4] Apply the patch. [5] Do step 3 again. This time, hits should be returned. [6] Verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 21:41:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 20:41:45 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 --- Comment #4 from Galen Charlton --- (In reply to Tom?s Cohen Arazi from comment #0) > To reproduce: > - Set a dev install (i did it using DOM) and launch zebrasrv. > - Verify that ~/koha-dev/koha-conf.xml points to an existent file in the > 'queryparser_config' section. > - Initialize the DB with the default data add a few authority records and > reindex. > - Search for the authority records (More > Authorities) > => The results are there > - Enable QP (sysprefs > "use" QueryParser > - Do the same search > => No results For folks attempting to reproduce the bug -- without the patches, it breaks for me only with the sort order is set to 'None'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 22:30:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 21:30:18 +0000 Subject: [Koha-bugs] [Bug 11573] New: change description of charges in account fines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Bug ID: 11573 Summary: change description of charges in account fines Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 24473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24473&action=edit item_description_charges Hi, In description of charges on an account, a title of a item is written twice (see capture). Why? It would be nice if each instance can set the information on Description of charges. For example, if we want to see call number, barcode, etc. Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 16 23:43:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 22:43:18 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 00:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 23:09:57 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #41 from Galen Charlton --- Pushed to master, along with a follow-up that changes the HTML comments to TT comments. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 00:10:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 23:10:35 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master, along with a follow-up that repairs breakage in the display of an authority record that has only one 4XX, or one 5XX. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 00:42:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 23:42:41 +0000 Subject: [Koha-bugs] [Bug 11574] New: Printing Lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Bug ID: 11574 Summary: Printing Lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 24474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24474&action=edit Sections that shouldn't print when printing list Would like to see list printing from staff client cleaned up. Right now, the list printing includes buttons and the "Add and item..." section below. These should be omitted to save paper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 00:43:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Jan 2014 23:43:08 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 02:05:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 01:05:04 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from M. Tompsett --- I can't verify the problem, but I can see how it happens. The revised patch should solve this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 02:06:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 01:06:58 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 02:07:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 01:07:01 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24169|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 24475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24475&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Click 'Home' 13) Click 'Administration' 14) Click 'Patron categories' 15) Click '+ New category' 16) Enter a dummy category and click 'Save' 17) Click 'Edit' for the dummy category. 18) Change a value and click 'Save' 19) Click 'Delete' for the dummy category. 20) Confirm to delete. 21) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 02:26:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 01:26:18 +0000 Subject: [Koha-bugs] [Bug 11498] can bypass sco timeout with print dialog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498 Samuel Crosby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scrosby000 at gmail.com --- Comment #1 from Samuel Crosby --- The problem with javascript in this case is that the confirm dialog box freezes runtime, meaning that the timer stops. I don't think theres a way to get it to auto close without plugins. I think the best solution would be to have it either redirect to a page containing a print preview of the receipt (which would allow the timeout check to continue) or to have a separate page for the print receipt, and close would just log out without bringing up a dialog. Anyone got any thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 03:07:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 02:07:07 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 03:07:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 02:07:09 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #9 from M. Tompsett --- Created attachment 24476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24476&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 03:13:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 02:13:30 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24476|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 24477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24477&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 03:17:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 02:17:19 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24477|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 24478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24478&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 03:26:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 02:26:44 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24478|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 24479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24479&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 03:34:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 02:34:01 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24479|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 24480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24480&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 03:41:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 02:41:30 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24480|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Comment on attachment 24480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24480 Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Forget reindenting, fixing licensing, etc. Let's keep this simple. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 03:58:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 02:58:30 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24475|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 24481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24481&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. Discovered tabs I had not corrected by running qa test tool. Some errors which I could not trigger were also fixed, such as line 248 shown by Merllissia Manueli. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Run the koha qa test tool. 13) Click 'Home' 14) Click 'Administration' 15) Click 'Patron categories' 16) Click '+ New category' 17) Enter a dummy category and click 'Save' 18) Click 'Edit' for the dummy category. 19) Change a value and click 'Save' 20) Click 'Delete' for the dummy category. 21) Confirm to delete. 22) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 06:23:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 05:23:48 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #66 from Galen Charlton --- Pushed to master, along with a follow-up updating the Bootstrap them. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 06:26:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 05:26:14 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- (In reply to Katrin Fischer from comment #8) > I think it makes sense to me not to allow it. Hm, can't really explain it > beyond that reverted to indicate "unwanted" to me. I can see why it sounds odd, but on the other hand, a reverted batch is still a staged batch -- it just /used/ to be imported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 06:34:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 05:34:51 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 06:38:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 05:38:10 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 06:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 05:59:59 +0000 Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 07:07:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 06:07:44 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #14 from Galen Charlton --- Pushed to master, along with a follow-up that repairs links to the item from item modification log entries. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 07:08:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 06:08:19 +0000 Subject: [Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master, along with a patch that makes a cosmetic improvement to the display of user/patron names and IDs. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 07:09:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 06:09:45 +0000 Subject: [Koha-bugs] [Bug 11575] New: OPACBaseURL sometimes set by ENV variable and not system preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 Bug ID: 11575 Summary: OPACBaseURL sometimes set by ENV variable and not system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, OPACBaseURL is being set by the $ENV{'SERVER_NAME'} variable with the following code (from 2009) executed in Auth.pm's sub "get_template_and_user": OPACBaseURL => ($in->{'query'}->https() ? "https://" : "http://") . $ENV{'SERVER_NAME'} . ($ENV{'SERVER_PORT'} eq ($in->{'query'}->https() ? "443" : "80") ? '' : ":$ENV{'SERVER_PORT'}"), Basically, this checks whether or not HTTP or HTTPS was used, then uses an environmental variable to fill in the SERVER_NAME and the SERVER_PORT (if it's not 443 or 80). Unfortunately, it appears that this SERVER_NAME is set by the URL used to access Koha, rather than the ServerName provided by Apache. In many cases, this is probably fine, but it means that the OPACBaseURL can change, if you have multiple aliases or if you use an IP address to connect to Koha. Moreover, if you're using a proxy server, it seems to pick up the local domain of the proxy server and NOT the domain from the URL provided by a user. The domain from your URL will appear instead in $ENV{'HTTP_X_FORWARDED_HOST'}. I propose that we just change this variable declaration to: OPACBaseURL => ($in->{'query'}->https() ? "https://" : "http://") . C4::Context->preference("OPACBaseURL") The comments from Bug 2152 seem to indicate other times when the system preference should be used over the environmental variable as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 07:10:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 06:10:06 +0000 Subject: [Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #11 from David Cook --- (In reply to Kyle M Hall from comment #4) > OPACBaseURL is set by get_template_and_user so having a script in the opac > directory set it as well is superfluous, but not harmful. At the time, I don't think I 100% understood what you meant by this, but I do now. I suppose it's not harmful so long as it doesn't tamper with the https detection happening in Auth.pm. That said, at the moment, I think the OPACBaseURL set by get_template_and_user is using an environmental "SERVER_NAME" variable (which appears to be the domain name that a user puts into their browser, rather than the ServerName in the Apache conf), rather than the OPACBaseURL system preference. While this might not be an issue in many cases, it appears to cause issues for Koha instances sitting behind proxy servers... I'm opening bug 11575 to deal with that... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 07:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 06:10:37 +0000 Subject: [Koha-bugs] [Bug 2152] eliminate OPACBaseURL system preference and replace with SERVER_NAME In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2152 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- After some experimenting on proxied and non-proxied connections, it appears that $ENV{'SERVER_NAME'} is the domain name of the URL that a user hits the page with, and NOT the ServerName provided in the Apache configuration. This means that the OPACBaseURL set in Auth.pm during the "get_template_and_user" call will depend on the URL that a user provided to get to that page. Except...when the Koha server is sitting behind a proxy server. In that case, the $ENV{'SERVER_NAME'} appears to come from the proxy server (I'm not certain what name is used...but it looks like some kind of local identifier), while $ENV{'HTTP_X_FORWARDED_HOST'} will contain the domain of the URL provided by the user. I'm opening bug 11575 to investigate further into this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 07:10:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 06:10:54 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8766, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2152 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 07:10:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 06:10:54 +0000 Subject: [Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11575 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 07:10:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 06:10:54 +0000 Subject: [Koha-bugs] [Bug 2152] eliminate OPACBaseURL system preference and replace with SERVER_NAME In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2152 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11575 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 08:09:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 07:09:06 +0000 Subject: [Koha-bugs] [Bug 11576] New: Untranslatable "manage" in serials-collection Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Bug ID: 11576 Summary: Untranslatable "manage" in serials-collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr PrepareSerialsData() in C4/Serials.pm has a hard-coded "manage", which is shown to the user in serials-collection -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 08:57:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 07:57:36 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- Created attachment 24482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24482&action=edit PDF output of print Christopher, Like this? Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 09:01:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 08:01:13 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 09:01:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 08:01:16 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #2 from Liz Rea --- Created attachment 24483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24483&action=edit Bug 11574 - Clean up lists interface for printing Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file, observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 09:02:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 08:02:15 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #3 from Liz Rea --- I should add I suppose, the patch is for the bootstrap theme. If he likes it, I'll do one for prog for backporting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 09:04:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 08:04:58 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- Hi Marjorie, Thanks for your report. As a general note, when taking a screenshot it's useful for us to see the whole page, including the URL, so we know exactly what page you are looking at. Cheers, Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 09:13:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 08:13:20 +0000 Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the translate script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24459|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 24484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24484&action=edit Bug 11571: FIX regression introduced by bug 7934 Bug 7934 breaks the -f option introduced by bug 9161. While the generation of the command tmpl_process3.pl, a space is missing if the -x option is given. The tmpl_process3.pl is called like: /home/koha/src/misc/translator/tmpl_process3.pl -q update -i /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ -s /home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po -r -x 'help'-f pay.tt Test plan: - ./translate update fr-FR -f pay.tt - put a warn at LangInstaller.pm line 375. - note the execution time and the output. The options in the command contain "-x 'help'-f pay.tt" The -f param is not passed to the script. - apply this patch and verify the output and the execution time is now correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 09:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 08:14:05 +0000 Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the translate script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 --- Comment #3 from Jonathan Druart --- Second patch replaces 'not' with 'now' in the commit message... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 09:18:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 08:18:51 +0000 Subject: [Koha-bugs] [Bug 11551] Allow to search on ordernumber in histsearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #5 from Jonathan Druart --- (In reply to AlexHorsman from comment #4) > trying to test this: > prove t/db_dependent/Acquisition.t > > but getting this error: Did you apply the 2 patches against master? The tests pass for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 09:27:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 08:27:33 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 --- Comment #6 from Fridolin SOMERS --- (In reply to M. Tompsett from comment #5) > Shouldn't it be coming up for both the reservoir and the catalog regardless > of hypens? This behavior is enabled in catalog search by using UCI in Zebra indexation. But this patch modifies a behavior only for breeding/reservoir search, which uses SQL query, not the search engine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 10:37:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 09:37:34 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 10:37:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 09:37:38 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #2 from Liz Rea --- Created attachment 24485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24485&action=edit Bug 11573 - Make fine display more consistent for rentals To test: 1. Set up an item type with a rental charge 2. issue an item from that item type 3. Check fines - the rental charge does not show the title of the issued item 4. Renew that item, the renewal charge does show the title of the issued item 5. Apply the patch 6. Repeat steps 1-4, both should show the title of the issued item in the description. This change is proposed in order to get rid of some double ups in the title on the boraccount template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 10:37:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 09:37:51 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #3 from Liz Rea --- Created attachment 24486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24486&action=edit Bug 11573 - removing title double ups on boraccount.tt To test: 1. Create a bunch of fines (or view your existing fines data) - it should have lost entries, rentals, rental renewals, and regular fines and fine updates. 2. View the fines tab for your borrower with fines 3. without the patch, it will look like the submitted screenshot 4. with the patch, there will be few, if any, doubleups of title This patch may be incomplete - there may be cases that still need work. I'm happy to do followups. Rental fees and rental renewals will not look wholly consistent without the other attached patch, but this one does not require it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 10:48:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 09:48:04 +0000 Subject: [Koha-bugs] [Bug 11567] Shortcut is searching with every keypress In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11567 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |WORKSFORME --- Comment #4 from Liz Rea --- I have seen this as well, related to translations, but it seems fixed in 3.14.1 and master. Clearing cache normally makes it go away for me (after the templates are updated). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 10:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 09:50:06 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- This probably also has to do with the report of scanners submitting new borrowers early in 3.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 10:58:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 09:58:41 +0000 Subject: [Koha-bugs] [Bug 11556] Send any notice to any patron (or all patrons) on demand In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- I like the idea of this. One thing I think might be nice would be an option to re-send a notice that has already gone out, from the notices tab, that goes on the schedule with the message queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 10:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 09:59:55 +0000 Subject: [Koha-bugs] [Bug 11548] notice when card about to expire In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11548 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Component|Patrons |Notices --- Comment #1 from Liz Rea --- This would be a cool option, one to add to the enhanced messaging options for sure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 11:08:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 10:08:09 +0000 Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #5 from Liz Rea --- Hmm, mine was Chromium and Firefox (latest on both) in Ubuntu, and it still worked in both. I tried with long and short cardnumbers, I'm just not seeing it. But since you guys did, I'll believe you that it exists. :) Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 11:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 10:25:08 +0000 Subject: [Koha-bugs] [Bug 11577] New: [ENH] Automatic renewal feature Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Bug ID: 11577 Summary: [ENH] Automatic renewal feature Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: h.meissner.82 at web.de Reporter: h.meissner.82 at web.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Our library wants a new ?automatic renewal? feature, that enables some patrons to borrow items for a long time, without having to renew manually. So for certain combinations of patron category and item type, renewals will be done by a cronjob. Automatic renewal stops when a hold is placed or when the given number of allowed renewals is exceeded. RFC: http://wiki.koha-community.org/wiki/Automatic_renewal_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 11:26:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 10:26:05 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #9 from Julian Maurice --- Created attachment 24487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24487&action=edit Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber If parent_ordernumber is not set in NewOrder parameter, it is automatically set to ordernumber. This patch only avoid code duplication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 11:26:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 10:26:21 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 12:20:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 11:20:54 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #69 from Koha Team Lyon 3 --- the HasWhateverRenewalToBeBlocked function makes a first level checking to see if any renewal must be blocked. The reason why may be one of the followings : 1) the borrower is already restricted 2) the borrower have late item(s) AND the 'blockall' option of OverduesBlockRenew syspref is enabled. the function gives the result of the checking through the value of first returned variable $blockallitems and also return in the third variable $overduesblockrenew the value of option syspref OverduesBlockRenew that will be passed to CanBookBeReserved if a second level checking is necesary on every items (if $blockallitems != 1). May be I could rename this function MustRenewalBeBlocked ? As for the following lines : $("input[name='renew_checked']").val('Return checked items')" cCould you tell me where exactly is the traduction problem since I kept the preexisting english terms ? Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 13:25:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 12:25:48 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23321|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 24488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24488&action=edit Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: There are many "space" changes. The reason to that is to format files to ease the translation process. Not related with this bug, but necessary. Also a few changes on default framework. Signed-off-by: Katrin Fischer I ran some tests and found one more case where the liblibrarian and libopac columns had slightly different descriptions, adding a follow-up for that. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 13:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 12:25:58 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23322|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 24489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24489&action=edit Bug 11330: Follow-up - Inconsistent field/subfield descriptions on MARC21 bibiographic frameworks Fixes one missing for 951 field description in the Default framework. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 13:26:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 12:26:09 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:03:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:03:25 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24186|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 24490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24490&action=edit Bug 11096: (follow-up) add direct regression tests This adds direct tests of indexing and retrieving bib records that are larger than the ISO2709 limit of 99,999 octets. To test: verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton Signed-off-by: Tomas Cohen Arazi Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:03:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:03:33 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24187|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 24491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24491&action=edit Bug 11096 - Wrap each test set configuration into a subtest This makes it easier to read. Also fixes the test count, and is rebased against 11499 which is needed to correctly test the patches for this bug (i.e. indexing mode needs to be correctly set in koha-conf.xml) Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:03:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:03:38 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24188|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 24492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24492&action=edit Bug 11096: force XML syntax for Zebra in DOM This patch makes Koha <-> Zebra use MARCXML for the serialization. We currently use the USMARC, which remains for GRS-1. This functions are modified for that purpose: - C4::Context->Zconn - C4::Context-_new_Zconn - C4::Search->* - C4::AuthoritiesMarc->SearchAuthorities - C4::AuthoritiesMarc->merge - C4::AuthoritiesMarc->FindDuplicateAuthority C4::Context->config('zebra_bib_index_mode') and C4::Context->config('zebra_auth_index_mode') Calls to the unsafe ZOOM::Record->render()[2] method are removed. Due to this last change the code for building facets was rewritten. And for performance on the facets creation I pushed higher version dependencies for MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string). Calls to MARC::Record->new_from_xml and MARC::Record->new_from_usmarc are wrapped with eval for catching problems [2]. To test: - prove t/db_dependent/Search.t should pass. - Searching should remain functional. - Indexing and searching for a big record should work (that's what the unit tests do). Regards To+ [1] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render() [2] a record that cannot be parsed by MARC::Record is simply skipped (bug 10684) Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Passes koha-qa.pl, all unit test. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:09:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:09:04 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com --- Comment #38 from Kyle M Hall --- Works great! On a side note, search results are crazy slow for the example record Tom?s uploaded. This is not an issue with this patch but does expose how slowly Koha process all items on a search results. I've seen this before with records that have hundreds of items that don't surpass the marc record length. Records that are overly large due to bib level notes fields and such will not trigger this kind of slowness. It may behoove us to find any efficiencies we can for item processing for search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:20:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:20:51 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24410|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 24493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24493&action=edit Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived Test plan: Update the updatedb entry and search the pref in the admin module. The explanation should have been updated. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:21:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:21:04 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24469|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 24494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24494&action=edit Bug 11237: Update default value for pref AcqItemSetSubfieldsWhenReceived The default value for this pref should be an empty string, not "0". Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:21:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:21:15 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:30:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:30:54 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:30:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:30:57 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24004|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 24495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24495&action=edit Bug 11309: Duplicated patterns when subscription table is updated Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:39:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:39:24 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24291|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 24496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24496&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:39:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:39:36 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #18 from Kyle M Hall --- Created attachment 24497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24497&action=edit Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:40:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:40:00 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 14:49:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 13:49:07 +0000 Subject: [Koha-bugs] [Bug 11328] local cover images in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:06:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:06:07 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 --- Comment #9 from Kyle M Hall --- Created attachment 24498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24498&action=edit Bug 10452 [QA Followup] - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:07:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:07:35 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24498|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 24499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24499&action=edit Bug 10452 [QA Followup] - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:13:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:13:59 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #36 from Paola Rossi --- I test against master 3.15.00.012 , unimarc, icu, italian version. All the items of all the merged records are kept in the output record (OK). In 005 time is the time of the merge (OK). The use of pref "MergeReportFields" is OK too. Report shows all the required columns (except the ones whose values are empty for all the records involved in the merge, OK). So my test is OK for unimarc, italian version. I let you complete the test on marc21. I shall not work on bugzilla in the next weeks. I keep the "Needs Signoff" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:16:52 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:18:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:18:30 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24417|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 24500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24500&action=edit Bug 11329: Check for marc record in opac-showmarc Instead of just running as_formatted, check if GetMarcBiblio returned a reference. If you e.g. did not pass an id, return 404 instead of 500. Consistent with opac-export.pl Test plan: [1] Run opac-showmarc.pl with valid biblionumber in id parameter. [2] Remove id parameter from URL. You should get a 404 now. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:18:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:18:37 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24500|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 24501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24501&action=edit Bug 11329: Check for marc record in opac-showmarc Instead of just running as_formatted, check if GetMarcBiblio returned a reference. If you e.g. did not pass an id, return 404 instead of 500. Consistent with opac-export.pl Test plan: [1] Run opac-showmarc.pl with valid biblionumber in id parameter. [2] Remove id parameter from URL. You should get a 404 now. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:19:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:19:23 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- I think it would be less confusing for end-users if we had a "no record found" error instead of a generic 404, but this works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:19:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:19:41 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24418|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 24502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24502&action=edit Bug 11329: Check for marc record in catalogue/showmarc Intranet counterpart patch. Same check as in opac/opac-showmarc. Test plan: [1] Run showmarc.pl with valid biblionumber in id parameter. [2] Remove id parameter from URL. You should get a 404 now. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:20:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:20:09 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24487|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 24503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24503&action=edit Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber If parent_ordernumber is not set in NewOrder parameter, it is automatically set to ordernumber. This patch only avoid code duplication. Signed-off-by: Jonathan Druart This solution is better! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:20:05 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:22:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:22:41 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:22:44 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 --- Comment #3 from Kyle M Hall --- Created attachment 24504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24504&action=edit Bug 11363 - Label printer profile units are not translatable Changed the unit names form an import to a switch case so that it is in the .tt so that it can be translated Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:26:32 +0000 Subject: [Koha-bugs] [Bug 11578] New: Improvement of the funds list view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Bug ID: 11578 Summary: Improvement of the funds list view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The funds list is not ergonomic and should be improved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:26:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:26:44 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:37:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:37:12 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:37:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:37:16 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #1 from Jonathan Druart --- Created attachment 24505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24505&action=edit Bug 11578: Upgrade the treetable jquery plugin This patch upgrade the treetable jquery plugin to the last version (3.1.0). It is only used on the funds list view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:37:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:37:21 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #2 from Jonathan Druart --- Created attachment 24506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24506&action=edit Bug 11578: Improve the funds list view The current funds list view does not allow to search in the table and the ergonomics of the page is quite bad. This patch add the datatables plugin combined to the treetable plugin in order to offer a better view of the budgets/funds. Test plan: - Verify there is no regression on this page: try to add/modify/delete a fund and a budget. - Verify the funds hierarchie is correctly displayed. - Filter the funds using the branch and the budget filters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:37:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:37:26 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #3 from Jonathan Druart --- Created attachment 24507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24507&action=edit Bug 11578: Add some css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:40:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:40:08 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #4 from Jonathan Druart --- Created attachment 24508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24508&action=edit Funds list view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:52:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:52:48 +0000 Subject: [Koha-bugs] [Bug 11579] New: The ordernumber is not displayed on the basket page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Bug ID: 11579 Summary: The ordernumber is not displayed on the basket page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:53:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:53:57 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:54:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:54:00 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 --- Comment #1 from Jonathan Druart --- Created attachment 24509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24509&action=edit Bug 11579: Show ordernumber in basket.pl tables Test plan: Verify the ordernumber is correctly displayed on the basket page (acqui/basket.pl?basketno=X) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 15:54:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 14:54:31 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |acqui/basket.pl Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:04:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:04:45 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |jonathan.druart at biblibre.co | |m --- Comment #13 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #7) > (In reply to Paul Poulain from comment #6) > > QA preliminary comment : I thought we wanted not to use Moose, and were > > favoring Class::Accessor > > You're correct, but I think it's rather for CGI scripts which can't support > Moose start-up penalty (will be possible with Plack). It's not a problem for > a CLI. Galen, could you confirm it is not blocker for a push to master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:09:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:09:03 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart --- Hello Amit, Could you provide unit tests for changes introduced in modules please? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:19:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:19:52 +0000 Subject: [Koha-bugs] [Bug 11435] Show basketgroup information in Acquisition tab in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:19:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:19:56 +0000 Subject: [Koha-bugs] [Bug 11435] Show basketgroup information in Acquisition tab in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23771|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 24510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24510&action=edit Bug 11435 - Show basketgroup information in Acquisition tab in catalogue page This patch adds a new column for displaying information about basketgroups in the Acquisition tab on catalogue page for a record. It also adds the number of the basket in the basket column. If the user does not have group_manage permission, he just see the basketgroup name and number. If he has the permission, he can click to display the basketgroup. If the basket is not in a basketgroup, the column is empty. To test: Use a record in an order, and put the basket in a basketgroup. Connect with a user WITHOUY group_manage permission (but with order_manage permission). Go to the record's detail in catalogue and click on Acquisition tab. Check you see the name and number of the basketgroup, with no link around it. Check the number of the basket is displayed within () after the name of the basket Click on the basket link, check the basket displayed is the right one. Connect with a user WITH group_manage permission. Go to the record's detail in catalogue and click on Acquisition tab. Check you see a link with the name and number of the basketgroup. Click on the link, check the basketgroup displayed is the right one. On the basketgroup page, move the basket out of the basketgroup, and save the basketgroup. Go back to the record's page on the catalogue and click on Acquisition tab. Check the basketgroup column is empty Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:25:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:25:19 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #3 from Christopher Brannon --- (In reply to Liz Rea from comment #2) > This probably also has to do with the report of scanners submitting new > borrowers early in 3.14. I would agree with that assessment, since scanner input often sends a CR signal. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:33:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:33:51 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #31 from M. de Rooy --- Just a *dumb* question: Why remove the biblio parameter and look it up in the database if you already had it in the first place? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:34:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:34:06 +0000 Subject: [Koha-bugs] [Bug 11429] Add a link to basketgroup in basket detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:34:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:34:09 +0000 Subject: [Koha-bugs] [Bug 11429] Add a link to basketgroup in basket detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23753|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 24511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24511&action=edit Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:34:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:34:43 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 --- Comment #3 from Ian Palko --- I'll second Owen's comment. Permit me to expand my explanation. Before 3.14 when one loaded this shelves.pl page for a certain list, the focus (cursor) went to the "add items" barcode field. To create a list, one would then just scan (or type in) an item barcode. The page would then reload with the new item in the list. Adding another item was a simple as scanning yet another barcode. Quick list creation (especially for merging items!) Now, the focus does not go to any field. To create a list now, I have place the cursor in the barcode field (or tab to it), scan the item. Then to add a second item, scroll down, again place the cursor, scan. I list of ten items used to require ten scans. Now it requires ten scans, plus ten mouse movements and clicks, plus scrolling as the list gets longer. The solution does not seem to be to move the location of the "add item" field, but to make the focus on the page load on that barcode field. That would restore the earlier functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:38:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:38:24 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24144|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 24512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24512&action=edit Bug 11516 - OPAC highlight lost in results browser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:39:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:39:03 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:46:42 +0000 Subject: [Koha-bugs] [Bug 11429] Add a link to basketgroup in basket detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 --- Comment #5 from Jonathan Druart --- Created attachment 24513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24513&action=edit Bug 11429: Manage display for basketgroup without name If a basketgroup does not have a name, the link was ' (closed)' Now it is "Basket group no. ID (closed)". This is used on the acqui/basketgroup.pl?booksellerid=XX page Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:49:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:49:59 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #18 from Kyle M Hall --- Is there any reason this couldn't be done using dateaccessioned rather than adding a new field to items? I imagine the test for items being 'new' is less than simple in some cases, and I can see a definite advantage in pre-setting items as new rather than determining that on the fly for every item. QA Issue: biblioitems_columns doesn't seem like it belongs in Items.pm, you could easily use DBIx::Class to get the columns names: http://search.cpan.org/~frew/DBIx-Class-0.08121/lib/DBIx/Class/ResultSource.pm#columns so no need for a special subroutine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:50:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:50:21 +0000 Subject: [Koha-bugs] [Bug 11580] New: returnBeforeExpiry and closed day Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Bug ID: 11580 Summary: returnBeforeExpiry and closed day Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi, If ReturnBeforeExpiry is set to "ON", closed day of calendar is not factor in. Test plan: 1. ReturnBeforeExpiry is activated 1. Set a closed day on calendar 2014-01-26 2. Set expiry date of a patron like 2014-01-26 3. Do a checkout, due date will be 2014-01-26 Is it a normal behavior? I dont think so. A due date should not be a closed day? Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:50:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:50:42 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:59:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:59:05 +0000 Subject: [Koha-bugs] [Bug 11581] New: HTTP 404s generated badly in some cases Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 Bug ID: 11581 Summary: HTTP 404s generated badly in some cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org There are several scripts that do the following when they want to signal that a resource (usually a MARC record) does not exist: print $query->redirect("/cgi-bin/koha/errors/404.pl"); This is not great, because what actually happens is that an HTTP 302 redirect is issued, followed by the 404. This wastes a bit of time for the user agent, and might be problematic if you let search engines crawl your OPAC. Better would be doing print $cgi->header( -status => '404 record not found'); or if a more specific message should be displayed, constructing it and calling output_with_http_headers $query, $cookie, $error_template->output, 'html', '404 Not Found'; The affected scripts are: catalogue/showmarc.pl opac/opac-ISBDdetail.pl opac/opac-MARCdetail.pl opac/opac-authoritiesdetail.pl opac/opac-detail.pl opac/opac-export.pl opac/opac-showmarc.pl opac/opac-topissues.pl opac/tracklinks.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:59:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:59:29 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Marcel! Note bug 11581. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:59:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:59:44 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- When I tried to test, the script couldn't find AnyEvent::Processor. Should this library be added as a dependency? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 16:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 15:59:55 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #19 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:00:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:00:12 +0000 Subject: [Koha-bugs] [Bug 11363] Label printer profile units are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Roman! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:00:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:00:36 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:01:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:01:54 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:01:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:01:56 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24450|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 24514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24514&action=edit Bug 9114: import/export routines should use UTF-8 Currently both the import_export_framework.pl script and the associated libs output data with Perl's default encoding, ISO-8859. This patch properly sets the binmode to UTF-8 for the CGI script, and makes the C4::ImportExportFramework routines apply the ":encoding(UTF-8)" layer to file descriptors. To test: Export step test - Use some non-ASCII character(s) in some field description in a chosen framework. - Export the framework at Administration > MARC frameworks - Run this to check the file is ISO-8859 encoded: $ file export_XXX.csv export_XXX.csv: ISO-8859 text, with very long lines (Note: try SQL and other output formats too. But not ODS) - Apply the patch - Export the framework again (change the name), and test encoding: $ file export_XXX_2.csv export_XXX_2.csv: UTF-8 Unicode text Import step test I assume you have two files, export_XXX.csv (ISO-8859 encoded) and export_XXX_2.csv (XXX will depend on your framework's code) - Reset your testing branch to master - Import export_XXX.csv - The string with non-ASCII chars is truncated at the first non-ASCII char's position (Note: this is the current behaviour). - Import export_XXX_2.csv - The non-ASCII chars are broken, the logs show errors on non-UNICODE chars. (Note: even thou UTF-8 is the expected encoding it is treated as ISO-8859). - Apply the patch - Import the good (UTF-8 as expected) file and check everything worked as expected. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Marcel de Rooy Tested export and re-import with CSV containing Latin chars and containing Chinese chars. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:04:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:04:20 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #19 from Jonathan Druart --- (In reply to Kyle M Hall from comment #18) > Is there any reason this couldn't be done using dateaccessioned rather than > adding a new field to items? I imagine the test for items being 'new' is > less than simple in some cases, and I can see a definite advantage in > pre-setting items as new rather than determining that on the fly for every > item. I am not sure to understand: the goal of the cronjob script is to remove the 'new' flag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:08:20 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #20 from Jonathan Druart --- And the script is based on the items.dateaccessioned field for the duration value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:09:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:09:16 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #15 from Fr?d?ric Demians --- Created attachment 24515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24515&action=edit Fix AnyEvent::Processor error AnyEvent::Processor was required, but by error AnyEvent::HTTP was added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:09:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:09:38 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:17:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:17:24 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24196|0 |1 is obsolete| | Attachment #24198|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 24516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24516&action=edit Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:17:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:17:29 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #14 from Kyle M Hall --- Created attachment 24517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24517&action=edit Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:18:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:18:02 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #15 from Kyle M Hall --- Created attachment 24518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24518&action=edit Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:18:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:18:12 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24516|0 |1 is obsolete| | Attachment #24517|0 |1 is obsolete| | Attachment #24518|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 24519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24519&action=edit Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:18:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:18:20 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24209|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 24520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24520&action=edit Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:18:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:18:53 +0000 Subject: [Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23741|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 24521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24521&action=edit Bug 11056 : Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no more assigned to $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : Check basketgroup are shown as before the patch, and can be closed and reopen. Check you can add or remove a basket from a basketgroup, and change informations about it (like delivery place) Check you can create a basketgroup when you close a basket. Signed-off-by: Jonathan Druart The following commands return nothing: - grep validate acqui/basketgroup.tt - grep -R basketgroup.pl -C 2 | grep validate - git grep parseinputbaskets - git grep parseinputbasketgroups - git grep basketgroup.pl | grep validate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:18:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:18:49 +0000 Subject: [Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:19:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:19:51 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24519|0 |1 is obsolete| | Attachment #24520|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 24522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24522&action=edit Bug 11182 [1] - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:20:05 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #19 from Kyle M Hall --- Created attachment 24523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24523&action=edit Bug 11182 [2] - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:20:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:20:14 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #20 from Kyle M Hall --- Created attachment 24524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24524&action=edit Bug 11182 [3] - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:20:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:20:25 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:27:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:27:01 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #110 from Paola Rossi --- I apply the patch against master 3.15.00.012. Adding a new subscription, after saving, the marc additional field is not automatically filled with the specified marc field of the notice. On the contrary, the values of category additional fields appear in new columns of the table. The values of the marc fields appear only once the subscription has been modified. I shall not work on bugzilla in the next weeks. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:31:43 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22956|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 24525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24525&action=edit [SIGNED OFF] Bug 11254 - breeding search must normalize ISBN When importing records, the ISBN is normalized and stored into database (see C4::Breeding::ImportBreeding). But when searching with ISBN into reservoir, it is not normalized (see C4::Breeding::BreedingSearch). So search does not match. This patch adds the normalisation to breeding search. Also replaces call private method _isbn_cleanup by GetNormalizedISBN, the correct public method. Also allows the breeding search on ISBN with hyphens. This is intended to fix only reservoir searches. Revised Test plan ----------------- 1) Back up DB 2) Save copy of attached example somewhere findable 2) Home -> Tools -> Stage MARC records for import 3) Click Browse and select the example MARC file 4) Click Upload file 5) Tweak as desired then click Stage for import 6) Click Manage staged records 7) Click Import this batch into the catalog 8) Home -> Cataloging 9) In the Cataloging search text box type 978-0-691-14289-0 and click Submit -- ISBN13 with hypens not found in reservoir 10) In the Cataloging search text box type 9780691142890 and click Submit -- ISBN13 without hypens not found in reservoir 11) In the Cataloging search text box type 0-691-14289-0 and click Submit -- ISBN10 with hypens not found in reservoir 12) In the Cataloging search text box type 0691142890 and click Submit -- ISBN10 without hypens found in reservoir 13) Apply patch 14) Repeat steps 9-12, this time it is always found! :) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:32:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:32:12 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #32 from mathieu saby --- (In reply to M. de Rooy from comment #31) > Just a *dumb* question: Why remove the biblio parameter and look it up in > the database if you already had it in the first place? Well, you may be right ;-) I thought it was a good thing to have as less parameters as possible, to make the code in .pl files more simple. But it was maybe a bad idea, for performance reasons. The code without this followup was working well (not sure it is still the case), and was signed off. Paul failed QA in comment 17, but I answer him in comment 19. If you think the followup is not needed, I can obsolete it, and put back the bug in "Signed off" state. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:33:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:33:57 +0000 Subject: [Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 --- Comment #6 from mathieu saby --- Oh, I did not even know "git grep" command! Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:34:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:34:17 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from M. Tompsett --- Vast improvement on reservoir searches by ISBN! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:43:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:43:25 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- This patch breaks the ODS format. ODS is a fancy ZIP file, and therefore needs to be written in binary mode. I also observed that strings got double-encoded upon export to the Excel XML format. Marking failed QA for the regressions. For folks testing future version of this patch, please test importing and exporting all four formats. I also want to highlight a part of Marcel's comment 3: to reproduce the bug, you actually don't want Chinese characters or the like in the framework you're exporting -- you want Western European diacritical characters that are to be found in the ISO-8859-1 character set. As Marcel observed, if you've got non-Latin1 characters in your string, Perl is much more likely to emit UTF8. Of course, you should test with non-Latin1 characters too, but they're less likely to trigger the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:47:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:47:35 +0000 Subject: [Koha-bugs] [Bug 11582] New: Have possibility to display authority subfield like bibliographic subfield Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11582 Bug ID: 11582 Summary: Have possibility to display authority subfield like bibliographic subfield Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Hi, In 3.12, in advanced constraints of a bibliographic framework, we have now 5 choices for the visibility of the subfields. Is that we could have the same for authority types? Actually, there is 2 choice, hide or show all. Thanks, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:52:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:52:59 +0000 Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10677 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:52:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:52:59 +0000 Subject: [Koha-bugs] [Bug 10677] C4::Search::GetSearchHistory is broken and unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10677 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10807 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 17:59:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 16:59:54 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 18:17:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 17:17:31 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9823 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 18:17:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 17:17:31 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9788 | --- Comment #11 from M. de Rooy --- Removing dependency on pushed 9788. Will look further next week. Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 18:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 17:22:54 +0000 Subject: [Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 18:22:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 17:22:56 +0000 Subject: [Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24521|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 24526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24526&action=edit Bug 11056 : Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no more assigned to $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : Check basketgroup are shown as before the patch, and can be closed and reopen. Check you can add or remove a basket from a basketgroup, and change informations about it (like delivery place) Check you can create a basketgroup when you close a basket. Signed-off-by: Jonathan Druart The following commands return nothing: - grep validate acqui/basketgroup.tt - grep -R basketgroup.pl -C 2 | grep validate - git grep parseinputbaskets - git grep parseinputbasketgroups - git grep basketgroup.pl | grep validate Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 18:38:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 17:38:02 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 18:38:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 17:38:05 +0000 Subject: [Koha-bugs] [Bug 11254] breeding search must normalize ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24525|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 24527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24527&action=edit Bug 11254 - breeding search must normalize ISBN When importing records, the ISBN is normalized and stored into database (see C4::Breeding::ImportBreeding). But when searching with ISBN into reservoir, it is not normalized (see C4::Breeding::BreedingSearch). So search does not match. This patch adds the normalisation to breeding search. Also replaces call private method _isbn_cleanup by GetNormalizedISBN, the correct public method. Also allows the breeding search on ISBN with hyphens. This is intended to fix only reservoir searches. Revised Test plan ----------------- 1) Back up DB 2) Save copy of attached example somewhere findable 2) Home -> Tools -> Stage MARC records for import 3) Click Browse and select the example MARC file 4) Click Upload file 5) Tweak as desired then click Stage for import 6) Click Manage staged records 7) Click Import this batch into the catalog 8) Home -> Cataloging 9) In the Cataloging search text box type 978-0-691-14289-0 and click Submit -- ISBN13 with hypens not found in reservoir 10) In the Cataloging search text box type 9780691142890 and click Submit -- ISBN13 without hypens not found in reservoir 11) In the Cataloging search text box type 0-691-14289-0 and click Submit -- ISBN10 with hypens not found in reservoir 12) In the Cataloging search text box type 0691142890 and click Submit -- ISBN10 without hypens found in reservoir 13) Apply patch 14) Repeat steps 9-12, this time it is always found! :) Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 19:34:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 18:34:56 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #53 from Kyle M Hall --- I'm having issues with the final patch. Is this a problem with the patch or just me? Applying: Bug 9016: DB changes: new table overduerules_transport_types Applying: Bug 9016: Fix unit tests Applying: Bug 9016: QA Followup fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9016: QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 19:49:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 18:49:30 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24441|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 24528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24528&action=edit Bug 10811 - Add a 999$c record matching rule to the MARC21 defaults This patch adds a default record matching rule for biblionumber using the 999$c and the Local-Number index. This is part of the optional marc21 SQL, as well as in the updatabase.pl script. TEST PLAN --------- 1) Back up your DB, because you probably want it back. 2) Apply the patch 3) Run the QA test tool. 4) Run updatedatabase.pl 5) Export some MARC bibliographic records from Koha 6) Import those same MARC bibliographic records using the "KohaBiblio" record matching rule. 7) The incoming records should match perfectly 8) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. 9) drop the koha database 10) create the koha database 11) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 12) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. 13) Restore your DB backup. :) I corrected any problems I found with the patch, particularly the $c issue. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 19:50:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 18:50:08 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com --- Comment #18 from Kyle M Hall --- I would question whether this match point should be added for upgrades, as the installer may have opted not to install the default match points. I believe that is a question for the release manager though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 20:01:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 19:01:02 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24415|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 24529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24529&action=edit Bug 11138 - Add auto_unsuspend_reserves to crontab.example To test: Set up and run the cronjobs from crontab.example with a hold set to unsuspend today. The hold should be unsuspended. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 20:01:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 19:01:12 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 20:01:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 19:01:15 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24416|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 24530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24530&action=edit Bug 11138 - auto_unsuspend_holds cronjob not in default cron jobs. to test: Install the packages with this patch, observe the /etc/cron.daily/koha-common file - auto_unsuspend_holds should now be in the default list. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 20:06:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 19:06:04 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Kyle M Hall --- FAIL Koha/Template/Plugin/ColumnsSettings.pm OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK valid OK critic FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 20) OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 21:10:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 20:10:54 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24445|0 |1 is obsolete| | Attachment #24446|0 |1 is obsolete| | Attachment #24447|0 |1 is obsolete| | Attachment #24448|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 24531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24531&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 21:11:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 20:11:17 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #25 from Kyle M Hall --- Created attachment 24532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24532&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 21:11:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 20:11:20 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #26 from Kyle M Hall --- Created attachment 24533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24533&action=edit Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 21:11:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 20:11:23 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #27 from Kyle M Hall --- Created attachment 24534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24534&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 21:11:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 20:11:35 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 22:20:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 21:20:45 +0000 Subject: [Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 22:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 21:21:16 +0000 Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Liz! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 22:22:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 21:22:53 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 17 23:40:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 22:40:31 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #4 from bondiurbano --- Jonathan, thanks for being patient with me. I am not a programmer and sadly can not help you in the way you ask me for. I can help you in "process" analisys. Anyway I read the bug 11336. As long as I understand the issue I am reporting is not included in 11336. The issue is constrained to hold status/prioriry "Waiting", i.e., anywhere in Koha (Staff or OPAC) when a hold with status "Waiting" is cancelled or deleted the next hold that follows the cancelled or deleted hold SHOULD BE UPDATED to status/prioriry "Waiting" and a mail sould be sent to the patron. I was testing this issue locally at /cgi-bin/koha/reserve/request.pl?biblionumber=383 Hope this helps...(my english is not the best. I can write in spanish) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 00:54:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 23:54:56 +0000 Subject: [Koha-bugs] [Bug 9311] How to access Koha from internet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9311 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |INVALID --- Comment #1 from Liz Rea --- Hi, Thanks for your question, unfortunately this isn't a support forum. You might try sending your question to the list, you can subscribe at http://koha-community.org/support/koha-mailing-lists/. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 00:55:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 23:55:51 +0000 Subject: [Koha-bugs] [Bug 8631] Amazon wish-list look-ups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8631 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 00:56:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 23:56:31 +0000 Subject: [Koha-bugs] [Bug 8156] allow users to put things in lists that are not in the catalog (free text entries to lists) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8156 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 00:57:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 23:57:44 +0000 Subject: [Koha-bugs] [Bug 7809] Edit Items screen should be sorted by home branch instead of holding branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7809 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- Probably has the ramification that someone will want it to be a syspref so they can switch which way it sorts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 00:58:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 23:58:26 +0000 Subject: [Koha-bugs] [Bug 7424] Koha should have a designated place for custom CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7424 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |WISHLIST -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 00:58:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 23:58:54 +0000 Subject: [Koha-bugs] [Bug 7707] Add fines placeholders in notices to display fine information on notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7707 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 00:59:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Jan 2014 23:59:51 +0000 Subject: [Koha-bugs] [Bug 7222] Display if a hold was placed in the OPAC or through the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7222 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |WISHLIST -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 01:00:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 00:00:35 +0000 Subject: [Koha-bugs] [Bug 6288] Check-in table could show reserve information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6288 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |WISHLIST -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 01:34:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 00:34:26 +0000 Subject: [Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- I feel, upon further reflection, that it might suffice to simply display the barcode so it can be copy/pasted or just entered by hand. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 01:46:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 00:46:51 +0000 Subject: [Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 01:46:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 00:46:54 +0000 Subject: [Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 --- Comment #2 from Liz Rea --- Created attachment 24535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24535&action=edit Bug 5739 - Show the barcode of the waiting item on the circulation page To test: 1. place a hold for a borrower 2. mark the hold waiting for that borrower 3. view that borrower's circulation page 4. without the patch, no barcode will be displayed under "hold waiting for..." With it, the barcode will be linked to the item. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 04:19:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 03:19:21 +0000 Subject: [Koha-bugs] [Bug 6921] Alert librarian that a waiting reserve has been filled by another item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6921 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WISHLIST -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 07:49:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 06:49:10 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #1 from Liz Rea --- This bug is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 07:53:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 06:53:20 +0000 Subject: [Koha-bugs] [Bug 8922] Can't sort Holds to Pull report on any field besides title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8922 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |WORKSFORME --- Comment #2 from Liz Rea --- This bug seems to have gone away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 08:22:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 07:22:12 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Liz, I think the Bootstrap CSS files require some special magic as they are being generated - see bug 11411. Not sure how to do it yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 08:47:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 07:47:18 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 08:47:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 07:47:21 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24108|0 |1 is obsolete| | Attachment #24381|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 24536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24536&action=edit [PASSED QA] Bug 11141: Filters are not kept on receiving. On receiving orders, the librarian has to filter again the pending orders list. This patch stores the filters in a cookie in order to apply them when the librarian finish a receive and come back on the pending orders list. Test plan: 1/ choose a vendor with several baskets and orders. 2/ start to receive an item. 3/ on the pending orders page, add some relevant filters. 4/ receive an item. 5/ you are back on the pending orders page and filters are directly applied. Signed-off-by: Nicolas Bravais Signed-off-by: Katrin Fischer Passes all tests and QA script. Tested with receiving and cancelling the receive process the filters are kept. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 08:47:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 07:47:37 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 --- Comment #11 from Katrin Fischer --- Created attachment 24537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24537&action=edit [PASSED QA] Bug 11141: Filters should be kept if the receive is cancelled Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 09:27:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 08:27:45 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22877|0 |1 is obsolete| | Attachment #23631|0 |1 is obsolete| | Attachment #24270|0 |1 is obsolete| | Attachment #24271|0 |1 is obsolete| | --- Comment #96 from Katrin Fischer --- Created attachment 24538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24538&action=edit [PASSED QA] Bug 7825: Changed OPACItemHolds syspref to be no|yes|force choice Currently, the Koha system preference OPACItemHolds allows a library system to choose to allow patrons to place bib and item level holds from the OPAC, or to allow patrons only to place bib level holds only from the opac. This patch set adds a third option, "force", which *requires* that patrons place item level holds from the opac, with no option of making a bib level hold. This patch modifies the system preference OPACItemHolds to be of the type "Choice", with the choices being "no", "yes", "force". The patch does not alter the currently set value of OPACItemHolds for database updates, only adding the additional option. Test Plan: 1) Set OPACItemHolds to "no". Check that OPAC holds behave as it is now (no "Place On" column, no "Select a specific copy" table, making a reserve is successful) 2) Set OPACItemHolds to "yes". Check that OPAC holds behave as it is now ( "Place On" column is there, "Select a specific copy" table shows when "A specific copy" is selected, making a reserve is successful) 3) Set OPACItemHolds to "force". Check that OPAC holds behave as follows: - no "Place On" column is present - "Select a specific copy" table is opened - making a reserve is successful This patch is a squashed patch of the 3 following patches: Amended opac-reserve.tt accordingly Signed-off-by: Delaye Stephane Bug 7825: Followup prevent submission without choosing an item + Fix some ergonomic issues in opac-reserve Signed-off-by: Delaye Stephane Bug 7825: Updatedatabase should only change the type and options values. The value field should not be change. We have to keep '1' for 'yes' and '' for 'no'. Original patch is from Srdjan Jankovic. Signed-off-by: Koha team AMU Signed-off-by: Katrin Fischer Testing notes on 4th patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 09:28:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 08:28:03 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #97 from Katrin Fischer --- Created attachment 24539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24539&action=edit [PASSED QA] Bug 7825: Changed OPACItemHolds syspref to be no|yes|force choice - bootstrap Same test plan as previous patch but with the bootstrap theme set. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 09:28:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 08:28:15 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #98 from Katrin Fischer --- Created attachment 24540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24540&action=edit [PASSED QA] Bug 7825: Clarify the yes and no values The value of the pref should be '1' (for yes) or '0' (for no). The options could be kept as 'yes' and 'no': since the ImplicitTyping is set, yes/no would become '1/0'. But I think it is preferable not to use the yes/no value in order not to introduce a bug here if ImplicitTyping is unset later. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 09:28:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 08:28:25 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #99 from Katrin Fischer --- Created attachment 24541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24541&action=edit [PASSED QA] Bug 7825: FIX the force value for the bootstrap theme If the pref was set to 'force', the item selection was not shown. .copiesrow should be hidden before showing specific #copiesrow_ID Signed-off-by: Katrin Fischer Passes all tests and QA script. Works on template level, tested with Boostrap and Prog theme with all 3 possible seetings of OPACItemHolds: 1) no = offer only title level holds 2) yes = offer both title and item level holds 3) force = offer only item level holds Also ran some additional tests on the Boostrap theme with deactivated Javascript. Note: I like this, but I think when "force" is selected the item list needs to be shown by default. I am also not so happy that the first item is automatically selected, but this is the current behaviour without the patches as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 09:35:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 08:35:05 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24541|0 |1 is obsolete| | --- Comment #100 from Katrin Fischer --- Created attachment 24542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24542&action=edit [PASSED QA] Bug 7825: FIX the force value for the bootstrap theme If the pref was set to 'force', the item selection was not shown. .copiesrow should be hidden before showing specific #copiesrow_ID Signed-off-by: Katrin Fischer Passes all tests and QA script. Works on template level, tested with Boostrap and Prog theme with all 3 possible seetings of OPACItemHolds: 1) no = offer only title level holds 2) yes = offer both title and item level holds 3) force = offer only item level holds Also ran some additional tests on the Boostrap theme with deactivated Javascript. Note: I like this, but I think when "force" is selected the item list needs to be shown by default. I am also not happy about preselecting the first item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 09:37:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 08:37:13 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #101 from Katrin Fischer --- I was close to passing this, as you can see from the attached patches, but I am not happy about the force behaviour. I think Kyle already pointed it out in comment 84: When force is selected, the item list is not shown by default. Additionally the first item is preselected. Both points bother me. The user will have no idea which item, which itemtype (short loan? normal loan?) at which branch got selected for the hold to fill. I think this is kind of missing the point of forcing the patron to pick the item to fill the hold. For serials, where it really matters which item you pick, this is even more difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 09:52:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 08:52:04 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #5 from Liz Rea --- There seems to be no print.css in the less folder, so I'm going to assume that his point 2 doesn't apply to this patch (yet). Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 09:58:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 08:58:34 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #47 from Katrin Fischer --- I am quite torn about this patch. I feel it's doing way too many things in one single change. It's really hard to test that way and I am not super confident about doing it, but going to give it a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 11:26:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 10:26:25 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #48 from mathieu saby --- Just ask, and I will split it into several patches. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 11:38:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 10:38:41 +0000 Subject: [Koha-bugs] [Bug 6226] Returning a misrouted item twice causes transit to correct receiving library to disappear In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6226 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |FIXED --- Comment #4 from Liz Rea --- Fixed sometime in 3.8. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 11:39:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 10:39:55 +0000 Subject: [Koha-bugs] [Bug 5827] Cloning Circ rules does not clone hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5827 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Liz Rea --- *** This bug has been marked as a duplicate of bug 4227 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 11:39:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 10:39:56 +0000 Subject: [Koha-bugs] [Bug 4227] opac-logout.pl is no longer used. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4227 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- *** Bug 5827 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 11:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 10:40:52 +0000 Subject: [Koha-bugs] [Bug 5827] Cloning Circ rules does not clone hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5827 --- Comment #2 from Liz Rea --- *** This bug has been marked as a duplicate of bug 4225 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 11:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 10:40:52 +0000 Subject: [Koha-bugs] [Bug 4225] Cloning of rules in smart-rules.pl only clones top table of rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4225 --- Comment #2 from Liz Rea --- *** Bug 5827 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 12:13:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 11:13:20 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #49 from Katrin Fischer --- I will have some comments soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 12:35:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 11:35:08 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #50 from Katrin Fischer --- I am having problems testing pubdate without QueryParser. For the QueryParser pubdate(xxxx) seems to work alright. But pubdate= or pubdate: doesn't seem to work. Any ideas about that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 13:50:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 12:50:54 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #51 from Jared Camins-Esakov --- (In reply to Katrin Fischer from comment #50) > I am having problems testing pubdate without QueryParser. For the > QueryParser pubdate(xxxx) seems to work alright. But pubdate= or pubdate: > doesn't seem to work. Any ideas about that? Yes, dates are searched with parentheses not = or : with QP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 14:00:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 13:00:32 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #52 from Katrin Fischer --- Ah sorry, I was not clear. When the QueryParser is turned off, none of the syntaxes seem to work. Neither for DOM nor GRS1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 14:18:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 13:18:06 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #53 from Katrin Fischer --- What I did after applying the patch: cp etc/searchengine/queryparser.yaml ../koha-devU/etc/searchengine/queryparser.yaml cp etc/zebradb/ccl.properties ../koha-devU/etc/zebradb/ccl.properties cp etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml ../koha-devU/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml cp etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl ../koha-devU/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl cp etc/zebradb/marc_defs/unimarc/biblios/record.abs ../koha-devU/etc/zebradb/marc_defs/unimarc/biblios/record.abs Completely reindexed the bibliographic data using -b -v -r -x Full reindex and searching for Dissertation-information worked nicely in DOM and GRS1. But... 1) In general I am having problems with pubdate and acqdate searches in UNIMARC compared to their MARC21 equivalents Mathieu, could you please take a look? Syntaxes I tried: pubdate=yyyy, pubdate:yyyy With QueryParser: pubdate(yyyy), acqdate(yyyy) 2) It would be nice if Dissertation-information could also be added for MARC21 on a seaparate bug later on. 3) In general I am a bit worried about removing indexes. I can see, why some subfields are not making much sense to index, I also have read the comments on bug 11119, but some of the changes might be debatable. For example the following change could break functionality some libraries rely on. Maybe it would not hurt to keep those around? -#FIXME Fields 603, 630, 631, 632, 633, 634, 635, 636, 646 are not defined in Unimarc, but may be used by some libraries. -melm 603 Subject,Subject:p -melm 630 Subject,Subject:p -melm 631 Subject,Subject:p -melm 632 Subject,Subject:p -melm 633 Subject,Subject:p -melm 634 Subject,Subject:p -melm 635 Subject,Subject:p -melm 636 Subject,Subject:p -melm 646 Subject,Subject:p Failing for now until 1) can be resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 14:54:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 13:54:32 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 14:54:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 13:54:41 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23882|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 24543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24543&action=edit [PASSED QA] Bug 11453 - Update EN default UNIMARC bibliographic framework This patch updates default EN UNIMARC bibliographic framework I used the 2008 version of the UNIMARC bibliographic manual, and added updates listed on official site. There are new fields/subfields, those added are hidden by default. There are some description changes, and also a lot of changes to repeatable and mandatory values. To test: a) Functional 1) Remove all bibliographic frameworks 2) Load new file unimarc_framework_DEFAULT.sql 3) Check that it load without errors b) Correctness 1) Take a time and verify that all new fields/subfileds are correct Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Huge patch, lots of additions and corrections. To view the changes git diff --color-words HEAD^ is helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 15:38:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 14:38:14 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 15:38:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 14:38:18 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19784|0 |1 is obsolete| | Attachment #24499|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 24544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24544&action=edit [PASSED QA] Bug 10452 - AllowHoldsOnDamagedItems should control using damaged items to fulfill holds AllowHoldsOnDamagedItems will stop item-specific holds from being placed on damaged items, but does not stop Koha from using damaged items to fill holds. This seems like incorrect behavior. Test Plan: 1) Set 'AllowHoldsOnDamagedItems' to "Don't Allow" 2) Pick an item, set it to damaged 3) Place a bib-level hold on this item's record 4) Scan the item though the returns system 5) Koha will ask to use this item to fill the hold, click "ignore" 6) Apply this patch 7) Repeat step 4 8) Koha will not ask to use this item to fill the hold Signed-off-by: Srdjan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 15:38:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 14:38:34 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 --- Comment #12 from Katrin Fischer --- Created attachment 24545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24545&action=edit [PASSED QA] Bug 10452 [QA Followup] - Unit tests Signed-off-by: Katrin Fischer Passes all tests and QA script. Also checked t/db_dependent/Holds.t t/db_dependent/HoldsQueue.t Tested holds triggering with different settings of AllowHoldsOnDamagedItems. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 16:01:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 15:01:07 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #54 from mathieu saby --- > > 1) In general I am having problems with pubdate and acqdate searches in > UNIMARC compared to their MARC21 equivalents Mathieu, could you please take > a look? Syntaxes I tried: > pubdate=yyyy, pubdate:yyyy > With QueryParser: pubdate(yyyy), acqdate(yyyy) I will take a look > 3) In general I am a bit worried about removing indexes. I can see, why > some subfields are not making much sense to index, I also have read > the comments on bug 11119, but some of the changes might be debatable. > For example the following change could break functionality some > libraries rely on. Maybe it would not hurt to keep those around? > > -#FIXME Fields 603, 630, 631, 632, 633, 634, 635, 636, 646 are not defined > in Unimarc, but may be used by some libraries. I don't know who added these indexes and why, but they were never used in Unimarc, so it was clearly a mistake to put them in standard configuration files. Maybe some french library made one day a very specific developpment using these fields (I'm thinking of Frantiq network, specialised in Archeology). Or maybe it is just a mistake... I will send a message to french list to warn everybody that if a library want to index those fields in 3.14 they need to edit the config files before reindexing. Mathieu Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 17:17:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 16:17:00 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- (In reply to mathieu saby from comment #2) > Hello > Not sure of that, but I see that you added a 852 field. We don't use it in > France, but I suppose it is made for storing information about items, which > are stored in 995 in UNIMARC Koha. > I unterstand it is part of the IFLA standard, but don't you think this could > be source of mistakes ? I'm not sure of the best way of dealing with that: > maybe not creating 852 field in a fist time? or adding a comment in the fied > name to prevent mistakes? > And maybe on a long run, we could envision to move items from 995 to 852 ?? A general question I've been curious about for a while: who uses the English UNIMARC frameworks? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 18:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 17:50:20 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I think the idea behind the update was in part that it could be used for translations. So only one framework would have to be updated in the future. But the question is good, maybe basing them on another, the French(?) would make more sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 19:09:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 18:09:24 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 --- Comment #8 from mathieu saby --- I'm sure it's used in France, in Portugal, in Italy. And Koha is used in those 3 countries. It may also be in use in Greece, Russia, Croatia and some arabic speaking countries (I found data of 2008 for those countries). Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 21:03:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 20:03:37 +0000 Subject: [Koha-bugs] [Bug 10506] Overdues report: Filter on date due is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10506 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 21:09:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 20:09:09 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 21:09:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 20:09:13 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24402|0 |1 is obsolete| | Attachment #24403|0 |1 is obsolete| | Attachment #24404|0 |1 is obsolete| | Attachment #24503|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 24546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24546&action=edit [PASSED QA] Bug 11549: Add regression test test plan: prove t/db_dependent/Acquisition/TransferOrder.t should fail before the patch and success after applying it. Signed-off-by: Sonia BOUIS Signed-off-by: Katrin Fischer Testing notes on last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 21:09:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 20:09:25 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #12 from Katrin Fischer --- Created attachment 24547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24547&action=edit [PASSED QA] Bug 11549: FIX receive and cancel the receipt after a transfer. To reproduce the issue: - transfer an order from a basket to another. Note the previous ordernumber (X) and the new one (Y). - receive the order - cancel the receipt - verify the order has been deleted: select count(*) from aqorders where ordernumber=Y; select * from aqorders_transfers where ordernumber_from = X; The value for ordernumber_to is null. To test this patch: - apply this patch - transfer an order from a basket to another - receive the order - cancel the receipt - verify the order still exist in the basket where the transfer has been done. Signed-off-by: Sonia BOUIS Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 21:09:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 20:09:36 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #13 from Katrin Fischer --- Created attachment 24548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24548&action=edit [PASSED QA] Bug 11549: Interpolate variables into SQL statements should not be allowed Signed-off-by: Sonia BOUIS Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 21:09:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 20:09:46 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #14 from Katrin Fischer --- Created attachment 24549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24549&action=edit [PASSED QA] Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber If parent_ordernumber is not set in NewOrder parameter, it is automatically set to ordernumber. This patch only avoid code duplication. Signed-off-by: Jonathan Druart This solution is better! Signed-off-by: Katrin Fischer Passes all tests and QA script. Also all tests in t/db_dependent/Acquisitions/. Confirmed bug and that the patch fixes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 21:14:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 20:14:36 +0000 Subject: [Koha-bugs] [Bug 10506] Overdues report: Filter on date due is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10506 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi, normally BLOCKED indicates, that a patch has a dependency on another development and can at the moment not be tested. Does the problem you describe still exist? Maybe you want to switch it back to NEW? If the problem is resolved, you could mark it RESOLVED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 23:27:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 22:27:50 +0000 Subject: [Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 18 23:27:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Jan 2014 22:27:53 +0000 Subject: [Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24094|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 24550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24550&action=edit [PASSED QA] Bug 11397: Remove the itemnumber list on the Acquisition detail tab Test plan: - verify this patch does not introduce regression on the enhancement introduced by bug 8230. - verify the itemnumber list does not appears anymore. Signed-off-by: Nicole C. Engard The acquisitions details tab on the holdings table in the staff client no longer shows the links to the items. Tests pass. Signed-off-by: Katrin Fischer Passes all tests and QA script. In my tests the itemnumbers didn't show up on the acquisition detail tab before the patch. So the patch visually only changed the column header for me. All other acquisition related information showed up ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 02:32:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 01:32:33 +0000 Subject: [Koha-bugs] [Bug 10506] Overdues report: Filter on date due is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10506 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |INVALID --- Comment #2 from bondiurbano --- I'm sooooooooooo sorry. I tried to cancel this ticket... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 03:00:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 02:00:25 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #5 from bondiurbano --- Created attachment 24551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24551&action=edit Updating reserve priority A brief process description of this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 04:47:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 03:47:53 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 JaTara Barnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 09:19:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 08:19:15 +0000 Subject: [Koha-bugs] [Bug 10506] Overdues report: Filter on date due is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10506 --- Comment #3 from Katrin Fischer --- Don't worry and thx for closing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 10:54:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 09:54:54 +0000 Subject: [Koha-bugs] [Bug 11435] Show basketgroup information in Acquisition tab in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11435 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 10:54:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 09:54:58 +0000 Subject: [Koha-bugs] [Bug 11435] Show basketgroup information in Acquisition tab in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11435 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24510|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 24552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24552&action=edit [PASSED QA] Bug 11435 - Show basketgroup information in Acquisition tab in catalogue page This patch adds a new column for displaying information about basketgroups in the Acquisition tab on catalogue page for a record. It also adds the number of the basket in the basket column. If the user does not have group_manage permission, he just see the basketgroup name and number. If he has the permission, he can click to display the basketgroup. If the basket is not in a basketgroup, the column is empty. To test: Use a record in an order, and put the basket in a basketgroup. Connect with a user WITHOUY group_manage permission (but with order_manage permission). Go to the record's detail in catalogue and click on Acquisition tab. Check you see the name and number of the basketgroup, with no link around it. Check the number of the basket is displayed within () after the name of the basket Click on the basket link, check the basket displayed is the right one. Connect with a user WITH group_manage permission. Go to the record's detail in catalogue and click on Acquisition tab. Check you see a link with the name and number of the basketgroup. Click on the link, check the basketgroup displayed is the right one. On the basketgroup page, move the basket out of the basketgroup, and save the basketgroup. Go back to the record's page on the catalogue and click on Acquisition tab. Check the basketgroup column is empty Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 10:59:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 09:59:43 +0000 Subject: [Koha-bugs] [Bug 11429] Add a link to basketgroup in basket detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 10:59:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 09:59:46 +0000 Subject: [Koha-bugs] [Bug 11429] Add a link to basketgroup in basket detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24511|0 |1 is obsolete| | Attachment #24513|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 24553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24553&action=edit [PASSED QA] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 11:00:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 10:00:57 +0000 Subject: [Koha-bugs] [Bug 11429] Add a link to basketgroup in basket detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 --- Comment #7 from Katrin Fischer --- Created attachment 24554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24554&action=edit [PASSED QA] Bug 11429: Manage display for basketgroup without name If a basketgroup does not have a name, the link was ' (closed)' Now it is "Basket group no. ID (closed)". This is used on the acqui/basketgroup.pl?booksellerid=XX page Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Passes all tests and QA script. Adds a link to the basket group page on the basket summary page. The link only appears when the basket group is closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 11:23:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 10:23:25 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Actually, this is quite interesting and confusing to me. Libraries here have to pay the tax, so I would expect the budgeted cost to include a calculated tax, if list prices are tax exclusive. Shouldn't the tax rate influence the prices in some way? I couldn't see that whatever combinatoin I tried. Budgeted cost and replacement cost being the same tax setting as the list price seems currently correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 11:27:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 10:27:41 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 11:27:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 10:27:44 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24110|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 24555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24555&action=edit [PASSED QA] Bug 10922: Display if prices are tax exc. or inc. when creating a new order This patch adds "(tax inc.)" or "(tax exc.)" after the "Vendor price", "Replacement cost", "Budgeted cost" and "Actual cost" when entering a new order. Actual cost must probably not be displayed here, but it will be the subject of an other patch. To test : - create 2 vendors, with differents values for "List prices includes tax" and "Invoiced prices does includes tax" options - create baskets for these 2 vendors - create an order in each basket, and look at the "tax. inc." and "tax exc" mention. It should be consistent with the options for each vendor - look at an order adding "&close=1" to the normal URL of the order. You must see the order without ability to edit it, but with the same mentions "tax inc." and "tax exc." Signed-off-by: Isabelle Beroud Signed-off-by: Katrin Fischer Passes tests and QA script. I have some doubts about the calculations done here, but the display changes are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 12:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 11:06:40 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Srdjan and Jonathan, could you provide more information on the effect of this patch? I have tested the patron attributes on memberentry.pl and it seems to work, but it's a bit hard to tell what to look out for. Also, the warnings in my logs seem the same before and after applying the patch. Also, shouldn't this line be changed as well? 825 my $newentry = { map { $_ => $entry->{$_} } %$entry }; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 12:41:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 11:41:22 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #39 from Katrin Fischer --- To add another set of eyes to this I have done some tests today and I found a problem in the rewrite of the facetting code. Without the patches the item type and other item related facets show the number of records related to them, but with the patch, the number of occurrences of the tag/items is shown. I think this is an unwanted change in behaviour that can be confusing to patrons. We shouldn't mix number of items and number of records in the facets. I think it's related to this change: unless ( $data ~~ @used_datas ) { - $facets_counter->{ $facet->{idx} } - ->{$data}++; push @used_datas, $data; } - } # fields + + $facets_counter->{ $facet->{idx} }->{$data}++; + + } # fields I will do more tests, but failing QA to get this fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 13:49:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 12:49:08 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #40 from Katrin Fischer --- TESTING NOTES MARC21 - b:dom - a:dom 1- Reindexing OK Full bib reindex -b -x -r -v OK Full auth reindex -a -x -r -v OK Update record OK Delete record 2- Catalog search OK Searching OK big record can be found and displayed 3- Facets OK limiting on several facets !!! facet counts 4- Authority search OK Searching OK Update record OK Delete record 5- prove t/db_dependent/Search.t OK All tests pass Problems found: Item related facets show the "wrong" count as what you expect would be a record related count, but what you see is the item related count Example: Itemtype: Books (15) can be only 5 records Typo in documentation serhaps/perhaps introduced by third patch. I am going to try and repeat the tests on a UNIMARC bib:grs1, auth:dom installation next. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 15:50:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 14:50:49 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #41 from Katrin Fischer --- UNIMARC - b:grs1 - a:dom The patches break search in my UNIMARC installation. A normal search for the keyword "der" that gives results on my master branch with freshly reindexed records, fails on the branch with patches applied, reindex and restart of the zebra server: Error: Can't call method "raw" on an undefined value at /home/katrin/kohacloneU/C4/Search.pm line 503. Authority search seems to work ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 17:22:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 16:22:34 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #18 from Katrin Fischer --- Comment on attachment 24099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24099 proposed patch Review of attachment 24099: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7677&attachment=24099) ----------------------------------------------------------------- Starting with a code review..., but also ran some tests in Koha. I really like the idea behind this and have been asked about functionality to automatically set/unset a status for the newest and previous issue before. But I think the current implementation is a bit problematic. Also there are some changes in this patch, that are not related to the main change and cause a lot of question marks for me. The change for the copynumber is especially problematic, as MARC21 uses a different field for the information already. I think this needs a bit more work - also see comments in splinter review below. ::: C4/Items.pm @@ +2782,5 @@ > push @authorised_values, $itemtype; > $authorised_lib{$itemtype} = $description; > + > + # If we have default value named itemtype or itemtypes, we use it > + $defaultvalue = $itemtype if ($defaultvalues and ($defaultvalues->{'itemtypes'} eq $itemtype or $defaultvalues->{'itemtype'} eq $itemtype)); How is this change related to the bug description? @@ +2814,5 @@ > $authorised_lib{$value} = $lib; > + > + # If we have a default value that has the same name as the authorised value category of the field, > + # we use it > + $defaultvalue = $value if ($defaultvalues and $defaultvalues->{$tagslib->{$tag}->{$subfield}->{authorised_value}} and $defaultvalues->{$tagslib->{$tag}->{$subfield}->{authorised_value}} eq $value); How is this change related to the bug description? ::: C4/Serials.pm @@ +926,5 @@ > + > + return $return; > +} > + > + Unit tests included in a separate patch. I had to solve a conflict, but the tests pass. All good. ::: installer/data/mysql/updatedatabase.pl @@ +7935,5 @@ > + ); > + > + print "Upgrade to $DBversion done (Add makePreviousSerialAvailable syspref)\n"; > + SetVersion($DBversion); > +} Please combine into one single database update and add an AFTER reneweddate to ensure that the sequence of fields is the same on new and updated installations. Also - 15 :) ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref @@ +54,5 @@ > + - pref: makePreviousSerialAvailable > + choices: > + yes: Make > + no: Do not make > + - previous serial automatically available when collecting a new serial. Please note that the item-level_itypes syspref must be set to specific item. I think 'receiving' would be a bit better than 'collecting' here, but probably better to check wording with a native speaker. It's not clear, which status will be used from the description - What is the first, and what is the second status? Which fields will be used? Could it be an option to make this pref a bit more configurable, behaving like AcqItemSetSubfieldsWhenReceived? ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt @@ +62,5 @@ > + // Also prefilling copynumber > + // Getting subfield with copynumber mapping > + subfield_div = $(item_div).find("input[name='kohafield'][value='items.copynumber']").parent(); > + // Setting text field > + $(subfield_div).children("input[type='text'][name='field_value']").val($("#serialseq" + serialId).val()); This is a bigger problem: I think copynumber is used in MARC21 to indicate different copies of the same book. The enumchron field is used for the information about issue and year. For MARC21 serialseq is now copied into both fields. I think we can't leave it that way. My suggestion would be to use enumchron for UNIMARC as well or make this marcflavour dependent. ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt @@ +621,5 @@ > + > +
                  6. > + [%IF makePreviousSerialAvailable %] > +
                6. > + Tiny capitalization issue - "Item". As this is on the subscription form, we could maybe leave out "serial" and shorten the description ab it. Also "Serial" is missing from the first field. ::: serials/serials-edit.pl @@ +243,5 @@ > $notes[$i] > ); > } > + my $makePreviousSerialAvailable = C4::Context->preference('makePreviousSerialAvailable'); > + if ($makePreviousSerialAvailable && $serialids[$i] ne "NEW") { What is 'NEW' referring to? In my tests the change for the itemtype worked, but I couldn't figure out, how the status change is supposed to work. ::: serials/subscription-add.pl @@ +153,5 @@ > # prepare template variables common to all $op conditions: > +my $shelflocations = GetKohaAuthorisedValues( 'items.location', '' ); > + > +my @locationarg = > + map { { code => $_, value => $shelflocations->{$_}, selected => ( ( $subs->{location} and $_ eq $subs->{location} ) ? "selected=\"selected\"" : "" ), } } sort keys %{$shelflocations}; How is this change related to the bug description? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 19 17:24:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Jan 2014 16:24:06 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 02:05:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 01:05:18 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 02:05:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 01:05:22 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 --- Comment #1 from David Cook --- Created attachment 24556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24556&action=edit Bug 11575 - OPACBaseURL sometimes set by ENV variable and not system preference This patch changes how the OPACBaseURL parameter gets set in the subroutine get_template_and_user in Auth.pm. Currently, it's being set by the $ENV{'SERVER_NAME'} variable, which is typically filled by the URL that the user uses to access a page. While this works in many cases, this causes a problem when using a proxy server. The SERVER_NAME will instead be the domain of the proxy server (for more info, read the comments already on this bug on Bugzilla). There are ways to compensate for proxy servers. However, such a solution seems a bit convoluted... Elsewhere in Koha, we use the system preference OPACBaseURL, so I think it makes sense to use it here as well. I did leave the $ENV{'SERVER_NAME'} as a full back if OPACBaseURL isn't set, but that's it. _TEST PLAN_ Before applying: 1) Clear your OPACBaseURL preference 2) Perform a search in the OPAC 3) Click on or hover over the orange RSS icon 4) Note that the URL you used to access the site is the URL used for the RSS link 5) Add an OPACBaseURL that isn't the same as the actual OPAC URL 6) Note that the OPACBaseURL system preference has no effect here After applying the patch: 7) Refresh the page 8) Note that the URL you see now is actually the OPACBaseURL system preference that you set 9) Clear your OPACBaseURL system preference 10) Refresh your search page 11) Note that the URL has reverted back to the URL that you used to access the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 02:05:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 01:05:40 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 02:16:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 01:16:10 +0000 Subject: [Koha-bugs] [Bug 11583] New: Add wysiwyg editor for HTML notices/letters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 Bug ID: 11583 Summary: Add wysiwyg editor for HTML notices/letters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, library staff need to handcode HTML notices/letters. This enhancement will add a wysiwyg editor for notices/letters that are marked as "HTML", so that library staff can create HTML notices/letters without much knowledge of HTML and CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 02:19:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 01:19:23 +0000 Subject: [Koha-bugs] [Bug 11584] New: Add wysiwyg editor to system preferences dealing with HTML Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Bug ID: 11584 Summary: Add wysiwyg editor to system preferences dealing with HTML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, library staff have to hand-code system preferences that include HTML in them (e.g. OpacNAV, OpacHeader, etc.). This enhancement will add a wysiwyg editor for system preferences that are marked as "Htmlarea". Built-in system preferences (like those mentioned above) will need to have their .pref files changed (and I suppose the database even though the Type recorded there doesn't appear to be used by Koha itself). While a new type of "Htmlarea" will be available for Local System Preferences. People using Koha as a CMS (http://wiki.koha-community.org/wiki/Koha_as_a_CMS) might find this useful. Or anyone that has added local system preferences for injecting HTML into their templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 02:19:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 01:19:36 +0000 Subject: [Koha-bugs] [Bug 11583] Add wysiwyg editor for HTML notices/letters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 02:19:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 01:19:39 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 02:56:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 01:56:33 +0000 Subject: [Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which require it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #20 from David Cook --- I've started trying to test the 3.10.x patches, but it's quite the slog trying to find the pages affected, and then not necessarily having the data to test them and having to create that data. This one is just too laborious for not enough reward, as it's already in master. Sorry :/. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 03:03:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 02:03:57 +0000 Subject: [Koha-bugs] [Bug 9084] Dates in notices should be formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from David Cook --- I hope it's appropriate that I mark this RESOLVED - DUPLICATE, but bug 11244 identifies the same problem and offers a more robust solution. *** This bug has been marked as a duplicate of bug 11244 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 03:03:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 02:03:57 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #12 from David Cook --- *** Bug 9084 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 04:00:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 03:00:14 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23965|0 |1 is obsolete| | --- Comment #13 from David Cook --- Created attachment 24557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24557&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. Signed-off-by: David Cook I love this patch! It is the best solution to this problem that I've seen. I think it is set up to perfectly handle dates in the notices. Unfortunately, the $dateonly flag is backwards, so the time is stripped from timestamps and 00:00:00 is added to dates without times. I'm adding a follow-up to reverse the setting of this flag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 04:00:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 03:00:39 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #14 from David Cook --- Created attachment 24558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24558&action=edit Bug 11244: (follow-up) Fix $dateonly flag At the moment, $dateonly is set to true when $1 is defined. However, since the regex capture group only includes the time, this flag will only be set when there is a value that includes a time. In effect, this means that timestamps are reduced to dates only, while dates have 00-00-0000 added to them. This patch keeps the logic but reverses the values, so that $dateonly will default to true unless $1 is defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 04:28:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 03:28:35 +0000 Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 04:28:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 03:28:39 +0000 Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23200|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 24559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24559&action=edit Bug 11314 - Restore ability to see only 5 entries on parcel.pl Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows, as well as the "sticky" feature. It is trivial to restore this functionality. These datatables are already using bStateSave, so are they are "sticky" already. The only part left is to enable the ability to limit the table to 5 rows at a time. Test Plan: 1) Apply this patch 2) Browse to parcel.pl 3) Note the default rows count is still 10 4) Note the option to limit the row count to 5 Signed-off-by: David Cook Works as described. Double-checked that the "sticky" feature is still in place thanks to bStateSave. I didn't notice a difference due to iDisplayLength being added, but the extra option of "5" to the list is there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 04:49:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 03:49:02 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 04:49:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 03:49:07 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23196|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 24560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24560&action=edit Bug 11313 - empty value in mandatory combobox in record edition In biblio (or authority) record edition or creation, Bug 3727 added an empty value to combobox for subfield using itemtype authorized values, which is mandatory and does not have a default value. This to avoid selecting arbitrarily the first value of combo. This patch extends this behavior to normal authorized values like CCODE, COUNTRY ... Also, when record already exists and has a defined value for the subfield this value will be selected in combobox so there is no need for an empty value. Test plan : - In a biblio framework, set a subfield mandatory and using itemtypes authorised values - Set a default value for this subfield - Create a new record with the framework => You see the subfield with a combobox, the first empty value is selected - Go to biblio framework and set a default value for the subfield - Create a new record with the framework => You see the subfield with a combobox, the default value is selected and there is no empty value - Select an other value and save the record - Edit this record => You see the subfield with a combobox, the saved value is selected and there is no empty value Perform same tests with a normal authorized values categorie (instead of itemtypes). Perform same tests with with authority creation/edition Perform same tests with a normal authorized values categorie and authority creation/edition Signed-off-by: David Cook Works as described. Fridolyn: I had a lot of difficulty understanding your test plan, especially since the second line should not be in the test plan (since if there is a default value, no empty value should appear). Perhaps it would be useful to use more whitespace to separate steps and the things for which a tester should check. Also, it might be useful to specify what testers should check for before and after applying the patch, so that they're sure that the behaviour has been corrected. In any case, the patch works! Certainly a helpful addition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:10:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:10:56 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |dcook at prosentient.com.au --- Comment #13 from David Cook --- Fridolyn: I agree that changing the templates to include copyrightdate would be another bug, since the templates don't include it already. However, I think it would still be prudent to add biblio.copyrightdate to your patch, since it was already included in the past with the biblio.* select. In any case, this patch needs to be rebased, as 3.14.0 (I think) merged "SearchOrders" and "GetPendingOrders". -- Bug 11122 - publisher code and publication year not fetched in acq orders 22306 - Bug 11122 - publisher code and publication year not fetched in acq orders Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11122 - publisher code and publication year not fetched in acq orders Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt Auto-merging acqui/uncertainprice.pl CONFLICT (content): Merge conflict in acqui/uncertainprice.pl Auto-merging C4/Acquisition.pm CONFLICT (content): Merge conflict in C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 11122 - publisher code and publication year not fetched in acq orders When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:23:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:23:58 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- HTTP_X_FORWARDED_HOST That reminds me of bug 6800. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:45:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:45:27 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23370|0 |1 is obsolete| | --- Comment #49 from Jared Camins-Esakov --- Created attachment 24561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24561&action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:45:37 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23371|0 |1 is obsolete| | --- Comment #50 from Jared Camins-Esakov --- Created attachment 24562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24562&action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:45:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:45:49 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23372|0 |1 is obsolete| | --- Comment #51 from Jared Camins-Esakov --- Created attachment 24563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24563&action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:46:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:46:02 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23373|0 |1 is obsolete| | --- Comment #52 from Jared Camins-Esakov --- Created attachment 24564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24564&action=edit Bug 10402 [Template follow-up] Add multiple contacts for vendors This template-only follow-up tweaks the button labels and restructures the vendor view layout a little bit to make it more amenable to multiple contacts: - Add spaces after button icons - Change "Add contact" to "Add another contact" in hopes of making it less ambiguous whether clicking it will submit the whole form. - Eliminate duplicate headers on the vendor view page by making the contact name the subheading for each individual contact. To test, view details for vendors with one or more contacts, and try editing to add additional contacts. Everything should look good and work correctly. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:46:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:46:14 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23374|0 |1 is obsolete| | --- Comment #53 from Jared Camins-Esakov --- Created attachment 24565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24565&action=edit Bug 10402 follow-up: rebase onto latest master Because of the complexity of the rebase, I have chosen to correct a couple merge errors in a separate patch rather than squashing the corrections into the last patch in the patchset. This rebase patch does one thing that may not be completely obvious: in order to keep the existing tests matching their stated aims, it centralizes contact-related unit testing at the end of the Bookseller.t unit test, and removes contacts from earlier tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:46:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:46:24 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23375|0 |1 is obsolete| | --- Comment #54 from Jared Camins-Esakov --- Created attachment 24566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24566&action=edit Bug 10402 follow-up: fix perlcritic exception Perlcritic doesn't like the syntax keys $variable, and requires that you explicitly dereference a hashref to a hash before using keys. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:46:35 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23376|0 |1 is obsolete| | --- Comment #55 from Jared Camins-Esakov --- Created attachment 24567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24567&action=edit Bug 10402 follow-up: choose contacts for serials and acq claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Run the unit test with: > prove t/db_dependent/Letters.t 5) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 05:46:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 04:46:57 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23377|0 |1 is obsolete| | --- Comment #56 from Jared Camins-Esakov --- Created attachment 24568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24568&action=edit Bug 10402: correct number of tests When merging t/db_dependent/Bookseller.t, the number of tests listed was not changed, causing the test to fail with too many tests. All patches rebased on master 2014/01/19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 06:00:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 05:00:18 +0000 Subject: [Koha-bugs] [Bug 8777] Quiet errors in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8777 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from M. Tompsett --- I believe bug 11182 closed the final ones remaining. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 07:56:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 06:56:50 +0000 Subject: [Koha-bugs] [Bug 11564] Sorting any search on a date column fails! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Kyle, might be good to check - does it behave the same with and without QueryParser? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 07:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 06:59:08 +0000 Subject: [Koha-bugs] [Bug 11528] TrackClicks feature messes up proxied EBSCO e-books links? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I have been thinking, is the link catalogued in the record correct? It seems strange that the feature would send it to another database - I was thinking maybe someone used jQuery there to change the URLs on the fly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 08:03:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 07:03:37 +0000 Subject: [Koha-bugs] [Bug 11519] Keep local MARC tags during data import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am quite sure there already is a bug with some patches for a feature like that, but I don't manage to find it this morning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 08:21:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 07:21:01 +0000 Subject: [Koha-bugs] [Bug 11519] Keep local MARC tags during data import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11519 --- Comment #2 from Katrin Fischer --- I think bug 10477 might allow to do this, but not marking this duplicate as I am not completely sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 09:39:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 08:39:24 +0000 Subject: [Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which require it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108 --- Comment #21 from Fridolin SOMERS --- (In reply to David Cook from comment #20) No problem, thanks for trying -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 09:44:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 08:44:33 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #55 from mathieu saby --- I made some tests. Without my patch: 1. with QP enable pubdate(1925) is working pubdate:1925 is working 2. with QP disable pubdate(1925) is not working pubdate:1925 is not working With my patch: Exactly the same behavior So, for me, the patch is correct, regarding pubdate index. It is not possible to build a query with pubdate without QP, but it was still the case in master. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 09:45:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 08:45:36 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #56 from Katrin Fischer --- Oh, that explains. It seems it's possible with MARC21 - what are we missing to make it work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 09:49:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 08:49:51 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #57 from mathieu saby --- I was always said not to use pubdate index like that, so the issue is old, but maybe unimarc specific. It is working only when you use a date in the advanced search filter see comment 30 By the way: If you or Galen ask it, I can try to split the patch, with non functional changes (comments...) in a separate patch. But I prefer not to, if it is not required, because - I could do a mistake and break the patch, - I won't have time to work on Koha this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 09:56:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 08:56:41 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #13 from mathieu saby --- (In reply to Katrin Fischer from comment #11) > Actually, this is quite interesting and confusing to me. > > Libraries here have to pay the tax, so I would expect the budgeted cost to > include a calculated tax, if list prices are tax exclusive. Shouldn't the > tax rate influence the prices in some way? I couldn't see that whatever > combinatoin I tried. > > Budgeted cost and replacement cost being the same tax setting as the list > price seems currently correct. This bug is not supposed to fix anything, just to make clearer for the user the current behavior of Koha But yes, there is a LOT of issues regarding taxes. Lyon 3 university is planning some improvements. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 09:57:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 08:57:51 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 --- Comment #9 from M. de Rooy --- (In reply to Galen Charlton from comment #8) > Marking failed QA for the regressions. thx for scrutiny++ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 10:14:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 09:14:22 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #58 from Katrin Fischer --- I think the pubdate index does not block this patch then - I will take another look at it later (if noone beats me to it :) ). Maybe you could file a bug for the pubdate index in UNIMARC and link to this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 10:22:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 09:22:40 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #33 from M. de Rooy --- (In reply to mathieu saby from comment #32) > Well, you may be right ;-) > I thought it was a good thing to have as less parameters as possible, to > make the code in .pl files more simple. But it was maybe a bad idea, for > performance reasons. > The code without this followup was working well (not sure it is still the > case), and was signed off. Paul failed QA in comment 17, but I answer him in > comment 19. > If you think the followup is not needed, I can obsolete it, and put back the > bug in "Signed off" state. I would suggest to combine them, since the followup also includes a unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 10:32:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 09:32:26 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 10:32:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 09:32:34 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24457|0 |1 is obsolete| | --- Comment #111 from Jonathan Druart --- Created attachment 24569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24569&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 10:32:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 09:32:52 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #112 from Jonathan Druart --- Created attachment 24570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24570&action=edit Bug 10855: Additional marc fields are not inserted In subscription-add.pl, the code for inserting additional_fields is not the same for updating and inserting. This patch refactores this code in code to do the same tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 10:34:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 09:34:46 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #113 from Jonathan Druart --- (In reply to Paola Rossi from comment #110) > I apply the patch against master 3.15.00.012. > > Adding a new subscription, after saving, the marc additional field is not > automatically filled with the specified marc field of the notice. Good catch! A previous change did not affect the subscription creation, only modification. It should work with the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:00:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:00:29 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23955|0 |1 is obsolete| | Attachment #23956|0 |1 is obsolete| | Attachment #23957|0 |1 is obsolete| | Attachment #23958|0 |1 is obsolete| | Attachment #23959|0 |1 is obsolete| | Attachment #23960|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart --- Created attachment 24571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24571&action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:00:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:00:38 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #55 from Jonathan Druart --- Created attachment 24572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24572&action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:00:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:00:45 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #56 from Jonathan Druart --- Created attachment 24573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24573&action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:00:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:00:51 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #57 from Jonathan Druart --- Created attachment 24574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24574&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:00:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:00:58 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #58 from Jonathan Druart --- Created attachment 24575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24575&action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:01:04 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #59 from Jonathan Druart --- Created attachment 24576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24576&action=edit Bug 9016: QA Followup Fix tab characters and POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:02:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:02:07 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #60 from Jonathan Druart --- (In reply to Kyle M Hall from comment #53) > I'm having issues with the final patch. Is this a problem with the patch or > just me? I don't know, I just got a conflict on updatedb.pl I rebased patches, maybe it could fix your problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:07:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:07:24 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:07:29 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #36 from Jonathan Druart --- Created attachment 24577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24577&action=edit Bug 10212: FIX QA issues FAIL Koha/Template/Plugin/ColumnsSettings.pm FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 20) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:39:05 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:39:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:39:11 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #102 from Jonathan Druart --- Created attachment 24578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24578&action=edit Bug 7825: QA followup - preselection of items This patch changes the default behavior for the 'force' value. If the pref is set to force, no item is preselected and the item list is shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:39:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:39:20 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #103 from Jonathan Druart --- Created attachment 24579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24579&action=edit Bug 7825: QA followup - preselection of items (bootstrap) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:39:28 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #6 from Benjamin Rokseth --- Hi, (In reply to Galen Charlton from comment #5) > (In reply to Chris Cormack from comment #4) > > So it might be good to do all the work fixing the config file for 2.4 on > > this? > > I agree, so I've changed the title of the bug accordingly. Chris Cormack is right, starting from a clean Ubuntu Saucy install, using Apache 2.4.6, I got problems with the mpm_event module and AssignUserId: http://mpm-itk.sesse.net/ Seems there is a problem from 2.2.2 until 2.4.7 http://debian.2.n7.nabble.com/mpm-itk-and-mod-fcgid-td3014876.html my quick fix was to swap the mpm_event and mpm_itk : sudo a2dismod mpm_event sudo a2enmod mpm_itk As for the .conf issue in Apache 2.4.6+, perhaps it is better to change to .conf altogether, if it won't break previous versions? Regards Benjamin Rokseth Oslo Public Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:40:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:40:31 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #104 from Jonathan Druart --- (In reply to Katrin Fischer from comment #101) Hi Katrin, The 2 last patches fix your request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:47:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:47:50 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 --- Comment #7 from Magnus Enger --- (In reply to Benjamin Rokseth from comment #6) > As for the .conf issue in Apache 2.4.6+, perhaps it is better to change to > .conf altogether, if it won't break previous versions? There are some scripts that assume the Apache config files are named witt just the instance name, without a .conf extension, so those will have to be updated too. But I agree, we might as well do this sooner rather than later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 11:53:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 10:53:23 +0000 Subject: [Koha-bugs] [Bug 9514] 'and' in subject searches causes a problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9514 fatma karam changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fatma.karam at fa-hists.edu.eg -- You are receiving this mail because: You are watching all bug changes. From andrea.furin at slacky.it Mon Jan 20 12:28:45 2014 From: andrea.furin at slacky.it (Andrea Furin) Date: Mon, 20 Jan 2014 12:28:45 +0100 Subject: [Koha-bugs] VERY URGENT: automatically redirection to searching page Message-ID: <52DD086D.8090008@slacky.it> After upgrading to koha 3.14.01.1-1 If I try to add a copy typing something from: http://localhost:8282/cgi-bin/koha/cataloguing/additem.pl?biblionumber=14#additema&searchid=nRPf4fIu browser goes to advanced search page: http://localhost:8282/cgi-bin/koha/catalogue/search.pl -- -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 5615 bytes Desc: not available URL: From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 13:23:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 12:23:37 +0000 Subject: [Koha-bugs] [Bug 11585] New: pubdate index not working well in UNIMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11585 Bug ID: 11585 Summary: pubdate index not working well in UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org Without Queryparser, pubdate index is not searchable in unimarc. the query "pubdate:1925" in simple search box gives 0 results, even if we have a book of 1925. It is working well with Queryparser activated. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 13:23:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 12:23:51 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #59 from mathieu saby --- Bug 11585 created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 14:15:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 13:15:04 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |h.meissner.82 at web.de Assignee|kyle.m.hall at gmail.com |h.meissner.82 at web.de --- Comment #3 from Holger Mei?ner --- Assigned this to myself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 15:44:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 14:44:05 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 15:44:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 14:44:13 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #42 from Tom?s Cohen Arazi --- Created attachment 24580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24580&action=edit Bug 11096: (qa followup) facets count and UNIMARC record syntax - An error in a copy and paste operation made me count facet occurences instead of records where the fields where present. - As of bug 3087 UNIMARC uses the 'unimarc' record syntax. I assumed 'usmarc' was used as serialization format as thought it was dialect-agnostic. This patch adds a test of whether we are in UNIMARC context or not and sets the record syntax to match the one from koha-conf.xml. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 17:25:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 16:25:07 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #6 from Jonathan Druart --- Created attachment 24581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24581&action=edit Bug 10827: Regression tests The unit tests in the file db_dependent/Reserves/priorities.t describe the issue. To reproduce using the interface: - Create 3 patrons A, B and C - Check an item out to A - Place a hold on this item for B and C - Check the item in - Confirm the hold - Verify the hold list: The item is waiting for B and C has a priority 2 - Delete the hold for B - Now you can see the item is not waiting for C. He has not been notified neither. If you apply all patches from this bug, at the next ste, the item is marked as waiting for C and C has been notified when the hold for B has been deleted. /!\Important note: This patch only manages item-level holds! The commented UT is for biblio-level holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 17:25:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 16:25:26 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #8 from Jonathan Druart --- Created attachment 24583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24583&action=edit Bug 10827: Check if the item should be transfered in ModReserveAffect Before this patch, ModReserveAffect should know if the item have to be transfered. Now it is checked in the routine. Moreover, it is possible to pass an item key in parameters. If it is not given, the item's information is retrieved from GetBiblioFromItemNumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 17:25:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 16:25:19 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #7 from Jonathan Druart --- Created attachment 24582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24582&action=edit Bug 10827: Change prototype for ModReserveAffect This patch only changes the prototype for C4::Reserves::ModReserveAffect. This modification will allow to simplify future changes. No change should be expected with this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 17:25:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 16:25:32 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #9 from Jonathan Druart --- Created attachment 24584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24584&action=edit Bug 10827: Update item-level holds if deletion If a lower level priority hold is deleted, the next on the list should be marked as 'waiting' and the patron notified. This patch only affects item-level holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 17:25:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 16:25:37 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #10 from Jonathan Druart --- Created attachment 24585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24585&action=edit Bug 10827: destBranch tt param is useless With previous changes, the destBranch passed to the template become useless and can be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 17:28:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 16:28:15 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #11 from Jonathan Druart --- Easy to reproduce but not easy to fix. I really would like to have some feedback. I did not manage to deal with biblio-level holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 17:28:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 16:28:26 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 18:33:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 17:33:55 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #12 from bondiurbano --- Jonathan, I don't know how biblio-level works about reserves because I can't imagine this. It doesn't seem relevant for reserves. I can't think how a biblio may be reserved.. Reserves are referred to holding's barcode, i.e., at item-level. The difference between reserves and regular issues is that reserves are not involved in circulation rules as fines policy are (that is where biblio-level may fit..). They work independently. Reserves and fines have no relation between them. Both are included in each circulation rule but it's a design matter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 19:16:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 18:16:06 +0000 Subject: [Koha-bugs] [Bug 11586] New: Better defaults for UNIMARC items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Bug ID: 11586 Summary: Better defaults for UNIMARC items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: gaetan.boisson at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On a clean (french) UNIMARC install, a large number of subfields are not configured for items, or not properly linked. It can mean several features are not available by default, and the user has to do some extra configuration to get them working. I am not sure yet if the chosen language has an influence on this set-up. The linked subfields are : 995$9 items.itemnumber 995$b items.homebranch 995$c items.holdingbranch 995$e items.location 995$f items.barcode 995$j items.stocknumber 995$k items.itemcallnumber 995$n items.onloan 995$o items.notforloan 995$r items.itype 995$u items.itemnotes Here is a suggestion to make this more complete : 995$1 items.cn_source 995$4 items.damaged (linked to the appropriate AV list) 995$8 items.coded_location_qualifier 995$a items.booksellerid 995$d items.datelastseen 995$g items.replacementprice 995$i items.replacementpricedate 995$p items.price 995$s items.cn_sort (with the appropriate zebra configuration done) 995$t items.stack 995$w items.issues 995$x items.renewals 995$y items.reserves 995$z items.nonpublicnote 995$0 items.withdrawn (linked to the appropriate AV list) 995$2 items.itemlost (linked to the appropriate AV list) 995$3 items.restricted 995$5 items.dateaccessioned (linked to the appropriate plugin) 995$6 items.copynumber 995$7 items.uri 995$h items.ccode (linked to the appropriate AV list) 995$l items.materials 995$m items.datelastborrowed 995$v items.enumchron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 22:36:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 21:36:56 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #3 from Fr?d?rick Capovilla --- The bug you encountered seems to be an indexation problem. If the zebra index wasn't rebuild between the authority creation and the linkage attempt, the new authority record won't be found by the linker. On our instances we use a deamon which automatically rebuilds the Zebra index when a new record is added to the queue. Could anyone test this feature again and rebuild the zebra index once the new authority is added? Also, the automatic linking should work on existing authorities that were already indexed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 20 23:09:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Jan 2014 22:09:42 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22175|0 |1 is obsolete| | Attachment #22430|0 |1 is obsolete| | --- Comment #22 from Blou --- Created attachment 24586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24586&action=edit Bug 8753 - Add forgot password link to OPAC This includes fix following the most recent comments, as well as full bootstrap and rebasing to 3.15. TEST PLAN: 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. That will cause the link 'Forgot your password' to show up on the welcome page, below connection box. 3) refresh front page, click on 'Forgot your password' and enter a VALID address (one that is associated to an entry in borrowers.email or borrowers.email_pro. 3b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 4) An email should be received at that address with a link. 5) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 6) Go to main page try the new password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 02:11:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 01:11:51 +0000 Subject: [Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall at gmail.com |wizzyrea at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 04:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 03:59:08 +0000 Subject: [Koha-bugs] [Bug 9858] Add button in "Search Engine Configuration" is not working. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9858 --- Comment #4 from Samuel Crosby --- (In reply to Hend from comment #3) > Currently , i could add a new search index through the staff client. But as > you had said it's not added to indexes.yaml. Does it allow for you to save once you've added the new index? Or does it go to an error screen? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 06:24:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 05:24:47 +0000 Subject: [Koha-bugs] [Bug 11587] New: IsSuperLibrarian generates warnings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Bug ID: 11587 Summary: IsSuperLibrarian generates warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org If userenv->{flags} is undefined, the modulus 2 generates floody entries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 06:30:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 05:30:52 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #18 from Katrin Fischer --- Hi Jonathan, I have some fails in the QA script, but not sure what it means: FAIL C4/Serials.pm OK pod OK forbidden patterns FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context OK critic Could you take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 06:31:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 05:31:04 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 06:50:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 05:50:33 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 06:50:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 05:50:36 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 --- Comment #1 from M. Tompsett --- Created attachment 24587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24587&action=edit Bug 11587 - IsSuperLibrarian generates warnings This corrects line 1250 of C4/Context.pm to be: return ($userenv->{flags}//0) % 2; And thus avoids an uninitialized value used in the modulus. TEST PLAN --------- 1) Apply the first patch (to update t/Context.t) 2) prove -v t/Context.t -- This should fail tests 7 and 8 3) Apply this patch (to fix C4/Context.pm) 4) prove -v t/Context.t -- All tests should succeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 06:51:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 05:51:10 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24587|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 24588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24588&action=edit Bug 11587 - IsSuperLibrarian generates warnings Simply viewing OPAC detail triggers a modulus warning entry. This first patch adds two test cases to t/Context.t to test for this situation. TEST PLAN --------- 1) Apply this patch (to upgrade t/Context.t) 2) prove -v t/Context.t -- Tests 7 and 8 will fail 3) Apply second patch (to amend C4/Context.pm) 4) prove -v t/Context.t -- All tests will succeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 06:51:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 05:51:20 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 --- Comment #3 from M. Tompsett --- Created attachment 24589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24589&action=edit Bug 11587 - IsSuperLibrarian generates warnings This corrects line 1250 of C4/Context.pm to be: return ($userenv->{flags}//0) % 2; And thus avoids an uninitialized value used in the modulus. TEST PLAN --------- 1) Apply the first patch (to update t/Context.t) 2) prove -v t/Context.t -- This should fail tests 7 and 8 3) Apply this patch (to fix C4/Context.pm) 4) prove -v t/Context.t -- All tests should succeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 06:54:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 05:54:10 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 07:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 06:02:26 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 07:02:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 06:02:29 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24560|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 24590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24590&action=edit [PASSED QA] Bug 11313 - empty value in mandatory combobox in record edition In biblio (or authority) record edition or creation, Bug 3727 added an empty value to combobox for subfield using itemtype authorized values, which is mandatory and does not have a default value. This to avoid selecting arbitrarily the first value of combo. This patch extends this behavior to normal authorized values like CCODE, COUNTRY ... Also, when record already exists and has a defined value for the subfield this value will be selected in combobox so there is no need for an empty value. Test plan : - In a biblio framework, set a subfield mandatory and using itemtypes authorised values - Set a default value for this subfield - Create a new record with the framework => You see the subfield with a combobox, the first empty value is selected - Go to biblio framework and set a default value for the subfield - Create a new record with the framework => You see the subfield with a combobox, the default value is selected and there is no empty value - Select an other value and save the record - Edit this record => You see the subfield with a combobox, the saved value is selected and there is no empty value Perform same tests with a normal authorized values categorie (instead of itemtypes). Perform same tests with with authority creation/edition Perform same tests with a normal authorized values categorie and authority creation/edition Signed-off-by: David Cook Works as described. Fridolyn: I had a lot of difficulty understanding your test plan, especially since the second line should not be in the test plan (since if there is a default value, no empty value should appear). Perhaps it would be useful to use more whitespace to separate steps and the things for which a tester should check. Also, it might be useful to specify what testers should check for before and after applying the patch, so that they're sure that the behaviour has been corrected. In any case, the patch works! Certainly a helpful addition. Signed-off-by: Katrin Fischer Passes all tests and QA script. 1) Adding a bibliographic record Subfield is mandatory, no default value: - adding record: no value is preselected, empty value exists - editing record: saved value is shown, empty value exists Subfield is mandatory, defined default value: - adding record: default is preselected, no empty value - editing record: saved value is shown, no empty value exists Subfield is not mandatory, defined default value: - adding record: default is preselected, empty value exists - editing record: saved value is shown, emtpy value exists Subfield is not mandatory, no default value: - adding record: empty value is preselected - editing record: saved value is shown, empty value exists 2) Adding an authority record Repeating tests from above. - Subfield is mandatory, no default value: OK - Subfield is mandatory, defined default value: OK - Subfield is not mandatory, defined default value: OK - Subfield is not mandatory, no default value: OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 07:46:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 06:46:32 +0000 Subject: [Koha-bugs] [Bug 11588] New: Untranslatable subscription frequency units Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588 Bug ID: 11588 Summary: Untranslatable subscription frequency units Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When eg. editing or creating a new subscription frequency, a drop-down lists the possible units for the frequency. These are not translatable, as they're hard-coded eg. in GetFictiveIssueNumber() in C4/Serials.pm ('day', 'week', 'month', 'year') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 08:11:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 07:11:39 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 08:11:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 07:11:44 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24578|0 |1 is obsolete| | Attachment #24579|0 |1 is obsolete| | --- Comment #105 from Katrin Fischer --- Created attachment 24591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24591&action=edit [PASSED QA] Bug 7825: QA followup - preselection of items This patch changes the default behavior for the 'force' value. If the pref is set to force, no item is preselected and the item list is shown. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 08:11:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 07:11:59 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #106 from Katrin Fischer --- Created attachment 24592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24592&action=edit [PASSED QA] Bug 7825: QA followup - preselection of items (bootstrap) Signed-off-by: Katrin Fischer Passes all tests and QA script. Retested with all 3 themes, works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 08:13:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 07:13:13 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #107 from Katrin Fischer --- Hi Jonathan, thx for taking my suggestions into account. It works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 09:27:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 08:27:23 +0000 Subject: [Koha-bugs] [Bug 11589] New: Sample serial frequencies do not match template frequencies Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11589 Bug ID: 11589 Summary: Sample serial frequencies do not match template frequencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org The sample serial subscription frequencies do not match the frequencies shown in OPAC or staff client. For example, freq 1 is '2/day', but is shown as "issued every day" in OPAC/staff client. Freq 2 is '1/day', and shows up as "issued every week". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 09:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 08:39:37 +0000 Subject: [Koha-bugs] [Bug 9858] Add button in "Search Engine Configuration" is not working. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9858 --- Comment #5 from Hend --- Yes, it allows me . I put the index information and click add then i click save. I don't get an error screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 09:55:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 08:55:26 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #13 from Jonathan Druart --- (In reply to bondiurbano from comment #12) A biblio-level hold is a reserve on the next available item. An item-level hold is a reserve on a specific item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 10:10:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 09:10:24 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 10:10:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 09:10:28 +0000 Subject: [Koha-bugs] [Bug 10851] Add missing statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 --- Comment #19 from Jonathan Druart --- Created attachment 24593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24593&action=edit Bug 10851: FIX QA issues This patch fixes following warnings: FAIL C4/Serials.pm FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 10:51:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 09:51:30 +0000 Subject: [Koha-bugs] [Bug 11586] Better defaults for UNIMARC items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 12:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 11:31:43 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #14 from bondiurbano --- (In reply to Jonathan Druart from comment #13) > (In reply to bondiurbano from comment #12) > A biblio-level hold is a reserve on the next available item. > An item-level hold is a reserve on a specific item. Ok Jonathan, thanks for the information. The important matter is that priority "Waiting" always refers to an item because an item has just been checked-in. Look at the document I uploaded: step 2 says "next available" but step 4 ("Waiting" priority) says barcode 200. So when a reserve in priority "Waiting" for barcode 200 is deleted or cancelled next reserve in the holds queue should be updated to priority "Waiting" for barcode 200 for the next patron. There's no confusion about it. At this point difference between biblio or item level should be irrelevant. The program must procedure at item level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 12:47:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 11:47:06 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #15 from Jonathan Druart --- Kyle, could you give me your opinion on the solution I proposed please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 12:58:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 11:58:47 +0000 Subject: [Koha-bugs] [Bug 11441] Ability to globally remove authorities with no bibliographic record linked. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11441 Juan Romay Sieira changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |juan.sieira at xercode.es Assignee|gmcharlt at gmail.com |juan.sieira at xercode.es --- Comment #2 from Juan Romay Sieira --- Created attachment 24594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24594&action=edit Bug 11441 - Ability to globally remove authorities with no bibliographic record linked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 13:06:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 12:06:20 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #16 from bondiurbano --- (In reply to bondiurbano from comment #14) > (In reply to Jonathan Druart from comment #13) > > (In reply to bondiurbano from comment #12) > > A biblio-level hold is a reserve on the next available item. > > An item-level hold is a reserve on a specific item. > > Ok Jonathan, thanks for the information. The important matter is that > priority "Waiting" always refers to an item because an item has just been > checked-in. Look at the document I uploaded: step 2 says "next available" > but step 4 ("Waiting" priority) says barcode 200. So when a reserve in > priority "Waiting" for barcode 200 is deleted or cancelled next reserve in > the holds queue should be updated to priority "Waiting" for barcode 200 for > the next patron. There's no confusion about it. At this point difference > between biblio or item level should be irrelevant. The program must > procedure at item level. Jonathan, a tip: now, when a reserve with priority "Waiting" is deleted or cancelled you can check-in the item AGAIN, Koha will ask for confirmation and next reserve in the holds queue is updated correctly!! Yes, it is possible to check-in items not issued but with reserves in holds queue... 1) Delete or cancel "Waiting" priority reserve 2) Check-in the item again 3) Confirm reserve for next patron 4) Priority for next patron reserve is updated correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 13:19:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 12:19:43 +0000 Subject: [Koha-bugs] [Bug 11561] Preventing duplicate print notices and enforcing a print notice if no notices can be generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 13:35:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 12:35:58 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #17 from Kyle M Hall --- (In reply to bondiurbano from comment #14) > (In reply to Jonathan Druart from comment #13) > > (In reply to bondiurbano from comment #12) > > A biblio-level hold is a reserve on the next available item. > > An item-level hold is a reserve on a specific item. > > Ok Jonathan, thanks for the information. The important matter is that > priority "Waiting" always refers to an item because an item has just been > checked-in. Look at the document I uploaded: step 2 says "next available" > but step 4 ("Waiting" priority) says barcode 200. So when a reserve in > priority "Waiting" for barcode 200 is deleted or cancelled next reserve in > the holds queue should be updated to priority "Waiting" for barcode 200 for > the next patron. There's no confusion about it. At this point difference > between biblio or item level should be irrelevant. The program must > procedure at item level. If I am interpreting your assertion correctly, you are incorrect. You are only looking at a single possible scenario. What if the next hold is for pickup at a different library, what if the next hold is cannot be filled by this item because of issuing rules? We cannot simply assume the next hold can be filled automatically by a canceled waiting hold item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 13:38:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 12:38:10 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #18 from Kyle M Hall --- (In reply to bondiurbano from comment #14) > > So when a reserve in > > priority "Waiting" for barcode 200 is deleted or cancelled next reserve in > > the holds queue should be updated to priority "Waiting" for barcode 200 for > > the next patron. There's no confusion about it. At this point difference > > between biblio or item level should be irrelevant. The program must > > procedure at item level. I should also mention Koha has *never* automatically set a hold to waiting. It has always been a manually triggered process where a library checks in an item, and chooses to trap the item for the hold request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 13:44:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 12:44:00 +0000 Subject: [Koha-bugs] [Bug 11586] Better defaults for UNIMARC items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 --- Comment #1 from Gaetan Boisson --- I might have tried too hard to link every single field in the database. The idea is that we might as well link everything, and rename the field if we need to recycle it. Since this means adding a number of fields that are not necessary to most users, or which don't even make sense in unimarc, i suggest hiding them by default. The configuration will exist and recycling the fields will be easy. Here's a corrected suggestion : 995$1 items.cn_source (linked to the appropriate AV list - which is technically not an AV list but you can chose it in the dropdown when configuring the subfield) 995$4 items.damaged (linked to the appropriate AV list) 995$8 items.coded_location_qualifier (should be hidden, doesn't exist in unimarc) 995$a items.booksellerid 995$d items.datelastseen (should be hidden in the editor, since the user shouldn't be able to change this himself) 995$g items.replacementprice 995$i items.replacementpricedate 995$p items.price 995$s items.cn_sort (with the appropriate zebra configuration done. This field should be completely hidden as it is only functionnal) 995$t items.stack (should be hidden, doesn't exist in unimarc) 995$w items.issues (should be hidden in the editor, since the user shouldn't be able to change this himself) 995$x items.renewals (should be hidden in the editor, since the user shouldn't be able to change this himself) 995$y items.reserves (should be hidden in the editor, since the user shouldn't be able to change this himself) 995$z items.nonpublicnote 995$0 items.withdrawn (linked to the appropriate AV list) 995$2 items.itemlost (linked to the appropriate AV list) 995$3 items.restricted 995$5 items.dateaccessioned (linked to the appropriate plugin) 995$6 items.copynumber (should be hidden in the editor as it doesn't make sense by default) 995$7 items.uri (should be hidden in the editor as it doesn't make sense by default) 995$h items.ccode (linked to the appropriate AV list) 995$l items.materials 995$m items.datelastborrowed (should be hidden in the editor, since the user shouldn't be able to change this himself) 995$v items.enumchron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 13:46:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 12:46:32 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #19 from Jonathan Druart --- (In reply to Kyle M Hall from comment #18) > I should also mention Koha has *never* automatically set a hold to waiting. But should it be managed or not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 14:05:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 13:05:56 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #20 from bondiurbano --- Kyle, read "my" tip in comment #16. I had never said that it was a simple matter. I'd tried to focus on "priority concept". (Im not a programmer). I'm not assuming only one scenario. When the next hold is tried to be updated (to priority "Waiting") it enters in regular basis of control as a reserve creation is done when an item is checked-in. So it may be possible or not to update the priority. It depends on the same factors that checked-in items depends. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 14:23:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 13:23:12 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 14:24:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 13:24:59 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10482 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 14:24:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 13:24:59 +0000 Subject: [Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11096 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 15:42:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 14:42:15 +0000 Subject: [Koha-bugs] [Bug 11590] New: Librarian able to checkout item without setting branch first Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Bug ID: 11590 Summary: Librarian able to checkout item without setting branch first Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It is possible to begin circulating items to a patron without first setting your logged in branch! To recreate: 1) From the "Search patrons" quick search, search for any patron 2) From this patron's details screen, click the "Check out" quick search and put in a valid patron cardnumber 3) You are now able to issue items to this patron without having set your logged in branch. Video example: http://screencast.com/t/xvzRb8zYf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 15:42:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 14:42:33 +0000 Subject: [Koha-bugs] [Bug 11590] Librarian able to checkout item without setting branch first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 15:45:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 14:45:11 +0000 Subject: [Koha-bugs] [Bug 11590] Librarian able to checkout item without setting branch first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 --- Comment #1 from Kyle M Hall --- Created attachment 24595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24595&action=edit Bug 11590 - Librarian able to checkout item without setting branch first It is possible to begin circulating items to a patron without first setting your logged in branch! Test Plan: 1) From the "Search patrons" quick search, search for any patron 2) From this patron's details screen, click the "Check out" quick search and put in a valid patron cardnumber 3) You are now able to issue items to this patron without having set your logged in branch. 4) Apply this patch 5) Repeat steps 1-2, you should now be redirected to select a branch instead of being taken directly to circulation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 15:45:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 14:45:08 +0000 Subject: [Koha-bugs] [Bug 11590] Librarian able to checkout item without setting branch first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 16:25:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 15:25:28 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #10 from Blou --- Created attachment 24596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24596&action=edit Conflicts: installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 16:28:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 15:28:17 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #11 from Blou --- Created attachment 24597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24597&action=edit Bug 10937 - Option to hide and group itemtypes from advanced search Sponsor: Vanier college Added bootstrap theme same instructions. SETUP 0) run updatedatabase.pl to add the two columns to itemtypes 1) You need to add a category to group your item types: a) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the category dropdown b) Click button "New authorized value for DOCTYPECAT" c) Enter Authorized value: HARDWARE Description : Hardware Description (OPAC): Hardware NORMAL USAGE 2) Group your items under that new category a) In Intranet/Koha Admin/Item types, choose (at least) two item types and for each: - Click action/Edit on the right column - Third row (below Description) is the Search category list box, select Hardware - click Save changes at the bottom 3) Select at least one item to be hidden in the OPAC search a) In Intranet/Koha Admin/Item types (again), choose a different item type: - Click action/Edit - Click the checkbox "Hide in OPAC" below the list of icons. FINAL TESTING 4) Go test your modifications a) Go to OPAC/Adv search. b) Validate that all items modified above (hidden or grouped) do not appear in Item type list c) Validate that new item type Hardware does appear instead. d) Select item Hardware, start Search. e) Validate returned items are the of the two types that were grouped into the Hardware category in step 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 16:29:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 15:29:04 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24596|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 16:29:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 15:29:35 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 16:47:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 15:47:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 16:48:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 15:48:34 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 17:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 16:01:38 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #43 from Jonathan Druart --- Sorry Tom?s, bad news. I get the 'Can't call method "data" on an undefined value' error with and without the last patch. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 17:31:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 16:31:30 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Chris Rohde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 17:37:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 16:37:14 +0000 Subject: [Koha-bugs] [Bug 11590] Librarian able to checkout item without setting branch first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 17:49:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 16:49:10 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 17:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 16:59:57 +0000 Subject: [Koha-bugs] [Bug 11591] New: runtime parameter for library groups Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11591 Bug ID: 11591 Summary: runtime parameter for library groups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Would be great to have a runtime parameter for groups of libraries as they are set in the libraries & groups menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 18:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 17:40:37 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 --- Comment #16 from Nicole C. Engard --- Not all of those typos were in the manual - but I have fixed the ones that were. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 20:13:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 19:13:50 +0000 Subject: [Koha-bugs] [Bug 11258] Holds queue is still making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258 Mickey Coalwell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcoalwell at nekls.org --- Comment #6 from Mickey Coalwell --- I set up test plan in production as described in ticket. Results positive. Available item with Local Hold was correctly x'ed out in holdings table, and hold did not show up on pick list for patron wanting pickup location at owning library. Checked in another item without hold restriction, which DID show up correctly on pick list. So the behavior is now as expected, and desired. Patch eliminated bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 21:51:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 20:51:45 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17892|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 24598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24598&action=edit Bug 8735 - Expire holds waiting only on days the library is open Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 21:52:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 20:52:10 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 21:52:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 20:52:13 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17893|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 24599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24599&action=edit Bug 8735 - Expire holds waiting only on days the library is open - Followup - Switch from C4::Calendar to Koha::Calendar Test Plan: 1) Set ExpireReservesMaxPickUpDelay 2) Set ReservesMaxPickUpDelay to 1 3) Place a hold, set it to waiting 4) Using the MySQL console, modify the waiting date and set it to the day before yesterday. 5) Set today as a holiday for the pickup branch in question. 6) Run misc/cronjobs/holds/cancel_expired_holds.pl 7) The hold should remain unchanged 8) Remove today as a holiday 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again 10) The hold should now be canceled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 22:30:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 21:30:24 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #4 from M. Tompsett --- Silly default of enhancement! DOH! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 22:41:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 21:41:31 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #44 from Tom?s Cohen Arazi --- Jonathan, can u tell me how is your setup? Specifically in koha-conf.xml do you have: ? or I assume you have this in your config section: grs1 dom -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 21 23:07:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Jan 2014 22:07:51 +0000 Subject: [Koha-bugs] [Bug 11590] Librarian able to checkout item without setting branch first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #2 from Robin Sheat --- The giant warning saying that you shouldn't do that indicates that you shouldn't do that. A better fix is is to make that warning a bit more compulsory, e.g. cutting off access to functions that aren't related to configuration/management if you're the database user. Maybe also make the warning bigger and having blinking marqueed text so it doesn't get ignored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 06:06:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 05:06:04 +0000 Subject: [Koha-bugs] [Bug 11592] New: opac-detail.pl and opac-MARCdetail.pl do not respect marc tag visibility Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Bug ID: 11592 Summary: opac-detail.pl and opac-MARCdetail.pl do not respect marc tag visibility Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org It is possible to change the visibility in OPAC by affecting the value of hidden in marc_subfield_structure (Home->Administration->MARC frameworks->BKS Subfields -> ... -> Advanced Constraints -> Uncheck/Check OPAC). opac-MARCdetail.pl, for the most part, respects it, but if things normally displayed in opac-detail.pl are marked as not having visibility in OPAC (unchecked), they are still displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 06:12:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 05:12:20 +0000 Subject: [Koha-bugs] [Bug 11592] opac-detail.pl and opac-MARCdetail.pl do not respect marc tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 06:30:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 05:30:42 +0000 Subject: [Koha-bugs] [Bug 11592] opac-detail.pl and opac-MARCdetail.pl do not respect marc tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 06:30:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 05:30:44 +0000 Subject: [Koha-bugs] [Bug 11592] opac-detail.pl and opac-MARCdetail.pl do not respect marc tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #1 from M. Tompsett --- Created attachment 24600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24600&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. Lastly, opac-showmarc now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 06:31:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 05:31:18 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-detail.pl and |opac scripts do not respect |opac-MARCdetail.pl do not |MARC tag visibility |respect marc tag visibility | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 06:33:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 05:33:21 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24600|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 24601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24601&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. Lastly, opac-showmarc now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 06:41:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 05:41:24 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #3 from M. Tompsett --- Still to do: Add tests for new functions to C4/Biblio. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 08:05:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 07:05:27 +0000 Subject: [Koha-bugs] [Bug 11593] New: subtag_registry.sql files contain the same information for each language Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11593 Bug ID: 11593 Summary: subtag_registry.sql files contain the same information for each language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr For each language in the installation, there's a mandatory subtag_registry.sql -file, that contains the language names. Each of those files contain the same language information. This is unnecessary duplication, and makes adding new install languages harder, because the same information needs to be added to each of those files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 09:34:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 08:34:42 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #45 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #44) > Jonathan, can u tell me how is your setup? Specifically in koha-conf.xml do > you have: > > > > ? or > > > > I assume you have this in your config section: > > grs1 > dom Hum, I did not have the zebra_bib_index_mode defined. In your patch, in C4::Search the test is done on zebra_bib_index_mode eq 'dom' but in C4::Context it is done on 'grs1'. I think it should be done every where on 'dom'. That way, if the value does not exist, we assume it is a dom instance. Tom?s, please signoff if you agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 09:35:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 08:35:39 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24580|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 24602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24602&action=edit Bug 11096: (qa followup) facets count and UNIMARC record syntax - An error in a copy and paste operation made me count facet occurences instead of records where the fields where present. - As of bug 3087 UNIMARC uses the 'unimarc' record syntax. I assumed 'usmarc' was used as serialization format as thought it was dialect-agnostic. This patch adds a test of whether we are in UNIMARC context or not and sets the record syntax to match the one from koha-conf.xml. Regards To+ Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 09:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 08:35:46 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #47 from Jonathan Druart --- Created attachment 24603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24603&action=edit Bug 11096: If zebra_bib_index_mode is not defined, assume it is grs1. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 09:48:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 08:48:13 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #34 from mathieu saby --- (In reply to M. de Rooy from comment #33) > (In reply to mathieu saby from comment #32) > > Well, you may be right ;-) > > I thought it was a good thing to have as less parameters as possible, to > > make the code in .pl files more simple. But it was maybe a bad idea, for > > performance reasons. > > The code without this followup was working well (not sure it is still the > > case), and was signed off. Paul failed QA in comment 17, but I answer him in > > comment 19. > > If you think the followup is not needed, I can obsolete it, and put back the > > bug in "Signed off" state. > > I would suggest to combine them, since the followup also includes a unit > test. Are you sure it is the best way to proceed? as the 1st patch was already signed off, I wanted to keep the signoff. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 09:51:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 08:51:01 +0000 Subject: [Koha-bugs] [Bug 11594] New: store both item type and document type in statistics Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11594 Bug ID: 11594 Summary: store both item type and document type in statistics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I copy here a comment originaly made on bug 9351 For some libraries, what is needed in statistical table is BOTH items.itype and biblioitems.itemtype, and maybe a clear indication (a 3rd column "circulation_type" ?) of which type is was used for circulation rights. Ex: In Rennes 2 we use item level for defining circulation rules. items.itype are codes for "Short Loan", "Normal Loan", "Long loan". biblioitems.itemtype are "Book", "Serial", "DVD" etc. For our annual report, we need to know the number of Books, Serials, DVD checked out, even if the type used for defining circulation rules are "Short loan", and not "Book". But other libraries may have different settings, and may have need to make stats on item level, or maybe cross stats on both level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 09:51:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 08:51:15 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #27 from mathieu saby --- (In reply to Fridolin SOMERS from comment #25) > (In reply to mathieu saby from comment #23) > > I did not read all the comments, but for some libraries, what is needed in > > statistical table is BOTH items.itype and biblioitems.itemtype, and maybe a > > clear indication (a 3rd column "circulation_type" ?) of which type is was > > used for circulation rights. > Very good idea. I think more information will be better for many libraries. > But in another bug because it will be an enhancement. See bug 11594 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 13:03:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 12:03:30 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #35 from M. de Rooy --- (In reply to mathieu saby from comment #34) > > I would suggest to combine them, since the followup also includes a unit > > test. > > Are you sure it is the best way to proceed? as the 1st patch was already > signed off, I wanted to keep the signoff. In that case you should amend the second patch accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 13:53:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 12:53:47 +0000 Subject: [Koha-bugs] [Bug 11595] New: Untranslatable error messages in rotating collections Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11595 Bug ID: 11595 Summary: Untranslatable error messages in rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Error messages "No Title Given" and "No Description Given" are hard-coded in C4/RotatingCollections.pm and cannot be translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 14:08:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 13:08:01 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24603|0 |1 is obsolete| | --- Comment #48 from Tom?s Cohen Arazi --- Created attachment 24604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24604&action=edit Bug 11096: (qa followup) facets count and UNIMARC record syntax - An error in a copy and paste operation made me count facet occurences instead of records where the fields where present. - As of bug 3087 UNIMARC uses the 'unimarc' record syntax. I assumed 'usmarc' was used as serialization format as thought it was dialect-agnostic. This patch adds a test of whether we are in UNIMARC context or not and sets the record syntax to match the one from koha-conf.xml. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 14:13:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 13:13:20 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24604|0 |1 is obsolete| | --- Comment #49 from Tom?s Cohen Arazi --- Created attachment 24605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24605&action=edit Bug 11096: fallback to the correct defaults if config entries missing My mistake choosing the right patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 14:35:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 13:35:37 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 14:35:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 13:35:40 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 --- Comment #28 from Kyle M Hall --- Created attachment 24606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24606&action=edit Bug 6254 [QA Followup 2] - can't set patron privacy by default -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 14:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 13:46:35 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 14:46:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 13:46:40 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24605|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart --- Created attachment 24607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24607&action=edit Bug 11096: fallback to the correct defaults if config entries missing As of bug 7818 misc/migration_tools/rebuild_zebra.pl behaves like: - bib_index_mode (defaults to 'grs1' if not specified) - auth_index_mode (defaults to 'dom') we should do the same in C4::Context. So people having old config files have a seamless behaviour. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart Without this patch, I got Can't call method "data" on an undefined value at /home/koha/src/C4/Search.pm line 1740. without zebra_bib_index_mode entry in my koha config file. With this patch, the search works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:17:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:17:44 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t ./xt (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|silence messages from |silence messages from |running prove ./t ./xt |running prove ./t ./xt | |(omnibus) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:18:46 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t ./xt (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11402 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:18:46 +0000 Subject: [Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:25:46 +0000 Subject: [Koha-bugs] [Bug 11596] New: Missing indexing options in koha-conf.xml should be reported Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Bug ID: 11596 Summary: Missing indexing options in koha-conf.xml should be reported Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It is quite common that new major releases introduce new configuration entries in the koha-conf.xml file. Users carrying old koha-conf.xml files usually miss those configuration entries. We usually fallback to some default when the configuration entry is missing. The user should be warnig that a fallback to some default is being done and that it could have consequences in a near future. It will help debug users' problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:26:32 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11096 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:26:32 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:32:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:32:31 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:32:35 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 24608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24608&action=edit Bug 11596: Missing indexing options in koha-conf.xml should be reported To test: - Have a clean master install - Verify that koha-conf.xml contains valid entries for: zebra_bib_index_mode and zebra_auth_index_mode - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Apply the patch - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Edit your koha-conf.xml file commenting one or both indexing mode entries. - Go to More > About Koha > System information => You get "XML configuration file" warnings for each commented entry. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:34:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:34:35 +0000 Subject: [Koha-bugs] [Bug 11597] New: tab through fields in cataloging. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11597 Bug ID: 11597 Summary: tab through fields in cataloging. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you are in cataloging and in the edit items page when you tab through all the fields the last tab should take you to the 'add item' button or the 'save changes' button but it skips that altogether and goes up to 'Circulation' up at the top of the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:35:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:35:50 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:36:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:36:59 +0000 Subject: [Koha-bugs] [Bug 9996] Fix search for existing/upgraded Debian package instances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9996 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11596 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:36:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:36:59 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9996 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:45:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:45:24 +0000 Subject: [Koha-bugs] [Bug 9996] Fix search for existing/upgraded Debian package instances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9996 --- Comment #6 from Tom?s Cohen Arazi --- I added a reference to bug 11596. Having the missing or wrongly configured entries reported will help debugging users' problems. I'm not sure having a shell script modifying the users config files might be worth because of its possible consequences. They are not mutually exclusive anyway. Just saying. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:50:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:50:03 +0000 Subject: [Koha-bugs] [Bug 11598] New: Add --text option to overdue_notices similar to --html option Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598 Bug ID: 11598 Summary: Add --text option to overdue_notices similar to --html option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We have a number of reports of libraries that were upset by Bug 10720 being fixed! These libraries preferred this single file output, but as text only. We should bring back this behavior, but as a feature, not a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:50:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:50:10 +0000 Subject: [Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:51:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:51:43 +0000 Subject: [Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 15:51:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 14:51:45 +0000 Subject: [Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598 --- Comment #1 from Kyle M Hall --- Created attachment 24609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24609&action=edit Bug 11598 - Add --text option to overdue_notices similar to --html option We have a number of reports of libraries that were upset by Bug 10720 being fixed! These libraries preferred this single file output, but as text only. We should bring back this behavior, but as a feature, not a bug. Test Plan: 1) Apply this patch 2) Run overdue_notices.pl --html 3) Note the output is wrapped in html tags 4) Run overdue_notices.pl --text 5) Note the same output, but not wrapped in html tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 16:31:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 15:31:14 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24472|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 24610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24610&action=edit Bug 11533: fix authority searching with no sorting when QueryParser is enabled This patch fixes an issue where chosing 'None' as the sort order for an authority search would result in zero hits if QueryParser is eanbled. This patch also adds some additional test cases. To test: [1] Enable QueryParser. [2] Perform an authority search in the staff interface that uses 'Heading A-Z' as the sort order and returns hits. [3] Run the same search, but with the sort order set to 'None'. No hits are returned. [4] Apply the patch. [5] Do step 3 again. This time, hits should be returned. [6] Verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 16:31:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 15:31:10 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 16:53:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 15:53:44 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 --- Comment #10 from Tom?s Cohen Arazi --- (In reply to Galen Charlton from comment #8) > This patch breaks the ODS format. ODS is a fancy ZIP file, and therefore > needs to be written in binary mode. I also observed that strings got > double-encoded upon export to the Excel XML format. The patch broke the ODS format, I've fixed easily. The Excel XML format is broken on master actually. I'll try to fix it too. Thanks for the insight Galen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 16:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 15:55:03 +0000 Subject: [Koha-bugs] [Bug 11599] New: itemBarcodeFallbackSearch should work even for items that don't have barcodes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11599 Bug ID: 11599 Summary: itemBarcodeFallbackSearch should work even for items that don't have barcodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When itemBarcodeFallbackSearch is in effect, falling back to a keyword search currently performs the search -- then filters out items that do not have barcodes. This is because the checkout interface currently requires an item barcode to make a loan; it cannot identify the item using the itemnumber. It would be nice if the itemnumber could be used instead. That way, if a library truly does not use item barcodes or RFID tags, they could leave the barcode field blank and still be able to circulate. Currently, they would have to fill in dummy values for the barcode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:02:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:02:44 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24601|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 24611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24611&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. Lastly, opac-showmarc now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:06 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23937|0 |1 is obsolete| | Attachment #23938|0 |1 is obsolete| | Attachment #23939|0 |1 is obsolete| | Attachment #23940|0 |1 is obsolete| | Attachment #23941|0 |1 is obsolete| | Attachment #23942|0 |1 is obsolete| | Attachment #23943|0 |1 is obsolete| | Attachment #23944|0 |1 is obsolete| | Attachment #23945|0 |1 is obsolete| | Attachment #23946|0 |1 is obsolete| | Attachment #23947|0 |1 is obsolete| | Attachment #23948|0 |1 is obsolete| | Attachment #23949|0 |1 is obsolete| | Attachment #23950|0 |1 is obsolete| | Attachment #23951|0 |1 is obsolete| | --- Comment #132 from Kyle M Hall --- Created attachment 24612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24612&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:24 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #133 from Kyle M Hall --- Created attachment 24613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24613&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:28 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #134 from Kyle M Hall --- Created attachment 24614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24614&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:32 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #135 from Kyle M Hall --- Created attachment 24615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24615&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:36 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #136 from Kyle M Hall --- Created attachment 24616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24616&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:41 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #137 from Kyle M Hall --- Created attachment 24617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24617&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #138 from Kyle M Hall --- Created attachment 24618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24618&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:50 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #139 from Kyle M Hall --- Created attachment 24619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24619&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:54 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #140 from Kyle M Hall --- Created attachment 24620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24620&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:11:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:11:58 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #141 from Kyle M Hall --- Created attachment 24621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24621&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:12:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:12:04 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #142 from Kyle M Hall --- Created attachment 24622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24622&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:12:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:12:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #143 from Kyle M Hall --- Created attachment 24623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24623&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:12:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:12:13 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #144 from Kyle M Hall --- Created attachment 24624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24624&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:12:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:12:18 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #145 from Kyle M Hall --- Created attachment 24625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24625&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:12:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:12:23 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #146 from Kyle M Hall --- Created attachment 24626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24626&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:48:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:48:23 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #19 from Matthias Meusburger --- ::: C4/Items.pm @@ +2782,5 @@ > push @authorised_values, $itemtype; > $authorised_lib{$itemtype} = $description; > + > + # If we have default value named itemtype or itemtypes, we use it > + $defaultvalue = $itemtype if ($defaultvalues and ($defaultvalues->{'itemtypes'} eq $itemtype or $defaultvalues->{'itemtype'} eq $itemtype)); and @@ +2814,5 @@ > $authorised_lib{$value} = $lib; > + > + # If we have a default value that has the same name as the authorised value category of the field, > + # we use it > + $defaultvalue = $value if ($defaultvalues and $defaultvalues->{$tagslib->{$tag}->{$subfield}->{authorised_value}} and $defaultvalues->{$tagslib->{$tag}->{$subfield}->{authorised_value}} eq $value); and ::: serials/subscription-add.pl @@ +153,5 @@ > # prepare template variables common to all $op conditions: > +my $shelflocations = GetKohaAuthorisedValues( 'items.location', '' ); > + > +my @locationarg = > + map { { code => $_, value => $shelflocations->{$_}, selected => ( ( $subs->{location} and $_ eq $subs->{location} ) ? "selected=\"selected\"" : "" ), } } sort keys %{$shelflocations}; -> You're right, this is not needed. ::: C4/Serials.pm @@ +926,5 @@ > + > + return $return; > +} > + > + -> Why do you quote this part specifically? The patch adds the whole GetPreviousSerialid, which return is needed. Am I missing something here? Please combine into one single database update and add an AFTER reneweddate to ensure that the sequence of fields is the same on new and updated installations. -> done It's not clear, which status will be used from the description - What is the first, and what is the second status? Which fields will be used? -> when makePreviousSerialAvailable is enabled, when receiving a new serial, notforloan will be set to 0 and the itype will be set to previousitemtype for previously received serial. Are these the points I should make more explicit? Could it be an option to make this pref a bit more configurable, behaving like AcqItemSetSubfieldsWhenReceived? -> If I'm not mistaken, AcqItemSetSubfieldsWhenReceived applies to the serial we just received, as makePreviousSerialAvailable applies to the one that was received before (just to make things clear). But besides that, if there are use-cases where other fields than notforloan and itype have to be used, it might be useful to have something more configurable. Is it so? This is a bigger problem: I think copynumber is used in MARC21 to indicate different copies of the same book. The enumchron field is used for the information about issue and year. For MARC21 serialseq is now copied into both fields. I think we can't leave it that way. My suggestion would be to use enumchron for UNIMARC as well or make this marcflavour dependent. -> using enumchron for UNIMARC as well makes sense. Done. Tiny capitalization issue - "Item". As this is on the subscription form, we could maybe leave out "serial" and shorten the description ab it. Also "Serial" is missing from the first field. -> done What is 'NEW' referring to? In my tests the change for the itemtype worked, but I couldn't figure out, how the status change is supposed to work. -> 'NEW' is previously set by koha : $cell->{'serialid'} = 'NEW'; (serials/serials-edit.pl:185) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:49:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:49:52 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #147 from Kyle M Hall --- Created attachment 24627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24627&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:50:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:50:53 +0000 Subject: [Koha-bugs] [Bug 11600] New: log viewer forgets your choice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11600 Bug ID: 11600 Summary: log viewer forgets your choice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org In the log view you pick your module and enter some criteria and then search. When the results come up your module choice is changed to 'all' so if you try to rerun your search you could (as I did today) end up searching all modules instead of just one and running a very very very long search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 17:51:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 16:51:02 +0000 Subject: [Koha-bugs] [Bug 11600] log viewer forgets your choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11600 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/tools/viewlog | |.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 18:01:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 17:01:21 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24627|0 |1 is obsolete| | --- Comment #148 from Kyle M Hall --- Created attachment 24628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24628&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 19:36:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 18:36:05 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24611|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 24629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24629&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. Lastly, opac-showmarc now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 19:45:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 18:45:26 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24514|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 24630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24630&action=edit Bug 9114: Make frameworks import/export routines correctly use UTF-8 Currently both the import_export_framework.pl script outputs data with Perl's default encoding, ISO-8859. This patch properly sets the binmode to UTF-8 when exporting SQL and CSV files using the PerlIO layer (":encoding(UTF-8)") for STDOUT. To test: Export step test - Use some ASCII character(s) with DIACRITICS in some field description in a chosen framework. - Export the framework at Administration > MARC frameworks - Run this to check the file is ISO-8859 encoded: $ file export_XXX.csv export_XXX.csv: ISO-8859 text, with very long lines (Note: try SQL and other output formats too. But not ODS) - Apply the patch - Export the framework again (change the name), and test encoding: $ file export_XXX_2.csv export_XXX_2.csv: UTF-8 Unicode text Import step test I assume you have two files, export_XXX.csv (ISO-8859 encoded) and export_XXX_2.csv (XXX will depend on your framework's code) - Reset your testing branch to master - Import export_XXX.csv - The string with non-ASCII chars is truncated at the first non-ASCII char's position (Note: this is the current behaviour). - Import export_XXX_2.csv - The non-ASCII chars are broken, the logs show errors on non-UNICODE chars. (Note: even thou UTF-8 is the expected encoding it is treated as ISO-8859). - Apply the patch - Import the good (UTF-8 as expected) file and check everything worked as expected. No double encoding should occur with either combination of formats. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 19:45:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 18:45:45 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 20:51:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 19:51:34 +0000 Subject: [Koha-bugs] [Bug 11601] New: Bootstrap theme has CSS files that do not have LESS counterparts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Bug ID: 11601 Summary: Bootstrap theme has CSS files that do not have LESS counterparts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: wizzyrea at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org We should create parity between the LESS and CSS folders in the Bootstrap theme. CSS should be minified to discourage hand editing. Steps to this available at http://www.lesscss.org/#usage Note that you will need to install Node.js first: http://nodejs.org/ A convenient tool for development with less: https://github.com/jonycheung/Dead-Simple-LESS-Watch-Compiler We should probably also start a wiki page to point people to on how to modify core less files in the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 20:56:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 19:56:10 +0000 Subject: [Koha-bugs] [Bug 11367] Clicking letter links on paid support (alphabetical) returns you to the home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11367 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 21:17:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 20:17:20 +0000 Subject: [Koha-bugs] [Bug 11367] Clicking letter links on paid support (alphabetical) returns you to the home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11367 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Liz Rea --- This was caused by a bug in the plugin that handles those. A bit of investigating later, and it's all fixed up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 21:19:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 20:19:51 +0000 Subject: [Koha-bugs] [Bug 11521] Patron Cardnumber scanning causing patron record to be saved. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11521 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11563 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 21:19:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 20:19:51 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 21:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 20:47:07 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 22:38:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 21:38:52 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 22:38:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 21:38:56 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #1 from Liz Rea --- Created attachment 24631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24631&action=edit Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 23:02:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 22:02:41 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 22 23:33:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 22:33:01 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jrobb at sekls.org --- Comment #2 from Jason Robb --- Sorry if I did this wrong; long time listener -- first time caller. This patch has been applied to our production server at SEKLS and works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 00:51:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 23:51:11 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 00:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Jan 2014 23:51:14 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24608|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 24632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24632&action=edit [SIGNED OFF] Bug 11596: Missing indexing options in koha-conf.xml should be reported To test: - Have a clean master install - Verify that koha-conf.xml contains valid entries for: zebra_bib_index_mode and zebra_auth_index_mode - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Apply the patch - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Edit your koha-conf.xml file commenting one or both indexing mode entries. - Go to More > About Koha > System information => You get "XML configuration file" warnings for each commented entry. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 01:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 00:08:06 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #2 from Agnes Rivers-Moore --- As a cataloguer I agree this prompt should not come up for every blank (new) record. It is very annoying not to have an option to turn this off. As others mentioned, let the button say "Overwrite with Z39.50" That's my preference. Otherwise, could we have a sys preference to have this prompt or not? Could we have a box to "do not tell me again in this session"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 01:23:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 00:23:16 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 --- Comment #3 from Tom?s Cohen Arazi --- Agnes, in which workflow you'd end up in the cataloguind interface calling a Z39.50 search? I asked my librarians the very same question and they answered that it was the way they chose the framework they wanted to use for the harvested record. When I filled bug 10678 I belived that if you're creating a new record, you'd start at the previous page. When you go More > Catalog. And that's why we added the dropdown for the framework selection. And my librarians were delighted. So leaving the warning there would be of no harm, as the action is actually going to delete anything you wrote there. I just leave the comment to continue the discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 02:22:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 01:22:43 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 --- Comment #4 from Agnes Rivers-Moore --- Hi Note that we are on 3.8. but finding this discussion still open I suppose this is still how it works in later versions. We usually have a pile of items to catalogue, often using the same framework. We only use More-Catalog to get to New record the first time. Choose framework from the Add New drop down (which is nice, thanks). Then in Add MARC record - we click Z39.50 from there. The message pops up (we have a blank framework because we are adding NEW). We have to click in response to the message to move on to the Z39.50 search. After loading, editing and saving the record we use the breadcrumbs to get back to Add New, or the back button to get to the blank MARC with our framework selected. Again when we click Z39.50, we have an extra click to confirm the message, before it will let us search. We will be cataloguing 30-40 items at a time, it gets annoying to have the check every time we go to look for a record. It would make sense if we had started with catalogue search - Edit existing record, but does not make sense when adding new records. The issue is not with a warning - it is that we have to click OK to clear it every time we open the Z39.50 search form, even if we have seen it 39 times already today, and also even if there is nothing to overwrite because it is a new record. One other option - maybe the warning could be added to the top of the Z39.50 Search form - so it would be seen but not need an extra click to acknowledge the pop-up message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 03:12:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 02:12:58 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 --- Comment #19 from Liz Rea --- Created attachment 24633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24633&action=edit Bug 10944 - opac-user and opac-readingrecord had instances of non-https amazon images To test: * Enable Amazon images in the system preferences * Issue a book you know will have images for, verify that without SSL 1. the images show on the borrower's logged in home page (opac-user) and on the opac-readingrecord 2. the image source is from an Amazon url that uses http:// 3. the images are the right size, and look ok * Do the same using https, verify that with SSL 1. the images show on the borrower's logged in home page (opac-user) and on the opac-readingrecord 2. the image source is from an Amazon url that uses https:// 3. the images are the right size, and look ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 03:24:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 02:24:27 +0000 Subject: [Koha-bugs] [Bug 11567] Shortcut is searching with every keypress In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11567 --- Comment #5 from Nicholas van Oudtshoorn --- Hmmm - it seems to be working now. I'll remember that tip about updating templates. I'm not running the debian packages (we're a Fedora shop here). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 03:26:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 02:26:15 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #20 from Liz Rea --- Should add that while I was in there I added the reference to the amazonTLD systempref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 04:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 03:48:41 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 04:52:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 03:52:43 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #19 from Galen Charlton --- (In reply to Kyle M Hall from comment #18) > I would question whether this match point should be added for upgrades, as > the installer may have opted not to install the default match points. I > believe that is a question for the release manager though. Either the database update should be skipped, or the MARC matching rules SQL should be mandatory during installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 06:26:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 05:26:12 +0000 Subject: [Koha-bugs] [Bug 11602] New: Fix localcover display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Bug ID: 11602 Summary: Fix localcover display Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: vanoudt at gmail.com QA Contact: testopia at bugs.koha-community.org I'm busy playing around with updating to the nice new bootstrap theme. We use google jackets most of the time, but have some localcovers stored too. I want to style the localcover imgs the same as any other bookmark. Ideally, they need a thumbnail class. But the 1px image that is returned causes (potentially, at least in my case) things like empty borders. Could the Locacovers.js function be modified to a) include a class of thumbnail for the image b) not insert the image when it is 1px in size. The following function would do that... /** * Search all: *
                  * or *
                  * and run a search with all collected isbns to Open Library Book Search. * The result is asynchronously returned by OpenLibrary and catched by * olCallBack(). */ GetCoverFromBibnumber: function(uselink) { $("div[id^=local-thumbnail],span[id^=local-thumbnail]").each(function(i) { var mydiv = this; var message = document.createElement("span"); $(message).attr("class","no-image"); $(message).html(NO_LOCAL_JACKET); $(mydiv).append(message); var img = $("").attr('src', '/cgi-bin/koha/opac-image.pl?thumbnail=1&biblionumber=' + $(mydiv).attr("class")) .load(function () { this.setAttribute("class", "thumbnail"); if (!this.complete || typeof this.naturalWidth == "undefined" || this.naturalWidth == 0) { //IE HACK try { $(mydiv).append(img); $(mydiv).children('.no-image').remove(); } catch(err){ }; } else if (this.width > 1) { // don't show the silly 1px "no image" img if (uselink) { var a = $("").attr('href', '/cgi-bin/koha/opac-imageviewer.pl?biblionumber=' + $(mydiv).attr("class")); $(a).append(img); $(mydiv).empty().append(a); } else { $(mydiv).empty().append(img); } $(mydiv).children('.no-image').remove(); } }) }); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 07:18:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 06:18:26 +0000 Subject: [Koha-bugs] [Bug 11590] Librarian able to checkout item without setting branch first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- (In reply to Robin Sheat from comment #2) > The giant warning saying that you shouldn't do that indicates that you > shouldn't do that. > > A better fix is is to make that warning a bit more compulsory, e.g. cutting > off access to functions that aren't related to configuration/management if > you're the database user. > > Maybe also make the warning bigger and having blinking marqueed text so it > doesn't get ignored. Yep, what Robin is saying is that the real problem here is that you are logged in not as a real user but the db user. I agree that we should definitely not let the db user ever circulate. That would be a much better solution. Also, lots of other features should be blocked too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:31:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:31:59 +0000 Subject: [Koha-bugs] [Bug 11603] New: Gather print notices: add csv and ods export Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Bug ID: 11603 Summary: Gather print notices: add csv and ods export Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org I completely refactored the gather_print_notices cronjob in order to allow the generation of csv and ods files. You can have a look at the wip on the BibLibre repo: http://git.biblibre.com/?p=kohac;a=shortlog;h=refs/heads/sanop/ft/MT13212 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:32:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:32:10 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:32:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:32:21 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10832 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:32:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:32:21 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11603 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:40:09 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 cedric.vita at dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cedric.vita at dracenie.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:44:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:44:43 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23505|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 24634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24634&action=edit Bug 11395: DB: Add permission tools_records_batchmod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:45:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:45:20 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:51:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:51:49 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24099|0 |1 is obsolete| | --- Comment #20 from Matthias Meusburger --- Created attachment 24635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24635&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:53:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:53:07 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 09:53:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 08:53:51 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 cedric.vita at dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cedric.vita at dracenie.com --- Comment #11 from cedric.vita at dracenie.com --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11319:

                  Something went wrong !

                  Applying: Bug 11319: Koha::SimpleMARC should take a hashref for parameters Applying: Bug 11319: Add UT for the fields management Applying: Bug 11319: Add the field management for Koha::SimpleMARC Applying: Bug 11319: Add specific UT for nonexistent field/subfield Applying: Bug 11319: Template modifications Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt Failed to merge in the changes. Patch failed at 0001 Bug 11319: Template modifications When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11319 - Marc modification templates improvements 23415 - Bug 11319: Koha::SimpleMARC should take a hashref for parameters 23416 - Bug 11319: Add UT for the fields management 23417 - Bug 11319: Add the field management for Koha::SimpleMARC 23418 - Bug 11319: Add specific UT for nonexistent field/subfield 23419 - Bug 11319: Template modifications Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11319-Template-modifications-Yo0tWr.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:06:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:06:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Pierre Angot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:09:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:09:19 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24052|0 |1 is obsolete| | Attachment #24053|0 |1 is obsolete| | Attachment #24054|0 |1 is obsolete| | Attachment #24055|0 |1 is obsolete| | Attachment #24056|0 |1 is obsolete| | Attachment #24057|0 |1 is obsolete| | Attachment #24058|0 |1 is obsolete| | Attachment #24059|0 |1 is obsolete| | Attachment #24060|0 |1 is obsolete| | Attachment #24061|0 |1 is obsolete| | Attachment #24062|0 |1 is obsolete| | Attachment #24063|0 |1 is obsolete| | Attachment #24064|0 |1 is obsolete| | Attachment #24065|0 |1 is obsolete| | --- Comment #158 from Jonathan Druart --- Created attachment 24636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24636&action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:09:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:09:28 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #159 from Jonathan Druart --- Created attachment 24637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24637&action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:09:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:09:35 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #160 from Jonathan Druart --- Created attachment 24638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24638&action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:09:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:09:42 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #161 from Jonathan Druart --- Created attachment 24639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24639&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:09:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:09:49 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #162 from Jonathan Druart --- Created attachment 24640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24640&action=edit Bug 7180: The default quantity is 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:09:57 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #163 from Jonathan Druart --- Created attachment 24641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24641&action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:10:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:10:05 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #164 from Jonathan Druart --- Created attachment 24642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24642&action=edit Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:10:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:10:13 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #165 from Jonathan Druart --- Created attachment 24643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24643&action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:10:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:10:23 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #166 from Jonathan Druart --- Created attachment 24644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24644&action=edit Bug 7180: FIX License version Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:10:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:10:31 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #167 from Jonathan Druart --- Created attachment 24645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24645&action=edit Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:10:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:10:38 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #168 from Jonathan Druart --- Created attachment 24646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24646&action=edit Bug 7180 - QA Followup - Correct minor language issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:10:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:10:45 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #169 from Jonathan Druart --- Created attachment 24647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24647&action=edit Bug 7180: Restore the "Add order" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:10:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:10:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #170 from Jonathan Druart --- Created attachment 24648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24648&action=edit Bug 7180: Remove useless rrp variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:11:00 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #171 from Jonathan Druart --- Created attachment 24649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24649&action=edit Bug 7180: FIX: discount was divided by 100 twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:11:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:11:44 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #172 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:18:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:18:37 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:18:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:18:41 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23419|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 24650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24650&action=edit Bug 11319: Template modifications This patch add template modifications for the restrictions: - the source field is always mandatory - on move and copy, the source and destination subfield should be both filled or blank. - on move and copy, the destination subfield should be filled. - on update, the subfield value should be filled. Test plan: Verify you are not able to create/modify template actions according to these restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 10:19:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 09:19:02 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #13 from Jonathan Druart --- Fix conflict with bug 11414. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 11:55:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 10:55:12 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by silvere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 11:55:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 10:55:24 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 11:55:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 10:55:34 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 24651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24651&action=edit Bug 11056: Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no longer assigned to the $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : * Check basketgroup are shown as before the patch, and can be closed and reopened. * Check you can add or remove a basket from a basketgroup, and change information about it (like delivery place) * Check you can create a basketgroup when you close a basket. Signed-off-by: Jonathan Druart The following commands return nothing: - grep validate acqui/basketgroup.tt - grep -R basketgroup.pl -C 2 | grep validate - git grep parseinputbaskets - git grep parseinputbasketgroups - git grep basketgroup.pl | grep validate Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton Signed-off-by: silvere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 12:02:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 11:02:33 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24509|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 12:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 11:02:37 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24651|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 12:03:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 11:03:33 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24509|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 24652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24652&action=edit Bug 11579: Show ordernumber in basket.pl tables Test plan: Verify the ordernumber is correctly displayed on the basket page (acqui/basket.pl?basketno=X) Signed-off-by: silvere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 12:09:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 11:09:04 +0000 Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 --- Comment #5 from Jonathan Druart --- Sylv?re has tested the patch in a sandbox but he applied it yesterday and signed off it today. Meanwhile the sandbox has been reset to master, so the master HEAD has been uploaded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 13:25:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 12:25:45 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from M. de Rooy --- Hi Jonathan, Am I wrong if I conclude that you are assigning an arrayref to $count? Quick fix? :) diff --git a/acqui/parcel.pl b/acqui/parcel.pl index ad0e51d..d374fa0 100755 --- a/acqui/parcel.pl +++ b/acqui/parcel.pl @@ -174,7 +174,7 @@ for my $order ( @orders ) { $line{holds} = 0; my @itemnumbers = GetItemnumbersFromOrder( $order->{ordernumber} ); for my $itemnumber ( @itemnumbers ) { - my ( $count ) = &GetReservesFromBiblionumber($line{biblionumber}, undef, $itemnumber); + my ( $count ) = &GetReservesFromBiblionumber({ biblionumber => $line{biblionumber}, itemnumber => $itemnumber }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 14:15:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 13:15:14 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 14:15:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 13:15:18 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22706|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 24653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24653&action=edit Bug 9823: Refactor return from GetReservesFromBiblionumber The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaing a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 14:15:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 13:15:57 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 --- Comment #14 from Jonathan Druart --- (In reply to M. de Rooy from comment #12) > Hi Jonathan, > Am I wrong if I conclude that you are assigning an arrayref to $count? > Quick fix? :) Yes, done! I also changed new occurrences of GetReservesFromBiblionumber in t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 14:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 13:32:11 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 14:32:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 13:32:13 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24629|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 24654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24654&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. The opac-showmarc page now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. Added tests to t/db_dependent/Biblio.t to test the functionality of the two functions added into C4::Biblio. TEST PLAN --------- 1) Backup DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be hidden... 13) Until you click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) Refresh the opac-MARCdetail page. Title should hide now. 17) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 18) Click Normal view 19) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 20) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 21) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields are treated separately, so I don't believe they could be hidden in the table using the MARC visibility. The goal was hiding properly things above the items. 22) Restore DB, because hiding 000,003,005,008,020,040,245,etc. are not useful across an entire framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 14:33:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 13:33:22 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #19 from M. de Rooy --- (In reply to Fridolin SOMERS from comment #18) > Can you signoff 3rd patch ? I still have a question. We had Number-local-acquisition with a capital letter. If I disable QueryParser, I can search with Number-local-acquisition:testmr and find a record. If I enable QueryParser, this will no longer work. The URLs from your commit message do all work, but note that now it is number-local-acquisition with a lower case letter. I am not yet so familiar with the QueryParser configuration, but is it possible to make these indexes case insensitive or so? I am hesitating to sign a patch that makes this index with the capital letter disappear.. I have asked jcamins this same question in an email.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 14:35:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 13:35:12 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 15:20:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 14:20:42 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 --- Comment #15 from M. de Rooy --- (In reply to Jonathan Druart from comment #14) > Yes, done! > I also changed new occurrences of GetReservesFromBiblionumber in > t/db_dependent/Holds.t Great. Have been testing some already. Looks good until now. But I cannot finish it today anymore. Will soon pick it up again.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 16:16:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 15:16:24 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24654|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 24655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24655&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. The opac-showmarc page now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. The opac-export script now filters the biblio record to match what is currently displayed. Added tests to t/db_dependent/Biblio.t to test the functionality of the two functions added into C4::Biblio. TEST PLAN --------- 1) Backup DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be hidden... 13) Until you click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) Refresh the opac-MARCdetail page. Title should hide now. 17) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 18) Click Normal view 19) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 20) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 21) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields are treated separately, so I don't believe they could be hidden in the table using the MARC visibility. The goal was hiding properly things above the items. 22) And lastly, attempt to Save record in the various formats using the dropdown and clicking Go. -- The results should be filtered. 23) Restore DB, because hiding 000,003,005,008,020,040,245,etc. are not useful across an entire framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 16:16:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 15:16:21 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 16:29:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 15:29:47 +0000 Subject: [Koha-bugs] [Bug 8142] Unhighlight option breaks keywords highlighted in staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8142 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #3 from Fridolin SOMERS --- Seems to work in actual master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 16:44:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 15:44:09 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 --- Comment #9 from Galen Charlton --- (In reply to mathieu saby from comment #8) > I'm sure it's used in France, in Portugal, in Italy. And Koha is used in > those 3 countries. > It may also be in use in Greece, Russia, Croatia and some arabic speaking > countries (I found data of 2008 for those countries). Right -- but do they use the *English* version specifically? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 16:53:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 15:53:23 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 --- Comment #10 from Katrin Fischer --- If we don't update the English version, we should maybe pick another language to base the po file for translations on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 17:15:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 16:15:23 +0000 Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 --- Comment #11 from Fridolin SOMERS --- (In reply to mathieu saby from comment #10) > Maybe an alternative could be to suppress the ability to select a date with > the dropdown list (I'm not sure that's very intuitive), and just use the > special input field made for filtering by dates. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 17:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 16:22:44 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt at gmail.com |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 17:48:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 16:48:03 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 17:58:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 16:58:00 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 17:58:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 16:58:38 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #28 from Galen Charlton --- Pushed to master. Thanks, Francesca and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 17:59:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 16:59:03 +0000 Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 17:59:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 16:59:27 +0000 Subject: [Koha-bugs] [Bug 11549] After transferring an order, receive and cancel the receipt will delete the order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 17:59:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 16:59:52 +0000 Subject: [Koha-bugs] [Bug 11435] Show basketgroup information in Acquisition tab in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11435 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 18:00:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 17:00:12 +0000 Subject: [Koha-bugs] [Bug 11429] Add a link to basketgroup in basket detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 18:00:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 17:00:30 +0000 Subject: [Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 18:00:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 17:00:50 +0000 Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 18:13:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 17:13:56 +0000 Subject: [Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #21 from Galen Charlton --- Pushed to master. Congratulations on having your first patch accepted into Koha, JaTara! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 18:41:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 17:41:06 +0000 Subject: [Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 19:35:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 18:35:54 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master, along with a follow-up to repair table sorting. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 21:25:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 20:25:13 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24483|0 |1 is obsolete| | --- Comment #6 from Liz Rea --- Comment on attachment 24483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24483 Bug 11574 - Clean up lists interface for printing contents of patch will need to be put in the less folder, because I have other work out that creates parity between the less and css folders. I'd rather have that patch, so I'll hold off on this one for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 21:38:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 20:38:38 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #12 from M. Tompsett --- Comment on attachment 24597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24597 Bug 10937 - Option to hide and group itemtypes from advanced search Review of attachment 24597: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10937&attachment=24597) ----------------------------------------------------------------- ::: C4/Koha.pm @@ +41,4 @@ > &slashifyDate > &subfield_is_koha_internal_p > &GetPrinters &GetPrinter > + &GetItemTypes &GetItemTypesCategorized &GetItemTypesByCategory &getitemtypeinfo No problem, but I would have put the new functions on a different line, so as to reduce the chance of messing up the old ones. @@ +270,4 @@ > } > } > > +=head2 GetItemTypes GetItemTypesCategorized. Oops! ::: admin/itemtypes.pl @@ +168,4 @@ > $input->param('summary'), > $input->param('checkinmsg'), > $input->param('checkinmsgtype'), > + ( $input->param('hideinopac') ? 1 : 0 ), This one is in parenthesis? @@ +193,4 @@ > $input->param('summary'), > $input->param('checkinmsg'), > $input->param('checkinmsgtype'), > + $input->param('hideinopac') ? 1 : 0, This one is not? It might be best to avoid the inline expr?true:false in this list. ::: installer/data/mysql/kohastructure.sql @@ +1241,5 @@ > summary text, -- information from the summary field, may include HTML > checkinmsg VARCHAR(255), -- message that is displayed when an item with the given item type is checked in > checkinmsgtype CHAR(16) DEFAULT 'message' NOT NULL, -- type (CSS class) for the checkinmsg, can be "alert" or "message" > + hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the search options in OPAC > + searchcategory varchar(15) default NULL, -- Group this item type with others with the same value on OPAC search options How did you decide on varchar(15)? ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt @@ +146,3 @@ > [% itemtypeloo.description %]
                  7. > [% IF ( loop.last ) %][% ELSE %][% UNLESS ( loop.count % 4 ) %]
                  [% END %][% END %] > + [% END %] This END isn't even the area you were adding your IF around. Why change the indentation? Indentation issues should perhaps be a separate patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 21:41:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 20:41:58 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #13 from M. Tompsett --- Does not apply to master. Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 22:27:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 21:27:12 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #23 from M. Tompsett --- Comment on attachment 24586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24586 Bug 8753 - Add forgot password link to OPAC Review of attachment 24586: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8753&attachment=24586) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +1068,5 @@ > PatronSelfRegistrationDefaultCategory => C4::Context->preference("PatronSelfRegistrationDefaultCategory"), > persona => C4::Context->preference("Persona"), > opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'}, > + OpacResetPassword => C4::Context->preference("OpacResetPassword"), > + OpacPasswordChange => C4::Context->preference("OpacPasswordChange"), No longer necessary. ::: C4/Members.pm @@ +2273,5 @@ > + my $uuid_str; > + $uuid_str .= $chars[rand @chars] for 1..32; > + > + #insert into database > + my $sth = $dbh->prepare( 'INSERT INTO borrower_password_recovery VALUES (? ,? , ADDDATE(NOW(), INTERVAL 2 DAY) )' ); Is this ANSI SQL? @@ +2281,5 @@ > + #define to/from emails > + my $kohaEmail = C4::Context->preference( 'KohaAdminEmailAddress' ); > + > + #create link > + my $uuidLink = "http://" . C4::Context->preference( 'OPACBaseURL' ) . "/cgi-bin/koha/opac-password-recovery.pl?uniqueKey=$uuid_str"; Does someone have that funky code to determine http vs https in a URL handy? Please don't hard code http. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ +556,5 @@ > + default: 1 > + choices: > + yes: "On" > + no: "Off" > + - ". If On, the user can reset his password on OPAC." There are prettier ways to format this. - - "The user " - pref: OpacResetPassword default: 1 choices: yes: "can reset" no: "can not reset" - " their password on OPAC." ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt @@ +48,5 @@ > + More than one account has been found for the email address: "[% email %]" > +
                  Try yo use your alternative email if you have another. > + [% ELSIF (errAlreadyStartRecovery) %] > + The process of password recovery has already started for this account ("[% email %]") > +
                  Check your emails; you should recieve the link to reset your password. receive typo. @@ +74,5 @@ > + > +[% ELSIF (new_password) %] > + [% IF (errLinkNotValid) %] > +
                  > + We could not authentify you as the account owner. authenticate ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tt @@ +86,5 @@ > > > +[% IF Koha.Preference('OpacPasswordChange') && Koha.Preference('OpacResetPassword') %] > +

                  Forgot your password?

                  > +[% END %] Could this be in the nologininstructions div? ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-password-recovery.tt @@ +46,5 @@ > + More than one account has been found for the email address: "[% email %]" > +
                  Try yo use your alternative email if you have another. > + [% ELSIF (errAlreadyStartRecovery) %] > + The process of password recovery has already started for this account ("[% email %]") > +
                  Check your emails; you should recieve the link to reset your password. receive typo. @@ +72,5 @@ > + > +[% ELSIF (new_password) %] > + [% IF (errLinkNotValid) %] > +
                  > + We could not authentify you as the account owner. authenticate ::: opac/opac-main.pl @@ +58,4 @@ > koha_news_count => $koha_news_count, > display_daily_quote => C4::Context->preference('QuoteOfTheDay'), > daily_quote => $quote, > + OpacResetPassword => C4::Context->preference('OpacResetPassword'), You tweaked opac-main.tt to use the Koha.Preference method of grabbing system preferences in the template. There's no need to modify this file. ::: opac/opac-password-recovery.pl @@ +48,5 @@ > +my $errPassTooShort; > + > +my $dbh = C4::Context->dbh; > + > +$template->param( OpacResetPassword => C4::Context->preference("OpacResetPassword") ); This is not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 22:30:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 21:30:08 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #24 from M. Tompsett --- Please look at my eyeball comments, and deal with this: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt FAIL forbidden patterns forbidden pattern: tab char (line 98) forbidden pattern: tab char (line 100) forbidden pattern: tab char (line 99) OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 23:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 22:12:36 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 --- Comment #4 from M. Tompsett --- Comment on attachment 24321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24321 Bug:8168 Fixing header of non csv files Review of attachment 24321: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8168&attachment=24321) ----------------------------------------------------------------- ::: misc/cronjobs/overdue_notices.pl @@ +628,5 @@ > } > # Generate the content of the csv with headers > + my $content; > + if ( defined $csvfilename ) { > + $content = join(";", qw(title name surname address1 address2 zipcode city country email itemcount itemsinfo due_date issue_date)) . "\n"; You missed Galen's second comment. The ";" should refer to C4::Context->preference('delimiter') I believe. You also have tab issues. @@ +634,5 @@ > + else { > + $content = ""; > + } > + $content .= join( "\n", @output_chunks ); > + This should be a blank line, not something with a tab or spaces. mtompset at ubuntu:~/kohaclone$ koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 1cc0d7b 'Bug 10907: (follow-up) fix table sort') FAIL misc/cronjobs/overdue_notices.pl OK pod FAIL forbidden patterns forbidden pattern: tab char (line 637) forbidden pattern: tab char (line 633) forbidden pattern: tab char (line 630) forbidden pattern: tab char (line 635) forbidden pattern: tab char (line 631) forbidden pattern: tab char (line 636) forbidden pattern: tab char (line 634) forbidden pattern: tab char (line 632) OK valid OK critic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 23:28:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 22:28:05 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 23:28:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 22:28:07 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24321|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 24656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24656&action=edit Bug 8168 - Fixing header of non csv files This determines if the CSV header should be included or not and then generates it as needed using the delimiter specified in the delimiter system preference. TEST PLAN --------- 1. make some overdues books 2. run the overdue notices script without the -csv 3. check emails notice csv header is in the email 4. apply the patch 5. run the overdue notice again 6. check email notice csv header is absent Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 23:28:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 22:28:59 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- Since I fixed what I reported wrong, some one else will need to sign off on this. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 23 23:35:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Jan 2014 22:35:32 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #8 from Robin Sheat --- Comment on attachment 24655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24655 Bug 11592 - opac scripts do not respect marc tag visibility Review of attachment 24655: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11592&attachment=24655) ----------------------------------------------------------------- Will this also hide appropriate fields in opac-ISBDdetail that should be hidden? ::: C4/Biblio.pm @@ +1222,5 @@ > + > +C<$OpacHideMARC> is a ref to a hash which contains a series > +of key value pairs indicating if that field (key) is > +hidden (value == 1) or not (value == 0). > + How can this be used to get information about something that doesn't have a kohafield attached? e.g. I want to hide marc field 505 from the OPAC, but it doesn't have a corresponding Koha field. Would this still work? @@ +1230,5 @@ > + > +sub GetOpacHideMARC { > + my ( $frameworkcode ) = shift || ''; > + my $dbh = C4::Context->dbh; > + my $sth = $dbh->prepare("SELECT kohafield AS field,tagfield AS tag,hidden FROM marc_subfield_structure WHERE LENGTH(kohafield)>0 AND frameworkcode=? ORDER BY field,tagfield;"); I would suspect that doing WHERE kohafield <> '' might be a tiny bit faster than asking it to do a length calculation. Probably negligible though. I'd probably also fix the spacing as right now it looks like it groups wrongly in the columns that it's selecting, even though it doesn't. @@ +1238,5 @@ > + foreach my $fullfield (keys %{$data}) { > + my @tmpsplit = split(/\./,$fullfield); > + my $field = $tmpsplit[-1]; > + foreach my $tag (keys %{$data->{$fullfield}}) { > + if ($data->{$fullfield}->{$tag}->{'hidden'}>0) { !=0 is likely to be marginally faster (unless negatives are a thing you care about.) @@ +1270,5 @@ > + my $filtered_record = $record->clone; > + > + my ( $frameworkcode ) = shift || ''; > + > + my $marcsubfieldstructure = GetMarcStructure(0,$frameworkcode); Maybe allow the marcsubfieldstructure to be passed in instead of the framework code. This becomes important if this happens over and over, as it'll do a big bunch of database work each time, this makes things very slow when it could be cached outside and passed in. It should be easy enough to see if you have a scalar or a ref, and so whether you have a code or the structure. @@ +1274,5 @@ > + my $marcsubfieldstructure = GetMarcStructure(0,$frameworkcode); > + if ($marcsubfieldstructure->{'000'}->{'@'}->{hidden}>0) { > + # LDR field is excluded from $record->fields(). > + # if we hide it here, the MARCXML->MARC::Record->MARCXML transformation blows up. > + } This if doesn't actually do anything. @@ +1977,4 @@ > push @marcsubjects, { > MARCSUBJECT_SUBFIELDS_LOOP => \@subfields_loop, > authoritylink => $authoritylink, > + } if $authoritylink || $#subfields_loop>=0; $#subfields_loop>=0 is a bit of an ugly construction. Best to use just @subfields_loop, it does the same thing and is easier to read. ::: opac/opac-detail.pl @@ +489,4 @@ > } > > my $dat = &GetBiblioData($biblionumber); > +my $OpacHideMARC = &GetOpacHideMARC($dat->{'frameworkcode'}); & is a perl4-ism, not required. @@ +654,5 @@ > +my ($st_tag,$st_subtag) = GetMarcFromKohaField('bibliosubtitle.subtitle',$dat->{'frameworkcode'}); > +my $subtitle; > +if ($st_tag && $st_subtag) { > + my @subtitles = $record->subfield($st_tag,$st_subtag); > + $subtitle = \@subtitles if scalar @subtitles; you don't need to say 'scalar' here. @@ +656,5 @@ > +if ($st_tag && $st_subtag) { > + my @subtitles = $record->subfield($st_tag,$st_subtag); > + $subtitle = \@subtitles if scalar @subtitles; > +} > +if ($subtitle && scalar @$subtitle) { nor here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 02:11:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 01:11:39 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Chris Cormack --- Try it without the <> construct. Because that is for making a dropdown, which we obviously can't do -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 03:45:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 02:45:53 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from M. Tompsett --- > Will this also hide appropriate fields in opac-ISBDdetail that should be > hidden? I didn't even look at opac-ISBDdetail -- we don't use it. I suppose I should. Though, it has that syspref related to the output for it. I'll add a filter call. > > +C<$OpacHideMARC> is a ref to a hash which contains a series > > +of key value pairs indicating if that field (key) is > > +hidden (value == 1) or not (value == 0). > > + > > How can this be used to get information about something that doesn't have a > kohafield attached? e.g. I want to hide marc field 505 from the OPAC, but it > doesn't have a corresponding Koha field. Would this still work? OpacHideMARC is intended as a hack for the loop in opac-detail that creates template parameters based on koha field names. It was around like 699 in the master, 713 in the patch. This is how [% title %] and other parameters are created. This covers the half of the problem that doesn't use the MARC record directly. If you are trying to hide something that doesn't have a kohafield, you are looking at the other function: GetFilteredOpacBiblio. This takes the MARC record and strips out things marked to be hidden. > > + my $sth = $dbh->prepare("SELECT kohafield AS field,tagfield AS tag,hidden FROM marc_subfield_structure WHERE LENGTH(kohafield)>0 AND frameworkcode=? ORDER BY field,tagfield;"); > > I would suspect that doing WHERE kohafield <> '' might be a tiny bit faster > than asking it to do a length calculation. I didn't do testing, but LENGTH(NULL) = 0, right? Which way handles the NULL case better? -- Just checked >'' is used elsewhere and returns the same number on my data. > Probably negligible though. I'd > probably also fix the spacing as right now it looks like it groups wrongly > in the columns that it's selecting, even though it doesn't. I don't understand what you are trying to say. OH! field,tagfield lacks spacing. Will fix that to improve readability. > > + if ($data->{$fullfield}->{$tag}->{'hidden'}>0) { > > !=0 is likely to be marginally faster (unless negatives are a thing you care > about.) valid values for hidden range from -15 to +... anyways... <=0 OPAC visibility is checked. >0 OPAC visibility is unchecked. So, yes, care about negatives. > > @@ +1270,5 @@ > > + my $filtered_record = $record->clone; > > + > > + my ( $frameworkcode ) = shift || ''; > > + > > + my $marcsubfieldstructure = GetMarcStructure(0,$frameworkcode); > > Maybe allow the marcsubfieldstructure to be passed in instead of the > framework code. This becomes important if this happens over and over, as > it'll do a big bunch of database work each time, this makes things very slow > when it could be cached outside and passed in. > > It should be easy enough to see if you have a scalar or a ref, and so > whether you have a code or the structure. Hmm... GetMarcStructure is cached. Look in C4/Biblio.pm for "sub GetMarcStructure". You will see the $marc_structure_cache line just above that, and it being used at the top of the function. > @@ +1274,5 @@ > > + my $marcsubfieldstructure = GetMarcStructure(0,$frameworkcode); > > + if ($marcsubfieldstructure->{'000'}->{'@'}->{hidden}>0) { > > + # LDR field is excluded from $record->fields(). > > + # if we hide it here, the MARCXML->MARC::Record->MARCXML transformation blows up. > > + } > > This if doesn't actually do anything. It explains why I didn't hide the LDR record. As this function is called only once, I don't think it is a big deal, but I will comment it out so people don't get the idea to fix the remaining LDR field problem this way. > > @@ +1977,4 @@ > > push @marcsubjects, { > > MARCSUBJECT_SUBFIELDS_LOOP => \@subfields_loop, > > authoritylink => $authoritylink, > > + } if $authoritylink || $#subfields_loop>=0; > > $#subfields_loop>=0 is a bit of an ugly construction. Best to use just > @subfields_loop, it does the same thing and is easier to read. Okay, I suppose I can try that. > > my $dat = &GetBiblioData($biblionumber); > > +my $OpacHideMARC = &GetOpacHideMARC($dat->{'frameworkcode'}); > > & is a perl4-ism, not required. Okay, I was confused a little by it used in some places and not in others. I'll remove my &. > > + $subtitle = \@subtitles if scalar @subtitles; > > you don't need to say 'scalar' here. > > +if ($subtitle && scalar @$subtitle) { > > nor here I'll test and remove, once confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 03:52:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 02:52:02 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #17 from Robin Sheat --- I noticed that GetMarcStructure does its own caching (which is likely to be problematic with plack) and this will be why it's substantially slower with memcache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 03:52:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 02:52:15 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #10 from Robin Sheat --- (In reply to M. Tompsett from comment #9) > Hmm... GetMarcStructure is cached. Look in C4/Biblio.pm for "sub > GetMarcStructure". You will see the $marc_structure_cache line just above > that, and it being used at the top of the function. Ah, interesting. It's also cached in memcache which actually slows things down. This explains why. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 03:56:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 02:56:23 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24655|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 24657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24657&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. The opac-showmarc page now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. The opac-export script now filters the biblio record to match what is currently displayed. Added tests to t/db_dependent/Biblio.t to test the functionality of the two functions added into C4::Biblio. Added a GetFilteredOpacBiblio call into opac-ISBDdetail page, so that it should be filtered. TEST PLAN --------- 1) Backup DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be hidden... 13) Until you click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) Refresh the opac-MARCdetail page. Title should hide now. 17) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 18) Click Normal view 19) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 20) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 21) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields are treated separately, so I don't believe they could be hidden in the table using the MARC visibility. The goal was hiding properly things above the items. 22) And lastly, attempt to Save record in the various formats using the dropdown and clicking Go. -- The results should be filtered. 23) Click on ISBD view to ensure nothing broke. 24) Restore DB, because hiding 000,003,005,008,020,040,245,etc. are not useful across an entire framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:00:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:00:26 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24657|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 24658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24658&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. The opac-showmarc page now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. The opac-export script now filters the biblio record to match what is currently displayed. Added tests to t/db_dependent/Biblio.t to test the functionality of the two functions added into C4::Biblio. Added a GetFilteredOpacBiblio call into opac-ISBDdetail page, so that it should be filtered. TEST PLAN --------- 1) Backup DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be hidden... 13) Until you click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) Refresh the opac-MARCdetail page. Title should hide now. 17) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 18) Click Normal view 19) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 20) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 21) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields are treated separately, so I don't believe they could be hidden in the table using the MARC visibility. The goal was hiding properly things above the items. 22) And lastly, attempt to Save record in the various formats using the dropdown and clicking Go. -- The results should be filtered. 23) Click on ISBD view to ensure nothing broke. 24) Restore DB, because hiding 000,003,005,008,020,040,245,etc. are not useful across an entire framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:02:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:02:38 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:02:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:02:41 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24658|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 24659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24659&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. The opac-showmarc page now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. The opac-export script now filters the biblio record to match what is currently displayed. Added tests to t/db_dependent/Biblio.t to test the functionality of the two functions added into C4::Biblio. Added a GetFilteredOpacBiblio call into opac-ISBDdetail page, so that it should be filtered. TEST PLAN --------- 1) Backup DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be hidden... 13) Until you click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) Refresh the opac-MARCdetail page. Title should hide now. 17) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 18) Click Normal view 19) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 20) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 21) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields are treated separately, so I don't believe they could be hidden in the table using the MARC visibility. The goal was hiding properly things above the items. 22) And lastly, attempt to Save record in the various formats using the dropdown and clicking Go. -- The results should be filtered. 23) Click on ISBD view to ensure nothing broke. 24) Restore DB, because hiding 000,003,005,008,020,040,245,etc. are not useful across an entire framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:14:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:14:49 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #14 from M. Tompsett --- opac-search.pl is out of scope for now. opac-ISDBdetail.pl could be cleaned up more, but the focus of this was more consistency between opac-MARCdetail and opac-detail pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:33:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:33:50 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24659|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 24660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24660&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. The opac-showmarc page now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. The opac-export script now filters the biblio record to match what is currently displayed. Added tests to t/db_dependent/Biblio.t to test the functionality of the two functions added into C4::Biblio. Added a GetFilteredOpacBiblio call into opac-ISBDdetail page, so that it should be filtered. TEST PLAN --------- 1) Backup DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be hidden... 13) Until you click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) Refresh the opac-MARCdetail page. Title should hide now. 17) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 18) Click Normal view 19) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 20) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 21) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields are treated separately, so I don't believe they could be hidden in the table using the MARC visibility. The goal was hiding properly things above the items. 22) And lastly, attempt to Save record in the various formats using the dropdown and clicking Go. -- The results should be filtered. 23) Click on ISBD view to ensure nothing broke. 24) Restore DB, because hiding 000,003,005,008,020,040,245,etc. are not useful across an entire framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:34:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:34:02 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #16 from M. Tompsett --- Created attachment 24661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24661&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:38:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:38:26 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24661|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 24662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24662&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:43:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:43:05 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24660|0 |1 is obsolete| | --- Comment #18 from M. Tompsett --- Created attachment 24663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24663&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. The opac-showmarc page now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. The opac-export script now filters the biblio record to match what is currently displayed. Added tests to t/db_dependent/Biblio.t to test the functionality of the two functions added into C4::Biblio. Added a GetFilteredOpacBiblio call into opac-ISBDdetail page, so that it should be filtered. TEST PLAN --------- 1) Backup DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be hidden... 13) Until you click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) Refresh the opac-MARCdetail page. Title should hide now. 17) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 18) Click Normal view 19) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 20) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 21) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields are treated separately, so I don't believe they could be hidden in the table using the MARC visibility. The goal was hiding properly things above the items. 22) And lastly, attempt to Save record in the various formats using the dropdown and clicking Go. -- The results should be filtered. 23) Click on ISBD view to ensure nothing broke. 24) Restore DB, because hiding 000,003,005,008,020,040,245,etc. are not useful across an entire framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 04:43:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 03:43:15 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24662|0 |1 is obsolete| | --- Comment #19 from M. Tompsett --- Created attachment 24664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24664&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 06:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 05:39:51 +0000 Subject: [Koha-bugs] [Bug 11604] New: editing patron error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11604 Bug ID: 11604 Summary: editing patron error Change sponsored?: --- Product: Koha Version: 3.8 Hardware: PC OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: anant.saraogi09 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Dear Sir, While editing in any record in the patron, I am getting this error: Undefined subroutine &C4::Members::GetBorrowerCategorycode called at /home/koha/kohaclone/C4/Members.pm line 721. I am using the Koha virtualbox 3.8 installation. Regards, Anant Saraogi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 08:37:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 07:37:21 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 08:37:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 07:37:25 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24656|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 24665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24665&action=edit Bug 8168 - Fixing header of non csv files This determines if the CSV header should be included or not and then generates it as needed using the delimiter specified in the delimiter system preference. TEST PLAN --------- 1. make some overdues books 2. run the overdue notices script without the -csv 3. check emails notice csv header is in the email 4. apply the patch 5. run the overdue notice again 6. check email notice csv header is absent Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 08:57:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 07:57:22 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24588|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 24666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24666&action=edit Bug 11587 - IsSuperLibrarian generates warnings Simply viewing OPAC detail triggers a modulus warning entry. This first patch adds two test cases to t/Context.t to test for this situation. TEST PLAN --------- 1) Apply this patch (to upgrade t/Context.t) 2) prove -v t/Context.t -- Tests 7 and 8 will fail 3) Apply second patch (to amend C4/Context.pm) 4) prove -v t/Context.t -- All tests will succeed Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 08:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 07:58:04 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 08:58:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 07:58:08 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24666|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 24667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24667&action=edit Bug 11587 - IsSuperLibrarian generates warnings This corrects line 1250 of C4/Context.pm to be: return ($userenv->{flags}//0) % 2; And thus avoids an uninitialized value used in the modulus. TEST PLAN --------- 1) Apply the first patch (to update t/Context.t) 2) prove -v t/Context.t -- This should fail tests 7 and 8 3) Apply this patch (to fix C4/Context.pm) 4) prove -v t/Context.t -- All tests should succeed Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 09:54:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 08:54:07 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- This king of patch could be done using the base offered by bug 10212. It will avoid to create yasp. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 09:57:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 08:57:42 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 --- Comment #7 from Katrin Fischer --- I did this mostly thinking about data privacy as we have to use personalized accounts for each staff member. So JQuery/CSS was not enough to achieve the goal here and hide the information safely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 10:20:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 09:20:38 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 --- Comment #8 from Jonathan Druart --- Yes sorry, you are right. I did not think about the data privacy problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 10:23:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 09:23:06 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 --- Comment #9 from Katrin Fischer --- Just trying to explain - I agree it's a pref for a small thing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 11:39:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 10:39:14 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 11:39:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 10:39:17 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24653|0 |1 is obsolete| | --- Comment #16 from M. de Rooy --- Created attachment 24668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24668&action=edit Bug 9823: Refactor return from GetReservesFromBiblionumber The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaing a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. Signed-off-by: Marcel de Rooy Placed biblio holds, future holds and item holds. Works as expected. Tested Holds.t and Reserves.t. Pass. Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. Fine. C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. Looks good. Handled a few unneeded calls in QA follow-up. Left only one point to-do for serials/routing-preview.pl. See Bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 11:39:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 10:39:26 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 --- Comment #17 from M. de Rooy --- Created attachment 24669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24669&action=edit Bug 9823: QA follow-up for GetReservesFromBiblionumber calls The template params holds and holdcount are not used in the ISBD template. Removed the associated code from catalogue/ISBDdetail.pl. Same applies for catalogue/MARCdetail.pl and labeledMARCdetail.pl. Same applies also for catalogue/imageviewer.pl. Same applies also for catalogue/moredetail.pl. In catalogue detail.tt only the number of holds is used. Removed the code that passed the holds array to the template. For consistency opac-detail should also incorporate future holds into its holds count; added the all_dates parameter for that reason. The Reserves module is no longer needed in moredetail. Removed it. Checked the other scripts also. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 11:40:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 10:40:56 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 --- Comment #18 from M. de Rooy --- Comments from testing (some preliminary QA comments for another QAer): Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. This attracted my attention: - $biblioitem->{'reserves'}->{'reserve'} = $reserves[1]; + $biblioitem->{'reserves'}->{'reserve'} = $reserves; But it is okay: $reserves[1] was previously the arrayref. So this is a code readability improvement too :) With and without patch I see my two holds in the output. Tested Holds.t and Reserves.t. Pass. Placed biblio holds, future holds and item holds. Works as expected (small note below on opac-detail). C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. OK Template params holds and holdcount are not used in the ISBD template; removed them from catalogue/ISBDdetail.pl in QA followup Same for MARCdetail.pl, imageviewer.pl, labeledMARCdetail.pl and moredetail.pl. Removed use Reserves from moredetail (no longer 'in use'.) In catalogue detail.tt only the number of holds is used. Removed the code that passed the holds array to the template. Tested various settings of OPACShowHoldQueueDetails and corresponding display in opac-detail. For consistency I added the all_dates parameter to the call in opac-detail to incorporate future holds in its count. I just note that the display of count and priority could be improved here but I am already at the scope borders of this report :) [The meaning of something like Total holds: 3 (priority 2) under the items list is rather obscure..] serials/routing-preview.pl: I have the strong feeling that this call of GetReservesFromBiblionumber also needs the all_dates parameter. I have not tested this call (there is no test plan for it too :), so I did not want to touch it now. If you could still have a look, Jonathan, perhaps you could still add that one in a follow-up? No complaints from koha-qa.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 11:46:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 10:46:19 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 --- Comment #19 from M. de Rooy --- Jonathan: the remark on routing-preview.pl actually applies too for: ILSDI/Services.pm C4/Biblio.pm (This one handles deleting reserves, so future ones should be cancelled too) C4/SIP/ILS/Item.pm acqui/parcel.pl Although you could ignore future holds in some counts etc., it makes me wonder if we still need the all_dates parameter and not just include them Always? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:08:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:08:36 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:08:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:08:40 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24290|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 24670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24670&action=edit Bug 11555 - Make "All" one of the default options for datatables There are many instances where librarians would like to have the ability to see all the rows in a datatable at one. It seems prudent to make this a default option for datatables, rather than change it on a case by case basis. Test Plan: 1) View the circulation history for a patron 2) Note you can select to view 10, 25, 50, or 100 entries 3) Apply this patch 4) Reload the circulation history page for a patron 5) Note the new "All" option 6) Verify the "All" option shows all the rows at once Signed-off-by: Jonathan Druart I tested the translation for "All" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:12:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:12:44 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 --- Comment #4 from Jonathan Druart --- Created attachment 24671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24671&action=edit Bug 11555: The menu entries are 10, 20, 50, 100, -1 If you have a look at git grep aLengthMenu, you will see we choose 20 instead of 25. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:14:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:14:09 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- (In reply to Jason Robb from comment #2) > Sorry if I did this wrong; long time listener -- first time caller. > > This patch has been applied to our production server at SEKLS and works as > expected. Yes but your production server is certainly not using a master branch :) So the patch could be work on it but not against the master branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:14:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:14:27 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:18:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:18:02 +0000 Subject: [Koha-bugs] [Bug 11605] New: DT: default entry is 20 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Bug ID: 11605 Summary: DT: default entry is 20 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The default entry is 20 and can be apply to all tables. Bug 11555 apply the menu entries to all tables, redefinition is useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:19:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:19:56 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:19:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:19:59 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 --- Comment #1 from Jonathan Druart --- Created attachment 24672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24672&action=edit Bug 11605: default entry is 20 for all tables using datatables The default entry is 20 and can be apply to all tables. Bug 11555 apply the menu entries to all tables, redefining it is uesless and can be removed. Test plan: Test pages impacted by this patch and verify there is no regression on the tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:20:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:20:13 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11555 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:20:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:20:13 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11605 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:20:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:20:44 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 --- Comment #6 from Jonathan Druart --- I submitted a followup on bug 11605. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:37:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:37:53 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:37:56 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24632|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 24673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24673&action=edit Bug 11596: Missing indexing options in koha-conf.xml should be reported To test: - Have a clean master install - Verify that koha-conf.xml contains valid entries for: zebra_bib_index_mode and zebra_auth_index_mode - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Apply the patch - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Edit your koha-conf.xml file commenting one or both indexing mode entries. - Go to More > About Koha > System information => You get "XML configuration file" warnings for each commented entry. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:38:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:38:03 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 --- Comment #4 from Jonathan Druart --- Created attachment 24674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24674&action=edit Bug 11596: Fix ergonomic issue If you had a warning on preference, the warning on the config file did not appear. To reproduce, without this patch: - switch on OPACPrivacy and set AnonymousPatron to 0. - comment at least 1 zebra_*_index_mode in your config file. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:38:46 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #5 from Jonathan Druart --- Tom?s, I provide a followup, could you agree or not with it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:48:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:48:46 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- There is already a call to the syspref delimiter in this script: my $sep_char = C4::Context->preference('delimiter') || ','; vs yours: my $delimiter = C4::Context->preference('delimiter') // ';'; I think we should use the same default delimiter. Marked as Failed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:50:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:50:43 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:50:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:50:47 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 --- Comment #9 from Jonathan Druart --- Created attachment 24675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24675&action=edit Bug 8168 - Use comma as default delimiter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:54:57 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24666|1 |0 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 12:55:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 11:55:04 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:05:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:05:23 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:05:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:05:27 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 --- Comment #7 from Jonathan Druart --- Created attachment 24676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24676&action=edit Bug 11587 - IsSuperLibrarian generates warnings (UT) Simply viewing OPAC detail triggers a modulus warning entry. This first patch adds two test cases to t/Context.t to test for this situation. TEST PLAN --------- 1) Apply this patch (to upgrade t/Context.t) 2) prove -v t/Context.t -- Tests 7 and 8 will fail 3) Apply second patch (to amend C4/Context.pm) 4) prove -v t/Context.t -- All tests will succeed Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:05:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:05:34 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24666|0 |1 is obsolete| | Attachment #24667|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 24677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24677&action=edit Bug 11587 - IsSuperLibrarian generates warnings This corrects line 1250 of C4/Context.pm to be: return ($userenv->{flags}//0) % 2; And thus avoids an uninitialized value used in the modulus. TEST PLAN --------- 1) Apply the first patch (to update t/Context.t) 2) prove -v t/Context.t -- This should fail tests 7 and 8 3) Apply this patch (to fix C4/Context.pm) 4) prove -v t/Context.t -- All tests should succeed Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:05:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:05:42 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 --- Comment #9 from Jonathan Druart --- Created attachment 24678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24678&action=edit Bug 11587 - Add UT for IsSuperLibrarian if flags == 0 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:06:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:06:30 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11587 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:06:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:06:30 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10277 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:23:28 +0000 Subject: [Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24674|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 24679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24679&action=edit Bug 11596: Fix ergonomic issue If you had a warning on preference, the warning on the config file did not appear. To reproduce, without this patch: - switch on OPACPrivacy and set AnonymousPatron to 0. - comment at least 1 zebra_*_index_mode in your config file. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:32:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:32:22 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Stefano Bargioni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni at pusc.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:36:42 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 --- Comment #10 from M. Tompsett --- installer/data/mysql/sysprefs.sql has a default value of semicolon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:39:37 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24675|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 24680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24680&action=edit Bug 8168 - Use semicolon as default delimiter installer/data/mysql/sysprefs.sql has semicolon as default. This fixes both instances to use the same fallback value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 13:41:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 12:41:09 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24680|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 24681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24681&action=edit Bug 8168 - Use semicolon as default delimiter installer/data/mysql/sysprefs.sql has semicolon as default. This fixes both instances to use the same fallback value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:02:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:02:16 +0000 Subject: [Koha-bugs] [Bug 11258] Holds queue is still making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > >6) View the holds queue, note the item is listed, though this > > patron cannot place a hold on this item > > I couldn't reproduce this. And me I see it before and after applying the patch (I rebuilt the holds queue). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:03:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:03:08 +0000 Subject: [Koha-bugs] [Bug 11258] Holds queue is still making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258 --- Comment #8 from Katrin Fischer --- Kyle, I think we need help here - could it be something is missing from the test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:09:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:09:44 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart --- Kyle, could you provide unit tests please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:15:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:15:38 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:39:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:39:06 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #29 from Jonathan Druart --- Maybe should we hide the "default privacy" entry on the categorie.pl page (form add/edit and list) if OPACPrivacy is off? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:41:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:41:40 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24471|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 24682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24682&action=edit Bug 11533: (regression test) QP breaks authority search This patch duplicates the SearchAuthority tests, with QP enabled. Searching shouldn't be affected by QP. Instructions for manually reproducing this can be read in the first comment for the bug entry. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:41:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:41:51 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:41:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:41:53 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24610|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 24683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24683&action=edit Bug 11533: fix authority searching with no sorting when QueryParser is enabled This patch fixes an issue where chosing 'None' as the sort order for an authority search would result in zero hits if QueryParser is eanbled. This patch also adds some additional test cases. To test: [1] Enable QueryParser. [2] Perform an authority search in the staff interface that uses 'Heading A-Z' as the sort order and returns hits. [3] Run the same search, but with the sort order set to 'None'. No hits are returned. [4] Apply the patch. [5] Do step 3 again. This time, hits should be returned. [6] Verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:42:03 +0000 Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24430|0 |1 is obsolete| | CC| |mtompset at hotmail.com --- Comment #22 from M. Tompsett --- Created attachment 24684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24684&action=edit Facets truncation broken for multi-byte characters You may have issues trying to git bz this. I had to upload this old-school, because I have ????????? : ???? ? ??? in the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:43:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:43:13 +0000 Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:45:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:45:16 +0000 Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #23 from M. Tompsett --- REVISED TEST PLAN ----------------- 1) Import the attached sample records. 2) Rebuild your indexes 3) In OPAC search for ????????? : ???? ? ??? -- There will be ugly diamonds with question marks in the facets 4) apply the patch 5) Search again. -- The names will be properly truncated. NOTE: This test assumes FacetLabelTruncationLength = 20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:45:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:45:40 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Severity|enhancement |normal --- Comment #1 from Nicole C. Engard --- Somehow this was marked enhancement instead of bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:46:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:46:50 +0000 Subject: [Koha-bugs] [Bug 11604] editing patron error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11604 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- Since 3.8 has been stable for quite some time now I suspect this is an issue specific to your installation or to the VirtualBox image. I suggest raising this issue on the Koha mailing list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:52:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:52:23 +0000 Subject: [Koha-bugs] [Bug 6902] Add integration for EBSCO's Novelist Select service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11606 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:52:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:52:23 +0000 Subject: [Koha-bugs] [Bug 11606] New: Novelist Select in Staff Client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Bug ID: 11606 Summary: Novelist Select in Staff Client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 6902 It would be great if the Novelist Select content could show in the staff client as well as the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:56:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:56:17 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #4 from Holger Mei?ner --- Created attachment 24685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24685&action=edit [PATCH 1/5] Bug 7413: Allow OPAC renewal x days before due date Currently multiple renewals can be done in immediate succsession. To optionally prevent this, a new parameter "No renewals before" is introduced. This patch adds issuingrules.norenewalbefore to the database. Default value is NULL. To test: 1) Run installer/data/mysql/updatedatabase.pl. 2) Create a SQL report like: SELECT * FROM issuingrules 3) Confirm that norenewalbefore was added after renewalperiod. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:58:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:58:09 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #5 from Holger Mei?ner --- Created attachment 24686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24686&action=edit [PATCH 2/5] Bug 7413: Allow OPAC renewal x days before due date This patch adds a column "No renewal before" to the circulation and fine rules. To test: 1) Add or edit some issuing rules. 2) Confirm that an empty entry, zero and non-numerical values for "No renewal before" are converted into undefined. 3) Confirm that numerical values can be entered and saved. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 14:59:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 13:59:19 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #6 from Holger Mei?ner --- Created attachment 24687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24687&action=edit [PATCH 3/5] Bug 7413: Allow OPAC renewal x days before due date This patch modifies CanBookBeRenewed in Ciculation.pm, so that based on issuingrules.norenewalbefore a new error "too_soon" can be returned. For this error intranet HTML templates will display "Not renewable yet" instead of "Not renewable". To test: 1) Create an issuing rule with "No renewal before" set to value X and "Unit" set to days. 2) Confirm that items can't be renewed if current date is more than X days before due date. 3) Confirm that items can be renewed if "No renewal before" is undefined or current date is X or less days before due due. 4) Confirm that "Renewals allowed (count)" has priority, i.e. if the number of allowed renewals is exceeded "Not renewable" is displayed, no matter what "No renewal before" is set to. 5) Test the same things with "Unit" set to hours. 6) Test for both circulation.tt and moremember.tt. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:00:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:00:25 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #7 from Holger Mei?ner --- Created attachment 24688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24688&action=edit [PATCH 4/5] Bug 7413: Allow OPAC renewal x days before due date This patch makes the bootstrap version of opac-user.tt handle the new renewal error "too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Test the sames things as in previous patch, only for opac-user.tt. 3) Confirm that additionally to "Not renewable yet", the number of remaining renewals is displayed. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:01:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:01:42 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #8 from Holger Mei?ner --- Created attachment 24689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24689&action=edit [PATCH 5/5] Bug 7413: Allow OPAC renewal x days before due date This patch makes the prog version of opac-user.tt handle the new renewal error "too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:03:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:03:34 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:04:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:04:27 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24668|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 24690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24690&action=edit Bug 9823: Refactor return from GetReservesFromBiblionumber The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaing a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. Signed-off-by: Marcel de Rooy Placed biblio holds, future holds and item holds. Works as expected. Tested Holds.t and Reserves.t. Pass. Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. Fine. C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. Looks good. Handled a few unneeded calls in QA follow-up. Left only one point to-do for serials/routing-preview.pl. See Bugzilla. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:04:40 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:04:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:04:44 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24669|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 24691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24691&action=edit Bug 9823: QA follow-up for GetReservesFromBiblionumber calls The template params holds and holdcount are not used in the ISBD template. Removed the associated code from catalogue/ISBDdetail.pl. Same applies for catalogue/MARCdetail.pl and labeledMARCdetail.pl. Same applies also for catalogue/imageviewer.pl. Same applies also for catalogue/moredetail.pl. In catalogue detail.tt only the number of holds is used. Removed the code that passed the holds array to the template. For consistency opac-detail should also incorporate future holds into its holds count; added the all_dates parameter for that reason. The Reserves module is no longer needed in moredetail. Removed it. Checked the other scripts also. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:05:32 +0000 Subject: [Koha-bugs] [Bug 11533] "use" QueryParser breaks authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton --- Pushed to master. Thanks for the regression test, Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:21:37 +0000 Subject: [Koha-bugs] [Bug 10920] Add a syspref regarding the use of basket groups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10920 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10973 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:21:37 +0000 Subject: [Koha-bugs] [Bug 10973] Make the use of basketgroup an option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10920 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 24 15:24:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Jan 2014 14:24:36 +0000 Subject: [Koha-bugs] [Bug 11607] New: items.content does not contain any formatting when HTML message is selected. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Bug ID: 11607 Summary: items.content does not contain any formatting when HTML message is selected. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: bartonski at gmail.com QA Contact: testopia at bugs.koha-community.org In DUEDGST and PREDUEDGST messages, the detail generated by <> does not contain any HTML formatting. Without line breaks, all of the detail renders on a single line when viewed in email. As a work around, items.content may be surrounded by 
                   tags, or 'HTML
Message' may be de-selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:26:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:26:28 +0000
Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on
	parcel.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:26:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:26:32 +0000
Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on
	parcel.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24559|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 24692
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24692&action=edit
Bug 11314 - Restore ability to see only 5 entries on parcel.pl

Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows,
as well as the "sticky" feature. It is trivial to restore this
functionality. These datatables are already using bStateSave, so are
they are "sticky" already. The only part left is to enable the
ability to limit the table to 5 rows at a time.

Test Plan:
1) Apply this patch
2) Browse to parcel.pl
3) Note the default rows count is still 10
4) Note the option to limit the row count to 5

Signed-off-by: David Cook 

Works as described.

Double-checked that the "sticky" feature is still in place thanks
to bStateSave.

I didn't notice a difference due to iDisplayLength being added, but
the extra option of "5" to the list is there.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:26:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:26:38 +0000
Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on
	parcel.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314

--- Comment #4 from Jonathan Druart  ---
Created attachment 24693
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24693&action=edit
Bug 11314: Make "All" translatable

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:29:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:29:28 +0000
Subject: [Koha-bugs] [Bug 11608] New: don't need the word 'library' on funds
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

            Bug ID: 11608
           Summary: don't need the word 'library' on funds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/acqui/acqui-home.pl
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: nengard at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Most libraries have the word library in their name - and even if they don't
showing 'library' next to the library's name is not really necessary on the
list of acq funds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:29:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:29:57 +0000
Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on
	parcel.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co
                   |y.org                       |m

--- Comment #5 from Jonathan Druart  ---
I am not sure to understand what bStateSave does.
If I click on the "Filter" button (on the left side of parcel.pl), the value
become again the default value (10).
Since bug 11555 and bug 11605 make "All" translatable, I added a followup to
keep the translation on this page.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:34:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:34:00 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

--- Comment #1 from Nicole C. Engard  ---
Created attachment 24694
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24694&action=edit
Library 2 times

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:37:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:37:16 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:37:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:37:19 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

--- Comment #2 from Nicole C. Engard  ---
Created attachment 24695
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24695&action=edit
[Bug 11608] Remove the word 'library' from funds list

The list of funds on the main acq page shows the library's name
followed by the word 'library'. I don't think this word is necessary
as most libraries have the word 'library' in their names. Even
if they don't they probably just want their library name to show
without extra words.

To test:

* Visit the acquisitions module before applying
* See the library's name + 'library' above the funds list
* Apply patch
* Look again at funds list and 'library' should be gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:48:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:48:22 +0000
Subject: [Koha-bugs] [Bug 9717] localuse recorded for holds/transfers
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:48:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:48:28 +0000
Subject: [Koha-bugs] [Bug 9717] localuse recorded for holds/transfers
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:48:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:48:39 +0000
Subject: [Koha-bugs] [Bug 9717] localuse recorded for holds/transfers
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.8                         |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:50:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:50:54 +0000
Subject: [Koha-bugs] [Bug 6504] no way to enter shipping price in acq
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6504

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #22 from Nicole C. Engard  ---
Fixed with another patch ages ago

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:50:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:50:55 +0000
Subject: [Koha-bugs] [Bug 929] See details of a budget
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

Bug 929 depends on bug 6504, which changed state.

Bug 6504 Summary: no way to enter shipping price in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6504

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:56:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:56:13 +0000
Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

--- Comment #30 from Jonathan Druart  ---
All seems good to me.
It would have been good to have several patches instead of one (for indentation
and wording fixes).
I still don't think it is a good idea to call Koha::Database in script file but
it seems this idea does not win unanimous support.

I will provide 1 patch with 2 small fixes.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:57:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:57:31 +0000
Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #31 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #29)
> Maybe should we hide the "default privacy" entry on the categorie.pl page
> (form add/edit and list) if OPACPrivacy is off?

I asked to Katrin on the IRC and she answered me:

cait: I wonder if a library would want to clean the history for certain patron
categories without the patron being able to choose how they do it
cait: i mean they could use the cronjob with a special setting for some patron
categories... even if you don't let the patrons choose their setting
so if that would work... maybe it should always be visible

Which is make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:57:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:57:51 +0000
Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23520|0                           |1
        is obsolete|                            |

--- Comment #32 from Jonathan Druart  ---
Created attachment 24696
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24696&action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds a new field "default privacy" to the patron
categories such that each patron category may have a different default
privacy setting.

Test Plan:
1) Apply this patch
2) Edit a patron category, change the default privacy to "forever"
3) Create a new patron of that category
4) Log into the catalog as that patron, verify the privacy setting
   is set to "forever"
5) Repeat steps 2-4 with the settings "never" and "default"

Signed-off-by: Joel Sasse 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:57:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:57:57 +0000
Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23987|0                           |1
        is obsolete|                            |

--- Comment #33 from Jonathan Druart  ---
Created attachment 24697
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24697&action=edit
Bug 6254 [QA Followup 1] - can't set patron privacy by default

* Adds default privacy column to summary table
* Adds default privacy to delete category summary
* Adds "AFTER categorycode" to the database update
* Whitespace cleanup and formatting for affected code blocks
* Switch basic DBI queries to DBIx::Class to simplify code
* Adds reference to misc/cronjobs/batch_anonymise.pl to description

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:58:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:58:04 +0000
Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24606|0                           |1
        is obsolete|                            |

--- Comment #34 from Jonathan Druart  ---
Created attachment 24698
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24698&action=edit
Bug 6254 [QA Followup 2] - can't set patron privacy by default

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:58:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 14:58:10 +0000
Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #35 from Jonathan Druart  ---
Created attachment 24699
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24699&action=edit
Bug 6254: QA FIX: remove trailing whitespaces

This patch removes trailing whitespaces/tab and fix the fields order in
the updatedb entry (according to the kohastructure.pl).

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:04:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:04:43 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:04:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:04:47 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

--- Comment #3 from Jonathan Druart  ---
Created attachment 24700
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24700&action=edit
Bug 11608: Remove the word 'library' from funds list

The list of funds on the main acq page shows the library's name
followed by the word 'library'. I don't think this word is necessary
as most libraries have the word 'library' in their names. Even
if they don't they probably just want their library name to show
without extra words.

To test:

* Visit the acquisitions module before applying
* See the library's name + 'library' above the funds list
* Apply patch
* Look again at funds list and 'library' should be gone

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:05:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:05:39 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24695|0                           |1
        is obsolete|                            |
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:09:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:09:03 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24700|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 24701
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24701&action=edit
Bug 11608: Remove the word 'library' from funds list

The list of funds on the main acq page shows the library's name
followed by the word 'library'. I don't think this word is necessary
as most libraries have the word 'library' in their names. Even
if they don't they probably just want their library name to show
without extra words.

To test:

* Visit the acquisitions module before applying
* See the library's name + 'library' above the funds list
* Apply patch
* Look again at funds list and 'library' should be gone

Signed-off-by: Jonathan Druart 
Amended patch: remove a space

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:09:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:09:10 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

--- Comment #5 from Jonathan Druart  ---
Created attachment 24702
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24702&action=edit
Bug 11608: Delete unused commented lines in template

On the way, these lines are commented and can be deleted safely.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:15:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:15:16 +0000
Subject: [Koha-bugs] [Bug 4090] subscription ID showing in OPAC - confusing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4090

--- Comment #4 from Nicole C. Engard  ---
I was going to tackle this, but now there is a filter on the left that lets you
choose a subscription number to filter on - again this makes no sense to
patrons who have no idea that this subscription for People magazine is #12 (or
whatever).  Do we really need this filter on subscription ID number in the
OPAC?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:22:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:22:56 +0000
Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the
	translate script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #4 from Jonathan Druart  ---
Since it is a regression, easier to test and makes me waste a lot of time (on
testing translation), I consider this bug as major.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:23:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:23:36 +0000
Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the
	translate script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571

--- Comment #5 from Jonathan Druart  ---
s/easier/easy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:26:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:26:36 +0000
Subject: [Koha-bugs] [Bug 10580] Remove NoZebra reference from Makefile.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10580

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:26:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:26:41 +0000
Subject: [Koha-bugs] [Bug 10580] Remove NoZebra reference from Makefile.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10580

--- Comment #1 from Tom?s Cohen Arazi  ---
Created attachment 24703
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24703&action=edit
Bug 10580: Zebra no more optional in Koha setup

Running Makefile.PL asks the user whether to install the Zebra configuration
files and different texts relate to the user having chosen to use Zebra.

This patch removes references to choosing to use Zebra and removes the related
variables from the code.

To test:
- Apply the patch
- Go through the different install modes
- Verify that nothing nothing is broken
- Sign off

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:31:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:31:11 +0000
Subject: [Koha-bugs] [Bug 10580] Remove NoZebra reference from Makefile.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10580

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24703|0                           |1
        is obsolete|                            |

--- Comment #2 from Tom?s Cohen Arazi  ---
Created attachment 24704
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24704&action=edit
Bug 10580: Zebra no more optional in Koha setup

Running Makefile.PL asks the user whether to install the Zebra configuration
files and different texts relate to the user having chosen to use Zebra.

This patch removes references to choosing to use Zebra and removes the related
variables from the code.

To test:
- Apply the patch
- Go through the different install modes
- Verify that nothing nothing is broken
- Sign off

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:50:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:50:47 +0000
Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272

--- Comment #1 from Nicole C. Engard  ---
Created attachment 24705
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24705&action=edit
[BUG 11272] Add second submit button to inventory

The inventory tool allows for 2 ways of processing files. The first
is to upload a file. The second is to generate the shelf list.
Most libraries think they have to fill in all fields because the
submit button is at the bottom of the second option. They do not.
This patch adds a second submit button under the first method to
make this clearer.

To test:

* Generate a file of barcodes for inventorying
* Before applying the patch use the file upload method to mark as seen
* Apply the patch
* Use the file upload method to mark as seen using the new submit
* Repeat the above for the shelf list method
* Confirm that inventory still works as expected with 2 buttons

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:50:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:50:44 +0000
Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:51:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:51:13 +0000
Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:57:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:57:13 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #17 from Katrin Fischer  ---
I see that we use those patches locally on 3.12.7 and wonder why I marked it
resolved fixed. Resetting to pushed to stable to get it checked for
backporting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:57:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:57:23 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:57:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:57:45 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:57:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:57:56 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:58:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 15:58:05 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:05:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 16:05:26 +0000
Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the
	translate script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:05:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 16:05:29 +0000
Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the
	translate script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24484|0                           |1
        is obsolete|                            |

--- Comment #6 from M. Tompsett  ---
Created attachment 24706
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24706&action=edit
[SIGNED OFF] Bug 11571 - FIX regression introduced by bug 7934

Bug 7934 breaks the -f option introduced in bug 9161.

While the generation of the command tmpl_process3.pl, a space is
missing if the -x option is given.
The tmpl_process3.pl is called like:
/home/koha/src/misc/translator/tmpl_process3.pl -q update -i
/home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ -s
/home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po -r
-x 'help'-f pay.tt

Revised test plan:
1) cd ./misc/translator
2) put a warn at LangInstaller.pm line 375.
3) time ./translate update fr-FR -f pay.tt
-- note the execution time and the output. The options in the
    command contain "-x 'help'-f pay.tt"
    The -f param is not passed to the script.
    The execution time is strangely long.
5) git reset --hard origin/master
6) apply this patch
7) put a warn at LangInstaller.pm line 375.
8) time ./translate update fr-FR -f pay.tt
-- verify the output and the execution time is now corrected.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:29:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 16:29:31 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #57 from Jonathan Druart  ---
It seems I cannot deactivate the 2 values claimacquisition and claimissues (on
editing a supplier). The 2 checkboxes are always checked.
I don't see (in the code) where you check the aqcontacts.claimacquisition flag
before sending a claim for late orders.
It seems only the first contact is notified, is it wanted?

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:29:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 16:29:43 +0000
Subject: [Koha-bugs] [Bug 11609] New: organize suggestions by library
 doesn't appear to work
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11609

            Bug ID: 11609
           Summary: organize suggestions by library doesn't appear to work
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 24707
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24707&action=edit
suggestions by library

See attached.  You can see that the suggestions all have libraries associated
with them, but the tab says 'unknown'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:32:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 16:32:10 +0000
Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the
	translate script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571

--- Comment #7 from Jonathan Druart  ---
> -- verify the output and the execution time is now corrected.
s/is/are
...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:32:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 16:32:20 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #25 from M. Tompsett  ---
Comment on attachment 24586
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24586
Bug 8753 - Add forgot password link to OPAC

Review of attachment 24586:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8753&attachment=24586)
-----------------------------------------------------------------

::: opac/opac-password-recovery.pl
@@ +102,5 @@
> +            email                   => HTML::Entities::encode($email),
> +        );
> +    }
> +    else {
> +        #generate uuid and send recovery email

Bug 11575 has:
    ($in->{'query'}->https() ? "https://" : "http://")
$query->https() may be what you need. Some way of passing that to
SendPasswordRecoveryEmail, so you don't hardcode http or https.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:13:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:13:49 +0000
Subject: [Koha-bugs] [Bug 9858] Add button in "Search Engine Configuration"
 is not working.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9858

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:32:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:32:26 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24636|0                           |1
        is obsolete|                            |
  Attachment #24637|0                           |1
        is obsolete|                            |
  Attachment #24638|0                           |1
        is obsolete|                            |
  Attachment #24639|0                           |1
        is obsolete|                            |
  Attachment #24640|0                           |1
        is obsolete|                            |
  Attachment #24641|0                           |1
        is obsolete|                            |
  Attachment #24642|0                           |1
        is obsolete|                            |
  Attachment #24643|0                           |1
        is obsolete|                            |
  Attachment #24644|0                           |1
        is obsolete|                            |
  Attachment #24645|0                           |1
        is obsolete|                            |
  Attachment #24646|0                           |1
        is obsolete|                            |
  Attachment #24647|0                           |1
        is obsolete|                            |
  Attachment #24648|0                           |1
        is obsolete|                            |
  Attachment #24649|0                           |1
        is obsolete|                            |

--- Comment #173 from Kyle M Hall  ---
Created attachment 24708
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24708&action=edit
Bug 7180: Order from staged file improvements

This patch adds:
- 1 syspref MarcFieldsToOrder
- 1 ajax script acqui/ajax-getauthvaluedropbox.pl
- 1 routine C4::Budgets::GetBudgetByCode

Before this patch you were not able to order 1 or all the records from
your staged file. You were allowed to specify some information ("Import All"
and "Accounting details" areas) for the order.

With this patch, the previous behaviours still exist.
But now you can *select* which records you want to ordered.
For these ones you can specify independently informations (Quantity,
price, budget, sort1 and sort2).
The cherry on the cake is that you can pre-fill these information with
values

Test plan:
1. Fill the new syspref MarcFieldsToOrder with something like:
==BEGIN==
price: 947$c
quantity: 969$h
budget_code: 922$a
rrp: 010$d
discount: 969$d
sort1: 923$a
sort2: 924$a

==END==
The empty line at the end is mandatory!
The budget (corresponding to your budget_code) can be filled with
authorized value categories (statistic 1 and 2).
The sort1 and sort2 values can be filled with the an authorized value
(of the category previously selected)

2. Choose randomly one or more biblio(s) and fill fields with what is relevant.

3. Export the biblio and import it (with the "Stage MARC records for
import" tool).

4. Go on a basket and add an order from a staged file. Select your
staged file.

5. Well. Now you can see your biblio (or biblios if your had exported
more than one). For each one, informations should be pre-filled with the
biblio values. The budget should be selected on the budget corresponding
to the budget_code (in the field 922$a) and the "planning values" too
(with fields 923$a and 924$a).
You can modify these values (or not) and choose a default value for
budget and planning values (in the "Accounting details" area).

6. Save and check the prices values. Modify the order and check that
budget and sort* are good

Prices are calculated following some parameters:
if there is no price => listprice = 0
else =>
  - the gstrate value for your order is the gstrate value of the bookseller
  - discount = if filled : the discount value / 100
               else: the discount value of the bookseller
  - if the bookseller includes tax( List item price includes tax: Yes )
        if a discount exists:
            ecost = price
            rrp   = ecost / ( 1 - discount )
        else: # a discount does not exist
            ecost = price * ( 1 - discount )
            rrp   = price
    else # the bookseller does not include tax
        if a discount exists:
            ecost = price / ( 1 + gstrate )
            rrp   = ecost / ( 1 - discount )
        else: # a discount does not exist
            rrp   = price / ( 1 + gstrate )
            ecost = rrp * ( 1 - discount )
  - in all cases:
        listprice = rrp / currency rate
        unitprice = ecost
        total = ecost * quantity

7. Retry with different parameters

8. Check the 'Import all' action still works

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:32:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:32:42 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #174 from Kyle M Hall  ---
Created attachment 24709
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24709&action=edit
Bug 7180: FIX getAuthValueDropbox should display the selected value

If the no AV match the name/category or if no category is defined, the
input field should contain the value.

Signed-off-by: Pierre Angot 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:32:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:32:47 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #175 from Kyle M Hall  ---
Created attachment 24710
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24710&action=edit
Bug 7180: Add UT for C4::Budgets::GetBudgetByCode

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:32:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:32:52 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #176 from Kyle M Hall  ---
Created attachment 24711
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24711&action=edit
Bug 7180: QA followup

Ergonomic improvements:
- Remove the green color the selected record.
- Use fieldset.rows (and legend).
- Use the required css class for quantity inputs.
- Replace "budget" with "fund".
- fix the "undefined" string
- Add a "show MARC" link
- replace "no_match" with a text.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:32:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:32:56 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #177 from Kyle M Hall  ---
Created attachment 24712
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24712&action=edit
Bug 7180: The default quantity is 1

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:00 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #178 from Kyle M Hall  ---
Created attachment 24713
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24713&action=edit
Bug 7180: Follow-up fixing minor issues

- Fixed some labels from Budget to Fund
- Added the system preference to sysprefs.sql
- Fixed some untranslatable Javascript strings

Signed-off-by: Jonathan Druart 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:06 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #179 from Kyle M Hall  ---
Created attachment 24714
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24714&action=edit
Bug 7180: Change syspref description

- the blank line is now useless
- add an example for the syspref value

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:11 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #180 from Kyle M Hall  ---
Created attachment 24715
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24715&action=edit
Bug 7180: Adapt neworderempty code (js function moved).

The js function fetchSortDropbox has been deleted in previous patch.
The new function is getAuthValueDropbox.

Test plan:
- link some av to some funds
- open an existing order and verify value are correctly filled in the
  sort1 and sort2 values
- create a new order and verify behavior is the same as before

Note: This patch generates 2 ajax queries (max) if the budget is linked
to 2 av categories for sort1 and sort2. This could be improved using a
template plugin for values display on load.

Signed-off-by: Jonathan Druart 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:15 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #181 from Kyle M Hall  ---
Created attachment 24716
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24716&action=edit
Bug 7180: FIX License version

Signed-off-by: Jonathan Druart 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:19 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #182 from Kyle M Hall  ---
Created attachment 24717
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24717&action=edit
Bug 7180: QA followup

- fix unit tests (use a transaction).
- add 3 tabs on the page in order to be more understandable.
- fix a warn in logs

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:23 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #183 from Kyle M Hall  ---
Created attachment 24718
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24718&action=edit
Bug 7180 - QA Followup - Correct minor language issues

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:28 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #184 from Kyle M Hall  ---
Created attachment 24719
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24719&action=edit
Bug 7180: Restore the "Add order" link

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:32 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #185 from Kyle M Hall  ---
Created attachment 24720
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24720&action=edit
Bug 7180: Remove useless rrp variable

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:33:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:33:42 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #186 from Kyle M Hall  ---
Created attachment 24721
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24721&action=edit
Bug 7180: FIX: discount was divided by 100 twice.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:44:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:44:56 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:47:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 17:47:47 +0000
Subject: [Koha-bugs] [Bug 11014] Slip Print Problem in Chrome
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11014

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 22:19:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 21:19:31 +0000
Subject: [Koha-bugs] [Bug 8760] Phone number Field tags are reversed in
	patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760

Joel Sasse  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsasse at plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:46:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 22:46:52 +0000
Subject: [Koha-bugs] [Bug 8760] Phone number Field tags are reversed in
	patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760

--- Comment #2 from Joel Sasse  ---
Created attachment 24722
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24722&action=edit
Patron data in the OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:47:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 22:47:36 +0000
Subject: [Koha-bugs] [Bug 8760] Phone number Field tags are reversed in
	patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760

--- Comment #3 from Joel Sasse  ---
Created attachment 24723
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24723&action=edit
Patron data in the staff client

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:48:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 22:48:06 +0000
Subject: [Koha-bugs] [Bug 8760] Phone number Field tags are reversed in
	patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760

--- Comment #4 from Joel Sasse  ---
Created attachment 24724
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24724&action=edit
Patron data in the database schema

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:50:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2014 22:50:43 +0000
Subject: [Koha-bugs] [Bug 8760] Phone number Field tags are reversed in
	patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760

--- Comment #5 from Joel Sasse  ---
I've attached some additional screenshots highlighting this issue. These
mismatched labels cause confusion when processing patron requests for
modifications to their personal details.

Also, why do the three values each have a different variable type in the
database? Phone is text, mobbile is varchar, and fax is mediumtext. Is there a
reason for this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 03:01:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 02:01:32 +0000
Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325

--- Comment #4 from Ian Palko  ---
In 3.14.01 the bug is even worse ...

Now, the focus is not by default on the "add barcode" field, but when data is
entered into this field, whether by scanner or keyboard, focus is immediately
sent to the "search the catalog" field at the top of the page.

This makes it impossible to create lists except by searching for the item in
the catalog and adding it to the list from the biblio details.

Perhaps our library just disproportionately affected because of needing to
clean up an imported database with lots of records needing to be merged, but it
seems that whatever patches were applied between 3.12 and 3.14.01 have
effectively broken this part of the list feature. 

That doesn't seem to me to be a "low minor bug". A seriously broken feature
doesn't seem minor, or low priority.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 03:39:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 02:39:53 +0000
Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325

--- Comment #5 from Ian Palko  ---
If it helps, I've done some playing around to try to contribute more than just
complaints. I think I know why the bug is happening and have a few ways to try
to solve it, but have no idea how to patch things or use git, etc.

Here goes:

The focus problem is because shelves.tt calls [% INCLUDE 'cat-search.inc' %].
This include gives #findborrower the class "focus". jQuery then assigns the
focus to this field which is hidden on this page by default. The catalog search
is visible by default.

I fixed the jumpy cursor by editing shelves.tt and adding 'class="focus"'. This
does not give it focus, #findborrower still steals it, but at least now data
can be entered.

It seems that having the include give focus to #findborrower is a bad way of
defaulting. Rather each tt should independently give focus to the proper
element for this page.

Thus, the solution seems to be to edit cat-search.inc, removing focus from
#findborrower, then on each tt page assign focus to the appropriate field.

Another default is to throw some javascript in that steals focus back to the
field we would want.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 05:11:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 04:11:55 +0000
Subject: [Koha-bugs] [Bug 8698] OPAC export "Save Record" for Dublincore XML
 for some records triggers error logs.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8698

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #2 from M. Tompsett  ---
I decided to attempt it again more recently. It seems to have corrected itself.
I can't duplicate it anymore. I suppose whatever code that was causing this
problem was corrected between versions in use (3.6.3 tarball, if I recall, vs.
3.14 custom-rolled packages).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:20:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:20:49 +0000
Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to
	left).
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

--- Comment #6 from Katrin Fischer  ---
Owen, could you maybe provide a patch here? I am not sure anyone else
understands how this works right now (including me) :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:38:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:38:41 +0000
Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte
	characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

--- Comment #24 from Katrin Fischer  ---
Created attachment 24725
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24725&action=edit
[PASSED QA] Bug 9579: Facets truncation broken for multi-byte characters

We seem to be relying on whatever Zoom::Results->render return, and
Perl doesn't explicitly consider it UNICODE data. That's why CORE::substr
(and probably CORE::length too) cut the bytes wrong.

This patch just decodes the UTF-8 data that render() returns and then
Perl behaves, heh.

It uses Encode::decode_utf8 which is already a dependency for the current
stable Koha releases.

REVISED TEST PLAN
-----------------
1) Import the attached sample records.
2) Rebuild your indexes
3) In OPAC search for ????????? : ???? ? ???
-- There will be ugly diamonds with question marks in the facets
4) apply the patch
5) Search again.
-- The names will be properly truncated.
NOTE: This test assumes FacetLabelTruncationLength = 20.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Mark Tompsett 
Signed-off-by: Katrin Fischer 
Passes all tests and QA script.
Works as described, tested with several German, English and
the Arabic test record. Arabic strings now display correctly
and no regression was found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:39:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:39:10 +0000
Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte
	characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24684|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:39:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:39:08 +0000
Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte
	characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:45:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:45:56 +0000
Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the
	basket page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:45:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:45:59 +0000
Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the
	basket page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24652|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer  ---
Created attachment 24726
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24726&action=edit
[PASSED QA] Bug 11579: Show ordernumber in basket.pl tables

Test plan:
Verify the ordernumber is correctly displayed on the basket page
(acqui/basket.pl?basketno=X)

Signed-off-by: silvere 
Signed-off-by: Katrin Fischer 
Fixed a tiny typo in the HTML:  > .
Passes all tests and QA script.
Tested that the ordernumber is now displayed and table sorting
works for the smaller and more detailed table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:50:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:50:27 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:50:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:50:30 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24701|0                           |1
        is obsolete|                            |
  Attachment #24702|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer  ---
Created attachment 24727
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24727&action=edit
[PASSED QA] Bug 11608: Remove the word 'library' from funds list

The list of funds on the main acq page shows the library's name
followed by the word 'library'. I don't think this word is necessary
as most libraries have the word 'library' in their names. Even
if they don't they probably just want their library name to show
without extra words.

To test:

* Visit the acquisitions module before applying
* See the library's name + 'library' above the funds list
* Apply patch
* Look again at funds list and 'library' should be gone

Signed-off-by: Jonathan Druart 
Amended patch: remove a space

Signed-off-by: Katrin Fischer 
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 09:50:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 08:50:40 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

--- Comment #7 from Katrin Fischer  ---
Created attachment 24728
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24728&action=edit
[PASSED QA] Bug 11608: Delete unused commented lines in template

On the way, these lines are commented and can be deleted safely.

Signed-off-by: Jonathan Druart 
Signed-off-by: Katrin Fischer 
Removes an HTML comment with unused code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:05:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 09:05:32 +0000
Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the
	translate script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:05:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 09:05:35 +0000
Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the
	translate script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24706|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer  ---
Created attachment 24729
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24729&action=edit
[PASSED QA] Bug 11571 - FIX regression introduced by bug 7934

Bug 7934 breaks the -f option introduced in bug 9161.

While the generation of the command tmpl_process3.pl, a space is
missing if the -x option is given.
The tmpl_process3.pl is called like:
/home/koha/src/misc/translator/tmpl_process3.pl -q update -i
/home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ -s
/home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po -r
-x 'help'-f pay.tt

Revised test plan:
1) cd ./misc/translator
2) put a warn at LangInstaller.pm line 375.
3) time ./translate update fr-FR -f pay.tt
-- note the execution time and the output. The options in the
    command contain "-x 'help'-f pay.tt"
    The -f param is not passed to the script.
    The execution time is strangely long.
5) git reset --hard origin/master
6) apply this patch
7) put a warn at LangInstaller.pm line 375.
8) time ./translate update fr-FR -f pay.tt
-- verify the output and the execution time is now corrected.

Signed-off-by: Mark Tompsett 
Signed-off-by: Katrin Fischer 
Passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:08:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 09:08:36 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Koha cannot retreive big    |Koha cannot retrieve big
                   |records from Zebra          |records from Zebra

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:37:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 09:37:51 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #51 from Katrin Fischer  ---
Tomas, I am sorry, but I have problem to resolve the conflict in Search.t in
the first patch and have the following patches apply. Can you please take a
look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:39:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 09:39:12 +0000
Subject: [Koha-bugs] [Bug 11258] Holds queue is still making transfer
 requests that contradict the branch holds policy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 11:38:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 10:38:49 +0000
Subject: [Koha-bugs] [Bug 11610] New: Serial summary page shows library code
 instead of description
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11610

            Bug ID: 11610
           Summary: Serial summary page shows library code instead of
                    description
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

On the serial summary page where all subscriptions for a serial can be viewed
the table shows the branchcode instead of the branch description.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 11:44:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 10:44:55 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #20 from Katrin Fischer  ---
I am sorry Jonathan, but there is a problem:

- I have a subscription with 3 issues:
  - Arrived
  - Missing (sold out)
  - Expected

When I go to the staff detail page, 2 issues are shown in the subscription tab.
Only the "Arrived" status displays, the other status that should be "Missing
(sold out)" is empty. On the OPAC detail page the display is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 11:48:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 10:48:10 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

--- Comment #21 from Katrin Fischer  ---
Everything else I checked so far was ok, copying my testing notes here for
later use :)

Checked:
- Receiving issues, setting and unsetting new status
- Display on serial summary page
- Display on subscription detail page, issues tab
- Display on OPAC and staff detail pages, subscription tab
    OPAC: ok     
    Staff: NOT OK - Missing status not shown
- Claiming issues, filtering and status display

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 11:54:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 10:54:48 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #43 from Katrin Fischer  ---
Kyle, please also check my other comments (comment 36 and comment 37). 

I would feel better about this if you split the first patch, so that the
"traditional" database update parts and the Schema update were separate.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 11:54:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 10:54:56 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 12:21:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 11:21:39 +0000
Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 12:21:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 11:21:42 +0000
Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24413|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer  ---
Created attachment 24730
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24730&action=edit
[PASSED QA] Bug 10955 - Add ability to skip deletions in zebraqueue

It seems that record deletions can cause extreme slowdowns for Koha
installations with extremely large numbers of records. It would be
helpful to be able to skip record deletions when processing the
zebraqueue with rebuild_zebra.pl so the deletions can be processed with
a lower frequency.

Test Plan:
1) Disable any zebra indexing cronjobs you may have
2) Delete a record
3) Note the operation recordDelete in the zebraqueue table having done = 0
4) Run misc/migration_tools/rebuild_zebra.pl -b -z --skip-deletes
5) Note the delete still has done = 0
6) Run misc/migration_tools/rebuild_zebra.pl -b -z
7) Note the delete now has done = 1

Signed-off-by: Jonathan Druart 
Signed-off-by: Katrin Fischer 
Passes all tests and QA script.
Also tested for authorities, no problems found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 12:45:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 11:45:24 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #19 from Katrin Fischer  ---
Sorry, but there is a bug:

Testing notes:
- Record with 1 lost item, result list = 1
  - Verified without both patches 404 error page is shown
  - Verified with 1st patch, no results page is shown
  - Verified with 2nd patch, the still showing facets are gone
- Record with 1 lost item, result list > 1
  - Record is hidden from result list, but
    - result count is wrong
    - result numbering is wrong
    > This is an old problem, just noting
- Record with 1 lost and 1 available item, result list = 1
  - Detail page is shown, only lost item is hidden
- Record with 1 ost and 1 available item, result list > 1
  - Only available item is shown in result list
  BUT: FACETS ARE HIDDEN.

I think the problem was introduced by the second patch, but since it fixes a
problem with the first patch, it also needs to be fixed before either patch can
be passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 13:10:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 12:10:02 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

--- Comment #18 from Katrin Fischer  ---
Hi Robin, I tried ... and failed. Could you adapt your hints a bit for testing
with a dev installation?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 15:27:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 14:27:41 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24490|0                           |1
        is obsolete|                            |

--- Comment #52 from Tom?s Cohen Arazi  ---
Created attachment 24731
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24731&action=edit
Bug 11096: (follow-up) add direct regression tests

This adds direct tests of indexing and retrieving
bib records that are larger than the ISO2709 limit
of 99,999 octets.

To test: verify that prove -v t/db_dependent/Search.t passes.

Signed-off-by: Galen Charlton 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Chris Cormack 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 15:30:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 14:30:43 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 15:30:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 14:30:48 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24491|0                           |1
        is obsolete|                            |

--- Comment #53 from Tom?s Cohen Arazi  ---
Created attachment 24732
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24732&action=edit
Bug 11096 - Wrap each test set configuration into a subtest

This makes it easier to read. Also fixes the test count, and is rebased
against 11499 which is needed to correctly test the patches for this bug
(i.e. indexing mode needs to be correctly set in koha-conf.xml)

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 15:50:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 14:50:37 +0000
Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte
	characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |3.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 15:56:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 14:56:14 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #54 from Katrin Fischer  ---
Hm, the tests are failing for me:
...
t/db_dependent/Search.t .. 4/4 # Looks like you failed 2 tests of 4.
t/db_dependent/Search.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/4 subtests 

Test Summary Report
-------------------
t/db_dependent/Search.t (Wstat: 512 Tests: 4 Failed: 2)
  Failed tests:  1-2
  Non-zero exit status: 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:00:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:00:59 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #55 from Tom?s Cohen Arazi  ---
(In reply to Katrin Fischer from comment #54)
> Hm, the tests are failing for me:
> ...
> t/db_dependent/Search.t .. 4/4 # Looks like you failed 2 tests of 4.
> t/db_dependent/Search.t .. Dubious, test returned 2 (wstat 512, 0x200)
> Failed 2/4 subtests 
> 
> Test Summary Report
> -------------------
> t/db_dependent/Search.t (Wstat: 512 Tests: 4 Failed: 2)
>   Failed tests:  1-2
>   Non-zero exit status: 2

Are you sure you're on latest master with all the patches applied? It is
passing for me http://snag.gy/fHAsw.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:04:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:04:44 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #56 from Katrin Fischer  ---
Yes, sure of both. Hm, so we need to find out where the difference is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:07:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:07:09 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #57 from Tom?s Cohen Arazi  ---
(In reply to Katrin Fischer from comment #56)
> Yes, sure of both. Hm, so we need to find out where the difference is.

MARC::Record version 2.0.6 is needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:08:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:08:40 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #58 from Katrin Fischer  ---
Is it packaged yet?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:12:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:12:50 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #59 from Tom?s Cohen Arazi  ---
(In reply to Katrin Fischer from comment #58)
> Is it packaged yet?

In my repo, it is :-D 

http://ubuntu.unc.edu.ar/koha/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:23:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:23:50 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #60 from Katrin Fischer  ---
Installed it from CPAN - tests still failing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:25:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:25:14 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #61 from Katrin Fischer  ---
not ok 48 - getRecords on _ALLRECORDS PQF returned all records
not ok 53 - Weighted query returns best match first # TODO Query weighting does
not behave exactly the same in DOM vs. GRS
not ok 100 - can do a search that retrieves an over-large bib record (bug
11096)
not ok 101 - able to render over-large bib record (bug 11096)
not ok 102 - able to render over-large bib record (bug 11096)
not ok 103 - able to render over-large bib record (bug 11096)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:39:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:39:38 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #62 from Katrin Fischer  ---
The first 2 tests also exist on the master branch and pass there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:45:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:45:26 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #63 from Tom?s Cohen Arazi  ---
(In reply to Katrin Fischer from comment #62)
> The first 2 tests also exist on the master branch and pass there.

Can you email me your dev setup? I cannot reproduce the problems you refer to,
and hence cannot provide a workaround.



tomas at zoe:koha-community-src(clean_master)$ git fetch
tomas at zoe:koha-community-src(clean_master)$ git reset --hard origin/master 
HEAD is now at 27c312b Bug 11533: fix authority searching with no sorting when
QueryParser is enabled
tomas at zoe:koha-community-src(clean_master)$ git bz apply 11096
Bug 11096 - Koha cannot retrieve big records from Zebra

24492 - Bug 11096: force XML syntax for Zebra in DOM
24602 - Bug 11096: (qa followup) facets count and UNIMARC record syntax
24607 - Bug 11096: fallback to the correct defaults if config entries missing
24731 - Bug 11096: (follow-up) add direct regression tests
24732 - Bug 11096 - Wrap each test set configuration into a subtest

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11096: force XML syntax for Zebra in DOM
Applying: Bug 11096: (qa followup) facets count and UNIMARC record syntax
Applying: Bug 11096: fallback to the correct defaults if config entries missing
Applying: Bug 11096: (follow-up) add direct regression tests
Applying: Bug 11096 - Wrap each test set configuration into a subtest
tomas at zoe:koha-community-src(clean_master)$ prove t/db_dependent/Search.t 2>
/dev/null
t/db_dependent/Search.t .. ok   
All tests successful.
Files=1, Tests=4, 29 wallclock secs ( 0.09 usr  0.01 sys + 20.84 cusr  2.72
csys = 23.66 CPU)
Result: PASS
tomas at zoe:koha-community-src(clean_master)$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:58:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 15:58:38 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #64 from Katrin Fischer  ---
What exactly do you need?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 17:01:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 16:01:26 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

--- Comment #20 from M. Tompsett  ---
Actually, in that last case which causes the problem, the page should be
auto-redirecting, because there is only 1 visible result. The problem is there
is a [0] hard coded into the one result redirection.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 18:38:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 17:38:20 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

--- Comment #21 from Katrin Fischer  ---
You misunderstood the test case - I did a search with a real result list, in my
case 7 results matching the search term. The record with the lost item shows,
but the lost item is not listed, because there is another item available. The
only problem there is that the facets are gone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:05:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 18:05:45 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

--- Comment #22 from M. Tompsett  ---
I'm still not understanding. You searched for something, and there are 7
results in total. That implies items. How many biblios? Was the lost item the
same or different biblio than the available one? And does that mean the other 5
were checked out?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:08:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 18:08:56 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

--- Comment #23 from Katrin Fischer  ---
7 records one of which was my testing record with 1 item and 1 normal item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:09:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 18:09:26 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

--- Comment #24 from Katrin Fischer  ---
1 lost item... and 1 available item. I am talking of a normal result list,
where one of the records happens to have a hidden item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:54:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 18:54:01 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:54:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 18:54:05 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24497|0                           |1
        is obsolete|                            |

--- Comment #25 from M. Tompsett  ---
Created attachment 24733
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24733&action=edit
Bug 11489: Show facets only if there is result to display

If all results are hidden, the facets are displayed.
With this patch, the facets are hidden too.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:55:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2014 18:55:04 +0000
Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the
 only search result is supressed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

--- Comment #26 from M. Tompsett  ---
I changed hits to total because of line 683 in opac/opac-search.pl, and since
hits is not set as a parameter to the template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 16:24:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 15:24:01 +0000
Subject: [Koha-bugs] [Bug 11608] don't need the word 'library' on funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11608

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #8 from Galen Charlton  ---
Pushed to master. Thanks, Nicole!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 16:43:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 15:43:18 +0000
Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on
	parcel.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton  ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 16:53:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 15:53:15 +0000
Subject: [Koha-bugs] [Bug 11571] Bug 7934 introduces a regression in the
	translate script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #9 from Galen Charlton  ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 18:52:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 17:52:09 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #36 from mathieu saby  ---
(In reply to M. de Rooy from comment #35)
> (In reply to mathieu saby from comment #34)
> > > I would suggest to combine them, since the followup also includes a unit
> > > test.
> > 
> > Are you sure it is the best way to proceed? as the 1st patch was already
> > signed off, I wanted to keep the signoff.
> 
> In that case you should amend the second patch accordingly.

I don't understand:
I wrote it a long time ago, but I seem to remember that the UT added in the 2d
patch was made to test the function DelOrder as amended by patches 1 and 2. So
what do you want me to do?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 18:53:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 17:53:48 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

mathieu saby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11585

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 18:53:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 17:53:48 +0000
Subject: [Koha-bugs] [Bug 11585] pubdate index not working well in UNIMARC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11585

mathieu saby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11202

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 20:01:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 19:01:08 +0000
Subject: [Koha-bugs] [Bug 11611] New: fix possible confusion between UNIMARC
 and MARC21 in some sysprefs
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611

            Bug ID: 11611
           Summary: fix possible confusion between UNIMARC and MARC21 in
                    some sysprefs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathsabypro at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Some sysprefs specific to MARC21 are only described as "MARC" related. So
UNIMARC people can think they are useful fo them, which is not the case.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 20:27:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 19:27:05 +0000
Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and
 MARC21 in some sysprefs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611

mathieu saby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 20:27:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 19:27:51 +0000
Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and
 MARC21 in some sysprefs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611

--- Comment #1 from mathieu saby  ---
Created attachment 24734
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24734&action=edit
[PATCH] Bug 11611: Rephrase description and examples of 5 MARC related sysprefs


This patch rephrases the description or examples of 5 sysprefs:
1/ MARCAuthorityControlField008: "MARC" -> "MARC21"
2/ itemcallnumber: "Examples" -> "Examples (for MARC21 records)"
3/ DefaultLanguageField008: "Range 35-37" -> "Range 35-37 of MARC21 records"
4/ MARCOrgCode: "new MARC records" -> "new MARC21 records"
5/ UNIMARCAuthorityField100 description: "Do NOT include the date (position
00-05)." -> "position 08-35. Do NOT include the date (position 00-07)."
It also adds description in sql systempreferences table for
UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode

Test plan:
Apply and run updatedatabase.pl
Check the changes are taken into account in syspref administration page
Check the changes are taken into account in systempreferences table (for
UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 20:28:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 19:28:01 +0000
Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and
 MARC21 in some sysprefs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611

mathieu saby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 20:31:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 19:31:53 +0000
Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and
 MARC21 in some sysprefs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611

--- Comment #2 from mathieu saby  ---
For "position 00-05" changed to "position 00-07" this patch fixes a little
copy/paste mistake. In UNIMARC, date is stored in the 8 first bytes of 100
field in authority records.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 23:46:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 22:46:23 +0000
Subject: [Koha-bugs] [Bug 11459] OrderPdfFormat pref description could be
	more verbose
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459

--- Comment #1 from mathieu saby  ---
There are only 3 valid values for OrderPdfFormat :
pdfformat::layout2pages
pdfformat::layout3pages
in french:pdfformat::layout3pagesfr


We should improve syspref description, and the manual.

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 23:50:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 22:50:14 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

--- Comment #19 from Robin Sheat  ---
(In reply to Katrin Fischer from comment #18)
> Hi Robin, I tried ... and failed. Could you adapt your hints a bit for
> testing with a dev installation?

Really all you'll need to do is a) make sure you have memcached installed and
running, and b) change the paths to point to wherever they happen to be on your
dev install. You probably don't need to run with the sudo either in that case,
so you could drop the "sudo -u library-koha env" part.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 23:50:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 22:50:28 +0000
Subject: [Koha-bugs] [Bug 11459] OrderPdfFormat pref description could be
	more verbose
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459

mathieu saby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mathsabypro at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 23:57:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 22:57:44 +0000
Subject: [Koha-bugs] [Bug 11459] OrderPdfFormat pref description could be
	more verbose
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459

--- Comment #2 from mathieu saby  ---
Created attachment 24735
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24735&action=edit
Bug 11459: Make OrderPdfFormat syspref description more verbose

This patch adds precisions to OrderPdfFormat syspref.

To test: in staff interface, check the syspref is now presented that way:

 Use ___ layout when printing basket groups (in the form
pdfformat::layoutname). Two english layouts are available:
pdfformat::layout2pages and pdfformat::layout3pages ; one french layout is
available: pdfformat::layout3pagesfr.



M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 23:57:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 22:57:54 +0000
Subject: [Koha-bugs] [Bug 11459] OrderPdfFormat pref description could be
	more verbose
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459

mathieu saby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 00:01:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 23:01:06 +0000
Subject: [Koha-bugs] [Bug 11612] New: 404 error page for Intranet may leak
	information
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11612

            Bug ID: 11612
           Summary: 404 error page for Intranet may leak information
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: isaacbrodsky at live.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Navigating to an non-existent page on the intranet site, (e.g.
https://demo-admin.calyx.net.au/test) allows an unauthenticated user to see the
top nav bar. If an administrator uses IntranetNav configuration option to add
links to the NavBar, those links will be displayed to unauthenticated users.

I do not believe any part of the staff client should be visible to
unauthenticated users. Administrators might assume no part of it is visible
since the login screen completely hides the regular staff interface.

Tested on Debian with Koha 3.14.

Isaac

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 00:40:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2014 23:40:57 +0000
Subject: [Koha-bugs] [Bug 1047] Punctuation in site names breaks Edit/Delete
 z39.50 server administration
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1047

--- Comment #5 from Isaac  ---
The problem exists because the name of the Z39.50 server is not escaped in the
query string to bring up the edit/delete pages. This appears to be a bug with
the "|url" Template filter, but I cannot find where that is defined.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 01:06:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 00:06:39 +0000
Subject: [Koha-bugs] [Bug 11611] fix possible confusion between UNIMARC and
 MARC21 in some sysprefs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11611

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 07:51:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 06:51:19 +0000
Subject: [Koha-bugs] [Bug 11613] New: Bootstrap advanced search "standard
 number" options are confusing
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11613

            Bug ID: 11613
           Summary: Bootstrap advanced search "standard number" options
                    are confusing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org

>From bootstrap/en/modules/opac-advsearch.tt:


     [% IF ( numbersphr) %]
               
     [% ELSE %]
               
     [% END %]
               


The patron cannot be expected to know what the difference is between the two
"Standard number" entries.
And if numbersphr is not on, there isn't any difference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:06:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:06:52 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

--- Comment #20 from M. de Rooy  ---
Got the following response from Jared:
Upper-case indexes seem odd to me, but it would be easy to add them. For
example, the following change in Koha/QueryParser/Driver/PQF.pm:
97    $self->add_search_field_alias( $class => $field => uc $field );

Note btw that I did not mean an uppercase index but actually an index starting
with one uppercase letter (in this case: Number-local-acquisition).
I have spent some time scrolling through QueryParser and found that we could
change its behavior around lines 856-857 in the regexes that parse the query
for fields and aliases, but that is certainly outside the scope of this report.

I do not think that it is necessary or even appropriate to add the first
mixed-case variant just for this field.
So in short, I will just sign off the current version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:16:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:16:59 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:17:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:17:02 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

--- Comment #22 from Jonathan Druart  ---
Created attachment 24736
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24736&action=edit
Bug 10851: (follow-up) FIX bad c/p (variable name)

In catalogue.detail.tt, a wrong variable loop was used.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:17:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:17:32 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:17:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:17:35 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22353|0                           |1
        is obsolete|                            |

--- Comment #21 from M. de Rooy  ---
Created attachment 24737
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24737&action=edit
Bug 10544 - stocknumber index is an alias of Number-local-acquisition

Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for
number 1062.
In this case, Number-local-acquisition must be used in record.abs and
stocknumber can be an alias of it in ccl.properties.

Test plan :
- drop zebra database (rebuild_zebra.pl -r ...)
- reindex
- test in simple search : ccl=Number-local-acquisition,alwaysmatches=''
=> you get all records with a stocknumber
- test in simple search : ccl=stocknumber,alwaysmatches=''
=> you get the same results

Signed-off-by: Chris Cormack 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:17:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:17:48 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22354|0                           |1
        is obsolete|                            |

--- Comment #22 from M. de Rooy  ---
Created attachment 24738
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24738&action=edit
Bug 10544 - add Number-local-acquisition in known indexes

Adding Number-local-acquisition in C4::Search known indexes allows to search
without using "ccl=" prefix.
Also corrects in ccl.properties : inv must be an alias of
Number-local-acquisition.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:18:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:18:01 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22355|0                           |1
        is obsolete|                            |

--- Comment #23 from M. de Rooy  ---
Created attachment 24739
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24739&action=edit
Bug 10544 - add Number-local-acquisition in QueryParser config

This patch adds the Number-local-acquisition into QueryParser configuration
file.
Like in ccl.properties, "Number-local-acquisition" is the main index name and
"stocknumber" and "inv" are aliases.

Test plan :
Enable QueryParser :
- Enable UseQueryParser syspref
- Edit your koha-conf.xml
- Add to "config" node : [your
path]/etc/searchengine/queryparser.yaml, adapt [your
patch] to your install configuration folder
- If needed copy from sources "etc/searchengine/queryparser.yaml" into your
install configuration folder
Test search :
- Add Number-local-acquisition on an existing subfield in records.abs. For
example on item barcode field
- Reindex Zebra database
- Choose a value of this field that will match some results. For example : "0*"
will match all barcodes beginning with zero
- In intranet, enter this URL : /cgi-bin/koha/catalogue/search.pl?idx=stocknumber&q=0*&sort_by=relevance
=> You get some results
- In intranet, enter this URL : /cgi-bin/koha/catalogue/search.pl?idx=inv&q=0*&sort_by=relevance
=> You get the same results
- In intranet, enter this URL : /cgi-bin/koha/catalogue/search.pl?idx=number-local-acquisition&q=0*&sort_by=relevance
=> You get the same results

Signed-off-by: Marcel de Rooy 
Comments on case sensitivity of index names in QueryParser, see Bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:18:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:18:02 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

--- Comment #23 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #20)
> When I go to the staff detail page, 2 issues are shown in the subscription
> tab.
> Only the "Arrived" status displays, the other status that should be "Missing
> (sold out)" is empty. On the OPAC detail page the display is ok.

Hi Katrin,
I used a bad variable name, sorry.
It should be fixed with the follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:22:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 09:22:06 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

--- Comment #24 from M. de Rooy  ---
Another note for the QAer:
The last patch with changes to the YAML file make koha-qa warn about
duplicates. I will send Jonathan a message about that. Seems a false warning;
the changes look good to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:15:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 10:15:36 +0000
Subject: [Koha-bugs] [Bug 11614] New: Untranslatable label_element_title in
 label management
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11614

            Bug ID: 11614
           Summary: Untranslatable label_element_title in label management
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

The page header says "Currently available [% label_element_title %]", where
label_element_title is one of "Batches", "Layouts", "Templates", or "Profiles",
and thatose single words are not translatable.

Hard-coded in labels/label-manage.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:29:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 10:29:14 +0000
Subject: [Koha-bugs] [Bug 11615] New: Untranslatable label_element and
 operator in label manage alert
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11615

            Bug ID: 11615
           Summary: Untranslatable label_element and operator in label
                    manage alert
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

alert(_("Please select only one ")+"[% label_element %]"+_(" to")+op+".");

In addition to label_element and op being untranslatable, the " to" -string
needs a space after it - otherwise we get messages like "Please select only one
layout toedit."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:31:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 10:31:15 +0000
Subject: [Koha-bugs] [Bug 11615] Untranslatable label_element and operator
 in label manage alert
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11615

--- Comment #1 from paxed  ---
And a few lines below that:

alert(_("Please select a ")+"[% label_element %].");

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:04:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:04:24 +0000
Subject: [Koha-bugs] [Bug 6890] Add reserves to modification logging
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #9 from Jonathan Druart  ---
The logs should be written only if a pref is set.
It is the usual way to log actions into Koha.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:18:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:18:23 +0000
Subject: [Koha-bugs] [Bug 11317] Add a way to access log files from the
	intranet.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart  ---
Fr?d?rick,

Could you provide a test plan and replace tablesorter with datatables please?

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:21:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:21:59 +0000
Subject: [Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing
	all facets
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #11 from Fridolin SOMERS  ---
Patches pushed to 3.14.x, will be in 3.14.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:24:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:24:10 +0000
Subject: [Koha-bugs] [Bug 11616] New: The tablesorter plugin is no longer in
	use
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

            Bug ID: 11616
           Summary: The tablesorter plugin is no longer in use
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

All references to tablesorter could be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:26:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:26:31 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Show the parent records     |Show the parent record's
                   |child records (aka.         |component parts in the
                   |component parts) in the     |detailed views.
                   |detailed views.             |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:27:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:27:03 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:27:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:27:07 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

--- Comment #1 from Jonathan Druart  ---
Created attachment 24740
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24740&action=edit
Bug 11616: tablesorter is no longer in use

DataTables has replaced the tablesorter plugin to sort tables into Koha.
There is no table using this plugin and all references could be removed.

Test plan:
- Verify there is no regression on the circ/bookcount.pl tables and that
  git grep tablesorter does no return any use of this plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:27:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:27:30 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:29:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:29:47 +0000
Subject: [Koha-bugs] [Bug 11249] Add db indexes on borrowers names
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.
(creates updatedatabase 3.14.02.001)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:32:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:32:43 +0000
Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when
 doing authority merges.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart  ---
Fr?d?rick,
Why don't you check the pref overwriteSubfieldsOnMerge value in the merge
routine?
Could you provide a test plan please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:44:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:44:39 +0000
Subject: [Koha-bugs] [Bug 11268] Biblioitems URL field is too small for some
	URLs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11268

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:44:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:44:42 +0000
Subject: [Koha-bugs] [Bug 11268] Biblioitems URL field is too small for some
	URLs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11268

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23006|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart  ---
Created attachment 24741
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24741&action=edit
Bug 11268 - Biblioitems URL field is too small for some URLs

The URL field in biblioitems is defined as a varchar(255) which is large
enough for most URLs but not all. This field should be converted to a
TEXT field to make sure it is capable of storing all valid URLs.

Test Plan:
1) Attempt to a URL that is greater than 255 chacters long in a record
   (856$u in MARC21)
2) Save the record, note the url gets truncated
3) Apply this patch
4) Repeat step 1
5) Note the entire url is saved

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:57:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 11:57:00 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #6 from Jonathan Druart  ---
Hi Marcel,
It does not seem to work with the default value for the custom parameter:

% perl misc/migration_tools/bulkmarcimport.pl -file /tmp/zztest01.xml -v=2 -b
-m XML -t | more
TESTING MODE ONLY
    DOING NOTHING
===============
Characteristic MARC flavour: UNIMARC
LDR 00000uam a22000001i 4500
001     734
008     870805
041    _aeng
044    _cNL
070    _a86307796X
084    _a14
245 00 _aEmerging hierarchies : processes of stratification and early state
formation in the Indonesian archipelago : prehistory and the ethnographic
present
       _cdoor Ina Erna Slamet-Velsink
260    _a[S.l.
       _bs.n.]
       _c1986
300    _aviii, 310 p., 20 pl.
       _bill., maps
       _c22 cm
500    _aDoctoral diss. RU Leiden
500    _aBibliogr.: p. 278-296
500    _aIncludes index
650  4 _aarchaeology
650  4 _astates
650  4 _anation building
650  4 _acultural and social anthropology
651  4 _aindonesia
700 1  _aSlamet-Velsink, Ina Erna
852    _aCentrale Bibliotheek (CB)
       _cN 87-911
       _p14000000001457
       _zBeschikbaar
852    _aCentrale Bibliotheek (CB)
       _cN 96-317
       _p14000002218786
       _zBeschikbaar

1 MARC records done in 0.0246779918670654 seconds


There is no 005 created.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:02:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:02:30 +0000
Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:10:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:10:04 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart  ---
Don't forget to provide unit tests for new routines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:10:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:10:16 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |fcapovilla at live.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:15:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:15:46 +0000
Subject: [Koha-bugs] [Bug 11617] New: Add itemnumber constraint to
	aqorders_items
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617

            Bug ID: 11617
           Summary: Add itemnumber constraint to aqorders_items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

This report is a follow-up report on bug 10869.
Instead of 'manually' deleting the records in aqorders_items in routine
DelOrder, we should just have MySQL do it with a cascaded delete.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:18:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:18:07 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10869

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:18:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:18:07 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11617

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:27:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:27:07 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617

--- Comment #1 from M. de Rooy  ---
Created attachment 24742
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24742&action=edit
Bug 11617: Add itemnumber constraint to aqorders_items

This patch adds a foreign key constraint to aqorders_items on itemnumber.
It is a follow-up on report 10869 with changes to DelOrder.
This removes the need to delete these records in DelOrder.

Test plan:
Do a new install, and check that the constraint on itemnumber is created
in the table aqorders_items.
Run an upgrade via install.pl?step=3&op=updatestructure. Check again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:27:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:27:03 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:27:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:27:26 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:29:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:29:42 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:29:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:29:45 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22300|0                           |1
        is obsolete|                            |

--- Comment #37 from M. de Rooy  ---
Created attachment 24743
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24743&action=edit
Bug 10869: Allow the deletion of order line if the record is deleted

[I integrated a small followup by P. Poulain, changing the name of $bibnum to
$biblionumber in DelOrder
It was more simple for rebasing]

This patch fixes 2 issues :
(medium issue) It is not possible to delete an order in a basket if the biblio
record is deleted.
(minor issue) There is a useless hyperlink around "Deleted bibliographic
notice", and "notice" is a frenchism for "record"

I had to change the behavior of Acquisitions::DelOrder (which is used only by
addorder.pl file), a line in addorder.pl, and a few lines in template
basket.tt.

To test :
1. Fill a basket with some records (some records with items or holds, some
without items)
2. Supress one of the record
3. In the basket (refresh the screen) check that "Deleted bibliographic notice"
line was replaced with "Deleted bibliographic record", without hyperlink
arround
4. Delete this order with the link "Delete order" to the right column of the
table
5. Check there is a new line in the "Deleted orders" table
6. Check there is no regression : felete an other order (one with no item),
then check you cannot delete an order with an item (like before patch)

Signed-off-by: Cedric Vita 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:30:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:30:00 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23839|0                           |1
        is obsolete|                            |

--- Comment #38 from M. de Rooy  ---
Created attachment 24744
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24744&action=edit
Bug 10869 Followup: Unit tests for DelOrder

DelOrder now returns undef if no ordernumber passed.
This patch also adds unit tests for DelOrder.

Test plan:
A. With syspref  AcqCreateItem  = on placing an order

1. Fill a basket with some orders (some records with already existing items or
holds, some without items). New items linked with the order will be created
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders, and check the deletion of the
order implies the deletion of items created when ordering
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.

7. Add some other orders to your basket  (some records with already existing
items or holds, some without items). New items linked with the order will be
created
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.

B. With syspref  AcqCreateItem  = on receiving an order

1. Fill a basket with some orders (some records with already existing items or
holds, some without items).
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
7. Add some other orders to your basket  (some records with already existing
items or holds, some without items).
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.

And to test the UT: prove t/db_dependent/Acquisition.t

Signed-off-by: Marcel de Rooy 
Amended the patch as to removing biblio parameter in DelOrder.
There is no need to remove the parameter if you will search for
biblionumber later on.
I also suggest to handle the deletes in aqorders_items via constraint.
Added a followup on report 11617 for that purpose.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:31:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:31:40 +0000
Subject: [Koha-bugs] [Bug 11618] New: jQuery timepicker is not picked up by
 the i18n toolchain
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618

            Bug ID: 11618
           Summary: jQuery timepicker is not picked up by the i18n
                    toolchain
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Created attachment 24745
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24745&action=edit
Untranslatable text in jQuery timepicker

The jQuery timepicker plugin has some strings that cannot be translated via
Koha i18n toolchain. ("Time", "Hour", "Minute", "Now", "Done", ...)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:32:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:32:28 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #10 from Jonathan Druart  ---
I have a concern: we can't know if the user has been notified or if the email
used was the SendAllEmailsTo content.
It could cause problem on debugging if the pref is available on a production
server.
I don't have a suggestion (except adding a new column in the message_queue
table (which is quite ugly).

I am not sure it is blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:33:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:33:28 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #39 from M. de Rooy  ---
(In reply to mathieu saby from comment #36)
> I don't understand:
> I wrote it a long time ago, but I seem to remember that the UT added in the
> 2d patch was made to test the function DelOrder as amended by patches 1 and
> 2. So what do you want me to do?

Please have a look at the amended second patch. If you agree, please retest and
put an additional signoff on it. Also I added a follow-up on report 11617 to
realize the deletion of items in aqorders_items. You are welcome to test that
too :)
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:35:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:35:50 +0000
Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #40 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:38:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:38:37 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #7 from M. de Rooy  ---
(In reply to Jonathan Druart from comment #6)
> Hi Marcel,
> It does not seem to work with the default value for the custom parameter:
> 
> % perl misc/migration_tools/bulkmarcimport.pl -file /tmp/zztest01.xml -v=2
> -b -m XML -t | more

The default value will only be used if you supply the custom flag. Something
like bulkmarcimport.pl -file ... -cust ...
In your example the -custom parameter is not passed, so bulkmarcimport does not
look at the customization routines (just normal behavior).

Does this need a better explanation in the POD ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:40:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:40:23 +0000
Subject: [Koha-bugs] [Bug 11279] Quote of the day feature won't pick a quote
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11279

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #16 from Fridolin SOMERS  ---
Patches pushed to 3.14.x, will be in 3.14.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:42:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:42:41 +0000
Subject: [Koha-bugs] [Bug 11417] remove_unused_authorities.pl doesn't accept
	--test
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:44:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:44:40 +0000
Subject: [Koha-bugs] [Bug 11228] Explanation on 'patron notification' is not
	quite right
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:50:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:50:21 +0000
Subject: [Koha-bugs] [Bug 11619] New: Duplicate key in QueryParser config
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

            Bug ID: 11619
           Summary: Duplicate key in QueryParser config
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Found by Jonathan with some hints from koha-qa:

duplicate key is language:

 647     language:
 648       bib1_mapping:
 649         biblioserver:
 650           1: 54
 651       enabled: 1
 652       index: language
 653       aliases:
 654         - language
 655         - ln
 656       label: Language
 657     language:
 658       bib1_mapping:
 659         biblioserver:
 660           1: 1095
 661       enabled: 1
 662       aliases:
 663         - language-original
 664       index: language-original
 665       label: Language of original

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:53:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:53:45 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

--- Comment #1 from M. de Rooy  ---
Created attachment 24746
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24746&action=edit
Bug 11619: Duplicate key in QueryParser config

Corrects a double entry for language in yaml file.
Language should have been language-original.

Test plan:
Copy changes in yaml file to your zebra folder.
Reindex, or change a few records and update zebra.
Search something with index language-original.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:53:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:53:59 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:58:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:58:45 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11619

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:58:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:58:45 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10544

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:59:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 12:59:30 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

--- Comment #25 from M. de Rooy  ---
(In reply to M. de Rooy from comment #24)
> Another note for the QAer:
> The last patch with changes to the YAML file make koha-qa warn about
> duplicates. I will send Jonathan a message about that. Seems a false
> warning; the changes look good to me.

Jonathan found that the language is duplicated. This problem is solved under
report 11619.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:02:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:02:48 +0000
Subject: [Koha-bugs] [Bug 11179] opac-course-details.pl shows item as
 available when it is checked out
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS  ---
Patches pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:06:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:06:55 +0000
Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #13 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:08:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:08:19 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24746|0                           |1
        is obsolete|                            |

--- Comment #2 from M. de Rooy  ---
Created attachment 24747
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24747&action=edit
Bug 11619: Duplicate key in QueryParser config

Corrects a double entry for language in yaml file.
Language should have been language-original.

Test plan:
Apply this patch on top of report 10544 (esp. third patch).
Actually quite hard to test if the record.abs does not contain an index for
languge of original under GRS1 :)
What should be resolved is the output of koha-qa.pl.
Run the qa script and verify if there are no yaml warnings anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:08:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:08:16 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:10:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:10:03 +0000
Subject: [Koha-bugs] [Bug 11403] renew page missing help file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:21:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:21:49 +0000
Subject: [Koha-bugs] [Bug 11445] it is possible for duplicate hold
 notifications to be sent
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS  ---
Patches pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:30:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:30:10 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24747|0                           |1
        is obsolete|                            |

--- Comment #3 from M. de Rooy  ---
Comment on attachment 24747
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24747
Bug 11619: Duplicate key in QueryParser config

Still yaml warnings..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:30:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:30:26 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:31:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:31:11 +0000
Subject: [Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed
	open()
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:31:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:31:56 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

--- Comment #4 from M. de Rooy  ---
I saw some 'suspect' lines around author too.
But I do not seem to get rid of the YAML warnings from koha-qa.pl
I am leaving this to the experts for now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:32:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:32:16 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|m.de.rooy at rijksmuseum.nl    |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:38:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:38:11 +0000
Subject: [Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in
 checkout page clears renew checkboxes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:43:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:43:46 +0000
Subject: [Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if
 undefned data is passed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin SOMERS  ---
Patches pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:47:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:47:13 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:47:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:47:18 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23133|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart  ---
Created attachment 24748
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24748&action=edit
Bug 11278: Adjusting bulkmarcimport.pl for customization routine and verbose
printing

This patch makes two adjustments:
[1] For the verbose option, verbose level 2 now means print the formatted
marcxml per record.
[2] If a module LocalChanges.pm is found in misc/migration_tools, the routine
customize in this module is called for each marc record. This allows you to
make local changes to these marc records before importing them.

Test plan:
[1] Test the verbose option: do no use -v on the command line, use -v 1 and
-v 2 on the command line. (Do not yet copy LocalChanges.pm in the folder.)
You may used the attached example file on Bugzilla:
perl misc/migration_tools/bulkmarcimport.pl -file zztest01.xml -v 2 -b -m XML
-t | more
Note the option t for test; no records will be imported.
[2] Copy LocalChanges.pm in the migration_tools folder. You may use the
example provided on Bugzilla (in a patch). If you use the example module,
check the contents of 001, 005 and 590 fields. (The verbose 2 option allows
you to easily check that.)

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:47:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:47:41 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23134|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart  ---
Created attachment 24749
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24749&action=edit
Bug 11278: Followup for customize command line parameter

The initial patch for this bug did not include a specific command line
option for customization. If a module LocalChanges.pm existed, it would
be used without asking.
This patch adds a command line option enabling the customization option
and offering the extra possibility of using another module name. If no file
name is passed, we default to LocalChanges.
Without the -custom option, behavior is as it was.
Also some POD lines are added to document the feature.

Test plan:
[1] Make a LocalChanges.pm in migration_tools. Verify that it is not used,
    if you do not enable the -cust parameter.
[2] Run the script again with -cust. Verify that it is called now.
[3] Copy LocalChanges.pm to Whatever.pm. Make some change. Run with
    -cust Whatever and verify that the new module is used.
[4] Copy Whatever.pm to another dir, make some change. Run with -cust and the
    full name. Verify that the latest change was used.
[5] Run without any option. Check the pod documentation.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:47:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:47:50 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

--- Comment #10 from Jonathan Druart  ---
Created attachment 24750
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24750&action=edit
Bug 11278: (follow-up) Return an exit value (1) if the module is not found.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:49:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:49:08 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

--- Comment #11 from Jonathan Druart  ---
(In reply to M. de Rooy from comment #7)
> In your example the -custom parameter is not passed, so bulkmarcimport does
> not look at the customization routines (just normal behavior).

Yes sorry, I have just stupidly followed the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:50:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:50:52 +0000
Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary
 while searching by all auth types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:55:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:55:23 +0000
Subject: [Koha-bugs] [Bug 11398] A typo occurred with occured
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin SOMERS  ---
Patch pushed to 3.14.x, will be in 3.14.3.
Looks more a trivial bug than an enhancement to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:57:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:57:27 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

--- Comment #12 from M. de Rooy  ---
(In reply to Jonathan Druart from comment #11)
Thanks for testing and follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:57:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 13:57:58 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #5 from Jonathan Druart  ---
(In reply to M. de Rooy from comment #4)
> I saw some 'suspect' lines around author too.
> But I do not seem to get rid of the YAML warnings from koha-qa.pl
> I am leaving this to the experts for now :)

I think your first patch is right.
The warning from koha-qa is normal. The tests are done before the patch AND
after the patch. The warnings only appears 1 time, so before applying the
patch. After the patch, it does not appear anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:00:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:00:53 +0000
Subject: [Koha-bugs] [Bug 11613] Advanced search "standard number" options
	are confusing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11613

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bootstrap advanced search   |Advanced search "standard
                   |"standard number" options   |number" options are
                   |are confusing               |confusing
           Severity|enhancement                 |normal

--- Comment #1 from Owen Leonard  ---
I've changed the title of this bug to reflect the fact that it is not specific
to Bootstrap.

It looks to me like the change introduced in Bug 9395 was intended to remove
the "sn" option altogether in cases where the system is configured to use
"sn,phr" by default. Can anyone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:03:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:03:34 +0000
Subject: [Koha-bugs] [Bug 9654] Missing space between amount and currency
 symbol in basket groups
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m
         Depends on|                            |9807

--- Comment #11 from Fridolin SOMERS  ---
Depends on Bug 9807 patch :
231f26b Bug 9807: (follow-up) quell warning if invoice price not set

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:03:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:03:34 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9654

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:03:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:03:59 +0000
Subject: [Koha-bugs] [Bug 11614] Untranslatable label_element_title in label
	management
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11614

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:04:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:04:21 +0000
Subject: [Koha-bugs] [Bug 11615] Untranslatable label_element and operator
 in label manage alert
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11615

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:05:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:05:13 +0000
Subject: [Koha-bugs] [Bug 11618] jQuery timepicker is not picked up by the
	i18n toolchain
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:05:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:05:14 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24746|1                           |0
        is obsolete|                            |

--- Comment #6 from M. de Rooy  ---
Comment on attachment 24746
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24746
Bug 11619: Duplicate key in QueryParser config

OK I will obsolete this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:05:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:05:55 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:06:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:06:17 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:07:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:07:20 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

--- Comment #7 from M. de Rooy  ---
This test plan is nonsense ('stupid') by the way :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:09:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:09:27 +0000
Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325

--- Comment #6 from Owen Leonard  ---
(In reply to Ian Palko from comment #4)
> Now, the focus is not by default on the "add barcode" field, but when data
> is entered into this field, whether by scanner or keyboard, focus is
> immediately sent to the "search the catalog" field at the top of the page.

This sounds like Bug 11567. Are you using a non-English translation which needs
to be updated?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:15:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:15:34 +0000
Subject: [Koha-bugs] [Bug 11620] New: dissertation-information is only
 defined for UNIMARC
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11620

            Bug ID: 11620
           Summary: dissertation-information is only defined for UNIMARC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

The dissertation-information index is added by bug 11202 for UNIMARC but does
not exist for others marc formats.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:16:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:16:11 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #60 from Jonathan Druart  ---
All looks good to me.

I had a discussion with Paul and the only think we found is that the
Dissertation-information is not defined for MARC21 (but the index is defined in
the ccl.properties). See bug 11620.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:18:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:18:05 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:18:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:18:13 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23830|0                           |1
        is obsolete|                            |

--- Comment #61 from Jonathan Druart  ---
Created attachment 24751
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24751&action=edit
Bug 11202 - Improve UNIMARC biblio indexing

This patch makes the following changes to UNIMARC biblio indexing :
A. Changes to UNIMARC conf files
1. add comments to biblio-koha-indexdefs.xml
2. make biblio-koha-indexdefs.xml more compact by grouping some declarations
Ex : 200$f and 200$g => one declaration for 200$fg
3. suppress unneeded declarations (indexing of some 4XX fields and 6XX fields
not in unimarc format)
4. unindex some (sub)fields unneeded by most users (318, 207,230,210a,215,
4XXd)
5. change the way 308 field is indexed (no visible changes)
6. replace Title-host with Host-item -- see bug 11119
7. index 208 in Material-Type -- see bug 11119
8. index 100 pos 8-9 and 9-12 in pubdate:y and pubdate:n
9. index 100 pos 8-9 in pubdate:s instead of 210$d
10. Index all subfields of note 334 and 327 in note index
11. Index 304 and 327 in title index as well as note index
327 can contain a list of titles included in a work
304 can contain the title of the original work in case of a translation
12. Index 314 in author index as well as note index
314 can contain authors not mentionned in 200$f/g (the 4th, 5th etc author)
13. Index 328 note in Dissertation-information as well as note
14. Index 328$t in Title

B. Changes to ccl.properties :
1. add a new index Dissertation-information (1056)
2. fix EAN, pubdate and acqdate (they were not linked with bib1 attributes)

C. Changes to Search.pm
1. add Dissertation-information and suppress Title-host and UPC

D. Changes to QP config file queryparser.yaml
1. add Dissertation-information
2 fix EAN, pubdate and acqdate

Test plan :
If you cannot test in GRS1, test only in DOM, as GRS will be deprecated.

1. Apply the patch in a UNIMARC Koha running with DOM and ICU
2. copy src/etc/searchengine/queryparser.yaml into the main config directory of
QP
3. copy src/etc/zebradb/ccl.properties into the main config directory of Zebra
4. copy src/etc/zebradb/marc_defs/unimarc/biblio/* into the main config
directory of Zebra
5. reindex biblios (rebuild_zebra.pl -r -b -x -v)
6. test note index : make some searches on 334$b or 327$b
7. test author index : make some searches on 314 field
8. test title index : make some searches on 304 and 327 field, make a search on
328$t subfield
9. test dissertation-information index : make some searches on 328 field
10. In a record, put in the dates of 100 fields the values "1000" (1st date)
and "1001" (2d date) ; try to search a book written in year 1000, you should
find the record ; idem for year 1001
11. make some searches and sort by date. It should work better as before,
especially if you have values like "c2009" or "impr. 2010" in 210 field
12. Regression test : make some searches on several indexes, like EAN, etc. It
should work as before
Test 10-12 with and without Queryparser activated.
Be careful: with Queryparser activated, the index names (title,
dissertation-information...) must be entered in lowercase only.
Of course, to test search and sort by dates, you need to have full records,
with dates in 100 field as well as 210 field.

Signed-off-by: Paola Rossi 
Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:21:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:21:53 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:21:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:21:57 +0000
Subject: [Koha-bugs] [Bug 11619] Duplicate key in QueryParser config
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24746|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart  ---
Created attachment 24752
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24752&action=edit
Bug 11619: Duplicate key in QueryParser config

Corrects a double entry for language in yaml file.
Language should have been language-original.

Test plan:
Copy changes in yaml file to your zebra folder.
Reindex, or change a few records and update zebra.
Search something with index language-original.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:22:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:22:23 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

--- Comment #62 from Katrin Fischer  ---
Hi Jonathan, thx for taking a look - my tests were also looking good so far,
but I was hesitating to pass as I don't know UNIMARC really well. I think our
libraries would like an index for dissertation-information - this could be
another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:52:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:52:13 +0000
Subject: [Koha-bugs] [Bug 11618] jQuery timepicker is not picked up by the
	i18n toolchain
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:59:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 14:59:56 +0000
Subject: [Koha-bugs] [Bug 906] ISBN Check
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:36:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 15:36:47 +0000
Subject: [Koha-bugs] [Bug 10208] The ability to order multiple copies of the
	same title
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10208

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:54:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 15:54:22 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:56:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 15:56:54 +0000
Subject: [Koha-bugs] [Bug 11621] New: Race condition exists for trapping
	holds
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11621

            Bug ID: 11621
           Summary: Race condition exists for trapping holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It is possible to trigger a race condition when it trapping items to fill
holds:
1) Librarian A checks in Book 1, which displays the hold trap dialog
2) Librarian B checks in Book 2, which displays the hold trap dialog
3) Librarian A clicks the "confirm and print" button, which prints the hold
slip and sends a hold waiting message to the patron
4) Library B clicks the "confirm and print" button, which causes the previous
hold to be overwritten with the new hold, and thus Book 1 is no longer a
waiting hold for this patron, Book 2 is.
5) Book 1 is now available, and if there are other holds that need filled, none
of them will be fulfilled with Book 1 unless a librarian checks it in again.

I believe this issue is caused by ModReserveFill assuming the hold must need
filled if called, and does not check for an existing waiting reserve. This
issue must be addressed in C4::Reserves and not just circ/returns.pl as the
issue affects SIP2 hold fulfillment as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:58:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 15:58:41 +0000
Subject: [Koha-bugs] [Bug 11622] New: Add ability to pay fees and fines from
 OPAC via PayPal
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

            Bug ID: 11622
           Summary: Add ability to pay fees and fines from OPAC via PayPal
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Many libraries wish to add the ability to pay fees and fines from the OPAC
using PayPal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:58:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 15:58:57 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
         Depends on|                            |6427
  Change sponsored?|---                         |Sponsored
           Assignee|oleonard at myacpl.org         |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:58:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 15:58:57 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11622

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:16:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 16:16:29 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:16:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 16:16:32 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #1 from Kyle M Hall  ---
Created attachment 24753
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24753&action=edit
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
1) Apply the patches for bug 6427
2) Apply this patch
3) Create a paypal developer account
4) Create two test accounts, a Personal account and a Business account
5) Enable PayPal in Sandbox mode via the system preferences.
6) Enter the business account API credentials into the new system
   preferences.
7) Create a new patron, add some fines/fees
8) Log in as that patron in the OPAC
9) Choose to pay via PayPal, log in as the sandbox Personal account
10) Complete the transaction
11) Note the fee is now paid

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:24:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 16:24:05 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24753|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall  ---
Created attachment 24754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24754&action=edit
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
1) Apply the patches for bug 6427
2) Apply this patch
3) Create a paypal developer account
4) Create two test accounts, a Personal account and a Business account
5) Enable PayPal in Sandbox mode via the system preferences.
6) Enter the business account API credentials into the new system
   preferences.
7) Create a new patron, add some fines/fees
8) Log in as that patron in the OPAC
9) Choose to pay via PayPal, log in as the sandbox Personal account
10) Complete the transaction
11) Note the fee is now paid

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:43:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 16:43:08 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #3 from Kyle M Hall  ---
Video demonstration: http://screencast.com/t/Kqlja7z1F

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:46:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 16:46:38 +0000
Subject: [Koha-bugs] [Bug 11618] jQuery timepicker is not picked up by the
	i18n toolchain
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:46:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 16:46:41 +0000
Subject: [Koha-bugs] [Bug 11618] jQuery timepicker is not picked up by the
	i18n toolchain
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618

--- Comment #1 from Owen Leonard  ---
Created attachment 24755
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24755&action=edit
Bug 11618 - jQuery timepicker is not picked up by the i18n toolchain

We handle internationalization of the jQuery datepicker by adding
language configuration strings to calendar.inc which can be processed by
the translation script. This patch adds a similar configuration file for
the timepicker.

This patch also upgrades the timepicker plugin to the latest version,
minified, and places it outside the prog template directory for global
use. The path in templates has been updated accordingly.

CSS has been added to more completely hide the controls for seconds,
milliseconds, and microseconds.

To test, apply the patch and clear your cache so that the browser
loads the new version of the jQuery plugin. Confirm that date and time
selection still function correctly on the circulation page, the patron
detail page, and the offline circulation page (circ/offline.pl).

Test at least one datepicker instance which does not use the
timepicker.

Run translate update on a po file and confirm that the timepicker
strings are now present.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:18:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:18:31 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #4 from Kyle M Hall  ---
Created attachment 24756
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24756&action=edit
Bug 11622 [DB Update] - Add ability to pay fees and fines from OPAC via PayPal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:06 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24612|0                           |1
        is obsolete|                            |
  Attachment #24613|0                           |1
        is obsolete|                            |
  Attachment #24614|0                           |1
        is obsolete|                            |
  Attachment #24615|0                           |1
        is obsolete|                            |
  Attachment #24616|0                           |1
        is obsolete|                            |
  Attachment #24617|0                           |1
        is obsolete|                            |
  Attachment #24618|0                           |1
        is obsolete|                            |
  Attachment #24619|0                           |1
        is obsolete|                            |
  Attachment #24620|0                           |1
        is obsolete|                            |
  Attachment #24621|0                           |1
        is obsolete|                            |
  Attachment #24622|0                           |1
        is obsolete|                            |
  Attachment #24623|0                           |1
        is obsolete|                            |
  Attachment #24624|0                           |1
        is obsolete|                            |
  Attachment #24625|0                           |1
        is obsolete|                            |
  Attachment #24626|0                           |1
        is obsolete|                            |
  Attachment #24628|0                           |1
        is obsolete|                            |

--- Comment #149 from Kyle M Hall  ---
Created attachment 24757
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24757&action=edit
Bug 6427 [Part 1] - Update schema files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:27 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #150 from Kyle M Hall  ---
Created attachment 24758
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24758&action=edit
Bug 6427 [Part 2] - Add new accounts related modules

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:31 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #151 from Kyle M Hall  ---
Created attachment 24759
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24759&action=edit
Bug 6427 [Part 3] - Add new TT plugin to deal with currency

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:36 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #152 from Kyle M Hall  ---
Created attachment 24760
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24760&action=edit
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and
payments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:40 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #153 from Kyle M Hall  ---
Created attachment 24761
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24761&action=edit
Bug 6427 [Part 5] - Implement new accounting system in the opac

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:45 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #154 from Kyle M Hall  ---
Created attachment 24762
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24762&action=edit
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:49 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #155 from Kyle M Hall  ---
Created attachment 24763
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24763&action=edit
Bug 6427 [Part 7] - Update cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:53 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #156 from Kyle M Hall  ---
Created attachment 24764
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24764&action=edit
Bug 6427 [Part 8] - Update existing intranet scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:41:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:41:57 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #157 from Kyle M Hall  ---
Created attachment 24765
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24765&action=edit
Bug 6427 [Part 9] - Update existing perl modules to support new accounting
system

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:42:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:42:03 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #158 from Kyle M Hall  ---
Created attachment 24766
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24766&action=edit
Bug 6427 [Part 10] - Update reports wizard

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:42:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:42:08 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #159 from Kyle M Hall  ---
Created attachment 24767
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24767&action=edit
Bug 6427 [Part 11] - Add new utility functions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:42:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:42:13 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #160 from Kyle M Hall  ---
Created attachment 24768
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24768&action=edit
Bug 6427 [Part 12] - Add and update unit tests

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:42:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:42:17 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #161 from Kyle M Hall  ---
Created attachment 24769
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24769&action=edit
Bug 6427 [Part 13] - Add database updates

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:42:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:42:22 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #162 from Kyle M Hall  ---
Created attachment 24770
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24770&action=edit
Bug 6427 [Part 14] - Delete unused and unnecessary files

 This patch re-engineers Koha's accounting system to be faster, more
 stable, and  have a better historical accounting of fees and payments
 while also unifying much of the payment logic and simplifying the code
 behind it.

 Three new tables have been created:
 account_debits stores fines and fees owed by the patron.

 account_credits stores payments, write-offs, and other line items that
 reduce the amount owed by a patron.

 account_offsets stores data about changes to debits and credits,
 including which credits paid which debits.

 borrowers.account_balance stores the current balance of the
 patron, so it does not have to be calculated each time it needs to be
 displayed.

 issues.issue_id has been added so that individual fines can be directly
 linked to the issue that caused them without ambiguity.

 The various accounting code strings ( F, FU, Rent, etc ), some of which
 have little or no documentation have been replaced by what enumerated
 data types which are documented via POD.
 There are three, one for each of Debits ( fees/fines ), Credits (
         payments ),
 and Offsets.

 The system continues to allow custom fee types ( moving MANUAL_INV to
         MANUAL_DEBIT )
 while additionally allowing custom payment types ( MANUAL_CREDIT ).

 The system also allows for overpayment, the the outstanding credit
 being
 applied to future fees as they are created.

 The system also allows for a librarian to accept a different amount of
 money than what is to be paid, and will calculate the change to be
 given.

 Test Plan:
 1) Apply this patch
 2) Create some manual fees
 3) Test the fee payments
    * Pay one fee
    * Pay multiple fees
    * Make a partial payment
    * Write off a fee
 4) View the fees/payments, verify they are correct
 5) Check out some items as overdue that should have fines
 6) Run fines.pl, verify fines were generated
 7) Pay on an accruing fine
 8) Run fines.pl again, verify the fine hasn't changed
 9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:42:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:42:27 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #163 from Kyle M Hall  ---
Created attachment 24771
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24771&action=edit
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:42:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:42:31 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #164 from Kyle M Hall  ---
Created attachment 24772
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24772&action=edit
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed
KohaAuthorisedValues plugin

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:48:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:48:14 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:53:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:53:30 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24009|0                           |1
        is obsolete|                            |
  Attachment #24010|0                           |1
        is obsolete|                            |
  Attachment #24011|0                           |1
        is obsolete|                            |

--- Comment #44 from Kyle M Hall  ---
Created attachment 24773
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24773&action=edit
Bug 9303 [1] - relative's checkouts in the opac - Schema Updates

This patch gives patrons the option of allowing other
linked relatives to view his or her checkouts from
opac-user.pl in a manner similiar to the patron's own
checkouts tab. By default the setting is not enabled.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create three borrowers, link them as relatives
4) In the OPAC, go to "my privacy" and choose to allow
   relatives to view current checkouts for borrowers A and B
5) Check out some items to each borrower
6) Log into the OPAC as borrower A, you should see a "Relatives'
   checkouts" tab. In this tab you should see the checkouts for
   borrower B
7) Log into the OPAC as borrower C, you should be able to view
   the current checkouts for both borrower A and borrower B

Signed-off-by: Joel Sasse 

Signed-off-by: Heather Braum 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:53:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:53:36 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #45 from Kyle M Hall  ---
Created attachment 24774
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24774&action=edit
Bug 9303 [2] - relative's checkouts in the opac - Database Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:53:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:53:41 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #46 from Kyle M Hall  ---
Created attachment 24775
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24775&action=edit
Bug 9303 [3] - relative's checkouts in the opac

Signed-off-by: Joel Sasse 

Signed-off-by: Heather Braum 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:53:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:53:47 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #47 from Kyle M Hall  ---
Created attachment 24776
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24776&action=edit
Bug 9303 [QA Followup] - Set AUTO_INCREMENT value for issues.issue_id

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:55:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 17:55:44 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:00:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 18:00:17 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #165 from Kyle M Hall  ---
Created attachment 24777
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24777&action=edit
Bug 6427 [Part 17] - Add cron script to recalculate account balances

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:39:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 18:39:03 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24597|0                           |1
        is obsolete|                            |

--- Comment #14 from Blou  ---
Created attachment 24778
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24778&action=edit
Bug 10937 - Option to hide and group itemtypes from advanced search

Fix and rebase following mtompset's comments

Bug 10937 - Option to hide and group itemtypes from advanced search

   Fixed and rebased following mtompset's comments.
   - Kept inline expr, same as "model" 5 lines earlier.
   - No indentation change.  END matching (now cleaner) introductory IF
   - changed to varchar(20) to match authorised_value's type.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:47:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 18:47:38 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:58:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 18:58:05 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #15 from M. Tompsett  ---
Applies fine.

mtompset at ubuntu:~/kohaclone$ koha-qa.pl -v 2 -c 1
testing 1 commit(s) (applied to bab96c3 'Bug 11571: fix breakage of -f option
')

 FAIL   C4/Koha.pm
   OK     pod
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 288)
                forbidden pattern: tab char (line 45)
   OK     valid
   OK     critic

...

 FAIL   opac/opac-search.pl
   OK     pod
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 411)
                forbidden pattern: tab char (line 228)
   OK     valid
   OK     critic

Please correct your tab issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:07:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 19:07:03 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #16 from Blou  ---
Created attachment 24779
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24779&action=edit
Fix tab issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:16:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 19:16:32 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #11 from Blou  ---
> I have a concern: we can't know if the user has been notified or if the
> email used was the SendAllEmailsTo content.
On most situation where Koha sends an email to ... anyone, we have no way to
know such action is taking place (script, cron...).  But if the email specified
in the pref starts receiving a lot of emails, that should make it clear.  I
rather have lot of emails in that box that I then need to reforward, rather
than the reverse (call back emails sent wrongly to user).

> It could cause problem on debugging if the pref is available on a production
> server.
Actually, we need it on a production server.  (Our) usage is to set as initial
email when things are being set up.  We do not want emails start flying to
users while still getting set up.

Another common usage is for testing, but on a copy a production database. 
Obviously, we do not want users to receive email based on now out of date/sync
data.

This can act as a safety valve on various situation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:22:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 19:22:40 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #17 from M. Tompsett  ---
Comment on attachment 24778
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24778
Bug 10937 - Option to hide and group itemtypes from advanced search

Review of attachment 24778:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10937&attachment=24778)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +7950,5 @@
> +    $dbh->do(q{
> +        ALTER TABLE itemtypes
> +            ADD hideinopac TINYINT(1) NOT NULL DEFAULT 0,
> +            ADD searchcategory VARCHAR(20) DEFAULT NULL;
> +    });

You forgot to print out a meaningful message and call SetVersion, like the
other ones. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:43:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 19:43:26 +0000
Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:23:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 20:23:11 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #18 from M. Tompsett  ---
CURRENT TEST PLAN
------------------
0) Back up database, so you can reset and retest easily. ;)
1) Run Koha QA tool.
2) Apply the patch

SETUP
3) run ./installer/data/mysql/updatedatabase.pl to add the
    two columns to itemtypes
   -- Does a meaningful message get printed?
      Are the columns added?
       "DESCRIBE itemtypes;" should list hideinopac and searchcategory.
4) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values,
       select DOCTYPECAT in the 'Show category:' dropdown
   b) Click button "New authorized value for DOCTYPECAT"
   c) Enter
         Authorized value: HARDWARE
         Description : Hardware
         Description (OPAC): Hardware

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least) two item types and
for each:
      - Click action/Edit on the right column
      - Third row (below Description) is the Search category list box, select
Hardware
      - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a different item type:
      -  Click action/Edit
      -  Click the checkbox "Hide in OPAC" below the list of icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

More revisions to follow once I actually start testing this fully. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:41:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 20:41:35 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #40 from mathieu saby  ---
OK, I did not understand your point of view. I thought you agreed for removing
biblionumber param...

I'm going to test your patch asap

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:43:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 20:43:40 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #9 from M. Tompsett  ---
With bootstrap being the default, could we get the equivalent bootstrap tweaks
in this too?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:55:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 20:55:23 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #26 from Blou  ---
Created attachment 24780
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24780&action=edit
Fixes all comments specified by mtompsett.

Same testing procedure.

Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:57:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 20:57:12 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24586|0                           |1
        is obsolete|                            |
  Attachment #24780|0                           |1
        is obsolete|                            |

--- Comment #27 from Blou  ---
Created attachment 24781
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24781&action=edit
Bug 8753 - Add forgot password link to OPAC

This includes fix following the most recent comments and a rebasing to 3.15.15

TEST PLAN:

1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 
That will cause the link 'Forgot your password' to show up on the welcome page,
below connection box.
3) refresh front page, click on 'Forgot your password' and enter a VALID
address (one that is associated to an entry in borrowers.email or
borrowers.email_pro.
3b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
4) An email should be received at that address with a link.
5) Follow the link in the mail to fill the new password.
   Until a satisfactory new password is entered, the old password is not reset.
6) Go to main page try the new password.

Fixes all comments specified by mtompsett.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:02:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 21:02:59 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #19 from Blou  ---
Created attachment 24782
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24782&action=edit
(Re?)added update message and set version to 3.15.XXX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:03:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 21:03:35 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:03:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 21:03:37 +0000
Subject: [Koha-bugs] [Bug 11617] Add itemnumber constraint to aqorders_items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11617

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24742|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett  ---
Created attachment 24783
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24783&action=edit
[SIGNED OFF] Bug 11617: Add itemnumber constraint to aqorders_items

This patch adds a foreign key constraint to aqorders_items on itemnumber.
It is a follow-up on report 10869 with changes to DelOrder.
This removes the need to delete these records in DelOrder.

REVISED TEST PLAN
---------
0) Backup DB, because you may want it back after.
1) go into mysql client, use the koha database and check:
   SHOW CREATE TABLE aqorders_items;
   -- should only be one constraint.
2) apply the patch
3) ./installer/mysql/data/updatedatabase.pl
4) go into mysql client, use the koha database and check:
   SHOW CREATE TABLE aqorders_items;
   -- should be two constraints.
5) drop the koha database and recreate it.
6) go to the staff client and do the web install.
7) go into mysql client, use the koha database and check:
   SHOW CREATE TABLE aqorders_items;
   -- should be two constraints.
8) Restore DB

Note that the constraints are in different orders, but identical.
The added constraint is:
  CONSTRAINT `aqorders_items_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES
`items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:32:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 21:32:44 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21976|0                           |1
        is obsolete|                            |
  Attachment #22315|0                           |1
        is obsolete|                            |

--- Comment #12 from Blou  ---
Created attachment 24784
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24784&action=edit
Bug 8000 - Override emails of every message sent from Koha

Note: rebased to 3.15

For testing purposes, we do not want emails sent to (legitimate) users.  And
sometime we also like to actually see what would be generated for the users. 
This preference will allow to override every message sent by koha with a new
(temporary) To address.  Leave it empty for normal usage.

C4/Letters.pm
installer/data/mysql/sysprefs.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref

TESTING:
0) Run updatedatabase.pl
1) Enter a valid address for new preference SendAllEmailsTo, something that
will be easily identified as NOT the normal destination for the Koha emails.
2) Have koha generate an email to a user.  Or any other mean prefered that
cause Koha to send email.
3) Validate that the email is NOT sent to the user.
4) Validate that the email IS sent to the overriding address.
5) Clean the preference
6) Redo the test, validate that the email is going to the right address.

PS Not sure if those steps are precise enough.  I'm not comfortable enough to
specify the best way to generate emails, I personnally had to hack it in my
environment.  Feedbacks welcomed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:02:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 22:02:26 +0000
Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

--- Comment #63 from Galen Charlton  ---
>From my review of this patch, five tests in t/QueryParser.t fail.  At first
glance, I think the problem is with the tests, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:44:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 22:44:41 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #48 from Katrin Fischer  ---
Hi Kyle, I can see that you split the database update, but not sure which other
changes you included - could you leave a comment about my comments?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 00:20:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2014 23:20:32 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #28 from Chris Cormack  ---
Comment on attachment 24781
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24781
Bug 8753 - Add forgot password link to OPAC

Review of attachment 24781:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8753&attachment=24781)
-----------------------------------------------------------------

::: opac/opac-password-recovery.pl
@@ +135,5 @@
> +    if (   ($borrower_number)
> +        && ( $password eq $repeatPassword )
> +        && ( length($password) >= $minPassLength ) )
> +    {  #apply changes
> +        changepassword( $username, $borrower_number, md5_base64($password) );

We no longer md5 hash the password in Koha, you should do 

use Koha::AuthUtils;

hash_password($password) instead.  

(It's using bcrypt with a salt). Old passwords still work, we check both, but
anytime people change their password it should be hashed with the much more
secure bcrypt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 04:10:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 03:10:41 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #20 from M. Tompsett  ---
Okay... that fresh install works. the update works.
the editing the itemtype stuff all seems to work.
But I can't get it to search properly.

ARTCL     Article
AUD     Audio CD
BK     Books
CF     Computer Files
CR     Continuing Resources
EBK     Ebooks, Online Resources
IM     In house Material
MP     Maps
MF     Microfiche
MX     Mixed Materials
MU     Music
REF     Reference
RPR     Reprint, VFile
TH     Thesis, Dissertation
VCD     Video CD
VM     Visual Materials

These are my item types. I took the first 8 and did a pretty 0-7 binary
combination with HARDWARE, Hide in OPAC, and Not for Loan.

I then went to the OPAC interface, clicked on Advanced Search and tried to make
sense of the Item type box. 10 things plus hardware were displayed. 16-4
(hidden in OPAC) = 12, 12-2 (not hidden in OPAC, but HARDWARE) = 10. plus
hardware. Display looks good.

I checked hardware, and then clicked the Search button at the bottom of the
page.

I got a bunch of results, but this is where it doesn't make sense. My first
result was a journal (Continuing Resources), which I had marked as no category,
not for loan, hide in OPAC. The fact that the search returned a no category,
and not the hardware category makes it seem broken.

Here is the URL (the name doesn't exist):
https://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=kw&q=&idx=kw&q=&idx=kw&q=&limit-yr=&searchcat=HARDWARE&limit=&limit=&multibranchlimit=&sort_by=relevance&do=Search

Hmmm... I changed the sort by drop down to title A-Z and the first one was BK,
so that was expected. The result count is strangely high too, but perhaps I am
mistaken in that account. I'll check manually later. Until then, I'm leaving
this as Failed QA, because the search by relevance gave me a bad result, and I
don't know if it is this patch, or just the by relevance search in general.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 04:48:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 03:48:05 +0000
Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching
 for duplicates during import is too low
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett  ---
Couldn't we have logic that knows about tighter matches (ISBN) vs. less precise
matches (authors)? And for the less precise ones, couldn't even 1000 still
fail?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 05:47:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 04:47:04 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett  ---
Does this mean that
./koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
doesn't need that /* Tablesorter */ section?

And is this at all related to the UseTablesortForCirc system preference?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 06:28:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 05:28:39 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24740|0                           |1
        is obsolete|                            |

--- Comment #3 from M. Tompsett  ---
Created attachment 24785
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24785&action=edit
[SIGNED OFF] Bug 11616: tablesorter is no longer in use

DataTables has replaced the tablesorter plugin to sort tables into Koha.
There is no table using this plugin and all references could be removed.

REVISED TEST PLAN
-----------------
1) Apply the patch
2) Home -> Koha administration -> Authorized values
3) Change the 'Show category:' drop down value, and play with
    the sorting of columns.
   -- should sort as expected.
4) Search the catalogue -> look for a biblio with high circulation
5) Click one of the name links.
6) Click the Items tab on the left.
7) Scroll down and click the (View item's checkout history)
    link in the History area.
   -- Does the sorting work there too?
      NOTE: I couldn't find data that generated sortable tables.
            All my checkouts were 0, for some strange reason.
8) git grep -i tablesorter
   -- Only a reference in staff-global.css and release texts.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 06:30:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 05:30:56 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 06:31:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 05:31:05 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24785|0                           |1
        is obsolete|                            |

--- Comment #4 from M. Tompsett  ---
Created attachment 24786
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24786&action=edit
[SIGNED OFF] Bug 11616: tablesorter is no longer in use

DataTables has replaced the tablesorter plugin to sort tables into Koha.
There is no table using this plugin and all references could be removed.

REVISED TEST PLAN
-----------------
1) Apply the patch
2) Home -> Koha administration -> Authorized values
3) Change the 'Show category:' drop down value, and play with
    the sorting of columns.
   -- should sort as expected.
4) Search the catalogue -> look for a biblio with high circulation
5) Click one of the name links.
6) Click the Items tab on the left.
7) Scroll down and click the (View item's checkout history)
    link in the History area.
   -- There was no sorting prior to the patch, so afterwards
      it should display the same.
8) git grep -i tablesorter
   -- Only a reference in staff-global.css and release texts.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 07:06:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 06:06:32 +0000
Subject: [Koha-bugs] [Bug 11623] New: Errors with upgrade from 3.00.00.070
	to 3.14.02.000
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11623

            Bug ID: 11623
           Summary: Errors with upgrade from 3.00.00.070 to 3.14.02.000
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dswhite42 at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

There are a number of database upgrade errors that take place when upgrading
from 3.00.00.070 to 3.14.02.000

* A number of upgrades expect the tables to have foreign keys and be in InnoDB
format.  In 3.00.00.070, MyISAM (and no foreign keys) is the standard.  With no
testing to see if the keys exist, these commands fail with (errno: 152)

Problem examples:
ALTER TABLE issues DROP FOREIGN KEY `issues_ibfk_1`
ALTER TABLE issues DROP FOREIGN KEY `issues_ibfk_2`
ALTER TABLE `message_transports` DROP FOREIGN KEY `message_transports_ibfk_3`
ALTER TABLE patronimage DROP FOREIGN KEY patronimage_fk1


* In updatedatabase.pl, in the section for DBVersion 3.00.00.091, there are
references to the @sql_scripts
"installer/data/mysql/en/optional/sample_notices_message_attributes.sql" and
"installer/data/mysql/en/optional/sample_notices_message_transports.sql" . 
These should be
"installer/data/mysql/en/mandatory/sample_notices_message_attributes.sql" and
"installer/data/mysql/en/mandatory/sample_notices_message_transports.sql"


* Even when that's corrected, the sample_notices_message_transports.sql script
fails because it references foreign keys to the "letters" table that have not
been created yet.  The reserves/HOLD combo isn't created until the 3.01.00.05
section of the updatedatabase.pl script, and circulation/CHECKIN and
circulation/CHECKOUT are not created until the 3.01.00.013 section.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 07:19:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 06:19:04 +0000
Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent
 from the staff client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22945|0                           |1
        is obsolete|                            |
                 CC|                            |mtompset at hotmail.com

--- Comment #12 from M. Tompsett  ---
Comment on attachment 22945
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22945
Patch to fix and use OPACBaseURL on all send list and send basket pages

Second set of patches looks more thorough. Testing them.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 07:27:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 06:27:19 +0000
Subject: [Koha-bugs] [Bug 11623] Errors with upgrade from 3.00.00.070 to
	3.14.02.000
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11623

--- Comment #1 from David White  ---
I'll just add my own workarounds to these:

* Convert everything to InnoDB prior to running the upgrade script.

* Of these ALTER TABLE DROP FOREIGN KEY errors, the only one that seems to
actually generate a red warning message is the patronimage one.  I solved this
by pre-creating the "patronimage" table with the patronimage_fk1 foreign key,
so the script can happily drop it

* Rewrote the /optional/ pathnames to /mandatory/

* Altered the sample_notices_message_transports.sql to delete these lines:

(4, 'email', 0, 'reserves',    'HOLD')
(4, 'sms',   0, 'reserves',    'HOLD')
(5, 'email', 0, 'circulation', 'CHECKIN')
(5, 'sms',   0, 'circulation', 'CHECKIN')
(6, 'email', 0, 'circulation', 'CHECKOUT')
(6, 'sms',   0, 'circulation', 'CHECKOUT')

These will allow the script to run at the right time, and the 6 lines above
will be created later by updatedatabase.pl later in the script anyway (when the
appropriate entries in the 'letters' table have also been created).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 07:47:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 06:47:42 +0000
Subject: [Koha-bugs] [Bug 11623] Errors with upgrade from 3.00.00.070 to
	3.14.02.000
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11623

--- Comment #2 from David White  ---
Sorry, one other bug:

* When attempting to run "misc/maintenance/remove_items_from_biblioitems.pl", a
number of SQL statements fail because C4/Biblio.pm tries to update columns that
don't exist in 3.00.00.070 .  Specifically, any attempt to "UPDATE biblioitems"
that refers to the "ean" and "agerestriction" column fails.

* workaround: temporarily remove references to those columns in C4/Biblio.pm,
and restore them after "remove_items_from_biblioitems.pl" has completed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 08:28:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 07:28:12 +0000
Subject: [Koha-bugs] [Bug 11459] OrderPdfFormat pref description could be
	more verbose
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459

mathieu saby  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24735|0                           |1
        is obsolete|                            |

--- Comment #3 from mathieu saby  ---
Created attachment 24787
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24787&action=edit
[PATCH] Bug 11459: Make OrderPdfFormat syspref description more verbose

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:32:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 10:32:28 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #9 from Olli-Antti Kivilahti  ---
Created attachment 24788
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24788&action=edit
Bug 11175 - Show the parent record's component parts in the detailed views.
Business layer.

TERMINOLOGY:
"Component part": A Bibliographic record connected to it's host record via
$773w -> 001
  or via other Record-control-number-index relation.
"Host record": A bibliographic record which contains child records. Host record
doesn't
  need to have a link to the child record.

USEFUL:
For music cataloguers whose jobs depend on these.
For browsing the contents of a musical record.
Provides the basis for a high quality music library service.

Because Koha has the building blocks to create these component part records out
of box, it is odd
that they can't be displayed out of box.

This patch adds a system preference AddComponentPartRecordsToDetailedViews.
This controls if component part records data is appended after the
bibliographic data for XSLT parsing.
Also makes sure that component part records are not pulled needlessly for
non-detailed views as
this would cripple performance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:32:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 10:32:51 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #10 from Olli-Antti Kivilahti  ---
Created attachment 24789
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24789&action=edit
Bug 11175 - Show the parent record's component parts in the detailed views.
Presentation for prog-theme.

This displays the injected component part records in the prog theme.

--------------------------------------
TEST PLAN
--------------------------------------

PREREQUISITES:

-AddChildRecordsToDetailedViews system preference needs to be activated.
-opacthemes system preference needs to be 'prog'.
-template system preference needs to be 'prog'.

-Catalog a bunch of child records for a host record.
--Search a record and go to detailed view.
--Use the existing functionality "+ New" -> "New Child Record" to catalog child
records.

------------------------
TEST CASE1 - Staff client
------------------------

-Reindex Zebra
-Search for the record you just made childs for and display it in the normal
detail.pl -view.
-Verify that a list of child records are displayed on the right side of the
browser window.

------------------------
TEST CASE2 - OPAC
------------------------

-Reindex Zebra
-Search for the record you just made childs for and display it in the
opac-detail.pl -view.
-Verify that a list of child records are displayed on the right side of the
browser window.

------------------------
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:33:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 10:33:08 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #11 from Olli-Antti Kivilahti  ---
Created attachment 24790
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24790&action=edit
Bug 11175 - Show the parent record's component parts in the detailed views.
Presentation for bootstrap-theme.

This displays the injected component part records in the bootstrap theme.

--------------------------------------
TEST PLAN
--------------------------------------

PREREQUISITES:

-AddChildRecordsToDetailedViews system preference needs to be activated.
-opacthemes system preference needs to be 'bootstrap'.

-Catalog a bunch of child records for a host record.
--Search a record and go to detailed view.
--Use the existing functionality "+ New" -> "New Child Record" to catalog child
records.

------------------------
TEST CASE1 - OPAC
------------------------

-Reindex Zebra
-Search for the record you just made childs for and display it in the
opac-detail.pl -view.
-Verify that a list of child records are displayed on the right side of the
browser window.

------------------------
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:46:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 10:46:52 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #12 from Olli-Antti Kivilahti  ---
(In reply to Katrin Fischer from comment #7)
> Hi, 
> 
> starting with a code review: 

Thank you for the effort Katrin! It is much appreciated!
> 
> - Small thing: Please break your commit messages into shorter lines so 
>   they are easier to read in a terminal window.
I hope it's better. I also hope with shorter lines you don't mean the dreaded
80 character maximum.
>   
> - Please provide a follow-up for the Bootstrap theme. As prog and
>   CCSR are going to be deprecated this is mandatory now.
>   
Follow up provided!

> - Database update adding the new system preference is missing.
> 
Provided!

> - The way this is coded it's a MARC21 specific feature. The rcn index
>   and 001 > $w linking are not MARC agnostic. Please check for the
>   marcflavor in your code and include a note
>   about the limitation to MARC21 in the syspref description.
>   
Added a note to the system preference.
Didn't add any syspref checks to the business layer.
Uncertain if rcn is unused in UNIMARC. If rcn-index is unpopulated, then should
cause zero extra overhead.
If rcn is populated in UNIMARC, then this feature should work?

> - Some of the comments look like TODOs - maybe something you want to 
>   take another look at?
> 
Apologies for that. I think it was a classical mistake.

> - Creating our 'own' XML in a MARCXML record doesn't look right to me. I
>   would much prefer if that could be expressed in normal MARC21 fields
>   and subfields.
>   
I guess I could differentiate from the searched component part records the marc
field they use to make the linking. All the data is available since the found
records are converted into MARC::Record objects.
Then this data could be injected to appropriate MARC::Fields to construct a
proper marc record.
If this behaviour is wanted maybe it is better to create them when these
component part relations are defined? Thus these links would be preserved
during MARC-export function.
The effort however doesn't justify the perceived benefits in my opinion. If you
can demonstrate the benefits (like displaying different kinds of component
relations under different heading) a follow-up can be prepared and designed.

Also a "own" XML in MARCXML is already there inside the -tag.

> - With the heading "Child records" you assume that it will be always
>   a component part, but that's not true. 001 > $w linkings are used
>   to express a lot of different relationships between records. I think
>   putting a bit more thought into the various relationships could be
>   good here.
> 
You are very correct. I went to the MARC21 manual and looked into the various
aspects of linkings. I changed the terminology to "child" -> "component part".

> Also the QA script points out some issues:
> 
>  FAIL	C4/XSLT.pm
>    FAIL	  pod
> 		*** ERROR: Unknown command 'head'  in file C4/XSLT.pm
> 		*** ERROR: Spurious text after =cut  in file C4/XSLT.pm
I don't know from where these are coming from?
>    OK	  forbidden patterns
>    OK	  valid
>    FAIL	  critic
> 		# Variables::ProhibitConditionalDeclarations: Got 1 violation(s).
Fixed this issue. perlcritic++

Happy to deliver!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 12:46:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 11:46:06 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24790|0                           |1
        is obsolete|                            |

--- Comment #13 from Olli-Antti Kivilahti  ---
Created attachment 24791
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24791&action=edit
Bug 11175 - Show the parent record's component parts in the detailed views.
Presentation for bootstrap-theme.

This displays the injected component part records in the bootstrap theme.

--------------------------------------
TEST PLAN
--------------------------------------

PREREQUISITES:

-AddChildRecordsToDetailedViews system preference needs to be activated.
-opacthemes system preference needs to be 'bootstrap'.

-Catalog a bunch of child records for a host record.
--Search a record and go to detailed view.
--Use the existing functionality "+ New" -> "New Child Record" to catalog child
records.

------------------------
TEST CASE1 - OPAC
------------------------

-Reindex Zebra
-Search for the record you just made childs for and display it in the
opac-detail.pl -view.
-Verify that a list of child records are displayed on the right side of the
browser window.

------------------------
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 12:46:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 11:46:51 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23049|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 12:56:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 11:56:42 +0000
Subject: [Koha-bugs] [Bug 11624] New: Impossible to style MARC display via
	CSS
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11624

            Bug ID: 11624
           Summary: Impossible to style MARC display via CSS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It's impossible to style the MARC display field number, indicators, and the
descriptions via CSS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:00:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:00:09 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24757|0                           |1
        is obsolete|                            |
  Attachment #24758|0                           |1
        is obsolete|                            |
  Attachment #24759|0                           |1
        is obsolete|                            |
  Attachment #24760|0                           |1
        is obsolete|                            |
  Attachment #24761|0                           |1
        is obsolete|                            |
  Attachment #24762|0                           |1
        is obsolete|                            |
  Attachment #24763|0                           |1
        is obsolete|                            |
  Attachment #24764|0                           |1
        is obsolete|                            |
  Attachment #24765|0                           |1
        is obsolete|                            |
  Attachment #24766|0                           |1
        is obsolete|                            |
  Attachment #24767|0                           |1
        is obsolete|                            |
  Attachment #24768|0                           |1
        is obsolete|                            |
  Attachment #24769|0                           |1
        is obsolete|                            |
  Attachment #24770|0                           |1
        is obsolete|                            |
  Attachment #24771|0                           |1
        is obsolete|                            |
  Attachment #24772|0                           |1
        is obsolete|                            |
  Attachment #24777|0                           |1
        is obsolete|                            |

--- Comment #166 from Kyle M Hall  ---
Created attachment 24792
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24792&action=edit
Bug 6427 [Part 1] - Update schema files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:00:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:00:54 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #167 from Kyle M Hall  ---
Created attachment 24793
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24793&action=edit
Bug 6427 [Part 2] - Add new accounts related modules

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:00:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:00:59 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #168 from Kyle M Hall  ---
Created attachment 24794
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24794&action=edit
Bug 6427 [Part 3] - Add new TT plugin to deal with currency

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:05 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #169 from Kyle M Hall  ---
Created attachment 24795
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24795&action=edit
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and
payments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:10 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #170 from Kyle M Hall  ---
Created attachment 24796
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24796&action=edit
Bug 6427 [Part 5] - Implement new accounting system in the opac

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:14 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #171 from Kyle M Hall  ---
Created attachment 24797
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24797&action=edit
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:18 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #172 from Kyle M Hall  ---
Created attachment 24798
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24798&action=edit
Bug 6427 [Part 7] - Update cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:23 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #173 from Kyle M Hall  ---
Created attachment 24799
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24799&action=edit
Bug 6427 [Part 8] - Update existing intranet scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:27 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #174 from Kyle M Hall  ---
Created attachment 24800
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24800&action=edit
Bug 6427 [Part 9] - Update existing perl modules to support new accounting
system

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:31 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #175 from Kyle M Hall  ---
Created attachment 24801
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24801&action=edit
Bug 6427 [Part 10] - Update reports wizard

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:35 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #176 from Kyle M Hall  ---
Created attachment 24802
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24802&action=edit
Bug 6427 [Part 11] - Add new utility functions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:40 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #177 from Kyle M Hall  ---
Created attachment 24803
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24803&action=edit
Bug 6427 [Part 12] - Add and update unit tests

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:44 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #178 from Kyle M Hall  ---
Created attachment 24804
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24804&action=edit
Bug 6427 [Part 13] - Add database updates

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:49 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #179 from Kyle M Hall  ---
Created attachment 24805
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24805&action=edit
Bug 6427 [Part 14] - Delete unused and unnecessary files

 This patch re-engineers Koha's accounting system to be faster, more
 stable, and  have a better historical accounting of fees and payments
 while also unifying much of the payment logic and simplifying the code
 behind it.

 Three new tables have been created:
 account_debits stores fines and fees owed by the patron.

 account_credits stores payments, write-offs, and other line items that
 reduce the amount owed by a patron.

 account_offsets stores data about changes to debits and credits,
 including which credits paid which debits.

 borrowers.account_balance stores the current balance of the
 patron, so it does not have to be calculated each time it needs to be
 displayed.

 issues.issue_id has been added so that individual fines can be directly
 linked to the issue that caused them without ambiguity.

 The various accounting code strings ( F, FU, Rent, etc ), some of which
 have little or no documentation have been replaced by what enumerated
 data types which are documented via POD.
 There are three, one for each of Debits ( fees/fines ), Credits (
         payments ),
 and Offsets.

 The system continues to allow custom fee types ( moving MANUAL_INV to
         MANUAL_DEBIT )
 while additionally allowing custom payment types ( MANUAL_CREDIT ).

 The system also allows for overpayment, the the outstanding credit
 being
 applied to future fees as they are created.

 The system also allows for a librarian to accept a different amount of
 money than what is to be paid, and will calculate the change to be
 given.

 Test Plan:
 1) Apply this patch
 2) Create some manual fees
 3) Test the fee payments
    * Pay one fee
    * Pay multiple fees
    * Make a partial payment
    * Write off a fee
 4) View the fees/payments, verify they are correct
 5) Check out some items as overdue that should have fines
 6) Run fines.pl, verify fines were generated
 7) Pay on an accruing fine
 8) Run fines.pl again, verify the fine hasn't changed
 9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:55 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #180 from Kyle M Hall  ---
Created attachment 24806
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24806&action=edit
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:01:59 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #181 from Kyle M Hall  ---
Created attachment 24807
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24807&action=edit
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed
KohaAuthorisedValues plugin

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:02:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:02:07 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #182 from Kyle M Hall  ---
Created attachment 24808
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24808&action=edit
Bug 6427 [Part 17] - Add cron script to recalculate account balances

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:02:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:02:09 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #41 from M. de Rooy  ---
(In reply to mathieu saby from comment #40)
> OK, I did not understand your point of view. I thought you agreed for
> removing biblionumber param...
Hi Matthieu,
My question about removing the biblionumber actually was inspired by the
thought that it was better to keep it than remove it and look it up again with
another database query..
Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:10:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:10:58 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24792|0                           |1
        is obsolete|                            |
  Attachment #24793|0                           |1
        is obsolete|                            |
  Attachment #24794|0                           |1
        is obsolete|                            |
  Attachment #24795|0                           |1
        is obsolete|                            |
  Attachment #24796|0                           |1
        is obsolete|                            |
  Attachment #24797|0                           |1
        is obsolete|                            |
  Attachment #24798|0                           |1
        is obsolete|                            |
  Attachment #24799|0                           |1
        is obsolete|                            |
  Attachment #24800|0                           |1
        is obsolete|                            |
  Attachment #24801|0                           |1
        is obsolete|                            |
  Attachment #24802|0                           |1
        is obsolete|                            |
  Attachment #24803|0                           |1
        is obsolete|                            |
  Attachment #24804|0                           |1
        is obsolete|                            |
  Attachment #24805|0                           |1
        is obsolete|                            |
  Attachment #24806|0                           |1
        is obsolete|                            |
  Attachment #24807|0                           |1
        is obsolete|                            |
  Attachment #24808|0                           |1
        is obsolete|                            |

--- Comment #183 from Kyle M Hall  ---
Created attachment 24809
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24809&action=edit
Bug 6427 [Part 1] - Update schema files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:20 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #184 from Kyle M Hall  ---
Created attachment 24810
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24810&action=edit
Bug 6427 [Part 2] - Add new accounts related modules

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:24 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #185 from Kyle M Hall  ---
Created attachment 24811
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24811&action=edit
Bug 6427 [Part 3] - Add new TT plugin to deal with currency

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:29 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #186 from Kyle M Hall  ---
Created attachment 24812
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24812&action=edit
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and
payments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:34 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #187 from Kyle M Hall  ---
Created attachment 24813
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24813&action=edit
Bug 6427 [Part 5] - Implement new accounting system in the opac

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:38 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #188 from Kyle M Hall  ---
Created attachment 24814
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24814&action=edit
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:42 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #189 from Kyle M Hall  ---
Created attachment 24815
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24815&action=edit
Bug 6427 [Part 7] - Update cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:47 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #190 from Kyle M Hall  ---
Created attachment 24816
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24816&action=edit
Bug 6427 [Part 8] - Update existing intranet scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:51 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #191 from Kyle M Hall  ---
Created attachment 24817
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24817&action=edit
Bug 6427 [Part 9] - Update existing perl modules to support new accounting
system

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:11:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:11:56 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #192 from Kyle M Hall  ---
Created attachment 24818
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24818&action=edit
Bug 6427 [Part 10] - Update reports wizard

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:12:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:12:00 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #193 from Kyle M Hall  ---
Created attachment 24819
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24819&action=edit
Bug 6427 [Part 11] - Add new utility functions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:12:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:12:07 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #194 from Kyle M Hall  ---
Created attachment 24820
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24820&action=edit
Bug 6427 [Part 12] - Add and update unit tests

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:12:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:12:12 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #195 from Kyle M Hall  ---
Created attachment 24821
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24821&action=edit
Bug 6427 [Part 13] - Add database updates

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:12:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:12:16 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #196 from Kyle M Hall  ---
Created attachment 24822
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24822&action=edit
Bug 6427 [Part 14] - Delete unused and unnecessary files

 This patch re-engineers Koha's accounting system to be faster, more
 stable, and  have a better historical accounting of fees and payments
 while also unifying much of the payment logic and simplifying the code
 behind it.

 Three new tables have been created:
 account_debits stores fines and fees owed by the patron.

 account_credits stores payments, write-offs, and other line items that
 reduce the amount owed by a patron.

 account_offsets stores data about changes to debits and credits,
 including which credits paid which debits.

 borrowers.account_balance stores the current balance of the
 patron, so it does not have to be calculated each time it needs to be
 displayed.

 issues.issue_id has been added so that individual fines can be directly
 linked to the issue that caused them without ambiguity.

 The various accounting code strings ( F, FU, Rent, etc ), some of which
 have little or no documentation have been replaced by what enumerated
 data types which are documented via POD.
 There are three, one for each of Debits ( fees/fines ), Credits (
         payments ),
 and Offsets.

 The system continues to allow custom fee types ( moving MANUAL_INV to
         MANUAL_DEBIT )
 while additionally allowing custom payment types ( MANUAL_CREDIT ).

 The system also allows for overpayment, the the outstanding credit
 being
 applied to future fees as they are created.

 The system also allows for a librarian to accept a different amount of
 money than what is to be paid, and will calculate the change to be
 given.

 Test Plan:
 1) Apply this patch
 2) Create some manual fees
 3) Test the fee payments
    * Pay one fee
    * Pay multiple fees
    * Make a partial payment
    * Write off a fee
 4) View the fees/payments, verify they are correct
 5) Check out some items as overdue that should have fines
 6) Run fines.pl, verify fines were generated
 7) Pay on an accruing fine
 8) Run fines.pl again, verify the fine hasn't changed
 9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:12:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:12:21 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #197 from Kyle M Hall  ---
Created attachment 24823
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24823&action=edit
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:12:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:12:25 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #198 from Kyle M Hall  ---
Created attachment 24824
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24824&action=edit
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed
KohaAuthorisedValues plugin

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:12:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 12:12:29 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #199 from Kyle M Hall  ---
Created attachment 24825
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24825&action=edit
Bug 6427 [Part 17] - Add cron script to recalculate account balances

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 14:00:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 13:00:21 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

--- Comment #10 from Owen Leonard  ---
> With bootstrap being the default, could we get the equivalent bootstrap
> tweaks in this too?

These patches don't touch the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 14:10:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 13:10:41 +0000
Subject: [Koha-bugs] [Bug 11624] Impossible to style MARC display via CSS
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11624

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |/cgi-bin/koha/catalogue/MAR
                   |                            |Cdetail.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:28:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:28:55 +0000
Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Volkan Sonmez  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mvsonmez at gmail.com

--- Comment #96 from Volkan Sonmez  ---
(In reply to Jonathan Druart from comment #95)
> Software error on cgi-bin/koha/members/member.pl:
> Base class package "DBIx::Class::Schema" is empty.
>     (Perhaps you need to 'use' the module which defines that package first,

This error occurs when DBIx::Class perl module is not installed. Check this
perl module. If not installed, install it and try again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:42:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:42:06 +0000
Subject: [Koha-bugs] [Bug 11328] Local cover images not appearing in staff
 client search results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|local cover images in staff |Local cover images not
                   |                            |appearing in staff client
                   |                            |search results
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:42:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:42:32 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24809|0                           |1
        is obsolete|                            |
  Attachment #24810|0                           |1
        is obsolete|                            |
  Attachment #24811|0                           |1
        is obsolete|                            |
  Attachment #24812|0                           |1
        is obsolete|                            |
  Attachment #24813|0                           |1
        is obsolete|                            |
  Attachment #24814|0                           |1
        is obsolete|                            |
  Attachment #24815|0                           |1
        is obsolete|                            |
  Attachment #24816|0                           |1
        is obsolete|                            |
  Attachment #24817|0                           |1
        is obsolete|                            |
  Attachment #24818|0                           |1
        is obsolete|                            |
  Attachment #24819|0                           |1
        is obsolete|                            |
  Attachment #24820|0                           |1
        is obsolete|                            |
  Attachment #24821|0                           |1
        is obsolete|                            |
  Attachment #24822|0                           |1
        is obsolete|                            |
  Attachment #24823|0                           |1
        is obsolete|                            |
  Attachment #24824|0                           |1
        is obsolete|                            |
  Attachment #24825|0                           |1
        is obsolete|                            |

--- Comment #200 from Kyle M Hall  ---
Created attachment 24826
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24826&action=edit
Bug 6427 [Part 1] - Update schema files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:42:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:42:58 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #201 from Kyle M Hall  ---
Created attachment 24827
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24827&action=edit
Bug 6427 [Part 2] - Add new accounts related modules

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:03 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #202 from Kyle M Hall  ---
Created attachment 24828
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24828&action=edit
Bug 6427 [Part 3] - Add new TT plugin to deal with currency

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:09 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #203 from Kyle M Hall  ---
Created attachment 24829
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24829&action=edit
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and
payments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:13 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #204 from Kyle M Hall  ---
Created attachment 24830
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24830&action=edit
Bug 6427 [Part 5] - Implement new accounting system in the opac

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:18 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #205 from Kyle M Hall  ---
Created attachment 24831
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24831&action=edit
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:23 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #206 from Kyle M Hall  ---
Created attachment 24832
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24832&action=edit
Bug 6427 [Part 7] - Update cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:27 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #207 from Kyle M Hall  ---
Created attachment 24833
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24833&action=edit
Bug 6427 [Part 8] - Update existing intranet scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:32 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #208 from Kyle M Hall  ---
Created attachment 24834
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24834&action=edit
Bug 6427 [Part 9] - Update existing perl modules to support new accounting
system

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:36 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #209 from Kyle M Hall  ---
Created attachment 24835
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24835&action=edit
Bug 6427 [Part 10] - Update reports wizard

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:41 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #210 from Kyle M Hall  ---
Created attachment 24836
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24836&action=edit
Bug 6427 [Part 11] - Add new utility functions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:46 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #211 from Kyle M Hall  ---
Created attachment 24837
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24837&action=edit
Bug 6427 [Part 12] - Add and update unit tests

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:50 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #212 from Kyle M Hall  ---
Created attachment 24838
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24838&action=edit
Bug 6427 [Part 13] - Add database updates

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:43:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:43:55 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #213 from Kyle M Hall  ---
Created attachment 24839
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24839&action=edit
Bug 6427 [Part 14] - Delete unused and unnecessary files

 This patch re-engineers Koha's accounting system to be faster, more
 stable, and  have a better historical accounting of fees and payments
 while also unifying much of the payment logic and simplifying the code
 behind it.

 Three new tables have been created:
 account_debits stores fines and fees owed by the patron.

 account_credits stores payments, write-offs, and other line items that
 reduce the amount owed by a patron.

 account_offsets stores data about changes to debits and credits,
 including which credits paid which debits.

 borrowers.account_balance stores the current balance of the
 patron, so it does not have to be calculated each time it needs to be
 displayed.

 issues.issue_id has been added so that individual fines can be directly
 linked to the issue that caused them without ambiguity.

 The various accounting code strings ( F, FU, Rent, etc ), some of which
 have little or no documentation have been replaced by what enumerated
 data types which are documented via POD.
 There are three, one for each of Debits ( fees/fines ), Credits (
         payments ),
 and Offsets.

 The system continues to allow custom fee types ( moving MANUAL_INV to
         MANUAL_DEBIT )
 while additionally allowing custom payment types ( MANUAL_CREDIT ).

 The system also allows for overpayment, the the outstanding credit
 being
 applied to future fees as they are created.

 The system also allows for a librarian to accept a different amount of
 money than what is to be paid, and will calculate the change to be
 given.

 Test Plan:
 1) Apply this patch
 2) Create some manual fees
 3) Test the fee payments
    * Pay one fee
    * Pay multiple fees
    * Make a partial payment
    * Write off a fee
 4) View the fees/payments, verify they are correct
 5) Check out some items as overdue that should have fines
 6) Run fines.pl, verify fines were generated
 7) Pay on an accruing fine
 8) Run fines.pl again, verify the fine hasn't changed
 9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:44:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:44:00 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #214 from Kyle M Hall  ---
Created attachment 24840
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24840&action=edit
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:44:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:44:07 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #215 from Kyle M Hall  ---
Created attachment 24841
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24841&action=edit
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed
KohaAuthorisedValues plugin

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:44:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:44:12 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #216 from Kyle M Hall  ---
Created attachment 24842
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24842&action=edit
Bug 6427 [Part 17] - Add cron script to recalculate account balances

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:44:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:44:17 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #217 from Kyle M Hall  ---
Created attachment 24843
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24843&action=edit
Bug 6427 [Part 18] - Add TableTools plugin for DataTables

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:44:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:44:22 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #218 from Kyle M Hall  ---
Created attachment 24844
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24844&action=edit
Bug 6427 [Part 19] - Add full debit and credit table Print and Download
features

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:45:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 14:45:21 +0000
Subject: [Koha-bugs] [Bug 11328] Local cover images not appearing in staff
 client search results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:17:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:17:53 +0000
Subject: [Koha-bugs] [Bug 11566] Fixing accessibility on OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566

--- Comment #11 from Owen Leonard  ---
(In reply to Aleisha Amohia from comment #2)
> Removed unnecessary fieldset around Submit button

I assume these patches are based on recommendations that a fieldset not be used
without a corresponding . In this case the fieldset is being used as a
somewhat-semantic grouping element in order to provide a logical hook for CSS.
Removing the fieldset doesn't solve any accessibility problem in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:26:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:26:13 +0000
Subject: [Koha-bugs] [Bug 11625] New: Default to logged in library for circ
 rules and notices & slips
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

            Bug ID: 11625
           Summary: Default to logged in library for circ rules and
                    notices & slips
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It has come to our attention that some librarians will accidentally change
default circulation rules and notices be accident, assuming they are working on
rules and notices for their library by default.

If a librarian is logged in with a set branchcode, we should display that
branches rules by default, and require them to choose the "All libraries"
sections by hand.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:26:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:26:21 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:31:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:31:50 +0000
Subject: [Koha-bugs] [Bug 11626] New: Cannot receive serial issues after
 subscription expiry date
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11626

            Bug ID: 11626
           Summary: Cannot receive serial issues after subscription expiry
                    date
 Change sponsored?: ---
           Product: Koha
           Version: 3.10
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Jeremy.evans at nibsc.org
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Some of our serials subscriptions were not renewed after 31/12/2013 but I
cannot receive any of the outstanding 2013 issues unless I renew the
subscription record (a couple of publishers are about 3 months late with their
printing/postage schedules compared to the subscription/cover dates). For a
couple of these titles we do not have a 2014 subscription so it is not
appropriate to renew the subscription record.
We should still be able to receive late issues after the subscription expiry
date (the date published for these issues would in most cases be on or before
the expiry date)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:36:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:36:20 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #49 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #48)
> Hi Kyle, I can see that you split the database update, but not sure which
> other changes you included - could you leave a comment about my comments?

No changes were made, I split the patch in two, with all schema file updates in
one patch, and the database updates in a second patch. The last 2 patches are
unchanged. I had to renumber them due to the splitting.

Hope this answers your question!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:47:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:47:36 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #50 from Katrin Fischer  ---
I had asked a few more questions in comment 37 - especially about a change
related to reserves.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:49:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:49:28 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:49:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:49:31 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #1 from Kyle M Hall  ---
Created attachment 24845
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24845&action=edit
Bug 11625 - Default to logged in library for circ rules and notices & slips

This patch makes the default circ rules and notices/slips to edit
the logged in branch, if one is set.

Test Plan:
1) Apply this patch
2) Log into staff side, and set your library
3) Browse to Administration/Circulation and fines rules
4) Note the rule set selected is for your library
5) Select "All libraries"
6) Note the rule set selected is for "All libraries"
7) Browse to Toos/Notices & slips
8) Note the notice set selected is for your library
9) Select "All libraries"
10) Not the rule set selected is for "All libraries"
11) Click "New Notice"
12) Note the Library field is set to "All libraries"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:56:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:56:28 +0000
Subject: [Koha-bugs] [Bug 11276] Sprite icons not in right spot on
	translated templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11276

--- Comment #1 from Owen Leonard  ---
FWIW I believe this bug does not affect the Bootstrap theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:59:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 15:59:37 +0000
Subject: [Koha-bugs] [Bug 11627] New: Branch Library not set for item when
 serial issue received
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11627

            Bug ID: 11627
           Summary: Branch Library not set for item when serial issue
                    received
 Change sponsored?: ---
           Product: Koha
           Version: 3.10
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Jeremy.evans at nibsc.org
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

When receiving serial issues we usually have the subscription set to
automatically create an item on receipt using the "create an item record when
receiving this serial" option in the subscription record.

The branch library is specified in the subscription record but this does not
carry through to the newly created item - we have to manually set the branch
library each time (the item type and shelving location do carry through)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:08:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:08:59 +0000
Subject: [Koha-bugs] [Bug 11628] New: staffaccess permission is missing in
 french userflags.sql file
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11628

            Bug ID: 11628
           Summary: staffaccess permission is missing in french
                    userflags.sql file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

'staffaccess' permission (17) is missing in
installer/mysql/data/fr-FR/1-Obligatoire/userflags.fr

This patch adds it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:10:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:10:13 +0000
Subject: [Koha-bugs] [Bug 11628] staffaccess permission is missing in french
 userflags.sql file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11628

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:18:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:18:33 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24781|0                           |1
        is obsolete|                            |

--- Comment #29 from Blou  ---
Created attachment 24846
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24846&action=edit
Bug 8753 - Add forgot password link to OPAC

Removed md5 usage.  Replaced with AuthUtils' hash_password.

System preference 'OPACBaseUrl' must be set for this feature to work properly
(otherwise, the link sent in the email will be invalid).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:18:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:18:42 +0000
Subject: [Koha-bugs] [Bug 11628] staffaccess permission is missing in french
 userflags.sql file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11628

--- Comment #1 from Sophie MEYNIEUX  ---
Created attachment 24847
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24847&action=edit
Bug 11628 : staffaccess permission is missing in french userflags.sql file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:19:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:19:07 +0000
Subject: [Koha-bugs] [Bug 11628] staffaccess permission is missing in french
 userflags.sql file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11628

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:42:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:42:23 +0000
Subject: [Koha-bugs] [Bug 11629] New: Add ability to update not for loan
 status on checkin
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

            Bug ID: 11629
           Summary: Add ability to update not for loan status on checkin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Some libraries would like to streamline the cataloging process my automatically
updating notforloan values on checkin. For example, an item is set to
notforloan of -1 ( ordered ). The item, is received, processed, and checked in
for the first time before being shelved. The checkin automatically changes the
nfl value from -1 to 0. The same workflow could be used for damaged items as
well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:48:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:48:53 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:48:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:48:55 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

--- Comment #1 from Kyle M Hall  ---
Created attachment 24848
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24848&action=edit
Bug 11629 - Add ability to update not for loan status on checkin

Some libraries would like to streamline the cataloging process my
automatically updating notforloan values on checkin. For example, an
item is set to notforloan of -1 ( ordered ). The item, is received,
processed, and checked in for the first time before being shelved.
The checkin automatically changes the nfl value from -1 to 0. The
same workflow could be used for damaged items as well.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateNotForLoanStatusOnCheckin
   to the following:
-1: 0
0: 1
4) Create an item, set it's notforloan value to -1
5) Check in the item, note its not for loan value is now 0
6) Check in the item again, note its not for loan value is now 1
7) Check in the item again, note its not for loan value reamins 1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:49:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:49:27 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24848|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall  ---
Created attachment 24849
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24849&action=edit
Bug 11629 - Add ability to update not for loan status on checkin

Some libraries would like to streamline the cataloging process my
automatically updating notforloan values on checkin. For example, an
item is set to notforloan of -1 ( ordered ). The item, is received,
processed, and checked in for the first time before being shelved.
The checkin automatically changes the nfl value from -1 to 0. The
same workflow could be used for damaged items as well.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateNotForLoanStatusOnCheckin
   to the following:
-1: 0
0: 1
4) Create an item, set it's notforloan value to -1
5) Check in the item, note its not for loan value is now 0
6) Check in the item again, note its not for loan value is now 1
7) Check in the item again, note its not for loan value reamins 1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:51:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:51:19 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 17:51:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 16:51:25 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:35:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 17:35:47 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:35:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 17:35:50 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23659|0                           |1
        is obsolete|                            |

--- Comment #11 from M. Tompsett  ---
Created attachment 24850
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24850&action=edit
[SIGNED OFF] Bug 11027 : Add a column for basketgroups in late orders table and
improve other columns

This patch makes 4 changes in late orders page :
- adding a new column for basketgroup, displaying the name and number of the
basketgroup
- displaying the name of the basket as well as its number, with a hyperlink to
this basketgroup
- displaying fund in a separate column to make sorting easier, and renaming it
from "budget" to "fund" (the confusion can be found elsewhere in Koha...)
- displaying branch in a separate column to make sorting easier (this column
could be improved later, by getting branch from basketgroup if there is one)

For that, in Aquisition.pm, I made some changes to GetLateOrders :
- 3 new columns in SELECT
- 1 new join

To test :
1. Display the list of late orders of your instance.
2. Check you have 3 new columns for basketgroups, fund and branch
3. In basketgroup column you should have "name of basket group (number)"
4. In basket column you should have "name of basket (number)"
5. Check the links for basketgroups. They should send you to the page
displaying information for each basketgroup
(without possibiliy of editing them if they are closed)

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:37:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 17:37:00 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23762|0                           |1
        is obsolete|                            |
  Attachment #24850|0                           |1
        is obsolete|                            |

--- Comment #12 from M. Tompsett  ---
Created attachment 24851
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24851&action=edit
[SIGNED OFF] Bug 11027 : Add a column for basketgroups in late orders table and
improve other columns

This patch makes 4 changes in late orders page :
- adding a new column for basketgroup, displaying the name and number of the
basketgroup
- displaying the name of the basket as well as its number, with a hyperlink to
this basketgroup
- displaying fund in a separate column to make sorting easier, and renaming it
from "budget" to "fund" (the confusion can be found elsewhere in Koha...)
- displaying branch in a separate column to make sorting easier (this column
could be improved later, by getting branch from basketgroup if there is one)

For that, in Aquisition.pm, I made some changes to GetLateOrders :
- 3 new columns in SELECT
- 1 new join

To test :
1. Display the list of late orders of your instance.
2. Check you have 3 new columns for basketgroups, fund and branch
3. In basketgroup column you should have "name of basket group (number)"
4. In basket column you should have "name of basket (number)"
5. Check the links for basketgroups. They should send you to the page
displaying information for each basketgroup
(without possibiliy of editing them if they are closed)

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:37:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 17:37:11 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

--- Comment #13 from M. Tompsett  ---
Created attachment 24852
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24852&action=edit
[SIGNED OFF] Bug 11027 - Create a link only if user have required permissions

With this followup, a user without order_manage permission won't be able to
cick on a basket
and a user without group_manage permission won't be able to click on a
basketgroup

Note that the issue for basket is present in current master. So it deserves a
separate bugfix (as bug 11027 is an ENH)

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:39:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 17:39:00 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

--- Comment #14 from M. Tompsett  ---
REVISED TEST PLAN
-----------------
 0) Back up DB if you want to restore it later. Also, apply patch. :)
 1) Log into staff client as superlibrarian
 2) Click Acquisitions
 3) Click the Search button in the Manage orders section
 4) Click + New basket for any one of the vendors
 5) Type a Basket name and click Save
 6) Click a link in the Add order to basket
    -- I used suggestions, since we have 9.
    -- don't forget to click "Add Item"
       and choose a Fund before "Save"
 7) Click Change button beside Branch dropdown
     to set up the branch.
    -- I don't know why this seems necessary, but
       I couldn't get it to work otherwise.
 8) Click Close the basket
 9) Check Attach this basket to a new basket group with the same name
10) Click Yes, close (Y)
11) Click Late orders
    -- the order just made should be listed.
    -- both the Basket and Basket group columns should be links
12) Add a patron with the following permissions:
    - check staff access
    - check acquisition
    - then uncheck group_manage
    - then uncheck order_manage
    Make sure to match the branch to the superlibrarian's
    branch, because that is what the entered late order uses
    as its branch.
13) log out of the staff client
14) log into the staff client with the new user
    -- you'll get an
       "Error: You do not have permission to access
        this page"
15) paste and correct the url:
    http://YOUR_SITE/cgi-bin/koha/acqui/acqui-home.pl
16) Click Late orders
    -- the orders listed will not have links in Basket and
       Basket group columns.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 19:08:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 18:08:29 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #21 from Blou  ---
Results hard to reproduce, I'll wait on your further testing results.

If you get "unwanted results", like the "no category" you listed below, could
you examine the search string in the header, something like 

Results of search  with limit(s): 'mc-itype,phr:CDR or mc-itype,phr:VG or
mc-itype,phr:VT' 

That is what is generated when HARDWARE is exploded in my latest test with URL:
cgi-bin/koha/opac-search.pl?idx=kw&q=&idx=kw&q=&idx=kw&q=&do=Search&searchcat=HARDWARE&limit-yr=&limit=&limit=&sort_by=relevance

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 19:53:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 18:53:08 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #30 from M. Tompsett  ---
Comment on attachment 24846
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24846
Bug 8753 - Add forgot password link to OPAC

Review of attachment 24846:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8753&attachment=24846)
-----------------------------------------------------------------

::: C4/Auth.pm
@@ +1068,4 @@
>          PatronSelfRegistrationDefaultCategory => C4::Context->preference("PatronSelfRegistrationDefaultCategory"),
>          persona            => C4::Context->preference("Persona"),
>          opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'},
> +        OpacResetPassword => C4::Context->preference("OpacResetPassword"),

You added OpacResetPassword, and all the templates use the Koha system
preference grabbing plugin. There's no need for this.

@@ +1068,5 @@
>          PatronSelfRegistrationDefaultCategory => C4::Context->preference("PatronSelfRegistrationDefaultCategory"),
>          persona            => C4::Context->preference("Persona"),
>          opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'},
> +        OpacResetPassword => C4::Context->preference("OpacResetPassword"),
> +        OpacPasswordChange => C4::Context->preference("OpacPasswordChange"),

This wasn't here, so I don't see a reason to add it, since all the template
changes you made use the Koha system preference grabbing plugin.

::: opac/opac-main.pl
@@ +58,4 @@
>      koha_news_count     => $koha_news_count,
>      display_daily_quote => C4::Context->preference('QuoteOfTheDay'),
>      daily_quote         => $quote,
> +    OpacResetPassword   => C4::Context->preference('OpacResetPassword'),

There's no point to have this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 20:14:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 19:14:14 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #31 from Blou  ---
Created attachment 24853
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24853&action=edit
Removed unnecessary references in template calls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 20:57:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 19:57:18 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #32 from M. Tompsett  ---
Comment on attachment 24846
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24846
Bug 8753 - Add forgot password link to OPAC

Review of attachment 24846:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8753&attachment=24846)
-----------------------------------------------------------------

::: C4/Members.pm
@@ +2266,5 @@
> +
> +sub SendPasswordRecoveryEmail {
> +    my $borrowernumber = shift;
> +    my $email = shift;
> +    my $query = shift;

Perhaps with the code later you were trying to handle:
    my $query = shift // CGI->new();

@@ +2285,5 @@
> +    #define to/from emails
> +    my $kohaEmail = C4::Context->preference( 'KohaAdminEmailAddress' );
> +
> +    #create link
> +    my $https = $query->https() ? "https://" : "http://";

I believe I have seen others call this protocol, but changing this isn't
necessary.

@@ +2290,5 @@
> +    my $uuidLink = $https . C4::Context->preference( 'OPACBaseURL' ) . "/cgi-bin/koha/opac-password-recovery.pl?uniqueKey=$uuid_str";
> +    #warn $uuidLink;
> +
> +    #build email content
> +    my $query = new CGI;

Why do you need this?! You have line 2270.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 21:24:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 20:24:09 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #33 from Blou  ---
Created attachment 24854
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24854&action=edit
Removed unnecessary argument in call to SendPasswordRecoveryEmail.  Improved
var naming

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 22:13:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 21:13:10 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24846|0                           |1
        is obsolete|                            |
  Attachment #24853|0                           |1
        is obsolete|                            |
  Attachment #24854|0                           |1
        is obsolete|                            |

--- Comment #34 from Blou  ---
Created attachment 24855
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24855&action=edit
Bug 8753 - Add forgot password link to OPAC

This includes fix following the most recent comments and a rebasing to 3.15.15
Fixes all comments specified by mtompsett.

TEST PLAN:

1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 
That will cause the link 'Forgot your password' to show up on the welcome page,
below connection box.
3) refresh front page, click on 'Forgot your password' and enter a VALID
address (one that is associated to an entry in borrowers.email or
borrowers.email_pro.
3b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
4) An email should be received at that address with a link.
5) Follow the link in the mail to fill the new password.
   Until a satisfactory new password is entered, the old password is not reset.
6) Go to main page try the new password.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 22:33:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2014 21:33:44 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #35 from M. Tompsett  ---
Comment on attachment 24855
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24855
Bug 8753 - Add forgot password link to OPAC

Review of attachment 24855:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8753&attachment=24855)
-----------------------------------------------------------------

::: C4/Auth.pm
@@ +1068,5 @@
>          PatronSelfRegistrationDefaultCategory => C4::Context->preference("PatronSelfRegistrationDefaultCategory"),
>          persona            => C4::Context->preference("Persona"),
>          opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'},
> +        OpacResetPassword => C4::Context->preference("OpacResetPassword"),
> +        OpacPasswordChange => C4::Context->preference("OpacPasswordChange"),

They're back. :(

::: opac/opac-main.pl
@@ +58,4 @@
>      koha_news_count     => $koha_news_count,
>      display_daily_quote => C4::Context->preference('QuoteOfTheDay'),
>      daily_quote         => $quote,
> +    OpacResetPassword   => C4::Context->preference('OpacResetPassword'),

Oops.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 02:46:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 01:46:04 +0000
Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

Jesse Weaver  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 02:46:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 01:46:10 +0000
Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #1 from Jesse Weaver  ---
Created attachment 24856
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24856&action=edit
Bug 11211 - Move calculation code out of C4::Calendar

This patch moves the calculation code out of C4::Calendar, replacing any
references to it with Koha::Calendar. Additionally, it moves the
administration interface to a single script, tools/calendar.pl.

NOTE: This is intended as a bridge to bug 8133, so the UI is a bit
awkward, and C4::Calendar has an API designed for adding hours to the
calendar. All features should still work, and 8133 will make things
better.

Test plan:
  1) Install the new dependency, Template::Plugin::JavaScript.
  2) prove t/db_dependent/Calendar.t t/db_dependent/Holidays.t to verify
     that the new C4::Calendar API works correctly.
  3) prove t/Calendar.t
  4) Add, remove and modify events of each type using the administrative
     interface. In this version, changing a repeating event to "Open"
     deletes it.
  5) Check out items to verify that the calculation code is using the
     events you just created.
  6) If possible, verify that the two affected cronjobs still function
     correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 02:47:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 01:47:17 +0000
Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

Jesse Weaver  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #2 from Jesse Weaver  ---
CC'ing Liz, as she was on the original bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:40:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 07:40:47 +0000
Subject: [Koha-bugs] [Bug 11630] New: AgeRestrictionMarker doesn't handle
 marker immediately followed by age
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630

            Bug ID: 11630
           Summary: AgeRestrictionMarker doesn't handle marker immediately
                    followed by age
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 24857
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24857&action=edit
Make AgeRestrictionMarker consider "K16"

In Finland the age restrictions are marked with letter K followed immediately
by the age, eg. "K16". The AgeRestrictionMarker setting expects the marker and
the age to be separated by space, eg. "PEGI 16"

Attached patch improves the setting so it also considers the case where the
marker is immediately followed by the age.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:49:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 10:49:38 +0000
Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers -
 Provide a download file of errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |h.meissner.82 at web.de

--- Comment #14 from Holger Mei?ner  ---
Created attachment 24858
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24858&action=edit
Screenshot of downloaded report

The download button appears and a text file can be downloaded. But it only
contains some kind of reference? See screenshot.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:26:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 11:26:26 +0000
Subject: [Koha-bugs] [Bug 11631] New: Make translation toolchain ignore
 useless translatable strings
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631

            Bug ID: 11631
           Summary: Make translation toolchain ignore useless translatable
                    strings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Created attachment 24859
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24859&action=edit
Make i18n toolchain ignore useless strings

There are several translatable strings which contain nothing but spaces and
placeholders - these are useless for translators.

Attached patch makes the translation toolchain ignore such strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:37:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 11:37:30 +0000
Subject: [Koha-bugs] [Bug 11632] New: Untranslatable string "Remove" in
	patron lists
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11632

            Bug ID: 11632
           Summary: Untranslatable string "Remove" in patron lists
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

In modules/patron_lists/list.tt there's text "Remove" which is not
translatable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:43:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 11:43:54 +0000
Subject: [Koha-bugs] [Bug 11443] Refactoring code sending basket from
	OPAC/intra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443

Eric B?gin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

--- Comment #1 from Eric B?gin  ---
I think that we could use the notifications in order to edit the content of the
email sent by the cart / lists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:47:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 11:47:16 +0000
Subject: [Koha-bugs] [Bug 11633] New: Cannot use the override function
 AllowFineOverride on the Staff client because this stops the pay function
 working on the SelfCheck (SC) machines
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633

            Bug ID: 11633
           Summary: Cannot use the override function AllowFineOverride on
                    the Staff client because this stops the pay function
                    working on the SelfCheck (SC) machines
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.field at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

You cannot use the override function (AllowFineOverride) on ?Fines outstanding?
on the Staff client because this stops the pay function working on the
SelfCheck (SC) machines.

The SIP2 devices share this system preference. 

Test Plan
=========
1) Set System Preference AllowFineOverride to "Allow".
2) On SIP2 device (e.g. 3M SelfCheck) try paying a fine. We see:-
Borrower XXXXXXXXX had existing fines of 50p (2 x 25p). Attempted to borrow
book YYYYYYYYYYYYY. Chose 'Pay Fines Later' and issue was allowed even with an
outstanding (payable) fine. Tried to pay fines SelfCheck Machine asked for
correct amount took money but then returned money stating it could not charge
account and to enquire at desk.

In the SIP2 response, character position 1 & 2 on the 64 response need to be
set to Y for the SIP2 device to properly handle the block. 

64YY        Y   00020110614 .................

In Koha these are only set in two scenarios
1) If the user has expired and 
2) if the user is debarred

Needs a change in the Members logic the status in the ILS::Patron is
setup on the basis of the return from GetMemberDetails it does not set
the noissues flag if staff can override (AllowFineOverride option). In
the staff client the noissuescharge is applied as part of the checkout
transaction in 'CanBookBeIssued'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:48:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 11:48:00 +0000
Subject: [Koha-bugs] [Bug 11633] Cannot use the override function
 AllowFineOverride on the Staff client because this stops the pay function
 working on the SelfCheck (SC) machines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633

Jonathan Field  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.field at ptfs-europe.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:21:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 12:21:55 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Eric B?gin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

--- Comment #12 from Eric B?gin  ---
The '?' character I write in my message (in .po file) or in the comment are not
encoded correctly and shows as ? even with that patch.

It's weird because this seems to be only with that character Other characters
(? ? ? ?) are ok.

Anyone noticed that ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:29:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 12:29:05 +0000
Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351

Petter Goks?yr ?sen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boutrosboutrosboutros at gmail
                   |                            |.com

--- Comment #6 from Petter Goks?yr ?sen  ---
I'd like to test this, can you rebase?

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:29:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 12:29:33 +0000
Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

Petter Goks?yr ?sen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boutrosboutrosboutros at gmail
                   |                            |.com

--- Comment #13 from Petter Goks?yr ?sen  ---
I'd like to test this, can you rebase?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:36:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 12:36:44 +0000
Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines
 rather than account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

--- Comment #2 from Holger Mei?ner  ---
Created attachment 24860
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24860&action=edit
template updates to make the Pay Fines tab the default tab

http://bugs.koha-community.org/show_bug.cgi?id=11087
Signed-off-by: Holger Mei?ner 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:40:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 12:40:39 +0000
Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines
 rather than account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |h.meissner.82 at web.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:45:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 12:45:16 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:45:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 12:45:18 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24845|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 24861
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24861&action=edit
[SIGNED-OFF] Bug 11625 - Default to logged in library for circ rules and
notices & slips

This patch makes the default circ rules and notices/slips to edit
the logged in branch, if one is set.

Test Plan:
1) Apply this patch
2) Log into staff side, and set your library
3) Browse to Administration/Circulation and fines rules
4) Note the rule set selected is for your library
5) Select "All libraries"
6) Note the rule set selected is for "All libraries"
7) Browse to Toos/Notices & slips
8) Note the notice set selected is for your library
9) Select "All libraries"
10) Not the rule set selected is for "All libraries"
11) Click "New Notice"
12) Note the Library field is set to "All libraries"

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:39:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 14:39:33 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24855|0                           |1
        is obsolete|                            |

--- Comment #36 from Blou  ---
Created attachment 24862
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24862&action=edit
Bug 8753 - Add forgot password link to OPAC

This includes fix following the most recent comments and a rebasing to 3.15.15
Fixes all comments specified by mtompsett.

TEST PLAN:

1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 
That will cause the link 'Forgot your password' to show up on the welcome page,
below connection box.
3) refresh front page, click on 'Forgot your password' and enter a VALID
address (one that is associated to an entry in borrowers.email or
borrowers.email_pro.
3b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
4) An email should be received at that address with a link.
5) Follow the link in the mail to fill the new password.
   Until a satisfactory new password is entered, the old password is not reset.
6) Go to main page try the new password.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:46:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 14:46:39 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22731|0                           |1
        is obsolete|                            |

--- Comment #33 from M. de Rooy  ---
Created attachment 24863
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24863&action=edit
Bug 8918: Calculate hold priority in AddReserve

Priority was calculated outside of this sub, in separate places.
Priority was not calculated when using ILS-DI.

This patch factorize code by putting the priority calculation code into
AddReserve.

Test plan:
1/ Place multiple holds in staff interface and check the priority is
   incremented for each hold.
2/ Do the same in OPAC.
3/ Place multiple holds using ILS-DI HoldTitle service:
  
/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER
   and check the priority is incremented for each hold.
4/ Do the same using HoldItem service:
  
/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&item_id=ITEMNUMBER

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:46:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 14:46:48 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22732|0                           |1
        is obsolete|                            |

--- Comment #34 from M. de Rooy  ---
Created attachment 24864
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24864&action=edit
Bug 8918: Add a unit test for GetReserveNextRank

Rebased on January 29, 2014 (marcelr)
Added text on the two 'is'-statements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:47:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 14:47:25 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5 - low
            Version|3.14                        |master

--- Comment #35 from M. de Rooy  ---
Rebasing first..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:15:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:15:53 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

Benjamin Rokseth  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:22:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:22:53 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #36 from M. de Rooy  ---
benjamin.rokseth at kul.oslo.kommune.no changed status to Signed off?

Could you please clarify?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:30:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:30:37 +0000
Subject: [Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which
	require it
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |3.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:43:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:43:08 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:43:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:43:12 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24481|0                           |1
        is obsolete|                            |

--- Comment #16 from Owen Leonard  ---
Created attachment 24865
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24865&action=edit
[SIGNED-OFF] Bug 11513 - Warnings in Patron categories

Just going to the patron categories page triggered errors.
Running through all the plain options also triggered other
warnings. This fix silences them.

Discovered tabs I had not corrected by running qa test tool.

Some errors which I could not trigger were also fixed, such
as line 248 shown by Merllissia Manueli.

TEST PLAN
---------
 1) Log in to staff client
 2) Click 'Administration'
 3) Click 'Patron categories'
 4) Click '+ New category'
 5) Enter a dummy category and click 'Save'
 6) Click 'Edit' for the dummy category.
 7) Change a value and click 'Save'
 8) Click 'Delete' for the dummy category.
 9) Confirm to delete.
10) Review error log, several new warnings
11) Apply patch
12) Run the koha qa test tool.
13) Click 'Home'
14) Click 'Administration'
15) Click 'Patron categories'
16) Click '+ New category'
17) Enter a dummy category and click 'Save'
18) Click 'Edit' for the dummy category.
19) Change a value and click 'Save'
20) Click 'Delete' for the dummy category.
21) Confirm to delete.
22) Review error log, no new warnings

Signed-off-by: Owen Leonard 

Followed test plan, saw no errors in the log after applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:51:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:51:14 +0000
Subject: [Koha-bugs] [Bug 11634] New: Allow renewal of item with unfilled
 holds if other available items can fill that hold
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634

            Bug ID: 11634
           Summary: Allow renewal of item with unfilled holds if other
                    available items can fill that hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The current holds behavior in Koha allows a situation like this:
- Patron A has an item currently checked out.
- Patron B places a hold on the next available copy of that title.
- Then Patron A will not be able to renew his item, even if there are other
available copies of that title that could potentially fill Patron B's hold.

Since this seems unfair to Patron A, we should allow renewal of items even if
there are unfilled holds, but those holds could all be filled with currently
available items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:52:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:52:04 +0000
Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds
 if other available items can fill those holds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow renewal of item with  |Allow renewal of item with
                   |unfilled holds if other     |unfilled holds if other
                   |available items can fill    |available items can fill
                   |that hold                   |those holds

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:55:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:55:53 +0000
Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds
 if other available items can fill those holds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:55:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:55:55 +0000
Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds
 if other available items can fill those holds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634

--- Comment #1 from Kyle M Hall  ---
Created attachment 24866
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24866&action=edit
Bug 11634 - Allow renewal of item with unfilled holds if other available items
can fill those holds

The current holds behavior in Koha allows a situation like this:
- Patron A has an item currently checked out.
- Patron B places a hold on the next available copy of that title.
- Then Patron A will not be able to renew his item, even if there are
  other available copies of that title that could potentially fill Patron
  B's hold.

Since this seems unfair to Patron A, we should allow renewal of items
even if there are unfilled holds, but those holds could all be filled
with currently available items.

Test Plan:
1) Apply this patch
2) Create a record with two items
3) Check out the item to a patron
4) Place a hold on the record
5) Note you cannot renew the item for the patron
6) Enable the new system preference AllowRenewalIfOtherItemsAvailable
7) Note you can now renew the item, as all the holds can be satisfied
   by available items.
8) Place a second hold on the record
9) Note you can no longer renew the item, as all the holds *cannot*
   be filled by currently available items

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:57:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 15:57:42 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #37 from M. de Rooy  ---
(In reply to M. de Rooy from comment #36)
> benjamin.rokseth at kul.oslo.kommune.no changed status to Signed off?
> 
> Could you please clarify?

I appreciate your interest in this report, Benjamin. But I take the liberty to
reset the status to Needs Signoff in lack of evidence that these two patches
have been tested and are ready for QA.

Note that I was looking at them too and I will still continue with them. But
the changes proposed are certainly not trivial and concern an area
(Circulation/Holds) which is rather complex and not bug free. At this moment I
actually feel that this report is not yet ready for signoff, but this needs
some documentation too. To be continued..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:02:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 16:02:54 +0000
Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you
 want to write off ..."
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:02:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 16:02:57 +0000
Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you
 want to write off ..."
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24460|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard  ---
Created attachment 24867
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24867&action=edit
[SIGNED-OFF] Bug 11488 Untranslatable warning "Are you sure you want to write
off ..."

Test plan:
- ./translate update LANG
- translate the string into your po file
- ./translate install LANG
- Verify the string is translated.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:18:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 16:18:36 +0000
Subject: [Koha-bugs] [Bug 11394] "Routing lists" -tab vanishes from patron
	info bar
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11394

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:25:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 16:25:43 +0000
Subject: [Koha-bugs] [Bug 11635] New: 995$r defined twice in record.abs
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

            Bug ID: 11635
           Summary: 995$r defined twice in record.abs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

For UNIMARC flavor, in record.abs, 995$r defined twice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:27:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 16:27:49 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

--- Comment #6 from Owen Leonard  ---
Marjorie do your patron card numbers have leading zeroes? I suspect that's why
Liz can't reproduce the error but I can.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:32:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 16:32:05 +0000
Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 24868
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24868&action=edit
Bug 11635 - 995$r defined twice in record.abs

For UNIMARC flavor, in record.abs, 995$r defined twice.

Test plan :
- Create a fresh install UNIMARC flavor and GRS1 indexing for biblios
- Re-indexe database
- Perform a search with index "itemtype" (and then "itype") on an existing
value of 995$r. For example : itemtype:BOOK
=> Check you get results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:32:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 16:32:24 +0000
Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:07:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:07:39 +0000
Subject: [Koha-bugs] [Bug 11636] New: Impossible to remove patrons from
 patron list during add process
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636

            Bug ID: 11636
           Summary: Impossible to remove patrons from patron list during
                    add process
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P3
         Component: Course reserves
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

This problem affects libraries where patron card numbers include leading
zeroes, for example "0001234." To reproduce:

1. If necessary, create or modify a patron to have a card number 
   with leading zeroes.
2. Go to Tools -> Patron lists.
3. Click "Add patrons" on an existing list.
4. Perform a patron search and choose one of the results.
5. Click the "remove" link next to the patron name which was just added.
   Nothing will happen.

See also Bug 11534.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:08:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:08:49 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

--- Comment #7 from Marjorie Barry-Vila  ---
Created attachment 24869
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24869&action=edit
link remove instructor course reserve

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:10:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:10:18 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

--- Comment #8 from Marjorie Barry-Vila  ---
Hi Owen,

No there is no zeroes in patron card number.

See the capture for the link when i do a hover on "remove".
Liz, do you see the same?

Thanks,

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:18:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:18:08 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
 list during add process
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Course reserves             |Tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:31:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:31:38 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
 list during add process
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:31:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:31:42 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
 list during add process
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636

--- Comment #1 from Owen Leonard  ---
Created attachment 24870
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24870&action=edit
Bug 11636 - Impossible to remove patrons from patron list during add process

If you patrons have card numbers with leading zeroes this causes
problems removing patron entries during the process of adding patrons to
an existing list. This patch refactors the relevant JavaScript to
correct the problem and to remove inline "onclick" from generated HTML.

This patch also includes a fix for Bug 11632 - Untranslatable string
"Remove" in patron lists.

To test:

1. If necessary, create or modify a patron to have a card number
   with leading zeroes.
2. Go to Tools -> Patron lists.
3. Click "Add patrons" on an existing list.
4. Perform a patron search and choose one of the results.
5. Click the "remove" link next to the patron name which was just added.
   Nothing will happen.
6. Apply the patch and test again. The "remove" link should now work.

To test the fix for Bug 11632, after applying the patch run "translate
update [language code]" and confirm that the "Remove" string is listed
in the updated po file for patron_lists/list.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:32:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:32:16 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
 list during add process
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11632

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:32:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:32:16 +0000
Subject: [Koha-bugs] [Bug 11632] Untranslatable string "Remove" in patron
	lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11632

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|                            |11636
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:36:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 17:36:33 +0000
Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english
	language fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145

michel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |WISHLIST

--- Comment #9 from michel  ---
Hi,

i solved the problem by upgrading to koha 3.14 and rerunning the translation
process with the command

  perl translate install fr-FR

i already used this fix to solve problems when upgrading -- but i'm not sure
which problems, maybe the "search by keyword" not working anymore.

Maybe reruning the translation(s) automatically when updating could be put in
the wish list ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:41:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 19:41:41 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

--- Comment #9 from Owen Leonard  ---
Created attachment 24871
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24871&action=edit
Bug 11534 - impossible to remove instructors on course reserve

In some cases clicking the "remove" link to remove a course instructor
when editing a course reserves course doesn't work. I suspect this is
caused by leading zeroes in the card number. This patch refactors the
relevant function to fix the problem and to remove inline JavaScript
from generated markup.

Other changes:

- Make the "Remove" text translatable
- Re-order the first name and last name when added by JavaScript to
match the template's "surname, firstname" order.

To test:

1. If necessary, create or modify a patron to have a card number
   with leading zeroes.
2. Go to Course reserves and add or edit a course.
3. If you are editing a course and there are existing instructors, click
   the "remove" link. Nothing will happen.
4. Perform a patron search and choose one of the results. The name
   should be added to the list of instructors in the format "surname,
   firstname."
5. Click the "remove" link next to the patron name which was just added.
   Nothing will happen.
6. Apply the patch and repeat step 4. The "remove" link should work.
7. Add an instructor and save the course reserve. Repeat steps 2 and 3.
   The "remove" link should now work.

To test the translation fix, after applying the patch run "translate
update [language code]" and confirm that the "Remove" string is listed
in the updated po file for course_reserves/course.tt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:41:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 19:41:38 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:48:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 19:48:48 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11595

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:48:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 19:48:48 +0000
Subject: [Koha-bugs] [Bug 11595] Untranslatable error messages in rotating
	collections
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11595

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8836
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:51:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 19:51:51 +0000
Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in
	serials-collection
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:55:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 19:55:05 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

--- Comment #10 from Marjorie Barry-Vila  ---
Owen,

I understood why i did not be able to remove my instructors.

There is no number in the cardnumber I used, there is only letters...
I tested it with a cardnumber with numbers (without leading zero) and it works!

So, a cardnumber can contain letters? 

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 21:11:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 20:11:30 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

--- Comment #11 from Owen Leonard  ---
(In reply to Marjorie Barry-Vila from comment #10)
> There is no number in the cardnumber I used, there is only letters...

That's good to know. My patch should fix the problem for both of us.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 21:28:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 20:28:54 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Liz Rea  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24633|0                           |1
        is obsolete|                            |

--- Comment #21 from Liz Rea  ---
Comment on attachment 24633
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24633
Bug 10944 - opac-user and opac-readingrecord had instances of non-https amazon
images

I think the amazonTLD preference isn't working properly, so I'll submit a new
patch without that additional change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 21:33:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 20:33:02 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #38 from Benjamin Rokseth  ---
No worries Marcel! Rookie in patch signoffs, and strugglig behind company
firewalls, so wasn't able to signoff via git-bz. Also noting that you're still
working on this, so will keep hands off this one for now. Enough of others
waiting signoff... 

Glad you're working on the public APIs, by the way, would love to see some work
on a JSON API for Holds, Reservations, etc. in the line of :

https://github.com/biblibre/koha-restful
&
https://github.com/clrh/koha-restful

All the best!
Benjamin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 21:39:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 20:39:42 +0000
Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text
 "Select titles to: " in bootstrap
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 21:39:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 20:39:52 +0000
Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text
 "Select titles to: " in bootstrap
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24194|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 24872
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24872&action=edit
[SIGNED-OFF] Bug 11495: Make "Select titles to: " translatable

Fixes translation of "Select titles to: " on the Bootstrap
OPAC result page.

Test plan:
- Update one of the po files running:
  perl translate update 
- Verify that "Select titles to: " is only listed once for
  search-results.tt
Apply patch
- Verify addings titles to lists and cart from the result list
  still works as expected
- Rerun the po file update
- Verify the string is now listed twice for search-results.tt

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 21:50:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 20:50:12 +0000
Subject: [Koha-bugs] [Bug 11637] New: No way to prevent a prediction date
 for the next issue in serials
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637

            Bug ID: 11637
           Summary: No way to prevent a prediction date for the next issue
                    in serials
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

This needs more testing, but I think we have lost a feature in serials: 

It used to be possible to create a frequency/prediction pattern where no date
was created for the next issue. Instead it would show XXX in some places. That
was for serials where you had no idea about when the next isssue would arrive.
It doesn't seem to be possible now in serials to do that. When testing an
irregular pattern, for all issues today's date is shown and there is also
always a date set for the next predicted issue.

Maybe I am missing something - please comment :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:05:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 21:05:38 +0000
Subject: [Koha-bugs] [Bug 11637] No way to prevent a prediction date for the
 next issue in serials
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11576

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:05:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 21:05:38 +0000
Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in
	serials-collection
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11637

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:07:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 21:07:09 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #37 from M. Tompsett  ---
You forget to delete the password reset entry after resetting the password.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:08:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 21:08:19 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24731|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:08:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 21:08:57 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24490|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:12:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 21:12:40 +0000
Subject: [Koha-bugs] [Bug 11637] No way to prevent a prediction date for the
 next issue in serials
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637

--- Comment #1 from Francois Charbonnier  ---
I confirm. Now, irregular patterns show the first issue publication date for
each issue in the prediction pattern. 

Before, Koha used to display XXX instead, which was maybe more handy since one
cant predict the issue dates with irregular patterns...

See attachment "irregular_pattern.png" for an example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:13:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 21:13:15 +0000
Subject: [Koha-bugs] [Bug 11637] No way to prevent a prediction date for the
 next issue in serials
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637

Francois Charbonnier  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |francharb at gmail.com

--- Comment #2 from Francois Charbonnier  ---
Created attachment 24873
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24873&action=edit
Irregular pattern example

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:15:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 21:15:14 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24490|0                           |1
        is obsolete|                            |

--- Comment #65 from Tom?s Cohen Arazi  ---
Created attachment 24874
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24874&action=edit
Bug 11096: (follow-up) add direct regression tests

This adds direct tests of indexing and retrieving
bib records that are larger than the ISO2709 limit
of 99,999 octets.

To test: verify that prove -v t/db_dependent/Search.t passes.

Signed-off-by: Galen Charlton 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Chris Cormack 
Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:35:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 22:35:41 +0000
Subject: [Koha-bugs] [Bug 11579] The ordernumber is not displayed on the
	basket page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton  ---
Pushed to master.  Thanks, Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:36:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 22:36:33 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #38 from M. Tompsett  ---
Please test with
/cgi-bin/koha/opac-password-recovery.pl?uniqueKey=OneThatDoesNotExist

404.pl is not the correct behaviour, in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 00:30:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2014 23:30:08 +0000
Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as
 Amazon, Google and add fail over i.e. if first source fails, go to next
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

David Cook  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:10:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 04:10:14 +0000
Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag
	visibility
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:10:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 04:10:18 +0000
Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag
	visibility
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24663|0                           |1
        is obsolete|                            |
  Attachment #24664|0                           |1
        is obsolete|                            |

--- Comment #20 from Robin Sheat  ---
Created attachment 24875
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24875&action=edit
Bug 11592 - Updated License Text and use Modern::Perl

Why not clean up the License Agreement stuff while the files
are being changed? Used the current one found at:
http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

Changed the strict and warning lines into just a Modern::Perl.

Signed-off-by: Robin Sheat 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:10:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 04:10:35 +0000
Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag
	visibility
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #21 from Robin Sheat  ---
Created attachment 24876
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24876&action=edit
Bug 11592 - opac scripts do not respect marc tag visibility

Added two functions to C4/Biblio: GetFilteredOpacBiblio
and GetOpacHideMARC.

GetFilteredOpacBiblio returns a MARC::Record stripped of all the
fields and subfields which are supposed to be hidden in OPAC.

GetOpacHideMARC returns a hash of whether a particular key
(eg. title, subtitle, etc.)  is hidden. A value of 0 means no,
a value of 1 means hidden.

Made GetCOinSBiblio function handle hiding of 245$a more
gracefully. Also, modified GetMarcSubjects to not generate an
array entry of empty values.

Tweaked C4/XSLT.pm to delete a field, if there weren't any
subfields to actually update with.

Properly hid 245$a, in the case that there is no visibility
for OPAC, for opac-MARCdetail.

opac-detail now filters the MARC::Record according to the hidden
value in marc_subfield_structure properly. It also corrects a
couple minor issues with a parameter not passed being used in a
concatenation. How the subtitle values calculation works changed.
It is now based on marc_subfield_structure and not fieldmapping.
And, the GetBiblioData hash that generates template variables is
now filtered by the results of a GetOpacHideMARC call.

The opac-showmarc page now converts the MARCXML record to a
MARC::Record to easily filter using GetFilteredOpacBiblio, which
is then turned back into MARCXML for processing.

The opac-export script now filters the biblio record to match
what is currently displayed.

Added tests to t/db_dependent/Biblio.t to test the functionality
of the two functions added into C4::Biblio.

Added a GetFilteredOpacBiblio call into opac-ISBDdetail page, so
that it should be filtered.

TEST PLAN
---------
 1) Backup DB
 2) Go to any OPAC detail page and note the biblio number.
 3) Log into the staff client and determine the framework code for
     that biblio number.
 4) The steps should be done with OPACXSLTDetailsDisplay
     set to blank.
 5) Home -> Koha administration -> MARC bibliographic framework
         -> MARC structure (for the matching framework)
 6) On the OPAC detail page, click MARC view
 7) In the staff client, for every tag listed in the OPAC
     -> Subfields -> click the first link
     Then running through all the tabs, click Advanced constraints
      and uncheck OPAC visibility. Then click Save Changes
 8) Refresh the opac-MARCdetail page in OPAC
    -- what you hid should be mostly hidden
       TITLE will still display, even if you hide 245$a!
 9) Click Normal view, and all the hidden things are still
     mostly showing!
10) The steps should be done with OPACXSLTDetailsDisplay
    set to default (or some custom one?).
11) Refresh the opac-detail page. Still mostly showing all the
     hidden things.
12) Click MARC view, and everything should be hidden...
13) Until you click the 'view plain' link.
14) Apply the patch.
15) Run the Koha QA test tool.
16) Refresh the opac-MARCdetail page. Title should hide now.
17) Click the 'view plain' link.
    -- LDR and 999$c and 999$d were displaying for me.
       I realized that I hadn't hidden 999, because the
       opac-MARCdetail page doesn't display it.
       LDR is the only known leak.
18) Click Normal view
19) Now all the opac-detail page should hide things just like
     the opac-MARCdetail page.
20) In the staff client, change the OPACXSLTDetailsDisplay to
     a blank value.
21) Recheck opac-detail and opac-MARC detail pages again,
     including the view plain link, and everything should
     hidden similarly.
    -- NOTE: LDR is the only known leak.
NOTE: 952 fields are treated separately, so I don't believe they
      could be hidden in the table using the MARC visibility.
      The goal was hiding properly things above the items.
22) And lastly, attempt to Save record in the various formats
     using the dropdown and clicking Go.
    -- The results should be filtered.
23) Click on ISBD view to ensure nothing broke.
24) Restore DB, because hiding 000,003,005,008,020,040,245,etc.
    are not useful across an entire framework.

Signed-off-by: Robin Sheat 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:11:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 04:11:34 +0000
Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag
	visibility
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #22 from Robin Sheat  ---
(sorry, attached them the wrong way around due to expecting git bz to work like
most git commands.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:35:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 04:35:10 +0000
Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett  ---
Eyeballing it, I can see it is duplicated.

Branched based on origin/master
Fully reindexed
OPAC searched for itemtype:dpn and itype:dpn -- 631 results

Applied patch
Fully reindexed
OPAC searched for itemtype:dpn and itype:dpn -- 631 results

cp ~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs
~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs.bak
cp ./etc/zebradb/marc_defs/unimarc/biblios/record.abs
~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs
Fully reindexed
OPAC searched for itemtype:dpn and itype:dpn -- 631 results

git reset --hard origin/master
Fully reindexed
OPAC searched for itemtype:dpn and itype:dpn -- 631 results

my reindexing gave my lots of warnings, but it was about indexing tags not
found in attset(s). I figure I can ignore those.

I think my test covers it. I'm signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:37:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 04:37:44 +0000
Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24868|0                           |1
        is obsolete|                            |

--- Comment #3 from M. Tompsett  ---
Created attachment 24877
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24877&action=edit
[SIGNED OFF] Bug 11635 - 995$r defined twice in record.abs

For UNIMARC flavor, in record.abs, 995$r defined twice.

Test plan :
- Create a fresh install UNIMARC flavor and GRS1 indexing for biblios
- Re-indexe database
- Perform a search with index "itemtype" (and then "itype") on an existing
value of 995$r. For example : itemtype:BOOK
=> Check you get results

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:37:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 04:37:42 +0000
Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 06:26:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 05:26:18 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24871|0                           |1
        is obsolete|                            |

--- Comment #12 from Chris Cormack  ---
Created attachment 24878
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24878&action=edit
Bug 11534 - impossible to remove instructors on course reserve

In some cases clicking the "remove" link to remove a course instructor
when editing a course reserves course doesn't work. I suspect this is
caused by leading zeroes in the card number. This patch refactors the
relevant function to fix the problem and to remove inline JavaScript
from generated markup.

Other changes:

- Make the "Remove" text translatable
- Re-order the first name and last name when added by JavaScript to
match the template's "surname, firstname" order.

To test:

1. If necessary, create or modify a patron to have a card number
   with leading zeroes.
2. Go to Course reserves and add or edit a course.
3. If you are editing a course and there are existing instructors, click
   the "remove" link. Nothing will happen.
4. Perform a patron search and choose one of the results. The name
   should be added to the list of instructors in the format "surname,
   firstname."
5. Click the "remove" link next to the patron name which was just added.
   Nothing will happen.
6. Apply the patch and repeat step 4. The "remove" link should work.
7. Add an instructor and save the course reserve. Repeat steps 2 and 3.
   The "remove" link should now work.

To test the translation fix, after applying the patch run "translate
update [language code]" and confirm that the "Remove" string is listed
in the updated po file for course_reserves/course.tt.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 06:26:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 05:26:52 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:20:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 07:20:40 +0000
Subject: [Koha-bugs] [Bug 11638] New: Untranslatable "Tag editor" in
	addbiblio.pl
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638

            Bug ID: 11638
           Summary: Untranslatable "Tag editor" in addbiblio.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

addbiblio.pl has a hard-coded (and therefore untranslatable) "Tag editor" text.
It appears in two places in the code.

Also:
print "Content-Type: text/html\n\n
                  ERROR when DELETING BIBLIO
$biblionumber : $error
                  ";

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:32:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 10:32:53 +0000
Subject: [Koha-bugs] [Bug 11639] New: Untranslatable strings in 007 builder
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639

            Bug ID: 11639
           Summary: Untranslatable strings in 007 builder
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Untranslatable strings in marc21_field_007.tt:

"(if exact bit depth known, enter; 
                  otherwise use pulldown)"

and

"Exact bit depth 001-999"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:49:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 10:49:59 +0000
Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285

paxed  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at pttk.fi

--- Comment #3 from paxed  ---
"m- Mixed" in Marc21 007 builder.

It's used in two different meanings for electronic resources: 007/03 (color)
and 007/11 (antecedent/source). For color it means a mix of color and B&W, for
source it means the source is of mixed type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:06:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 11:06:35 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #39 from M. de Rooy  ---
Julian:
Would you mind if I split this report into two pieces? 

I would rather make a distinction between
1) The original bug in HoldTitle and HoldItem for ILS-DI
2) Making changes in AddReserves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:12:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 11:12:15 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #40 from Julian Maurice  ---
Marcel, do what you want with patches if you think it can help them to be in
master ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:23:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 11:23:29 +0000
Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

Deichman Digital Development  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22724|0                           |1
        is obsolete|                            |

--- Comment #18 from Deichman Digital Development  ---
Created attachment 24879
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24879&action=edit
Rebased against master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:45:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 11:45:49 +0000
Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

Benjamin Rokseth  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #19 from Benjamin Rokseth  ---
ilsdi.pl?service=CancelHold&patron_id=114&item_id=47

("47" was the reserve_id of a hold)

Got the following error :

Can't use string ("1974687") as a HASH ref while "strict refs" in use at
/usr/local/src/kohaclone/C4/Reserves.pm line 1724.

points to :
sub _FixPriority {
    my ( $params ) = @_;
    my $reserve_id = $params->{reserve_id};      <<<

1974687 was here the biblionumber, not the reserve_id.

The hold is correctly deleted, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:52:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 11:52:35 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17376|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:09:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:09:32 +0000
Subject: [Koha-bugs] [Bug 11278] Adjusting bulkmarcimport.pl for
 customization routine and verbose printing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11278

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:28:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:28:47 +0000
Subject: [Koha-bugs] [Bug 11640] New: Extending the use of the new routine
 CalculatePriority
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11640

            Bug ID: 11640
           Summary: Extending the use of the new routine CalculatePriority
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

This is a follow-up of report 8918 (work by Julian Maurice).
That report introduces the new routine but only uses it in ILS-DI.
This report is meant to extend its use in the Reserves module.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:29:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:29:03 +0000
Subject: [Koha-bugs] [Bug 11640] Extending the use of the new routine
	CalculatePriority
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11640

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8918

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:29:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:29:03 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11640

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:31:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:31:05 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24863|0                           |1
        is obsolete|                            |

--- Comment #41 from M. de Rooy  ---
Created attachment 24880
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24880&action=edit
Bug 8918: Fix reserve priority in ILS-DI

Priority was not calculated when using ILS-DI.
A new routine is added to Reserves.pm that calculates it.
A separate report will make the changes needed in Reserves in order to
use this new routine more generally.
This patch does therefore only affect ILS-DI.

Note: ILS-DI already allows you to generate multiple holds on a biblio or
item for the same patron. This patch does not change that behavior.

Test plan:
[1] Place multiple holds using ILS-DI HoldTitle service:
   
/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&request_location=test
    Check the priority.
[2] Do the same using HoldItem service:
   
/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&item_id=ITEMNUMBER
    Check the priority again.
[3] Use a biblio with multiple items. Place item level holds on both.
    Check in one of these items in another branch. Confirm transfer.
    Check in the other item in the original branch. Confirm hold.
    Now you have a waiting and a transit hold.
    Test HoldTitle and HoldItem service again a few times.
[4] Enable AllowHoldDateInFuture and add a future hold.
    Now test HoldTitle and HoldItem again and check if these holds are
    inserted before the future hold (lower priority).

January 29, 2014: Rebased this patch and amended it to make a distinction
between fixing the ILS-DI bug and using the new routine.
Updated commit message and test plan (marcelr).

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:31:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:31:48 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17376|0                           |1
        is obsolete|                            |

--- Comment #42 from M. de Rooy  ---
Created attachment 24881
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24881&action=edit
8918 QA Followup for pref descriptions

Updating pref descriptions for ReservesNeedReturns and ILS-DI:AuthorizedIPs.
Just sideway related to this report, but not important enough to separate.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:32:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:32:29 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24864|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:41:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:41:51 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #43 from M. de Rooy  ---
Created attachment 24882
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24882&action=edit
Bug 8918: Add a unit test for CalculatePriority

Rebased on January 29, 2014 (marcelr)
Added text on the two 'is'-statements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:42:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:42:59 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24882|0                           |1
        is obsolete|                            |

--- Comment #44 from M. de Rooy  ---
Created attachment 24883
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24883&action=edit
Bug 8918: Add a unit test for CalculatePriority

Rebased on January 29, 2014 (marcelr)
Added text on the two 'is'-statements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:46:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:46:41 +0000
Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639

--- Comment #1 from paxed  ---
And another one:

"(three digits, pad with zero as needed, 
                  or ||| for no attempt to code)"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:49:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:49:19 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24880|0                           |1
        is obsolete|                            |

--- Comment #45 from M. de Rooy  ---
Created attachment 24884
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24884&action=edit
Bug 8918: Fix reserve priority in ILS-DI

Priority was not calculated when using ILS-DI.
A new routine is added to Reserves.pm that calculates it.
A separate report will make the changes needed in Reserves in order to
use this new routine more generally.
This patch does therefore only affect ILS-DI.

Note: ILS-DI already allows you to generate multiple holds on a biblio or
item for the same patron. This patch does not change that behavior.

Test plan:
[1] Place multiple holds using ILS-DI HoldTitle service:
   
/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&request_location=test
    Check the priority.
[2] Do the same using HoldItem service:
   
/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&item_id=ITEMNUMBER
    Check the priority again.
[3] Use a biblio with multiple items. Place item level holds on both.
    Check in one of these items in another branch. Confirm transfer.
    Check in the other item in the original branch. Confirm hold.
    Now you have a waiting and a transit hold.
    Test HoldTitle and HoldItem service again a few times.
[4] Enable AllowHoldDateInFuture and add a future hold.
    Now test HoldTitle and HoldItem again and check if these holds are
    inserted before the future hold (lower priority).

January 29, 2014: Rebased this patch and amended it to make a distinction
between fixing the ILS-DI bug and using the new routine.
Updated commit message and test plan (marcelr).

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:52:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:52:27 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24881|0                           |1
        is obsolete|                            |

--- Comment #46 from M. de Rooy  ---
Created attachment 24885
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24885&action=edit
8918 QA Followup for pref descriptions

Updating pref descriptions for ReservesNeedReturns and ILS-DI:AuthorizedIPs.
Just sideway related to this report, but not important enough to separate.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:52:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 12:52:33 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24883|0                           |1
        is obsolete|                            |

--- Comment #47 from M. de Rooy  ---
Created attachment 24886
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24886&action=edit
Bug 8918: Add a unit test for CalculatePriority

Rebased on January 29, 2014 (marcelr)
Added text on the two 'is'-statements.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:02:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:02:39 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #48 from M. de Rooy  ---
Setting it back to Assigned for a short while since I stil want to add a few
additional tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:21:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:21:23 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #49 from M. de Rooy  ---
Created attachment 24887
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24887&action=edit
Bug 8918: Follow-up for some more unit tests for CalculatePriority

Adding a few unit tests, including the following situations:
Placing a hold when there is a wait.
Placing a hold when there is a future hold.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:22:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:22:17 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24887|0                           |1
        is obsolete|                            |

--- Comment #50 from M. de Rooy  ---
Created attachment 24888
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24888&action=edit
Bug 8918: Follow-up for some more unit tests for CalculatePriority

Adding a few unit tests, including the following situations:
Placing a hold when there is a wait.
Placing a hold when there is a future hold.
Calculating priority with future date.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:38:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:38:11 +0000
Subject: [Koha-bugs] [Bug 11638] Untranslatable "Tag editor" in addbiblio.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--- Comment #1 from Owen Leonard  ---
I find these instances of the phrase "tag editor" in .pl and .pm files:

Line 220 of authorities\authorities.pl
Line 252 of authorities\authorities.pl
Line 2833 of C4\Items.pm
Line 398 of cataloguing\addbiblio.pl
Line 427 of cataloguing\addbiblio.pl
Line 238 of cataloguing\additem.pl
Line 255 of cataloguing\additem.pl
Line 404 of tools\batchMod.pl
Line 418 of tools\batchMod.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:41:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:41:14 +0000
Subject: [Koha-bugs] [Bug 11641] New: ILS-DI: Some more work for HoldTitle
	and HoldItem
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11641

            Bug ID: 11641
           Summary: ILS-DI: Some more work for HoldTitle and HoldItem
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

This report is a follow-up on report 8918. 
This still needs some attention:

1) HoldTItle and HoldItem do not check for double reserve requests of a patron
where Koha does. 
2) The mandatory request_location parameter of HoldTitle does not seem to be
used. Same for needed_before_date and pickup_expiry_date.
3) Also: needed_before_date, pickup_expiry_date in HoldItem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:41:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:41:32 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11641

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:41:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:41:32 +0000
Subject: [Koha-bugs] [Bug 11641] ILS-DI: Some more work for HoldTitle and
	HoldItem
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11641

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8918

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:48:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:48:40 +0000
Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:55:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:55:43 +0000
Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515

Petter Goks?yr ?sen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boutrosboutrosboutros at gmail
                   |                            |.com

--- Comment #2 from Petter Goks?yr ?sen  ---
I don't experience this encoding issue, using queries with Norwegian characters
or French diactric marks. The query is always correctly displayed. It's also
displayed correctly after I apply the patch..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:55:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:55:57 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #51 from M. de Rooy  ---
Julian,
Do you agree with the amendments? Note that I also renamed GetReserveNextRank
to CalculatePriority. In the context of the Reserves module priority is used
more often than rank. Hopefully, this will create less confusion.
I also noted some points for adjustment in HoldTitle and HoldItem on report
11641.
Using the new routine in AddReserves is moved to report 11640. This makes
testing this report much easier and chances of getting it pushed much higher.

All by all, I will sign off on this report now. And give some attention to
11640 later. I leave 11641 for you :)
If you would still see something here that blocks this report, please feel free
to change the status again.

Hopefully this will give this report a push in the right direction now..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:56:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:56:08 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:56:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 13:56:17 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:06:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:06:58 +0000
Subject: [Koha-bugs] [Bug 11640] Extending the use of the new routine
	CalculatePriority
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11640

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:10:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:10:10 +0000
Subject: [Koha-bugs] [Bug 11640] Extending the use of the new routine
	CalculatePriority
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11640

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8918

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:10:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:10:10 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11640

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:13:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:13:13 +0000
Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515

--- Comment #3 from Fridolin SOMERS  ---
(In reply to Petter Goks?yr ?sen from comment #2)
> I don't experience this encoding issue, using queries with Norwegian
> characters or French diactric marks. The query is always correctly
> displayed. It's also displayed correctly after I apply the patch..
Odd.
When I test on master :
- simple search at OPAC with "centr?"
- I have 5 results
- I click on a result
- I click on "Back to results"
=> I get the page : "cgi-bin/koha/opac-search.pl?idx=&q=centr??", "centr??" in
search box and no results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:19:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:19:56 +0000
Subject: [Koha-bugs] [Bug 11640] Extending the use of the new routine
	CalculatePriority
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11640

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:26:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:26:45 +0000
Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515

--- Comment #4 from Petter Goks?yr ?sen  ---
> Odd.
> When I test on master :
> - simple search at OPAC with "centr?"
> - I have 5 results
> - I click on a result
> - I click on "Back to results"
> => I get the page : "cgi-bin/koha/opac-search.pl?idx=&q=centr??", "centr??" in  search box and no results.

Hm, I'm on master too. When I search for "?l", get 22 results, click on a
result, click "Back to results", I get the page:
=> http://localhost:9000/cgi-bin/koha/opac-search.pl?q=%C3%B8l
"?l" beeing url-encoded into %C3%B8l
Its displayed correctly in the browser:
=> Results of search for 'kw,wrdl: ?l'

I notice you have idx= in your url, why I dont have that?

I am very interested in any encoding-related bugs, because we also experience
them on a seemingly random basis.

It seems to me that it is not dealt with properly once and for all in Koha (ie.
force utf-8 everywhere), but instead patched here and there, with the result
that we sometimes get double-encoding issues. However, I do not know enough
about Perl or Koha yet, so I might be totally wrong

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:31:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:31:47 +0000
Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from M. de Rooy  ---
(In reply to Petter Goks?yr ?sen from comment #4)
> It seems to me that it is not dealt with properly once and for all in Koha
> (ie. force utf-8 everywhere), but instead patched here and there, with the
> result that we sometimes get double-encoding issues. However, I do not know
> enough about Perl or Koha yet, so I might be totally wrong

Well, this sounds (unfortunately) quite correct to me :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:32:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:32:48 +0000
Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273

--- Comment #7 from Deichman Digital Development  ---
Created attachment 24889
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24889&action=edit
Rebased against master 2014-01-30

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:50:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:50:57 +0000
Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273

--- Comment #8 from Deichman Digital Development  ---
Created attachment 24890
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24890&action=edit
Signed-off-by: Benjamin Rokseth 

Rebased against master 2014-01-30

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:51:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:51:34 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |h.meissner.82 at web.de

--- Comment #4 from Holger Mei?ner  ---
In the test plans, did you mean:
https://.../cgi-bin/koha/opac/svc/report?id=##

Not:
https://.../cgi-bin/koha/svc/report?id=##
?

Or should kohaclone/svc/report also add headers?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:53:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 14:53:13 +0000
Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:10:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:10:49 +0000
Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273

Benjamin Rokseth  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #9 from Benjamin Rokseth  ---
FYI, this was tested using SIP2 through telnet.

1. sent SIP2 Fee paid command after successful login:

>> 3720140130    0900010401NOKBV333.33|AOFilleinstitusjon|AA1003|BKbbs001|

got successful SIP2 response:

<< 38Y20140130    154751AOFilleinstitusjon|AA1003|BKbbs001|

2. checked patron info in koha admin. 
  Payment was added, with Payment, thanks msg.

3. Printed slip, where payment showed ok.

Benjamin Rokseth


(In reply to Deichman Digital Development from comment #8)
> Created attachment 24890 [details] [review]
> Signed-off-by: Benjamin Rokseth 
> 
> Rebased against master 2014-01-30

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:10:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:10:53 +0000
Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515

--- Comment #6 from Fridolin SOMERS  ---
(In reply to Petter Goks?yr ?sen from comment #4)
> I notice you have idx= in your url, why I dont have that?
I've tested with "?l". It works.
Can you test with one of ?,?,?,?,?,? ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:11:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:11:43 +0000
Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes
 more than warning states it will delete
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352

Joy Nelson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #3 from Joy Nelson  ---
To add insult to injury, this tool in some instances will completely delete the
patrons and not move them to deleted_borrowers table.  It just nukes the
borrowers completely.  (deleted permanently is the preselected option)

(In reply to Danielle Elder from comment #2)
> Yes, it is deleting ones it shouldn't and we couldn't get any of the numbers
> to show up: warning, count, or on the database. We even queried with the
> deletion parameters before deletion and could not get numbers to match up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:11:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:11:48 +0000
Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:11:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:11:53 +0000
Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515

--- Comment #7 from Fridolin SOMERS  ---
> I've tested with "?l". It works.
I mean this patch is not needed for "?l".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:18:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:18:31 +0000
Subject: [Koha-bugs] [Bug 11642] New: Batch patron deletion/anonymization
 should not allow permanent destruction of patron data
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642

            Bug ID: 11642
           Summary: Batch patron deletion/anonymization should not allow
                    permanent destruction of patron data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The Batch patron deletion/anonymization tool gives the option of destroying
patron data or moving it to the "trash". I see know reason why we allow
deletion of patrons without moving them to deletedborrowers first. We don't
allow this kind of behavior for records or items, so why patrons? Furthermore
it seems far to easy to mis-use this tool by accident, further exacerbating the
situation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:18:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:18:36 +0000
Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should
 not allow permanent destruction of patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:26:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:26:09 +0000
Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should
 not allow permanent destruction of patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:26:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:26:11 +0000
Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should
 not allow permanent destruction of patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642

--- Comment #1 from Kyle M Hall  ---
Created attachment 24891
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24891&action=edit
Bug 11642 - Batch patron deletion/anonymization should not allow permanent
destruction of patron data

The Batch patron deletion/anonymization tool gives the option of
destroying patron data or moving it to the "trash". I see know reason
why we allow deletion of patrons without moving them to deletedborrowers
first. We don't allow this kind of behavior for records or items, so why
patrons? Furthermore it seems far to easy to mis-use this tool by
accident, further exacerbating the situation.

Test Plan:
1) Apply this patch
2) Verify you can no longer permanently delete patrons
   with the batch patron deletion/anonymization tool,
   instead they will always be moved to deletedborrowers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:44:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:44:17 +0000
Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:44:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:44:20 +0000
Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588

--- Comment #1 from Owen Leonard  ---
Created attachment 24892
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24892&action=edit
Bug 11588 - Untranslatable subscription frequency units

The subscription add form has a couple of translation issues which are
addressed in this patch: First, the frequency option which pulls
descriptive strings from the subscription_frequencies table. Second, the
subscription length option which is based on hard-coded choices in
subscription-add.pl.

This patch makes these choices translatable by using a SWITCH in the
template based on the predefined strings which can be expected.

To test, apply the patch and update the translation of your choice by
running 'translate update [language code]'. Confirm that the frequency
and length strings are now present in the updated po file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:49:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:49:20 +0000
Subject: [Koha-bugs] [Bug 11588] Untranslatable subscription frequency units
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11588

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24892|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Comment on attachment 24892
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24892
Bug 11588 - Untranslatable subscription frequency units

Never mind, this method won't work with translated values in the database.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:53:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:53:13 +0000
Subject: [Koha-bugs] [Bug 11439] UT: XISBN.t returns failure
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11439

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |Pushed to Master

--- Comment #12 from Galen Charlton  ---
I have taken the liberty of pushing another follow-up to account for a change
in the list of ISBNs returned by OCLC's XISBN service.  Setting status back to
pushed to master; I recommend that RMaints pick up this follow-up ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:55:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 15:55:59 +0000
Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515

--- Comment #8 from Petter Goks?yr ?sen  ---
> Can you test with one of ?,?,?,?,?,? ?

I did also try with french characters,
It also works:
=> Results of search for 'kw,wrdl: andr?'
   http://localhost:9000/cgi-bin/koha/opac-search.pl?q=andr%C3%A9

Same with ?, ? & ?

Can it be that your OS/browser submits the querystring with a French encoding?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:07:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:07:36 +0000
Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:07:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:07:38 +0000
Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24705|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 24893
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24893&action=edit
[SIGNED-OFF] Bug 11272 - copy submit button on inventory

The inventory tool allows for 2 ways of processing files. The first
is to upload a file. The second is to generate the shelf list.
Most libraries think they have to fill in all fields because the
submit button is at the bottom of the second option. They do not.
This patch adds a second submit button under the first method to
make this clearer.

To test:

* Generate a file of barcodes for inventorying
* Before applying the patch use the file upload method to mark as seen
* Apply the patch
* Use the file upload method to mark as seen using the new submit
* Repeat the above for the shelf list method
* Confirm that inventory still works as expected with 2 buttons

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:12:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:12:27 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

Koha Team AMU  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #21 from Koha Team AMU  ---
I tested on a sandbox (langres) by comparing the results with sql reports.

It seems that the main part of the patch is ok but I still notice two problems
:

- test of sort by hours : if we choose the same date in "period", for example
"from 30/01/2014 To 30/01/2014", group by hour doesn't work. (nevertheless,
limits of end intervals are included for period )

- test of patron attributes : if we don't use filter and display all the
values, total is still wrong. I notice that the lign with the value "NULL" is
empty. Maybe only patron attributes with an authorised values list should be
added in this patch ?

PROFESSION / datetime     9     10     11     13     14     15     16     17   
 TOTAL
agent administratif     0     0     0     0     1     1     0     0     2
?colier         0     0     0     0     1     0     0     0     1
NULL                                     
TOTAL             0     0     0     0     2     1     0     0     58

For that reason, changing status to "In discussion".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:38:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:38:51 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24874|0                           |1
        is obsolete|                            |

--- Comment #66 from Tom?s Cohen Arazi  ---
Created attachment 24894
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24894&action=edit
[SIGNED OFF] Bug 11096: add direct regression tests

This adds direct tests of indexing and retrieving
bib records that are larger than the ISO2709 limit
of 99,999 octets.

To test: verify that prove -v t/db_dependent/Search.t passes.

Signed-off-by: Galen Charlton 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Chris Cormack 
Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:39:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:39:15 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24732|0                           |1
        is obsolete|                            |

--- Comment #67 from Tom?s Cohen Arazi  ---
Created attachment 24895
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24895&action=edit
[SIGNED OFF] Bug 11096: Wrap each test set configuration into a subtest

This makes it easier to read. Also fixes the test count, and is rebased
against 11499 which is needed to correctly test the patches for this bug
(i.e. indexing mode needs to be correctly set in koha-conf.xml)

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:41:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:41:50 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24492|0                           |1
        is obsolete|                            |
  Attachment #24602|0                           |1
        is obsolete|                            |
  Attachment #24607|0                           |1
        is obsolete|                            |

--- Comment #68 from Tom?s Cohen Arazi  ---
Created attachment 24896
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24896&action=edit
Bug 11096: Koha<->Zebra should use the XML syntax with DOM

This patch makes Koha <-> Zebra use MARCXML for the serialization when
using DOM, and USMARC for GRS-1.

* The following functions are modified to set the Zebra record syntax according
to the current sysprefs and configuration:

- C4::Context->Zconn
- C4::Context-_new_Zconn

* A new function 'new_record_from_zebra' is introduced, which checks the
context
we are in, and creates the MARC::Record object using the right constructor.

The following packages get touched to make use of the new function:
- C4::Search
- C4::AuthoritiesMarc

and the same happens to the UI scripts that make use of them (both in the OPAC
and
STAFF interfaces).

* Calls to the unsafe ZOOM::Record->render()[1] method are removed.
Due to this last change the code for building facets was rewritten. And for
performance on the facets creation I pushed higher version dependencies for
MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string).

* Calls to MARC::Record->new_from_xml and MARC::Record->new_from_usmarc are
wrapped with
eval for catching problems [2].

* As of bug 3087, UNIMARC uses the 'unimarc' record syntax. this case is
correctly handled.

* As of bug 7818 misc/migration_tools/rebuild_zebra.pl behaves like:

- bib_index_mode (defaults to 'grs1' if not specified)
- auth_index_mode (defaults to 'dom')

here we do exactly the same.

To test:
 - prove t/db_dependent/Search.t should pass.
 - Searching should remain functional.
 - Indexing and searching for a big record should work (that's what the unit
tests do).
 - Test an index scan search (on the staff interface):
    Search > More options > Check "Scan indexes".

Regards
To+

[1] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()
[2] a record that cannot be parsed by MARC::Record is simply skipped (bug
10684)

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:42:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:42:21 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:45:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:45:32 +0000
Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes
 more than warning states it will delete
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11642

--- Comment #4 from Kyle M Hall  ---
(In reply to Joy Nelson from comment #3)
> To add insult to injury, this tool in some instances will completely delete
> the patrons and not move them to deleted_borrowers table.  It just nukes the
> borrowers completely.  (deleted permanently is the preselected option)

Remedied by bug 11642

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:45:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:45:32 +0000
Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should
 not allow permanent destruction of patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11352

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:48:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:48:51 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:48:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:48:54 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24672|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 24897
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24897&action=edit
[SIGNED-OFF] Bug 11605: default entry is 20 for all tables using datatables

The default entry is 20 and can be apply to all tables.

Bug 11555 apply the menu entries to all tables, redefining it is
uesless and can be removed.

Test plan:
Test pages impacted by this patch and verify there is no regression on
the tables.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:50:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:50:05 +0000
Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of
 GetReservesFromBiblionumber
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #22 from Galen Charlton  ---
Pushed to master, along with a follow-up that improves the POD for
GetReservesFromBiblionumber.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:53:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:53:59 +0000
Subject: [Koha-bugs] [Bug 11643] New: DelBiblio does not cancel future holds,
 it just deletes them
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11643

            Bug ID: 11643
           Summary: DelBiblio does not cancel future holds, it just
                    deletes them
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

DelBiblio() currently does not retrieve future holds, and consequently does not
call CancelReserve().  The consequences of this are minor, as it just means
that old_reserves doesn't get a copy of deleted future holds (instead, the
future holds are deleted via the FK constraint), but this could be a problem in
the future if (say) CancelReserve() gets extended to initiate sending hold
cancellation notices.

An argument could be made that the default value of the all_dates parameter to
GetReservesFromBiblionumber should be true, not false.  If so, all_dates might
be better named 'show_only_current_holds' or the like.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:54:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 16:54:28 +0000
Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of
 GetReservesFromBiblionumber
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823

--- Comment #23 from Galen Charlton  ---
Note bug 11643.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:01:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 17:01:29 +0000
Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the
	library is open
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24598|0                           |1
        is obsolete|                            |

--- Comment #29 from Kyle M Hall  ---
Created attachment 24898
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24898&action=edit
Bug 8735 - Expire holds waiting only on days the library is open

Signed-off-by: Leila 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:01:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 17:01:34 +0000
Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the
	library is open
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24599|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall  ---
Created attachment 24899
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24899&action=edit
Bug 8735 - Expire holds waiting only on days the library is open - Followup -
Switch from C4::Calendar to Koha::Calendar

Test Plan:
 1) Set ExpireReservesMaxPickUpDelay
 2) Set ReservesMaxPickUpDelay to 1
 3) Place a hold, set it to waiting
 4) Using the MySQL console, modify the waiting date and set it to the
    day before yesterday.
 5) Set today as a holiday for the pickup branch in question.
 6) Run misc/cronjobs/holds/cancel_expired_holds.pl
 7) The hold should remain unchanged
 8) Remove today as a holiday
 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again
10) The hold should now be canceled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:08:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 17:08:44 +0000
Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not
 have LESS counterparts
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard  ---
Everything looks good except one file: This patch adds "jquery.css," which
seems to be a renamed version of jquery.rating.css. Was this an error from the
Less compile process?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:37:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 17:37:44 +0000
Subject: [Koha-bugs] [Bug 11644] New: Cannot update fund if total is equal
 to amount unallocated
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644

            Bug ID: 11644
           Summary: Cannot update fund if total is equal to amount
                    unallocated
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When attempting to update a fund, if the amount unalloccated for the fund is
equal to the total, you can be prevented from saving. This is due to imprecise
floating point number comparison in check_parent_total.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:37:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 17:37:53 +0000
Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to
 amount unallocated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:44:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 17:44:21 +0000
Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to
 amount unallocated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:44:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 17:44:23 +0000
Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to
 amount unallocated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644

--- Comment #1 from Kyle M Hall  ---
Created attachment 24900
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24900&action=edit
Bug 11644 - Cannot update fund if total is equal to amount unallocated

When attempting to update a fund, if the amount unalloccated for the
fund is equal to the total, you can be prevented from saving. This is
due to imprecise floating point number comparison in
check_parent_total.pl

Test Plan:
1) Create a fund where the amount unallocated is equal to the amount
   unallocated for the budget period
2) Edit the fund, attempt to change the name of the fund
3) Note you recieve an error and cannot save
4) Apply this patch
5) Repeat step 2
6) Note you can now update the fund

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:10:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 18:10:31 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24896|0                           |1
        is obsolete|                            |

--- Comment #69 from Tom?s Cohen Arazi  ---
Created attachment 24901
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24901&action=edit
Bug 11096: Koha<->Zebra should use the XML syntax with DOM

This patch makes Koha <-> Zebra use MARCXML for the serialization when
using DOM, and USMARC for GRS-1.

* The following functions are modified to set the Zebra record syntax according
to the current sysprefs and configuration:

- C4::Context->Zconn
- C4::Context-_new_Zconn

* A new function 'new_record_from_zebra' is introduced, which checks the
context
we are in, and creates the MARC::Record object using the right constructor.

The following packages get touched to make use of the new function:
- C4::Search
- C4::AuthoritiesMarc

and the same happens to the UI scripts that make use of them (both in the OPAC
and
STAFF interfaces).

* Calls to the unsafe ZOOM::Record->render()[1] method are removed.
Due to this last change the code for building facets was rewritten. And for
performance on the facets creation I pushed higher version dependencies for
MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string).

* Calls to MARC::Record->new_from_xml and MARC::Record->new_from_usmarc are
wrapped with
eval for catching problems [2].

* As of bug 3087, UNIMARC uses the 'unimarc' record syntax. this case is
correctly handled.

* As of bug 7818 misc/migration_tools/rebuild_zebra.pl behaves like:

- bib_index_mode (defaults to 'grs1' if not specified)
- auth_index_mode (defaults to 'dom')

here we do exactly the same.

To test:
 - prove t/db_dependent/Search.t should pass.
 - Searching should remain functional.
 - Indexing and searching for a big record should work (that's what the unit
tests do).
 - Test an index scan search (on the staff interface):
    Search > More options > Check "Scan indexes".
 - Enable 'itemBarcodeFallbackSearch' and try to circulate any word, it
shouldn't break.
 - Searching for a biblio in a new subscription shouldn't break.
 - Running bulkmarcimport.pl shouldn't break.
 - And so on... for the rest of the .pl files.

Regards
To+

[1] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()
[2] a record that cannot be parsed by MARC::Record is simply skipped (bug
10684)

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:25:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 18:25:18 +0000
Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273

--- Comment #10 from Chris Cormack  ---
Thanks for signing off Benjamin

A few things though

Please mark the bug signed off when you are done
Please obsolete the old patches

and

In the rebase the original commit message has been killed, can we get that
back? So amend the signed off patch, add back the original commit message,
attach it, and obsolete all the others. And finally switch to signed off.
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:49:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 18:49:25 +0000
Subject: [Koha-bugs] [Bug 11645] New: Cannot remove instructors from course
 whose card number begins with a 0
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11645

            Bug ID: 11645
           Summary: Cannot remove instructors from course whose card
                    number begins with a 0
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It appears that if an instructor's card number begins with a 0, that instructor
cannot be removed from a course.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:51:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 18:51:31 +0000
Subject: [Koha-bugs] [Bug 11645] Cannot remove instructors from course whose
 card number begins with a 0
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11645

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:51:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 18:51:33 +0000
Subject: [Koha-bugs] [Bug 11645] Cannot remove instructors from course whose
 card number begins with a 0
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11645

--- Comment #1 from Kyle M Hall  ---
Created attachment 24902
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24902&action=edit
Bug 11645 - Cannot remove instructors from course whose card number begins with
a 0

It appears that if an instructor's card number begins with a 0, that
instructor cannot be removed from a course.

Test Plan:
1) Create a patron with a card number "012345"
2) Add this patron to a course
3) Click the "remove" link for that instructor
4) Note that nothing happens
5) Apply this patch
6) Reload the page
7) Repeat stepts 2-3
8) Note you can now remove the instructor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:51:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 18:51:44 +0000
Subject: [Koha-bugs] [Bug 11645] Cannot remove instructors from course whose
 card number begins with a 0
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11645

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:51:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 18:51:49 +0000
Subject: [Koha-bugs] [Bug 11645] Cannot remove instructors from course whose
 card number begins with a 0
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11645

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:21:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:21:51 +0000
Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to
	left).
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23883|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard  ---
Created attachment 24903
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24903&action=edit
Bug 11411 - Bootstrap theme (enhancement) for (right to left)

This patch improves Koha's layout when a right-to-left language is being
displayed by correcting a float set by the right-to-left version of
Bootstrap CSS.

The patch modifies the right-to-left Less file and includes a
now-minified version of the compiled CSS.

To test, install a right-to-left language like ar-Arab. Apply the patch
and view the OPAC under the Bootstrap theme. When logged in, the
aligned to the left.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:21:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:21:48 +0000
Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to
	left).
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:43:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:43:10 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #39 from Blou  ---
(In reply to M. Tompsett from comment #37)
> You forget to delete the password reset entry after resetting the password.

You mean from table borrower_password_recovery ?  I validated it does delete
the entry.

And I can't reproduce the 404 of your next comment.  When I append your line to
my opac base url, it sends me to a message:

"
We could not authenticate you as the account owner.
Be sure to use the link you received in your email. 
"

Are you sure the patch was correctly applied?

Thanks again for your time!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:49:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:49:26 +0000
Subject: [Koha-bugs] [Bug 11645] Cannot remove instructors from course whose
 card number begins with a 0
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11645

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Kyle M Hall  ---


*** This bug has been marked as a duplicate of bug 11636 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:49:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:49:26 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
 list during add process
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #2 from Kyle M Hall  ---
*** Bug 11645 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:52:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:52:33 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:52:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:52:35 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24878|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall  ---
Created attachment 24904
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24904&action=edit
Bug 11534 - impossible to remove instructors on course reserve

In some cases clicking the "remove" link to remove a course instructor
when editing a course reserves course doesn't work. I suspect this is
caused by leading zeroes in the card number. This patch refactors the
relevant function to fix the problem and to remove inline JavaScript
from generated markup.

Other changes:

- Make the "Remove" text translatable
- Re-order the first name and last name when added by JavaScript to
match the template's "surname, firstname" order.

To test:

1. If necessary, create or modify a patron to have a card number
   with leading zeroes.
2. Go to Course reserves and add or edit a course.
3. If you are editing a course and there are existing instructors, click
   the "remove" link. Nothing will happen.
4. Perform a patron search and choose one of the results. The name
   should be added to the list of instructors in the format "surname,
   firstname."
5. Click the "remove" link next to the patron name which was just added.
   Nothing will happen.
6. Apply the patch and repeat step 4. The "remove" link should work.
7. Add an instructor and save the course reserve. Repeat steps 2 and 3.
   The "remove" link should now work.

To test the translation fix, after applying the patch run "translate
update [language code]" and confirm that the "Remove" string is listed
in the updated po file for course_reserves/course.tt.

Signed-off-by: Chris Cormack 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:56:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:56:51 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

--- Comment #5 from M. Tompsett  ---
The ... is the OPAC reference, so the svc maps accordingly based on the Apache
configuration.

There is no reason to do it for the staff client, since I don't expect people
to try to make public reports run from the staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:59:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:59:54 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
 list during add process
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:59:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 19:59:57 +0000
Subject: [Koha-bugs] [Bug 11636] Impossible to remove patrons from patron
 list during add process
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24870|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall  ---
Created attachment 24905
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24905&action=edit
Bug 11636 - Impossible to remove patrons from patron list during add process

If you patrons have card numbers with leading zeroes this causes
problems removing patron entries during the process of adding patrons to
an existing list. This patch refactors the relevant JavaScript to
correct the problem and to remove inline "onclick" from generated HTML.

This patch also includes a fix for Bug 11632 - Untranslatable string
"Remove" in patron lists.

To test:

1. If necessary, create or modify a patron to have a card number
   with leading zeroes.
2. Go to Tools -> Patron lists.
3. Click "Add patrons" on an existing list.
4. Perform a patron search and choose one of the results.
5. Click the "remove" link next to the patron name which was just added.
   Nothing will happen.
6. Apply the patch and test again. The "remove" link should now work.

To test the fix for Bug 11632, after applying the patch run "translate
update [language code]" and confirm that the "Remove" string is listed
in the updated po file for patron_lists/list.tt.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 21:13:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 20:13:01 +0000
Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not
 have LESS counterparts
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601

--- Comment #3 from Liz Rea  ---
hmm possibly, I'll have a check. 

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 21:53:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 20:53:56 +0000
Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not
 have LESS counterparts
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11411

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 21:53:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 20:53:56 +0000
Subject: [Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to
	left).
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11601
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:32:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 21:32:21 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #40 from Blou  ---
Created attachment 24906
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24906&action=edit
Improved UGLY code (sic).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:33:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 21:33:42 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Is there a reason that private reports should not have headers? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:41:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 21:41:32 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #41 from Blou  ---
Created attachment 24907
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24907&action=edit
hash vs hashref issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:43:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 21:43:21 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

--- Comment #7 from Katrin Fischer  ---
Hm, I just double checked - it's possible to run the report from the staff URL,
so you will only get access to the data when you are logged in. I can see use
cases for that when you want to make sensitive data available to another
service.
I think it would make sense to add the headers to both.

Example URL:
/cgi-bin/koha/svc/report?id=3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 23:09:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 22:09:18 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24862|0                           |1
        is obsolete|                            |
  Attachment #24906|0                           |1
        is obsolete|                            |
  Attachment #24907|0                           |1
        is obsolete|                            |

--- Comment #42 from Blou  ---
Created attachment 24908
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24908&action=edit
Bug 8753 - Add forgot password link to OPAC

This includes fix following the most recent comments and a rebasing to 3.15.15
Fixes all comments specified by mtompsett.

TEST PLAN:

1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 
That will cause the link 'Forgot your password' to show up on the welcome page,
below connection box.
2b) make sure that OpacPasswordChange is also ON.
3) refresh front page, click on 'Forgot your password' and enter a VALID
address (one that is associated to an entry in borrowers.email or
borrowers.email_pro.
3b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
4) An email should be received at that address with a link.
5) Follow the link in the mail to fill the new password.
   Until a satisfactory new password is entered, the old password is not reset.
6) Go to main page try the new password.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 23:27:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 22:27:13 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24001|0                           |1
        is obsolete|                            |

--- Comment #8 from M. Tompsett  ---
Created attachment 24909
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24909&action=edit
Bug 11491 - Missing header fields in JSON data

Added a header parameter, which when non-empty will add the
header fields of the query in question as the first element of
the JSON array.

Added header ability to staff svc/report as well.

Moved code around to make diffs between svc/report and
opac/svc/report smaller.

TEST PLAN
---------
1) Log into staff client
2) Reports
3) Used save reports
4) Click the Action button on any report
5) Click Edit
6) Make the report public
7) Update the SQL
8) Note the ID number of the report
9) In a new tab
     https://.../cgi-bin/koha/svc/report?id=##
10) The returned JSON should not have a header.
11) Go to
     https://.../cgi-bin/koha/svc/report?id=##&header=1
12) The returned JSON should have a header.
13) ~/qa-test-tools/koha-qa.pl -v 2 -c 2
    NOTE: There are two patches, but you could just test 1.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 23:27:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 22:27:20 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24002|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett  ---
Created attachment 24910
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24910&action=edit
Bug 11491 - Old License and strict, warnings

Replaced License text with latest one from
    http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
and tweaked copyright lines accordingly.

Also changed use strict and use warnings into use Modern::Perl
as per PERL2 from the coding guidelines.

TEST PLAN
---------
1) less ~/kohaclone/opac/svc/report
   - The license does not reflect the current license
   - This will have use strict and use warnings
2) Apply patch
   - The license should be corrected
3) It should still run
     https://.../cgi-bin/koha/svc/report?id=##
     https://.../cgi-bin/koha/svc/report?id=##&header=blah
   Where ## reflects a public report available (for OPAC).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 23:38:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2014 22:38:42 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #10 from Chris Cormack  ---
I think changing it to be

my $lines     = $sth->fetchall_arrayref({});

Which hands back an array of hashrefs is nicer, the JSON output of it is also a
lot nicer and a lot easier to deal with in Javascript.

Shall I do a counter patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:33:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 00:33:50 +0000
Subject: [Koha-bugs] [Bug 11305] Patrons with hundreds of checkouts cause
 extreme slowdown
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11305

jdemuth at roseville.ca.us  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:34:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 00:34:12 +0000
Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

jdemuth at roseville.ca.us  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:31:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 03:31:05 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24909|0                           |1
        is obsolete|                            |

--- Comment #11 from M. Tompsett  ---
Created attachment 24911
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24911&action=edit
Bug 11491 - Missing field names in JSON data

Added a parameter (annotated), which when non-empty will generate
an array of hashes that include the field names as keys, not
the typical array of field values, for the JSON output.

Added functionality to staff svc/report as well.

Moved code around to make diffs between svc/report and
opac/svc/report smaller.

TEST PLAN
---------
 1) Apply the patch
 2) ~/qa-test-tools/koha-qa.pl -v 2 -c 2
    NOTE: There are two patches, but you could just test 1.
 3) Log into staff client
 4) Reports
 5) Used save reports
 6) Click the Action button on any report
     WITHOUT PARAMETERS.
    -- with parameters blows up in master and this.
 7) Click Edit
 8) Make the report public
 9) Update the SQL
10) Note the ID number of the report
11) Note the ID number of a non-public report
12) In a new tab use the number from step 9.
     https://OPAC/cgi-bin/koha/svc/report?id=##
    -- matches default master report.
     https://OPAC/cgi-bin/koha/svc/report?id=##&annotated=1
    -- has hash where the keys are the field name.
     https://STAFF/cgi-bin/koha/svc/report?id=##
    -- matches default master report.
     https://STAFF/cgi-bin/koha/svc/report?id=##&annotated=1
    -- has hash where the keys are the field name.
13) In a new tab use the number from step 10.
     https://OPAC/cgi-bin/koha/svc/report?id=##
    -- matches the warning from master.
     https://OPAC/cgi-bin/koha/svc/report?id=##&annotated=1
    -- matches the warning from master.
     https://STAFF/cgi-bin/koha/svc/report?id=##
    -- matches default master report.
     https://STAFF/cgi-bin/koha/svc/report?id=##&annotated=1
    -- has hash where the keys are the field name.
14) In a new tab use a crazy number like 9675309 such that
    the report does not exist.
     https://OPAC/cgi-bin/koha/svc/report?id=##
    -- tells you the report doesn't exist vs.
       master giving a Software error.
     https://OPAC/cgi-bin/koha/svc/report?id=##&annotated=1
    -- tells you the report doesn't exist vs.
       master giving a Software error.
     https://STAFF/cgi-bin/koha/svc/report?id=##
    -- tells you the report doesn't exist vs.
       master giving a Software error.
     https://STAFF/cgi-bin/koha/svc/report?id=##&annotated=1
    -- tells you the report doesn't exist vs.
       master giving a Software error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:31:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 03:31:16 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24910|0                           |1
        is obsolete|                            |

--- Comment #12 from M. Tompsett  ---
Created attachment 24912
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24912&action=edit
Bug 11491 - Old License and strict, warnings

Replaced License text with latest one from
    http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
and tweaked copyright lines accordingly.

Also changed use strict and use warnings into use Modern::Perl
as per PERL2 from the coding guidelines.

TEST PLAN
---------
1) less ~/kohaclone/opac/svc/report
   - The license does not reflect the current license
   - This will have use strict and use warnings
2) Apply patch
   - The license should be corrected
3) It should still run
     https://.../cgi-bin/koha/svc/report?id=##
     https://.../cgi-bin/koha/svc/report?id=##&header=blah
   Where ## reflects a public report available (for OPAC).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:51:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 03:51:42 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24911|0                           |1
        is obsolete|                            |

--- Comment #13 from M. Tompsett  ---
Created attachment 24913
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24913&action=edit
Bug 11491 - Missing field names in JSON data

Added a parameter (annotated), which when non-empty will generate
an array of hashes that include the field names as keys, not
the typical array of field values, for the JSON output.

Added functionality to staff svc/report as well.

Moved code around to make diffs between svc/report and
opac/svc/report smaller.

TEST PLAN
---------
 1) Log into staff client
 2) Reports
 3) Used save reports
 4) Click the Action button on any report
     WITHOUT PARAMETERS.
    -- with parameters blows up in master and this.
 5) Click Edit
 6) Make the report public
 7) Update the SQL
 8) Note the ID number of the report
 9) Note the ID number of a non-public report
10) Make up a crazy ID number for a non-existant report
11) In a new tab (with the appropriate edits)
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: Sorry this report is not public
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: hash- or arrayref expected (not a simple scalar, use
allow_nonref to allow this) at /usr/share/perl5/JSON.pm line 154.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: hash- or arrayref expected (not a simple scalar, use
allow_nonref to allow this) at /usr/share/perl5/JSON.pm line 154.

12) Apply the patch
13) ~/qa-test-tools/koha-qa.pl -v 2 -c 2
    -- There should be no problems. All OK.

14) In a new tab (with the appropriate edits)
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: Sorry this report is not public
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: hash- or arrayref expected (not a simple scalar, use
allow_nonref to allow this) at /usr/share/perl5/JSON.pm line 154.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: hash- or arrayref expected (not a simple scalar, use
allow_nonref to allow this) at /usr/share/perl5/JSON.pm line 154.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:51:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 03:51:49 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24912|0                           |1
        is obsolete|                            |

--- Comment #14 from M. Tompsett  ---
Created attachment 24914
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24914&action=edit
Bug 11491 - Old License and strict, warnings

Replaced License text with latest one from
    http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
and tweaked copyright lines accordingly.

Also changed use strict and use warnings into use Modern::Perl
as per PERL2 from the coding guidelines.

TEST PLAN
---------
1) less ~/kohaclone/opac/svc/report
   - The license does not reflect the current license
   - This will have use strict and use warnings
2) Apply patch
   - The license should be corrected
3) It should still run
     https://.../cgi-bin/koha/svc/report?id=##
     https://.../cgi-bin/koha/svc/report?id=##&header=blah
   Where ## reflects a public report available (for OPAC).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:13:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 04:13:15 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24913|0                           |1
        is obsolete|                            |

--- Comment #15 from M. Tompsett  ---
Created attachment 24915
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24915&action=edit
Bug 11491 - Missing field names in JSON data

Added a parameter (annotated), which when non-empty will generate
an array of hashes that include the field names as keys, not
the typical array of field values, for the JSON output.

Added functionality to staff svc/report as well.

Moved code around to make diffs between svc/report and
opac/svc/report smaller.

TEST PLAN
---------
 1) Log into staff client
 2) Reports
 3) Used save reports
 4) Click the Action button on any report
     WITHOUT PARAMETERS.
    -- with parameters blows up in master and this.
 5) Click Edit
 6) Make the report public
 7) Update the SQL
 8) Note the ID number of the report
 9) Note the ID number of a non-public report
10) Make up a crazy ID number for a non-existant report
11) In a new tab (with the appropriate edits)
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: Sorry this report is not public
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: hash- or arrayref expected (not a simple scalar, use
allow_nonref to allow this) at /usr/share/perl5/JSON.pm line 154.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: hash- or arrayref expected (not a simple scalar, use
allow_nonref to allow this) at /usr/share/perl5/JSON.pm line 154.

12) Apply the patch
13) ~/qa-test-tools/koha-qa.pl -v 2 -c 2
    -- There should be no problems. All OK.

14) In a new tab (with the appropriate edits)
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of hashes with field names as keys
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: There is no such report.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: There is no such report.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of hashes with field names as keys
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- JSON data has arrays of hashes with field names as keys
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: There is no such report.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: There is no such report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:13:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 04:13:20 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24914|0                           |1
        is obsolete|                            |

--- Comment #16 from M. Tompsett  ---
Created attachment 24916
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24916&action=edit
Bug 11491 - Old License and strict, warnings

Replaced License text with latest one from
    http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
and tweaked copyright lines accordingly.

Also changed use strict and use warnings into use Modern::Perl
as per PERL2 from the coding guidelines.

TEST PLAN
---------
1) less ~/kohaclone/opac/svc/report
   - The license does not reflect the current license
   - This will have use strict and use warnings
2) Apply patch
   - The license should be corrected
3) It should still run
     https://.../cgi-bin/koha/svc/report?id=##
     https://.../cgi-bin/koha/svc/report?id=##&header=blah
   Where ## reflects a public report available (for OPAC).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:14:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 04:14:47 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:14:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 04:14:50 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24916|0                           |1
        is obsolete|                            |

--- Comment #17 from M. Tompsett  ---
Created attachment 24917
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24917&action=edit
Bug 11491 - Old License and strict, warnings

Replaced License text with latest one from
    http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
and tweaked copyright lines accordingly.

Also changed use strict and use warnings into use Modern::Perl
as per PERL2 from the coding guidelines.

TEST PLAN
---------
1) less ~/kohaclone/opac/svc/report
   - The license does not reflect the current license
   - This will have use strict and use warnings
2) Apply patch
   - The license should be corrected
3) It should still run
     https://.../cgi-bin/koha/svc/report?id=##
     https://.../cgi-bin/koha/svc/report?id=##&annotated=blah
   Where ## reflects a public report available (for OPAC).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:15:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 04:15:43 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

--- Comment #18 from M. Tompsett  ---
Test plans for each patch are in the patch. See comment 15 and comment 17.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:28:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 06:28:13 +0000
Subject: [Koha-bugs] [Bug 11646] New: Untranslatable confirm popup in field
 006 and 008 builders
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646

            Bug ID: 11646
           Summary: Untranslatable confirm popup in field 006 and 008
                    builders
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

marc21_field_006.tt and marc21_field_008.tt have the following confirmation
popup, which is not picked up for translation:

confirm('Show values for \'' +
form.material_type.options[form.material_type.selectedIndex].text + '\'
material type?'))

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:33:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 06:33:02 +0000
Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|gmcharlt at gmail.com          |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #4 from Katrin Fischer  ---
Hi Fridolin, please remember to assign the bug to yourself :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:39:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 06:39:05 +0000
Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:39:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 06:39:08 +0000
Subject: [Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24877|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer  ---
Created attachment 24918
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24918&action=edit
[PASSED QA] Bug 11635 - 995$r defined twice in record.abs

For UNIMARC flavor, in record.abs, 995$r defined twice.

Test plan :
- Create a fresh install UNIMARC flavor and GRS1 indexing for biblios
- Re-indexe database
- Perform a search with index "itemtype" (and then "itype") on an existing
value of 995$r. For example : itemtype:BOOK
=> Check you get results

Signed-off-by: Mark Tompsett 
Signed-off-by: Katrin Fischer 
Removes duplicated index definition.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:52:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 06:52:16 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hm, I noticed that now when you log in as superlibrarian, there is a difference
in behaviour. If you try to save a rule for "All libraries" without picking a
library first, it won't save.

Could it be this line here?
-my $branch = $input->param('branch') || ( C4::Branch::onlymine() ? (
C4::Branch
+my $branch = $input->param('branch') || C4::Branch::mybranch();

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:53:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 06:53:16 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #4 from Katrin Fischer  ---
I am not a fan of using the superlibrarian, but I think in this case it is a
little bug that could be fixed by keeping a fallback?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:03:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 07:03:08 +0000
Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines
 rather than account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Just some small things:
Ketan, please add the bug number, a problem description and a test plan to your
commit message for your next patch.

Holger, please obsolete the old patch, you can do it with git-bz using git-bz
attach -e and uncommenting the line for the attachments you want to obsolete.

Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:05:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 07:05:10 +0000
Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines
 rather than account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

--- Comment #4 from Katrin Fischer  ---
Created attachment 24919
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24919&action=edit
[PASSED QA] Bug 11087: Make the Pay Fines tab the default tab

Since paying fines is the most likely action when clicking on
the Fines tab, the pay fines tab should be the default rather
than the account summary.

http://bugs.koha-community.org/show_bug.cgi?id=11087
Signed-off-by: Holger Mei?ner 
Signed-off-by: Katrin Fischer 
Verified by accessing the fines pages from the various
patron account pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:05:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 07:05:44 +0000
Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines
 rather than account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24860|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:05:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 07:05:46 +0000
Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines
 rather than account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23060|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:06:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 07:06:00 +0000
Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines
 rather than account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:06:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 07:06:36 +0000
Subject: [Koha-bugs] [Bug 11087] Have the fines tab default to pay fines
 rather than account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

--- Comment #5 from Katrin Fischer  ---
Or in case of a character git-bz doesn't like (?), you can use git bz edit to
obsolete :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:56:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 07:56:27 +0000
Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639

--- Comment #2 from paxed  ---
And Yet Another One:

"(YYYYMM; use up to 6 - for unknown 
                  or | for no attempt to code)"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:58:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 07:58:56 +0000
Subject: [Koha-bugs] [Bug 11643] DelBiblio does not cancel future holds,
 it just deletes them
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11643

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 09:11:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 08:11:49 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #52 from M. de Rooy  ---
Still see something. Please wait :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:14:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:14:16 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:14:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:14:20 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24888|0                           |1
        is obsolete|                            |

--- Comment #53 from M. de Rooy  ---
Created attachment 24920
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24920&action=edit
Bug 8918: Follow-up for some more unit tests for CalculatePriority

Adding a few unit tests, including the following situations:
Placing a hold when there is a wait.
Placing a hold when there is a future hold.
Calculating priority with future date.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:15:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:15:28 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #54 from M. de Rooy  ---
Resolved a small date comparison problem in the unit test.
Julian: Could you still test this again one time and set status back to Signed
off? Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:24:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:24:27 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24672|1                           |0
        is obsolete|                            |
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from M. de Rooy  ---
Comment on attachment 24672
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24672
Bug 11605: default entry is 20 for all tables using datatables

Temporarily unobsoleting just for a short while. No worries :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:25:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:25:51 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24672|0                           |1
        is obsolete|                            |

--- Comment #4 from M. de Rooy  ---
Comment on attachment 24672
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24672
Bug 11605: default entry is 20 for all tables using datatables

No. Doesn't work either..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:26:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:26:24 +0000
Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #5 from M. de Rooy  ---
Applying: Bug 11605: default entry is 20 for all tables using datatables
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/js/datatables.js).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11605: default entry is 20 for all tables using
datatables

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:34:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:34:21 +0000
Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text
 "Select titles to: " in bootstrap
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:34:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:34:23 +0000
Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text
 "Select titles to: " in bootstrap
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

--- Comment #3 from M. de Rooy  ---
Created attachment 24921
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24921&action=edit
Bug 11495: Make "Select titles to: " translatable

Fixes translation of "Select titles to: " on the Bootstrap
OPAC result page.

Test plan:
- Update one of the po files running:
  perl translate update 
- Verify that "Select titles to: " is only listed once for
  search-results.tt
Apply patch
- Verify addings titles to lists and cart from the result list
  still works as expected
- Rerun the po file update
- Verify the string is now listed twice for search-results.tt

Signed-off-by: Owen Leonard 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:34:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:34:45 +0000
Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text
 "Select titles to: " in bootstrap
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
            Version|unspecified                 |master
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:35:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:35:08 +0000
Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text
 "Select titles to: " in bootstrap
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24872|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:58:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:58:38 +0000
Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you
 want to write off ..."
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:58:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:58:41 +0000
Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you
 want to write off ..."
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488

--- Comment #9 from M. de Rooy  ---
Created attachment 24922
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24922&action=edit
Bug 11488 Untranslatable warning "Are you sure you want to write off ..."

Test plan:
- ./translate update LANG
- translate the string into your po file
- ./translate install LANG
- Verify the string is translated.

Signed-off-by: Owen Leonard 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:58:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 09:58:54 +0000
Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you
 want to write off ..."
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:01:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:01:06 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24915|0                           |1
        is obsolete|                            |

--- Comment #19 from Holger Mei?ner  ---
Created attachment 24923
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24923&action=edit
Bug 11491 - Missing field names in JSON data

Added a parameter (annotated), which when non-empty will generate
an array of hashes that include the field names as keys, not
the typical array of field values, for the JSON output.

Added functionality to staff svc/report as well.

Moved code around to make diffs between svc/report and
opac/svc/report smaller.

TEST PLAN
---------
 1) Log into staff client
 2) Reports
 3) Used save reports
 4) Click the Action button on any report
     WITHOUT PARAMETERS.
    -- with parameters blows up in master and this.
 5) Click Edit
 6) Make the report public
 7) Update the SQL
 8) Note the ID number of the report
 9) Note the ID number of a non-public report
10) Make up a crazy ID number for a non-existant report
11) In a new tab (with the appropriate edits)
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: Sorry this report is not public
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: hash- or arrayref expected (not a simple scalar, use
allow_nonref to allow this) at /usr/share/perl5/JSON.pm line 154.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: hash- or arrayref expected (not a simple scalar, use
allow_nonref to allow this) at /usr/share/perl5/JSON.pm line 154.

12) Apply the patch
13) ~/qa-test-tools/koha-qa.pl -v 2 -c 2
    -- There should be no problems. All OK.

14) In a new tab (with the appropriate edits)
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of hashes with field names as keys
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- Software error: Sorry this report is not public
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: There is no such report.
     https://OPAC/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: There is no such report.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 8&annotated=1
    -- JSON data has arrays of hashes with field names as keys
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9
    -- JSON data has arrays of field values.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 9&annotated=1
    -- JSON data has arrays of hashes with field names as keys
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10
    -- Software error: There is no such report.
     https://STAFF/cgi-bin/koha/svc/report?id=# from step 10&annotated=1
    -- Software error: There is no such report.

Signed-off-by: Holger Mei?ner 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:01:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:01:10 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24917|0                           |1
        is obsolete|                            |

--- Comment #20 from Holger Mei?ner  ---
Created attachment 24924
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24924&action=edit
Bug 11491 - Old License and strict, warnings

Replaced License text with latest one from
    http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
and tweaked copyright lines accordingly.

Also changed use strict and use warnings into use Modern::Perl
as per PERL2 from the coding guidelines.

TEST PLAN
---------
1) less ~/kohaclone/opac/svc/report
   - The license does not reflect the current license
   - This will have use strict and use warnings
2) Apply patch
   - The license should be corrected
3) It should still run
     https://.../cgi-bin/koha/svc/report?id=##
     https://.../cgi-bin/koha/svc/report?id=##&annotated=blah
   Where ## reflects a public report available (for OPAC).

Signed-off-by: Holger Mei?ner 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:06:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:06:36 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:08:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:08:05 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

--- Comment #21 from Holger Mei?ner  ---
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:21:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:21:54 +0000
Subject: [Koha-bugs] [Bug 11268] Biblioitems URL field is too small for some
	URLs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11268

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24741|0                           |1
        is obsolete|                            |

--- Comment #3 from M. de Rooy  ---
Created attachment 24925
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24925&action=edit
Bug 11268 - Biblioitems URL field is too small for some URLs

The URL field in biblioitems is defined as a varchar(255) which is large
enough for most URLs but not all. This field should be converted to a
TEXT field to make sure it is capable of storing all valid URLs.

Test Plan:
1) Attempt to a URL that is greater than 255 chacters long in a record
   (856$u in MARC21)
2) Save the record, note the url gets truncated
3) Apply this patch
4) Repeat step 1
5) Note the entire url is saved

Signed-off-by: Jonathan Druart 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:21:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:21:51 +0000
Subject: [Koha-bugs] [Bug 11268] Biblioitems URL field is too small for some
	URLs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11268

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:22:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:22:08 +0000
Subject: [Koha-bugs] [Bug 11268] Biblioitems URL field is too small for some
	URLs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11268

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:30:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:30:58 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:32:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:32:51 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

--- Comment #17 from M. de Rooy  ---
Enrolment is BE,  Enrollment is AE 
But categorie sounds Dutch to me :)

Just referring to script and column names here..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:51:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:51:59 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

--- Comment #9 from Holger Mei?ner  ---
Created attachment 24926
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24926&action=edit
Bug 7413: Add issuingrules.norenewalbefore

Currently multiple renewals can be done in immediate succsession.
To optionally prevent this, a new parameter "No renewal before"
is introduced.

This patch adds issuingrules.norenewalbefore to the database.
Default value is NULL.

To test:
1) Run installer/data/mysql/updatedatabase.pl.
2) Create a SQL report like:
   SELECT * FROM issuingrules
3) Confirm that norenewalbefore was added after renewalperiod.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:52:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:52:03 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

--- Comment #10 from Holger Mei?ner  ---
Created attachment 24927
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24927&action=edit
Bug 7413: Add "No renewal before" to circulation and fine rules

This patch adds a column "No renewal before" to the circulation and
fine rules table.

To test:
1) Add or edit some issuing rules.
2) Confirm that an empty entry, zero and non-numerical values for
   "No renewal before" are converted into undefined.
3) Confirm that numerical values can be entered and saved.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:52:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:52:08 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

--- Comment #11 from Holger Mei?ner  ---
Created attachment 24928
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24928&action=edit
Bug 7413: Add new error "too_soon" in CanBookBeRenewed

This patch modifies CanBookBeRenewed in Ciculation.pm, so that based
on issuingrules.norenewalbefore a new error "too_soon" can be
returned.
For this error intranet HTML templates will display "Not renewable
yet" instead of "Not renewable".

To test:
1) Create an issuing rule with "No renewal before" set to value X
   and "Unit" set to days.
2) Confirm that items can't be renewed if current date is more than
   X days before due date.
3) Confirm that items can be renewed if "No renewal before" is
   undefined or current date is X or less days before due date.
4) Confirm that "Renewals allowed (count)" has priority, i.e. if
   the number of allowed renewals is exceeded "Not renewable" is
   displayed, no matter what "No renewal before" is set to.
5) Test the same things with "Unit" set to hours.
6) Test for both circulation.tt and moremember.tt.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:52:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:52:11 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

--- Comment #12 from Holger Mei?ner  ---
Created attachment 24929
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24929&action=edit
Bug 7413: Bootstrap theme changes

This patch makes opac-user.pl and the bootstrap version of opac-user.tt
handle the new renewal error "too_soon".

To test:
1) Set global syspref "opacthemes" to bootstrap.
2) Test the sames things as in previous patch, only for opac-user.tt.
3) Confirm that additionally to "Not renewable yet", the number of
   remaining renewals is displayed.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:52:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:52:15 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

--- Comment #13 from Holger Mei?ner  ---
Created attachment 24930
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24930&action=edit
Bug 7413: Prog theme change

This patch makes the prog version of opac-user.tt handle the
new renewal error "too_soon".

To test:
1) Set global syspref "opacthemes" to prog.
2) Test the same things as in previous patch.

Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:54:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:54:16 +0000
Subject: [Koha-bugs] [Bug 11440] Duplicate authorities when edit a
	bibliographic record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11440

Janusz Kaczmarek  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |januszop at gmail.com

--- Comment #1 from Janusz Kaczmarek  ---
Please, check the Linker options. If you already had duplicated authority and
the LinkerModule option is set to Default, there will be no match, so a new
authority will be created. If there is exactly one matching authority, it will
be found and linked. Is it not you case...?

You may also try with LinkerModule set to First Match or Last Match to verify
if this is the case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:54:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:54:31 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24688|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:54:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:54:33 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24689|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:54:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:54:37 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24686|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:54:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:54:35 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24685|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:54:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:54:39 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24687|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:55:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:55:42 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

--- Comment #14 from Holger Mei?ner  ---
Improved commit messages and fixed a few typos.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:57:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:57:47 +0000
Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

Holger Mei?ner  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Medium patch                |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:58:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 10:58:00 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

--- Comment #18 from M. de Rooy  ---
Created attachment 24931
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24931&action=edit
Bug 11513 - Warnings in Patron categories

Just going to the patron categories page triggered errors.
Running through all the plain options also triggered other
warnings. This fix silences them.

Discovered tabs I had not corrected by running qa test tool.

Some errors which I could not trigger were also fixed, such
as line 248 shown by Merllissia Manueli.

TEST PLAN
---------
 1) Log in to staff client
 2) Click 'Administration'
 3) Click 'Patron categories'
 4) Click '+ New category'
 5) Enter a dummy category and click 'Save'
 6) Click 'Edit' for the dummy category.
 7) Change a value and click 'Save'
 8) Click 'Delete' for the dummy category.
 9) Confirm to delete.
10) Review error log, several new warnings
11) Apply patch
12) Run the koha qa test tool.
13) Click 'Home'
14) Click 'Administration'
15) Click 'Patron categories'
16) Click '+ New category'
17) Enter a dummy category and click 'Save'
18) Click 'Edit' for the dummy category.
19) Change a value and click 'Save'
20) Click 'Delete' for the dummy category.
21) Confirm to delete.
22) Review error log, no new warnings

Signed-off-by: Owen Leonard 

Followed test plan, saw no errors in the log after applying the patch.

Signed-off-by: Marcel de Rooy 
Tested various dates and enrollment periods with different settings of
dateformat pref. Works as advertised. No warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:00:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:00:35 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

--- Comment #19 from M. de Rooy  ---
Even the split on an empty string is thoroughly tested :)
(I would have assumed that I got back the empty string, but perl keeps
surprising..)
Code looks good to me. Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:01:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:01:16 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:01:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:01:19 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24865|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:14:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:14:54 +0000
Subject: [Koha-bugs] [Bug 11647] New: Subscribe to email notification for
 serials needs user login
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647

            Bug ID: 11647
           Summary: Subscribe to email notification for serials needs user
                    login
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

It should be mandatory to be logged in on OPAC to subscribe to email
notification on new issues for a serial.

This patch does that.

To test : 
- find a serial with notification allowed
- display it on OPAC without being logged in
- click on Subscriptions > Mode details > Subscribe to email notification

Without patch, opac-alert-subscribe.pl is displaid and you can confirm your
subscription, but as you are not loggued in, nothing happens and you've got no
warning

With the patch, Koha asks you to login before asking confirmation for
subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:19:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:19:30 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:19:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:19:33 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24786|0                           |1
        is obsolete|                            |

--- Comment #5 from M. de Rooy  ---
Created attachment 24932
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24932&action=edit
Bug 11616: tablesorter is no longer in use

DataTables has replaced the tablesorter plugin to sort tables into Koha.
There is no table using this plugin and all references could be removed.

REVISED TEST PLAN
-----------------
1) Apply the patch
2) Home -> Koha administration -> Authorized values
3) Change the 'Show category:' drop down value, and play with
    the sorting of columns.
   -- should sort as expected.
4) Search the catalogue -> look for a biblio with high circulation
5) Click one of the name links.
6) Click the Items tab on the left.
7) Scroll down and click the (View item's checkout history)
    link in the History area.
   -- There was no sorting prior to the patch, so afterwards
      it should display the same.
8) git grep -i tablesorter
   -- Only a reference in staff-global.css and release texts.

Signed-off-by: Mark Tompsett 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:19:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:19:49 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:20:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:20:03 +0000
Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials
 needs user login
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P4
           Assignee|oleonard at myacpl.org         |sophie.meynieux at biblibre.co
                   |                            |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:24:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:24:47 +0000
Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials
 needs user login
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647

--- Comment #1 from Sophie MEYNIEUX  ---
Created attachment 24933
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24933&action=edit
Bug 11647 : Subscription for email notification on serials asks for login
before proceeding

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:25:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:25:05 +0000
Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials
 needs user login
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:44:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 11:44:33 +0000
Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272

--- Comment #3 from M. de Rooy  ---
Created attachment 24934
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24934&action=edit
Bug 11272 - copy submit button on inventory

The inventory tool allows for 2 ways of processing files. The first
is to upload a file. The second is to generate the shelf list.
Most libraries think they have to fill in all fields because the
submit button is at the bottom of the second option. They do not.
This patch adds a second submit button under the first method to
make this clearer.

To test:

* Generate a file of barcodes for inventorying
* Before applying the patch use the file upload method to mark as seen
* Apply the patch
* Use the file upload method to mark as seen using the new submit
* Repeat the above for the shelf list method
* Confirm that inventory still works as expected with 2 buttons

Signed-off-by: Owen Leonard 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:03:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 12:03:46 +0000
Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #4 from M. de Rooy  ---
Passing QA on this trivial patch adding a submit button on inventory, but I
feel that this form actually needs more attention as for design.
Just viewing this as a workaround.

The form design is not intuitive. The two approaches should be more visible, as
well as common options to both approaches like exporting to csv etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:04:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 12:04:09 +0000
Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24893|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:20:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 12:20:43 +0000
Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273

Deichman Digital Development  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22834|0                           |1
        is obsolete|                            |
  Attachment #24889|0                           |1
        is obsolete|                            |
  Attachment #24890|0                           |1
        is obsolete|                            |

--- Comment #11 from Deichman Digital Development  ---
Created attachment 24935
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24935&action=edit
Signed-off-by: Benjamin Rokseth 

Adds support for recording in Koha accountlines a different accounttype
depending on how the fee was paid at the SIP2 station (cash, credit, etc)

Adds a new param to recordpayment(), $sip_paytype, which is appended to the
'Pay' type if present.  The payment descriptin is also appended with " (via
SIP2)"
if this is present.

In order for other scripts to keep working as expected, "eq 'Pay'" needed to
be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##'
would continue
to group together.

To test:
1.  Make a payment over a SIP2 connection
2.  Check the patron record in the staff client; you should see the modified
description
3.  Attempt to print a invoice or a reciept for the borrower; the payment
should show up
    where expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:21:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 12:21:57 +0000
Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273

Benjamin Rokseth  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:29:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 12:29:15 +0000
Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19826|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall  ---
Created attachment 24936
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24936&action=edit
[PASSED QA] Bug 7308 - Follow up: removing line breaks for better
translatability

Because of the lines breaks in the table headings the strings
were separated in translation. Example:

Base-level allocated
 - Base-level
 - allocated

If you look at a smaller screen the table headings will still break
without the additional 
                  .

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:29:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 12:29:32 +0000
Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22462|0                           |1
        is obsolete|                            |

--- Comment #31 from Kyle M Hall  ---
Created attachment 24937
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24937&action=edit
[PASSED QA] Bug 7308: change color style for fund child

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:29:43 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 12:29:43 +0000
Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:02:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:02:03 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #5 from Kyle M Hall  ---
Katrin, do you mean *any* superlibrarian? Or just the database login
superlibrarian?

(In reply to Katrin Fischer from comment #3)
> Hm, I noticed that now when you log in as superlibrarian, there is a
> difference in behaviour. If you try to save a rule for "All libraries"
> without picking a library first, it won't save.
> 
> Could it be this line here?
> -my $branch = $input->param('branch') || ( C4::Branch::onlymine() ? (
> C4::Branch
> +my $branch = $input->param('branch') || C4::Branch::mybranch();

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:02:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:02:45 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

--- Comment #22 from Koha Team AMU  ---
(In reply to Julian Maurice from comment #19)
> This is a proposal patch for the first mentioned option : display only one
> line with all "case-variant" values in it.
> 
> The 2nd option seems to require more work.

It's ok for this patch. "agent administratif" and "Agent administratif" are
included in the same row.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:07:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:07:37 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #6 from Katrin Fischer  ---
Ah sorry Kyle, I meant the database user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:19:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:19:42 +0000
Subject: [Koha-bugs] [Bug 11648] New: Use word item instead of copy
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648

            Bug ID: 11648
           Summary: Use word item instead of copy
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Sometimes, the word copy/copies is use to speak about item/items.
It would be better to use only item because translation of the word copy
depends on context, it should be used only when speaking about copy like in
"copy and paste".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:19:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:19:58 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10346

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:19:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:19:58 +0000
Subject: [Koha-bugs] [Bug 10346] "Add multiple copies" should be labelled
 "Add multiple items"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10346

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11648

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:30:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:30:07 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:30:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:30:10 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 24938
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24938&action=edit
Bug 11648 - Use word item instead of copy - intranet

Sometimes, the word copy/copies is use to speak about item/items.
It would be better to use only item because translation of the word copy
depends on context, it should be used only when speaking about copy like in
"copy and paste".

This patch replaces copy/copies in intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:30:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:30:38 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648

--- Comment #2 from Fridolin SOMERS  ---
Created attachment 24939
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24939&action=edit
Bug 11648 - Use word item instead of copy - opac bootstrap

Sometimes, the word copy/copies is use to speak about item/items.
It would be better to use only item because translation of the word copy
depends on context, it should be used only when speaking about copy like in
"copy and paste".

This patch replaces copy/copies in opac bootstrap theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:31:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:31:23 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648

--- Comment #3 from Fridolin SOMERS  ---
Created attachment 24940
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24940&action=edit
Bug 11648 - Use word item instead of copy - opac prog

Sometimes, the word copy/copies is use to speak about item/items.
It would be better to use only item because translation of the word copy
depends on context, it should be used only when speaking about copy like in
"copy and paste".

This patch replaces copy/copies in  opac prog theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:42:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:42:18 +0000
Subject: [Koha-bugs] [Bug 11649] New: Always use words "copy number"
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11649

            Bug ID: 11649
           Summary: Always use words "copy number"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In most cases, the value of items.copynumber is displayed using the words "Copy
number". But in some cases, it is just "Copy".
It would be better to always use "Copy number" because in translation the word
"Copy" means the action of coping.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:47:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:47:20 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #7 from Kyle M Hall  ---
Created attachment 24941
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24941&action=edit
Bug 11625 [QA Followup] - Default to logged in library for circ rules and
notices & slips

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:49:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:49:56 +0000
Subject: [Koha-bugs] [Bug 11649] Always use words "copy number"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11649

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:49:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:49:59 +0000
Subject: [Koha-bugs] [Bug 11649] Always use words "copy number"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11649

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 24942
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24942&action=edit
Bug 11649 - Always use words "copy number" - intranet

In most cases, the value of items.copynumber is displayed using the words "Copy
number". But in some cases, it is just "Copy".
It would be better to always use "Copy number" because in translation the word
"Copy" means the action of coping.

This patch manages templates of intranet.

To test, display an item containing a value in items.copynumber.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:50:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:50:03 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #8 from Kyle M Hall  ---
Thanks! This followup should resolve the problem. As an aside, I wonder if you
should rid ourselves of the 'database' user altogether, and just provide a
command line script for creating users ( or at least superlibrarians ). It just
seems to cause more issues than it solves.

(In reply to Katrin Fischer from comment #6)
> Ah sorry Kyle, I meant the database user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:50:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:50:11 +0000
Subject: [Koha-bugs] [Bug 11649] Always use words "copy number"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11649

--- Comment #2 from Fridolin SOMERS  ---
Created attachment 24943
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24943&action=edit
Bug 11649 - Always use words "copy number" - opac bootstrap

In most cases, the value of items.copynumber is displayed using the words "Copy
number". But in some cases, it is just "Copy".
It would be better to always use "Copy number" because in translation the word
"Copy" means the action of coping.

This patch manages templates of opac bootstrap theme.

To test, display an item containing a value in items.copynumber.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:50:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:50:34 +0000
Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351

Benjamin Rokseth  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23354|0                           |1
        is obsolete|                            |

--- Comment #7 from Benjamin Rokseth  ---
Created attachment 24944
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24944&action=edit
Rebased against master 2014-01-31

Bug 11351 - Add support for SIP2 media types

Koha's SIP2 server implementation does not currently support the SIP2
protocol field "media type" ( CK ).

This patch implements the SIP2 media type by allowing an arbitrary
mapping of itemtypes to SIP2 media types.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Edit an itemtype, select a SIP media type, and save the changes
4) Make a SIP2 Item Information Request
5) Verify that the CK field of the Item Information Response contains
   the correct media type code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:50:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:50:39 +0000
Subject: [Koha-bugs] [Bug 11649] Always use words "copy number"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11649

--- Comment #3 from Fridolin SOMERS  ---
Created attachment 24945
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24945&action=edit
Bug 11649 - Always use words "copy number" - opac prog

In most cases, the value of items.copynumber is displayed using the words "Copy
number". But in some cases, it is just "Copy".
It would be better to always use "Copy number" because in translation the word
"Copy" means the action of coping.

This patch manages templates of opac prog theme.

To test, display an item containing a value in items.copynumber.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:51:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:51:20 +0000
Subject: [Koha-bugs] [Bug 11648] Use word item instead of copy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11648

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11649

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:51:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:51:20 +0000
Subject: [Koha-bugs] [Bug 11649] Always use words "copy number"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11649

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11648

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:55:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:55:53 +0000
Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351

Benjamin Rokseth  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24944|0                           |1
        is obsolete|                            |

--- Comment #8 from Benjamin Rokseth  ---
Created attachment 24946
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24946&action=edit
Tested according to described plan: - ran updatedatabase.pl - edited itemtype
of book and added SIP media type book - restarted SIP server - made SIP request
of book - verified that SIP media type returned CK001 (=book)

Bug 11351 - Add support for SIP2 media types

Koha's SIP2 server implementation does not currently support the SIP2
protocol field "media type" ( CK ).

This patch implements the SIP2 media type by allowing an arbitrary
mapping of itemtypes to SIP2 media types.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Edit an itemtype, select a SIP media type, and save the changes
4) Make a SIP2 Item Information Request
5) Verify that the CK field of the Item Information Response contains
   the correct media type code.

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:57:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:57:49 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #9 from Katrin Fischer  ---
I agree with you, but you would also have to provide a way to create the branch
and category code... and that complicates things a bit more. Also you would
have to prevent people from using it after running the web installer with the
database user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:59:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 13:59:41 +0000
Subject: [Koha-bugs] [Bug 11351] Add support for SIP2 media types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351

Benjamin Rokseth  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:04:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:04:02 +0000
Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683

Koha Team AMU  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #50 from Koha Team AMU  ---
I tested on a sandbox (langres) by comparing the results with sql reports.

The acquired date filter doesn't work. It seems like the end of the limit is
not used.

--> SQL report
SELECT homebranch, itemtype, COUNT(itemnumber)
FROM items JOIN biblioitems USING(biblionumber)
WHERE dateaccessioned BETWEEN "2013-01-01" AND "2013-12-31"
GROUP BY homebranch, itemtype
--> r?sultat
MAURES LIVR 1
MAURES REV 147

--> using statistics wizards
Row = itemtype
Column = home library
Acquired Date Filter From 01/01/2013 To 31/12/2013
--> r?sultats
itemtype / items.homebranch BDP MAURES TOTAL
CD 380 380
LAUD 6 6
LIVR 20 3783 3803
REV 862 862
SPECIAL 2 2
VHS 3 3
TOTAL 20 5036 5056

I tried the filter with "From 01/01/2012 To 31/12/2012", "From 01/01/2013 To
31/12/2013", "From 01/01/2014 To 31/01/2014". Each time the total is growing as
if only the start of the limit is used.

For that reason, I change status in "Failed QA".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:27:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:27:32 +0000
Subject: [Koha-bugs] [Bug 11650] New: multiplicated authorities after
 link_bibs_to_authorities.pl
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11650

            Bug ID: 11650
           Summary: multiplicated authorities after
                    link_bibs_to_authorities.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: gmcharlt at gmail.com
          Reporter: januszop at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Under certain circumstances misc/link_bibs_to_authorities.pl creates
multiple authority with identical heading.

Test scenario:
1. Have some (2-3) biblio records with some repeated headings
   Have BiblioAddsAuthorities = allow, AutoCreateAuthorities = generate
   Have no authority records
2. Run misc/link_bibs_to_authorities.pl script
3. You will get multiple authority records -- one for each occurence of a
   heading in biblio record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:30:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:30:05 +0000
Subject: [Koha-bugs] [Bug 11650] multiplicated authorities after
 link_bibs_to_authorities.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11650

Janusz Kaczmarek  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jcamins at cpbibliography.com
           Assignee|gmcharlt at gmail.com          |januszop at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:34:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:34:41 +0000
Subject: [Koha-bugs] [Bug 11650] multiplicated authorities after
 link_bibs_to_authorities.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11650

--- Comment #1 from Janusz Kaczmarek  ---
Created attachment 24947
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24947&action=edit
proposed patch

Under certain circumstances misc/link_bibs_to_authorities.pl creates
multiple authority with identical heading.

Test plan:
1. Have some (2-3) biblio records with some repeated headings
   Have BiblioAddsAuthorities = allow, AutoCreateAuthorities = generate
   Have no authority records
2. Run misc/link_bibs_to_authorities.pl script
3. You will get multiple authority records -- one for each occurence of a
   heading in biblio record.

4. Apply the patch.
5. Repeat 1-3 (remember to have "fresh" biblios, without $9, and no
   authorities).
6. The problem should be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:39:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:39:20 +0000
Subject: [Koha-bugs] [Bug 11650] multiplicated authorities after
 link_bibs_to_authorities.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11650

Janusz Kaczmarek  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

--- Comment #2 from Janusz Kaczmarek  ---
Jared, I am no sure if you will like this patch (it is related to your Bug 7284
solution).  Perhaps you would have a more elegant idea to sort this out...?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:52:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:52:33 +0000
Subject: [Koha-bugs] [Bug 11651] New: Add possibility to print holds from
	holds queue
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

            Bug ID: 11651
           Summary: Add possibility to print holds from holds queue
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rkopaczka at afm.edu.pl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

I've made a patch that allow print holds from holds queue page. In this way we
manage holds in our library, maybe someone else also would like it.
It's managed by preferences, when disabled nothing is changed (default) when
enabled there is possibility to print holds separately. 
There are some changes in database schema. I've add print_status column to
reserves, old_reserves and tmp_holdsqueue to distinguish between printed and
not printed holds. And reserve_id in tmp_holdsqueue to easily gets info about
particular reserve.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:53:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:53:59 +0000
Subject: [Koha-bugs] [Bug 11258] Holds queue is still making transfer
 requests that contradict the branch holds policy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #9 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #8)
> Kyle, I think we need help here - could it be something is missing from the
> test plan?

Nope, I followed the test plan with a fresh database and was able to recreate
the bug, and also show the patch resolves it.

Here is a video demonstration: http://screencast.com/t/0PBAfJkf5

After I demonstrate the bug, apply the patch and rebuild the holds queue,
you'll see no items in the holds queue. This is because I forgot that Reference
items are not holdable. So post-patch, neither item is holdable by that patron,
and the holds queue *should* be empty. After that, I make Reference items
holdable, rebuild the holds queue again, and a hold request for the Reference
item shows up, which is the correct behavior as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:56:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:56:39 +0000
Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds
	queue
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #1 from Rafal Kopaczka  ---
Created attachment 24948
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24948&action=edit
Bug-11651-Add-possibility-to-print-holds-from-holds-.patch

This patch adds possibility to print holds slip, directly from holds
queue page.
Added preference to enable or disable. When enabled in holds queue are 2
new buttons and checkboxes to select holds to print. First button prints
selected holds on RESERVESLIP form. Second is to switch between
display printed or not printed holds. In this mode isn't possible
to display printed and non printed together.

Test plan:
1) Apply patch
2) Update database
3) Make 2 new holds, 1 on specific copy, another on next available
4) Update holds queue by running
$KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl
5) Check holds queue there should be 2 new holds from step 3
6) Enable printSlipFromHoldsQueue in preferences-> circulation-> interface
7) Go to holds after submit branch there should be 2 new buttons and
checkboxes in table.
8) Print both holds and check if on slip are all biblio and item info.
9) click show printed to display printed holds
10) click hide printed, now holds queue shuld be empty
11) disable printSlipFromHoldsQueue go to holds queue and check if holds
are again visible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:57:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 14:57:45 +0000
Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds
	queue
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:14:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:14:11 +0000
Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:14:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:14:14 +0000
Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19606|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall  ---
Created attachment 24949
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24949&action=edit
Bug 9532: reserve rules with itemtype on biblio

When itemtype is defined on biblio (item-level_itypes syspref), the method
C4::Reserves::CanItemBeReserved uses item->{itemtype}. But item comes from
C4::Items::GetItem and it does not have a 'itemtype' key, in this method the
item type value is always in 'itype' key.

This patch corrects it.

Test plan:
You must have itemtype on biblio and 'item-level_itypes' syspref on biblio.
This test plan is with ReservesControlBranch on ItemHomeLibrary.
- Choose a branch, a borrower category and an item type, for example 'NYC',
'CHILD' and 'DVD'
- Set an issuing rule for 'NYC', CHILD' and 'DVD' with 'Holds allowed' on 10
- Set an issuing rule for 'NYC', CHILD' and all item types with 'Holds allowed'
on 0
- Choose an item of a biblio with itemtype 'DVD', that can be reserved, with
'NYC' as homebranch
- Choose a borrower with category 'CHILD'
- try to reverse the item for the borrower
=> without the patch, you can
=> with the patch, you can't
You may check reserve is allowed with 'Holds allowed' > 0 on issuing rule for
'DVD'.

Signed-off-by: Liz Rea 
Great test plan - thanks!

Confirmed the bug, and the fix. Looks good to me.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:17:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:17:04 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:20:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:20:20 +0000
Subject: [Koha-bugs] [Bug 11455] Rule Replacement Confirmation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11455

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:20:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:20:17 +0000
Subject: [Koha-bugs] [Bug 11454] Cannot indicate time on Circulation Rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11454

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:23:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:23:19 +0000
Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:23:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:23:51 +0000
Subject: [Koha-bugs] [Bug 11462] New series title authority includes volume
	number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11462

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:27:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:27:22 +0000
Subject: [Koha-bugs] [Bug 11652] New: merging authority records does not
	correct biblios
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652

            Bug ID: 11652
           Summary: merging authority records does not correct biblios
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: gmcharlt at gmail.com
          Reporter: januszop at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When merging authority records in librarian interface biblio records
linked to deleted authority are not being corrected (i.e. have still
old heading and orpaned link in $9).

Test scenario:
1. Have two authorities in the catalogue, linked to biblio records.
2. Merge them with the new merge facility (cf. Bug 5202).
3. Have a look a the biblio record(s) previously linked to the removed
   authority. It should still have the old heading AND orpaned authority
   link in $9.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:29:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:29:16 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
	biblios
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652

Janusz Kaczmarek  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |januszop at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:29:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:29:59 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
	biblios
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652

--- Comment #1 from Janusz Kaczmarek  ---
Created attachment 24950
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24950&action=edit
proposed patch

When merging authority records in librarian interface biblio records
linked to deleted authority are not being corrected (i.e. have still
old heading and orpaned link in $9).

Test plan:
1. Have two authorities in the catalogue, linked to biblio records.
2. Merge them with the new merge facility (cf. Bug 5202).
3. Have a look a the biblio record(s) previously linked to the removed
   authority. It should still have the old heading AND orpaned authority
   link in $9.

4. Apply the patch.
5. Refresh the test records (or use another set).
6. Repeat 1-3. Headings should be refreshed and the correct authid link
   should be in $9 now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:30:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:30:30 +0000
Subject: [Koha-bugs] [Bug 11482] new reservation syspref
	PickupHoldOnlyFromItemBranches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:30:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:30:36 +0000
Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct
	biblios
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652

Janusz Kaczmarek  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:30:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:30:37 +0000
Subject: [Koha-bugs] [Bug 11481] new reservation syspref
	HoldOnlyWhenAllItemsOnLoan
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:31:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:31:10 +0000
Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your
	summary tabs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:33:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:33:29 +0000
Subject: [Koha-bugs] [Bug 10968] Add a way to choose which indexes to
 display on simple and advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10968

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:37:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:37:48 +0000
Subject: [Koha-bugs] [Bug 11616] The tablesorter plugin is no longer in use
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11616

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton  ---
Pushed to master, along with a follow-up that removes CSS rules used only for
tablesorter.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:39:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:39:40 +0000
Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your
	summary tabs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23888|0                           |1
        is obsolete|                            |

--- Comment #2 from Nicole C. Engard  ---
Created attachment 24951
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24951&action=edit
[SIGNED-OFF] Bug 11465 - Show counts and amounts on OPAC your summary tabs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:39:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:39:47 +0000
Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your
	summary tabs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:46:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:46:01 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #42 from mathieu saby  ---
I'll take a look next week

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:46:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:46:59 +0000
Subject: [Koha-bugs] [Bug 11534] impossible to remove instructors on course
	reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #14 from Galen Charlton  ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:48:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:48:44 +0000
Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text
 "Select titles to: " in bootstrap
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton  ---
Pushed to master.  Thanks, Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:49:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:49:15 +0000
Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to
 amount unallocated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644

Sean McGarvey  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |smcgarvey at pascocountyfl.net

--- Comment #2 from Sean McGarvey  ---
Tested on pasco county production server, our acquisitions team says fix worked
perfectly!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:51:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:51:14 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:52:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:52:17 +0000
Subject: [Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you
 want to write off ..."
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #10 from Galen Charlton  ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:58:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:58:56 +0000
Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag
	visibility
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24875|0                           |1
        is obsolete|                            |

--- Comment #23 from Kyle M Hall  ---
Created attachment 24952
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24952&action=edit
Bug 11592 - Updated License Text and use Modern::Perl

Why not clean up the License Agreement stuff while the files
are being changed? Used the current one found at:
http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

Changed the strict and warning lines into just a Modern::Perl.

Signed-off-by: Robin Sheat 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:59:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:59:17 +0000
Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag
	visibility
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24876|0                           |1
        is obsolete|                            |

--- Comment #24 from Kyle M Hall  ---
Created attachment 24953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24953&action=edit
Bug 11592 - opac scripts do not respect marc tag visibility

Added two functions to C4/Biblio: GetFilteredOpacBiblio
and GetOpacHideMARC.

GetFilteredOpacBiblio returns a MARC::Record stripped of all the
fields and subfields which are supposed to be hidden in OPAC.

GetOpacHideMARC returns a hash of whether a particular key
(eg. title, subtitle, etc.)  is hidden. A value of 0 means no,
a value of 1 means hidden.

Made GetCOinSBiblio function handle hiding of 245$a more
gracefully. Also, modified GetMarcSubjects to not generate an
array entry of empty values.

Tweaked C4/XSLT.pm to delete a field, if there weren't any
subfields to actually update with.

Properly hid 245$a, in the case that there is no visibility
for OPAC, for opac-MARCdetail.

opac-detail now filters the MARC::Record according to the hidden
value in marc_subfield_structure properly. It also corrects a
couple minor issues with a parameter not passed being used in a
concatenation. How the subtitle values calculation works changed.
It is now based on marc_subfield_structure and not fieldmapping.
And, the GetBiblioData hash that generates template variables is
now filtered by the results of a GetOpacHideMARC call.

The opac-showmarc page now converts the MARCXML record to a
MARC::Record to easily filter using GetFilteredOpacBiblio, which
is then turned back into MARCXML for processing.

The opac-export script now filters the biblio record to match
what is currently displayed.

Added tests to t/db_dependent/Biblio.t to test the functionality
of the two functions added into C4::Biblio.

Added a GetFilteredOpacBiblio call into opac-ISBDdetail page, so
that it should be filtered.

TEST PLAN
---------
 1) Backup DB
 2) Go to any OPAC detail page and note the biblio number.
 3) Log into the staff client and determine the framework code for
     that biblio number.
 4) The steps should be done with OPACXSLTDetailsDisplay
     set to blank.
 5) Home -> Koha administration -> MARC bibliographic framework
         -> MARC structure (for the matching framework)
 6) On the OPAC detail page, click MARC view
 7) In the staff client, for every tag listed in the OPAC
     -> Subfields -> click the first link
     Then running through all the tabs, click Advanced constraints
      and uncheck OPAC visibility. Then click Save Changes
 8) Refresh the opac-MARCdetail page in OPAC
    -- what you hid should be mostly hidden
       TITLE will still display, even if you hide 245$a!
 9) Click Normal view, and all the hidden things are still
     mostly showing!
10) The steps should be done with OPACXSLTDetailsDisplay
    set to default (or some custom one?).
11) Refresh the opac-detail page. Still mostly showing all the
     hidden things.
12) Click MARC view, and everything should be hidden...
13) Until you click the 'view plain' link.
14) Apply the patch.
15) Run the Koha QA test tool.
16) Refresh the opac-MARCdetail page. Title should hide now.
17) Click the 'view plain' link.
    -- LDR and 999$c and 999$d were displaying for me.
       I realized that I hadn't hidden 999, because the
       opac-MARCdetail page doesn't display it.
       LDR is the only known leak.
18) Click Normal view
19) Now all the opac-detail page should hide things just like
     the opac-MARCdetail page.
20) In the staff client, change the OPACXSLTDetailsDisplay to
     a blank value.
21) Recheck opac-detail and opac-MARC detail pages again,
     including the view plain link, and everything should
     hidden similarly.
    -- NOTE: LDR is the only known leak.
NOTE: 952 fields are treated separately, so I don't believe they
      could be hidden in the table using the MARC visibility.
      The goal was hiding properly things above the items.
22) And lastly, attempt to Save record in the various formats
     using the dropdown and clicking Go.
    -- The results should be filtered.
23) Click on ISBD view to ensure nothing broke.
24) Restore DB, because hiding 000,003,005,008,020,040,245,etc.
    are not useful across an entire framework.

Signed-off-by: Robin Sheat 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:59:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 15:59:28 +0000
Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag
	visibility
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:01:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:01:33 +0000
Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the
 'active' switch on budgets
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolin SOMERS  ---
Isn't this a duplicate of Bug 10875 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:03:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:03:11 +0000
Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the
 'active' switch on budgets
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176

--- Comment #2 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #1)
> Isn't this a duplicate of Bug 10875 ?
No, this bug is about suggestions, sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:03:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:03:26 +0000
Subject: [Koha-bugs] [Bug 11268] Biblioitems URL field is too small for some
	URLs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11268

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton  ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:03:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:03:33 +0000
Subject: [Koha-bugs] [Bug 11644] Cannot update fund if total is equal to
 amount unallocated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11644

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24900|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall  ---
Created attachment 24954
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24954&action=edit
Bug 11644 - Cannot update fund if total is equal to amount unallocated

When attempting to update a fund, if the amount unalloccated for the
fund is equal to the total, you can be prevented from saving. This is
due to imprecise floating point number comparison in
check_parent_total.pl

Test Plan:
1) Create a fund where the amount unallocated is equal to the amount
   unallocated for the budget period
2) Edit the fund, attempt to change the name of the fund
3) Note you recieve an error and cannot save
4) Apply this patch
5) Repeat step 2
6) Note you can now update the fund

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:07:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:07:17 +0000
Subject: [Koha-bugs] [Bug 11182] Warnings in circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24522|0                           |1
        is obsolete|                            |

--- Comment #21 from Tom?s Cohen Arazi  ---
Created attachment 24955
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24955&action=edit
Bug 11182 [1] - Warnings in circulation

TEST PLAN
---------
 1) Log into staff client
 2) Click 'Circulation'
 3) Click 'Check out'
 4a) Type a patron name, click 'Submit'
 4b) If necessary, select which one, and click 'Select'
 5) Check the error logs, new warnings
 6) Apply patch
 7) Click 'Circulation'
 8) Click 'Check out'
 9a) Type a patron name, click 'Submit'
 9b) If necessary, select which one, and click 'Select'
10) Check the error logs, no new warnings
11) Click the 'Restrictions' tab
12) Click 'Add manual restriction'
13) Add a dummy restriction
14) Click the 'Restrictions' tab
15) Click 'Remove'
16) Click 'OK'
17) Confirm that no additional error log entries were added
     and adding/deleting restrictions hasn't broken.

Signed-off-by: Jesse Weaver 
Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:07:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:07:36 +0000
Subject: [Koha-bugs] [Bug 11182] Warnings in circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24523|0                           |1
        is obsolete|                            |

--- Comment #22 from Tom?s Cohen Arazi  ---
Created attachment 24956
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24956&action=edit
Bug 11182 [2] - Warnings in circulation

This deals with the warning when Circulation system preference
'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item
is checked in.

TEST PLAN
---------
 0) Feel free to backup your koha-error_log file, and then toast it.
     $ echo > ~/koha-dev/var/log/koha-error_log
 1) Log into staff client
 2) Koha administration
 3) Global system preferences
 4) Circulation
 5) Make sure WaitingNotifyAtCheckin is set to Notify.
 6) Check out tab
 7) Type patron's name
 8) Select patron if required
 9) Check out an item, but set the due date to be overdue.
10) Check in the overdue item.
11) Check the error log
     $ cat ~/koha-dev/var/log/koha-error_log | grep 284
     NOTE: the returns.pl one that will be fixed by this.
12) Apply this patch
13) Repeat steps 6 through 7, there should no new line 284 entries.

Signed-off-by: Jesse Weaver 
Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:07:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:07:49 +0000
Subject: [Koha-bugs] [Bug 11182] Warnings in circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24524|0                           |1
        is obsolete|                            |

--- Comment #23 from Tom?s Cohen Arazi  ---
Created attachment 24957
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24957&action=edit
Bug 11182 [3] - get rid of some warnings

After fuller testing, there were five problems found:
circulation.pl:273
borrower_debarments.inc:65
returns.pl:269
returns.pl:284
returns.pl:540

This patch catches returns.pl:269 and returns.pl:540
Oops. Cut-and-paste error. Corrected step 5. :)

TEST PLAN
---------
 1) Log into staff client
 2) Koha administration
 3) Global system preferences
 4) Circulation
 5) Make sure FineNotifyAtCheckin is set to Notify.
 6) Check out tab
 7) Type patron's name and click 'Submit'
 8) Select patron if required
 9) Check out an item, but set the due date to be overdue.
10) Check in the overdue item.
11) Check the error log
     $ cat ~/koha-dev/var/log/koha-error_log
     NOTE: only the warnings from lines 269 and 540 in returns.pl
           are the ones to note.
12) Apply this patch
13) Repeat steps 6 through 11, there should no new
    warnings related to lines 269 or 540 from returns.pl.

Signed-off-by: Mark Tompsett 
Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:08:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:08:05 +0000
Subject: [Koha-bugs] [Bug 11182] Warnings in circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182

--- Comment #24 from Tom?s Cohen Arazi  ---
Created attachment 24958
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24958&action=edit
Bug 11182: (QA followup) warning if itemBarcodeFallbackSearch set

To reproduce:
- On top of the previous patches, if you enable the itemBarcodeFallbackSearch
  syspref and do a search for a term that returns at least one result, there
  will be warnings for each result without items attached.

To test:

- In the checkout form enter a term that should return results (some of them
  without items attached)
=> There are warnings on the logs regarding a split of undef variable
- Apply the patch
- Repeat the first step
=> No warings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:24:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:24:02 +0000
Subject: [Koha-bugs] [Bug 11513] Warnings in Patron categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #20 from Galen Charlton  ---
Pushed to master, along with a follow-up that ensures that KohaDates is used
for all occurrences of the enrollment end date.  Thanks, Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:41:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:41:34 +0000
Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte
	characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

--- Comment #25 from Galen Charlton  ---
Created attachment 24959
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24959&action=edit
Bug 9579: fix truncation of facets containing multi-byte characters

We seem to be relying on whatever Zoom::Results->render return, and
Perl doesn't explicitly consider it UNICODE data. That's why CORE::substr
(and probably CORE::length too) cut the bytes wrong.

This patch just decodes the UTF-8 data that render() returns and then
Perl behaves, heh.

It uses Encode::decode_utf8 which is already a dependency for the current
stable Koha releases.

REVISED TEST PLAN
-----------------
1) Import the attached sample records.
2) Rebuild your indexes
3) In OPAC search for ????????? : ???? ? ???
-- There will be ugly diamonds with question marks in the facets
4) apply the patch
5) Search again.
-- The names will be properly truncated.
NOTE: This test assumes FacetLabelTruncationLength = 20.

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Mark Tompsett 
Signed-off-by: Katrin Fischer 
Passes all tests and QA script.
Works as described, tested with several German, English and
the Arabic test record. Arabic strings now display correctly
and no regression was found.

Signed-off-by: Galen Charlton 

I've reviewed it and approve its inclusion in 3.14.x and earlier.  I
will use the patches for bug 11096, once they pass QA, for the master
branch.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:41:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:41:51 +0000
Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte
	characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:41:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 16:41:53 +0000
Subject: [Koha-bugs] [Bug 9579] Facets truncation broken for multi-byte
	characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24725|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:07:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 17:07:54 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

--- Comment #9 from M. Tompsett  ---
t/db_dependent/Members.t calls C4::Member::DelMember which potentially logs
based on a system preference.

MyISAM is effectively autocommit=1 and prevents transactions. Transactions
should be used in tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:24:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 17:24:12 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24923|0                           |1
        is obsolete|                            |
                 CC|                            |kyle at bywatersolutions.com

--- Comment #22 from Kyle M Hall  ---
Created attachment 24960
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24960&action=edit
24923: Bug 11491 - Missing field names in JSON data

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:24:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 17:24:36 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24924|0                           |1
        is obsolete|                            |

--- Comment #23 from Kyle M Hall  ---
Created attachment 24961
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24961&action=edit
24924: Bug 11491 - Old License and strict, warnings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:25:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 17:25:18 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24960|0                           |1
           is patch|                            |
  Attachment #24960|application/mbox            |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:25:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 17:25:36 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:46:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 17:46:19 +0000
Subject: [Koha-bugs] [Bug 11653] New: For tag "020" only subfields "a" is
 displayed in MARC XSLT OPAC's detail template
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11653

            Bug ID: 11653
           Summary: For tag "020" only subfields "a" is displayed in MARC
                    XSLT OPAC's detail template
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: costalc at gmail.com
        QA Contact: testopia at bugs.koha-community.org

MARC XSLT OPAC's detail template and Intranet detail template only display
subfield "a" for tag "020". It is  needed  showing all subfields according MARC
rules. 

example
=======
For:
020     ##$a0870686933$qv. 1$z087064302

Display:
ISBN 0870686933 (v. 1) ISBN (invalid) 0870684302 



Reference: http://www.loc.gov/marc/bibliographic/bd020.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:51:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 17:51:42 +0000
Subject: [Koha-bugs] [Bug 11654] New: New subfield "q" in Tag "020". It is
 needed to update Books Mark Framework Struture in sql installation file.
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11654

            Bug ID: 11654
           Summary: New subfield "q" in Tag "020". It is needed to update
                    Books Mark Framework Struture in sql installation
                    file.
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: costalc at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

New subfield "q" in Tag "020". It is needed to update Books Mark Framework
Struture in sql installation file.

Reference:http://www.loc.gov/marc/bibliographic/bd020.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 19:31:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 18:31:07 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Havilah Lyon  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |havilah at aflibrary.org

--- Comment #3 from Havilah Lyon  ---
I tested this. It works fine for us.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 19:37:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 18:37:08 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Melissa Lefebvre  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24849|0                           |1
        is obsolete|                            |

--- Comment #4 from Melissa Lefebvre  ---
Created attachment 24962
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24962&action=edit
Bug 11629 - Add ability to update not for loan status on checkin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 19:58:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 18:58:16 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

--- Comment #5 from Kyle M Hall  ---
Created attachment 24963
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24963&action=edit
Bug 11629 [QA Followup] - Add message for librarian that status was updated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 20:00:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 19:00:01 +0000
Subject: [Koha-bugs] [Bug 11629] Add ability to update not for loan status
	on checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24963|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall  ---
Created attachment 24964
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24964&action=edit
Bug 11629 [QA Followup] - Add message for librarian that status was updated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 20:18:34 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 19:18:34 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Joel Sasse  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsasse at plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 20:24:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 19:24:49 +0000
Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the
	MARC21 defaults
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #20 from Galen Charlton  ---
Pushed to master.  Note that I dropped the database update and added a
follow-up to ensure that matching would work regardless of the QueryParser
mode.

By the way, I wouldn't be opposed to making the default matching rules
mandatory during installation.

Thanks David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 20:42:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 19:42:19 +0000
Subject: [Koha-bugs] [Bug 11655] New: koha-translate --list shouldn't show
	'en'
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655

            Bug ID: 11655
           Summary: koha-translate --list shouldn't show 'en'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

'en' is not a translation and it doesn't make any sense to return it as part of
the installed translations or the available ones.

It becomes relevant to remove it as users upgrading their installed
translations end up doing things like this to remove en from the list:

for lang in $(sudo koha-translate --list | grep -v -x en) ; do sudo
koha-translate --update $lang ; done

And we do the same in several places too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 20:50:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 19:50:57 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #43 from Katrin Fischer  ---
I'd love to see this moving forward, but I am not sure how to fully test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 20:57:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 19:57:27 +0000
Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 20:57:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 19:57:31 +0000
Subject: [Koha-bugs] [Bug 11655] koha-translate --list shouldn't show 'en'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11655

--- Comment #1 from Tom?s Cohen Arazi  ---
Created attachment 24965
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24965&action=edit
Bug 11655: koha-translate --list shouldn't show 'en'

'en' is not a translation and it doesn't make any sense to return it as part of
the installed translations or the available ones.

It becomes relevant to remove it as users upgrading their installed
translations end up grepping the output to remove 'en' like in:

for lang in $(koha-translate --list | grep -v -x -e 'en') ; do
  koah-translate --update $lang
done

instead on simply issuing the koha-translate --list command.

To test:
- Run
  ./koha-translate --list
  ./koha-translate --list --available
=> It shouldn't return 'en' in the result list.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:32:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 20:32:03 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to have header
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

Galen Charlton  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #24 from Galen Charlton  ---
Pushed to master.  Thanks, Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:46:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 20:46:49 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #43 from M. Tompsett  ---
The generate a new link process can create multiple links (potentially huge
number) for a single user. It should overwrite the existing one. No more than
one entry per borrowernumber.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:02:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 21:02:40 +0000
Subject: [Koha-bugs] [Bug 11491] Extending report service to be annotated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Extending report service to |Extending report service to
                   |have header                 |be annotated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:12:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 21:12:23 +0000
Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english
	language fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10942

--- Comment #10 from Katrin Fischer  ---
I think 10942 would help with your wish :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:12:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2014 21:12:23 +0000
Subject: [Koha-bugs] [Bug 10942] Provide a way for package upgrades to
 update template translations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11145

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.