[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Magnus Enger <magnus at enger.priv.no> ---
1. Typo in the module name, I think Koha::Sitemaper should be Koha::Sitemapper.
2. XML::Writer is not added to C4::Installer::PerlDependencies.
3. The POD for the script talks about generating files called sitemapindex.xml
and sitemapXXXX.xml, but as far as I can see, all output is written to STDOUT
and has to be split into different files by hand?
4. XML documents output by the script are missing the <?xml ... ?>
declarations, but they might be optional? 
5. No tests for the stuff in Koha::Sitemaper and Koha::Sitemaper::Writer? 

Suggestions:

6. It could perhaps be said explicitly that the --url parameter shuld not
include the trailing slash?
7. Could the base URL be taken from the OPACBaseURL syspref instead of being a
command line parameter? 
8. URLs in the sitemap-file are on the form: http://example.org/bib/171 Some
sites might have disabled the Apache rewrite rules that make these URLs
functional, so it might be better to have the style
/cgi-bin/koha/opac-detail.pl?biblionumber=172 as the default and make the
shorter form available through a command line switch? 

I'm marking this "Failed QA" because of number 2 above. But this would make a
very cool addition to Koha, so I hope the issues can be fixed! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.