[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23893|0                           |1
        is obsolete|                            |

--- Comment #9 from Frédéric Demians <frederic at tamil.fr> ---
Created attachment 23896
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23896&action=edit
Proposed patch v3

> This meant that the script was actually beig run as the kohadev-koha user
> (or something like that), which did not have write permission to the dir I
> was executing the script in. This caused the XML to be written to STDOUT,
> instead of to a file.

I've added a test on this condition: error message is displayed now.

> Would it be hard to add an (optional) switch for specifying where the
> output goes? 

Done.

> If sitemap.pl is run without any arguments, it will create the sitemap
> files. I seem to remember we have a convention that scripts run without
> arguments should print a help message and exit, but it does not seem to be
> in the coding guidelines... Maybe add a --run parameter to actually run the
> script?

I'm not sure on this point. For me, a --run is required for scripts
which alter database, and when there is a risk of data loose. This isn't
the case here.

-- 
You are receiving this mail because:
You are watching all bug changes.