[Koha-bugs] [Bug 11473] New: View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473

            Bug ID: 11473
           Summary: View log template has malformed conditionals, and
                    logging info incorrect/inconsistent/unexpected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Transaction logs
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

1) Malformed conditionals

Currently, the majority of "viewlog.tt" is ignored, because we haven't formed
the conditionals correctly. 

(e.g. Using 'module' when we should be using 'loopro.module' [or
'loopro.MODULENAME' like 'loopro.CIRCULATION'], 'info' instead of
'loopro.info', etc.)

This means that we always get the raw "loopro.object", which is either a
borrowernumber, biblionumber, itemnumber, subscriptionid, or authid, with
absolutely no qualifier at all.


*SOLUTION*

Alas, the solution requires a few systematic changes.

Detecting an object as a 'borrowernumber' is easy, since MEMBERS, CIRCULATION,
and FINES always use it as its object. Same goes for 'subscriptionid' for
SERIALS and 'authid' for AUTHORITIES. For these cases, we just need to fix the
variables called in the conditions.

However, unfortunately, CATALOGUING sometimes uses biblionumber and sometimes
uses itemnumber as its object. This causes the following problem...


2) Conditions in viewlog.pl and viewlog.tt do not correctly differentiate items
and biblios.

There are conditions that check to see if the 'info' column says 'item'.
However, this has erratic results, because 'item' is only logged for item adds
and deletions - not modifications. (Authorities also only track 'authority' for
additions and deletions - not modifications.)

'biblio' is only tracked for biblio additions. Deletions have no info, while
modifications include the record content.  


In viewlog.tt, logs without an 'info' of 'item' will be labelled and linked as
'biblio'. That means that all item modifications will be treated as biblios and
not items. 

*SOLUTION*
Change logaction to prepend the info column with "biblio" for all biblio
transactions and "item" for all item transactions. Then, check for the
applicable substring in viewlog.pl and viewlog.tt to determine how to link and
label the number.

For legacy data, have a third option that doesn't label/link the object. Just
have the raw number (as we currently do).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.