[Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes'

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 24034
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24034&action=edit
[SIGNED-OFF] Bug 11466 - Purchase suggestion itemtypes, only default available
if AdvancedSearchTypes not equal 'itemtypes'

--------------
-- Synopsis --
--------------

When system preference AdvancedSearchTypes has other values than 'itemtypes',
for ex 'itemtypes|loc', itemtypes selection in opac-suggestions.pl is not
populated with available itemtypes.

This patch fixes the issue by broadening the strict comparison of
($advanced_search_types eg 'itemtypes') #fails 'itemtypes|loc'
to
($advanced_search_types =~ 'itemtypes') #succeeds 'itemtypes|loc'

Unit tests included

---------------
-- Test plan --
---------------

REPLICATING THE ISSUE
1. Set system preference  AdvancedSearchTypes to itemtypes|loc
2. Go to opac-suggestions.pl and observe Item type <select> dropdown list
2.1. List should have only the default value

AFTER APLLYING THIS PATCH
1. Set system preference  AdvancedSearchTypes to itemtypes|loc
2. Go to opac-suggestions.pl and observe Item type <select> dropdown list
2.1. List should have itemtypes available for selection

Thanks for testing!
You are awesome!
gg

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Tests worked as expected. Placed a suggestion and saw the whole
list of item types, chose one, saved, checked staff and it loaded
as expected. Changed item type in staff and it applied in both
views.

-- 
You are receiving this mail because:
You are watching all bug changes.