[Koha-bugs] [Bug 10845] Multi transport types for holds

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Olli-Antti Kivilahti from comment #13)
> Reading your test cases, and good job with the description!
> 
> There is one concern!
> What if a patron defines to his own messaging preferences sms and email, but
> has no sms notification number defined nor email.
> This can easily be done accidentally.
> This might needlessly bloat our print notifications queue and cause lots of
> extra costs.

If no sms and email are defined, a print notice will be generated.
Feel free to fix the preferences or not to sent the notification :)
What do you propose ?

> Would it be possible to add a check that;
>  if email or sms is succesfully sent, even if the other email or sms has
> failed, no print notice is generated. This is slightly problematic to
> implement but shouldn't be too difficult.

The behavior I developed is the behavior needed by our customer.
Maybe a syspref could be let the choice, but it is out of the scope of this
patch.

> Also a patron can request email and sms, buth have no such contact details.
> In this case the email is sent via print notice + the sms replaced with
> another print notice!

No, normally only 1 print notice is generated.

(In reply to Olli-Antti Kivilahti from comment #15)
> If I have had email and sms defined, but subsequently removed those contact
> details, I suspect this condition brings falsehood:
> 
> if ( ($mtt eq 'email' and not $to_address) or ($mtt eq 'sms' and not
> $borrower->{smsalertnumber}) ) {
> 
> $to_address and $borrower->{smsalertnumber} are defined as empty Strings and
> validate true in Perl.
> 
> Thus I have been unable to trigger the double print notification bug, but
> instead got sms and email notifications with destination of '' == empty
> String

1 sms and 1 email have been generated with and empty to_address?

-- 
You are receiving this mail because:
You are watching all bug changes.