[Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |gmcharlt at gmail.com

--- Comment #8 from Galen Charlton <gmcharlt at gmail.com> ---
I'm failing this because it doesn't address the root cause, which is that
opac-search.pl is failing to count hits correctly when bibs get filtered out
because all of their items are hidden.  To see what I mean, try the following
test:

[1] Arrange a search that returns two hits.
[2] Edit the items on one of the bibs so that all of them would be hidden.
[3] Run the search.  The OPAC will report two hits, but display a result list
containing only one hit.  It should actually be redirecting to that bib.

The root issue is described in bug 8462.  Putting aside the notion of further
work to materialize the hidden status of the items attached to a bib so that
the search engine can filter them out automatically, I think there's room for a
patch for that bug that simply arranges so that $total and $hits are calculated
correctly; I think that it is a far less productive direction to pile on more
code that attempts to work around $total being incorrect.

Jonathan: regarding your follow-up, one thing to note is that the Bootstrap
theme already

-- 
You are receiving this mail because:
You are watching all bug changes.