[Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left).

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #4)
> This works nicely, but not sure if it touches the necessary files. I see
> there is also /koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.css.

Yeah there is a better way to handle this, although no one can be blamed for
not knowing it because I haven't done a good job of laying out the guidelines.

Two main points to consider:

1. No changes should be made to the files in bootstrap/lib unless they are
"official upgrades" to these files, which are all created and maintained
outside of the Koha project. If bootstrap-rtl.css has an error it and there
isn't an "official upgrade" then the correction needs to be applied in Koha's
custom RTL CSS.

2. All CSS in the Bootstrap theme is generated from LESS files (in
bootstrap/less), so changes to CSS should be done in the LESS file. There is a
specific rtl CSS file there: bootstrap/less/right-to-left.less, where this
patch's changes should be made. Then the less file should be compiled and the
resulting file put in bootstrap/css.

-- 
You are receiving this mail because:
You are watching all bug changes.