[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Jan 12 12:18:10 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some notes:

1) The feature is activated by default on updated installations. I think it
would
  be better to only activate it on new installations.

2) The return date defaults to "today 23:59". Wouldn't it make more sense to 
   default to "yesterday 23:95"? And consequently, should we allow setting
return
   dates in the future?

3) If you use the date the plugin suggests, check the checkbox for keeping the
date and then submit the form with empty barcode or return a book, following
error occurs:
   Template process failed: undef error - Can't use string ("") as a HASH ref
while "strict refs" in use at
/home/katrin/kohaclone/Koha/Template/Plugin/Borrowers.pm line 47.
It also happens with a return date in the past, book was not checked out.

X) We have the same problem here as we have on bug 10995. For accessibility
  reasons we should allow manual entry of the date and time, but we need to 
  catch the errors. 
  If you enter an invalid date now, you get a nasty perl error. I got:
  Can't call method "ymd" on an undefined value at
/usr/share/perl5/DateTime/Format/MySQL.pm line 84. 

Failed for 2) and 3). X) is kind of a difficult one. I really think we need a
general solution here, but not sure how to achieve it. Not going to fail for
that right now, but welcoming ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list