[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle,

there is a conflict in Branches.pm. I tried to resolve it, but started
wondering about @bind_parameters. You remove the push line, so it never gets
assigned, but is used later on. Also I think we should use ? instead of
$branches.

     my $query="SELECT * FROM branches";
     my @bind_parameters;
     if ($onlymine && C4::Context->userenv && C4::Context->userenv->{branch}){
-      $query .= ' WHERE branchcode = ? ';
-      push @bind_parameters, C4::Context->userenv->{branch};
+      my $branches = GetIndependentGroupModificationRights({ stringify => 1
});
+      $query .= qq{ WHERE branchcode IN ( $branches ) };
     }
    $query .= " ORDER BY branchname";
    $sth = $dbh->prepare($query);
    $sth->execute(@bind_parameters);

-- 
You are receiving this mail because:
You are watching all bug changes.