[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |gmcharlt at gmail.com

--- Comment #40 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #25)
> Works as described, but still could not expand or collapse fields.

This is still a problem -- ExpandField() cataloging.js, and possibly other
routines, are expecting that subfields are contained in a <div>, not <li>, and
would need to be updated.

Another thing that gets broken by the patch is the ability to client on the
little triangle icons next to each subfield to move them up or down.  That
should either be made to work, or it should be removed (on account that the
subfields become sortable with this patch).

I'm failing the patch for those reasons, but they won't be difficult to deal
with.

There's a more serious issue, however, which isn't caused by this patch but
which would become more obvious with it -- if you open the record again in the
editor, field order isn't maintained.  For example, if you construct your
record so that subject headings are in the following order:

650 $aElizabethan theatre
600 $aShakespeare, William

then open it up again in the editor, the 600 will be displayed before the 650,
even though the 650 field is stored first in the record.  This has the
potential to be seriously confusing to users, and I feel that a patch that
allows sorting of the fields in a user-specified order needs to be accompanied
by work that makes the editor display existing fields in the order that they
appear in the record.

The increase in the time (as measured by Jonathan) it takes to render the
editor is unfortunate, but IMO does not quite rise to the level that calls for
a new syspref.  Now if Bernardo's experience (36 seconds!) were the norm, that
would be unacceptably slow.

-- 
You are receiving this mail because:
You are watching all bug changes.