[Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Cook from comment #3)
> Marcel, why do you think that these patches are necessary?
Hi David. Thanks for testing.
They are not that important :) But I would like to reduce the 500s in my log
(especially from opac, mainly coming from Googlebot).
Testing if something is what it should be, cannot hurt BTW :)

> I suppose, in the case of the OPAC, it might make sense to return a 404
> instead of a 500, but when is an opac-showmarc.pl query string going to be
> malformed?
That is indeed somewhat less likely, but not imaginary.
1) Someone saved a URL. The record does no longer exist.
2) User 1 deleted the record, Zebra has not been updated yet. User 2 clicks on
the link.
3) If the marcxml of a record is malformed (due to some earlier error or so),
GetMarcBiblio returns undef. We should check that and not assume a valid
MARC::Record object.

> In the case of the staff client, I got a 404 both before/after trying the
> patch, so I'm not sure that it's necessary. I imagine that there must
> already be checking higher up in showmarc.pl?
Really? I got the following 500 error on an wrong biblio number:
Can't call method "as_formatted" on an undefined value at
/usr/share/koha/testclone/catalogue/showmarc.pl line 82.
You should be able to repeat this error in current master..

-- 
You are receiving this mail because:
You are watching all bug changes.