[Koha-bugs] [Bug 11312] Add span to facets (for css selection)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I tested and saw some small issues that could be fixed in a follow up. As we
don't have bootstrap in 3.12 the boostrap follow up would be best as a separate
patch.

INTRANET & PROG OPAC
The span for the author facet is not closing correctly:
+[% IF facets_loo.type_label_Authors %]<span id="facet-authors"Authors</span>[%
END %]

Also it would be nice, if all use were following the same naming schema. Most
ids use a minus, but we have 2 using an underscore instead.

BOOTSTRAP
The HTML structure here is a bit different than for the other 2 themes. The
patch adds a span inside a h5 tag. It would be cleaner, if we changed it, so
the h5 tag has the id. In order to do that the <h5> before and the </h5> after
the facet block can be deleted and the span has to be changed to h5. The result
would look someting like this:

[% IF ( facets_loo.type_label_Topics ) %]<h5 id="facets-Topics">Topics</h5>[%
END %]

We could also standardize the naming scheme a bit more, by using all lowercase
ids. This way it would be the same ids for all 3 templates.

-- 
You are receiving this mail because:
You are watching all bug changes.