[Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #8)
> Two things I noticed when I tested.
> 1) The order of the system preference text box was changed. I don't think
> that is problem, but felt I should note that.

Just looking at the patch, I do not understand your remark.

> 2) I noticed the default was 0. Should it be 0, or should it be blank? Since
> this is really outside the scope of updating the explanation, I'm ignoring
> it, even if it is a potential problem.

I agree that it should be blank. In the code I see a split on this pref without
further testing. (May not harm, but correcting it is better.) Although you
formally could say that it is actually outside report scope, I would like to
ask Jonathan to just handle this tiny 'bug' within the same db revision (in the
same update statement). No need to touch the same code in two reports.
For this reason setting it to Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.