[Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24188|0                           |1
        is obsolete|                            |

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 24492
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24492&action=edit
Bug 11096: force XML syntax for Zebra in DOM

This patch makes Koha <-> Zebra use MARCXML for the serialization. We
currently use the USMARC, which remains for GRS-1.

This functions are modified for that purpose:
- C4::Context->Zconn
- C4::Context-_new_Zconn
- C4::Search->*
- C4::AuthoritiesMarc->SearchAuthorities
- C4::AuthoritiesMarc->merge
- C4::AuthoritiesMarc->FindDuplicateAuthority

    C4::Context->config('zebra_bib_index_mode')
and C4::Context->config('zebra_auth_index_mode')

Calls to the unsafe ZOOM::Record->render()[2] method are removed.
Due to this last change the code for building facets was rewritten. And for
performance on the facets creation I pushed higher version dependencies for
MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string).

Calls to MARC::Record->new_from_xml and MARC::Record->new_from_usmarc are
wrapped with
eval for catching problems [2].

To test:
 - prove t/db_dependent/Search.t should pass.
 - Searching should remain functional.
 - Indexing and searching for a big record should work (that's what the unit
tests do).

Regards
To+

[1] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()
[2] a record that cannot be parsed by MARC::Record is simply skipped (bug
10684)

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Passes koha-qa.pl, all unit test. Works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.