[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #19 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
::: C4/Items.pm
@@ +2782,5 @@
>                              push @authorised_values, $itemtype;
>                              $authorised_lib{$itemtype} = $description;
> +
> +                            # If we have default value named itemtype or itemtypes, we use it
> +                            $defaultvalue = $itemtype if ($defaultvalues and ($defaultvalues->{'itemtypes'} eq $itemtype or $defaultvalues->{'itemtype'} eq $itemtype));

and 

@@ +2814,5 @@
>                              $authorised_lib{$value} = $lib;
> +
> +                            # If we have a default value that has the same name as the authorised value category of the field,
> +                            # we use it
> +                            $defaultvalue = $value if ($defaultvalues and $defaultvalues->{$tagslib->{$tag}->{$subfield}->{authorised_value}} and $defaultvalues->{$tagslib->{$tag}->{$subfield}->{authorised_value}} eq $value);

and

::: serials/subscription-add.pl
@@ +153,5 @@
>  # prepare template variables common to all $op conditions:
> +my $shelflocations = GetKohaAuthorisedValues( 'items.location', '' );
> +
> +my @locationarg =
> +  map { { code => $_, value => $shelflocations->{$_}, selected => ( ( $subs->{location} and $_ eq $subs->{location} ) ? "selected=\"selected\"" : "" ), } } sort keys %{$shelflocations};

-> You're right, this is not needed.

::: C4/Serials.pm
@@ +926,5 @@
> +
> +    return $return;
> +}
> +
> +

-> Why do you quote this part specifically? The patch adds the whole
GetPreviousSerialid, which return is needed. Am I missing something here?


Please combine into one single database update and add an AFTER reneweddate to
ensure that the sequence of fields is the same on new and updated
installations.

-> done

It's not clear, which status will be used from the description - What is the
first, and what is the second status? Which fields will be used? 

-> when makePreviousSerialAvailable is enabled, when receiving a new serial,
notforloan will be set to 0 and the itype will be set to previousitemtype for
previously received serial. Are these the points I should make more explicit?

Could it be an option to make this pref a bit more configurable, behaving like
AcqItemSetSubfieldsWhenReceived?

-> If I'm not mistaken, AcqItemSetSubfieldsWhenReceived applies to the serial
we just received, as makePreviousSerialAvailable applies to the one that was
received before (just to make things clear). 

But besides that, if there are use-cases where other fields than notforloan and
itype have to be used, it might be useful to have something more configurable.
Is it so?


This is a bigger problem: I think copynumber is used in MARC21 to indicate
different copies of the same book. The enumchron field is used for the
information about issue and year. For MARC21 serialseq is now copied into both
fields. I think we can't leave it that way. My suggestion would be to use
enumchron for UNIMARC as well or make this marcflavour dependent.

-> using enumchron for UNIMARC as well makes sense. Done.

Tiny capitalization issue - "Item".
As this is on the subscription form, we could maybe leave out "serial" and
shorten the description ab it. Also "Serial" is missing from the first field.

-> done

What is 'NEW' referring to? In my tests the change for the itemtype worked, but
I couldn't figure out, how the status change is supposed to work.

-> 'NEW' is previously set by koha : 
$cell->{'serialid'}       = 'NEW';
(serials/serials-edit.pl:185)

-- 
You are receiving this mail because:
You are watching all bug changes.