[Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24666|0                           |1
        is obsolete|                            |

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 24667
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24667&action=edit
Bug 11587 - IsSuperLibrarian generates warnings

This corrects line 1250 of C4/Context.pm to be:
    return ($userenv->{flags}//0) % 2;
And thus avoids an uninitialized value used in the modulus.

TEST PLAN
---------
1) Apply the first patch (to update t/Context.t)
2) prove -v t/Context.t
-- This should fail tests 7 and 8
3) Apply this patch (to fix C4/Context.pm)
4) prove -v t/Context.t
-- All tests should succeed

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.