[Koha-bugs] [Bug 11491] Extending report service to have header

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11491

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24909|0                           |1
        is obsolete|                            |

--- Comment #11 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 24911
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24911&action=edit
Bug 11491 - Missing field names in JSON data

Added a parameter (annotated), which when non-empty will generate
an array of hashes that include the field names as keys, not
the typical array of field values, for the JSON output.

Added functionality to staff svc/report as well.

Moved code around to make diffs between svc/report and
opac/svc/report smaller.

TEST PLAN
---------
 1) Apply the patch
 2) ~/qa-test-tools/koha-qa.pl -v 2 -c 2
    NOTE: There are two patches, but you could just test 1.
 3) Log into staff client
 4) Reports
 5) Used save reports
 6) Click the Action button on any report
     WITHOUT PARAMETERS.
    -- with parameters blows up in master and this.
 7) Click Edit
 8) Make the report public
 9) Update the SQL
10) Note the ID number of the report
11) Note the ID number of a non-public report
12) In a new tab use the number from step 9.
     https://OPAC/cgi-bin/koha/svc/report?id=##
    -- matches default master report.
     https://OPAC/cgi-bin/koha/svc/report?id=##&annotated=1
    -- has hash where the keys are the field name.
     https://STAFF/cgi-bin/koha/svc/report?id=##
    -- matches default master report.
     https://STAFF/cgi-bin/koha/svc/report?id=##&annotated=1
    -- has hash where the keys are the field name.
13) In a new tab use the number from step 10.
     https://OPAC/cgi-bin/koha/svc/report?id=##
    -- matches the warning from master.
     https://OPAC/cgi-bin/koha/svc/report?id=##&annotated=1
    -- matches the warning from master.
     https://STAFF/cgi-bin/koha/svc/report?id=##
    -- matches default master report.
     https://STAFF/cgi-bin/koha/svc/report?id=##&annotated=1
    -- has hash where the keys are the field name.
14) In a new tab use a crazy number like 9675309 such that
    the report does not exist.
     https://OPAC/cgi-bin/koha/svc/report?id=##
    -- tells you the report doesn't exist vs.
       master giving a Software error.
     https://OPAC/cgi-bin/koha/svc/report?id=##&annotated=1
    -- tells you the report doesn't exist vs.
       master giving a Software error.
     https://STAFF/cgi-bin/koha/svc/report?id=##
    -- tells you the report doesn't exist vs.
       master giving a Software error.
     https://STAFF/cgi-bin/koha/svc/report?id=##&annotated=1
    -- tells you the report doesn't exist vs.
       master giving a Software error.

-- 
You are receiving this mail because:
You are watching all bug changes.